Eric Blake
f105627992
snapshot: Drop virDomainSnapshotDef.current
...
The only use for the 'current' member of virDomainSnapshotDef was with
the PARSE/FORMAT_INTERNAL flag for controlling an internal-use
<active> element marking whether a particular snapshot definition was
current, and even then, only by the qemu driver on output, and by qemu
and test driver on input. But this duplicates vm->snapshot_current,
and gets in the way of potential simplifications to have qemu store a
single file for all snapshots rather than one file per snapshot. Get
rid of the member by adding a bool* parameter during parse (ignored if
the PARSE_INTERNAL flag is not set), and by adding a new flag during
format (if FORMAT_INTERNAL is set, the value printed in <active>
depends on the new FORMAT_CURRENT).
Then update the qemu driver accordingly, which involves hoisting
assignments to vm->current_snapshot to occur prior to any point where
a snapshot XML file is written (although qemu kept
vm->current_snapshot and snapshot->def_current in sync by the end of
the function, they were not always identical in the middle of
functions, so the shuffling gets a bit interesting). Later patches
will clean up some of that confusing churn to vm->current_snapshot.
Note: even if later patches refactor qemu to no longer use
FORMAT_INTERNAL for output (by storing bulk snapshot XML instead), we
will always need PARSE_INTERNAL for input (because on upgrade, a new
libvirt still has to parse XML left from a previous libvirt).
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
2019-03-22 01:15:20 -05:00
..
2018-05-13 13:38:31 +04:00
2019-02-24 13:20:51 +04:00
2019-02-24 13:20:51 +04:00
2018-12-03 14:31:41 +01:00
2018-12-17 15:02:11 +00:00
2019-03-05 14:47:49 +01:00
2019-03-18 10:51:02 -04:00
2017-11-07 14:58:04 +01:00
2018-03-13 13:54:06 +01:00
2018-11-14 12:18:46 -05:00
2018-02-02 14:51:32 +01:00
2019-03-13 12:06:52 -06:00
2019-03-06 15:53:53 +01:00
2019-02-21 13:06:16 -05:00
2019-01-29 13:37:11 +00:00
2019-02-01 12:57:13 -05:00
2019-02-01 12:57:13 -05:00
2019-03-18 11:14:58 +03:00
2017-12-07 09:21:04 +00:00
2017-12-07 09:21:04 +00:00
2017-12-05 14:52:49 +01:00
2018-08-28 11:49:01 +01:00
2018-07-10 13:37:51 +02:00
2019-03-04 11:08:40 -05:00
2019-02-05 17:15:05 +01:00
2019-03-12 15:29:44 +01:00
2017-11-30 16:49:05 +01:00
2019-02-14 09:22:17 +01:00
2019-02-14 09:22:17 +01:00
2018-08-13 15:50:01 +02:00
2018-04-17 12:45:26 -04:00
2018-08-21 15:46:06 +02:00
2019-03-15 16:41:26 +01:00
2019-03-12 16:09:55 +01:00
2019-03-13 12:06:52 -06:00
2019-03-07 12:01:09 +01:00
2019-01-29 19:16:19 -05:00
2019-03-19 16:46:21 +01:00
2019-03-19 16:46:21 +01:00
2018-05-25 09:32:37 -04:00
2018-12-17 14:43:33 +00:00
2018-12-17 14:43:33 +00:00
2019-03-06 11:12:48 -05:00
2018-03-14 17:43:40 +01:00
2018-09-20 13:06:02 -04:00
2018-10-05 15:53:29 +02:00
2017-10-16 10:22:34 +01:00
2019-02-26 11:41:18 +01:00
2018-08-14 15:52:35 +02:00
2018-08-13 15:50:01 +02:00
2018-02-02 13:00:48 +00:00
2018-06-26 11:22:07 +01:00
2018-08-13 14:19:41 -04:00
2018-04-20 09:09:29 +02:00
2019-03-13 12:06:52 -06:00
2019-03-13 12:06:52 -06:00
2018-04-09 11:33:30 -06:00
2018-04-20 09:11:01 +02:00
2018-02-19 13:15:00 -05:00
2018-05-13 13:38:31 +04:00
2018-02-22 13:52:45 +01:00
2019-02-24 13:20:51 +04:00
2019-02-24 13:20:51 +04:00
2018-08-15 10:15:29 +02:00
2018-09-20 10:16:39 +02:00
2018-12-17 15:02:11 +00:00
2019-03-05 14:47:49 +01:00
2019-02-11 17:40:44 -05:00
2019-03-18 12:40:03 -04:00
2018-12-13 16:08:38 +00:00
2019-03-22 01:15:20 -05:00
2018-09-20 10:16:39 +02:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-08-15 10:15:29 +02:00
2018-11-14 12:18:46 -05:00
2018-04-26 13:39:10 +02:00
2018-09-20 10:16:39 +02:00
2018-07-27 15:44:38 +02:00
2019-02-11 17:40:44 -05:00
2019-03-14 10:05:25 +01:00
2018-12-11 15:03:08 -05:00
2018-09-20 10:16:39 +02:00
2019-03-14 20:47:15 -04:00
2019-03-08 14:59:20 +01:00
2019-01-31 17:45:41 +01:00
2019-03-14 10:05:25 +01:00
2019-01-31 17:45:41 +01:00
2018-09-20 10:16:39 +02:00
2018-09-20 10:16:39 +02:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-14 10:47:13 +00:00
2019-03-14 10:05:25 +01:00
2018-09-20 10:16:39 +02:00
2018-12-13 16:08:38 +00:00
2018-12-17 17:52:46 +01:00
2017-09-19 16:04:53 +02:00
2018-09-20 10:16:39 +02:00
2018-08-13 15:50:01 +02:00
2018-09-20 10:16:39 +02:00
2019-03-20 08:17:05 +01:00
2019-03-18 15:49:47 +01:00
2018-12-13 16:08:38 +00:00
2019-03-13 11:07:12 +01:00
2018-06-19 14:01:14 +02:00
2018-12-14 10:47:13 +00:00
2018-12-13 16:08:38 +00:00
2018-08-13 15:50:01 +02:00
2018-12-14 10:47:13 +00:00
2019-03-13 14:16:46 +01:00
2019-02-14 09:22:17 +01:00
2019-03-14 10:05:25 +01:00
2018-12-14 10:47:13 +00:00
2018-12-14 10:47:13 +00:00
2018-12-14 10:47:13 +00:00
2018-12-14 10:47:13 +00:00
2018-12-19 15:32:43 +01:00
2018-12-19 15:32:43 +01:00
2018-12-19 15:32:43 +01:00
2019-01-24 18:59:38 -05:00
2019-03-21 12:43:02 -04:00
2019-03-12 16:09:55 +01:00
2018-11-16 13:42:39 +01:00
2018-09-20 10:16:39 +02:00
2018-09-20 10:16:39 +02:00
2018-12-05 10:39:54 +01:00
2018-11-16 13:42:39 +01:00
2018-09-20 10:16:39 +02:00
2018-09-20 10:16:39 +02:00
2018-09-20 10:16:39 +02:00
2018-09-20 10:16:39 +02:00
2018-12-13 16:08:38 +00:00
2019-02-12 08:51:23 -05:00
2019-03-07 12:12:11 +01:00
2019-02-12 13:11:36 -05:00
2019-03-19 16:46:21 +01:00
2019-02-12 08:51:23 -05:00
2019-02-12 08:51:23 -05:00
2018-12-14 10:47:13 +00:00
2019-03-14 10:05:21 +01:00
2019-02-20 15:54:41 +01:00
2018-12-14 10:47:13 +00:00
2018-09-20 10:16:39 +02:00
2018-12-14 10:47:13 +00:00
2019-03-13 11:07:10 +01:00
2019-03-13 11:07:10 +01:00
2018-07-13 14:15:59 +02:00
2018-12-14 10:47:13 +00:00
2018-11-26 16:38:26 -07:00
2018-12-14 10:47:13 +00:00
2018-09-20 10:16:39 +02:00
2018-09-20 10:16:39 +02:00
2018-12-13 16:08:38 +00:00
2018-02-05 16:08:57 +01:00
2019-02-22 10:05:45 +01:00
2018-12-13 16:08:38 +00:00
2018-09-20 10:16:39 +02:00
2018-12-13 16:08:38 +00:00
2018-12-14 10:47:13 +00:00
2018-09-20 10:16:39 +02:00
2018-06-05 14:32:36 +02:00
2018-12-13 16:08:38 +00:00
2018-12-14 10:47:13 +00:00
2018-12-13 16:08:38 +00:00
2018-12-17 17:52:46 +01:00
2018-12-18 10:12:09 -05:00
2019-02-03 17:46:29 -05:00
2019-02-26 11:41:18 +01:00
2019-02-26 11:41:18 +01:00
2019-03-13 14:16:27 +01:00
2019-03-13 14:15:35 +01:00
2019-02-01 12:08:37 -05:00
2018-12-14 10:47:13 +00:00
2018-12-05 10:39:54 +01:00
2018-12-14 10:47:13 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-14 10:47:13 +00:00
2018-09-20 10:16:39 +02:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2019-02-14 18:03:10 +01:00
2018-12-13 16:08:38 +00:00
2017-11-03 13:24:12 +01:00
2018-12-13 16:08:38 +00:00
2019-03-07 13:40:17 +01:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-14 10:47:13 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-14 10:47:13 +00:00
2018-12-13 16:08:38 +00:00
2018-04-24 11:02:28 +02:00
2018-09-20 10:16:39 +02:00
2019-03-18 11:14:37 +03:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-14 10:47:13 +00:00
2018-12-13 16:08:38 +00:00
2019-03-14 10:05:28 +01:00
2019-03-14 10:05:25 +01:00
2018-10-12 09:30:56 -05:00
2019-03-14 10:05:28 +01:00
2019-02-18 10:31:21 +01:00
2019-02-12 08:51:23 -05:00
2018-12-13 16:08:38 +00:00
2018-12-14 10:47:13 +00:00
2019-01-23 07:54:58 +01:00
2019-03-14 10:05:28 +01:00
2018-12-13 16:08:38 +00:00
2018-09-20 10:16:38 +02:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-12-13 16:08:38 +00:00
2018-09-20 10:16:39 +02:00
2018-09-20 10:16:39 +02:00
2019-02-12 10:14:53 +01:00
2019-03-13 12:06:52 -06:00
2018-12-13 16:08:38 +00:00
2018-09-20 10:16:39 +02:00
2018-09-20 10:16:39 +02:00