mirror of
				https://github.com/softprops/action-gh-release.git
				synced 2025-11-04 05:39:24 +00:00 
			
		
		
		
	Compare commits
	
		
			9 Commits
		
	
	
		
			v2.4.0
			...
			dependabot
		
	
	| Author | SHA1 | Date | |
|---|---|---|---|
| 
						 | 
					0d3324bd4e | ||
| 
						 | 
					0adea5aa98 | ||
| 
						 | 
					aa05f9d779 | ||
| 
						 | 
					bbaccb3a0c | ||
| 
						 | 
					50fda3f773 | ||
| 
						 | 
					5434409c2b | ||
| 
						 | 
					6da8fa9354 | ||
| 
						 | 
					f38efdea4c | ||
| 
						 | 
					cec1a1113b | 
							
								
								
									
										2
									
								
								.github/workflows/main.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										2
									
								
								.github/workflows/main.yml
									
									
									
									
										vendored
									
									
								
							@@ -10,7 +10,7 @@ jobs:
 | 
			
		||||
    steps:
 | 
			
		||||
      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
 | 
			
		||||
 | 
			
		||||
      - uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v4
 | 
			
		||||
      - uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6
 | 
			
		||||
        with:
 | 
			
		||||
          node-version-file: ".tool-versions"
 | 
			
		||||
          cache: "npm"
 | 
			
		||||
 
 | 
			
		||||
@@ -1,3 +1,12 @@
 | 
			
		||||
## 2.4.1
 | 
			
		||||
 | 
			
		||||
## What's Changed
 | 
			
		||||
 | 
			
		||||
### Other Changes 🔄
 | 
			
		||||
 | 
			
		||||
* fix(util): support brace expansion globs containing commas in parseInputFiles by @Copilot in https://github.com/softprops/action-gh-release/pull/672
 | 
			
		||||
* fix: gracefully fallback to body when body_path cannot be read by @Copilot in https://github.com/softprops/action-gh-release/pull/671
 | 
			
		||||
 | 
			
		||||
## 2.4.0
 | 
			
		||||
 | 
			
		||||
## What's Changed
 | 
			
		||||
 
 | 
			
		||||
@@ -39,6 +39,18 @@ describe('util', () => {
 | 
			
		||||
        'loom',
 | 
			
		||||
      ]);
 | 
			
		||||
    });
 | 
			
		||||
    it('handles globs with brace groups containing commas', () => {
 | 
			
		||||
      assert.deepStrictEqual(parseInputFiles('./**/*.{exe,deb,tar.gz}\nfoo,bar'), [
 | 
			
		||||
        './**/*.{exe,deb,tar.gz}',
 | 
			
		||||
        'foo',
 | 
			
		||||
        'bar',
 | 
			
		||||
      ]);
 | 
			
		||||
    });
 | 
			
		||||
    it('handles single-line brace pattern correctly', () => {
 | 
			
		||||
      assert.deepStrictEqual(parseInputFiles('./**/*.{exe,deb,tar.gz}'), [
 | 
			
		||||
        './**/*.{exe,deb,tar.gz}',
 | 
			
		||||
      ]);
 | 
			
		||||
    });
 | 
			
		||||
  });
 | 
			
		||||
  describe('releaseBody', () => {
 | 
			
		||||
    it('uses input body', () => {
 | 
			
		||||
@@ -110,6 +122,52 @@ describe('util', () => {
 | 
			
		||||
        }),
 | 
			
		||||
      );
 | 
			
		||||
    });
 | 
			
		||||
    it('falls back to body when body_path is missing', () => {
 | 
			
		||||
      assert.equal(
 | 
			
		||||
        releaseBody({
 | 
			
		||||
          github_ref: '',
 | 
			
		||||
          github_repository: '',
 | 
			
		||||
          github_token: '',
 | 
			
		||||
          input_body: 'fallback-body',
 | 
			
		||||
          input_body_path: '__tests__/does-not-exist.txt',
 | 
			
		||||
          input_draft: false,
 | 
			
		||||
          input_prerelease: false,
 | 
			
		||||
          input_files: [],
 | 
			
		||||
          input_overwrite_files: undefined,
 | 
			
		||||
          input_preserve_order: undefined,
 | 
			
		||||
          input_name: undefined,
 | 
			
		||||
          input_tag_name: undefined,
 | 
			
		||||
          input_target_commitish: undefined,
 | 
			
		||||
          input_discussion_category_name: undefined,
 | 
			
		||||
          input_generate_release_notes: false,
 | 
			
		||||
          input_make_latest: undefined,
 | 
			
		||||
        }),
 | 
			
		||||
        'fallback-body',
 | 
			
		||||
      );
 | 
			
		||||
    });
 | 
			
		||||
    it('returns undefined when body_path is missing and body is not provided', () => {
 | 
			
		||||
      assert.equal(
 | 
			
		||||
        releaseBody({
 | 
			
		||||
          github_ref: '',
 | 
			
		||||
          github_repository: '',
 | 
			
		||||
          github_token: '',
 | 
			
		||||
          input_body: undefined,
 | 
			
		||||
          input_body_path: '__tests__/does-not-exist.txt',
 | 
			
		||||
          input_draft: false,
 | 
			
		||||
          input_prerelease: false,
 | 
			
		||||
          input_files: [],
 | 
			
		||||
          input_overwrite_files: undefined,
 | 
			
		||||
          input_preserve_order: undefined,
 | 
			
		||||
          input_name: undefined,
 | 
			
		||||
          input_tag_name: undefined,
 | 
			
		||||
          input_target_commitish: undefined,
 | 
			
		||||
          input_discussion_category_name: undefined,
 | 
			
		||||
          input_generate_release_notes: false,
 | 
			
		||||
          input_make_latest: undefined,
 | 
			
		||||
        }),
 | 
			
		||||
        undefined,
 | 
			
		||||
      );
 | 
			
		||||
    });
 | 
			
		||||
  });
 | 
			
		||||
  describe('parseConfig', () => {
 | 
			
		||||
    it('parses basic config', () => {
 | 
			
		||||
@@ -432,3 +490,36 @@ describe('util', () => {
 | 
			
		||||
    });
 | 
			
		||||
  });
 | 
			
		||||
});
 | 
			
		||||
 | 
			
		||||
describe('parseInputFiles edge cases', () => {
 | 
			
		||||
  it('handles multiple brace groups on same line', () => {
 | 
			
		||||
    assert.deepStrictEqual(parseInputFiles('./**/*.{exe,deb},./dist/**/*.{zip,tar.gz}'), [
 | 
			
		||||
      './**/*.{exe,deb}',
 | 
			
		||||
      './dist/**/*.{zip,tar.gz}',
 | 
			
		||||
    ]);
 | 
			
		||||
  });
 | 
			
		||||
 | 
			
		||||
  it('handles nested braces', () => {
 | 
			
		||||
    assert.deepStrictEqual(parseInputFiles('path/{a,{b,c}}/file.txt'), ['path/{a,{b,c}}/file.txt']);
 | 
			
		||||
  });
 | 
			
		||||
 | 
			
		||||
  it('handles empty comma-separated values', () => {
 | 
			
		||||
    assert.deepStrictEqual(parseInputFiles('foo,,bar'), ['foo', 'bar']);
 | 
			
		||||
  });
 | 
			
		||||
 | 
			
		||||
  it('handles commas with spaces around braces', () => {
 | 
			
		||||
    assert.deepStrictEqual(parseInputFiles(' ./**/*.{exe,deb} , file.txt '), [
 | 
			
		||||
      './**/*.{exe,deb}',
 | 
			
		||||
      'file.txt',
 | 
			
		||||
    ]);
 | 
			
		||||
  });
 | 
			
		||||
 | 
			
		||||
  it('handles mixed newlines and commas with braces', () => {
 | 
			
		||||
    assert.deepStrictEqual(parseInputFiles('file1.txt\n./**/*.{exe,deb},file2.txt\nfile3.txt'), [
 | 
			
		||||
      'file1.txt',
 | 
			
		||||
      './**/*.{exe,deb}',
 | 
			
		||||
      'file2.txt',
 | 
			
		||||
      'file3.txt',
 | 
			
		||||
    ]);
 | 
			
		||||
  });
 | 
			
		||||
});
 | 
			
		||||
 
 | 
			
		||||
							
								
								
									
										2
									
								
								dist/index.js
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										2
									
								
								dist/index.js
									
									
									
									
										vendored
									
									
								
							
										
											
												File diff suppressed because one or more lines are too long
											
										
									
								
							
							
								
								
									
										1121
									
								
								package-lock.json
									
									
									
										generated
									
									
									
								
							
							
						
						
									
										1121
									
								
								package-lock.json
									
									
									
										generated
									
									
									
								
							
										
											
												File diff suppressed because it is too large
												Load Diff
											
										
									
								
							
							
								
								
									
										12
									
								
								package.json
									
									
									
									
									
								
							
							
						
						
									
										12
									
								
								package.json
									
									
									
									
									
								
							@@ -1,6 +1,6 @@
 | 
			
		||||
{
 | 
			
		||||
  "name": "action-gh-release",
 | 
			
		||||
  "version": "2.4.0",
 | 
			
		||||
  "version": "2.4.1",
 | 
			
		||||
  "private": true,
 | 
			
		||||
  "description": "GitHub Action for creating GitHub Releases",
 | 
			
		||||
  "main": "lib/main.js",
 | 
			
		||||
@@ -24,21 +24,21 @@
 | 
			
		||||
  "dependencies": {
 | 
			
		||||
    "@actions/core": "^1.11.1",
 | 
			
		||||
    "@actions/github": "^6.0.1",
 | 
			
		||||
    "@octokit/plugin-retry": "^8.0.2",
 | 
			
		||||
    "@octokit/plugin-throttling": "^11.0.2",
 | 
			
		||||
    "@octokit/plugin-retry": "^8.0.3",
 | 
			
		||||
    "@octokit/plugin-throttling": "^11.0.3",
 | 
			
		||||
    "glob": "^11.0.3",
 | 
			
		||||
    "mime-types": "^3.0.1"
 | 
			
		||||
  },
 | 
			
		||||
  "devDependencies": {
 | 
			
		||||
    "@types/glob": "^9.0.0",
 | 
			
		||||
    "@types/mime-types": "^3.0.1",
 | 
			
		||||
    "@types/node": "^20.19.19",
 | 
			
		||||
    "@types/node": "^20.19.24",
 | 
			
		||||
    "@vercel/ncc": "^0.38.4",
 | 
			
		||||
    "@vitest/coverage-v8": "^3.2.4",
 | 
			
		||||
    "@vitest/coverage-v8": "^4.0.6",
 | 
			
		||||
    "prettier": "3.6.2",
 | 
			
		||||
    "ts-node": "^10.9.2",
 | 
			
		||||
    "typescript": "^5.9.3",
 | 
			
		||||
    "typescript-formatter": "^7.2.2",
 | 
			
		||||
    "vitest": "^3.1.4"
 | 
			
		||||
    "vitest": "^4.0.4"
 | 
			
		||||
  }
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
							
								
								
									
										54
									
								
								src/util.ts
									
									
									
									
									
								
							
							
						
						
									
										54
									
								
								src/util.ts
									
									
									
									
									
								
							@@ -35,23 +35,53 @@ export const uploadUrl = (url: string): string => {
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
export const releaseBody = (config: Config): string | undefined => {
 | 
			
		||||
  return (
 | 
			
		||||
    (config.input_body_path && readFileSync(config.input_body_path).toString('utf8')) ||
 | 
			
		||||
    config.input_body
 | 
			
		||||
  );
 | 
			
		||||
  if (config.input_body_path) {
 | 
			
		||||
    try {
 | 
			
		||||
      const contents = readFileSync(config.input_body_path, 'utf8');
 | 
			
		||||
      return contents;
 | 
			
		||||
    } catch (err: any) {
 | 
			
		||||
      console.warn(
 | 
			
		||||
        `⚠️ Failed to read body_path "${config.input_body_path}" (${err?.code ?? 'ERR'}). Falling back to 'body' input.`,
 | 
			
		||||
      );
 | 
			
		||||
    }
 | 
			
		||||
  }
 | 
			
		||||
  return config.input_body;
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
type Env = { [key: string]: string | undefined };
 | 
			
		||||
 | 
			
		||||
const smartSplit = (input: string): string[] => {
 | 
			
		||||
  const result: string[] = [];
 | 
			
		||||
  let current = '';
 | 
			
		||||
  let braceDepth = 0;
 | 
			
		||||
 | 
			
		||||
  for (const ch of input) {
 | 
			
		||||
    if (ch === '{') {
 | 
			
		||||
      braceDepth++;
 | 
			
		||||
    }
 | 
			
		||||
    if (ch === '}') {
 | 
			
		||||
      braceDepth--;
 | 
			
		||||
    }
 | 
			
		||||
    if (ch === ',' && braceDepth === 0) {
 | 
			
		||||
      if (current.trim()) {
 | 
			
		||||
        result.push(current.trim());
 | 
			
		||||
      }
 | 
			
		||||
      current = '';
 | 
			
		||||
    } else {
 | 
			
		||||
      current += ch;
 | 
			
		||||
    }
 | 
			
		||||
  }
 | 
			
		||||
  if (current.trim()) {
 | 
			
		||||
    result.push(current.trim());
 | 
			
		||||
  }
 | 
			
		||||
  return result;
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
export const parseInputFiles = (files: string): string[] => {
 | 
			
		||||
  return files.split(/\r?\n/).reduce<string[]>(
 | 
			
		||||
    (acc, line) =>
 | 
			
		||||
      acc
 | 
			
		||||
        .concat(line.split(','))
 | 
			
		||||
        .filter((pat) => pat)
 | 
			
		||||
        .map((pat) => pat.trim()),
 | 
			
		||||
    [],
 | 
			
		||||
  );
 | 
			
		||||
  return files
 | 
			
		||||
    .split(/\r?\n/)
 | 
			
		||||
    .flatMap((line) => smartSplit(line))
 | 
			
		||||
    .filter((pat) => pat.trim() !== '');
 | 
			
		||||
};
 | 
			
		||||
 | 
			
		||||
export const parseConfig = (env: Env): Config => {
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user