Mark McLoughlin
a0f83fd905
* src/xen_internal.c: Don't crash if there's no /sys/hypervisor/capabilities
2008-02-07 10:43:14 +00:00
Mark McLoughlin
3d3c8ac4c4
src/iptables.c: Create directory for saving iptables rules
2008-02-07 10:17:24 +00:00
Mark McLoughlin
f90cd4c3f4
src/xm_internal.[ch]: Move static function prototype from header
2008-02-07 10:14:43 +00:00
Daniel Veillard
b33f740e1f
* src/libvirt.c: fix bug in xenUnifiedDomainSuspend() patch provided
...
by Marcus Meissner
Daniel
2008-02-07 09:37:10 +00:00
Daniel Veillard
594af3eb22
add/change/delete a Disk/NIC of an inactive domains
...
* src/xm_internal.[ch]: applied patch from Shigeki Sakamoto to
add/change/delete a Disk/NIC of an inactive domains
Daniel
2008-02-06 17:57:10 +00:00
Daniel Veillard
eecd68364a
QEmu config error handling fixes
...
* src/qemu_conf.c: applied 2 patches from Guido Guenther to avoid
crashes when reading the config file
Daniel
2008-02-06 16:24:28 +00:00
Jim Meyering
5419d0b44d
Fix new "make distcheck" failures.
...
* src/xml.c (virDomainParseXMLOSDescHVM): Mark a diagnostic.
2008-02-05 22:07:31 +00:00
Jim Meyering
e04912a9f0
Remove all trailing blanks; turn on the rule to detect them.
...
* Makefile.cfg (local-checks-to-skip): Remove sc_trailing_blank.
* .x-sc_trailing_blank: New file, to exempt the few binary files.
2008-02-05 19:27:37 +00:00
Daniel P. Berrange
e87e3f86bf
Added support for booting off kenrel+initrd with HVM guests
2008-02-05 16:21:25 +00:00
Jim Meyering
fb66d5ab92
Eliminate all uses of virBufferAdd with string literals.
...
* Makefile.maint (sc_prohibit_virBufferAdd_with_string_literal):
New rule.
* src/buf.h (virBufferAddLit): Define.
* src/conf.c (virConfSaveValue): Use virBufferAddLit, in place
of virBufferAdd everywhere possible.
(virConfSaveEntry): Likewise.
* src/qemu_conf.c (qemudGenerateXML, qemudGenerateNetworkXML): Likewise.
* src/qemu_driver.c (qemudGetFeatures, qemudGetCapabilities): Likewise.
* src/test.c (testDomainDumpXML, testNetworkDumpXML): Likewise.
* src/xen_internal.c (xenHypervisorMakeCapabilitiesXML): Likewise.
* src/xend_internal.c (xend_parse_sexp_desc_os): Likewise.
(xend_parse_sexp_desc, sexpr_to_xend_topology_xml): Likewise.
* src/xm_internal.c (xenXMDomainFormatXML, xenXMDomainPinVcpu): Likewise.
* src/xml.c (virSaveCpuSet, virParseXenCpuTopology): Likewise.
(virDomainParseXMLGraphicsDescImage): Likewise.
(virDomainParseXMLGraphicsDescVFB, virDomainParseXMLOSDescHVM): Likewise.
(virDomainParseXMLOSDescPV, virDomainParseXMLDiskDesc): Likewise.
(virDomainParseXMLIfDesc, virDomainParseXMLDesc): Likewise.
2008-02-05 14:22:28 +00:00
Jim Meyering
ecaa696250
Enable more checks for unmarked messages; fix violators.
...
* Makefile.maint (sc_unmarked_diagnostics): Check for more functions.
* src/conf.c (virConfParseValue): Remove trailing space in diagnostic.
* src/libvirt.c (do_open, virDomainMigrate): Mark diagnostics.
* src/xend_internal.c (do_connect, xenDaemonDomainDumpXMLByID): Likewise.
(xenDaemonDomainDumpXMLByName, xenDaemonCreateLinux): Likewise.
(xenDaemonDomainMigratePerform, xenDaemonDomainDefineXML): Likewise.
* src/xml.c (virXPathString, virXPathNumber, virXPathLong): Likewise.
(virXPathBoolean, virXPathNode, virXPathNodeSet): Likewise.
(virDomainParseXMLOSDescHVM): Likewise.
* src/xmlrpc.c (xmlRpcValueNew): Likewise.
(xmlRpcValueUnmarshalDictElement): Likewise.
2008-02-04 19:31:30 +00:00
Jim Meyering
e99570fc77
Mark a string for translation.
...
* src/virsh.c: Add a "%s" and wrap with _(...).
2008-02-04 14:58:47 +00:00
Jim Meyering
70400346d2
Enable the sc_unmarked_diagnostics test and correct all violations
...
involving the "error" function.
* Makefile.cfg (local-checks-to-skip): Remove from skip list.
* src/remote_internal.c: Mark translatable strings.
2008-02-04 14:58:05 +00:00
Jim Meyering
f5f530f33f
Avoid virsh leaks due to missing virDomainFree(dom) calls
...
* src/virsh.c (cmdDomuuid): Add missing virDomainFree call.
(cmdAttachDevice): Likewise.
(cmdDetachDevice): Likewise.
2008-01-30 19:58:59 +00:00
Jim Meyering
a1d2d2b21c
src/virsh.c (cmdCapabilities): Plug a small leak.
2008-01-30 19:57:54 +00:00
Jim Meyering
34dff95bfd
src/test.c (testLoadDomain): Avoid leaks upon failure.
2008-01-30 19:57:13 +00:00
Jim Meyering
1217e5d516
Avoid used-uninitialized errors in test driver.
...
* src/test.c (testOpenFromFile): Initialize "privconn".
2008-01-30 19:54:29 +00:00
Jim Meyering
6997b1920f
src/libvirt.c (do_open): Avoid double-free upon failure.
2008-01-30 19:53:10 +00:00
Jim Meyering
218f866f86
Avoid segfault upon malloc failure, and plug a leak.
...
* src/test.c (testDomainSave): Detect testDomainDumpXML failure. Free "xml".
2008-01-30 19:52:16 +00:00
Jim Meyering
5561e9125f
Plug test-related leaks.
...
* src/test.c (testLoadNetwork): Free forwardDev.
(testLoadDomain): Free ctxt.
(testLoadNetwork): Likewise.
(testOpenFromFile): Likewise.
2008-01-30 19:50:14 +00:00
Daniel P. Berrange
17ef6faa7f
Remove double mutex lock()
2008-01-30 18:21:13 +00:00
Daniel P. Berrange
03003499e7
Fix XML generation for Xen USB devices
2008-01-30 16:38:18 +00:00
Daniel P. Berrange
21416a4746
Fix device name -> number conversion for block stats
2008-01-29 18:36:00 +00:00
Jim Meyering
2367caa327
Also detect and remove unnecessary if-before-xmlXPathFreeContext.
...
* build-aux/find-unnecessary-if-before-free: Update regexp.
* src/openvz_conf.c: Remove unnecessary "if (P)"-before xmlXPathFreeContext.
* src/qemu_conf.c: Likewise.
* src/virsh.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* tests/xmlrpctest.c: Likewise.
2008-01-29 18:23:43 +00:00
Jim Meyering
a378188194
Enable the <config.h>-requiring test; fix violations
...
Use <config.h>, not "config.h", per autoconf documentation.
* Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
* .x-sc_require_config_h: New file, to list exempted files.
* Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
2008-01-29 18:15:54 +00:00
Jim Meyering
acff2d11ac
Given code like if (foo) free (foo); remove the useless "if (foo) " part.
...
Likewise, given if (foo != NULL) free (foo); remove the useless "if" test.
* proxy/libvirt_proxy.c: Remove unnecessary "if" test before free.
* python/generator.py: Likewise.
* qemud/qemud.c: Likewise.
* src/buf.c: Likewise.
* src/conf.c: Likewise.
* src/hash.c: Likewise.
* src/iptables.c: Likewise.
* src/libvirt.c: Likewise.
* src/openvz_conf.c: Likewise.
* src/qemu_conf.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/remote_internal.c: Likewise.
* src/test.c: Likewise.
* src/virsh.c: Likewise.
* src/virterror.c: Likewise.
* src/xen_internal.c: Likewise.
* src/xen_unified.c: Likewise.
* src/xend_internal.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* src/xmlrpc.c: Likewise.
* src/xs_internal.c: Likewise.
* tests/testutils.c: Likewise.
* tests/xencapstest.c: Likewise.
* tests/xmconfigtest.c: Likewise.
2008-01-29 17:41:07 +00:00
Daniel Veillard
aab826d4cc
Fix VIR_DOMAIN_NONE into VIR_DOMAIN_NOSTATE
...
* src/xen_internal.c: fix an erronous use of VIR_DOMAIN_NONE instead
of VIR_DOMAIN_NOSTATE (both defined as 0, no regression)
Daniel
2008-01-25 09:47:51 +00:00
Daniel Veillard
3f9a94bec3
* src/libvirt.c: Jay Gagnon pointed out that virDomainGetXMLDesc
...
was failing with a non-zero flag value
Daniel
2008-01-24 17:09:56 +00:00
Richard W.M. Jones
9cf2573c8a
Portability improvements for Mac OS X.
...
* configure.in: Use PortableXDR if available.
* qemud/internal.h: Use "socketcompat.h".
* qemud/qemud.c: Use <signal.h>.
* src/sexpr.c: Use <stdlib.h> instead of <malloc.h>.
* src/socketcompat.h: Include <sys/un.h> for Mac OS X.
2008-01-23 14:54:41 +00:00
Richard W.M. Jones
569200b6d4
Remove DOS line-endings.
...
* src/socketcompat.h: Remove DOS line-endings in this file.
2008-01-23 14:50:14 +00:00
Daniel P. Berrange
9d7661e415
Fix compat for old pkg-config and gnutls
2008-01-22 21:30:05 +00:00
Daniel P. Berrange
97bed42f7a
Fix & refactor ref counting cleanup code
2008-01-21 16:29:10 +00:00
Daniel P. Berrange
45738083a6
Use virFileReadAll in virsh.c
2008-01-21 15:27:14 +00:00
Daniel P. Berrange
53365f4c54
Remove no-op networking APIs from openvz driver
2008-01-21 15:19:46 +00:00
Jim Meyering
64b3019d69
Adjust sexpr-related interfaces to be const-correct.
...
* src/sexpr.c (sexpr_cons, append, sexpr_append, sexpr2string)
(sexpr_lookup_key, sexpr_lookup, sexpr_node, sexpr_fmt_node):
Add "const" attribute where appropriate.
* src/xend_internal.c (sexpr_int, sexpr_float, sexpr_u64)
(sexpr_uuid, sexpr_to_xend_domain_info, sexpr_to_xend_node_info)
(sexpr_to_xend_topology_xml, sexpr_to_domain): Likewise.
* src/sexpr.h: Adjust prototypes.
2008-01-21 14:22:15 +00:00
Jim Meyering
a430f22be4
Don't access line[-1] for a zero-length "line" from fgets.
...
A NUL byte at beginning of input, or just after a newline
would provoke an invalid buf[-1] access (possible segfault).
* src/libvirt.c (virConnectAuthCallbackDefault):
2008-01-21 14:09:51 +00:00
Daniel Veillard
5912e7c233
Preserve vif order
...
* src/xml-internal.c: apply patch from Hiroyuki Kaguchi to
preserve the vif list order.
Daniel
2008-01-21 08:27:12 +00:00
Daniel P. Berrange
d56aff5255
Added xstrtol_ll and xstrtol_ull convenience functions
2008-01-20 16:11:25 +00:00
Daniel P. Berrange
e05a879022
Fix nodeinfo compat for Xen 3.2.0
2008-01-20 15:56:49 +00:00
Daniel P. Berrange
e8d690aeb5
Enable debug by default, but only if LIBVIRT_DEBUG=1. Use generic macro for debug output
2008-01-19 18:36:01 +00:00
Jim Meyering
42e5d20ae9
Avoid format string warnings.
...
* src/virsh.c: Add "%s" where needed.
* src/proxy_internal.c: Likewise.
2008-01-16 17:13:23 +00:00
Daniel P. Berrange
f6ba6e9eb7
Support VNC keymap option with QEMU (Daniel Hokka Zakrisson)
2008-01-15 15:18:33 +00:00
Daniel P. Berrange
045d32a8e8
Fix off-by-one in SSH argv checking. Fix format string warning
2008-01-15 14:23:52 +00:00
Jim Meyering
2edab512a0
Clean up the global name space.
...
* src/qemu_conf.c: Add "static" and "const" attributes to some globals.
* src/qemu_conf.h: Update a declaration.
* src/qemu_driver.c (qemud_driver): Declare static.
Author: Jim Meyering <meyering@redhat.com>
2008-01-14 14:05:25 +00:00
Daniel P. Berrange
6aae9a9efb
Re-factor auth code to make clearer (Jim Meyering)
2008-01-14 04:05:23 +00:00
Daniel P. Berrange
b2083ea907
Fix crash when no auth callback
2008-01-14 04:00:34 +00:00
Mark McLoughlin
4c50142381
fix an unused variable warning
2008-01-10 14:41:39 +00:00
Mark McLoughlin
73ab4e0845
add iptablesSaveRules(), and don't save the rules to disk
...
and run lokkit each time a new rule is added.
2008-01-10 14:01:00 +00:00
Mark McLoughlin
2d2e410818
now that we only use built-in iptables chains, we don't
...
need to add or delete them
2008-01-10 13:58:59 +00:00
Mark McLoughlin
9b29b2a2a5
Like --with-iptables-prefix, --with-iptables-dir is no
...
longer useful, so let's remove it.
2008-01-10 13:57:48 +00:00