Chris Lalancette
17a9e03cd1
Give iSCSI and disk storage backend drivers the
...
ability to resolve any kind of volume path to the pool target volume
path. For instance, if the pool was defined with a
<target><path>/dev/disk/by-id</path></target> section, and one of the
volumes is /dev/disk/by-id/scsi-S_beaf11, then you would be able to
call virStorageVolLookupByPath("/dev/sdc"), and get the correct volume
back.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-11-03 11:37:11 +00:00
Daniel Veillard
7d3041aff3
* python/virConnect.py: needed for events from the python bindings
...
by Ben Guthro
daniel
2008-10-31 13:56:47 +00:00
Daniel Veillard
ba2dff372c
* src/xm_internal.c: add minimum domain memory size check for Xen
...
patch by Shigeki Sakamoto
* AUTHORS: add Shigeki Sakamoto
Daniel
2008-10-31 13:06:17 +00:00
Daniel Veillard
7b716fce8e
* python/Makefile.am python/generator.py python/libvir.c
...
python/libvir.py python/libvirt_wrap.h python/types.c:
adds support for events from the python bindings, also
improves the generator allowing to embbed per function
definition files, patch by Ben Guthro
* examples/domain-events/events-python/event-test.py: also
adds a programming example
Daniel
2008-10-31 10:13:45 +00:00
Cole Robinson
c5ee075dd9
Add a test storage driver.
2008-10-30 17:40:57 +00:00
Daniel Veillard
f22d0fcd8d
* docs/relatedlinks.html docs/relatedlinks.html.in: add link
...
for AMQP/QPid bindings
daniel
2008-10-29 15:34:12 +00:00
Daniel Veillard
4780a00b14
* src/domain_conf.h src/qemu_driver.c: patch adding hor removal of
...
scsi/virtio disks for KVM, patch by Guido Günther
daniel
2008-10-29 14:32:40 +00:00
Jim Meyering
f79ebbd121
remove src/socketcompat.h; no longer needed
...
* src/socketcompat.h: Remove file.
* src/remote_internal.c: Don't include socketcompat.h.
* qemud/qemud.h: Likewise.
* qemud/remote_protocol.x: Likewise, but do include <arpa/inet.h>
for htonl.
* src/remote_internal.c: Likewise, but do include <errno.h>.
* qemud/remote_protocol.c: Regenererate.
* qemud/remote_protocol.h: Regenererate.
* src/Makefile.am (REMOTE_DRIVER_SOURCES): Remove socketcompat.h.
2008-10-28 19:09:04 +00:00
Jim Meyering
d6efc2ffd3
make generated qemud/*.[ch] files read-only
...
* qemud/Makefile.am (.x.c): Rewrite not to write directly to $@,
and to make generated files read-only.
(.x.h): Likewise.
2008-10-28 17:48:11 +00:00
Jim Meyering
487d57b341
avoid compiler warning when all storage backends are disabled
...
* src/storage_backend.c (backends): Add a NULL terminator.
(virStorageBackendForType): Use NULL terminator rather than
warning-provoking (possibly 0) array size.
2008-10-28 17:48:06 +00:00
Jim Meyering
a6c7f474eb
avoid many mingw-specific warnings
...
* tests/virshtest.c (mymain): Use only one definition of this function.
[WIN32]: Call exit(77) to skip the test.
* tests/nodeinfotest.c: Likewise.
2008-10-28 17:48:01 +00:00
Jim Meyering
57d54689da
cvsignore mingw build artifacts: *.exe
2008-10-28 17:47:54 +00:00
Jim Meyering
2bbf76ebeb
include netinet etc #ifndef HAVE_WINSOCK2_H
2008-10-28 17:47:45 +00:00
Jim Meyering
78d4d969e2
* src/remote_internal.c (remoteFindDaemonPath) [!WIN32]: Don't compile.
2008-10-28 17:47:40 +00:00
Jim Meyering
c5f45efd06
use errno, not socket_errno()
...
* remote_internal.c: s/socket_errno()/errno/, now that gnulib's
socket module ensures errno is useful in those cases.
2008-10-28 17:47:33 +00:00
Jim Meyering
b80b3ce4b3
socketcompat.h: simplify, to match latest gnulib
...
Now, sys/socket.h is always available, and errno works.
2008-10-28 17:47:23 +00:00
Jim Meyering
75e69df956
updates from gnulib
2008-10-28 17:47:12 +00:00
Jim Meyering
c54eb963dd
use more gnulib modules
...
* bootstrap: use more gnulib modules: close, connect, perror, recv,
send, socket setsockopt, gethostname.
2008-10-28 17:46:07 +00:00
Jim Meyering
cabb75c503
adapt to API change in gnulib
...
* qemud/qemud.c: Include <netdb.h>, not "getaddrinfo.h"
* src/remote_internal.c: Likewise.
2008-10-28 17:46:00 +00:00
Jim Meyering
9801d7c595
* src/network_conf.c: Include <string.h> for declaration of memcmp.
2008-10-28 17:45:41 +00:00
Jim Meyering
05589b72c4
use ARRAY_CARDINALITY more
...
* tests/nodeinfotest.c: Include "util.h".
* src/xen_internal.c: Likewise.
* src/qemu_conf.c (qemudCapsInit): Use ARRAY_CARDINALITY.
* src/storage_backend.c (virStorageBackendForType): Likewise.
* src/storage_backend_fs.c (virStorageBackendProbeFile): Likewise.
* src/xen_internal.c (xenHypervisorMakeCapabilitiesInternal): Likewise.
* src/xend_internal.c (xenDaemonParseSxpr): Likewise.
* tests/nodeinfotest.c (mymain): Likewise.
* tests/qparamtest.c (DO_TEST): Likewise.
2008-10-28 17:43:24 +00:00
Jim Meyering
b172c22997
exempt gnulib from write-avoidance syntax check
2008-10-28 17:42:41 +00:00
Jim Meyering
711c5d62d1
exempt gnulib from ctype-macros prohibition
...
Author: Jim Meyering <meyering@redhat.com>
2008-10-28 17:36:31 +00:00
Daniel P. Berrange
b38d045dea
Remove use of sys/poll.h on mingw
2008-10-24 13:10:30 +00:00
Daniel P. Berrange
bfc86e8a74
Fix syntax check errors
2008-10-24 12:05:39 +00:00
Daniel P. Berrange
3091bdd31a
Implement getVersion API for openvz driver
2008-10-24 11:32:48 +00:00
Daniel P. Berrange
6d35116e33
Fix mingw build due to missing icons in tar.gz
2008-10-24 11:31:15 +00:00
Daniel P. Berrange
bdd50bc7f3
Centralize domain mac address handling in domain_conf.c/util.c
2008-10-24 11:20:08 +00:00
Jim Meyering
327b2eea26
fix mingw compilation warning
...
* src/libvirt.c (winsock_init) [HAVE_WINSOCK2_H]: Always return a value.
2008-10-24 08:55:13 +00:00
Chris Lalancette
c402724354
Brown paper bag bug. I didn't preserve the
...
<sources> tags properly, and I didn't put the <source> tag into the
proper place, so I totally changed the output of the discovery XML.
Fix this up to do the right thing.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-10-23 13:21:01 +00:00
Daniel Veillard
1509b8027f
Massive patch adding event APIs by Ben Guthro
...
* include/libvirt/libvirt.h include/libvirt/libvirt.h.in
src/libvirt.c src/libvirt_sym.version: new libvirt event entry
points, big patch provided by Ben Guthro
* Makefile.am configure.in src/driver.h src/event.c src/event.h
src/internal.h src/libvirt.c src/libvirt_sym.version src/lxc_driver.c
src/openvz_driver.c src/qemu_conf.h src/qemu_driver.c
src/remote_internal.c src/storage_backend_fs.c src/test.c
qemud/event.c qemud/event.h qemud/mdns.c qemud/qemud.c
qemud/qemud.h qemud/remote.c qemud/remote_dispatch_localvars.h
qemud/remote_dispatch_proc_switch.h qemud/remote_dispatch_prototypes.h
qemud/remote_protocol.c qemud/remote_protocol.h
qemud/remote_protocol.x proxy/Makefile.am python/generator.py:
Not much is left untouched by the patch adding the events support
* docs/libvirt-api.xml docs/libvirt-refs.xml
docs/html/libvirt-libvirt.html: regenerated the docs
* examples/domain-events/events-c/Makefile.am
examples/domain-events/events-c/event-test.c: a test example
* AUTHORS: added Ben Guthro
daniel
2008-10-23 13:18:18 +00:00
Daniel Veillard
e10b79947a
* docs/apps.html docs/apps.html.in: update monitoring apps section
...
Daniel
2008-10-23 11:42:42 +00:00
Chris Lalancette
e3b792d6e3
An updated patch for adding <device> tags to logical
...
findPoolSources. Given danpb's last feedback, I completely removed the XML
parsing and did it all with structures. The result should (hopefully) be a lot
easier on the eyes, and is a little more generic.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-10-23 11:39:53 +00:00
Chris Lalancette
c0c0fb8eef
As suggested by danpb, to fix up the regression caused by last week's VIR_ENUM
...
cleanup patch, add a ".defaultFormat" member to .poolOptions. In
storage_conf.c, if virXPathString(/pool/source/format/@type) returns NULL, then
set the pool type to .defaultFormat; otherwise, lookup the type via
formatFromString.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-10-23 11:32:22 +00:00
Cole Robinson
6d035f67e0
Fix syntax error that was breaking RPM builds.
2008-10-22 13:55:15 +00:00
Chris Lalancette
c6f0a7b2db
Currently, you can define a logical storage pool with something like:
...
<pool type='logical'>
<source>
<name>MyVG</name>
<device name='/dev/sdb'/>
...
However, dumping out the XML for this same storage pool (with, say, virsh
pool-dumpxml), gives:
<pool type='logical'>
<source>
<name>MyVG</name>
<device name='/dev/sdb'>
</device>
To make this more idempotent, do the <device name='/dev/sdb'/> form by default,
and only do the <device>...</device> form if .nfreeExtent is defined for the
storage pool.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-10-21 17:23:38 +00:00
Chris Lalancette
46db2b2968
Because of my patch last week that converted the various virStorage*FromString
...
and virStorage*ToString implementations to the generic VIR_ENUM_IMPL, there were
a couple of places that didn't properly set errors when they failed. This patch
fixes these places up.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-10-21 17:18:45 +00:00
Chris Lalancette
c83c3e9e5c
While doing on this patch series, I mistakenly added a bogus piece of
...
storage XML to libvirtd, which was saved in /etc/libvirt/storage. On subsequent
stop/start of libvirtd, because of another bug , an
error wasn't being set properly in an error path, so libvirtd was SEGV'ing in
storage_conf.c:virStoragePoolObjLoad when trying to dereference the NULL err
returned from virGetLastError(). Make this more robust against errors by always
doing "err ? err->message : NULL" in the printf. I looked around the tree and
found a couple of other places that weren't guarded, so this patch fixes them as
well.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-10-21 17:15:53 +00:00
Dan Smith
e98d8d7997
Fix up cgroup initialization order and allow /dev/pts device access in LXC
2008-10-21 16:46:47 +00:00
Daniel Veillard
85432b0bd0
Document somme commit rules, and add application monitoring links to docs
...
* HACKING: update with some rules for commiters
* docs/apps.html docs/apps.html.in: add a section on monitoring
support
daniel
2008-10-21 14:26:59 +00:00
Daniel Veillard
6d6fd6b305
* src/qemu_driver.c: cleanup patch for usb masstorage hotadd
...
by Guido Günther
daniel
2008-10-21 13:09:23 +00:00
Jim Meyering
6e2c770581
ALL_LINGUAS: set unconditionally, using $srcdir/po
...
* configure.in: Remove hard-coded list altogether.
2008-10-21 07:47:29 +00:00
Jim Meyering
bb371128dc
ALL_LINGUAS: remove "no", now that it's superseded by np.po
...
* configure.in: Remove "no" from hard-coded list.
2008-10-19 09:56:47 +00:00
Daniel Veillard
7b9344686a
* src/qemu_driver.c: add scsi/virtio hotplug support for KVM
...
patch by Guido Günther
daniel
2008-10-17 12:36:39 +00:00
Jim Meyering
444efaa4a7
Makefile.maint (sync-vcs-ignore-files): avoid risk of abuse
...
* Makefile.maint (sync-vcs-ignore-files): Rewrite rule so that
it won't misbehave even with maliciously-named sub-directories.
2008-10-17 12:04:27 +00:00
Jim Meyering
83c2762b35
generate .gitignore files from .cvsignore ones
...
* Makefile.maint (sync-vcs-ignore-files): New target.
Prompted by a patch from James Morris.
http://thread.gmane.org/gmane.comp.emulators.libvirt/8619/focus=8773
Add all (now-generated) .gitignore files.
* .gitignore: New file.
* build-aux/.gitignore: New file.
* docs/.gitignore: New file.
* docs/devhelp/.gitignore: New file.
* docs/examples/.gitignore: New file.
* docs/examples/python/.gitignore: New file.
* gnulib/lib/.gitignore: New file.
* gnulib/lib/arpa/.gitignore: New file.
* gnulib/lib/netinet/.gitignore: New file.
* gnulib/lib/sys/.gitignore: New file.
* gnulib/tests/.gitignore: New file.
* include/.gitignore: New file.
* include/libvirt/.gitignore: New file.
* po/.gitignore: New file.
* proxy/.gitignore: New file.
* python/.gitignore: New file.
* python/tests/.gitignore: New file.
* qemud/.gitignore: New file.
* src/.gitignore: New file.
* tests/.gitignore: New file.
* tests/confdata/.gitignore: New file.
* tests/sexpr2xmldata/.gitignore: New file.
* tests/virshdata/.gitignore: New file.
* tests/xencapsdata/.gitignore: New file.
* tests/xmconfigdata/.gitignore: New file.
* tests/xml2sexprdata/.gitignore: New file.
2008-10-17 09:59:02 +00:00
Daniel Veillard
8348610c5e
qemudDomainBlockStats use qemudDiskDeviceName
...
* src/qemu_driver.c: use qemudDiskDeviceName to determine the block
device name in qemudDomainBlockStats(), patch by Guido Günther
daniel
2008-10-17 09:29:29 +00:00
Daniel Veillard
f009e2aae2
* src/qemu_driver.c: fix qemudDiskDeviceName to handle disk devices
...
too, patch by Guido Günther
daniel
2008-10-17 09:24:07 +00:00
Daniel Veillard
aadb84a547
* src/domain_conf.c: fix virDiskNameToBusDeviceIndex() to allow 0
...
patch by Guido Günther
Daniel
2008-10-17 09:18:21 +00:00
Jim Meyering
c16d74a12a
build: when po-check fails, say why and suggest a fix
...
* Makefile.maint (po-check): Before, when this check failed, it just
spat out a diff mentioning two temporary files. Now, it tells you
what's wrong and suggests a fix with a patch using the name of the
affected file (rather than temporary file names) in the diff output.
2008-10-16 17:18:48 +00:00
Chris Lalancette
eeff3cdcbc
Add support for detecting the partition table type when scanning
...
iSCSI volumes. This is implemented in the
virStorageBackendUpdateVolInfoFD function, so all future callers will
automatically benefit. This is a somewhat large patch because the
conversion of the virStorageBackendPartTableTypeToString necessitated
a change to the formatToString and formatFromString function pointers,
which caused fallout in other places in the storage stuff. The good
news is that most of these callers are now converted over to the
VIR_ENUM_IMPL, which means a lot of redundant code is now gone.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-10-16 15:06:03 +00:00
Chris Lalancette
164f786626
Compiling with -Werror showed a possible use before initialization
...
in src/qemu_driver.c. Make sure to initialize the olddisk ptr to NULL.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-10-16 13:44:09 +00:00
Jim Meyering
e4e4a45927
build: exempt *.ico files from the trailing blank check
...
* .x-sc_trailing_blank: Add \.ico$ to the list.
2008-10-16 13:28:07 +00:00
Chris Lalancette
0fd0cb6037
"make syntax-check" was complaining that network_driver.c was missing from
...
POTFILES.in. Add it there, and then fix up one warning about included
c-ctypes.h that wasn't being used.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-10-16 12:04:06 +00:00
Richard W.M. Jones
d0a8e88b95
* configure.in, src/Makefile.am, src/virsh_win_icon.rc:
...
Add a Windows icon resource.
2008-10-15 18:39:34 +00:00
Richard W.M. Jones
d510d4bf92
* src/libvirt.c: Register the remote driver even when we are
...
configured --without-libvirtd. Also adds debugging of
registration events.
2008-10-15 10:33:01 +00:00
Jim Meyering
fd52c6ff67
avoid many format string warnings
...
Building with --disable-nls exposed many new warnings like these:
virsh.c:4952: warning: format not a string literal and no format ...
util.c:163: warning: format not a string literal and no format arguments
All but one of the following changes add a "%s" argument before
the offending _(...) argument.
This was the only manual change:
* src/lxc_driver.c (lxcVersion): Use %s and strerror(errno)
rather than %m, to avoid a warning from gcc -Wformat-security.
Add "%s" before each warned about format-string-with-no-%-directive:
* src/domain_conf.c (virDomainHostdevSubsysUsbDefParseXML)
(virDomainDefParseString, virDomainDefParseFile):
* src/hash.c (virGetConnect, __virGetDomain, virReleaseDomain)
(__virGetNetwork, virReleaseNetwork, __virGetStoragePool)
(virReleaseStoragePool, __virGetStorageVol, virReleaseStorageVol):
* src/lxc_container.c (lxcContainerChild):
* src/lxc_driver.c (lxcDomainDefine, lxcDomainUndefine)
(lxcDomainGetInfo, lxcGetOSType, lxcDomainDumpXML)
(lxcSetupInterfaces, lxcDomainStart, lxcDomainCreateAndStart)
(lxcVersion, lxcGetSchedulerParameters):
* src/network_conf.c (virNetworkDefParseString)
(virNetworkDefParseFile):
* src/openvz_conf.c (openvzReadNetworkConf, openvzLoadDomains):
* src/openvz_driver.c (openvzDomainDefineCmd)
(openvzDomainGetInfo, openvzDomainDumpXML, openvzDomainShutdown)
(openvzDomainReboot, ADD_ARG_LIT, openvzDomainDefineXML)
(openvzDomainCreateXML, openvzDomainCreate, openvzDomainUndefine)
(openvzDomainSetAutostart, openvzDomainGetAutostart)
(openvzDomainSetVcpus):
* src/qemu_driver.c (qemudDomainBlockPeek, qemudDomainMemoryPeek):
* src/remote_internal.c (remoteDomainBlockPeek)
(remoteDomainMemoryPeek, remoteAuthPolkit):
* src/sexpr.c (sexpr_new, _string2sexpr):
* src/storage_backend_disk.c (virStorageBackendDiskMakeDataVol)
(virStorageBackendDiskCreateVol):
* src/storage_backend_fs.c
(virStorageBackendFileSystemNetFindPoolSources):
* src/storage_backend_logical.c (virStorageBackendLogicalFindLVs)
(virStorageBackendLogicalFindPoolSources):
* src/test.c (testOpenDefault, testOpenFromFile, testOpen)
(testGetDomainInfo, testDomainRestore)
(testNodeGetCellsFreeMemory):
* src/util.c (virExec):
* src/virsh.c (cmdAttachDevice, cmdDetachDevice)
(cmdAttachInterface, cmdDetachInterface, cmdAttachDisk)
(cmdDetachDisk, cmdEdit):
* src/xend_internal.c (do_connect, wr_sync, xend_op_ext)
(urlencode, xenDaemonDomainCreateXML)
(xenDaemonDomainLookupByName_ids, xenDaemonDomainLookupByID)
(xenDaemonParseSxprOS, xend_parse_sexp_desc_char)
(xenDaemonParseSxprChar, xenDaemonParseSxprDisks)
(xenDaemonParseSxpr, sexpr_to_xend_topology, sexpr_to_domain)
(xenDaemonDomainFetch, xenDaemonDomainGetAutostart)
(xenDaemonDomainSetAutostart, xenDaemonDomainMigratePerform)
(xenDaemonDomainDefineXML, xenDaemonGetSchedulerType)
(xenDaemonGetSchedulerParameters)
(xenDaemonSetSchedulerParameters, xenDaemonDomainBlockPeek)
(xenDaemonFormatSxprChr, virDomainXMLDevID):
* src/xm_internal.c (xenXMConfigCacheRefresh, xenXMDomainPinVcpu)
(xenXMDomainCreate, xenXMDomainDefineXML)
(xenXMDomainAttachDevice, xenXMDomainDetachDevice):
* src/xml.c (virXPathString, virXPathNumber, virXPathLong)
(virXPathULong, virXPathBoolean, virXPathNode, virXPathNodeSet):
* src/xs_internal.c (xenStoreOpen):
2008-10-13 16:46:28 +00:00
Richard W.M. Jones
72523d7bc2
Documentation for NIC model selection.
...
* docs/formatdomain.html.in, docs/formatdomain.html: Add the
documentation for NIC model selection.
2008-10-13 15:25:38 +00:00
Richard W.M. Jones
c13f07fc88
Build failure fixed.
...
* src/domain_conf.c: Fix build failure of the Xen proxy.
2008-10-13 15:24:34 +00:00
Jim Meyering
6ac274673c
testError format strings: explicitly include domain and network names
...
This repairs the "make check" failure of tests/undefine.
* src/test.c (testResumeDomain, testPauseDomain): Likewise.
(testShutdownDomain, testGetDomainInfo, ): Likewise.
(testSetMemory, testSetVcpus, testDomainCreate, testDomainUndefine)
(testDomainGetSchedulerType, testDomainGetSchedulerParams): Likewise.
(testDomainSetSchedulerParams, testNetworkUndefine): Likewise.
(testNetworkStart, testNetworkGetBridgeName): Likewise.
(testDomainCoreDump, testDomainSave): Likewise, and...
Name the file upon failed open or write.
Use strerror(errno) in diagnostics.
* tests/undefine: Adjust expected output.
test.c (testError): Remove now-ignored dom and net parameters.
This is a sytnax-only change: removing the two unused parameters
and updating all callers:
* src/test.c (GET_DOMAIN, GET_NETWORK, testError)
(testBuildCapabilities, testOpenDefault, testOpenFromFile)
(testOpen, testGetHostname, testGetURI, testGetCapabilities)
(testLookupDomainByID, testLookupDomainByUUID)
(testLookupDomainByName, testResumeDomain, testPauseDomain)
(testShutdownDomain, testGetDomainInfo, testDomainSave)
(testDomainRestore, testDomainCoreDump, testGetOSType)
(testSetMemory, testSetVcpus, testListDefinedDomains)
(testNodeGetCellsFreeMemory, testDomainCreate)
(testDomainUndefine, testDomainGetSchedulerType)
(testDomainGetSchedulerParams, testDomainSetSchedulerParams)
(testLookupNetworkByUUID, testLookupNetworkByName)
(testListNetworks, testListDefinedNetworks, testNetworkUndefine)
(testNetworkStart, testNetworkGetBridgeName): Update callers.
2008-10-11 07:24:49 +00:00
Daniel P. Berrange
0c4a048485
Fix virRealloc bug for zero-size
2008-10-10 18:17:13 +00:00
Daniel P. Berrange
7e0d3e62e9
Support SDL config with QEMU guests
2008-10-10 16:52:20 +00:00
Daniel P. Berrange
427f7a8b09
Switch domain device objects to array instead of linked list
2008-10-10 16:08:01 +00:00
Daniel P. Berrange
2e53a9912e
Switch storage objects to array instead of linked list
2008-10-10 15:13:28 +00:00
Daniel P. Berrange
dd48e929c7
Switch network objects to array instead of linked list
2008-10-10 14:50:26 +00:00
Daniel P. Berrange
4789154063
Switch domain objects to array instead of linked list
2008-10-10 14:20:37 +00:00
Daniel P. Berrange
1564711a27
Split network driver out into separate files
2008-10-10 13:57:13 +00:00
Daniel P. Berrange
0107578c5e
Fix two format string warnings on 32bit hosts
2008-10-10 12:54:10 +00:00
Richard W.M. Jones
0ae26314b3
Updated MinGW spec file.
...
* .cvsignore, Makefile.am, autobuild.sh, configure.in,
mingw32-libvirt.spec.in: Import the latest MinGW libvirt spec
file. Note that the file has been renamed to conform to
new Fedora packaging guidelines.
* autobuild.sh: Fix a bug in the generation of the $EXTRA_RELEASE
field when autobuilding.
2008-10-10 11:33:10 +00:00
Daniel Veillard
f6803c960f
virDomainDefineXML, and a few additional cleanups
...
* include/libvirt/libvirt.h[.in] include/libvirt/virterror.h
qemud/remote* src/driver.h src/libvirt.c src/libvirt_sym.version
src/lxc_driver.c src/openvz_driver.c src/proxy_internal.c
src/qemu_driver.c src/remote_internal.c src/test.c src/virsh.c
src/xen_internal.c src/xen_unified.c src/xen_unified.h
src/xend_internal.c src/xend_internal.h src/xm_internal.c
src/xs_internal.c docs/*: cleanup virDomainCreateLinux into
virDomainDefineXML, and a few additional cleanups
Daniel
2008-10-10 09:32:27 +00:00
Daniel Veillard
3d038d101f
fix index creation for disks
...
* src/domain_conf.c src/util.c: fix index creation for disks >
{sd,hd,xvd,vd}z (Sanjay Rao and Chris Wright)
Daniel
2008-10-10 08:37:35 +00:00
Cole Robinson
02fc93d624
Centralize majority of error reporting logic.
2008-10-09 15:38:31 +00:00
Daniel P. Berrange
218334d1b2
Fix two compile warnings
2008-10-09 14:50:25 +00:00
Dan Smith
6c504d6a7c
Add LXC scheduling parameters and support in virsh schedinfo
2008-10-08 16:28:48 +00:00
Daniel Veillard
6d670a1fc1
use safewrite() and plug a leak
...
* src/cgroup.c: use safewrite()
* src/qemu_driver.c: missing VIR_FREE pojnted out by Eduardo Habkost
Daniel
2008-10-08 13:44:40 +00:00
Jim Meyering
3ca608b5d6
avoid "make syntax-check" failure
...
* src/cgroup.c (virCgroupSetValueStr): Use safe_write, not write.
2008-10-08 09:31:13 +00:00
Daniel Veillard
f9dbe46b44
* src/qemu_driver.c: another OOM handling cleanup (Guido Günther)
...
daniel
2008-10-07 16:39:32 +00:00
Daniel Veillard
9f4c047935
* src/qemu_driver.c: don't print and extra OOM error on top of getpwuid error
...
(Guido Günther)
Daniel
2008-10-07 16:01:23 +00:00
Cole Robinson
e2a43cdb87
Move DEBUG macros to central location.
2008-10-06 19:53:06 +00:00
Cole Robinson
8206b421d6
Fix segfault if starting qemu VM with an inactive virtual network.
2008-10-06 19:36:46 +00:00
Cole Robinson
a588bf5514
Slim down schema test result output
2008-10-06 19:25:29 +00:00
Daniel Veillard
72c40b0622
use C99 initializers for virState
...
* src/lxc_driver.c src/qemu_driver.c src/remote_internal.c
src/storage_driver.c: use C99 initializers for virState (Guido
Gunther)
Daniel
2008-10-06 15:40:37 +00:00
Daniel P. Berrange
243e80260a
Fix vpath build
2008-10-06 10:24:31 +00:00
Daniel Veillard
396473f1bf
* po/no.po: removed it's obsoleted by np.po, fixes #335211
...
daniel
2008-10-06 10:10:10 +00:00
Dan Smith
dd062d4209
Add forgotten cgroup.{c,h} and ChangeLog
2008-10-03 17:58:02 +00:00
Daniel Veillard
773441bba7
* libvirt.spec.in: fix bug #465274 to build on RHEL
...
daniel
2008-10-02 15:04:11 +00:00
Cole Robinson
a166cdbb6e
Fix starting qemu VM with multiple pty char devices.
2008-10-02 14:10:20 +00:00
Daniel Veillard
3bc324139e
Xen interface order and fix python parallel build
...
* src/xend_internal.c: fix ordering when parsing multiple Xen
interfaces, patch by Jim Fehlig
* python/Makefile.am: fix parallel build
Daniel
2008-10-01 15:31:02 +00:00
Mark McLoughlin
758733cb55
Thu Sep 25 13:37:42 IST 2008 Mark McLoughlin <markmc@redhat.com>
...
* docs/virsh.pod: fixup some minor issues - e.g. bogus
references to "xm"
2008-09-25 12:40:01 +00:00
Daniel Veillard
321c9a7f51
* configure.in libvirt.spec.in NEWS docs/*: release of libvirt-0.4.6
...
* src/storage_backend_logical.c: re-add the -f flag to vgremove
* po/*: rebuilt
Daniel
2008-09-23 20:48:49 +00:00
Daniel Veillard
38a22555de
* po/pt_BR.po: updated brazilian translation
...
Daniel
2008-09-23 10:18:02 +00:00
Daniel Veillard
ad5723e792
cleanup and removal for pools in logical backend
...
* src/storage_backend_logical.c: enable stop pool in logical backend
improve portability when deleting a pool and also call pvremove
patch by Chris Lalancette
Daniel
2008-09-22 20:22:35 +00:00
Daniel Veillard
4f84e631ed
* src/storage_conf.c: fixes parsing to allow no sources for a pool
...
fix by Dan and Chris Lalancette
Daniel
2008-09-22 19:57:47 +00:00
Daniel Veillard
0958489ca5
* src/remote_internal.c src/storage_driver.c: structure init cleanup
...
by Chris Lalancette
Daniel
2008-09-22 19:53:42 +00:00
Daniel Veillard
7e0ff3aab0
read network config in OpenVZ driver
...
* src/openvz_conf.c: patch from Evgeniy Sokolov to read
network config in OpenVZ driver.
Daniel
2008-09-22 15:21:44 +00:00
Daniel P. Berrange
da622a20cd
Fix broken specfile build
2008-09-18 10:20:24 +00:00
Richard W.M. Jones
49c50366fd
Documentation cleanups.
...
* docs/bindings.html.in: Clean up the bindings page, and add
C# and Java.
* docs/windows.html.in: Remove old bogus information and add
placeholder.
2008-09-18 09:00:10 +00:00
Daniel P. Berrange
0aac8c9447
Fix trailing whitespace & unmarked diagnostic warning
2008-09-18 08:54:23 +00:00
Richard W.M. Jones
a0208e6635
src/openvz_driver.c: Fix segfault in OpenVZ driver
...
(Evgeniy Sokolov).
2008-09-17 16:07:03 +00:00
Daniel P. Berrange
bf347f5af0
Fix broken test case data files
2008-09-17 15:39:11 +00:00
Richard W.M. Jones
4f1e6e7ef2
src/storage_backend_disk.c: Missing include file.
2008-09-17 14:29:47 +00:00
Richard W.M. Jones
dd57b821e4
Remove some deadcode (Nguyen Anh Quynh).
2008-09-17 14:21:27 +00:00
Richard W.M. Jones
3b7c7d888a
Change name of "blocked" state to "idle" (John Levon).
2008-09-17 14:18:15 +00:00
Richard W.M. Jones
a744ddad59
include/libvirt/libvirt.h.in, src/libvirt.c: Fix comments
...
which incorrectly referred to non-existent 'virDomainFlags'
type (Anton Protopopov).
2008-09-17 14:15:20 +00:00
Richard W.M. Jones
7076981f50
src/conf.c: Improved error messages in XM conf module.
2008-09-17 14:11:21 +00:00
Richard W.M. Jones
422311ff32
libvirt.spec.in: Specfile enhancements for minimal
...
"client only" build (Ben Guthro).
2008-09-17 14:09:13 +00:00
Richard W.M. Jones
04e9e1b2a6
configure.in, src/qemu_driver.h, src/qemu_driver.c: KVM
...
can determine max VCPUs at runtime (Guido Günther).
2008-09-17 14:07:49 +00:00
Cole Robinson
bf26cd8ecb
Implement disk volume deleting.
2008-09-16 16:46:08 +00:00
Cole Robinson
a82bd0784b
Fix reading vncdisplay from xend, add several test cases for xen vnc corner case
...
s.
2008-09-09 13:53:58 +00:00
Cole Robinson
bf3e2132a7
Fix a segfault if defining a qemu domain without an emulator.
2008-09-09 13:44:42 +00:00
Daniel Veillard
9d3d43436e
* configure.in libvirt.spec.in docs/*: preparing release of
...
libvirt-0.4.5
* po/*: rebuilt and updated de.po
daniel
2008-09-08 14:32:18 +00:00
Daniel Veillard
58686c3dd8
add domain name in network configurations suport and on OpenVZ config bugfix
...
* src/network_conf.c src/network_conf.h src/qemu_driver.c: add
support for a domain name in network configurations, patch by
JJ Reynolds with bugfix raised by Dan
* src/openvz_conf.c: fix to small bug in openvzReadConfigParam
by Evgeniy Sokolov
Daniel
2008-09-08 12:45:29 +00:00
Daniel P. Berrange
3aa7c4639d
Fix potential NULL deref in openvz driver
2008-09-08 12:15:33 +00:00
Daniel Veillard
914e1c61de
finish applying initialization patch for logical storage backend
...
* src/storage_backend_logical.c: finish applying initialization
from Jim Fehlig patch for logical storage backend
Daniel
2008-09-08 08:03:54 +00:00
Daniel P. Berrange
a8936295ce
Fix trailing whitespace mistakes
2008-09-05 15:00:14 +00:00
Daniel P. Berrange
1cc9f9b3d8
Convert openvz driver to generic domain XML APIs
2008-09-05 14:10:58 +00:00
Daniel P. Berrange
542039fab0
Fully support mingw builds
2008-09-05 12:03:45 +00:00
Daniel P. Berrange
126d3ebeea
Fix starting of xen domains without a PVFB console by removing default emulator
2008-09-05 11:52:12 +00:00
Daniel P. Berrange
f193e19536
Fix xen capabilities data creation
2008-09-05 11:35:43 +00:00
Daniel Veillard
e88295804a
* src/storage_backend_fs.c: fix a signed/unsigned issue breaking
...
virStorageBackendProbeFile(), patch by Cole Robinson
Daniel
2008-09-04 13:34:42 +00:00
Daniel Veillard
a8d0600762
* src/qemu_driver.c: fix an error message, patch by Nguyen Anh Quynh
...
Daniel
2008-09-04 13:20:28 +00:00
Daniel P. Berrange
b9ed7914c2
Fix make check when augparse is missing
2008-09-04 13:17:47 +00:00
Daniel Veillard
c37031ebf3
fix a miscalculation of command line size for vgcreate
...
* src/storage_backend_logical.c: fix a miscalculation of command line
size for vgcreate, patch from Jim Fehlig
Daniel
2008-09-04 13:13:32 +00:00
Daniel P. Berrange
9567aad381
Add Augeas lens' for libvirtd.conf and qemu.conf
2008-09-04 10:44:23 +00:00
Daniel Veillard
18626bd225
when dumping code don't keep Xen domain live
...
* src/xend_internal.c: patch from John Levon shutting down a live
domain is just more hazardous
Daniel
2008-09-04 09:11:37 +00:00
Daniel Veillard
584ff19452
* src/xend_internal.c src/xs_internal.c: use poweroff instead of halt
...
when shutting down a xen domain, patch by John Levon
Daniel
2008-09-04 09:07:42 +00:00
Daniel Veillard
821dcf0ff7
* src/qemu_driver.c: switch flags to unsigned by James Morris
...
* AUTHORS: add James Morris
Daniel
2008-09-04 08:15:05 +00:00
Dan Smith
df01e14bd7
Add LXC version implementation
...
This patch adds an implementation of the version function to the LXC driver.
The providers use the hypervisor version in a field of one of the instances,
so we need to have something meaningful here. AFAICT, the only real option
we have (considering the limitations of the libvirt version information) is
to use the kernel version.
2008-09-03 17:21:27 +00:00
Cole Robinson
e0b4fcc280
Fix qemu media connect/eject to work with latest syntax. Add support for ejecting floppy devices and scsi cdroms.
2008-09-03 16:05:25 +00:00
Cole Robinson
fe7bb57a8b
Update domain xml after usb device hotplug.
2008-09-03 15:05:31 +00:00
Cole Robinson
f4af06d812
Scrap media eject output to try and determine success/fail.
2008-09-03 14:43:34 +00:00
Cole Robinson
34b1a03402
Fix disk ordering and add target duplication checking when parsing domain xml.
2008-09-03 14:30:24 +00:00
Daniel Veillard
53738f83a5
avoid a segfault on CD eject in KVM/QEmu
...
* src/qemu_driver.c: patch from Cole Robinson to avoid a segfault
on KVM CD eject
Daniel
2008-09-03 12:52:27 +00:00
Daniel Veillard
54a4f8d44d
add output on attach and detach success
...
* src/virsh.c: patch from Cole Robinson to add output on attach
and detach success
daniel
2008-09-03 12:38:28 +00:00
Daniel Veillard
d9d3478a89
* AUTHORS: add Cole Robinson as commiter
...
daniel
2008-09-03 12:24:50 +00:00
Daniel Veillard
b419ebc7e9
* src/storage_conf.c: add one missing check in virStoragePoolDefParseDoc
...
Daniel
2008-09-03 07:12:37 +00:00
Daniel Veillard
10ccfc92f3
* src/domain_conf.c: fix a parsing error for input devices
...
patch by Cole Robinson
daniel
2008-09-02 15:33:39 +00:00
Daniel Veillard
b8f2610280
check availbility of emulators before reporting them in capabilities
...
* src/qemu_conf.c: patch from Cole Robinson to report in the
capabilities only the ones where the emulators is actually found
* po/libvirt.pot: regenerated
* src/libvirt.c: small typo fix
Daniel
2008-09-02 15:00:09 +00:00
Daniel Veillard
41ce15a586
Adds storage source element for pools
...
* src/storage_backend.h src/storage_backend_logical.c
src/storage_conf.c src/storage_conf.h src/virsh.c:
Applied patches from David Lively to add storage source
elements needed for storage pool
* docs/formatstorage.html docs/formatstorage.html.in: associated
documentation
Daniel
2008-09-02 14:15:42 +00:00
Jim Meyering
81cb09f9fe
qemu_conf.c: use new function, virFileReadLimFD
...
* src/qemu_conf.c (qemudExtractVersionInfo): Use virFileReadLimFD
and VIR_FREE in place of an open-coded loop and a static buffer.
2008-09-02 10:30:40 +00:00
Jim Meyering
d2ac46f2b0
util.c: add a file-descriptor-based wrapper for fread_file_lim
...
* src/util.c (virFileReadLimFP): New function.
(__virFileReadLimFD): New function.
* src/util.h (__virFileReadLimFD): Declare.
(virFileReadLimFD): Define.
(virFileReadAll): Rewrite to use virFileReadLimFP.
2008-09-02 10:29:51 +00:00
Daniel P. Berrange
3348a97bd3
Switch over fork/exec code to use virExec
2008-08-29 07:11:15 +00:00
Daniel P. Berrange
afac1439aa
Allow for private root filessytem in containers using pivot_root
2008-08-28 22:40:50 +00:00
Daniel P. Berrange
8f762e34f3
Fix lookup of xen VM after define (Cole Robinson)
2008-08-28 11:59:07 +00:00
Jim Meyering
ff7ecc1d5b
improve parallel build support
...
* autobuild.sh: Append -j$N to MAKEFLAGS, if no -j option is there.
* libvirt.spec.in: Use %{?_smp_mflags} with "make".
Based on a patch from James Morris:
http://thread.gmane.org/gmane.comp.emulators.libvirt/8201
2008-08-28 09:08:44 +00:00
Daniel P. Berrange
39c9354c5c
Add storage pool source discovery support (patch from David Lively)
2008-08-27 20:05:58 +00:00
Daniel P. Berrange
406f3ee9e8
Fix QEMU domain creation by allowing virExec to preserve certain FDs
2008-08-27 11:44:58 +00:00
Daniel P. Berrange
2875ed81bd
Fix EOF handling when reading openvz domain list
2008-08-27 11:21:01 +00:00
Daniel P. Berrange
d81b038cc2
Remove use of virState apis from openvz driver
2008-08-27 11:19:45 +00:00
Dan Smith
5fb17bcc1e
[LXC] Cleanup devices on container shutdown
2008-08-22 15:35:37 +00:00
Daniel P. Berrange
8f789f1b2f
Use libvirt error message for python exceptions
2008-08-22 10:50:18 +00:00
Jim Meyering
6c02ba0540
configure.in: link with -lpthread when necessary
...
* configure.in: Explicitly add -lpthread to $LIBS.
With an empty "ACTION_IF_FOUND", AC_CHECK_LIB would have done
that for us automatically, but when there is an explicit third
argument, those commands are run instead of the default.
Reported by Jun Koi <junkoi2004@gmail.com>.
2008-08-22 08:32:58 +00:00
Jim Meyering
7e0da18527
autobuild.sh: Fix minor shell-quoting bugs.
...
* autobuild.sh: Remove unnecessary quotes.
Don't choke on a file name argument containing a space.
Don't misbehave for $AUTOBUILD_INSTALL_ROOT containing
a shell meta-character.
2008-08-21 19:31:55 +00:00
Mark McLoughlin
e2d7a26ec0
Forgotten ChangeLog entry
2008-08-21 11:51:27 +00:00
Daniel P. Berrange
9472d3e2f3
Improve error reporting from remote driver
2008-08-21 10:14:54 +00:00
Daniel P. Berrange
11a2e2972a
Propagate virConnectOpen errors to global error object
2008-08-21 10:12:32 +00:00
Daniel P. Berrange
c2bbf99e48
Remove unused lx_controller.h file
2008-08-21 10:07:21 +00:00
Daniel P. Berrange
177c74b1fa
Create lxc_controller standalone binary
2008-08-20 20:55:32 +00:00
Daniel P. Berrange
bb16f4a25d
Do conditional driver config in Makefile.am, not source files
2008-08-20 20:48:35 +00:00
Daniel P. Berrange
6334cd16df
Remove configFile/autostartLink vars from virDomainObj struct
2008-08-20 19:42:36 +00:00
Daniel Veillard
b1e5880740
add cpu management functionality to OpenVZ driver
...
* src/openvz_conf.c src/openvz_driver.c: patch from Evgeniy Sokolov
to limit the number of CPUs used by OpenVZ domains.
Daniel
2008-08-20 13:44:03 +00:00
Daniel Veillard
ce9439358c
Fix creating and cleaning up logical volumes if a target path is specified
...
* src/storage_backend_logical.c: Patch from Cole Robinson, fix
creating and cleaning up logical volumes if a target path is
specified.
Daniel
2008-08-20 13:33:01 +00:00
Daniel Veillard
ace1b6bf98
Fix size reporting for disks without partitions.
...
* src/parthelper.c: Patch from Cole Robinson, fix size reporting for
disks without partitions.
Daniel
2008-08-20 13:20:01 +00:00
Daniel Veillard
4240b3fd63
Handle HTML generation in the absence of XHTML1 DTDs
...
* configure.in libvirt.spec.in docs/Makefile.am: fix the problem
of HTML generation in the absence of XHTML1 DTDs in the system
catalog.
Daniel
2008-08-20 13:16:29 +00:00
Daniel Veillard
b73d495754
* src/network_conf.c src/network_conf.h src/qemu_driver.c: allow to
...
add static host definition for dnsmasq
Daniel
2008-08-20 12:50:29 +00:00
Daniel P. Berrange
1b4bb7d4ab
Allow non-blocking/daemon mode to be specified via virExec flags
2008-08-20 09:24:14 +00:00
Daniel P. Berrange
6bc99a7775
Allow a pre-opened FD to be be pass to virExec for stdout/err
2008-08-20 09:08:17 +00:00
Daniel P. Berrange
60ed1d2a7a
Avoid signal race in virExec
2008-08-20 08:53:49 +00:00
Daniel P. Berrange
f2172946e5
Improve virExec error reporting
2008-08-20 08:30:04 +00:00
Daniel P. Berrange
5cd1d3c53c
Remove duplicated call to virInitialize
2008-08-18 09:24:46 +00:00
Atsushi SAKAI
6fd4c30285
fix typos src/virsh.c from John Levon,
...
and 3 more files(src/domain_conf.c src/openvz_driver.c src/qemu_driver.c)
2008-08-15 01:41:49 +00:00
Daniel P. Berrange
2723efaae1
Update LXC driver in POTFILES.in
2008-08-14 09:07:18 +00:00
Daniel P. Berrange
2e7a373646
Switch LXC driver over to generic domain XML processing APIs
2008-08-13 12:50:55 +00:00
Daniel P. Berrange
763dacda97
Make LXC I/O controller process a parent of the container process
2008-08-13 10:52:15 +00:00
Daniel P. Berrange
e82c913680
Refactor LXC driver to pass tty/socket state directly
2008-08-13 10:14:47 +00:00
Daniel Veillard
415b92101f
* docs/storage.html[.in] src/storage_backend_disk.c: revert previous
...
msdos patch and apply new one from Cole Robinson
daniel
2008-08-13 09:45:10 +00:00
Jim Meyering
4ee755d641
rewrite virFileLinkPointsTo
...
* src/util.c (SAME_INODE): Define.
(virFileLinkPointsTo): Rewrite to be more portable and more efficient.
2008-08-12 17:38:08 +00:00
Daniel Veillard
8fdb2cffa5
make sure parted doesn't ask for confirmation
...
* src/storage_backend_disk.c: make sure parted doesn't ask
confirmation, patch by Cole Robinson
Daniel
2008-08-12 11:29:49 +00:00
Daniel Veillard
ef7fec1168
rename the disk type from 'dos' to 'msdos'
...
* docs/storage.html[.in] src/storage_backend_disk.c: patch from
Cole Robinson to rename the disk type from 'dos' to 'msdos'
Daniel
2008-08-12 11:26:00 +00:00
Atsushi SAKAI
413c5dbf07
add _fd to stdin, stderr stdout in struct virDomainObj for compilation on MinGW
2008-08-12 08:38:22 +00:00
Atsushi SAKAI
43c7f972aa
fix compilation for MinGW
2008-08-12 08:25:48 +00:00
Daniel Veillard
3c487a4229
Fix connection lookup in python storage instances
...
* python/generator.py: patch from Cole Robinson trying to fix
problem of connection lookup when creating storage instances
Daniel
2008-08-12 08:11:09 +00:00
Daniel Veillard
52efa8863e
* po/*: regeneration of pot file, updates of .po
...
Daniel
2008-08-12 08:05:36 +00:00
Daniel Veillard
9b4b4af716
documentation for USB passthrough
...
* docs/formatdomain.html docs/formatdomain.html.in: documentation
for the USB format option by Guido Günther
daniel
2008-08-12 07:28:28 +00:00
Jim Meyering
efb8492b9d
tests: append a newline to expected-output files lacking NL-at-EOF
...
* tests/qemuxml2argvtest.c (testCompareXMLToArgvFiles): Adjust the
code that creates "actual" output, so that it too produces a
newline-terminated buffer.
* tests/qemuxml2argvdata/*.args: Append a newline to each, via:
for i in $(find|grep '\.args$'); do echo >> $i;done
2008-08-11 12:29:58 +00:00
Daniel P. Berrange
b3728d7d72
Fix const-correctness of virRUn and virExec
2008-08-08 15:43:38 +00:00
Daniel Veillard
5ba372306a
llow to add a disk as an USB device (QEmu/KVM)
...
* src/domain_conf.c src/domain_conf.h src/qemu_conf.c
src/qemu_driver.c: patch from Guido Günther allowing to add
disk as USB devices
* docs/libvirt.rng: extend the schemas for the new value
* tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args
tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml
tests/qemuxml2argvtest.c tests/qemuxml2xmltest.c: add a specific
test to the regression suite
Daniel
2008-08-08 15:03:00 +00:00
Daniel Veillard
d1710d35ea
Extend parser and add support for USB devices in QEmu/KVM
...
* src/domain_conf.c src/domain_conf.h src/qemu_conf.c
src/qemu_driver.c: Patch from Guido Günther allowing to pass
usb devices to qemu/kvm
* docs/libvirt.rng: add the new functionality to the grammar
* tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.args
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-product.args
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-product.xml
tests/qemuxml2argvtest.c tests/qemuxml2xmltest.c: adding examples
to the regression tests
* libvirt.spec.in: fix the licence tag
Daniel
2008-08-08 14:27:05 +00:00
Atsushi SAKAI
c11e64efbd
fix typos in docs
...
docs/formatdomain.html docs/formatdomain.html.in docs/java.html docs/java.html.in
2008-08-08 10:24:14 +00:00
Daniel Veillard
f61ac900b7
* tests/domainschematest: patch from Guido Günther to fix RNG checking
...
in out of tree builds.
daniel
2008-08-07 17:52:16 +00:00
Dan Smith
e94c12451b
Fix device name clash in src/veth.c
2008-08-07 13:34:17 +00:00
Jim Meyering
7846f71fb3
add the mkstemp module from gnulib
...
* bootstrap (modules): Add mkstemp.
The remainder of these changes are the result of running
./bootstrap, adding new files, and committing the result.
* gnulib/lib/gettimeofday.c: New file.
* gnulib/lib/mkstemp.c: New file.
* gnulib/lib/tempname.c: New file.
* gnulib/lib/tempname.h: New file.
* gnulib/m4/gettimeofday.m4: New file.
* gnulib/m4/mkstemp.m4: New file.
* gnulib/m4/tempname.m4: New file.
* gnulib/tests/test-gettimeofday.c: New file.
* gnulib/lib/Makefile.am: Update.
* gnulib/m4/gnulib-cache.m4: Likewise.
* gnulib/m4/gnulib-comp.m4: Likewise.
* gnulib/m4/inet_pton.m4: Likewise.
* gnulib/tests/Makefile.am: Likewise.
2008-08-07 13:02:45 +00:00
Daniel Veillard
2194f1c983
* src/bridge.c: fix a build failure on RHEL4
...
Daniel
2008-08-07 10:22:52 +00:00
Jim Meyering
57f15f779f
update from gnulib
...
* build-aux/mktempd (rand_bytes, mktempd):
* build-aux/useless-if-before-free (FILE):
* build-aux/vc-list-files:
* gnulib/lib/.cvsignore:
* gnulib/lib/Makefile.am:
* gnulib/lib/poll.c (poll):
* gnulib/lib/stdbool.in.h (_GL_STDBOOL_H, true):
* gnulib/lib/stdio-impl.h (fp_, fp_ub):
* gnulib/lib/stdio.in.h (vasprintf, obstack_printf)
(obstack_vprintf):
* gnulib/lib/vasnprintf.c (_GNU_SOURCE, sprintf, IF_LINT, exp)
(remainder, scale10_round_decimal_long_double)
(scale10_round_decimal_double, pad_ourselves):
* gnulib/m4/gnulib-cache.m4:
* gnulib/m4/gnulib-common.m4 (gl_MODULE_INDICATOR):
* gnulib/m4/gnulib-tool.m4 (gl_LOCAL_DIR, gl_M4_BASE, gl_PO_BASE)
(gl_DOC_BASE, gl_TESTS_BASE, gl_WITH_TESTS, gl_LIB, gl_LGPL)
(gl_MAKEFILE_NAME, gl_MACRO_PREFIX, gl_PO_DOMAIN, gl_VC_FILES):
* gnulib/m4/lock.m4 (gl_LOCK_EARLY_BODY, gl_PREREQ_LOCK)
(gl_DISABLE_THREADS):
* gnulib/m4/onceonly.m4:
* gnulib/m4/posix-shell.m4 (gl_POSIX_SHELL):
* gnulib/m4/stdio_h.m4 (gl_STDIO_H_DEFAULTS):
* gnulib/tests/test-getaddrinfo.c (ENABLE_DEBUGGING, dbgprintf)
(simple):
* gnulib/tests/test-stdint.c (UINTMAX_MAX, or):
* gnulib/tests/test-vc-list-files-cvs.sh (compare):
* gnulib/tests/test-vc-list-files-git.sh (compare):
2008-08-07 09:42:29 +00:00
Jim Meyering
34afcb5b26
complete the MinGW inet_pton portability fix
...
* gnulib/m4/inet_pton.m4: New file. Required for MinGW.
* gnulib/m4/gnulib-comp.m4: Regenerate via gnulib-tool.
2008-08-07 09:36:49 +00:00
Jim Meyering
3fb53d1181
fix failing "make syntax-check"
...
* src/stats_linux.c: Don't include <c-ctype.h> no longer used.
2008-08-06 13:07:55 +00:00
Jim Meyering
783158511a
work around MinGW build failure due to its lack of inet_aton
...
Use inet_pton instead; pull in gnulib's module by the same name.
* src/network_conf.c (virNetworkDefParseXML): Use inet_pton,
rather than inet_aton.
* bootstrap (modules): Add inet_pton.
* gnulib/lib/inet_pton.c: New file, from gnulib.
2008-08-06 12:08:49 +00:00
Daniel Veillard
ed3c9c3824
* docs/formatdomain.html docs/formatdomain.html.in: fix memory unit
...
as pointed out by matthew chan it's kilobytes
Daniel
2008-08-06 11:37:53 +00:00
Chris Lalancette
b8fb68be37
DanB pointed out that my sexpr xend_internal patch from yesterday broke one of
...
the regression tests. The problem is that the xenDaemonFormatSxpr{Disk,Net}
functions are shared between domain creation time and attaching disk time.
Unfortunately, though, Xend expects something different during these two times.
During domain creation time, it wants the "(device" in front of the sexpr,
while during attach time it does not. To remedy this situation, I added a flag
to these two functions to differentiate between these two modes. With this
patch in place, all of the regression tests pass.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-08-06 11:26:47 +00:00
Chris Lalancette
6335c2a0cc
With the recent refactoring of the domain code, plus the changes with the Xend
...
code, a couple of bugs were introduced into the attach-disk and attach-interface
functionality. This patch fixes 3 bugs:
1) In xenDaemonAttachDevice(), there is a switch statement to determine which
of the xenDaemonFormatSxpr{Disk,Net} functions to call. Unfortunately, the case
statements are all missing the corresponding "break", so we always fall-through
to the default error case. This patch just adds the appropriate break statements.
2) (minor) In xenDaemonDomainDefineXML (that's a mouthful!), there is a stray
"fprintf". This is now converted to a proper virXendError().
3) xenDaemonFormatSxpr{Disk,Net} were adding an extra (device to the front of
the sexpr expressions that xend did not expect (this is Xend on RHEL 5.2).
Because of this, the attaches would fail. The patch fixes this by removing the
(device from the front, which makes attach-disk and attach-interface work again.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-08-05 16:45:07 +00:00
Chris Lalancette
8c30002862
Recently upstream Xen added support for having xvd devices > 16. For the most
...
part, this doesn't really concern libvirt, since for things like attach and
detach we just pass it through and let xend worry about whether it is supported
or not. The one place this breaks down is in the stats collecting code, where
we need to figure out the device number so we can go digging in /sys for the
statistics.
To remedy this, I've re-written xenLinuxDomainDeviceID() to use regular
expressions to figure out the device number from the name. The major advantage
is that now xenLinuxDomainDeviceID() looks fairly identical to
tools/python/xen/util/blkif.py (in the Xen sources), so that adding additional
devices in the future should be much easier. It also reduces the size of the
code, and, in my opinion, the code complexity.
With this patch in place, I was able to get block statistics both on older style
devices (/dev/xvda) and on the new, expanded devices (/dev/xvdaa).
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-08-05 16:38:49 +00:00
Daniel Veillard
063679580d
saving UUID of new OpenVZ domains
...
* src/openvz_conf.c src/openvz_conf.h src/openvz_driver.c: patch
from Evgeniy Sokolov saving the UUID when creating or defining
a domain.
Daniel
2008-08-05 10:53:05 +00:00
Jim Meyering
6d72e14178
make distclean: remove generated source files
...
* src/Makefile.am (DISTCLEANFILES): Define to $(BUILT_SOURCES)
so "make distcheck" passes.
2008-08-05 08:43:03 +00:00
Atsushi SAKAI
adc1d93f97
fix syntax-check error (replace TAB to space)
2008-08-04 06:33:25 +00:00
Jim Meyering
07f8a8b34a
xend_internal.c, sexpr.c: const-correctness fixes
2008-08-01 14:43:12 +00:00
Richard W.M. Jones
c74c20f701
Incorrect attribution.
2008-08-01 14:30:59 +00:00
Richard W.M. Jones
969fa847c1
'virsh edit' and related commands
...
* src/virsh.c: Implement 'virsh edit', 'virsh net-edit' and
'virsh pool-edit' commands. These edit the XML for domains,
networks and storage pools respectively, and are the
equivalent of doing 'virsh dumpxml; vi foo.xml; virsh define'
* src/Makefile.am, src/.cvsignore: Auto-generate the net-edit
and pool-edit commands.
* docs/virsh.pod: Updated the documentation.
2008-08-01 14:30:41 +00:00
Daniel P. Berrange
0dee7feb74
Fix initial VM state
2008-08-01 14:19:06 +00:00
Jim Meyering
66f9bb5b95
virsh.c: more const-correctness fixes
2008-08-01 13:51:18 +00:00
Daniel P. Berrange
a7600746fb
Support for container related domain XML extensions
2008-08-01 13:31:37 +00:00
Daniel P. Berrange
ffc839fb20
Always set forward-delay on bridge, even if 0
2008-08-01 12:56:52 +00:00
Richard W.M. Jones
3f3345aa85
Const-correctness fixes in virsh.c
...
* src/virsh.c: Const-correctness.
2008-08-01 12:19:56 +00:00
Richard W.M. Jones
ccb516144e
Link to "how to contribute to open source"
...
* HACKING: Link to external document which describes how to
contribute to open source projects.
2008-08-01 11:25:22 +00:00
Daniel Veillard
c810c6cc23
* src/qemu_driver.c: patch from Chris Lalancette adding missing
...
carriage returns to logs
Daniel
2008-08-01 11:24:04 +00:00
Daniel P. Berrange
1b554381d1
Added test to validate all domain XML files against schema
2008-08-01 10:53:41 +00:00
Richard W.M. Jones
cf11bb2249
Improve error messages when XML is not well-formed.
...
* src/domain_conf.c, src/network_conf.c, src/storage_conf.c:
Improve error messages from commands such as 'virsh define'
when the XML is not well-formed by passing libxml2 errors
back out through virterror.
2008-08-01 09:39:44 +00:00
Daniel Veillard
eba65e1c6d
* docs/formatdomain.html docs/formatdomain.html.in docs/libvirt-api.xml
...
docs/libvirt-refs.xml docs/html/libvirt-libvirt.html src/libvirt.c:
fixed somedocs and API entry point descriptions as suggested by
Charles Duffy and regenerated the API descriptions.
Daniel
2008-08-01 06:42:45 +00:00
Daniel Veillard
7711e6858c
* src/qemu_driver.c: apply patch from Charles Duffy fixing erro
...
messages when trying to crate a domain already defined.
Daniel
2008-08-01 06:23:31 +00:00
Daniel P. Berrange
42e559a324
Fix autoport when domain is inactive
2008-07-31 14:39:30 +00:00
Chris Lalancette
6f17fb2851
From Charles Duffy:
...
Per subject; if autoport is in use for a host, the current
virDomainGraphicsDefFormat code always emits "port=-1", even if a port
is assigned to the host; this leaves no way for a client to find the VNC
port assigned to the host in question.
This patches fixes it by putting the vncport in place if there is one, and
only putting "-1" if we fail that test.
2008-07-31 12:30:34 +00:00
Daniel Veillard
55e1221686
* src/qemu_driver.c: patch from Guido Günther, interface stats should
...
not crash on interfaces without an ifname.
Daniel
2008-07-30 09:20:19 +00:00
Daniel Veillard
c05cf3f3e1
* src/storage_backend_logical.c: patch from David Lively fixing
...
small differences of behaviour for 'lvs' and 'vgs' on SLES
Daniel
2008-07-30 08:52:44 +00:00
Daniel Veillard
a8f10951d0
* qemud/qemud.c: patch from Guido Günther fixing the place where
...
config file check is done.
Daniel
2008-07-30 08:47:10 +00:00
Chris Lalancette
654c5714bf
The new generic domain re-factor introduced a small regression into the drive
...
handling code. In particular, if you had a section of XML like:
<disk type='file' device='cdrom'>
<target dev='hdc' bus='ide'/>
<readonly/>
</disk>
This used to work with older libvirt, but now fails. This is because we are
actually passing the literal string (null) to the qemu command-line, which qemu
barfs on. This patch fixes it up by making it blank, which allows qemu to
continue on it's merry way.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-07-29 12:09:21 +00:00
Daniel Veillard
4779e0bcb2
build OpenVZ and LXC support by default, fix OpenVZ build
...
* src/openvz_conf.c: fix compilation with new XPath interface
signatures
* configure.in: build OpenVZ and LXC support by default
Daniel
2008-07-29 08:42:56 +00:00
Daniel Veillard
996933bbcd
OpenVZ xml refactoring
...
* src/domain_conf.[ch] src/openvz_conf.[ch] src/openvz_driver.c:
patch from Evgeniy Sokolov doing the OpenVZ xml refactoring,
still needs to be ported to the new XML parsing code but
implements the new format.
Daniel
2008-07-28 14:06:54 +00:00
Daniel Veillard
387e06421f
* src/qemu_driver.c: patch from Guido Günther to make sure create
...
doesn't override an existing domain definition or UUID
Daniel
2008-07-28 12:52:37 +00:00
Daniel P. Berrange
c5ecc66658
Fix misc typos in domain XML handling
2008-07-25 16:25:11 +00:00
Daniel P. Berrange
e8a84817d4
Remove unused c-ctype.h include
2008-07-25 16:19:00 +00:00
Daniel P. Berrange
9351cb0ab0
Fix reporting of errors against virConnect object in XML apis
2008-07-25 14:27:25 +00:00
Daniel P. Berrange
cb29913fb1
Switch XM config file driver to use new domain APIs for XML to config conversion
2008-07-25 14:10:49 +00:00
Daniel P. Berrange
547bd71a4a
Switch XM config file driver to use new domain APIs for XML generation
2008-07-25 13:50:08 +00:00
Daniel P. Berrange
225fb3e93c
Prepare xm_internal driver for new domain XML apis
2008-07-25 13:39:02 +00:00
Daniel P. Berrange
73d021c5c1
Fix test driver inactive domains and domain ID allocation
2008-07-25 13:27:12 +00:00
Daniel P. Berrange
8c6f5a546b
Convert XenD XML->SEXPR conversion to new domain XML APIs
2008-07-25 13:17:27 +00:00
Daniel Veillard
5ee15074af
Skip python bindings for virDomainBlockPeek and virDomainMemoryPeek
...
* python/generator.py: skip generation for virDomainBlockPeek and
virDomainMemoryPeek as they break the build
Daniel
2008-07-25 12:37:06 +00:00
Daniel P. Berrange
31ac8125b8
Convert XenD SEXPR->XML convesion to new domain XML APIs
2008-07-25 10:49:33 +00:00
Daniel P. Berrange
d9383fe158
Remove unused/no-op Xen driver code
2008-07-25 09:51:23 +00:00
Daniel P. Berrange
0b4f277845
Enable openvz, lxc and xen proxy in automated builds
2008-07-25 09:43:23 +00:00
Daniel P. Berrange
3de646a51d
Misc bug fixes
2008-07-25 09:31:24 +00:00
Daniel Veillard
c1e6cc1969
* src/qemu_driver.c: some uuid to string conversion were missing
...
patch from Guido Günther
Daniel
2008-07-25 09:01:25 +00:00
Daniel Veillard
01fd287bcd
Remove Xen centric comments, rebuild the docs
...
* include/libvirt/libvirt.h include/libvirt/libvirt.h.in:
remove Xen centric comments patch from Guido Günther
* docs/apibuild.py: ignore VIR_DEPRECATED
* docs/libvirt-*.xml docs/html/libvirt-*.html: regenerated the
documentation for the API
Daniel
2008-07-25 08:52:19 +00:00
Daniel Veillard
6fae611381
wrong open() failure detection
...
* src/qemu_driver.c: Guido Trotter pointed out a wrong open() failure
detection
Daniel
2008-07-25 08:42:05 +00:00
Daniel Veillard
388502750e
* docs/libvirt.rng: patch from John Levon fixing various patterns
...
Daniel
2008-07-25 06:37:20 +00:00
Daniel Veillard
27efc8bd0d
Check for already running QEmu domain on create
...
* src/qemu_driver.c: another patch from Guido Günther checking
for an already running domain on create
Daniel
2008-07-24 07:29:50 +00:00
Daniel Veillard
d3bb1e4367
* src/qemu_driver.c: patch from Guido Günther checking for
...
unsupported migrate command
Daniel
2008-07-24 07:09:45 +00:00
Daniel Veillard
9d39ca744e
documentation for java bindings
...
* docs/java.html docs/java.html.in: added documentation for the
java bindings
Daniel
2008-07-22 17:49:53 +00:00
Jim Meyering
2eb8ab2057
better diagnostic when failing to undefine a running domain via ID
...
* src/virsh.c (cmdUndefine): Tell user to shutdown and then use name or UUID.
* tests/undefine: New test. Exercise virsh's undefine command.
* tests/Makefile.am (test_scripts): Add undefine.
2008-07-22 16:12:01 +00:00
Daniel Veillard
7e73b8b61a
cleaning up integer string parsing
...
* src/openvz_conf.c src/openvz_driver.c: patch from Evgeniy Sokolov
cleaning up integer string parsing.
Daniel
2008-07-21 13:34:19 +00:00
Daniel Veillard
403a5163c9
* src/xen_unified.c: fix a leak in xenUnifiedOpen
...
Daniel
2008-07-21 09:48:01 +00:00
Daniel Veillard
7b4f67acea
OpenVZ domain cpu time
...
* src/openvz_driver.c: patch from Evgeniy Sokolov to get OpenVZ
domain cpu time consumption.
Daniel
2008-07-21 08:08:25 +00:00
Daniel Veillard
92b56c0412
xen lib detection patch on 64bits
...
* configure.in: patch from David Lively to try to detect the xen
libs when using --with-xen-distdir= on 64bit arches.
Daniel
2008-07-21 08:03:58 +00:00
Daniel Veillard
cb3e65e922
* src/openvz_driver.c: patch from Evgeniy Sokolov avoiding domain
...
lookups based on ID as this doesn't work for a stopped domain.
Daniel
2008-07-21 07:31:14 +00:00
Jim Meyering
3ff5480d7b
remove unnecessary "V = NULL;" stmts after VIR_FREE(V)
...
* src/domain_conf.c (virDomainChrDefParseXML)
(virDomainNetDefParseXML): Likewise.
* src/iptables.c (iptRuleFree): Likewise.
* src/storage_backend.c (virStorageBackendRunProgRegex): Likewise.
* src/test.c (testOpenFromFile): Likewise.
* src/xmlrpc.c (xmlRpcCallRaw): Likewise.
2008-07-19 07:42:34 +00:00
Jim Meyering
cff27e9f40
enable format-safety checks for virDomainReportError
...
* src/domain_conf.c (virDomainReportError): Declare using
ATTRIBUTE_FORMAT(printf, 3, 4).
* Makefile.maint (msg_gen_function): Add virDomainReportError.
2008-07-18 11:02:18 +00:00
Daniel Veillard
dfccabe1e7
fix pool-create for netfs format 'auto'
...
* src/storage_backend_fs.c: patch from Cole Robinson fixing
pool-create for netfs format 'auto'
Daniel
2008-07-17 15:20:28 +00:00
Daniel Veillard
16b8942966
undefine command can't take an ID
...
* src/virsh.c: patch from Evgeniy Sokolov for the undefine command
which can't take an id
Daniel
2008-07-17 11:49:15 +00:00
Daniel Veillard
edbbb3aa12
ID domain lookup fixup
...
* src/libvirt.c src/openvz_driver.c: fix the description of the ID
domain lookup and fix the OpenVZ routine
Daniel
2008-07-16 20:42:38 +00:00
Daniel Veillard
07601749e8
lookup by ID function and error report fix for OpenVZ
...
* src/openvz_driver.c: fix the lookup by ID function and error
reporting in OpenVZ, fix by Evgeniy Sokolov
Daniel
2008-07-16 15:27:00 +00:00
Daniel Veillard
5553b0cd16
cleaning up the exec calls to OpenVZ binaries
...
* src/openvz_driver.c: another cleanup patch from Evgeniy Sokolov
cleaning up the exec calls to OpenVZ binaries
Daniel
2008-07-16 14:45:55 +00:00
Daniel P. Berrange
276bffd907
Remove unneccessary include
2008-07-12 13:53:50 +00:00
Daniel P. Berrange
6385fe3ede
Switch QEMU driver over to generic domain APIs
2008-07-11 19:34:11 +00:00
Daniel P. Berrange
774354e3ef
Set initial domain state to SHUTOFF
2008-07-11 19:31:26 +00:00
Daniel P. Berrange
a1b49bcdea
Use full path when loading XML files
2008-07-11 17:59:27 +00:00
Daniel P. Berrange
381fa1fc46
Switch QEMU driver over to generic network APIs
2008-07-11 17:33:45 +00:00
Daniel P. Berrange
d78c0a6800
Convert test driver to new domain XML apis
2008-07-11 16:41:27 +00:00
Daniel P. Berrange
c422fd1240
Convert test driver to new network XML apis
2008-07-11 16:39:08 +00:00
Daniel P. Berrange
d1304583d6
Added generic domain XML APIs
2008-07-11 16:23:36 +00:00
Daniel Veillard
d678a6e88c
fix OpenVZ probe function
...
* src/openvz_driver.c: fix from Evgeniy Sokolov to the probe function
Daniel
2008-07-11 11:09:44 +00:00
Daniel P. Berrange
747fad6654
Generic APIs for network XML configuration
2008-07-11 10:48:34 +00:00
Daniel P. Berrange
69582431a0
Fix booting QEMU off CDROM devices with -drive arg
2008-07-11 09:56:23 +00:00
Daniel P. Berrange
d4f6e9b5bb
Default to admin auth for polkit. Rename policy file
2008-07-11 09:51:25 +00:00
Daniel P. Berrange
5e239b00d6
Don't default to polkit auth when running non-root
2008-07-11 09:50:01 +00:00
Daniel P. Berrange
1d86fca433
Fix parsing of QEMU stdout looking for serial device PTY with Xenner
2008-07-11 09:48:51 +00:00
Daniel Veillard
915b86d29b
cleanup OpenVZ config file accesses
...
* src/openvz_conf.c: cleanup OpenVZ config file accesses, patch
from Evgeniy Sokolov
Daniel
2008-07-11 08:56:16 +00:00
Daniel Veillard
fc2076033b
bug in do_open()
...
* src/libvirt.c: Evgeniy Sokolov found a driver open bug
in do_open()
Daniel
2008-07-10 15:29:39 +00:00
Daniel Veillard
5215d88be2
cleanup OpenVZ error function
...
* src/openvz_conf.c src/openvz_conf.h src/openvz_driver.c
Makefile.maint: patch from Evgeniy Sokolov cleaning up the
error function used and format check based on Jim's fedback.
Daniel
2008-07-10 12:21:09 +00:00
Daniel Veillard
a665a52cb3
domain name validation fix
...
* docs/libvirt.rng: domain name validation fix by John Levon
* AUTHORS: add John Levon
Daniel
2008-07-10 08:05:39 +00:00
Daniel Veillard
47010f352c
* src/openvz_conf.c src/openvz_conf.h src/openvz_driver.c: new
...
patch from Evgeniy Sokolov adding OpenVZ autostart get and set support
Daniel
2008-07-10 07:52:14 +00:00
Daniel Veillard
f7896554e9
Adds Evgeniy to AUTHORS list
...
Daniel
2008-07-09 11:57:40 +00:00
Daniel Veillard
db9bcc9bd4
diagnostic fixes on OpenVZ failures
...
* src/openvz_conf.c src/openvz_conf.h src/openvz_driver.c: applied
patch from Evgeniy Sokolov fixing error diagnostic when exec'ing
OpenVZ commands.
Daniel
2008-07-09 11:55:27 +00:00
Daniel P. Berrange
c207f75890
Fix use of VIR_TEST_DEBUG var when OOM testing is not enabled & surpress more valgrind warnings
2008-07-09 10:27:17 +00:00
Daniel P. Berrange
08397146eb
Remove legacy debug output
2008-07-09 10:18:03 +00:00
Daniel P. Berrange
0fac29a8c6
Fix QEMU test for xen bootloader
2008-07-09 08:46:09 +00:00
Daniel P. Berrange
b897973f2e
Preserve context node when doing XPath queries to allow relative XPath expressions
2008-07-09 08:35:09 +00:00
Jim Meyering
fb2eca4cfd
give a more useful diagnostic for tap-add failure w/ENOTSUP
...
* src/qemu_conf.c (qemudNetworkIfaceConnect):
Suggestion from Daniel P. Berrange.
2008-07-09 05:24:08 +00:00
Daniel P. Berrange
a211db1b8f
Fix typo in domain state constant
2008-07-08 17:49:26 +00:00
Daniel P. Berrange
24cef5fdfd
Fix three typos pointed out by Anton Protopopov
2008-07-08 17:44:56 +00:00
Daniel P. Berrange
95675d4d76
Fix openvz build on x86_64
2008-07-07 11:48:40 +00:00
Daniel P. Berrange
d1b5773ec1
Remove bogus return statement in test code
2008-07-07 10:36:30 +00:00
Daniel P. Berrange
0caf27a2b0
ALlow OOM tests to be parallelized
2008-07-07 10:10:29 +00:00
Daniel Veillard
8d18d826a4
* proxy/libvirt_proxy.c: fix a compilation problem without Xen
...
* libvirt.spec.in: add %{release] to BuildRoot
Daniel
2008-07-07 10:00:30 +00:00
Daniel P. Berrange
bf79e90f3a
Fix memory leak in OOM cleanup
2008-07-07 09:52:26 +00:00
Dan Smith
b6cd099df4
Updated ChangeLog for recent LXC patches
2008-07-02 14:20:10 +00:00
Atsushi SAKAI
fa97486070
Compilation fix for MinGW(w/ LXC)
2008-06-30 05:11:13 +00:00
Atsushi SAKAI
f3c3550771
Fix make syntax-check
2008-06-26 10:56:19 +00:00
Atsushi SAKAI
fbb5d771a0
Compilation fixes for MinGW
2008-06-26 09:37:51 +00:00
Jim Meyering
9c593643ff
quiet "make syntax-check"
...
* Makefile.maint (strftime-check): Add "@" prefix.
(po-check): Likewise.
2008-06-25 14:21:44 +00:00
Daniel Veillard
2de7d9d224
* python/types.c: patch from Ryan Scott to remove misplaced verbosity
...
when compiling in debug mode.
Daniel
2008-06-25 11:42:27 +00:00
Daniel Veillard
93db3c61c0
* configure.in NEWS libvirt.spec* doc/* po/*: making libvirt-0.4.4
...
release
* src/xm_internal.c: fix xm driver serialization escapes
* tests/xmconfigtest.c tests/xmconfigdata/test-escape-paths.cfg
tests/xmconfigdata/test-escape-paths.xml: add test for previous
problem
Daniel
2008-06-25 08:59:37 +00:00
Daniel Veillard
3f6d44e9c9
* po/*: updated a couple of localizations and regenerated the
...
files
Daniel
2008-06-25 08:49:54 +00:00
Daniel P. Berrange
47605e1dfa
Added helpers for dealing with enumerations
2008-06-24 15:00:15 +00:00
Daniel P. Berrange
313f1a7c0d
Fix const-ness of virStorageBackendRunProgRegex()
2008-06-24 14:30:25 +00:00
Daniel Veillard
1ec7cccbd3
fix a couple of List functions for max = 0 issues
...
* src/xen_internal.c src/xend_internal.c: fix a couple of issues
for List functions where max given is 0
Daniel
2008-06-19 14:39:49 +00:00
Jim Meyering
e09fab39a8
virsh fails to read files larger than BUFSIZ bytes
...
* src/util.c (fread_file_lim): Use VIR_REALLOC_N, not VIR_ALLOC_N.
Bug introduced in 895d0fdf5b
.
* tests/Makefile.am (test_scripts): Add read-bufsiz.
* tests/read-bufsiz: New test for the above.
2008-06-19 14:30:52 +00:00
Chris Lalancette
2dc11b36a1
Update the changelog to go along with my commits for the last week.
2008-06-19 14:22:54 +00:00
Daniel Veillard
a48f26c718
adding autogen.sh to EXTRA_DIST
...
* Makefile.am: adding autogen.sh to EXTRA_DIST
Daniel
2008-06-13 09:08:44 +00:00
Daniel Veillard
5ba9e91e52
* src/qemu_conf.c: patch from Kaitlin Rupert, dynamic devices
...
for network should be defined in an 'interface' node not 'net'
Daniel
2008-06-13 07:56:59 +00:00
Daniel Veillard
7db4c905d7
* configure.in NEWS libvirt.spec* doc/* po/*: making libvirt-0.4.3
...
release
Daniel
2008-06-12 16:10:50 +00:00
Daniel P. Berrange
841dd882a4
Fix misc compile warnings
2008-06-12 13:48:29 +00:00
Daniel P. Berrange
db162cb2b8
Fix saving of iptables rules
2008-06-12 13:47:38 +00:00
Daniel P. Berrange
74fb2b9704
Deal with inactive virtual network in domain creation
2008-06-12 10:19:24 +00:00
Daniel Veillard
5d14e4fcce
* src/qemu_driver.c: patch from Kaitlin Rupert, changing vcpu or
...
memory of an active domain is a NO_SUPPORT not INTERNAL_ERROR
Daniel
2008-06-12 08:55:13 +00:00
Daniel Veillard
d7f62fefed
po regeneration
...
* po/*: update and regenerated
Daniel
2008-06-11 15:22:24 +00:00
Daniel P. Berrange
357bf10553
Fix RPM build
2008-06-11 11:26:36 +00:00
Daniel Veillard
c0626a02a9
* python/libvir.py python/libvirt-python-api.xml: more python
...
cleanups by Cole Robinson
Daniel
2008-06-11 07:49:01 +00:00
Daniel Veillard
b0a3d6809a
* configure.in: patch from Cole Robinson to reactivate storage
...
support
Daniel
2008-06-10 15:35:15 +00:00
Daniel Veillard
cb96ae2583
* python/generator.py python/libvir.c python/libvirt-python-api.xml:
...
Apply patch from Cole Robinson fixing UUIDString for python
Daniel
2008-06-10 15:20:25 +00:00
Richard W.M. Jones
406d896363
Pass syntax check for XM block devices over to XenD
...
* src/xm_internal.c: Pass responsibility for checking syntax
of XM block devices over the XenD (see also Xen cset 17617).
(Hiroyuki Kaguchi).
2008-06-10 14:39:58 +00:00
Richard W.M. Jones
6bcf25017b
virDomainMemoryPeek API
...
* include/libvirt/libvirt.h.in, src/libvirt.c, src/driver.h,
src/libvirt_sym.version: New virDomainMemoryPeek API.
* qemud/remote.c, qemud/remote_protocol.x, src/remote_internal.c:
Support for remote.
* src/qemu_driver.c: QEMU driver implementation of API.
* src/test.c: Test driver (null) implementation of API.
* docs/hvsupport.html.in: Document API.
* libvirt.spec.in: New path /var/cache/libvirt for temporary
storage of memory images.
* qemud/libvirtd.init.in: Remove any old temp files in
/var/cache/libvirt on restarts.
* src/Makefile.am: make install creates /var/cache/libvirt.
* configure.in: Detect mkdir -p.
2008-06-10 10:43:28 +00:00
David L. Leskovec
0d0c96722c
Mon Jun 9 15:42:34 PST 2008 David L. Leskovec <dlesko@linux.vnet.ibm.com>
...
* src/lxc_driver.c: Make console element is output only. Always open new
PTY when starting a container.
Fix string overrun when storing console name in VM def struct
2008-06-09 22:51:32 +00:00
Richard W.M. Jones
787e44a1d0
Better error messages in xend driver.
...
* src/xend_internal.c: Change virXendError function to take
varargs. Better error messages throughout.
2008-06-09 12:16:03 +00:00
Daniel P. Berrange
d789ef5a88
Switch over remaining driver code to use memory alloc apis
2008-06-06 11:09:57 +00:00
Daniel P. Berrange
d7d21c85e0
Switch daemon over to use internal memory allocation APIs
2008-06-06 10:52:01 +00:00
Richard W.M. Jones
a73a88a19f
virDomainBlockPeek QEMU and remote support
...
* qemud/remote.c, qemud/remote_protocol.x, src/remote_internal.c:
Remote support.
* qemud/remote_dispatch_localvars.h,
qemud/remote_dispatch_proc_switch.h,
qemud/remote_dispatch_prototypes.h,
qemud/remote_protocol.c,
qemud/remote_protocol.h:
Generated files for remote support.
* src/xen_unified.c, src/driver.h, src/libvirt.c: Small fix -
pass flags around internally.
* src/qemu_driver.c: Support for QEMU.
* src/xend_internal.c: Remove redundant fstat call from Xen.
2008-06-05 21:12:26 +00:00
Richard W.M. Jones
8354895e68
virDomainBlockPeek call
...
* configure.in: Document AC_SYS_LARGEFILE.
* docs/hvsupport.html.in: Document HV support for virDomainBlockPeek.
* include/libvirt/libvirt.h.in, src/driver.h, src/libvirt.c,
src/libvirt_sym.version: Add virDomainBlockPeek infrastructure.
* src/qemu_driver.c, src/test.c: Null versions of this call.
* src/xen_unified.c, src/xend_internal.c, src/xend_internal.h,
src/xm_internal.c, src/xm_internal.h: Xen implementation.
* tests/sexpr2xmldata/sexpr2xml-curmem.xml,
tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml: XML output
has been reordered slightly in the Xen driver, but should be
functionally the same.
2008-06-05 13:17:45 +00:00
David L. Leskovec
0bd57cdbe1
Fix a few issues related to restart of libvirtd with containers running.
...
Mon May 12 23:32:21 PST 2008 David L. Leskovec <dlesko@linux.vnet.ibm.com>
* src/lxc_driver.c: Add sanity of tty pid before kill()
Ignore ECHILD errors during VM cleanup
Call functions to store tty pid and cleanup tty pid file
* src/lxc_conf.h: Add function to verify container process exists
Add facilities to manage storing the tty forward process pid
* src/lxc_conf.c: Add function to verify container process exists
Call function to verify container process during config load
Add facilities to manage storing the tty forward process pid
Call function to load tty pid during load config
2008-06-05 06:03:00 +00:00
Richard W.M. Jones
eeb224b812
* src/xm_internal.c: If vcpu cpuset attribute is invalid
...
then display an error instead of silently ignoring it
(Hiroyuki Kaguchi).
2008-06-03 08:01:45 +00:00
Richard W.M. Jones
4a9ebf7da7
General tips for contributing patches
...
* HACKING: Added section "general tips for contributing patches"
to this file.
2008-06-02 11:53:23 +00:00
Daniel P. Berrange
f855e91f11
Only run coverage tests if lcov is installed
2008-05-29 20:43:08 +00:00
Daniel P. Berrange
d007428ddb
Fix make dist
2008-05-29 20:09:56 +00:00
Daniel P. Berrange
84494d2e0a
Fix warning with OOM testing is disabled
2008-05-29 19:41:40 +00:00
Daniel P. Berrange
aa2bb9c88c
Switch to using lcov for code coverage repots
2008-05-29 19:27:04 +00:00
Daniel P. Berrange
5e124764c1
Fix parted check & disable storage driver if daemon isn't present
2008-05-29 19:23:17 +00:00
Daniel P. Berrange
895d0fdf5b
Convert to use new memory allocation APIs
2008-05-29 19:20:22 +00:00
Daniel P. Berrange
e8a0db81ef
Pass allocation number to callback
2008-05-29 18:47:00 +00:00
Daniel P. Berrange
46f52f32b2
Convert to use new memory allocation APIs
2008-05-29 18:45:36 +00:00
Daniel P. Berrange
489da1c4b1
Fix missing check for memory allocation failure
2008-05-29 18:45:07 +00:00
Daniel P. Berrange
4b23495509
Convert test suites over to new test infrastructure
2008-05-29 15:31:49 +00:00
Daniel P. Berrange
b0bcffda3b
Misc OOM / memory leak fixes
2008-05-29 15:28:28 +00:00
Daniel P. Berrange
364f53a67a
Generic test suite helpers for OOM testing
2008-05-29 15:21:45 +00:00
Daniel P. Berrange
18da6991e1
Generic OOM testing hooks
2008-05-29 15:13:07 +00:00
Daniel P. Berrange
a9d4944f8e
Don't add trailing blanks in dominfo output
2008-05-29 14:56:12 +00:00
Daniel P. Berrange
2168e27738
Fix python code generation for storage APIs
2008-05-29 14:53:58 +00:00
Atsushi SAKAI
2b483bfaf5
Fix make syntax-check caused by trailing blanks
2008-05-29 05:21:53 +00:00
Richard W.M. Jones
ec8b5b605e
Fix virsh dominfo test.
...
* tests/virshdata/dominfo-fc4.txt: 'virsh dominfo' test
matches actual output with autostart status.
2008-05-27 13:51:52 +00:00
Richard W.M. Jones
5c9454aa6e
Display autostart status in virsh dominfo command.
...
* src/virsh.c: Display autostart status in virsh dominfo
command (Shigeki Sakamoto).
2008-05-27 09:41:25 +00:00
Richard W.M. Jones
e083fc786c
Fix use of header files in disk storage backend.
...
* src/storage_backend_disk.c: Include internal.h to resolve use
of header files.
2008-05-27 08:56:56 +00:00
Richard W.M. Jones
f60dc0bc09
Deprecate the conn, dom and net fields in the _virError structure.
...
* include/libvirt/libvirt.h.in: Add VIR_DEPRECATED macro.
* src/internal.h: Internal code is allowed to use deprecated
features, so override VIR_DEPRECATED here.
* include/libvirt/virterror.h: Deprecate the conn, dom and net
fields in the _virError structure.
2008-05-23 08:32:08 +00:00
Richard W.M. Jones
1d8d4f86b6
Standardize use of header files, making internal.h primary.
...
* qemud/internal.h, qemud/qemud.h: Rename this file so it
doesn't conflict with src/internal.h.
* HACKING: Document how header files should be used.
* qemud/Makefile.am: Add src/ directory to includes.
* qemud/event.c, qemud/mdns.c, qemud/qemud.c, qemud/remote.c,
qemud/remote_protocol.c, qemud/remote_protocol.h,
qemud/remote_protocol.x, src/buf.c, src/libvirt.c,
src/nodeinfo.c, src/qemu_conf.c, src/qemu_driver.c,
src/stats_linux.c, src/storage_backend.c, src/storage_backend_fs.c,
src/storage_backend_iscsi.c, src/storage_backend_logical.c,
src/storage_conf.c, src/storage_driver.c, src/util.c,
src/util.h, src/virsh.c, src/virterror.c, src/xend_internal.c,
src/xml.c, tests/reconnect.c, tests/xmlrpctest.c,
tests/qparamtest.c: Standardize use of header files.
* docs/*, po/*: Rebuild docs.
2008-05-23 08:24:41 +00:00
Richard W.M. Jones
c132e0f712
Fix type-punning warning in remote code.
...
* qemud/rpcgen_fix.pl: Case-insensitive string match on identifiers.
* qemud/remote_protocol.c: Update this generated file.
2008-05-23 07:59:00 +00:00
Daniel P. Berrange
9dc31e159a
Fix misc leaks in qparams code, support ; as param separator. Add test suite
2008-05-22 23:49:36 +00:00
Daniel P. Berrange
7646d59568
Refactor QEMU command line building code for readability
2008-05-22 23:45:09 +00:00
Daniel P. Berrange
e193b5ddea
Apply CPU pinning at startup for QEMU guests
2008-05-22 16:27:20 +00:00
Daniel P. Berrange
6d372bd468
Add support for VCPU pinning in QEMU driver
2008-05-22 16:20:31 +00:00
Daniel P. Berrange
7852a63443
Added missing config.h import
2008-05-22 16:18:40 +00:00
Daniel P. Berrange
42aec3d000
Fix removal of iptable forwarding rules
2008-05-22 15:49:50 +00:00
Daniel P. Berrange
3e1aeff4c5
Remove duplicated error messages
2008-05-22 15:40:01 +00:00
Daniel P. Berrange
6a48a6a9e7
Fix misleading comment about numactl
2008-05-22 15:35:51 +00:00
Daniel P. Berrange
b0d340be77
Quote all args to configure.in macros
2008-05-22 15:34:02 +00:00
Daniel P. Berrange
508c4226e1
Implement NUMA info/apis in QEMU driver
2008-05-22 15:29:50 +00:00
Daniel P. Berrange
ab5be538f3
Wire up free memory APIs to remote driver/daemon
2008-05-22 15:20:25 +00:00
Daniel P. Berrange
dd674689df
Fix misc memory leaks
2008-05-22 15:12:25 +00:00
Daniel Veillard
8e5c89ba64
"copy-paste" errors
...
* docs/formatdomain.html docs/formatdomain.html.in: Anton Protopopov
pointed out a few "copy-paste" errors
daniel
2008-05-22 14:57:32 +00:00
Daniel P. Berrange
ecb117a4a8
Fix exit status check with qemu -help
2008-05-21 21:14:36 +00:00
Daniel P. Berrange
e866e302f8
Fixed couple of memory leaks wrt to virXXXDestroy APIs, and clarify docs to match reality
2008-05-21 20:53:30 +00:00
Daniel P. Berrange
922fbeb8b7
Don't free C object after destroy method in python
2008-05-21 20:18:20 +00:00
Daniel P. Berrange
3af422a82e
Run qemu with -help when probing for args
2008-05-21 19:43:39 +00:00
Daniel P. Berrange
8049357ded
Avoid initializing driver if pidfie is claimed. Always claim pidfile as root
2008-05-20 16:17:36 +00:00
Daniel Veillard
1290f50284
Notes on the use of listen_tls/listen_tcp
...
* docs/remote.html docs/remote.html.in: patch from Kenneth Nagin
with Notes on the use of listen_tls/listen_tcp
Daniel
2008-05-20 15:55:00 +00:00
Jim Meyering
f011f263a1
plug two leaks
...
* src/qemu_conf.c (qemudParseXML): Free "obj" unconditionally.
2008-05-16 16:53:44 +00:00
Daniel P. Berrange
40a82f3066
Make QEMU test suite independant of host OS capabilities
2008-05-16 16:51:30 +00:00
Jim Meyering
a770c2ab1c
* src/xml.c: Include "c-ctype.h".
2008-05-16 14:18:38 +00:00
Jim Meyering
c1ee35af3b
start using c-ctype functions
...
Up to now, we've been avoiding ctype functions like isspace, isdigit,
etc. because they are locale-dependent. Now that we have the c-ctype
functions, we can start using *them*, to make the code more readable
with changes like these:
- /* This may not work on EBCDIC. */
- if ((*p >= 'a' && *p <= 'z') ||
- (*p >= 'A' && *p <= 'Z') ||
- (*p >= '0' && *p <= '9'))
+ if (c_isalnum(*p))
- while ((*cur >= '0') && (*cur <= '9')) {
+ while (c_isdigit(*cur)) {
Also, some macros in conf.c used names that conflicted with
standard meaning of "BLANK" and "SPACE", so I've adjusted them
to be in line with the definition of e.g., isblank.
In addition, I've wrapped those statement macros with do {...} while (0),
so that we can't forget the ";" after a use. There was one like that
already (fixed below). The missing semicolon would mess up automatic
indenting.
* src/buf.c (virBufferURIEncodeString):
* src/conf.c (IS_EOL, SKIP_BLANKS_AND_EOL, SKIP_BLANKS)
(virConfParseLong, virConfParseValue, virConfParseName)
(virConfParseSeparator, virConfParseStatement, IS_BLANK, IS_CHAR)
(IS_DIGIT, IS_SPACE, SKIP_SPACES):
* src/nodeinfo.c:
* src/qemu_conf.c (qemudParseInterfaceXML):
* src/qemu_driver.c (qemudDomainBlockStats):
* src/sexpr.c:
* src/stats_linux.c:
* src/util.c (virParseNumber, virDiskNameToIndex):
* src/uuid.c (hextobin, virUUIDParse):
* src/virsh.c:
* src/xml.c (parseCpuNumber, virParseCpuSet):
2008-05-16 09:37:44 +00:00
Jim Meyering
0dc23afb0c
avoid a double-free bug
...
* src/qemu_conf.c (qemudParseXML): Ensure that "obj" is either
NULL or a valid malloc'd pointer before we might "goto error"
where it is freed.
2008-05-16 09:30:10 +00:00
Daniel P. Berrange
65c2738ea1
Remove use of strcmp()
2008-05-15 20:07:34 +00:00
Daniel P. Berrange
25f860dc2f
Fixe default disk bus selection logic
2008-05-15 16:24:26 +00:00
Daniel P. Berrange
763a59d84d
Support Xenner bootloader
2008-05-15 16:21:11 +00:00
Daniel P. Berrange
0f1b6dd06a
Pass -name arg to QEMU when available
2008-05-15 16:15:17 +00:00
Daniel P. Berrange
3a7b528d4b
Add support for Xen input device in QEMU driver for xenner
2008-05-15 16:11:40 +00:00
Daniel P. Berrange
2c37f47985
Support paravirt disk configuration for xenner guests
2008-05-15 16:05:41 +00:00
Jim Meyering
6049594045
avoid using STREQLEN with a literal; use STRPREFIX instead
...
Likewise for STRNEQLEN -> !STRPREFIX.
* src/nodeinfo.c (linuxNodeInfoCPUPopulate):
* src/qemu_conf.c (qemudNetworkIfaceConnect):
(qemudParseInterfaceXML):
* src/qemu_driver.c (qemudDomainBlockStats):
* src/remote_internal.c (call):
* src/stats_linux.c (xenLinuxDomainDeviceID):
* src/xend_internal.c (xend_parse_sexp_desc):
(xend_get, sexpr_to_xend_topology):
* src/xm_internal.c (xenXMConfigCacheRefresh)
(xenXMDomainFormatXML):
2008-05-15 14:21:34 +00:00
Jim Meyering
abb9a583a0
* Makefile.maint (sc_prohibit_strcmp): Also prohibit strncmp.
2008-05-15 07:12:43 +00:00
Atsushi SAKAI
b87f3000aa
Change libvirtd description from qemu only to various VM(i.e. Xen, LXC)
...
Fix typos and comments
2008-05-15 06:12:32 +00:00
Jim Meyering
13555de861
exempt gnulib/ from "make syntax-check" strcmp prohibition
...
* .x-sc_prohibit_strcmp: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_prohibit_strcmp.
2008-05-14 21:18:27 +00:00
Daniel P. Berrange
f7fe78dc82
Added listen_addr config param for daemon (Stefan de Konink)
2008-05-14 20:57:20 +00:00
Daniel P. Berrange
1d73398e8f
Remove all use of strcmp, strncmp in favour of STREQ, STREQLEN, STRPREFIX
2008-05-14 19:51:24 +00:00
Jim Meyering
e830d52573
avoid "not a string literal..." warnings
...
* src/qemu_conf.c (qemudParseInterfaceXML): Add "%s".
(qemudBuildCommandLine, qemudGenerateXML): Likewise.
2008-05-13 09:15:11 +00:00
David L. Leskovec
773d59e86d
Fix some stray leading spaces in Changelog entry for my last commit
2008-05-13 06:51:42 +00:00
David L. Leskovec
94311de539
Enable libvirtd drivers to handle signals, in lxc, sigchld triggers vm cleanup
...
Mon May 12 23:32:21 PST 2008 David L. Leskovec <dlesko@linux.vnet.ibm.com>
* qemud/qemud.c: get siginfo with signals, distribute to drivers that
register a handler
* src/driver.h: add sighandler function to state driver table
* src/internal.h: define virStateSigDispatcher functions
* src/libvirt.c: add __virStateSigDispatcher function
* src/libvirt_sym.version: add __virStateSigDispatcher
* src/lxc_driver.c: add sig handler function, cleanup vm when sigchld
received from container process
* src/qemu_driver.c: NULL for sig handler (no handler) in state driver
* src/remote_internal.c: NULL for sig handler (no handler) in state driver
* src/storage_driver.c: NULL for sig handler (no handler) in state driver
2008-05-13 06:30:58 +00:00
Daniel P. Berrange
098ba1a433
Add support for -drive QEMU syntax, and virtio bus / disk type
2008-05-09 16:41:19 +00:00
Jim Meyering
7967662a52
Add new files from gnulib.
...
* gnulib/lib/c-ctype.c: New file.
* gnulib/lib/c-ctype.h: Likewise.
* gnulib/tests/test-c-ctype.c: Likewise.
* gnulib/tests/test-vc-list-files-git.sh: Likewise.
* gnulib/tests/test-vc-list-files-cvs.sh: Likewise.
2008-05-09 14:03:15 +00:00
Jim Meyering
25534052bc
Use gnulib's c-ctype.h, not <ctype.h>.
...
# Convert uses of isspace to c_isspace, isdigit to c_isdigit, etc.
re=$(man isspace|grep is.....,.is|sed 's/ -.*//' \
|tr -s ', \n' \||sed 's/^|//;s/|$//')
git grep -l -E "$re"|grep -Ev 'Chan|gnulib' \
|xargs perl -pi -e 's/\b('"$re"')\b/c_$1/g'
# Remove all uses of to_uchar
git grep -l to_uchar|xargs perl -pi -e 's/to_uchar\((.*?)\)/$1/g'
* src/util.h (to_uchar): Remove definition.
(TOLOWER): Remove definition.
(__virMacAddrCompare): Use c_tolower, not TOLOWER.
Globally:
Where needed, change <ctype.h> to <c-ctype.h>.
Remove unnecessary inclusion of <ctype.h>.
Ensure the global changes are never needed again:
* Makefile.maint (sc_avoid_ctype_macros): Prohibit use of ctype
macros. Recommend c-ctype.h instead.
(sc_prohibit_c_ctype_without_use): New rule.
(sc_prohibit_ctype_h): New rule. Disallow use of <ctype.h>.
2008-05-09 13:50:14 +00:00
Jim Meyering
82892f131b
Prepare to use gnulib's c-type module.
...
* bootstrap: Move module list into separate variable w/less syntax.
(modules): Add c-ctype.
Update the following from gnulib:
* build-aux/useless-if-before-free:
* build-aux/vc-list-files:
* gnulib/lib/Makefile.am:
* gnulib/lib/getaddrinfo.h:
* gnulib/m4/gnulib-cache.m4:
* gnulib/m4/gnulib-comp.m4:
* gnulib/m4/inet_ntop.m4:
* gnulib/tests/Makefile.am:
* gnulib/tests/test-getaddrinfo.c:
2008-05-09 13:46:09 +00:00
Daniel Veillard
5e1bd04692
autostart for running Xen domains
...
* src/xen_unified.c src/xend_internal.c src/xend_internal.h: patch
from Cole Robinson implementing autostart for running Xen domains
Daniel
2008-05-09 08:17:18 +00:00
Jim Meyering
eb046f9d59
sytnax-check: add a check for risky ctype macro use
...
* Makefile.maint (sc_risky_ctype_macros): New rule.
2008-05-09 08:11:13 +00:00
Jim Meyering
b8111adf35
avoid one more ctype vs. sign-extension problem
...
* src/util.c (TOLOWER): Also convert tolower argument.
2008-05-09 08:09:48 +00:00
Jim Meyering
712251009b
add "const" and "static" attributes to file-scoped globals
...
* src/storage_backend_fs.c (fileTypeInfo): Add "static" and two
"const" attributes.
(FileTypeInfo): Name the previously anonymous struct,
so the declaration of fileTypeInfo looks more conventional.
* src/xend_internal.c (sound_models): Mark as static, and
as an array of "const" entries.
These were relatively new additions to the list from here:
nm src/*.o|grep ' D '
2008-05-09 08:02:44 +00:00
David L. Leskovec
6ca76333f3
*** empty log message ***
2008-05-09 07:16:30 +00:00
Daniel P. Berrange
d9691ab277
Added some notes about libvirt string/memory/buffer functions
2008-05-08 14:49:53 +00:00
Daniel P. Berrange
021bd31706
Added disk target bus type to Xen driver
2008-05-08 14:41:56 +00:00
Daniel P. Berrange
979edb4a64
Update domain XML docs
2008-05-08 14:20:07 +00:00
Daniel P. Berrange
7b21582e2d
Fix polkit docs
2008-05-08 11:52:21 +00:00
Daniel P. Berrange
31b17e6d44
Disable sound functions when in proxy
2008-05-07 18:50:23 +00:00
Daniel Veillard
da6316f20e
SetVcpus and DomainGetMaxVcpus for QEmu
...
* src/qemu_conf.c src/qemu_conf.h src/qemu_driver.c: another patch
from Cole Robinson adding SetVcpus and DomainGetMaxVcpus for QEmu
Daniel
2008-05-07 16:16:44 +00:00
Daniel Veillard
0feb4c9552
More regression tests for sound support
...
* tests/qemuxml2argvdata/qemuxml2argv-sound.args
tests/qemuxml2argvdata/qemuxml2argv-sound.xml
tests/sexpr2xmldata/sexpr2xml-fv-sound-all.sexpr
tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml
tests/sexpr2xmldata/sexpr2xml-fv-sound.sexpr
tests/sexpr2xmldata/sexpr2xml-fv-sound.xml
tests/xmconfigdata/test-fullvirt-sound.cfg
tests/xmconfigdata/test-fullvirt-sound.xml
tests/xml2sexprdata/xml2sexpr-fv-sound.sexpr
tests/xml2sexprdata/xml2sexpr-fv-sound.xml: other regression
tests from previous commit
Daniel
2008-05-07 14:44:20 +00:00
Daniel Veillard
70f446631f
Sound support for QEmu and Xen
...
* src/qemu_conf.c src/qemu_conf.h src/xend_internal.c
src/xend_internal.h src/xm_internal.c src/xml.c src/xml.h:
Patch from Cole Robinson adding sound support for QEmu and Xen
* tests/qemuxml2argvtest.c tests/sexpr2xmltest.c
tests/xmconfigtest.c tests/xml2sexprtest.c:
Associated regression tests
Daniel
2008-05-07 14:04:40 +00:00
Daniel P. Berrange
2afd1db4a2
Fix build on F9 with missing stddefs.h include
2008-05-06 21:44:12 +00:00
Jim Meyering
924e953f47
* build-aux/vc-list-files: Add support for bzr.
...
Author: Soren Hansen <soren@ubuntu.com>
2008-05-06 21:23:20 +00:00
Daniel P. Berrange
db3f10c807
Check in /usr/sbin for iptables too, for SUSE distros (Jim Fehlig)
2008-05-05 19:58:56 +00:00
Daniel P. Berrange
b04e40d6a3
Remove bogus check for NULL in qparams breaking connections
2008-05-01 18:11:03 +00:00
Daniel P. Berrange
3bc5510a63
Remove compat macros now present in onceonly.m4
2008-04-30 16:32:26 +00:00
Jim Meyering
07efaf941f
update from gnulib, again
...
* gnulib/m4/onceonly.m4: New file.
* gnulib/m4/printf.m4: New file.
* build-aux/useless-if-before-free: Update.
* build-aux/vc-list-files: Update.
* gnulib/lib/arpa_inet.in.h: Update.
* gnulib/lib/stdio-impl.h: Update.
* gnulib/m4/inet_ntop.m4: Update.
2008-04-30 16:11:08 +00:00
Daniel P. Berrange
a9420c223e
Add compat for RHEL-5 autoconf
2008-04-30 15:54:40 +00:00
Daniel P. Berrange
159cb2b97c
Added support for network interface model setting
2008-04-30 12:30:55 +00:00
Jim Meyering
303277a8dc
* gnulib/lib/stdio-impl.h: Add another new file from gnulib.
2008-04-29 21:43:50 +00:00
Jim Meyering
eb6c33cd97
* gnulib/tests/test-EOVERFLOW.c: Add another new file from gnulib.
2008-04-29 21:39:38 +00:00
Jim Meyering
ffdc37c2aa
Fix build errors.
...
* proxy/Makefile.am (libvirt_proxy_LDADD): Add ../gnulib/lib/libgnu.la.
* gnulib/lib/arpa_inet.in.h: Add new file from gnulib.
2008-04-29 21:23:34 +00:00
Jim Meyering
130426c659
update from gnulib
...
* gnulib/lib/inet_ntop.h: Remove file.
* gnulib/m4/onceonly_2_57.m4: Remove file.
* build-aux/useless-if-before-free: Update.
* build-aux/vc-list-files: Update.
* gnulib/lib/.cvsignore: Update.
* gnulib/lib/Makefile.am: Update.
* gnulib/lib/fseeko.c: Update.
* gnulib/lib/getaddrinfo.c: Update.
* gnulib/lib/getdelim.c: Update.
* gnulib/lib/inet_ntop.c: Update.
* gnulib/lib/inet_ntop.h: Update.
* gnulib/lib/poll.c: Update.
* gnulib/lib/snprintf.c: Update.
* gnulib/lib/stdlib.in.h: Update.
* gnulib/lib/string.in.h: Update.
* gnulib/lib/sys_socket.in.h: Update.
* gnulib/lib/sys_stat.in.h: Update.
* gnulib/lib/vasnprintf.c: Update.
* gnulib/lib/vasprintf.c: Update.
* gnulib/lib/wchar.in.h: Update.
* gnulib/m4/arpa_inet_h.m4: Update.
* gnulib/m4/extensions.m4: Update.
* gnulib/m4/gnulib-common.m4: Update.
* gnulib/m4/gnulib-comp.m4: Update.
* gnulib/m4/include_next.m4: Update.
* gnulib/m4/inet_ntop.m4: Update.
* gnulib/m4/netinet_in_h.m4: Update.
* gnulib/m4/onceonly_2_57.m4: Update.
* gnulib/m4/physmem.m4: Update.
* gnulib/m4/snprintf.m4: Update.
* gnulib/m4/stdint.m4: Update.
* gnulib/m4/stdio_h.m4: Update.
* gnulib/m4/stdlib_h.m4: Update.
* gnulib/m4/string_h.m4: Update.
* gnulib/m4/strndup.m4: Update.
* gnulib/m4/sys_select_h.m4: Update.
* gnulib/m4/sys_socket_h.m4: Update.
* gnulib/m4/sys_stat_h.m4: Update.
* gnulib/m4/vasnprintf.m4: Update.
* gnulib/tests/Makefile.am: Update.
* gnulib/tests/test-fseeko.c: Update.
* gnulib/tests/test-getaddrinfo.c: Update.
* gnulib/tests/test-getdelim.c: Update.
* gnulib/tests/test-getline.c: Update.
* gnulib/tests/test-lseek.c: Update.
* gnulib/tests/test-snprintf.c: Update.
* gnulib/tests/test-sys_stat.c: Update.
* gnulib/tests/test-vasnprintf.c: Update.
* gnulib/tests/test-vasprintf.c: Update.
2008-04-29 19:52:26 +00:00
Jim Meyering
0c37f59802
remove useless tests before xmlFree
...
* src/qemu_conf.c (qemudParseDiskXML, qemudParseInterfaceXML):
(qemudParseInputXML, qemudParseDhcpRangesXML):
* src/remote_internal.c (doRemoteOpen):
* src/storage_conf.c (virStoragePoolDefParseDoc):
* src/xm_internal.c (xenXMParseXMLDisk, xenXMParseXMLVif):
(xenXMParseXMLToConfig, xenXMAttachInterface):
* src/xml.c (virDomainParseXMLDiskDesc, virDomainParseXMLIfDesc):
(virDomainXMLDevID):
2008-04-29 19:43:57 +00:00
Daniel P. Berrange
e9c7af6864
Tell gcov to look in .libs to find coverage data
2008-04-29 15:41:30 +00:00
Jim Meyering
12af012644
also check for useless test-before-xmlFree
...
* Makefile.cfg (useless_free_options): Add --name=xmlFree.
2008-04-29 15:06:14 +00:00
Jim Meyering
c3626941c7
tests: recognize more uses of strcmp.
...
* Makefile.maint (sc_prohibit_strcmp): Relax regexp.
2008-04-29 14:25:19 +00:00
Daniel P. Berrange
b1f791adb0
Fix array out of bounds in capabilities code parsing
2008-04-29 14:13:54 +00:00
Daniel P. Berrange
1968468ca4
Added network XML docs
2008-04-29 14:08:08 +00:00
Daniel P. Berrange
7573ce3591
Remove bogus test code accidentally left in previous commit
2008-04-29 13:48:41 +00:00
Jim Meyering
724d0df7e5
Avoid "make syntax-check" failures.
...
* src/memory.c: Include "config.h".
Remove trailing blanks.
2008-04-29 13:37:20 +00:00
Jim Meyering
fe394e0baa
Avoid in-function #if directives.
...
* src/parthelper.c [!PED_PARTITION_PROTECTED]: Define to 0.
Remove in-function #ifdefs.
2008-04-29 13:20:46 +00:00
Richard W.M. Jones
1e43bebf69
* src/parthelper.c: Don't fail if PED_PARTITION_PROTECTED
...
is not defined because of ancient libparted
(Soren Hansen).
2008-04-29 08:17:36 +00:00
Daniel P. Berrange
4ffb0358de
Added safer lowlevel memory allocation APis. Converted hash.c and capabilities.c to use them
2008-04-28 21:44:54 +00:00
Daniel P. Berrange
642b26fab2
Change virBuffer API to prevent common usage errors. Update all users of APIs
2008-04-28 15:14:59 +00:00
Jim Meyering
7301131e42
fix typo in bootstrap script
...
* bootstrap: Fix typo: s/gnulib/.gnulib/. Reported by
Daniel P. Berrange.
2008-04-28 14:12:45 +00:00
Daniel P. Berrange
45008e03ec
Ignore bash bugs under valgrind
2008-04-28 13:36:48 +00:00
Jim Meyering
212472b813
avoid format-related warnings
...
* qemud/qemud.c (main): Fix a bogus format string reported as umarked.
* src/virsh.c (cmdVcpupin): Non-literal with no args.
2008-04-28 09:09:52 +00:00
Daniel Veillard
8383c6640a
* docs/Makefile.am docs/et.png docs/libvirt.css docs/page.xsl
...
docs/*.html docs/html/*.html: removed footer, added sponsor logo
regenerated the html pages also fixed 'make distcheck' as
pointed by Jim.
Daniel
2008-04-28 08:29:35 +00:00
Daniel P. Berrange
e6f1123819
Added full support for serial and parallel devices to Xen drivers
2008-04-26 14:22:02 +00:00
Daniel P. Berrange
49956f0469
Implement serial & parallel device support for QEMU driver
2008-04-25 20:46:13 +00:00
Daniel P. Berrange
d62a9f2390
Adapt layout to workaround IE6 bugs
2008-04-25 16:23:51 +00:00
Daniel Veillard
384c5cff37
group ownership of /var/run/libvirt/
...
* qemud/qemud.c: applied patch from Anton Protopopov to change
group ownership of /var/run/libvirt/ to unix_sock_gid.
Daniel
2008-04-25 15:46:46 +00:00
Jim Meyering
225ba3f0af
avoid problems with sign-extended "char" operand to is* functions
...
* src/util.h (to_uchar): Define function.
* src/nodeinfo.c (linuxNodeInfoCPUPopulate): Apply to_uchar to is* operand.
* src/qemu_driver.c (qemudExtractMonitorPath): Likewise.
* src/sexpr.c (_string2sexpr): Likewise.
* src/stats_linux.c (xenLinuxDomainDeviceID): Likewise.
* src/util.c (TOLOWER, __virMacAddrCompare, virParseMacAddr): Likewise.
* src/virsh.c (cmdVcpupin, vshCommandGetToken): Likewise.
2008-04-25 14:53:05 +00:00
Daniel Veillard
9c38a1d0eb
Sponsor logo
...
* docs/page.xsl docs/redhat.gif docs/*.html: using the shadowman
logo to indicate Red Hat sponsoring, regenerated.
Daniel
2008-04-24 15:20:06 +00:00
Daniel Veillard
3725f7af65
* AUTHORS: update, list people with commit access
...
Daniel
2008-04-24 12:35:28 +00:00
Daniel Veillard
ca5600d29d
fix the search
...
* libvirt.css search.php: fix the search box and PHP output
Daniel
2008-04-24 09:44:00 +00:00
Atsushi SAKAI
2ef22ecee3
* proxy/libvirt_proxy.c and docs/* typo fixing
...
Atsushi
2008-04-24 09:17:29 +00:00
Daniel Veillard
bc4dacb286
Cosmetic doc improvements
...
* AUTHORS: indicate that the Logo is by Diana Fong
* docs/index.py: modify to also index subprojects pages
Daniel
2008-04-24 07:56:37 +00:00
Daniel P. Berrange
c6b067d0c3
Fix generation of NEWS file
2008-04-23 19:39:59 +00:00
Daniel P. Berrange
ea23f5ae45
Fix wiki link in API docs
2008-04-23 17:45:07 +00:00
Daniel P. Berrange
9092c3d491
Split website out into one file per page. APply new layout and styling
2008-04-23 17:08:31 +00:00
Jim Meyering
95a7adf3e6
Enable 'make syntax-check's sc_changelog rule.
...
* Makefile.maint (sc_changelog): Adapt to work with legacy
ChangeLog entry header lines.
* Makefile.cfg (local-checks-to-skip): Remove sc_changelog.
2008-04-21 10:09:07 +00:00
Daniel P. Berrange
b11f2be30e
Python header workaround
2008-04-18 18:31:32 +00:00
Jim Meyering
f41ba90c18
Work around Python.h name-space pollution.
...
* python/libvir.c (HAVE_PTHREAD_H): #undef.
Without this, we'd get a redefinition warning.
2008-04-18 18:07:40 +00:00
Daniel P. Berrange
94353ef660
Re-factor and pretty print differences
2008-04-18 15:28:33 +00:00
Daniel P. Berrange
484559148d
Test script helper for printing string differences
2008-04-18 15:05:29 +00:00
Jim Meyering
2d206f1d7a
avoid compile error when <pthread.h> is absent
...
* src/internal.h (HAVE_PTHREAD_H): Test with "#ifdef", not "#if".
2008-04-18 09:26:45 +00:00
Richard W.M. Jones
8df91acf70
Fixes for MinGW.
...
* configure.in: Fix pkg-config detection of libxml2,
add -lgcrypt to gnutls lib.
* src/Makefile.am: If compiling --without-libvirtd then
don't compile any part of the storage driver.
* configure.in, src/hash.c, src/internal.h: Detect availability
of pthread library and compile out mutex code if not available.
* src/storage_driver.c, src/util.c: Ignore some missing
headers on MinGW.
2008-04-18 08:33:23 +00:00
Daniel Veillard
49e6b7221c
Complete and cleanup virsh man page
...
* virsh.1 docs/virsh.pod: fix missing entries and small cleanups
in the man page, should fix #442429
Daniel
2008-04-15 15:20:43 +00:00
Daniel P. Berrange
3e4ffa4ec0
Added lxc_container.c to POTFILES.in
2008-04-14 17:44:51 +00:00
Richard W.M. Jones
ba5411995b
Remove unused uid field in virsh control structure.
...
* src/virsh.c: Remove unused uid field in virsh control structure.
2008-04-10 17:37:23 +00:00
Jim Meyering
fa8ddb744d
HACKING: New file: begin to describe contributor/coding guidelines
2008-04-10 16:56:44 +00:00
Jim Meyering
3b83d22e79
ensure that no C source file uses TABs for indentation
...
* Makefile.maint (sc_TAB_in_indentation): New rule.
2008-04-10 16:55:31 +00:00
Jim Meyering
5bf824ea10
convert TAB-based indentation in C sources to use only spaces
...
Done using this command (also includes .c.in and .h.in files):
for i in $(g ls-files|grep -E '\.[ch](\.in)?$'|grep -v gnulib); do
expand -i $i > j && mv j $i;done
2008-04-10 16:54:54 +00:00
Jim Meyering
dc42a9d2de
remove Vim and Emacs variable settings from C source files
...
Done with these commands:
git grep -l Local.variab|xargs \
perl -0x3b -pi -e 's,\n+/\*\n \* vim:(.|\n)*,\n,'
git grep -l Local.variab|xargs \
perl -0x3b -pi -e 's,\n+/\*\n \* Local variables:\n(.|\n)*,\n,'
2008-04-10 16:53:29 +00:00
Daniel Veillard
3ceae485b2
AUTHORS and po updates
...
* AUTHORS: adding Dave Leskovec and Ryan Scott to the authors list
* po/*: rebuilt
daniel
2008-04-10 13:32:46 +00:00
Daniel Veillard
c863713742
Ask xend to remove device in the config file too
...
* src/xend_internal.c: applied a patch from Ryan Scott to ask
xend to save the device removal change in the config file
Daniel
2008-04-10 13:30:17 +00:00
Daniel Veillard
9ae41a71ac
* src/Makefile.am src/lxc_conf.c src/lxc_conf.h src/lxc_container.c
...
src/lxc_container.h src/lxc_driver.c: Applied second set of
linux container patches from Dave Leskovec adding start/stop
of domains
Daniel
2008-04-10 07:30:52 +00:00
Richard W.M. Jones
a2c0fa5f5b
Add virsh.pod to EXTRA_DIST
...
* docs/Makefile.am: Add virsh.pod to EXTRA_DIST.
2008-04-09 15:12:13 +00:00
Richard W.M. Jones
ed8a6d6a10
Core code contains Xen-ism UUID of dom0 = 0..0
...
* src/libvirt.c: Remove a Xen-ism from the core code, the
assumption that dom0's UUID is all zeroes.
2008-04-09 14:03:01 +00:00
Richard W.M. Jones
c1bc644bad
Warn about conn, dom and net fields in virterror
...
* include/libvirt/virterror.h: Warn about the use of
conn, dom and net fields in virterror.
2008-04-09 14:00:07 +00:00
Richard W.M. Jones
b5af30a9f3
Remove extraneous underscore
...
* src/openvz_conf.c: Remove extraneous underscore which stopped
file from compiling (Anton Protopopov).
2008-04-09 13:50:27 +00:00
Daniel Veillard
5b470f32c3
0.4.2 release
...
* configure.in NEWS doc/* po/*: making libvirt-0.4.2 release
daniel
2008-04-08 16:45:57 +00:00
Jim Meyering
d2090e649b
configure.in (ALL_LINGUAS): Fix typo: s/Latn/latin/.
2008-04-08 15:53:16 +00:00
Jim Meyering
3ce465f819
Don't fail to read a file because it's non-seekable (e.g., a pipe).
...
* src/util.c (fread_file_lim): New function.
(__virFileReadAll): Use fread_file_lim, rather than requiring
that stat.st_size provide a usable file size.
* tests/read-non-seekable: New test, for the above.
* tests/Makefile.am (test_scripts): Add read-non-seekable.
* tests/test-lib.sh (mkfifo_or_skip_): New helper function.
2008-04-08 15:33:16 +00:00
Richard W.M. Jones
407df0f164
src/qemu_driver.c: Handle errors from fork(2) and pipe(2)
...
system calls when creating qemu subprocess.
2008-04-08 12:27:53 +00:00
Daniel Veillard
09f1c2041d
* po/sr.po po/sr@Latn.po po/sr@latin.po: fix/update serbian
...
translations.
daniel
2008-04-08 09:51:37 +00:00
Daniel Veillard
801a8f2e7b
adds xen and hvm guest types to test driver capabilities
...
* src/test.c: patch from Cole Robinson adding xen and hvm guest types
to the test driver's capabilities.
Daniel
2008-04-08 09:26:24 +00:00
Daniel Veillard
2579443e21
Fix potential infinite loop in python generator
...
* python/generator.py: fix an infinite loop bug
Daniel
2008-04-08 08:26:15 +00:00
Jim Meyering
7c61b48202
* tests/vcpupin: Add a test for the 2008-04-04 virsh.c bugfix.
2008-04-07 12:12:34 +00:00
Daniel Veillard
67b17df9d2
update bugzilla URIs
...
* docs/bugs.html docs/libvir.html: update the page bugzilla URIs
depending on the set the user is running.
Daniel
2008-04-07 10:54:40 +00:00
Daniel P. Berrange
d4a6fe9f99
Don't do polkit auth as root
2008-04-04 15:09:19 +00:00
Daniel Veillard
62ee5d5711
error message on vcpupin
...
* src/virsh.c: patch from Shigeki Sakamoto adding message on vcpupin
Daniel
2008-04-04 11:20:45 +00:00
Daniel Veillard
3a50451e84
doc and localization updates
...
* docs//* po/*: regenerated the documentation and reextracted the
full set of localization strings to push to the translation team.
Daniel
2008-04-04 08:06:18 +00:00
Daniel Veillard
a528e97383
typos fixes
...
* docs//* src/conf.c src/hash.c src/libvirt.c src/proxy_internal.c
src/remote_internal.c src/virsh.c src/xen_internal.c
src/xend_internal.c src/xml.c: applied patch from Atsushi SAKAI
fixing a lot of typos
Daniel
2008-04-04 07:58:29 +00:00
Daniel Veillard
7b72ef296f
virNodeGetCellsFreeMemory for test driver
...
* src/test.c: patch from Cole Robinson to add
virNodeGetCellsFreeMemory to the test driver
Daniel
2008-04-04 07:31:24 +00:00
Richard W.M. Jones
dfc4b8a7d0
C99 initializer on __lastErr
...
* src/virterror.c: Use C99 initializers to make initialization
of __lastErr clearer (Guido Günther).
2008-04-02 16:22:34 +00:00
Daniel Veillard
c2b690f1bd
* src/lxc_conf.c: patch from Dave Leskovec fixing an freed memory
...
access I introduced yesterday
Daniel
2008-04-01 13:01:01 +00:00
Daniel Veillard
c7d7aa1cd1
remove dandling domain/net/conn pointers from error data
...
* src/hash.c src/internal.h src/virterror.c: remove dandling
domain/net/conn pointers from error data when released.
* src/lxc_driver.c: fix a NULL/0 return error mismatch
Daniel
2008-03-31 14:38:12 +00:00
Daniel Veillard
be03daaab2
* configure.in: small patch from Mike Gerdts to avoid problems with
...
older awk implementations, fixes #439649
Daniel
2008-03-31 12:13:52 +00:00
Daniel Veillard
497f252015
linux countainers cleanup patches
...
* src/lxc_conf.c src/lxc_conf.h: cleanup patch for the conf driver
of linux countainers, reuse XPath helpers, make string fields dynamic
and remove a memory leak.
* src/lxc_driver.c: avoid some problems when the config directory is
not accessible and for regression tests
Daniel
2008-03-31 12:02:12 +00:00
Daniel P. Berrange
038b434f14
Added patches for routed networking from Mads Chr. Olesen
2008-03-28 20:38:21 +00:00
Daniel P. Berrange
924de9c3d1
Fix output of XML for FS storage pool
2008-03-28 17:56:44 +00:00
Daniel P. Berrange
b7909d3276
Tweak masquering rules to only capture traffic leaving the virtual network
2008-03-28 01:05:08 +00:00
Jim Meyering
c5adab5270
lxcError: mark a string and add to the list of nearly-checked functions
...
* Makefile.maint (msg_gen_function): Add, but commented-out.
* src/lxc_conf.c (lxcParseXML): Mark a diagnostic for translation.
2008-03-27 14:02:57 +00:00
Jim Meyering
76a7098407
testError: mark most string arguments for translation
...
* Makefile.maint (msg_gen_function): Add testError
* src/test.c (testDomainSave, testDomainRestore): Mark strings.
(testDomainCoreDump): Likewise.
2008-03-27 14:01:59 +00:00
Jim Meyering
7f8639261a
openvzLog: mark its string arguments for translation
...
* Makefile.maint (msg_gen_function): Add openvzLog.
* src/openvz_conf.c (openvzAssignVMDef, openvzParseXML): Mark strings.
* src/openvz_driver.c (openvzDomainShutdown, openvzDomainReboot):
(openvzDomainDefineXML, openvzDomainCreateLinux):
(openvzDomainCreate, openvzDomainUndefine): Likewise.
2008-03-27 14:00:28 +00:00
Jim Meyering
5bb81e1d87
error: mark most string arguments for translation
...
Also mark some arguments to __virRaiseError.
* Makefile.maint (msg_gen_function): Add error.
* po/POTFILES.in: Add src/openvz_conf.c and src/openvz_driver.c.
* src/openvz_conf.c (openvzParseXML, openvzGetVPSInfo): Mark strings.
* src/openvz_driver.c (openvzDomainLookupByID): Likewise.
(openvzDomainLookupByUUID, openvzDomainLookupByName): Likewise.
(openvzDomainGetInfo, openvzDomainShutdown, openvzDomainReboot)
(openvzDomainCreate, openvzDomainUndefine): Likewise.
* src/remote_internal.c (check_cert_file): Likewise.
(negotiate_gnutls_on_connection, verify_certificate): Likewise.
(remoteAuthenticate, addrToString, remoteAuthSASL): Likewise.
(remoteAuthPolkit, call, really_read_buf): Likewise.
2008-03-27 13:58:56 +00:00
Jim Meyering
f1eed04b2d
Convert diagnostics like "VAR > MAX_VAR" to translatable messages.
...
* src/remote_internal.c (errorf): New function.
(remoteListDomains, remoteDomainPinVcpu, remoteDomainGetVcpus):
(remoteListDefinedDomains, remoteListNetworks):
(remoteListDefinedNetworks): Convert strings to be translatable,
and also to include offending and maximum values. Use errorf.
2008-03-27 13:56:28 +00:00
Jim Meyering
b53c4e51f8
qemudReportError: mark for translation string args to this function
...
* Makefile.maint (msg_gen_function): Add qemudReportError.
* src/qemu_conf.c (qemudLoadDriverConfig)
(qemudExtractVersion, qemudParseDiskXML, qemudParseInterfaceXML)
(qemudParseInputXML, qemudParseXML, qemudNetworkIfaceConnect)
(qemudBuildCommandLine, qemudSaveConfig, qemudParseVMDeviceDef)
(qemudAssignVMDef, qemudSaveVMDef, qemudSaveNetworkConfig)
(qemudParseDhcpRangesXML, qemudParseNetworkXML)
(qemudAssignNetworkDef, qemudSaveNetworkDef, qemudGenerateXML)
(qemudGenerateNetworkXML, qemudDeleteConfig): Mark strings.
* src/qemu_driver.c (qemudBuildDnsmasqArgv, qemudAddIptablesRules)
(qemudGetCapabilities, qemudDomainGetOSType)
(qemudListDefinedDomains, qemudListNetworks)
(qemudListDefinedNetworks, qemudNetworkGetBridgeName): Mark strings.
2008-03-27 13:53:14 +00:00
Jim Meyering
3163224bb5
ReportError: mark for translation string args to this function
...
* Makefile.maint (msg_gen_function): Add ReportError.
* src/util.c (_virExec): Mark strings.
2008-03-27 13:47:00 +00:00
Jim Meyering
56a3cb8086
xenXMError: mark for translation string args to this function
...
* Makefile.maint (msg_gen_function): Add xenXMError.
* src/xm_internal.c (xenXMParseXMLToConfig, xenXMDomainDefineXML):
(xenXMDomainAttachDevice, xenXMDomainDetachDevice): Mark strings.
2008-03-27 13:45:26 +00:00
Jim Meyering
513bd04ce1
Mark many more strings for translation.
...
* Makefile.maint (err_func_re): Add to the list and make it readable.
* po/POTFILES.in: Add src/util.c and src/xm_internal.c, and sort.
* src/storage_backend.c: Fix comment.
* src/util.c (virFileLinkPointsTo): Mark a string.
* qemud/remote.c (remoteDispatchClientRequest): Mark strings.
(remoteDispatchOpen, CHECK_CONN, remoteDispatchGetType): Likewise.
(remoteDispatchDomainGetSchedulerType): Likewise.
(remoteDispatchDomainGetSchedulerParameters): Likewise.
(remoteDispatchDomainSetSchedulerParameters): Likewise.
(remoteDispatchDomainBlockStats): Likewise.
(remoteDispatchDomainInterfaceStats): Likewise.
(remoteDispatchDomainAttachDevice, remoteDispatchDomainCreate):
(remoteDispatchDomainDestroy, remoteDispatchDomainDetachDevice):
(remoteDispatchDomainDumpXml, remoteDispatchDomainGetAutostart):
(remoteDispatchDomainGetInfo, remoteDispatchDomainGetMaxMemory):
(remoteDispatchDomainGetMaxVcpus, remoteDispatchDomainGetOsType):
(remoteDispatchDomainGetVcpus): Likewise.
(remoteDispatchDomainMigratePerform): Likewise.
(remoteDispatchListDefinedDomains, remoteDispatchDomainPinVcpu):
(remoteDispatchDomainReboot, remoteDispatchDomainResume):
(remoteDispatchDomainSave, remoteDispatchDomainCoreDump):
(remoteDispatchDomainSetAutostart): Likewise.
(remoteDispatchDomainSetMaxMemory, remoteDispatchDomainSetMemory):
(remoteDispatchDomainSetVcpus, remoteDispatchDomainShutdown):
(remoteDispatchDomainSuspend, remoteDispatchDomainUndefine):
(remoteDispatchListDefinedNetworks, remoteDispatchListDomains):
(remoteDispatchListNetworks, remoteDispatchNetworkCreate):
(remoteDispatchNetworkDestroy, remoteDispatchNetworkDumpXml):
(remoteDispatchNetworkGetAutostart, remoteDispatchNetworkGetBridgeName):
(remoteDispatchNetworkSetAutostart, remoteDispatchNetworkUndefine):
(addrToString, remoteDispatchAuthSaslInit, remoteDispatchAuthSaslStart):
(remoteDispatchAuthSaslStep, remoteDispatchListDefinedStoragePools):
(remoteDispatchListStoragePools, remoteDispatchStoragePoolCreate):
(remoteDispatchStoragePoolBuild, remoteDispatchStoragePoolDestroy):
(remoteDispatchStoragePoolDelete, remoteDispatchStoragePoolRefresh):
(remoteDispatchStoragePoolGetInfo, remoteDispatchStoragePoolDumpXml):
(remoteDispatchStoragePoolGetAutostart): Likewise.
(remoteDispatchStoragePoolSetAutostart):
(remoteDispatchStoragePoolListVolumes):
(remoteDispatchStoragePoolNumOfVolumes):
(remoteDispatchStoragePoolUndefine, remoteDispatchStorageVolCreateXml):
(remoteDispatchStorageVolDelete, remoteDispatchStorageVolGetInfo):
(remoteDispatchStorageVolDumpXml, remoteDispatchStorageVolGetPath):
(remoteDispatchStorageVolLookupByName): Likewise.
* src/qemu_driver.c (qemudOpenMonitor, qemudStartVMDaemon):
(dhcpStartDhcpDaemon, qemudStartNetworkDaemon):
(qemudDomainSuspend, qemudDomainResume, qemudDomainShutdown):
(qemudDomainGetOSType, qemudDomainSetMaxMemory):
(qemudDomainSetMemory, qemudDomainGetInfo, qemudDomainSave):
(qemudDomainRestore, qemudDomainDumpXML, qemudDomainStart):
(qemudDomainUndefine, qemudDomainChangeCDROM):
(qemudDomainAttachDevice, qemudDomainGetAutostart):
(qemudDomainSetAutostart, qemudDomainInterfaceStats):
(qemudNetworkLookupByUUID, qemudNetworkLookupByName):
(qemudNetworkUndefine, qemudNetworkStart, qemudNetworkDestroy):
(qemudNetworkDumpXML, qemudNetworkGetAutostart):
(qemudNetworkSetAutostart): Likewise.
* src/virsh.c (cmdVcpupin, cmdAttachDevice, cmdDetachDevice): Likewise.
* src/xm_internal.c (xenXMConfigCacheRefresh, xenXMDomainPinVcpu): Likewise.
2008-03-27 13:43:01 +00:00
Daniel Veillard
425cf2e792
Linux container fixes, move driver in the daemon.
...
* src/lxc_conf.c src/lxc_conf.h src/lxc_driver.c src/remote_internal.c:
applied patch from Dan Berrange to change the way the lxc driver
works, migrating the support in the daemon, it also removes some
compilation issues and teh way the configuration files are named.
Daniel
2008-03-27 09:34:06 +00:00
Daniel Veillard
ae15bc7245
support of older versions of iscsiadm.
...
* src/storage_backend_iscsi.c: patch from Chris Lalancette to improve
support with older versions of iscsiadm.
Daniel
2008-03-27 08:11:27 +00:00
Daniel Veillard
94c2255d81
* src/xen_internal.c proxy/libvirt_proxy.c: fix Xen hypercall for
...
Xen-3.2, and merged its debugging with the general library facility
Daniel
2008-03-26 13:03:30 +00:00
Richard W.M. Jones
cedd94662d
Wed Mar 26 12:57:00 UTC 2008 Richard W.M. Jones <rjones@redhat.com>
...
* po/lt.po: Fixed typo (Beth Kon).
2008-03-26 13:00:47 +00:00
Richard W.M. Jones
dc1824b780
Tue Mar 25 10:23:00 UTC 2008 Richard W.M. Jones <rjones@redhat.com>
...
* src/virsh.c: Additional error messages for missing
parameters (Shigeki Sakamoto).
2008-03-25 10:26:32 +00:00
Daniel Veillard
928a84e10d
* src/qemu_driver.c: remove trailing newlines from error messages
...
patch from Guido Günther
Daniel
2008-03-24 10:58:21 +00:00
Daniel Veillard
71c061d559
* src/qemu_driver.c: applied patch from Guido Günther to make error
...
strings as translatable
Daniel
2008-03-24 10:51:47 +00:00
Jim Meyering
b8fb14a905
* Makefile.maint (err_func_re): Add lxcError.
2008-03-24 10:21:46 +00:00
Jim Meyering
f4d2430d6c
* qemud/remote.c: Don't include <getopt.h>. Not used.
2008-03-24 10:21:03 +00:00
Jim Meyering
16fd2b6b61
Sync Makefile rules from coreutils.
...
* Makefile.maint: Merge.
* GNUmakefile: Update from coreutils.
2008-03-24 10:20:15 +00:00
Jim Meyering
f15efcdf27
Add new testing framework and the first test to use it.
...
* tests/Makefile.am (test_scripts): Add vcpupin.
(EXTRA_DIST): Add test-lib.sh.
* tests/test-lib.sh: Testing framework, from coreutils.
* tests/vcpupin: New file.
* build-aux/mktempd: New file, from gnulib.
* bootstrap: Add posix-shell and mktempd to the list of imported modules.
* gnulib/m4/posix-shell.m4: New file, from gnulib.
2008-03-24 10:19:36 +00:00
Jim Meyering
870dba07b1
Fix bugs in tests/Makefile.am.
...
* tests/Makefile.am (TESTS_ENVIRONMENT): Correct invalid
settings of abs_top_builddir and abs_top_srcdir.
Also prepend src/ to PATH, so we test the just-built virsh,
not whatever happens to be in the original $PATH.
2008-03-24 10:18:36 +00:00
Daniel Veillard
979bb2bb67
* src/xend_internal.c: applied patch from Saori Fukuta adding the
...
scheduler API for the Xen daemon driver
* po/POTFILES.in: add the two new linux container modules
Daniel
2008-03-24 09:23:32 +00:00
Daniel Veillard
f163895204
Initial Linux containers work
...
* configure.in include/libvirt/virterror.h src/Makefile.am
src/driver.h src/lxc_conf.[ch] src/lxc_driver.[ch] src/virterror.c:
Applied 3 patches from Dave Leskovec for intial support of
Linux containers, configured off by default, work in progress.
* src/libvirt.c: improve virDomainCreateLinux xmlDesc description
Daniel
2008-03-21 15:03:37 +00:00
Daniel Veillard
ccb19376f7
* src/util.c src/util.h src/xml.c: applied patch from Hiroyuki Kaguchi
...
fixing Ethernet MAC addresses parsingand separating as an util
function, with added comments from Jim Meyering
Daniel
2008-03-20 11:24:30 +00:00
Daniel Veillard
623ec4d2f2
* src/qemu_conf.c src/qemu_conf.h src/qemu_driver.c: applied patch
...
from Cole Robinson implementing memory operations for qemu driver
Daniel
2008-03-19 14:32:50 +00:00
Jim Meyering
2fe1c38796
Avoid "make syntax-check" failure.
...
* src/xen_unified.c: Remove trailing blank.
2008-03-18 22:33:01 +00:00
Daniel P. Berrange
ea1c08e78d
Use explicit logic rules for opening Xen sub-drivers
2008-03-17 17:30:48 +00:00
Jim Meyering
a34bcb7829
Treat ENOTSUP like ENODATA, after failed fgetfilecon.
...
* src/storage_backend.c (virStorageBackendUpdateVolInfoFD): Treat a
failed fgetfilecon with errno == ENOTSUP the same as for ENODATA.
2008-03-17 16:57:21 +00:00
Daniel Veillard
96c795328d
fixed DefinedDomains function comments c.f. 437216
...
* libvirt.c: fixed DefinedDomains function comments c.f. 437216
* docs/libvirt-*.xml docs/*/libvirt-libvirt.html: regenerated
Daniel
2008-03-17 16:43:54 +00:00
Daniel P. Berrange
cefa185c1f
Fix creation of unmanaged pools
2008-03-17 15:10:48 +00:00
Daniel P. Berrange
d8b363c35f
Cope with missing selinux attribute
2008-03-17 15:09:38 +00:00
Daniel Veillard
ca7047f122
* src/libvirt.c docs/libvirt-*.xml docs/html/libvirt-libvirt.html:
...
fixed a few missing argument descriptions and regenerated.
Daniel
2008-03-17 10:48:02 +00:00
Daniel Veillard
08ecf61b35
* NEWS virsh.1 docs//* include/libvirt/libvirt.h[.in] qemud/mdns.h
...
src/libvirt.c src/qemu.conf src/remote_internal.c src/xend_internal.c
tests/confdata/libvirtd.conf tests/confdata/libvirtd.out: patch from
Atsushi SAKAI fixing a ot more typo
Daniel
2008-03-17 10:27:31 +00:00
Daniel P. Berrange
7ae13660cf
Don't set MAC on TAP devs. Pass TAP device name to QEMU
2008-03-14 20:30:03 +00:00
Daniel Veillard
8885191702
* po/*: updated translations
...
Daniel
2008-03-14 15:57:02 +00:00
Daniel Veillard
62b4c870aa
typo
...
* src/bridge.c: fix a typo in a comment
Daniel
2008-03-14 15:31:08 +00:00
Daniel Veillard
a7892ee000
String fixes #436620
...
* qemud/qemud.c src/virsh.c: fixing some user facing strings
problems pointed out by Francesco Tombolini should fix #436620
Daniel
2008-03-14 15:21:15 +00:00
Daniel Veillard
384f26525f
Small cleanup, Daniel
2008-03-14 11:14:41 +00:00
Richard W.M. Jones
3e59e29859
Fix typo "informations" -> "information" (Atsushi SAKAI and
...
Saori FUKUTA).
2008-03-14 11:08:03 +00:00
Daniel Veillard
adbf991a1d
* src/libvirt.c: virDomainSetSchedulerParameters need to be
...
blocked on read-only connections, patch from Saori Fukuta
Daniel
2008-03-13 09:27:46 +00:00
Daniel Veillard
dc232cdf1b
* src/bridge.c src/virsh.c: typo fixes from Atsushi SAKAI
...
daniel
2008-03-13 09:21:41 +00:00
Daniel Veillard
af1c7f96a8
* src/qemu_conf.c src/qemu_driver.c: patch from Cole Robinson
...
fixing CD Rom change on live QEmu/KVM domains.
Daniel
2008-03-13 09:17:45 +00:00
Daniel P. Berrange
8d2d44ad05
Remove use of polkit-grant. Keep stdio open when running polkit-auth
2008-03-11 14:49:04 +00:00
Daniel P. Berrange
c3501d4792
Don't force Xen connections to readonly when non-root
2008-03-11 14:25:49 +00:00
Daniel P. Berrange
028e4a6116
Don't run cleannup code for parent process in daemon mode
2008-03-11 14:22:12 +00:00
Daniel Veillard
f5ade63437
* docs/libvir.html docs/storage.html: apply documentation fixes
...
and typos cleanup from Atsushi Sakai
Daniel
2008-03-07 11:13:02 +00:00
Daniel Veillard
d4cbf4c624
* src/xend_internal.c: applied patch from Cole Robinson to not
...
loose the boot tag when defining a fully virtualized xen domain
Daniel
2008-03-07 09:23:30 +00:00
Richard W.M. Jones
2a4c20437d
Make iSCSI login actually work
...
* src/storage_backend_iscsi.c: Make iSCSI login actually work
(Chris Lalancette).
2008-03-04 20:02:34 +00:00
Richard W.M. Jones
4d6a8a1c0a
Report error when vcpupin is given bad vCPU number.
...
* src/virsh.c: Report error when vcpupin is given bad vCPU number
(Shigeki Sakamoto).
2008-03-04 19:59:56 +00:00
Jim Meyering
869f8d0e7d
Also ignore leading zeros when comparing MAC addresses.
...
* src/util.c: Include <ctype.h>.
(TOLOWER): Define.
(__virMacAddrCompare): Rewrite to also ignore leading zeros.
2008-03-03 20:39:52 +00:00
Daniel Veillard
65c4379c53
* src/capabilities.c: Cole Robinson pointed out a well formedness
...
problem when generating the capabilities in the test driver.
Daniel
2008-03-03 20:21:21 +00:00
Jim Meyering
4090a0870c
Don't use first byte of string as a pointer.
...
* src/qemu_conf.c (qemudReportError): Use the pointer, errorMessage,
not its first byte, errorMessage[0].
2008-03-03 18:11:16 +00:00
Jim Meyering
f9e94c2e13
Avoid segfault upon early libvirtd failure.
...
* qemud/qemud.c (main): Don't call qemudCleanup on an
uninitialized pointer.
2008-03-03 18:10:19 +00:00
Daniel Veillard
6a17c6c652
Release of 0.4.1
...
* NEWS configure.in libvirt.spec.in docs/* include/libvirt/libvirt.h
po/*: preparing release of libvirt-0.4.1
Daniel
2008-03-03 14:42:37 +00:00
Jim Meyering
6272a7d0c2
Plug saslUsernameWhitelist leak.
...
* qemud/qemud.c (qemudCleanup): Free the array as well as
the strings in it.
2008-03-03 13:17:05 +00:00
Jim Meyering
cd6eefd3e8
Plug skipped-qemudCleanup leak.
...
* qemud/qemud.c (main): Call qemudCleanup also upon failure.
Otherwise, an error return would skip it and induce leaks.
2008-03-03 13:16:31 +00:00
Jim Meyering
ba8459e859
Plug remoteReadConfigFile leak.
...
* qemud/qemud.c (remoteReadConfigFile): Be careful to free
"conf" after a successful virConfReadFile.
2008-03-03 13:15:57 +00:00
Jim Meyering
1de5bace80
Plug two leaks: host.migrateTrans and arch.name
...
* src/capabilities.c (virCapabilitiesFree): Free host.migrateTrans.
(virCapabilitiesFreeGuest): Free arch.name member.
2008-03-03 13:15:14 +00:00
Jim Meyering
47a4c0fa0b
Plug virCapabilities*GuestDomain leak.
...
* src/capabilities.c (virCapabilitiesFreeGuestDomain): Free dom->type.
(virCapabilitiesAddGuestDomain): Remove duplicate strdup stmt.
2008-03-03 13:14:26 +00:00
Daniel Veillard
3e1aaf27fe
missing comments for _virDomainBlockStats fields
...
* include/libvirt/libvirt.h include/libvirt/libvirt.h.in:
missing comments for _virDomainBlockStats fields
* docs/*: rebuilt docs
Daniel
2008-03-03 06:18:06 +00:00
Daniel Veillard
39947cec85
fix a broken line split
...
* qemud/Makefile.am: fix a broken line split
Daniel
2008-02-29 17:02:41 +00:00
Richard W.M. Jones
bb8340c18d
Many typos fixed (Atsushi SAKAI).
2008-02-29 12:53:10 +00:00
Jim Meyering
ba52fcbcdf
Rewrite test-coverage rules to accommodate multiple .o files per .c.
...
* src/Makefile.am (cov): Rewrite rule to merge gcov results corresponding
to two .o files: the libvirt_la- one, and the libvirt_test_la- one.
(tst): Remove unused rule.
* configure.in (LV_LIBTOOL_OBJDIR): Define and AC_SUBST.
2008-02-28 17:07:37 +00:00
Jim Meyering
9262d88e28
Avoid link errors with "configure --disable-shared".
...
* src/Makefile.am: Create a convenience library, libvirt_test.la,
and don't restrict access to *its* symbols.
* tests/Makefile.am (LDADDS): Add ../src/libvirt_test.la, so that
"configure --disable-shared" no longer provokes link errors.
(LIBVIRT): Remove definition.
(LDADDS): Remove use.
($(LIBVIRT)): Remove rule.
(LDADDS): Use the new convenience library instead.
(CLEANFILES): Define.
* docs/examples/index.py (dump_Makefile): Append $(COVERAGE_LDFLAGS),
to the LDADDS definition, to avoid link error with the combination of
--enable-test-coverage and --disable-shared.
* docs/examples/Makefile.am: Regenerate.
* docs/examples/index.html: Likewise.
* qemud/Makefile.am (libvirtd_LDFLAGS): Append $(COVERAGE_LDFLAGS).
* src/libvirt_sym.version: Remove some SP-before-TAB.
2008-02-28 17:06:32 +00:00
Daniel Veillard
004ff90483
Fix qemudReportError.
...
* src/qemu_conf.c: applied patch from Cole Robinson to use virErrorMsg
in qemudReportError.
Daniel
2008-02-28 11:17:49 +00:00
Daniel P. Berrange
9699e372c2
Set MAC address on TUN device for Xenner compatability
2008-02-28 01:23:14 +00:00
Jim Meyering
46b427a310
Make qemud/'s rpcgen rules work.
...
* qemud/Makefile.am (SUFFIXES): Define to .x before implicit rule.
2008-02-27 19:12:58 +00:00
Richard W.M. Jones
92a1e14b0b
virMacAddrCompare for comparing MAC addresses
...
* src/util.c, src/util.h, src/libvirt_sym.version: Added
virMacAddrCompare utility function for comparing MAC
addresses.
* src/virsh.c, src/xm_internal.c: Use virMacAddrCompare
to compare addresses. (Shigeki Sakamoto and Richard Jones).
2008-02-27 16:14:44 +00:00
Jim Meyering
fa4ab3325b
Avoid "make distcheck" failure.
...
* src/Makefile.am (virsh_SOURCES): Add util-lib.h.
2008-02-27 15:17:45 +00:00
Jim Meyering
d7cdc28431
Fix a "make syntax-check" failure.
...
* src/capabilities.c: Include <config.h> from the .c file,
* src/capabilities.h: ... not from the .h file.
2008-02-27 14:40:19 +00:00
Richard W.M. Jones
b4882504ea
Fix typos (Atsushi SAKAI).
2008-02-27 10:37:19 +00:00
Daniel P. Berrange
63bc5dd3e1
Add formal internal capabilities API and update drivers to use it
2008-02-27 04:35:08 +00:00
Richard W.M. Jones
727c5601ec
Implement virDomainBlockStats for QEMU/KVM.
...
* src/qemu_driver.c: Implement virDomainBlockStats for QEMU/KVM
using QEMU/KVM 'info blockstats' command (Richard Jones).
* src/qemu_driver.c, src/qemu_conf.h: const-correctness
fixes (Jim Meyering).
2008-02-26 18:41:43 +00:00
Richard W.M. Jones
242fe3d401
No address attribute in Xen domain XML.
...
* src/xm_internal.c: handle the case where <mac/> clause
in Xen domain interface has no address attribute
(Shigeki Sakamoto).
2008-02-26 18:31:57 +00:00
Daniel Veillard
36c6bfa63d
* src/driver.h src/libvirt.c src/openvz_driver.c src/qemu_driver.c
...
src/remote_internal.c src/test.c src/util.c src/util.h
src/xen_unified.c: added probe interface at the driver level,
use that to improve default hypervisor selection in the absence
of a given URI when connecting
Daniel
2008-02-26 07:05:18 +00:00
Daniel Veillard
9b1cd481b8
fix compilation against static libraries
...
* src/Makefile.am src/util-lib.h: fix done with Jim to allow
compilation of virsh with the static libraries.
Daniel
2008-02-25 13:55:56 +00:00
Jim Meyering
e497deb89e
Avoid new "make syntax-check" failures.
...
* .x-sc_avoid_write: Exempt src/util-lib.c, too.
* Makefile.maint (sc_unmarked_diagnostics): Filter out false positives.
* src/storage_backend_fs.c (virStorageBackendFileSystemVolCreate):
Use safewrite, not write.
* src/storage_backend_logical.c (virStorageBackendLogicalBuildPool): Likewise.
2008-02-25 10:00:16 +00:00
Jim Meyering
b1b23f76be
avoid format string warnings
...
Avoid warnings like this:
file:nnn:format not a string literal and no format arguments
* qemud/qemud.c: Insert a "%s" format argument.
* qemud/remote.c: Likewise.
* src/iptables.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/storage_backend.c: Likewise.
* src/storage_backend_fs.c: Likewise.
* src/storage_backend_iscsi.c Likewise.
* src/storage_backend_logical.c: Likewise.
* src/storage_conf.c: Likewise.
* src/storage_driver.c: Likewise.
2008-02-22 16:26:13 +00:00
Jim Meyering
b59d9c85f1
Use safewrite in place of write, in many cases.
...
Also add "make syntax-check" rules to ensure no new uses sneak in.
There are many uses of write like this:
if (write (fd, xml, towrite) != towrite)
return -1;
The problem is that the syscall can succeed, yet write less than
the requested number of bytes, so the caller should retry
rather than simply failing.
This patch changes most of them to use util.c's safewrite wrapper,
which encapsulates the process. Also, there were a few cases in
which the retry loop was open-coded, and I replaced those, too.
* Makefile.maint (sc_avoid_write): New rule, to avoid recurrence.
* .x-sc_avoid_write: New file. Record two legitimate exemptions.
* qemud/qemud.c (sig_handler, qemudClientWriteBuf): Use safewrite, not write.
* src/conf.c (__virConfWriteFile): Likewise.
* src/qemu_conf.c (qemudSaveConfig, qemudSaveNetworkConfig): Likewise.
* src/qemu_driver.c (qemudWaitForMonitor, qemudStartVMDaemon)
(qemudVMData, PROC_IP_FORWARD): Likewise.
* proxy/libvirt_proxy.c: Include "util.h".
(proxyWriteClientSocket): Use safewrite.
* src/test.c (testDomainSave, testDomainCoreDump): Likewise.
* src/proxy_internal.c (virProxyWriteClientSocket): Likewise.
* src/virsh.c: Include "util-lib.h".
(vshOutputLogFile): Use safewrite.
* src/console.c: Include "util-lib.h".
(vshRunConsole): Use safewrite.
2008-02-22 15:55:04 +00:00
Jim Meyering
a178a4e7bf
Move safewrite and saferead to a separate file.
...
We currently use safewrite from inside libvirt and don't want to publish
any such function name. However, we do want to use it in applications
like virsh, libvirtd and libvirt_proxy that link with libvirt. To that
end, this change moves that function definition (along with the nearly
identical saferead) into a new file, util-lib.c. To avoid maintaining
separate copies of even such small functions, we simply include that new
file from util.c. Then, the separate applications that need to use
safewrite simply compile and link with util-lib.c.
Of course, this does mean that each of those applications will
containing two copies of these functions. However, the functions
are so small that it's not worth worrying about that.
* src/util.c (saferead, safewrite): Move function definitions to
util-lib.c and include that .c file.
* src/util-lib.c (saferead, safewrite): New file. Functions from src/util.c
with slight change (s/int r =/ssize_t r =/) to reflect read/write return type.
* src/util-lib.h: Declare the two moved functions.
* src/util.h: Remove declarations. Include src/util-lib.h.
* proxy/Makefile.am (libvirt_proxy_SOURCES): Add src/util-lib.c.
* qemud/Makefile.am (libvirtd_SOURCES): Likewise.
* src/Makefile.am (virsh_SOURCES): Add util-lib.c. Remove some SP-before-TAB.
2008-02-22 15:53:13 +00:00
Jim Meyering
6187c6de9b
With --enable-iptables-lokkit=no, avoid warning about unused parameter.
...
* src/iptables.c (iptRulesSave) [!ENABLE_IPTABLES_LOKKIT]:
Mark parameter as used.
2008-02-22 12:34:27 +00:00
Jim Meyering
bdbce64bab
With --without-xen, avoid warning about unused function.
...
* tests/statstest.c (testQuietError) [!WITH_XEN]: Don't define.
2008-02-22 12:33:47 +00:00
Jim Meyering
9bcade46df
Rewrite openvzSetUUID.
...
* src/openvz_conf.c (openvzSetUUID): Rewrite to avoid unchecked
lseek, write, and close as well as a potential file descriptor leak.
2008-02-21 18:48:06 +00:00
Jim Meyering
5fc07cd840
Handle failed openvzLocateConfDir.
...
* src/openvz_conf.c (openvzLocateConfDir, openvzGetVPSUUID):
(openvzSetUUID): Don't dereference NULL upon failure.
2008-02-21 18:22:45 +00:00
Richard W.M. Jones
be8653b183
Fix double-free in OpenVZ driver.
...
* src/openvz_conf.c: Double-free fix (Anton Protopopov).
2008-02-21 15:20:36 +00:00
Daniel P. Berrange
83d0aa0706
Added missing symbol export
2008-02-21 03:53:03 +00:00
Jim Meyering
c8c473c053
Avoid "make syntax-check" failure.
...
* docs/examples/index.py: Don't emit trailing blanks.
* docs/examples/Makefile.am: Regenerate.
2008-02-20 17:26:01 +00:00
Daniel P. Berrange
104cc98636
Update to work with new policy kit APIs
2008-02-20 16:54:35 +00:00
Daniel P. Berrange
caad8777e0
Update po files with latest translatable strings
2008-02-20 16:08:56 +00:00
Daniel P. Berrange
8b6b21d41c
Added docs on storage management capabilities
2008-02-20 15:58:06 +00:00
Daniel P. Berrange
291158945d
Added no-op stub of storage APIs to test driver
2008-02-20 15:53:34 +00:00
Daniel P. Berrange
b7db975135
Added disk partition storage pool backend
2008-02-20 15:52:17 +00:00
Daniel P. Berrange
8ec1fcd925
Added iSCSI storage pool backend
2008-02-20 15:49:25 +00:00
Daniel P. Berrange
049ff4e572
Set close-on-exec flag for signal pipe
2008-02-20 15:47:06 +00:00
Daniel P. Berrange
ac736602fd
Added logical volume storage pool driver
2008-02-20 15:45:33 +00:00
Daniel P. Berrange
e39438e869
Added directory/filesystem/netfs based storage pool backend
2008-02-20 15:42:30 +00:00
Daniel P. Berrange
4a4e272f9d
Added storage backend helper APIs
2008-02-20 15:38:29 +00:00
Daniel P. Berrange
20878720c0
Added main internal storage driver impl
2008-02-20 15:34:52 +00:00
Daniel P. Berrange
f43e709842
Added convenience virsh command for creating pools/volumes without XML
2008-02-20 15:29:13 +00:00
Daniel P. Berrange
816fd02876
Added virsh commands for storage management
2008-02-20 15:27:08 +00:00
Daniel P. Berrange
859679f72a
Added python binding for storage APIs
2008-02-20 15:26:22 +00:00
Daniel P. Berrange
661c5c4476
Add storage APIs to remote driver
2008-02-20 15:23:36 +00:00
Daniel P. Berrange
f48160cfb4
Add remote daemon support for storage APIs
2008-02-20 15:22:35 +00:00
Daniel P. Berrange
056da31bfe
Regenerate docs to include storage APIs
2008-02-20 15:20:44 +00:00
Daniel P. Berrange
cb228a0e24
Internal driver API for storage management
2008-02-20 15:06:53 +00:00
Daniel P. Berrange
e1d2e325dd
Add public API for storage management
2008-02-20 14:57:39 +00:00
Jim Meyering
26709f561f
Pull useless-if-before-free from gnulib, and update.
...
* bootstrap (gnulib_tool): Add useless-if-before-free to
the list of modules.
* build-aux/useless-if-before-free: Update from gnulib.
* gnulib/lib/vasnprintf.c: Work around a bug in HPUX 10.20.
* gnulib/m4/vasnprintf.m4: Likewise.
2008-02-13 21:52:19 +00:00
Daniel P. Berrange
e91aeae437
Ignore ChangeLog/NEWS file for whitespace checks
2008-02-12 14:45:17 +00:00
Daniel Veillard
fd71d295d7
Network doc example fixes
...
* docs/libvir.html docs/format.html: fixes the examples on the
section about ethernet bridging, as raised by Maxwell Bottiger,
fixes bug #430790
Daniel
2008-02-11 16:08:11 +00:00
Mark McLoughlin
3da5504e68
Fix gcc-4.3.0 "inlining failed" warning.
...
* src/internal.h: move xstrol() variants from here ...
* src/util.[ch]: ... to here and rename to virStrToLong()
* src/libvirt_sym.version: export __virStrToLong_i() for
virsh and qemud.
* src/nodeinfo.c, src/stats_linux.c, src/virsh.c,
src/xend_internal.c, qemud/qemud.c: replace xstrtol()
calls with virStrToLong()
* src/nodeinfo.h: don't include internal.h, which was only
needed for xstrtol(), but instead include libvirt.h which
is suffificient for the declarations in the header.
2008-02-08 09:15:16 +00:00
Jim Meyering
db4037e592
Enable another syntax-check rule.
...
* Makefile.cfg (local-checks-to-skip): Remove sc_no_have_config_h.
* qemud/mdns.c: Remove "#ifdef HAVE_CONFIG_H".
* Makefile.maint (sc_no_have_config_h): Tighten up regexp,
so that the above mention of "HAVE_CONFIG_H" doesn't match.
* .x-sc_no_have_config_h: New file, to exempt gnulib/ straggler.
2008-02-07 19:20:36 +00:00
Jim Meyering
3cb808d2a2
autobuild.sh: Run "make syntax-check", so the autobuilder does this.
2008-02-07 19:19:45 +00:00
Daniel Veillard
55f7de7821
missing ')'
...
* qemud/remote.c: fix a missing ')' introduced earlier
Daniel
2008-02-07 17:03:17 +00:00
Daniel Veillard
e9b3bc773d
virHashRemoveSet bugfixes
...
* src/hash.c: fix a couple of problems in virHashRemoveSet based
on Hiroyuki Kaguchi patch and explanations.
Daniel
2008-02-07 16:56:01 +00:00
Jim Meyering
247df6e448
Mark all qemudLog diagnostics for translation.
...
* po/POTFILES.in: Add names of many new files.
* Makefile.maint (err_func_re): Add qemudLog.
Mark diagnostics with _(...). Split some long lines.
* qemud/qemud.c (remoteCheckCertFile, remoteInitializeGnuTLS):
(qemudDispatchSignalEvent, qemudSetCloseExec, qemudSetNonBlock):
(qemudWritePidFile, qemudListenUnix, remoteMakeSockets):
(remoteListenTCP, qemudInitPaths, qemudInitialize):
(qemudNetworkInit, remoteInitializeTLSSession, remoteCheckDN):
(remoteCheckCertificate, remoteCheckAccess, qemudDispatchServer):
(qemudClientReadBuf, qemudDispatchClientRead):
(qemudClientWriteBuf, qemudDispatchClientWrite, qemudOneLoop):
(remoteConfigGetStringList, checkType, GET_CONF_STR):
(remoteConfigGetAuth, remoteReadConfigFile, main):
* qemud/remote.c (remoteDispatchAuthSaslInit, remoteSASLCheckSSF):
(remoteSASLCheckAccess, remoteDispatchAuthSaslStart):
(remoteDispatchAuthSaslStep, remoteDispatchAuthSaslInit):
(remoteDispatchAuthSaslStart, remoteDispatchAuthSaslStep):
(qemudGetSocketIdentity, remoteDispatchAuthPolkit):
* src/iptables.c (notifyRulesUpdated, MAX_FILE_LEN, iptRulesSave):
(iptRulesReload):
* src/qemu_conf.c (qemudExtractVersionInfo, qemudLoadConfig):
(qemudLoadNetworkConfig, qemudScanConfigDir):
* src/qemu_driver.c (qemudSetCloseExec, qemudSetNonBlock):
(qemudAutostartConfigs, qemudStartup, qemudReload):
(qemudWaitForMonitor, qemudStartVMDaemon, qemudVMData):
(qemudShutdownVMDaemon, qemudStartNetworkDaemon):
(qemudShutdownNetworkDaemon, qemudMonitorCommand):
(qemudDomainUndefine, qemudNetworkUndefine):
* src/uuid.c (virUUIDGenerate):
* src/xm_internal.c (xenXMAttachInterface):
2008-02-07 16:50:17 +00:00
Jim Meyering
e8ff93b4e6
Remove more useless if tests before "free"-like functions.
...
* build-aux/useless-if-before-free: Rename from ...
* build-aux/find-unnecessary-if-before-free: ... this. Remove file.
Also changed it so that new names are no longer hard-coded in the
script. Instead, they're supplied via options:
* Makefile.cfg (useless_free_options): Define.
Add xmlXPathFreeObject to the list of free-like functions it detects.
* Makefile.maint (sc_avoid_if_before_free): Reflect script renaming.
* .x-sc_avoid_if_before_free: Likewise.
* src/openvz_conf.c (openvzParseXML): Remove useless "if"-before-free.
* src/qemu_conf.c (qemudParseXML, qemudParseNetworkXML): Likewise.
* src/virsh.c (cmdVNCDisplay, cmdTTYConsole, cmdDetachInterface):
(cmdDetachDisk): Likewise.
* src/xm_internal.c (xenXMConfigSetIntFromXPath): Likewise.
(xenXMConfigSetStringFromXPath, xenXMParseXMLToConfig): Likewise.
(xenXMDomainAttachDevice, xenXMAttachDisk, xenXMAttachInterface):
(xenXMDomainDetachDevice): Likewise.
* src/xml.c (virXPathString): Likewise.
* tests/xmlrpctest.c (checkRequestValue): Likewise.
2008-02-07 16:49:29 +00:00
Jim Meyering
5a93214143
Remove trailing blanks
2008-02-07 12:34:19 +00:00
Mark McLoughlin
a0f83fd905
* src/xen_internal.c: Don't crash if there's no /sys/hypervisor/capabilities
2008-02-07 10:43:14 +00:00
Mark McLoughlin
3d3c8ac4c4
src/iptables.c: Create directory for saving iptables rules
2008-02-07 10:17:24 +00:00
Mark McLoughlin
f90cd4c3f4
src/xm_internal.[ch]: Move static function prototype from header
2008-02-07 10:14:43 +00:00
Daniel Veillard
ecaf98fcc5
Python bindings return values fixes
...
* python/libvir.c: apply patch from Cole Robinson to provide
return values for manulally written python bindings.
Daniel
2008-02-07 09:49:13 +00:00
Daniel Veillard
232d4f157a
Oops forgot >>>>, Daniel
2008-02-07 09:37:41 +00:00
Daniel Veillard
b33f740e1f
* src/libvirt.c: fix bug in xenUnifiedDomainSuspend() patch provided
...
by Marcus Meissner
Daniel
2008-02-07 09:37:10 +00:00
Daniel Veillard
594af3eb22
add/change/delete a Disk/NIC of an inactive domains
...
* src/xm_internal.[ch]: applied patch from Shigeki Sakamoto to
add/change/delete a Disk/NIC of an inactive domains
Daniel
2008-02-06 17:57:10 +00:00
Daniel Veillard
eecd68364a
QEmu config error handling fixes
...
* src/qemu_conf.c: applied 2 patches from Guido Guenther to avoid
crashes when reading the config file
Daniel
2008-02-06 16:24:28 +00:00
Jim Meyering
5419d0b44d
Fix new "make distcheck" failures.
...
* src/xml.c (virDomainParseXMLOSDescHVM): Mark a diagnostic.
2008-02-05 22:07:31 +00:00
Jim Meyering
e04912a9f0
Remove all trailing blanks; turn on the rule to detect them.
...
* Makefile.cfg (local-checks-to-skip): Remove sc_trailing_blank.
* .x-sc_trailing_blank: New file, to exempt the few binary files.
2008-02-05 19:27:37 +00:00
Daniel P. Berrange
e87e3f86bf
Added support for booting off kenrel+initrd with HVM guests
2008-02-05 16:21:25 +00:00
Jim Meyering
fb66d5ab92
Eliminate all uses of virBufferAdd with string literals.
...
* Makefile.maint (sc_prohibit_virBufferAdd_with_string_literal):
New rule.
* src/buf.h (virBufferAddLit): Define.
* src/conf.c (virConfSaveValue): Use virBufferAddLit, in place
of virBufferAdd everywhere possible.
(virConfSaveEntry): Likewise.
* src/qemu_conf.c (qemudGenerateXML, qemudGenerateNetworkXML): Likewise.
* src/qemu_driver.c (qemudGetFeatures, qemudGetCapabilities): Likewise.
* src/test.c (testDomainDumpXML, testNetworkDumpXML): Likewise.
* src/xen_internal.c (xenHypervisorMakeCapabilitiesXML): Likewise.
* src/xend_internal.c (xend_parse_sexp_desc_os): Likewise.
(xend_parse_sexp_desc, sexpr_to_xend_topology_xml): Likewise.
* src/xm_internal.c (xenXMDomainFormatXML, xenXMDomainPinVcpu): Likewise.
* src/xml.c (virSaveCpuSet, virParseXenCpuTopology): Likewise.
(virDomainParseXMLGraphicsDescImage): Likewise.
(virDomainParseXMLGraphicsDescVFB, virDomainParseXMLOSDescHVM): Likewise.
(virDomainParseXMLOSDescPV, virDomainParseXMLDiskDesc): Likewise.
(virDomainParseXMLIfDesc, virDomainParseXMLDesc): Likewise.
2008-02-05 14:22:28 +00:00
Jim Meyering
ecaa696250
Enable more checks for unmarked messages; fix violators.
...
* Makefile.maint (sc_unmarked_diagnostics): Check for more functions.
* src/conf.c (virConfParseValue): Remove trailing space in diagnostic.
* src/libvirt.c (do_open, virDomainMigrate): Mark diagnostics.
* src/xend_internal.c (do_connect, xenDaemonDomainDumpXMLByID): Likewise.
(xenDaemonDomainDumpXMLByName, xenDaemonCreateLinux): Likewise.
(xenDaemonDomainMigratePerform, xenDaemonDomainDefineXML): Likewise.
* src/xml.c (virXPathString, virXPathNumber, virXPathLong): Likewise.
(virXPathBoolean, virXPathNode, virXPathNodeSet): Likewise.
(virDomainParseXMLOSDescHVM): Likewise.
* src/xmlrpc.c (xmlRpcValueNew): Likewise.
(xmlRpcValueUnmarshalDictElement): Likewise.
2008-02-04 19:31:30 +00:00
Jim Meyering
e99570fc77
Mark a string for translation.
...
* src/virsh.c: Add a "%s" and wrap with _(...).
2008-02-04 14:58:47 +00:00
Jim Meyering
70400346d2
Enable the sc_unmarked_diagnostics test and correct all violations
...
involving the "error" function.
* Makefile.cfg (local-checks-to-skip): Remove from skip list.
* src/remote_internal.c: Mark translatable strings.
2008-02-04 14:58:05 +00:00
Jim Meyering
aa290a3ece
Pull vc-list-files from gnulib, and update.
...
* bootstrap (gnulib_tool): Add the vc-list-files module.
2008-02-01 19:47:07 +00:00
Jim Meyering
b5433aaa6f
Avoid compilation failure when building --without-xen.
...
* tests/statstest.c (testDevice) [!WITH_XEN]: #ifdef-out.
(main) [!WITH_XEN]: #ifdef-out the body.
Committer: Jim Meyering <meyering@redhat.com>
Author: Guido Guenther <agx@sigxcpu.org>
2008-01-31 21:49:47 +00:00
Jim Meyering
f5f530f33f
Avoid virsh leaks due to missing virDomainFree(dom) calls
...
* src/virsh.c (cmdDomuuid): Add missing virDomainFree call.
(cmdAttachDevice): Likewise.
(cmdDetachDevice): Likewise.
2008-01-30 19:58:59 +00:00
Jim Meyering
a1d2d2b21c
src/virsh.c (cmdCapabilities): Plug a small leak.
2008-01-30 19:57:54 +00:00
Jim Meyering
34dff95bfd
src/test.c (testLoadDomain): Avoid leaks upon failure.
2008-01-30 19:57:13 +00:00
Jim Meyering
1217e5d516
Avoid used-uninitialized errors in test driver.
...
* src/test.c (testOpenFromFile): Initialize "privconn".
2008-01-30 19:54:29 +00:00
Jim Meyering
6997b1920f
src/libvirt.c (do_open): Avoid double-free upon failure.
2008-01-30 19:53:10 +00:00
Jim Meyering
218f866f86
Avoid segfault upon malloc failure, and plug a leak.
...
* src/test.c (testDomainSave): Detect testDomainDumpXML failure. Free "xml".
2008-01-30 19:52:16 +00:00
Jim Meyering
5561e9125f
Plug test-related leaks.
...
* src/test.c (testLoadNetwork): Free forwardDev.
(testLoadDomain): Free ctxt.
(testLoadNetwork): Likewise.
(testOpenFromFile): Likewise.
2008-01-30 19:50:14 +00:00
Daniel P. Berrange
17ef6faa7f
Remove double mutex lock()
2008-01-30 18:21:13 +00:00
Daniel P. Berrange
03003499e7
Fix XML generation for Xen USB devices
2008-01-30 16:38:18 +00:00
Jim Meyering
51dd1d9e38
Arrange for "make syntax-check" to pass.
...
* .x-sc_avoid_if_before_free: Exempt ChangeLog.
* tests/statstest.c: Include <config.h>, not "config.h".
2008-01-30 06:55:56 +00:00
Daniel P. Berrange
21416a4746
Fix device name -> number conversion for block stats
2008-01-29 18:36:00 +00:00
Jim Meyering
2367caa327
Also detect and remove unnecessary if-before-xmlXPathFreeContext.
...
* build-aux/find-unnecessary-if-before-free: Update regexp.
* src/openvz_conf.c: Remove unnecessary "if (P)"-before xmlXPathFreeContext.
* src/qemu_conf.c: Likewise.
* src/virsh.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* tests/xmlrpctest.c: Likewise.
2008-01-29 18:23:43 +00:00
Jim Meyering
1be2c8c814
Enable two more tests.
...
* Makefile.cfg (local-checks-to-skip)
[sc_cast_of_x_alloc_return_value, sc_cast_of_argument_to_free]: Enable.
2008-01-29 18:21:00 +00:00
Jim Meyering
2c72562374
Enable the <assert.h>-checking test; fix violations.
...
* Makefile.cfg (local-checks-to-skip)
[sc_prohibit_assert_without_use]: Enable.
* qemud/mdns.c: Don't include <assert.h>; no uses of assert here.
* qemud/qemud.c: Likewise.
* qemud/remote.c: Likewise.
2008-01-29 18:20:25 +00:00
Jim Meyering
05ae9d8bc4
Enable the po-check test; fix violations.
...
* Makefile.cfg (local-checks-to-skip) [po-check]: Enable.
* po/POTFILES.in: Add three file names. Sort.
2008-01-29 18:19:46 +00:00
Jim Meyering
bc48db5758
Update from gnulib
...
* lib/poll.c: Update.
* lib/string.in.h: Update.
* m4/string_h.m4: Update.
* tests/test-getaddrinfo.c: Update.
* lib/Makefile.am: Regenerate.
2008-01-29 18:17:47 +00:00
Jim Meyering
a378188194
Enable the <config.h>-requiring test; fix violations
...
Use <config.h>, not "config.h", per autoconf documentation.
* Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
* .x-sc_require_config_h: New file, to list exempted files.
* Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
2008-01-29 18:15:54 +00:00
Jim Meyering
9e4c8fcb3a
Enable the duplicate-"the" test; fix violations
...
* Makefile.cfg (local-checks-to-skip) [sc_the_the]: Enable.
* docs/virsh.pod: Remove a duplicate "the".
* libvirt.spec.in: Likewise.
* virsh.1: Likewise.
2008-01-29 17:43:28 +00:00
Jim Meyering
cc337da21f
Add framework for code style- and syntax-checking rules.
...
Almost all tests are initially disabled via the list in Makefile.cfg.
* Makefile.am (EXTRA_DIST): Add .x-sc_avoid_if_before_free.
Omit names of files that automake includes automatically.
* .x-sc_avoid_if_before_free: New file.
* build-aux/vc-list-files: Likewise.
* build-aux/find-unnecessary-if-before-free: Likewise.
* GNUmakefile, Makefile.cfg, Makefile.maint: New files.
2008-01-29 17:42:39 +00:00
Jim Meyering
acff2d11ac
Given code like if (foo) free (foo); remove the useless "if (foo) " part.
...
Likewise, given if (foo != NULL) free (foo); remove the useless "if" test.
* proxy/libvirt_proxy.c: Remove unnecessary "if" test before free.
* python/generator.py: Likewise.
* qemud/qemud.c: Likewise.
* src/buf.c: Likewise.
* src/conf.c: Likewise.
* src/hash.c: Likewise.
* src/iptables.c: Likewise.
* src/libvirt.c: Likewise.
* src/openvz_conf.c: Likewise.
* src/qemu_conf.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/remote_internal.c: Likewise.
* src/test.c: Likewise.
* src/virsh.c: Likewise.
* src/virterror.c: Likewise.
* src/xen_internal.c: Likewise.
* src/xen_unified.c: Likewise.
* src/xend_internal.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* src/xmlrpc.c: Likewise.
* src/xs_internal.c: Likewise.
* tests/testutils.c: Likewise.
* tests/xencapstest.c: Likewise.
* tests/xmconfigtest.c: Likewise.
2008-01-29 17:41:07 +00:00
Richard W.M. Jones
b17caa80d1
Clarify virsh documentation.
...
* docs/virsh.pod: Clarify virsh documentation on when you can
set memory and vCPUs.
2008-01-25 12:03:05 +00:00
Daniel Veillard
aab826d4cc
Fix VIR_DOMAIN_NONE into VIR_DOMAIN_NOSTATE
...
* src/xen_internal.c: fix an erronous use of VIR_DOMAIN_NONE instead
of VIR_DOMAIN_NOSTATE (both defined as 0, no regression)
Daniel
2008-01-25 09:47:51 +00:00
Daniel Veillard
3f9a94bec3
* src/libvirt.c: Jay Gagnon pointed out that virDomainGetXMLDesc
...
was failing with a non-zero flag value
Daniel
2008-01-24 17:09:56 +00:00
Richard W.M. Jones
7db9140126
Correct typos in the documentation (Atsushi SAKAI)
...
* README, libvirt.spec.in, docs/devhelp/html.xsl,
docs/devhelp/index.html: Correct typos in the documentation.
2008-01-24 10:15:13 +00:00
Daniel P. Berrange
38b2478b41
Fix enablement of SASL
2008-01-23 19:37:10 +00:00
Richard W.M. Jones
9cf2573c8a
Portability improvements for Mac OS X.
...
* configure.in: Use PortableXDR if available.
* qemud/internal.h: Use "socketcompat.h".
* qemud/qemud.c: Use <signal.h>.
* src/sexpr.c: Use <stdlib.h> instead of <malloc.h>.
* src/socketcompat.h: Include <sys/un.h> for Mac OS X.
2008-01-23 14:54:41 +00:00
Richard W.M. Jones
569200b6d4
Remove DOS line-endings.
...
* src/socketcompat.h: Remove DOS line-endings in this file.
2008-01-23 14:50:14 +00:00
Daniel P. Berrange
9d7661e415
Fix compat for old pkg-config and gnutls
2008-01-22 21:30:05 +00:00
Jim Meyering
63dffbf1d2
Avoid "may be used uninitialized" warning.
...
* tests/xmconfigtest.c (testCompareParseXML): Initialize "old_priv".
2008-01-21 17:06:47 +00:00
Daniel P. Berrange
97bed42f7a
Fix & refactor ref counting cleanup code
2008-01-21 16:29:10 +00:00
Daniel P. Berrange
c9b7eae903
Make python generator fail build on any missing APIs
2008-01-21 15:55:53 +00:00
Daniel P. Berrange
62094f72f6
Add missing vcpu/schedular APIs to python binding
2008-01-21 15:41:15 +00:00
Daniel P. Berrange
45738083a6
Use virFileReadAll in virsh.c
2008-01-21 15:27:14 +00:00
Daniel P. Berrange
53365f4c54
Remove no-op networking APIs from openvz driver
2008-01-21 15:19:46 +00:00
Jim Meyering
64b3019d69
Adjust sexpr-related interfaces to be const-correct.
...
* src/sexpr.c (sexpr_cons, append, sexpr_append, sexpr2string)
(sexpr_lookup_key, sexpr_lookup, sexpr_node, sexpr_fmt_node):
Add "const" attribute where appropriate.
* src/xend_internal.c (sexpr_int, sexpr_float, sexpr_u64)
(sexpr_uuid, sexpr_to_xend_domain_info, sexpr_to_xend_node_info)
(sexpr_to_xend_topology_xml, sexpr_to_domain): Likewise.
* src/sexpr.h: Adjust prototypes.
2008-01-21 14:22:15 +00:00
Jim Meyering
a430f22be4
Don't access line[-1] for a zero-length "line" from fgets.
...
A NUL byte at beginning of input, or just after a newline
would provoke an invalid buf[-1] access (possible segfault).
* src/libvirt.c (virConnectAuthCallbackDefault):
2008-01-21 14:09:51 +00:00
Daniel Veillard
5912e7c233
Preserve vif order
...
* src/xml-internal.c: apply patch from Hiroyuki Kaguchi to
preserve the vif list order.
Daniel
2008-01-21 08:27:12 +00:00
Daniel Veillard
d3043afe5c
Remove docs/API*.html
...
* docs/API* docs/api.xsl docs/site.xsl docs/Makefile.am: remove the
generation of the API*.html files as it's not really useful here
Daniel
2008-01-21 08:08:33 +00:00
Daniel P. Berrange
d56aff5255
Added xstrtol_ll and xstrtol_ull convenience functions
2008-01-20 16:11:25 +00:00
Daniel P. Berrange
e05a879022
Fix nodeinfo compat for Xen 3.2.0
2008-01-20 15:56:49 +00:00
Daniel P. Berrange
e8d690aeb5
Enable debug by default, but only if LIBVIRT_DEBUG=1. Use generic macro for debug output
2008-01-19 18:36:01 +00:00
Jim Meyering
df7bf130ae
docs/examples/examples.xml: Regenerate, now that *.c file names are sorted.
2008-01-15 15:27:31 +00:00
Daniel P. Berrange
f6ba6e9eb7
Support VNC keymap option with QEMU (Daniel Hokka Zakrisson)
2008-01-15 15:18:33 +00:00
Daniel P. Berrange
045d32a8e8
Fix off-by-one in SSH argv checking. Fix format string warning
2008-01-15 14:23:52 +00:00
Jim Meyering
32d4aeb162
Update from gnulib.
2008-01-14 14:07:25 +00:00
Jim Meyering
2edab512a0
Clean up the global name space.
...
* src/qemu_conf.c: Add "static" and "const" attributes to some globals.
* src/qemu_conf.h: Update a declaration.
* src/qemu_driver.c (qemud_driver): Declare static.
Author: Jim Meyering <meyering@redhat.com>
2008-01-14 14:05:25 +00:00
Jim Meyering
f510a6128b
Clean up global name space in examples and tests.
...
* docs/examples/suspend.c: Declare global "conn" to be static.
* tests/qemuxml2argvtest.c: Declare global "driver" to be static.
* tests/qemuxml2xmltest.c: Likewise.
Author: Jim Meyering <meyering@redhat.com>
2008-01-14 14:04:33 +00:00
Daniel P. Berrange
6aae9a9efb
Re-factor auth code to make clearer (Jim Meyering)
2008-01-14 04:05:23 +00:00
Daniel P. Berrange
b2083ea907
Fix crash when no auth callback
2008-01-14 04:00:34 +00:00
Mark McLoughlin
4c50142381
fix an unused variable warning
2008-01-10 14:41:39 +00:00
Mark McLoughlin
73ab4e0845
add iptablesSaveRules(), and don't save the rules to disk
...
and run lokkit each time a new rule is added.
2008-01-10 14:01:00 +00:00
Mark McLoughlin
2d2e410818
now that we only use built-in iptables chains, we don't
...
need to add or delete them
2008-01-10 13:58:59 +00:00
Mark McLoughlin
9b29b2a2a5
Like --with-iptables-prefix, --with-iptables-dir is no
...
longer useful, so let's remove it.
2008-01-10 13:57:48 +00:00
Mark McLoughlin
f8e0674ad5
--with-iptables-prefix was added to integrate with
...
a proposed system for letting iptables know how to
reload our rules. The proposed system wasn't accepted
so, although there might be some other theoretical
use for this, let's just remove it.
2008-01-10 13:56:22 +00:00
Mark McLoughlin
b9daf6d9dd
Add support for integrating our iptables support with Fedora's
...
iptables configuration using the lokkit --custom-rules command.
Basically, we write out our rules to /var/lib/libvirt/iptables
and run lokkit --custom-rules so that if e.g. iptables is
restarted or the user edits their firewall configuration, then
libvirt's rules get reloaded.
2008-01-10 13:54:02 +00:00
Mark McLoughlin
a43ddc075a
Include the iptables command and chain name in the saved rules files
2008-01-10 13:51:55 +00:00
Mark McLoughlin
9d04c25ab2
Re-name the "flipflop" variable to "command_idx"
2008-01-10 13:50:46 +00:00
Mark McLoughlin
cc83cda045
make use of virFileMakePath(), virFileBuildPath() and virRun().
2008-01-10 13:49:55 +00:00
Mark McLoughlin
fc11528f98
Fix compile error in --with-iptables-dir code
2008-01-10 13:48:44 +00:00
Mark McLoughlin
cf0ee0f6e4
Change virExec() such that with --enable-debug,
...
stdout and stderr no longer go to /dev/null.
2008-01-10 13:47:49 +00:00
Mark McLoughlin
77a2fc0061
Add virRun() helper function (Dan Berrange)
2008-01-10 13:46:10 +00:00
Daniel P. Berrange
9d11255a47
Fix vcpupin hypercall map data to be 8-bytes
2008-01-09 21:08:29 +00:00
Daniel P. Berrange
78f2cd3d2d
Added graceful shutdown support to QEMU/KVM (patch from Guido Guenther)
2008-01-09 16:05:21 +00:00
Daniel P. Berrange
8796a9ff74
Fix warning in debug output
2008-01-08 17:52:10 +00:00
Daniel P. Berrange
8cd4774468
Fix buffer passed to free()
2008-01-08 16:17:15 +00:00
Daniel P. Berrange
94e49e3f0e
Fix config file reading to not truncate large files
2008-01-07 15:21:33 +00:00
Richard W.M. Jones
029aef1d24
Miscellaneous fixes for building on Windows (MinGW).
...
* configure.in: xdr functions may require -lxdr.
* configure.in, src/Makefile.am: Extra linking flags for
building libvirt DLL.
* src/socketcompat.h: Hide Windows Winsock incompatibilities
in a separate header file.
* src/remote_internal.c: Switch to using socketcompat.h /
socket_errno().
* src/test.c: Switch to using socketcompat.h.
* gnulib/lib/arpa/.cvsignore: Ignore another generated file.
* src/qparams.c: Include <config.h>.
2008-01-05 16:06:36 +00:00
Daniel P. Berrange
76122538b6
Fix crash when no auth callback is provided
2008-01-02 22:48:04 +00:00
Daniel Veillard
7b40fcd11f
* src/openvz.c: patch from Mikhail Pokidko to fix the OpenVZ
...
compilation error #426385
Daniel
2007-12-26 05:41:05 +00:00
Daniel Veillard
6cb0289917
* configure.in docs/libvir.html docs/news.html po/*:
...
prepare release of libvirt-0.4.0
Daniel
2007-12-17 23:20:12 +00:00
Daniel P. Berrange
7d0cef38b5
Added dep on 'nc' RPM
2007-12-17 23:05:51 +00:00
Daniel P. Berrange
d575a83f81
Fix nodeinfo compat with Xen 3.2.0
2007-12-17 23:04:33 +00:00
Richard W.M. Jones
1be1fe69f5
Fix remote_internal.c error handling of qparam_get_query
...
* src/remote_internal.c: Fixed reversed check of error handling
of qparam_get_query call (Dan Berrange).
2007-12-17 17:41:02 +00:00
Richard W.M. Jones
3b0149354b
Add separate qparams module for handling query parameters.
...
* src/qparams.c, src/qparams.h, src/Makefile.am: Added a
separate 'qparams' module for handling query parameters.
* src/remote_internal.c: Factor out query parameter code so
it uses the 'qparams' module.
2007-12-17 10:07:56 +00:00
Richard W.M. Jones
ed9788c796
Add extra utility functions to buf.c
...
* src/buf.c, src/buf.h: Added utility functions
virBufferURIEncodeString and virBufferAddChar to the
buffer module.
2007-12-17 10:05:35 +00:00
Daniel P. Berrange
a11494fd52
Don't invoke callback with unsupported credential types
2007-12-15 17:15:12 +00:00
Daniel Veillard
cc8e4ff318
fix setting CPU parameters in the config files
...
* src/xm_internal.c: patch from Saori Fukuta to fix setting
CPU parameters in the config files, the value was overwritten
Daniel
2007-12-14 15:51:42 +00:00
Daniel Veillard
81acc14e3a
fix the detach-disk command when using Xen tap devices
...
* src/xs_internal.[ch]: patch from Saori Fukuta to fix the
detach-disk command when using Xen tap devices.
* docs/libvir.html: typo fix from Jim Meyering
Daniel
2007-12-14 15:38:02 +00:00
Richard W.M. Jones
b47ffc035c
Fix virBufferEscapeString escaping of '<'
...
* src/buf.c (virBufferEscapeString): '<' escaped as "<"
2007-12-12 16:27:10 +00:00
Jim Meyering
0d0b0113d0
Always build in python/ subdir.
...
* configure.in (PYTHON_SUBDIR): Don't set. Remove all uses.
* Makefile.am (SUBDIRS): Hard-code "python" here.
(tests): Test equivalent "$(pythondir)", not @PYTHON_SUBDIR@.
2007-12-12 08:12:38 +00:00
Jim Meyering
9e188e11c5
Accommodate automake-1.9.
...
* tests/Makefile.am (TESTS_ENVIRONMENT): Adjust PATH setting
to work also with automake-1.9. Can't use $(abs_top_builddir).
Author: Jim Meyering <meyering@redhat.com>
2007-12-12 07:21:37 +00:00
Jim Meyering
49230350fa
Use a variable name as sizeof argument, not a type name.
...
Given code like: T *var = calloc (n, sizeof (T));
Convert to this: T *var = calloc (n, sizeof (*var));
This first-cut change adjusts all malloc, calloc, and
realloc statements.
The only binary differences are in remote_internal.c
(due to the bug fix) and in xmlrpc.c (due to factorization).
* python/libvir.c: As above.
* qemud/event.c: Likewise.
* qemud/mdns.c: Likewise.
* qemud/qemud.c: Likewise.
* qemud/remote.c: Likewise.
* src/bridge.c: Likewise.
* src/buf.c: Likewise.
* src/conf.c: Likewise.
* src/hash.c: Likewise.
* src/iptables.c: Likewise.
* src/openvz_conf.c: Likewise.
* src/qemu_conf.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/test.c: Likewise.
* src/xen_internal.c: Likewise.
* src/xen_unified.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* tests/qemuxml2argvtest.c: Likewise.
* src/xmlrpc.c (xmlRpcValuePtr): Likewise, and minor factorization.
* src/remote_internal.c (remoteAuthMakeCredentials): Use the right
type when allocating space for an array of cred _pointers_.
2007-12-11 21:57:29 +00:00
Jim Meyering
5a190594f4
Test libvirtd's config-processing code.
...
And remove a minor diagnostic inconsistency.
* tests/daemon-conf: New test.
* tests/Makefile.am (TESTS_ENVIRONMENT): Prepend qemud/ to PATH,
so we can invoke libvirtd without an absolute name.
(test_scripts): Add daemon-conf.
* qemud/qemud.c (remoteConfigGetAuth): Use checkType,
rather than open-coding it with a different diagnostic.
2007-12-11 21:20:13 +00:00
Jim Meyering
ac6bb7e131
Add gnulib-tool unit tests.
...
* bootstrap: Re-add --with-tests, now that gnulib-tool
arranges to use separate libraries for lib/ and tests/.
* configure.in (AC_OUTPUT): Add gnulib/tests/Makefile.in.
* Makefile.am (SUBDIRS): Add gnulib/tests.
* gnulib/tests/Makefile.am: New file.
* gnulib/lib/.cvsignore: Sort.
* gnulib/lib/Makefile.am, gnulib/m4/getdelim.m4, gnulib/m4/getline.m4:
* gnulib/m4/gnulib-cache.m4, gnulib/m4/gnulib-comp.m4: Regenerate.
* gnulib/tests/test-alloca-opt.c: New file, from gnulib.
* gnulib/tests/test-arpa_inet.c: Likewise.
* gnulib/tests/test-fseeko.c: Likewise.
* gnulib/tests/test-fseeko.sh: Likewise.
* gnulib/tests/test-getaddrinfo.c: Likewise.
* gnulib/tests/test-getdelim.c: Likewise.
* gnulib/tests/test-getline.c: Likewise.
* gnulib/tests/test-lseek.c: Likewise.
* gnulib/tests/test-lseek.sh: Likewise.
* gnulib/tests/test-netinet_in.c: Likewise.
* gnulib/tests/test-snprintf.c: Likewise.
* gnulib/tests/test-stdbool.c: Likewise.
* gnulib/tests/test-stdint.c: Likewise.
* gnulib/tests/test-stdio.c: Likewise.
* gnulib/tests/test-stdlib.c: Likewise.
* gnulib/tests/test-string.c: Likewise.
* gnulib/tests/test-sys_select.c: Likewise.
* gnulib/tests/test-sys_socket.c: Likewise.
* gnulib/tests/test-sys_stat.c: Likewise.
* gnulib/tests/test-sys_time.c: Likewise.
* gnulib/tests/test-unistd.c: Likewise.
* gnulib/tests/test-vasnprintf.c: Likewise.
* gnulib/tests/test-vasprintf.c: Likewise.
* gnulib/tests/test-wchar.c: Likewise.
* gnulib/tests/dummy.c: Likewise.
* gnulib/tests/intprops.h: Likewise.
* gnulib/tests/verify.h: Likewise.
2007-12-10 18:26:56 +00:00
Daniel P. Berrange
fd6ce1e637
Remove gnulib/lib/arpa/inet.h autogenerated file
2007-12-08 23:08:54 +00:00
Daniel P. Berrange
8392c710ae
Remove bogus autoconf 2.60 prereq
2007-12-07 15:31:36 +00:00
Daniel P. Berrange
6dfa7af42a
Fix minor quoting issue
2007-12-07 15:17:42 +00:00
Richard W.M. Jones
acbd696b05
Fri Dec 7 14:55:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* proxy/Makefile.am: Include gnulib code when building the
proxy.
2007-12-07 15:00:26 +00:00
Richard W.M. Jones
0d14fc0cbb
Fri Dec 7 14:49:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/console.c, src/console.h, src/virsh.c: Disable
text console on Windows.
* src/libvirt.c: Use replacement getpass from Gnulib.
* src/libvirt.c: Initialize Winsock before use.
* src/remote_internal.c: Header file fixes for Windows.
Don't fail if AI_ADDRCONFIG isn't defined. Disable
unsupported stuff under Windows.
* src/uuid.c: ENODATA unavailable on Windows, use EIO instead.
* src/virsh.c: No uid_t / getuid on Windows.
* src/virsh.c: No O_SYNC on Windows.
2007-12-07 14:56:37 +00:00
Richard W.M. Jones
f3ebd20d35
Fri Dec 7 14:47:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/internal.h: Use gnulib gettext library. Define
INET_ADDRSTRLEN unless already defined.
2007-12-07 14:52:24 +00:00
Richard W.M. Jones
f1f94721ae
Fri Dec 7 14:36:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/.cvsignore: Ignore *.loT files (generated under Windows).
* proxy/libvirt_proxy.c: Bail out earlier --without-xen.
* src/proxy_internal.c: Don't build proxy client side if
configured --without-xen.
* src/iptables.c, src/iptables.h: Disable this code if
configured --without-qemu.
* src/nodeinfo.c: If no 'uname' function, set model name to
empty string (for Windows).
* src/xen_unified.h, src/util.c, src/test.c: Include <winsock2.h>
on Windows.
* src/util.c: Disable virExec* and virFileLinkPointsTo on
MinGW.
2007-12-07 14:45:39 +00:00
Richard W.M. Jones
36f0ce0472
Fri Dec 7 14:34:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/sexpr.c: Cosmetic rearrangement of headers.
2007-12-07 14:39:14 +00:00
Richard W.M. Jones
abe8a90952
Fri Dec 7 14:27:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* configure.in: Extra checks for uname and some header files
(for MinGW Windows port).
2007-12-07 14:35:18 +00:00
Richard W.M. Jones
532759a593
Fri Dec 7 14:27:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* bootstrap, Makefile.am, gnulib/*: Import more gnulib
modules for use by MinGW Windows port.
2007-12-07 14:32:35 +00:00
Jim Meyering
4a2f8fc633
Include "config.h" in remaining non-generated files.
...
* proxy/libvirt_proxy.c: Likewise.
* python/libvir.c: Likewise.
* python/types.c: Likewise.
* src/event.c: Likewise.
* src/xm_internal.c: Likewise.
* tests/reconnect.c: Likewise.
* tests/testutils.c: Likewise.
2007-12-07 10:08:06 +00:00
Daniel Veillard
a56281c0a8
* python/generator.py python/libvir.c python/libvirt-python-api.xml:
...
add a python binding for virNodeGetCellsFreeMemory
Daniel
2007-12-07 08:41:01 +00:00
Jim Meyering
7ff9eebeba
qemud/qemud.c (qemudInitPaths): Remove unused code.
2007-12-06 16:41:43 +00:00
Richard W.M. Jones
efd495d667
Thu Dec 6 16:32:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/virsh.c: The prompt should depend on readonly status,
not on the UID.
2007-12-06 16:36:21 +00:00
Richard W.M. Jones
21e0a86f25
Thu Dec 6 16:30:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* configure.in, qemud/Makefile.am: Added a --without-libvirtd
configure option.
2007-12-06 16:34:48 +00:00
Daniel P. Berrange
bb020a9f75
Fix polkit macros for RHEL
2007-12-06 15:35:54 +00:00
Daniel Veillard
d5fc8b3036
* docs/*: rebuilt the docs and XML files
...
Daniel
2007-12-06 14:54:23 +00:00
Daniel Veillard
5390cfcc72
* po/*: updated the localization files
...
Daniel
2007-12-06 14:43:41 +00:00
Richard W.M. Jones
ec38eb9388
Thu Dec 6 12:00:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/remote_internal.c: Clean up a warning if neither SASL
nor PolKit are enabled.
2007-12-06 12:05:35 +00:00
Jim Meyering
2ec759fc58
Build also on systems where -lreadline requires e.g., -lncurses
...
* configure.in: If the test for -lreadline fails, search for a
library with termcap support. If one is found (often -lncurses),
rerun the test for -lreadline, linking also with the new library.
Author: Jim Meyering <meyering@redhat.com>
2007-12-06 11:42:26 +00:00
Daniel Veillard
7633453cfa
* configure.in src/Makefile.am src/virsh.c: fix compilation problems
...
when readline headers were found but not the library
Daniel
2007-12-06 10:24:52 +00:00
Jim Meyering
d51e7c9ff0
Accommodate developers using autoconf-2.59.
...
* configure.in (m4_foreach_w): Define if not defined.
Author: Jim Meyering <meyering@redhat.com>
2007-12-05 23:02:13 +00:00
Jim Meyering
87396257fc
Include "config.h".
...
* qemud/event.c: Likewise.
* src/buf.c: Likewise.
* src/hash.c: Likewise.
* src/nodeinfo.c: Likewise.
* src/openvz_conf.c: Likewise.
* src/proxy_internal.c: Likewise.
* src/virterror.c: Likewise.
* src/xmlrpc.c: Likewise.
* src/xs_internal.c: Likewise.
* tests/conftest.c: Likewise.
* tests/xmlrpctest.c: Likewise.
This fixes a mingw build failure reported by Rich Jones.
Author: Jim Meyering <meyering@redhat.com>
2007-12-05 21:40:15 +00:00
Jim Meyering
4c6bef2a6c
Add all of the files pulled in by running ./bootstrap.
...
Adjust .cvsignore files.
Author: Jim Meyering <meyering@redhat.com>
2007-12-05 21:35:32 +00:00
Jim Meyering
261e7581b1
Use gnulib, starting with its physmem and getaddrinfo modules.
...
New files go into these directories:
gnulib/lib
gnulib/m4
gnulib/tests
* bootstrap: A wrapper around gnulib-tool.
* configure.in: Invoke gl_EARLY and gl_INIT, being careful to put gl_EARLY
before any macro that uses AC_COMPILE_IFELSE.
(AC_OUTPUT): Add lib/Makefile and gl-tests/Makefile. Remove m4/Makefile.
* Makefile.am (SUBDIRS): Add gnulib/lib and remove m4. Add gnulib/tests
early enough that those tests run before any libvirt unit tests.
* m4/Makefile.am: Remove file. Not needed.
* src/Makefile.am (INCLUDES): Add -I$(top_srcdir)/gnulib/lib -I../gnulib/lib.
(LDADDS, libvirt_la_LIBADD): Add ../gnulib/lib/libgnu.la.
* src/nodeinfo.c: Include "physmem.h".
* qemud/qemud.c, src/remote_internal.c: Include "getaddrinfo.h".
(MEMINFO_PATH, linuxNodeInfoMemPopulate): Remove definitions.
(virNodeInfoPopulate): Use physmem_total, not linuxNodeInfoMemPopulate.
* tests/Makefile.am (INCLUDES): Add -I$(top_srcdir)/gnulib/lib -I../gnulib/lib.
(LDADDS): Add ../gnulib/lib/libgnu.la.
* qemud/Makefile.am (libvirtd_LDADD): Add ../gnulib/lib/libgnu.la.
* tests/nodeinfotest.c (linuxTestCompareFiles): No longer read total
memory from a file.
Update expected output not to include "Memory: NNNN"
* tests/nodeinfodata/linux-nodeinfo-1.txt:
* tests/nodeinfodata/linux-nodeinfo-2.txt:
* tests/nodeinfodata/linux-nodeinfo-3.txt:
* tests/nodeinfodata/linux-nodeinfo-4.txt:
* tests/nodeinfodata/linux-nodeinfo-5.txt:
* tests/nodeinfodata/linux-nodeinfo-6.txt:
* src/test.c [WITH_TEST]: Remove definition of _GNU_SOURCE that
would conflict with the one now in "config.h".
* autogen.sh: Add -I gnulib/m4.
* src/conf.c, src/sexpr.c: Don't define _GNU_SOURCE.
Instead, include "config.h".
* qemud/qemud.c: Remove definition of _GNU_SOURCE.
* src/openvz_driver.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/remote_internal.c: Likewise.
* configure.in: Use AC_CONFIG_AUX_DIR(build-aux), so that a bunch
of gettextize-generated files go into build-aux/, rather than in
the top-level directory.
* .cvsignore: Adjust.
* build-aux/.cvsignore: New file.
Author: Jim Meyering <meyering@redhat.com>
2007-12-05 21:31:07 +00:00
Daniel Veillard
1d1cf57b9b
* qemud/remote.c: rename remoteDispatchAuthPolkitInit to
...
remoteDispatchAuthPolkit, the no-op init call when policykit
is not available
Daniel
2007-12-05 20:45:37 +00:00
Daniel P. Berrange
2add6b3026
Fix compile issues when SASL is disabled
2007-12-05 19:25:44 +00:00
Daniel P. Berrange
0e5f5da3db
Added docs on authentication setup
2007-12-05 19:16:13 +00:00
Daniel P. Berrange
48c48b260d
Disable setuid Xen proxy if policykit is enabled
2007-12-05 19:11:01 +00:00
Daniel P. Berrange
5ab109f862
Add manual impl of virConnectOpenAuth python binding
2007-12-05 19:09:23 +00:00
Daniel P. Berrange
60a6bbe6c5
Re-add listen_tcp/listen_tls config params accidentally lost
2007-12-05 18:56:27 +00:00
Daniel P. Berrange
e332ccdf71
Wire up SASL interaction callbacks to libvirt callbacks. Provide default callback impl
2007-12-05 18:55:04 +00:00
Daniel P. Berrange
7fa9ceb740
Added public API for authentication credential callback support
2007-12-05 18:28:05 +00:00
Daniel P. Berrange
282342c1c5
Added PolicyKit authentication support
2007-12-05 18:21:27 +00:00
Richard W.M. Jones
ffdbb903e4
Wed Dec 5 18:00:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/Makefile.am, tests/Makefile.am: Remove LIBOBJS/LTLIBOBJS
which were incorrectly committed earlier.
2007-12-05 18:05:13 +00:00
Daniel P. Berrange
ca71b87cb0
Quit virsh immediately if connection open fails, rather than giving a non-functional interactive shell
2007-12-05 16:24:22 +00:00
Daniel P. Berrange
cfb62c9d5e
Add whitelisting of users. Remove IP whitelisting. Make auth schemes configurable
2007-12-05 15:34:05 +00:00
Daniel P. Berrange
bb5371f668
Add data encryption using SASL SSF layer
2007-12-05 15:27:08 +00:00
Daniel P. Berrange
1b1d647439
Initial integration of SASL authentication, working for Kerberos only
2007-12-05 15:24:15 +00:00
Daniel P. Berrange
a8977b62ba
Strip autogenerated vnetXXX interfaces
2007-12-05 15:08:23 +00:00
Richard W.M. Jones
4bfdb77aae
Wed Dec 5 13:48:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* python/libvir.c, python/libvirt_wrap.h, qemud/qemud.c,
qemud/remote.c, src/internal.h, src/openvz_conf.c,
src/openvz_driver.c, src/proxy_internal.h, src/qemu_conf.c,
src/qemu_driver.c, src/remote_internal.h, src/test.h, src/util.c,
src/xen_unified.c, src/xen_unified.h, tests/nodeinfotest.c,
tests/qemuxml2argvtest.c, tests/qemuxml2xmltest.c, tests/reconnect.c,
tests/sexpr2xmltest.c, tests/virshtest.c, tests/xencapstest.c,
tests/xmconfigtest.c, tests/xml2sexprtest.c:
Change #include <> to #include "" for local includes.
Removed many includes from src/internal.h and put them in
the C files which actually use them.
Removed <ansidecl.h> - unused.
Added a comment around __func__.
Removed a clashing redefinition of VERSION symbol.
All limits (PATH_MAX etc) now done in src/internal.h, so we
don't need to include those headers in other files.
2007-12-05 13:56:22 +00:00
Richard W.M. Jones
5682ba5921
Tue Dec 4 18:25:01 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* configure.in: Fix configure if rpcgen program is missing.
2007-12-04 19:14:11 +00:00
Richard W.M. Jones
4338271f1a
Tue Dec 4 17:47:01 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* configure.in: curses is not actually required to build libvirt
* configure.in, src/virsh.c: Make readline optional. If not
available then virsh is built without support for command
line editing.
2007-12-04 18:27:52 +00:00
Jim Meyering
025c5df87b
Avoid compile failure when HAVE_AVAHI is not defined.
...
* qemud/qemud.c (remoteReadConfigFile): Remove some of the
"#ifdef HAVE_AVAHI" guards around uses of mdns_name and mdns_adv.
2007-12-03 19:45:00 +00:00
Richard W.M. Jones
78f756e081
Mon Dec 3 16:15:10 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/util.c: Fix header files for Windows builds.
2007-12-03 16:19:41 +00:00
Daniel P. Berrange
4cd62fe306
Move generic file & I/O routines out of QEMU driver into util.c
2007-12-03 14:30:46 +00:00
Daniel Veillard
ed5e20baab
* src/xen_unified.[ch] src/proxy_internal.c src/xen_internal.c
...
src/xend_internal.c src/xm_internal.c src/xs_internal.c:
cleanup the xen subdriver table, remove the type entry and
always return "Xen" from the unified entry point.
Daniel
2007-12-03 09:34:38 +00:00
Daniel P. Berrange
2b3c49b6ab
Fix numerous memory leaks
2007-12-01 15:45:25 +00:00
Daniel P. Berrange
b4f841d92f
Fix buffer termination off-by-1 in link comparison code
2007-12-01 15:29:45 +00:00
Daniel P. Berrange
6d3f1d516e
Disable Xen specific functions if Xen driver is disabled
2007-11-30 22:51:54 +00:00
Jim Meyering
c3c80a183e
Detect heap allocation failure; factor out some duplication.
...
* qemud/qemud.c (tls_port, tcp_port, mdns_name, tls_allowed_ip_list):
(tls_allowed_dn_list): Remove "const", now that we free these.
(unix_sock_rw_mask): Rename from unix_sock_rw_perms, so that
the latter name can be used as a local string variable, so that the
variable name matches the config attribute name.
(unix_sock_ro_mask): Rename from unix_sock_ro_perms, likewise.
(remoteCheckDN, remoteCheckAccess): Adapt to const removal.
(qemudDispatchServer): Check for heap allocation failure.
(remoteConfigGetStringList): New function, based on code from Dan Berrangé.
(CHECK_TYPE): Remove macro.
(checkType): New function.
(GET_CONF_INT, GET_CONF_STR): New macros.
(remoteReadConfigFile): Use new macros to avoid duplication and to
check for allocation failure.
* src/conf.h (virConfTypeName): New static inline function.
2007-11-30 15:43:42 +00:00
Richard W.M. Jones
2ac691d60e
Fri Nov 30 11:04:00 GMT 2007 Richard W.M. Jones <rjones@redhat.com>
...
* python/libvir.c, python/libvir.py: Make Python aware that
the C bindings module is called cygvirtmod.dll when compiled
by CYGWIN.
* python/Makefile.am: Remove symlink libvirtmod.dll -> cygvirtmod.dll
no longer necessary because of the above.
* configure.in: Remove AM_CONDITIONAL(CYGWIN).
2007-11-30 11:10:53 +00:00
Richard W.M. Jones
d63034c018
Thu Nov 29 17:40:00 GMT 2007 Richard W.M. Jones <rjones@redhat.com>
...
* configure.in: Added CYGWIN_EXTRA_LDFLAGS, CYGWIN_EXTRA_LIBADD,
CYGWIN_EXTRA_PYTHON_LIBADD, CYGWIN automake conditional.
* src/Makefile.am: Extra flags required to build DLL of libvirt
for Cygwin.
* python/Makefile.am: Extra flags and rule required to build
Python module for Cygwin.
2007-11-29 17:44:01 +00:00
Richard W.M. Jones
65aa3dbf6c
Thu Nov 29 17:38:00 GMT 2007 Richard W.M. Jones <rjones@redhat.com>
...
* configure.in: Check for C compiler first before checking for
external programs.
Add AC_LIBTOOL_WIN32_DLL.
Add AM_PROG_CC_STDC.
Add AC_C_CONST.
2007-11-29 17:41:57 +00:00
Richard W.M. Jones
4a898dd491
Thu Nov 29 16:19:00 GMT 2007 Richard W.M. Jones <rjones@redhat.com>
...
* docs/libvir.html, docs/windows.html: Updated Windows
documentation now that we have shared libraries and Python
working.
2007-11-29 16:21:52 +00:00
Richard W.M. Jones
ba75647b55
Thu Nov 29 09:15:00 GMT 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/virsh.c: Added #include <time.h> so it can compile
on CentOS 4 (Carl Jones).
2007-11-29 09:18:04 +00:00
Richard W.M. Jones
df0525a911
Wed Nov 28 14:20:00 GMT 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/virsh.c: Missing comma.
2007-11-28 14:22:30 +00:00
Jim Meyering
55311d6c38
src/virsh.c (vshCloseLogFile): Diagnose close/write failure.
2007-11-28 13:22:33 +00:00
Richard W.M. Jones
208a450a53
Wed Nov 28 09:00:00 GMT 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/xm_internal.c, src/xm_internal.h: Added support for
pinning inactive domains for Xen 3.0.3 (Saori Fukuta).
2007-11-28 10:11:18 +00:00
Jim Meyering
59a375812d
When reporting errors, use "conn" whenever possible.
...
* src/remote_internal.c: change all error (NULL, ... to error (conn, ...
(check_cert_file): Add+use parameter, conn.
Adjust callers.
(initialise_gnutls): The "conn" parameter *is* used, so remove
ATTRIBUTE_UNUSED.
Author: Jim Meyering <meyering@redhat.com>
2007-11-27 18:18:23 +00:00
Daniel Veillard
b4438e5933
* docs/site.xsl docs/libvir.html *.html: add boilerplate for
...
a Windows support page
Daniel
2007-11-27 15:41:32 +00:00
Daniel Veillard
1338ed4f25
* configure.in: when configuring with --prefix=/usr i.e. the same
...
prefix as the installed libvirt, use the same localstatedir /var
(instead of /usr/var) and sysconfdir /etc (instead of /usr/etc) to
be able to connect to the system daemon, and use the system local
options
* src/xs_internal.c: avoid error message when non-root cannot open
xenstore
* src/xend_internal.c: avoid error message when non-root cannot
directly access xend, in those 2 cases the proxy (or remote code)
should implement the access so there is no need to raise the error
there.
Daniel
2007-11-27 14:39:42 +00:00
Daniel Veillard
3e59effd03
* doc/*: modified the python page into a bindings page,
...
added the Ruby binding link to all pages
Daniel
2007-11-26 14:07:56 +00:00
Richard W.M. Jones
851c651820
Mon Nov 26 12:12:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* configure.in, src/console.c: Replace cfmakeraw if not in
standard library.
2007-11-26 12:14:32 +00:00
Richard W.M. Jones
b7641686a6
Mon Nov 26 12:03:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* tests/Makefile.am, tests/nodeinfotest.c, tests/qemuxml2argvtest.c,
tests/qemuxml2xmltest.c, tests/sexpr2xmltest.c, tests/virshtest.c,
tests/xencapstest.c, tests/xmconfigtest.c, tests/xml2sexprtest.c:
Miscellaneous fixes to the tests to compile under Cygwin.
2007-11-26 12:03:34 +00:00
Richard W.M. Jones
fe9d013c3e
Mon Nov 26 11:56:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* qemud/qemud.c: If AF_INET6 not defined, don't test for it.
2007-11-26 11:56:41 +00:00
Richard W.M. Jones
31527e43d9
Mon Nov 26 11:54:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* qemud/internal.h: Miscellaneous header file fixes to allow
libvirtd to build under Cygwin.
2007-11-26 11:54:29 +00:00
Richard W.M. Jones
b740fe92d3
Mon Nov 26 11:52:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* configure.in, proxy/Makefile.am: Disable building of the Xen proxy
if configured --without-xen.
2007-11-26 11:52:38 +00:00
Richard W.M. Jones
95585d7c94
Mon Nov 26 11:49:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/bridge.c, src/bridge.h, src/qemu_conf.c, src/qemu_conf.h,
src/qemu_driver.c, src/qemu_driver.h, src/test.c: Disable more
of qemu if configured --without-qemu.
2007-11-26 11:50:16 +00:00
Richard W.M. Jones
d6d1c629fa
Mon Nov 26 11:47:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/remote_internal.c: Miscellaneous header file fixes for
Cygwin.
2007-11-26 11:47:15 +00:00
Richard W.M. Jones
1ef8005d65
Mon Nov 26 11:44:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* configure.in, qemud/Makefile.am: Check for buggy glibc rpcgen
and only run Perl fix-up script for that.
2007-11-26 11:45:26 +00:00
Richard W.M. Jones
d43607b2f9
Mon Nov 26 11:42:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* configure.in: Check if -lrpc is needed to get XDR functions.
2007-11-26 11:43:01 +00:00
Richard W.M. Jones
a79891f126
Mon Nov 26 11:39:04 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* configure.in: Minimum version of GnuTLS we support is 1.0.25.
2007-11-26 11:34:57 +00:00
Jim Meyering
3e4ea06702
Fix a typo in a variable name.
...
* qemud/qemud.c: Check crl_file, not ca_file, for revocation list,
in remoteInitializeGnuTLS.
Author: Jim Meyering <meyering@redhat.com>
2007-11-21 23:16:11 +00:00
Daniel Veillard
1ad3d2cdd8
* src/xm_internal.c: fix the parsing of predefined domains on
...
xen prior to 3.1 to take into accound the fact that disk can
be shareable.
Daniel
2007-11-21 16:31:30 +00:00
Richard W.M. Jones
207962bb1a
Wed Nov 21 11:59:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* docs/libvir.html, docs/site.xsl: Fix the link to OCaml
bindings.
2007-11-21 12:02:40 +00:00
Richard W.M. Jones
618db3deb7
Wed Nov 21 11:36:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/bridge.c, src/qemu_driver.c: Incorrect call to
brSetForwardDelay changed to brSetEnableSTP.
2007-11-21 11:46:05 +00:00
Daniel Veillard
a1c2e40cac
* docs/index.html docs/libvir.html: apply english corrections
...
suggested by Bruce Montague
Daniel
2007-11-21 10:38:07 +00:00
Richard W.M. Jones
4ef3a4ea7c
Tue Nov 20 10:49:28 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/virterror.c, src/stats_linux.c, include/libvirt/virterror.h:
Renamed the VIR_FROM_LINUX error as VIR_FROM_STATS_LINUX for
consistency.
2007-11-20 10:58:21 +00:00
Daniel Veillard
aab34d876e
* include/libvirt/virterror.h src/openvz_conf.c src/openvz_driver.c
...
src/stats_linux.c src/virterror.c src/xm_internal.c: patch from
Saori Fukuta cleaning up various problems in the error reporting
layers
Daniel
2007-11-20 10:15:38 +00:00
Daniel Veillard
ef4006b3a5
* tests/sexpr2xmltest.c tests/xml2sexprtest.c: warn before exiting
...
if the path environment variable is missing, add the tests for
<shareable/> from/to w! ode for disk
* tests/sexpr2xmldata/sexpr2xml-disk-block-shareable.sexpr
tests/sexpr2xmldata/sexpr2xml-disk-block-shareable.xml
tests/xml2sexprdata/xml2sexpr-disk-block-shareable.sexpr
tests/xml2sexprdata/xml2sexpr-disk-block-shareable.xml:
the new tests data
Daniel
2007-11-20 10:05:45 +00:00
Daniel P. Berrange
a2492efb60
Re-add quotes around top_srcdir/top_builddir
2007-11-18 11:23:09 +00:00
Daniel P. Berrange
99c0470dd8
Remove reliance on abs_top_{src,build}dir variables from automake 1.10
2007-11-17 13:16:47 +00:00
Daniel P. Berrange
4d82d16dc1
Added missing news.xsl to EXTRA_DIST
2007-11-17 12:09:35 +00:00
Daniel P. Berrange
2efc8ff757
Fixed 32-bit overflow
2007-11-17 11:53:44 +00:00
Daniel P. Berrange
6bb2d376b5
Refactor processing of incoming packets to remove dead code
2007-11-17 11:17:48 +00:00
Richard W.M. Jones
e714bb67ca
Thu Nov 15 17:43:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/stats_linux.c: Fix parsing of short interface names
occurring in the /proc/net/dev file.
* src/qemu_driver.c: Collect interface stats for QEMU & KVM
domains.
2007-11-15 17:45:44 +00:00
Richard W.M. Jones
7a66394fcb
Thu Nov 15 17:40:15 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* docs/hvsupport.html, docs/libvir.html: Document HV support
for virNodeGetFreeMemory and virNodeGetCellsFreeMemory.
* src/libvirt.c: Add DEBUG to virNodeGetFreeMemory and
virNodeGetCellsFreeMemory.
* src/xen_internal.c: virXenError* functions now take an
additional virConnectPtr argument, and set it where possible.
2007-11-15 17:44:06 +00:00
Daniel Veillard
9ae4f3d27e
* docs/libvir.html docs/uri.html: update docs about the libvirt
...
daemon startup when using QEmu/KVM.
Daniel
2007-11-15 17:07:28 +00:00
Jim Meyering
d5117af382
Make "make distcheck" work.
...
* Makefile.am: Expand some "*" wildcards, and (for now) disable
the relatively unimportant, distuninstallcheck target.
Fix a few redirect-directly-to-target bugs.
Add a few $(srcdir)/ prefixes and add an uninstall-local rule.
* docs/Makefile.am: More of the same. Split some long lines.
* python/Makefile.am: Likewise.
* python/tests/Makefile.am: Likewise.
* qemud/Makefile.am: Likewise.
* tests/Makefile.am: Remove the directories already listed in SUBDIRS.
* docs/examples/index.py: Adapt to produce the desired changes in
docs/examples/Makefile.am. Also, sort *.c, so results are reproducible,
and emit a comment telling emacs and vi that the file is read-only.
* docs/examples/Makefile.am: Regenerate.
Author: Jim Meyering <meyering@redhat.com>
2007-11-15 13:04:28 +00:00
Daniel Veillard
a4499a22c5
* src/stats_linux.c: patch from Jim Paris to fix compilation
...
when Xen isn't installed
* src/qemu_conf.h: small cleanup of signedness of bitfields
from Jim Paris
Daniel
2007-11-15 10:56:24 +00:00
Daniel Veillard
ec58960745
* doc/libvir.html doc/format.html: add missing docs for
...
<shareable/> on disk devices
* src/Makefile.am: fix the tst build rule for missing libraries
Daniel
2007-11-14 17:11:19 +00:00
Jim Meyering
a3d909888d
Handle failed strdup and malloc.
...
* src/remote_internal.c: Don't dereference NULL after
failed strdup or malloc in doRemoteOpen.
2007-11-14 16:29:08 +00:00
Richard W.M. Jones
3ba58f158d
Wed Nov 14 11:55:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/stats_linux.c, src/stats_linux.h, src_xen_internal.c:
Abstract out the Linux-specific statistics. Fixed parsing
of 64 bit numbers.
* src/Makefile.am: Updated Makefile for new files.
2007-11-14 11:58:36 +00:00
Richard W.M. Jones
88f28d6980
Wed Nov 14 11:36:00 UTC 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/libvirt.c and all internal driver interfaces: Parse the
URI only once and pass it to virDrvOpen instead of the
unparsed name string.
2007-11-14 11:40:57 +00:00
Jim Meyering
5d25419188
Parse integers more carefully, cont'd.
...
* qemud/qemud.c: Replace uses of strtol with uses of xstrtol_i.
Avoid overflow for very large --timeout=N values.
* src/nodeinfo.c: In linuxNodeInfoMemPopulate and
linuxNodeInfoCPUPopulate, use xstrtol_i rather than strtol.
Unlike in qemud.c, here we allow trailing "isspace", and in
the case of "cpuinfo cpu MHz", also allow a "." terminator,
since we ignore the decimal and any following digits.
* src/internal.h: Define xstrtol_ui, too.
Author: Jim Meyering <meyering@redhat.com>
2007-11-14 10:53:05 +00:00
Jim Meyering
5a6571eba9
Arrange for tests to pass in a non-srcdir build.
...
* tests/Makefile.am: Include the contents of the *data directories
in the make-dist-built tarball by adding each of that *data
directories to EXTRA_DIST.
Also add int-overflow (via $(test_scripts)) to EXTRA_DIST.
* tests/nodeinfotest.c: Prepend "$abs_top_srcdir/tests" to
each input file name.
* tests/qemuxml2argvtest.c: Likewise.
* tests/qemuxml2xmltest.c: Likewise.
* tests/sexpr2xmltest.c: Likewise.
* tests/test_conf.sh: Likewise.
* tests/virshtest.c: Likewise.
* tests/xencapstest.c: Likewise.
* tests/xmconfigtest.c: Likewise.
* tests/xml2sexprtest.c: Likewise.
Author: Jim Meyering <meyering@redhat.com>
2007-11-14 10:35:58 +00:00
Jim Meyering
4f2900d097
remove all trailing white space
2007-11-13 15:42:57 +00:00
Jim Meyering
5f78eccd1c
Make qemud's install-init rule work in a non-srcdir build.
...
* qemud/Makefile.am: In the install-init, remove an unneeded
$(srcdir)/ prefix.
Author: Jim Meyering <meyering@redhat.com>
2007-11-13 14:39:20 +00:00
Jim Meyering
a8b9c6640a
conftest: fix transposed size and count arguments to fwrite.
...
* tests/conftest.c: Include <string.h> and <errno.h>.
Also include strerror in diagnostic.
Author: Jim Meyering <meyering@redhat.com>
2007-11-12 22:16:25 +00:00
Daniel Veillard
a500a479b0
Begin fixing uses of strtol: parse integers more carefully.
...
Patch from Jim Meyering
* src/internal.h: Include <errno.h>.
Define new static inline function, xstrtol_i.
* src/virsh.c: Detect integer overflow in domain ID number
in vshCommandOptDomainBy. Detect overflow and invalid port
number suffix in cmdVNCDisplay.
* src/xend_internal.c: Parse CPU number more carefully in
xenDaemonDomainGetVcpus.
* tests/int-overflow: New script. Test for the above-fixed bug.
* tests/Makefile.am: Add int-overflow to TESTS. Define
TESTS_ENVIRONMENT, to propagate $abs_top_* variables into the
int-overflow script. Adapt the "valgrind" rule not to clobber
new TESTS_ENVIRONMENT.
Daniel
2007-11-12 14:00:32 +00:00
Daniel Veillard
906c1f5055
* src/virsh.c: initialize a couple of variable to avoid warnings
...
when compiling with Fedora.
Daniel
2007-11-08 18:07:02 +00:00
Daniel Veillard
710547590b
* src/virsh.c: patch from Jim Meyering to use gcc's printf attribute.
...
Daniel
2007-11-08 18:00:52 +00:00
Daniel Veillard
b31ed75bff
* src/virsh.c: patch from Jim Meyering to correct vshCommandOptInt
...
indentation
Daniel
2007-11-08 16:14:12 +00:00
Daniel Veillard
50804b725b
* docs/libvir.html docs/site.xsl: small updates with references
...
to CIM and OpenVZ
* po/*: updated translations
Daniel
2007-11-07 13:40:19 +00:00
Richard W.M. Jones
5a628880b0
Tue Nov 6 19:54:00 CET 2007 Jim Meyering <meyering@redhat.com>
...
Avoid risk of format string abuse (also avoids gcc warnings).
* src/util.c (ReportError): Use a literal "%s" format string.
* src/remote_internal.c (server_error): Likewise.
* src/qemu_conf.c (qemudReportError): Likewise.
* acinclude.m4: Add -Wformat -Wformat-security to default
list of warning flags, to warn about errors such as the
above.
2007-11-07 12:29:37 +00:00
Daniel Veillard
f2886d75e6
* src/xs_internals.c: patch from Chris Lalancette, forgot to
...
remove the domainDumpXML entry when changing the driver structure
Daniel
2007-11-06 16:25:32 +00:00
Daniel Veillard
9899932303
* src/xml.c src/xs_internal.c src/xs_internal.h: applied patch
...
from Masayuki Sunou to fix xend errors when adding disk
devices, due to improper device id lookup.
Daniel
2007-11-06 11:49:01 +00:00
Daniel Veillard
31eade077e
* src/virsh.c: patch from Masayuki Sunou to fix parameter
...
validation of virsh schedinfo parameters.
Daniel
2007-11-06 09:41:18 +00:00
Daniel Veillard
028275d6da
* src/xml.c: patch from Beth Kon to fix a problem when the
...
cpuset parameter for numa uses cpu maxcpu-1
Daniel
2007-11-05 10:14:42 +00:00
Daniel Veillard
c33b54df47
* src/xm_internal.c: patches from Masayuki Sunou to fix a problem
...
when an HVM domain is started with a CD-Rom config, this should
fix #328841
Daniel
2007-11-01 13:33:58 +00:00
Daniel Veillard
390cca8125
* proxy/libvirt_proxy.c src/proxy_internal.[ch] src/xen_internal.c
...
src/xen_unified.[ch] src/xend_internal.[ch] src/xml.[ch]: last
patch for the library NUMA support, allow to serialize CPU pinning
to domain configs (but won't work though proxy access), includes
many patches from Saori Fukuta.
Daniel
2007-10-31 09:39:13 +00:00
Daniel P. Berrange
8a0711c758
Avoiding calling remote network driver recursively if inside daemon
2007-10-27 01:23:28 +00:00
Daniel P. Berrange
d6f351690e
Support CDROM media change for QEMU/KVM
2007-10-27 01:21:09 +00:00
Daniel P. Berrange
97185033e5
Refactor shell escaping code
2007-10-27 01:19:51 +00:00
Daniel P. Berrange
eed1b17791
Refactor device parsing code
2007-10-27 01:18:38 +00:00
Daniel P. Berrange
79995893de
Make qemudMonitorCommand append line endings
2007-10-27 01:16:53 +00:00
Daniel Veillard
2718513226
* src/xml.c: fix build when configured without Xen
...
Daniel
2007-10-26 13:41:18 +00:00
Daniel Veillard
211a20aefb
* src/xml.c: applied patch from Jim Meyering fixing parseNumber
...
to detect overflow, and also reindented the module.
Daniel
2007-10-24 14:22:25 +00:00
Daniel Veillard
de327d23e7
* po/id.po: Remove again bogus Project-Id-Version field from merge error
...
Daniel
2007-10-24 08:39:11 +00:00
Daniel Veillard
3d32b50f05
* po/*: updated from translation team
...
Daniel
2007-10-23 15:45:03 +00:00
Daniel Veillard
14c5c70a78
* src/xml.c: fix the build of the proxy broken on previous commit
...
Daniel
2007-10-23 15:31:33 +00:00
Daniel Veillard
08be2facab
* src/xen_internal.c src/xen_unified.c src/xen_unified.h
...
src/xend_internal.c src/xml.c src/xml.h: commited erronously
the NUMA patches sent for review on the list in last commit.
But that should not affect non NUMA users so early push should
not be a problem.
Daniel
2007-10-22 20:36:04 +00:00
Daniel Veillard
cfb192ad1e
* docs/format.html docs/libvir.html: documentation cleaups
...
from Jim Paris
Daniel
2007-10-22 20:28:55 +00:00
Daniel Veillard
a87420ae59
* src/xend_internal.c: update to cpuset parsing code for NUMA
...
Daniel
2007-10-22 13:06:15 +00:00
Daniel Veillard
d620b00ffa
* src/Makefile.am: fix tst build rule
...
* src/buf.c: fix virBufferContentAndFree to make sure the string is
always 0 terminated.
Daniel
2007-10-19 15:09:31 +00:00
Daniel Veillard
24abf6c925
* src/conf.c: fix bug on negative values in virConfParseLong()
...
raised by Tatsuro Enokura
Daniel
2007-10-19 10:01:01 +00:00
Daniel Veillard
69b9fcf297
* src/conf.c: documentation cleanups from Jim Meyering
...
* tests/conftest.c: Use fwrite, not printf, since the
result buffer is not NUL-terminatedi, from Jim Meyering.
* tests/qemuxml2argvtest.c: Initialize vm.migrateFrom[0],
to avoid "read-uninitialized" error from within
qemudBuildCommandLinei, from Jim Meyering.
Daniel
2007-10-19 08:29:13 +00:00
Richard W.M. Jones
171afdf694
Wed Oct 17 11:27:00 BST 2007 Richard W.M. Jones <rjones@redhat.com>
...
* libvirt.spec.in (BuildRequires): Add "qemu" (Jim Meyering).
2007-10-17 10:39:32 +00:00
Richard W.M. Jones
4e04ee2d2f
Wed Oct 17 11:27:00 BST 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/xend_internal.c (sexpr_get): Declare with gcc's printf
attribute. (Jim Meyering)
2007-10-17 10:33:16 +00:00
Daniel P. Berrange
b4fab30b89
Mark XML param for attach/detach APIs const
2007-10-15 21:38:56 +00:00
Daniel P. Berrange
56ba14daa4
Changelog entry for default config files
2007-10-15 21:33:42 +00:00
Richard W.M. Jones
503cca7cee
Mon Oct 15 15:31:00 BST 2007 Richard W.M. Jones <rjones@redhat.com>
...
* src/test.c, include/libvirt/libvirt.h.in: Remove virDomainRestart
from the public API (it was not used), and move it into the test
driver where it is used for purely internal purposes.
2007-10-15 14:32:35 +00:00
Daniel P. Berrange
912c18afa3
Added QEMU driver config file
2007-10-12 16:05:44 +00:00
Daniel P. Berrange
af10d71cc2
Reset migration source after failed VM start
2007-10-10 19:46:17 +00:00
Daniel P. Berrange
175e1711a6
Fixed processing of vncdisplay/vncused params in XM config files
2007-10-10 17:55:38 +00:00
Daniel P. Berrange
bf70fe4883
Fix virtual networking XML -> XM config file conversion & a mem leak
2007-10-10 17:41:06 +00:00
Daniel Veillard
aa826860bc
* src/xend_internal.c: applied patch from Beth Kon to fix
...
NUMA topology for cells without CPUs
Daniel
2007-10-08 15:02:47 +00:00
Daniel P. Berrange
77cf0390e4
Fix NUMA topology error handling (beth kon)
2007-10-05 01:08:17 +00:00
Daniel P. Berrange
d08b12c1a6
Remove bogus Project-Id-Version field
2007-10-03 14:19:35 +00:00
Daniel Veillard
fdc44cf1b7
* configure.in libvirt.spec.in include/libvirt/libvirt.h docs/*:
...
preparing release of 0.3.3
* po/*: updated the strings localizations
Daniel
2007-09-30 21:09:29 +00:00