Daniel P. Berrange
218334d1b2
Fix two compile warnings
2008-10-09 14:50:25 +00:00
Dan Smith
6c504d6a7c
Add LXC scheduling parameters and support in virsh schedinfo
2008-10-08 16:28:48 +00:00
Daniel Veillard
6d670a1fc1
use safewrite() and plug a leak
...
* src/cgroup.c: use safewrite()
* src/qemu_driver.c: missing VIR_FREE pojnted out by Eduardo Habkost
Daniel
2008-10-08 13:44:40 +00:00
Jim Meyering
3ca608b5d6
avoid "make syntax-check" failure
...
* src/cgroup.c (virCgroupSetValueStr): Use safe_write, not write.
2008-10-08 09:31:13 +00:00
Daniel Veillard
f9dbe46b44
* src/qemu_driver.c: another OOM handling cleanup (Guido Günther)
...
daniel
2008-10-07 16:39:32 +00:00
Daniel Veillard
9f4c047935
* src/qemu_driver.c: don't print and extra OOM error on top of getpwuid error
...
(Guido Günther)
Daniel
2008-10-07 16:01:23 +00:00
Cole Robinson
e2a43cdb87
Move DEBUG macros to central location.
2008-10-06 19:53:06 +00:00
Cole Robinson
8206b421d6
Fix segfault if starting qemu VM with an inactive virtual network.
2008-10-06 19:36:46 +00:00
Daniel Veillard
72c40b0622
use C99 initializers for virState
...
* src/lxc_driver.c src/qemu_driver.c src/remote_internal.c
src/storage_driver.c: use C99 initializers for virState (Guido
Gunther)
Daniel
2008-10-06 15:40:37 +00:00
Dan Smith
dd062d4209
Add forgotten cgroup.{c,h} and ChangeLog
2008-10-03 17:58:02 +00:00
Dan Smith
4461568ab4
Add cgroup manipulation and LXC driver
2008-10-03 16:46:01 +00:00
Cole Robinson
a166cdbb6e
Fix starting qemu VM with multiple pty char devices.
2008-10-02 14:10:20 +00:00
Daniel Veillard
3bc324139e
Xen interface order and fix python parallel build
...
* src/xend_internal.c: fix ordering when parsing multiple Xen
interfaces, patch by Jim Fehlig
* python/Makefile.am: fix parallel build
Daniel
2008-10-01 15:31:02 +00:00
Daniel Veillard
321c9a7f51
* configure.in libvirt.spec.in NEWS docs/*: release of libvirt-0.4.6
...
* src/storage_backend_logical.c: re-add the -f flag to vgremove
* po/*: rebuilt
Daniel
2008-09-23 20:48:49 +00:00
Daniel Veillard
ad5723e792
cleanup and removal for pools in logical backend
...
* src/storage_backend_logical.c: enable stop pool in logical backend
improve portability when deleting a pool and also call pvremove
patch by Chris Lalancette
Daniel
2008-09-22 20:22:35 +00:00
Daniel Veillard
4f84e631ed
* src/storage_conf.c: fixes parsing to allow no sources for a pool
...
fix by Dan and Chris Lalancette
Daniel
2008-09-22 19:57:47 +00:00
Daniel Veillard
0958489ca5
* src/remote_internal.c src/storage_driver.c: structure init cleanup
...
by Chris Lalancette
Daniel
2008-09-22 19:53:42 +00:00
Daniel Veillard
7e0ff3aab0
read network config in OpenVZ driver
...
* src/openvz_conf.c: patch from Evgeniy Sokolov to read
network config in OpenVZ driver.
Daniel
2008-09-22 15:21:44 +00:00
Daniel P. Berrange
0aac8c9447
Fix trailing whitespace & unmarked diagnostic warning
2008-09-18 08:54:23 +00:00
Richard W.M. Jones
a0208e6635
src/openvz_driver.c: Fix segfault in OpenVZ driver
...
(Evgeniy Sokolov).
2008-09-17 16:07:03 +00:00
Richard W.M. Jones
4f1e6e7ef2
src/storage_backend_disk.c: Missing include file.
2008-09-17 14:29:47 +00:00
Richard W.M. Jones
dd57b821e4
Remove some deadcode (Nguyen Anh Quynh).
2008-09-17 14:21:27 +00:00
Richard W.M. Jones
3b7c7d888a
Change name of "blocked" state to "idle" (John Levon).
2008-09-17 14:18:15 +00:00
Richard W.M. Jones
a744ddad59
include/libvirt/libvirt.h.in, src/libvirt.c: Fix comments
...
which incorrectly referred to non-existent 'virDomainFlags'
type (Anton Protopopov).
2008-09-17 14:15:20 +00:00
Richard W.M. Jones
7076981f50
src/conf.c: Improved error messages in XM conf module.
2008-09-17 14:11:21 +00:00
Richard W.M. Jones
04e9e1b2a6
configure.in, src/qemu_driver.h, src/qemu_driver.c: KVM
...
can determine max VCPUs at runtime (Guido Günther).
2008-09-17 14:07:49 +00:00
Cole Robinson
bf26cd8ecb
Implement disk volume deleting.
2008-09-16 16:46:08 +00:00
Cole Robinson
a82bd0784b
Fix reading vncdisplay from xend, add several test cases for xen vnc corner case
...
s.
2008-09-09 13:53:58 +00:00
Cole Robinson
bf3e2132a7
Fix a segfault if defining a qemu domain without an emulator.
2008-09-09 13:44:42 +00:00
Daniel Veillard
58686c3dd8
add domain name in network configurations suport and on OpenVZ config bugfix
...
* src/network_conf.c src/network_conf.h src/qemu_driver.c: add
support for a domain name in network configurations, patch by
JJ Reynolds with bugfix raised by Dan
* src/openvz_conf.c: fix to small bug in openvzReadConfigParam
by Evgeniy Sokolov
Daniel
2008-09-08 12:45:29 +00:00
Daniel P. Berrange
3aa7c4639d
Fix potential NULL deref in openvz driver
2008-09-08 12:15:33 +00:00
Daniel Veillard
914e1c61de
finish applying initialization patch for logical storage backend
...
* src/storage_backend_logical.c: finish applying initialization
from Jim Fehlig patch for logical storage backend
Daniel
2008-09-08 08:03:54 +00:00
Daniel P. Berrange
a8936295ce
Fix trailing whitespace mistakes
2008-09-05 15:00:14 +00:00
Daniel P. Berrange
1cc9f9b3d8
Convert openvz driver to generic domain XML APIs
2008-09-05 14:10:58 +00:00
Daniel P. Berrange
542039fab0
Fully support mingw builds
2008-09-05 12:03:45 +00:00
Daniel P. Berrange
126d3ebeea
Fix starting of xen domains without a PVFB console by removing default emulator
2008-09-05 11:52:12 +00:00
Daniel P. Berrange
f193e19536
Fix xen capabilities data creation
2008-09-05 11:35:43 +00:00
Daniel Veillard
e88295804a
* src/storage_backend_fs.c: fix a signed/unsigned issue breaking
...
virStorageBackendProbeFile(), patch by Cole Robinson
Daniel
2008-09-04 13:34:42 +00:00
Daniel Veillard
a8d0600762
* src/qemu_driver.c: fix an error message, patch by Nguyen Anh Quynh
...
Daniel
2008-09-04 13:20:28 +00:00
Daniel Veillard
c37031ebf3
fix a miscalculation of command line size for vgcreate
...
* src/storage_backend_logical.c: fix a miscalculation of command line
size for vgcreate, patch from Jim Fehlig
Daniel
2008-09-04 13:13:32 +00:00
Daniel Veillard
18626bd225
when dumping code don't keep Xen domain live
...
* src/xend_internal.c: patch from John Levon shutting down a live
domain is just more hazardous
Daniel
2008-09-04 09:11:37 +00:00
Daniel Veillard
584ff19452
* src/xend_internal.c src/xs_internal.c: use poweroff instead of halt
...
when shutting down a xen domain, patch by John Levon
Daniel
2008-09-04 09:07:42 +00:00
Daniel Veillard
821dcf0ff7
* src/qemu_driver.c: switch flags to unsigned by James Morris
...
* AUTHORS: add James Morris
Daniel
2008-09-04 08:15:05 +00:00
Dan Smith
df01e14bd7
Add LXC version implementation
...
This patch adds an implementation of the version function to the LXC driver.
The providers use the hypervisor version in a field of one of the instances,
so we need to have something meaningful here. AFAICT, the only real option
we have (considering the limitations of the libvirt version information) is
to use the kernel version.
2008-09-03 17:21:27 +00:00
Cole Robinson
e0b4fcc280
Fix qemu media connect/eject to work with latest syntax. Add support for ejecting floppy devices and scsi cdroms.
2008-09-03 16:05:25 +00:00
Cole Robinson
fe7bb57a8b
Update domain xml after usb device hotplug.
2008-09-03 15:05:31 +00:00
Cole Robinson
f4af06d812
Scrap media eject output to try and determine success/fail.
2008-09-03 14:43:34 +00:00
Cole Robinson
34b1a03402
Fix disk ordering and add target duplication checking when parsing domain xml.
2008-09-03 14:30:24 +00:00
Daniel Veillard
53738f83a5
avoid a segfault on CD eject in KVM/QEmu
...
* src/qemu_driver.c: patch from Cole Robinson to avoid a segfault
on KVM CD eject
Daniel
2008-09-03 12:52:27 +00:00
Daniel Veillard
54a4f8d44d
add output on attach and detach success
...
* src/virsh.c: patch from Cole Robinson to add output on attach
and detach success
daniel
2008-09-03 12:38:28 +00:00
Daniel Veillard
b419ebc7e9
* src/storage_conf.c: add one missing check in virStoragePoolDefParseDoc
...
Daniel
2008-09-03 07:12:37 +00:00
Daniel Veillard
10ccfc92f3
* src/domain_conf.c: fix a parsing error for input devices
...
patch by Cole Robinson
daniel
2008-09-02 15:33:39 +00:00
Daniel Veillard
b8f2610280
check availbility of emulators before reporting them in capabilities
...
* src/qemu_conf.c: patch from Cole Robinson to report in the
capabilities only the ones where the emulators is actually found
* po/libvirt.pot: regenerated
* src/libvirt.c: small typo fix
Daniel
2008-09-02 15:00:09 +00:00
Daniel Veillard
41ce15a586
Adds storage source element for pools
...
* src/storage_backend.h src/storage_backend_logical.c
src/storage_conf.c src/storage_conf.h src/virsh.c:
Applied patches from David Lively to add storage source
elements needed for storage pool
* docs/formatstorage.html docs/formatstorage.html.in: associated
documentation
Daniel
2008-09-02 14:15:42 +00:00
Jim Meyering
81cb09f9fe
qemu_conf.c: use new function, virFileReadLimFD
...
* src/qemu_conf.c (qemudExtractVersionInfo): Use virFileReadLimFD
and VIR_FREE in place of an open-coded loop and a static buffer.
2008-09-02 10:30:40 +00:00
Jim Meyering
d2ac46f2b0
util.c: add a file-descriptor-based wrapper for fread_file_lim
...
* src/util.c (virFileReadLimFP): New function.
(__virFileReadLimFD): New function.
* src/util.h (__virFileReadLimFD): Declare.
(virFileReadLimFD): Define.
(virFileReadAll): Rewrite to use virFileReadLimFP.
2008-09-02 10:29:51 +00:00
Daniel P. Berrange
3348a97bd3
Switch over fork/exec code to use virExec
2008-08-29 07:11:15 +00:00
Daniel P. Berrange
afac1439aa
Allow for private root filessytem in containers using pivot_root
2008-08-28 22:40:50 +00:00
Daniel P. Berrange
8f762e34f3
Fix lookup of xen VM after define (Cole Robinson)
2008-08-28 11:59:07 +00:00
Daniel P. Berrange
39c9354c5c
Add storage pool source discovery support (patch from David Lively)
2008-08-27 20:05:58 +00:00
Daniel P. Berrange
da1963381b
Fix QEMU domain creation by allowing virExec to preserve certain FDs
2008-08-27 11:42:52 +00:00
Daniel P. Berrange
2875ed81bd
Fix EOF handling when reading openvz domain list
2008-08-27 11:21:01 +00:00
Daniel P. Berrange
d81b038cc2
Remove use of virState apis from openvz driver
2008-08-27 11:19:45 +00:00
Dan Smith
5fb17bcc1e
[LXC] Cleanup devices on container shutdown
2008-08-22 15:35:37 +00:00
Daniel P. Berrange
9472d3e2f3
Improve error reporting from remote driver
2008-08-21 10:14:54 +00:00
Daniel P. Berrange
11a2e2972a
Propagate virConnectOpen errors to global error object
2008-08-21 10:12:32 +00:00
Daniel P. Berrange
c2bbf99e48
Remove unused lx_controller.h file
2008-08-21 10:07:21 +00:00
Daniel P. Berrange
5f134f0197
Ignore libvirt_lxc binary
2008-08-21 09:14:39 +00:00
Daniel P. Berrange
177c74b1fa
Create lxc_controller standalone binary
2008-08-20 20:55:32 +00:00
Daniel P. Berrange
bb16f4a25d
Do conditional driver config in Makefile.am, not source files
2008-08-20 20:48:35 +00:00
Daniel P. Berrange
6334cd16df
Remove configFile/autostartLink vars from virDomainObj struct
2008-08-20 19:42:36 +00:00
Daniel Veillard
b1e5880740
add cpu management functionality to OpenVZ driver
...
* src/openvz_conf.c src/openvz_driver.c: patch from Evgeniy Sokolov
to limit the number of CPUs used by OpenVZ domains.
Daniel
2008-08-20 13:44:03 +00:00
Daniel Veillard
ce9439358c
Fix creating and cleaning up logical volumes if a target path is specified
...
* src/storage_backend_logical.c: Patch from Cole Robinson, fix
creating and cleaning up logical volumes if a target path is
specified.
Daniel
2008-08-20 13:33:01 +00:00
Daniel Veillard
ace1b6bf98
Fix size reporting for disks without partitions.
...
* src/parthelper.c: Patch from Cole Robinson, fix size reporting for
disks without partitions.
Daniel
2008-08-20 13:20:01 +00:00
Daniel Veillard
b73d495754
* src/network_conf.c src/network_conf.h src/qemu_driver.c: allow to
...
add static host definition for dnsmasq
Daniel
2008-08-20 12:50:29 +00:00
Daniel P. Berrange
1b4bb7d4ab
Allow non-blocking/daemon mode to be specified via virExec flags
2008-08-20 09:24:14 +00:00
Daniel P. Berrange
6bc99a7775
Allow a pre-opened FD to be be pass to virExec for stdout/err
2008-08-20 09:08:17 +00:00
Daniel P. Berrange
60ed1d2a7a
Avoid signal race in virExec
2008-08-20 08:53:49 +00:00
Daniel P. Berrange
f2172946e5
Improve virExec error reporting
2008-08-20 08:30:04 +00:00
Daniel P. Berrange
5cd1d3c53c
Remove duplicated call to virInitialize
2008-08-18 09:24:46 +00:00
Mark McLoughlin
7c3ccd6f14
Fri Aug 15 11:00:38 IST 2008 Mark McLoughlin <markmc@redhat.com>
...
* src/qemu_conf.c: fix serial/telnet to use "server" option
rather than "listen"
* tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.args:
fix the test case too
2008-08-15 10:02:33 +00:00
Atsushi SAKAI
6fd4c30285
fix typos src/virsh.c from John Levon,
...
and 3 more files(src/domain_conf.c src/openvz_driver.c src/qemu_driver.c)
2008-08-15 01:41:49 +00:00
Daniel P. Berrange
2e7a373646
Switch LXC driver over to generic domain XML processing APIs
2008-08-13 12:50:55 +00:00
Daniel P. Berrange
763dacda97
Make LXC I/O controller process a parent of the container process
2008-08-13 10:52:15 +00:00
Daniel P. Berrange
518c2144e5
Re-arrange code between LXC driver files
2008-08-13 10:25:34 +00:00
Daniel P. Berrange
e82c913680
Refactor LXC driver to pass tty/socket state directly
2008-08-13 10:14:47 +00:00
Daniel Veillard
415b92101f
* docs/storage.html[.in] src/storage_backend_disk.c: revert previous
...
msdos patch and apply new one from Cole Robinson
daniel
2008-08-13 09:45:10 +00:00
Jim Meyering
4ee755d641
rewrite virFileLinkPointsTo
...
* src/util.c (SAME_INODE): Define.
(virFileLinkPointsTo): Rewrite to be more portable and more efficient.
2008-08-12 17:38:08 +00:00
Daniel Veillard
8fdb2cffa5
make sure parted doesn't ask for confirmation
...
* src/storage_backend_disk.c: make sure parted doesn't ask
confirmation, patch by Cole Robinson
Daniel
2008-08-12 11:29:49 +00:00
Daniel Veillard
ef7fec1168
rename the disk type from 'dos' to 'msdos'
...
* docs/storage.html[.in] src/storage_backend_disk.c: patch from
Cole Robinson to rename the disk type from 'dos' to 'msdos'
Daniel
2008-08-12 11:26:00 +00:00
Atsushi SAKAI
413c5dbf07
add _fd to stdin, stderr stdout in struct virDomainObj for compilation on MinGW
2008-08-12 08:38:22 +00:00
Atsushi SAKAI
43c7f972aa
fix compilation for MinGW
2008-08-12 08:25:48 +00:00
Daniel P. Berrange
b3728d7d72
Fix const-correctness of virRUn and virExec
2008-08-08 15:43:38 +00:00
Daniel Veillard
5ba372306a
llow to add a disk as an USB device (QEmu/KVM)
...
* src/domain_conf.c src/domain_conf.h src/qemu_conf.c
src/qemu_driver.c: patch from Guido Günther allowing to add
disk as USB devices
* docs/libvirt.rng: extend the schemas for the new value
* tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args
tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml
tests/qemuxml2argvtest.c tests/qemuxml2xmltest.c: add a specific
test to the regression suite
Daniel
2008-08-08 15:03:00 +00:00
Daniel Veillard
d1710d35ea
Extend parser and add support for USB devices in QEmu/KVM
...
* src/domain_conf.c src/domain_conf.h src/qemu_conf.c
src/qemu_driver.c: Patch from Guido Günther allowing to pass
usb devices to qemu/kvm
* docs/libvirt.rng: add the new functionality to the grammar
* tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.args
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-product.args
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-product.xml
tests/qemuxml2argvtest.c tests/qemuxml2xmltest.c: adding examples
to the regression tests
* libvirt.spec.in: fix the licence tag
Daniel
2008-08-08 14:27:05 +00:00
Dan Smith
e94c12451b
Fix device name clash in src/veth.c
2008-08-07 13:34:17 +00:00
Daniel Veillard
2194f1c983
* src/bridge.c: fix a build failure on RHEL4
...
Daniel
2008-08-07 10:22:52 +00:00
Jim Meyering
3fb53d1181
fix failing "make syntax-check"
...
* src/stats_linux.c: Don't include <c-ctype.h> no longer used.
2008-08-06 13:07:55 +00:00
Jim Meyering
783158511a
work around MinGW build failure due to its lack of inet_aton
...
Use inet_pton instead; pull in gnulib's module by the same name.
* src/network_conf.c (virNetworkDefParseXML): Use inet_pton,
rather than inet_aton.
* bootstrap (modules): Add inet_pton.
* gnulib/lib/inet_pton.c: New file, from gnulib.
2008-08-06 12:08:49 +00:00
Chris Lalancette
b8fb68be37
DanB pointed out that my sexpr xend_internal patch from yesterday broke one of
...
the regression tests. The problem is that the xenDaemonFormatSxpr{Disk,Net}
functions are shared between domain creation time and attaching disk time.
Unfortunately, though, Xend expects something different during these two times.
During domain creation time, it wants the "(device" in front of the sexpr,
while during attach time it does not. To remedy this situation, I added a flag
to these two functions to differentiate between these two modes. With this
patch in place, all of the regression tests pass.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-08-06 11:26:47 +00:00
Chris Lalancette
6335c2a0cc
With the recent refactoring of the domain code, plus the changes with the Xend
...
code, a couple of bugs were introduced into the attach-disk and attach-interface
functionality. This patch fixes 3 bugs:
1) In xenDaemonAttachDevice(), there is a switch statement to determine which
of the xenDaemonFormatSxpr{Disk,Net} functions to call. Unfortunately, the case
statements are all missing the corresponding "break", so we always fall-through
to the default error case. This patch just adds the appropriate break statements.
2) (minor) In xenDaemonDomainDefineXML (that's a mouthful!), there is a stray
"fprintf". This is now converted to a proper virXendError().
3) xenDaemonFormatSxpr{Disk,Net} were adding an extra (device to the front of
the sexpr expressions that xend did not expect (this is Xend on RHEL 5.2).
Because of this, the attaches would fail. The patch fixes this by removing the
(device from the front, which makes attach-disk and attach-interface work again.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-08-05 16:45:07 +00:00
Chris Lalancette
8c30002862
Recently upstream Xen added support for having xvd devices > 16. For the most
...
part, this doesn't really concern libvirt, since for things like attach and
detach we just pass it through and let xend worry about whether it is supported
or not. The one place this breaks down is in the stats collecting code, where
we need to figure out the device number so we can go digging in /sys for the
statistics.
To remedy this, I've re-written xenLinuxDomainDeviceID() to use regular
expressions to figure out the device number from the name. The major advantage
is that now xenLinuxDomainDeviceID() looks fairly identical to
tools/python/xen/util/blkif.py (in the Xen sources), so that adding additional
devices in the future should be much easier. It also reduces the size of the
code, and, in my opinion, the code complexity.
With this patch in place, I was able to get block statistics both on older style
devices (/dev/xvda) and on the new, expanded devices (/dev/xvdaa).
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-08-05 16:38:49 +00:00
Daniel Veillard
063679580d
saving UUID of new OpenVZ domains
...
* src/openvz_conf.c src/openvz_conf.h src/openvz_driver.c: patch
from Evgeniy Sokolov saving the UUID when creating or defining
a domain.
Daniel
2008-08-05 10:53:05 +00:00
Jim Meyering
6d72e14178
make distclean: remove generated source files
...
* src/Makefile.am (DISTCLEANFILES): Define to $(BUILT_SOURCES)
so "make distcheck" passes.
2008-08-05 08:43:03 +00:00
Atsushi SAKAI
adc1d93f97
fix syntax-check error (replace TAB to space)
2008-08-04 06:33:25 +00:00
Jim Meyering
deefaf1891
src/xend_internal.c (xenDaemonParseSxpr): Add const to "root" parameter.
...
This piece was mistakenly omitted from the previous patch.
2008-08-01 15:32:28 +00:00
Jim Meyering
07f8a8b34a
xend_internal.c, sexpr.c: const-correctness fixes
2008-08-01 14:43:12 +00:00
Richard W.M. Jones
969fa847c1
'virsh edit' and related commands
...
* src/virsh.c: Implement 'virsh edit', 'virsh net-edit' and
'virsh pool-edit' commands. These edit the XML for domains,
networks and storage pools respectively, and are the
equivalent of doing 'virsh dumpxml; vi foo.xml; virsh define'
* src/Makefile.am, src/.cvsignore: Auto-generate the net-edit
and pool-edit commands.
* docs/virsh.pod: Updated the documentation.
2008-08-01 14:30:41 +00:00
Daniel P. Berrange
0dee7feb74
Fix initial VM state
2008-08-01 14:19:06 +00:00
Jim Meyering
66f9bb5b95
virsh.c: more const-correctness fixes
2008-08-01 13:51:18 +00:00
Daniel P. Berrange
a7600746fb
Support for container related domain XML extensions
2008-08-01 13:31:37 +00:00
Daniel P. Berrange
ffc839fb20
Always set forward-delay on bridge, even if 0
2008-08-01 12:56:52 +00:00
Richard W.M. Jones
3f3345aa85
Const-correctness fixes in virsh.c
...
* src/virsh.c: Const-correctness.
2008-08-01 12:19:56 +00:00
Daniel Veillard
c810c6cc23
* src/qemu_driver.c: patch from Chris Lalancette adding missing
...
carriage returns to logs
Daniel
2008-08-01 11:24:04 +00:00
Richard W.M. Jones
cf11bb2249
Improve error messages when XML is not well-formed.
...
* src/domain_conf.c, src/network_conf.c, src/storage_conf.c:
Improve error messages from commands such as 'virsh define'
when the XML is not well-formed by passing libxml2 errors
back out through virterror.
2008-08-01 09:39:44 +00:00
Daniel Veillard
eba65e1c6d
* docs/formatdomain.html docs/formatdomain.html.in docs/libvirt-api.xml
...
docs/libvirt-refs.xml docs/html/libvirt-libvirt.html src/libvirt.c:
fixed somedocs and API entry point descriptions as suggested by
Charles Duffy and regenerated the API descriptions.
Daniel
2008-08-01 06:42:45 +00:00
Daniel Veillard
7711e6858c
* src/qemu_driver.c: apply patch from Charles Duffy fixing erro
...
messages when trying to crate a domain already defined.
Daniel
2008-08-01 06:23:31 +00:00
Daniel P. Berrange
42e559a324
Fix autoport when domain is inactive
2008-07-31 14:39:30 +00:00
Chris Lalancette
6f17fb2851
From Charles Duffy:
...
Per subject; if autoport is in use for a host, the current
virDomainGraphicsDefFormat code always emits "port=-1", even if a port
is assigned to the host; this leaves no way for a client to find the VNC
port assigned to the host in question.
This patches fixes it by putting the vncport in place if there is one, and
only putting "-1" if we fail that test.
2008-07-31 12:30:34 +00:00
Daniel Veillard
55e1221686
* src/qemu_driver.c: patch from Guido Günther, interface stats should
...
not crash on interfaces without an ifname.
Daniel
2008-07-30 09:20:19 +00:00
Daniel Veillard
c05cf3f3e1
* src/storage_backend_logical.c: patch from David Lively fixing
...
small differences of behaviour for 'lvs' and 'vgs' on SLES
Daniel
2008-07-30 08:52:44 +00:00
Chris Lalancette
654c5714bf
The new generic domain re-factor introduced a small regression into the drive
...
handling code. In particular, if you had a section of XML like:
<disk type='file' device='cdrom'>
<target dev='hdc' bus='ide'/>
<readonly/>
</disk>
This used to work with older libvirt, but now fails. This is because we are
actually passing the literal string (null) to the qemu command-line, which qemu
barfs on. This patch fixes it up by making it blank, which allows qemu to
continue on it's merry way.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-07-29 12:09:21 +00:00
Daniel Veillard
4779e0bcb2
build OpenVZ and LXC support by default, fix OpenVZ build
...
* src/openvz_conf.c: fix compilation with new XPath interface
signatures
* configure.in: build OpenVZ and LXC support by default
Daniel
2008-07-29 08:42:56 +00:00
Daniel Veillard
996933bbcd
OpenVZ xml refactoring
...
* src/domain_conf.[ch] src/openvz_conf.[ch] src/openvz_driver.c:
patch from Evgeniy Sokolov doing the OpenVZ xml refactoring,
still needs to be ported to the new XML parsing code but
implements the new format.
Daniel
2008-07-28 14:06:54 +00:00
Daniel Veillard
387e06421f
* src/qemu_driver.c: patch from Guido Günther to make sure create
...
doesn't override an existing domain definition or UUID
Daniel
2008-07-28 12:52:37 +00:00
Daniel P. Berrange
c5ecc66658
Fix misc typos in domain XML handling
2008-07-25 16:25:11 +00:00
Daniel P. Berrange
e8a84817d4
Remove unused c-ctype.h include
2008-07-25 16:19:00 +00:00
Daniel P. Berrange
9351cb0ab0
Fix reporting of errors against virConnect object in XML apis
2008-07-25 14:27:25 +00:00
Daniel P. Berrange
cb29913fb1
Switch XM config file driver to use new domain APIs for XML to config conversion
2008-07-25 14:10:49 +00:00
Daniel P. Berrange
547bd71a4a
Switch XM config file driver to use new domain APIs for XML generation
2008-07-25 13:50:08 +00:00
Daniel P. Berrange
225fb3e93c
Prepare xm_internal driver for new domain XML apis
2008-07-25 13:39:02 +00:00
Daniel P. Berrange
73d021c5c1
Fix test driver inactive domains and domain ID allocation
2008-07-25 13:27:12 +00:00
Daniel P. Berrange
8c6f5a546b
Convert XenD XML->SEXPR conversion to new domain XML APIs
2008-07-25 13:17:27 +00:00
Daniel P. Berrange
31ac8125b8
Convert XenD SEXPR->XML convesion to new domain XML APIs
2008-07-25 10:49:33 +00:00
Daniel P. Berrange
d9383fe158
Remove unused/no-op Xen driver code
2008-07-25 09:51:23 +00:00
Daniel P. Berrange
3de646a51d
Misc bug fixes
2008-07-25 09:31:24 +00:00
Daniel Veillard
c1e6cc1969
* src/qemu_driver.c: some uuid to string conversion were missing
...
patch from Guido Günther
Daniel
2008-07-25 09:01:25 +00:00
Daniel Veillard
6fae611381
wrong open() failure detection
...
* src/qemu_driver.c: Guido Trotter pointed out a wrong open() failure
detection
Daniel
2008-07-25 08:42:05 +00:00
Daniel Veillard
27efc8bd0d
Check for already running QEmu domain on create
...
* src/qemu_driver.c: another patch from Guido Günther checking
for an already running domain on create
Daniel
2008-07-24 07:29:50 +00:00
Daniel Veillard
d3bb1e4367
* src/qemu_driver.c: patch from Guido Günther checking for
...
unsupported migrate command
Daniel
2008-07-24 07:09:45 +00:00
Jim Meyering
2eb8ab2057
better diagnostic when failing to undefine a running domain via ID
...
* src/virsh.c (cmdUndefine): Tell user to shutdown and then use name or UUID.
* tests/undefine: New test. Exercise virsh's undefine command.
* tests/Makefile.am (test_scripts): Add undefine.
2008-07-22 16:12:01 +00:00
Daniel Veillard
fa6177aafe
fix a warning when no proxy is configured in, Daniel
2008-07-22 09:52:31 +00:00
Daniel Veillard
7e73b8b61a
cleaning up integer string parsing
...
* src/openvz_conf.c src/openvz_driver.c: patch from Evgeniy Sokolov
cleaning up integer string parsing.
Daniel
2008-07-21 13:34:19 +00:00
Daniel Veillard
f92e0898d3
Fix compile , Daniel
2008-07-21 12:06:16 +00:00
Daniel Veillard
403a5163c9
* src/xen_unified.c: fix a leak in xenUnifiedOpen
...
Daniel
2008-07-21 09:48:01 +00:00
Daniel Veillard
7b4f67acea
OpenVZ domain cpu time
...
* src/openvz_driver.c: patch from Evgeniy Sokolov to get OpenVZ
domain cpu time consumption.
Daniel
2008-07-21 08:08:25 +00:00
Daniel Veillard
cb3e65e922
* src/openvz_driver.c: patch from Evgeniy Sokolov avoiding domain
...
lookups based on ID as this doesn't work for a stopped domain.
Daniel
2008-07-21 07:31:14 +00:00
Jim Meyering
3ff5480d7b
remove unnecessary "V = NULL;" stmts after VIR_FREE(V)
...
* src/domain_conf.c (virDomainChrDefParseXML)
(virDomainNetDefParseXML): Likewise.
* src/iptables.c (iptRuleFree): Likewise.
* src/storage_backend.c (virStorageBackendRunProgRegex): Likewise.
* src/test.c (testOpenFromFile): Likewise.
* src/xmlrpc.c (xmlRpcCallRaw): Likewise.
2008-07-19 07:42:34 +00:00
Jim Meyering
cff27e9f40
enable format-safety checks for virDomainReportError
...
* src/domain_conf.c (virDomainReportError): Declare using
ATTRIBUTE_FORMAT(printf, 3, 4).
* Makefile.maint (msg_gen_function): Add virDomainReportError.
2008-07-18 11:02:18 +00:00
Daniel Veillard
dfccabe1e7
fix pool-create for netfs format 'auto'
...
* src/storage_backend_fs.c: patch from Cole Robinson fixing
pool-create for netfs format 'auto'
Daniel
2008-07-17 15:20:28 +00:00
Daniel Veillard
16b8942966
undefine command can't take an ID
...
* src/virsh.c: patch from Evgeniy Sokolov for the undefine command
which can't take an id
Daniel
2008-07-17 11:49:15 +00:00
Daniel Veillard
edbbb3aa12
ID domain lookup fixup
...
* src/libvirt.c src/openvz_driver.c: fix the description of the ID
domain lookup and fix the OpenVZ routine
Daniel
2008-07-16 20:42:38 +00:00
Daniel Veillard
07601749e8
lookup by ID function and error report fix for OpenVZ
...
* src/openvz_driver.c: fix the lookup by ID function and error
reporting in OpenVZ, fix by Evgeniy Sokolov
Daniel
2008-07-16 15:27:00 +00:00
Daniel Veillard
5553b0cd16
cleaning up the exec calls to OpenVZ binaries
...
* src/openvz_driver.c: another cleanup patch from Evgeniy Sokolov
cleaning up the exec calls to OpenVZ binaries
Daniel
2008-07-16 14:45:55 +00:00
Daniel P. Berrange
276bffd907
Remove unneccessary include
2008-07-12 13:53:50 +00:00
Daniel P. Berrange
6385fe3ede
Switch QEMU driver over to generic domain APIs
2008-07-11 19:34:11 +00:00
Daniel P. Berrange
774354e3ef
Set initial domain state to SHUTOFF
2008-07-11 19:31:26 +00:00
Daniel P. Berrange
a1b49bcdea
Use full path when loading XML files
2008-07-11 17:59:27 +00:00
Daniel P. Berrange
381fa1fc46
Switch QEMU driver over to generic network APIs
2008-07-11 17:33:45 +00:00
Daniel P. Berrange
d78c0a6800
Convert test driver to new domain XML apis
2008-07-11 16:41:27 +00:00
Daniel P. Berrange
c422fd1240
Convert test driver to new network XML apis
2008-07-11 16:39:08 +00:00
Daniel P. Berrange
d1304583d6
Added generic domain XML APIs
2008-07-11 16:23:36 +00:00
Daniel Veillard
d678a6e88c
fix OpenVZ probe function
...
* src/openvz_driver.c: fix from Evgeniy Sokolov to the probe function
Daniel
2008-07-11 11:09:44 +00:00
Daniel P. Berrange
747fad6654
Generic APIs for network XML configuration
2008-07-11 10:48:34 +00:00
Daniel P. Berrange
69582431a0
Fix booting QEMU off CDROM devices with -drive arg
2008-07-11 09:56:23 +00:00
Daniel P. Berrange
1d86fca433
Fix parsing of QEMU stdout looking for serial device PTY with Xenner
2008-07-11 09:48:51 +00:00
Daniel Veillard
915b86d29b
cleanup OpenVZ config file accesses
...
* src/openvz_conf.c: cleanup OpenVZ config file accesses, patch
from Evgeniy Sokolov
Daniel
2008-07-11 08:56:16 +00:00
Daniel Veillard
fc2076033b
bug in do_open()
...
* src/libvirt.c: Evgeniy Sokolov found a driver open bug
in do_open()
Daniel
2008-07-10 15:29:39 +00:00
Daniel Veillard
5215d88be2
cleanup OpenVZ error function
...
* src/openvz_conf.c src/openvz_conf.h src/openvz_driver.c
Makefile.maint: patch from Evgeniy Sokolov cleaning up the
error function used and format check based on Jim's fedback.
Daniel
2008-07-10 12:21:09 +00:00
Daniel Veillard
47010f352c
* src/openvz_conf.c src/openvz_conf.h src/openvz_driver.c: new
...
patch from Evgeniy Sokolov adding OpenVZ autostart get and set support
Daniel
2008-07-10 07:52:14 +00:00
Jim Meyering
a626719f0c
remove trailing blanks
2008-07-09 16:59:28 +00:00
Daniel Veillard
db9bcc9bd4
diagnostic fixes on OpenVZ failures
...
* src/openvz_conf.c src/openvz_conf.h src/openvz_driver.c: applied
patch from Evgeniy Sokolov fixing error diagnostic when exec'ing
OpenVZ commands.
Daniel
2008-07-09 11:55:27 +00:00
Daniel P. Berrange
b897973f2e
Preserve context node when doing XPath queries to allow relative XPath expressions
2008-07-09 08:35:09 +00:00
Jim Meyering
fb2eca4cfd
give a more useful diagnostic for tap-add failure w/ENOTSUP
...
* src/qemu_conf.c (qemudNetworkIfaceConnect):
Suggestion from Daniel P. Berrange.
2008-07-09 05:24:08 +00:00
Daniel P. Berrange
a211db1b8f
Fix typo in domain state constant
2008-07-08 17:49:26 +00:00
Daniel P. Berrange
95675d4d76
Fix openvz build on x86_64
2008-07-07 11:48:40 +00:00
Daniel P. Berrange
bf79e90f3a
Fix memory leak in OOM cleanup
2008-07-07 09:52:26 +00:00
Atsushi SAKAI
fa97486070
Compilation fix for MinGW(w/ LXC)
2008-06-30 05:11:13 +00:00
Dan Smith
0d2c36fda9
[LXC] Remove unused variable and fix uninitialized variable
...
Also remove a stale comment in the area. This makes libvirt compile when
passed --with-lxc and --enable-compiler-warnings=error
2008-06-27 15:05:31 +00:00
Dan Smith
0240fe9d58
[LXC] Add setup/cleanup of container network interfaces
2008-06-26 16:09:48 +00:00
Dan Smith
97e1fc3734
[LXC] Add XML parsing of container network interfaces.
2008-06-26 16:08:59 +00:00
Dan Smith
e59eb52fad
[LXC] Add functions to manage veth device pairs
...
This gives us the ability to create a veth pair so that we can move one
into the network namespace of an LXC container.
2008-06-26 16:07:48 +00:00
Dan Smith
99ded85f45
[LXC] Detect support for NETNS in lxc driver initialization
...
Allow check for containers support to be done without CLONE_NEWNET, and then
determine support on the fly by checking for iproute2 support and a
successful clone(CLONE_NEWNET). This lets us set a flag for later, as well
as not completely disable LXC support on a system without NETNS support.
2008-06-26 16:05:02 +00:00
Atsushi SAKAI
f3c3550771
Fix make syntax-check
2008-06-26 10:56:19 +00:00
Atsushi SAKAI
fbb5d771a0
Compilation fixes for MinGW
2008-06-26 09:37:51 +00:00
Daniel Veillard
93db3c61c0
* configure.in NEWS libvirt.spec* doc/* po/*: making libvirt-0.4.4
...
release
* src/xm_internal.c: fix xm driver serialization escapes
* tests/xmconfigtest.c tests/xmconfigdata/test-escape-paths.cfg
tests/xmconfigdata/test-escape-paths.xml: add test for previous
problem
Daniel
2008-06-25 08:59:37 +00:00
Daniel P. Berrange
47605e1dfa
Added helpers for dealing with enumerations
2008-06-24 15:00:15 +00:00
Daniel P. Berrange
313f1a7c0d
Fix const-ness of virStorageBackendRunProgRegex()
2008-06-24 14:30:25 +00:00
Daniel Veillard
1ec7cccbd3
fix a couple of List functions for max = 0 issues
...
* src/xen_internal.c src/xend_internal.c: fix a couple of issues
for List functions where max given is 0
Daniel
2008-06-19 14:39:49 +00:00
Jim Meyering
e09fab39a8
virsh fails to read files larger than BUFSIZ bytes
...
* src/util.c (fread_file_lim): Use VIR_REALLOC_N, not VIR_ALLOC_N.
Bug introduced in 895d0fdf5b
.
* tests/Makefile.am (test_scripts): Add read-bufsiz.
* tests/read-bufsiz: New test for the above.
2008-06-19 14:30:52 +00:00
Chris Lalancette
0aa6eedddd
For 0.4.3, danpb's new memory management scheme went into libvirt. This is
...
fine, except that is subtly alters the semantics of malloc(), calloc(), and
realloc(). In particular, if you say:
foo = malloc(0);
glibc will happily return a non-NULL pointer to you. However, with the new
memory management stuff, if you say:
foo = VIR_ALLOC(0);
you will actually get a NULL pointer back. Personally, I think this is a
dangerous deviation from malloc() semantics that everyone is used to, and is
indeed causing problems with the remote driver. The short of it is that the
remote driver allocates memory on behalf of the remote side using VIR_ALLOC_N,
and this call is returning NULL so that the NULL checks elsewhere in the code
fire and return failure.
The attached patch fixes this situation by removing the 0 checks from the memory
allocation paths, and just lets them fall through to the normal malloc(),
calloc(), or realloc() routines, restoring old semantics.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-06-19 11:58:49 +00:00
Chris Lalancette
a24b1d9eda
When doing the conversion to danpb's new memory API, a small bug was
...
introduced into the qemudNetworkIfaceConnect() function. In particular, there
is a call:
if (VIR_ALLOC_N(vm->tapfds, vm->ntapfds+2) < 0)
goto no_memory;
However, the tapfds structure is used to track *all* of the tap fds, and is
called once for each network that is being attached to the domain. VIR_ALLOC_N
maps to calloc(). So the first network would work just fine, but if you had
more than one network, subsequent calls to this function would blow away the
stored fd's that were already there and fill them all in with zeros. This
causes multiple problems, from the qemu domains not starting properly to
improper cleanup on shutdown. The attached patch just changes the VIR_ALLOC_N()
to a VIR_REALLOC_N(), and everything is happy again.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-06-19 10:38:36 +00:00
Jim Meyering
21ea9cb7af
remove trailing white space
2008-06-17 15:55:03 +00:00
Chris Lalancette
0de4f35ebc
This rather large patch rewrites the virStorageBackendISCSIFindLUNs() function
...
to only rely on sysfs for finding LUNs, given a session number. Along the way,
it also fixes the bug where we wouldn't find LUNs for older kernels (with the
block:sda format), and also fixes a race condition where we could try
to find the LUN before udev has finished connecting it.
This patch fixes a few different bugs:
1) We weren't finding LUNs on pre 2.6.24 kernels
2) libvirtd sysfs scanning was racing with udev, so we didn't always see LUNs
3) We weren't showing the 0'th LUN, although that can be a valid LUN
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-06-17 12:49:37 +00:00
Chris Lalancette
94e3ba0e87
A small bugfix; we only need to call the iscsiadm sendtarget command when we are
...
first logging in; we don't need to do it for logout. Move the sendtarget
command into the Login() function.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-06-17 12:47:10 +00:00
Chris Lalancette
88dd6f6cc2
Older versions of iscsiadm didn't support the "-P 0" flag to the "iscsiadm
...
--mode session" command. However, just running "iscsiadm --mode session" seems
to work on all version of iscsiadm commands back to FC-6, so just use that.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-06-17 12:46:38 +00:00
Chris Lalancette
a9e30eec59
In src/util.c, virLog is just a wrapper around fprintf(stderr). Make sure to
...
put line breaks at the end of lines that use virLog() (noticed during testing).
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-06-17 12:45:59 +00:00
Chris Lalancette
a75a612ad5
This patch changes things around so that virStorageBackendRunProgRegex() does
...
*not* virStorageReportError() if the fork()/exec() process it spawned returned a
!= 0 exit code. Rather, it returns the exitcode in this case, and it is up to
the higher level to determine whether this is a fatal error or not. The use
case for this change is in the iSCSI stuff; older versions of iscsiadm tools
would return a failure when getting the session number, despite the command
succeeding.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
2008-06-17 12:45:24 +00:00
Daniel Veillard
5ba9e91e52
* src/qemu_conf.c: patch from Kaitlin Rupert, dynamic devices
...
for network should be defined in an 'interface' node not 'net'
Daniel
2008-06-13 07:56:59 +00:00
Daniel P. Berrange
841dd882a4
Fix misc compile warnings
2008-06-12 13:48:29 +00:00
Daniel P. Berrange
db162cb2b8
Fix saving of iptables rules
2008-06-12 13:47:38 +00:00
Daniel P. Berrange
74fb2b9704
Deal with inactive virtual network in domain creation
2008-06-12 10:19:24 +00:00
Daniel Veillard
5d14e4fcce
* src/qemu_driver.c: patch from Kaitlin Rupert, changing vcpu or
...
memory of an active domain is a NO_SUPPORT not INTERNAL_ERROR
Daniel
2008-06-12 08:55:13 +00:00
Daniel P. Berrange
357bf10553
Fix RPM build
2008-06-11 11:26:36 +00:00
Richard W.M. Jones
406d896363
Pass syntax check for XM block devices over to XenD
...
* src/xm_internal.c: Pass responsibility for checking syntax
of XM block devices over the XenD (see also Xen cset 17617).
(Hiroyuki Kaguchi).
2008-06-10 14:39:58 +00:00
Richard W.M. Jones
6bcf25017b
virDomainMemoryPeek API
...
* include/libvirt/libvirt.h.in, src/libvirt.c, src/driver.h,
src/libvirt_sym.version: New virDomainMemoryPeek API.
* qemud/remote.c, qemud/remote_protocol.x, src/remote_internal.c:
Support for remote.
* src/qemu_driver.c: QEMU driver implementation of API.
* src/test.c: Test driver (null) implementation of API.
* docs/hvsupport.html.in: Document API.
* libvirt.spec.in: New path /var/cache/libvirt for temporary
storage of memory images.
* qemud/libvirtd.init.in: Remove any old temp files in
/var/cache/libvirt on restarts.
* src/Makefile.am: make install creates /var/cache/libvirt.
* configure.in: Detect mkdir -p.
2008-06-10 10:43:28 +00:00
David L. Leskovec
0d0c96722c
Mon Jun 9 15:42:34 PST 2008 David L. Leskovec <dlesko@linux.vnet.ibm.com>
...
* src/lxc_driver.c: Make console element is output only. Always open new
PTY when starting a container.
Fix string overrun when storing console name in VM def struct
2008-06-09 22:51:32 +00:00
Richard W.M. Jones
787e44a1d0
Better error messages in xend driver.
...
* src/xend_internal.c: Change virXendError function to take
varargs. Better error messages throughout.
2008-06-09 12:16:03 +00:00
Daniel P. Berrange
d789ef5a88
Switch over remaining driver code to use memory alloc apis
2008-06-06 11:09:57 +00:00
Daniel P. Berrange
d7d21c85e0
Switch daemon over to use internal memory allocation APIs
2008-06-06 10:52:01 +00:00
Richard W.M. Jones
a73a88a19f
virDomainBlockPeek QEMU and remote support
...
* qemud/remote.c, qemud/remote_protocol.x, src/remote_internal.c:
Remote support.
* qemud/remote_dispatch_localvars.h,
qemud/remote_dispatch_proc_switch.h,
qemud/remote_dispatch_prototypes.h,
qemud/remote_protocol.c,
qemud/remote_protocol.h:
Generated files for remote support.
* src/xen_unified.c, src/driver.h, src/libvirt.c: Small fix -
pass flags around internally.
* src/qemu_driver.c: Support for QEMU.
* src/xend_internal.c: Remove redundant fstat call from Xen.
2008-06-05 21:12:26 +00:00
Richard W.M. Jones
8354895e68
virDomainBlockPeek call
...
* configure.in: Document AC_SYS_LARGEFILE.
* docs/hvsupport.html.in: Document HV support for virDomainBlockPeek.
* include/libvirt/libvirt.h.in, src/driver.h, src/libvirt.c,
src/libvirt_sym.version: Add virDomainBlockPeek infrastructure.
* src/qemu_driver.c, src/test.c: Null versions of this call.
* src/xen_unified.c, src/xend_internal.c, src/xend_internal.h,
src/xm_internal.c, src/xm_internal.h: Xen implementation.
* tests/sexpr2xmldata/sexpr2xml-curmem.xml,
tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml: XML output
has been reordered slightly in the Xen driver, but should be
functionally the same.
2008-06-05 13:17:45 +00:00
David L. Leskovec
0bd57cdbe1
Fix a few issues related to restart of libvirtd with containers running.
...
Mon May 12 23:32:21 PST 2008 David L. Leskovec <dlesko@linux.vnet.ibm.com>
* src/lxc_driver.c: Add sanity of tty pid before kill()
Ignore ECHILD errors during VM cleanup
Call functions to store tty pid and cleanup tty pid file
* src/lxc_conf.h: Add function to verify container process exists
Add facilities to manage storing the tty forward process pid
* src/lxc_conf.c: Add function to verify container process exists
Call function to verify container process during config load
Add facilities to manage storing the tty forward process pid
Call function to load tty pid during load config
2008-06-05 06:03:00 +00:00
Richard W.M. Jones
eeb224b812
* src/xm_internal.c: If vcpu cpuset attribute is invalid
...
then display an error instead of silently ignoring it
(Hiroyuki Kaguchi).
2008-06-03 08:01:45 +00:00
Daniel P. Berrange
aa2bb9c88c
Switch to using lcov for code coverage repots
2008-05-29 19:27:04 +00:00
Daniel P. Berrange
5e124764c1
Fix parted check & disable storage driver if daemon isn't present
2008-05-29 19:23:17 +00:00
Daniel P. Berrange
895d0fdf5b
Convert to use new memory allocation APIs
2008-05-29 19:20:22 +00:00
Daniel P. Berrange
e8a0db81ef
Pass allocation number to callback
2008-05-29 18:47:00 +00:00
Daniel P. Berrange
46f52f32b2
Convert to use new memory allocation APIs
2008-05-29 18:45:36 +00:00
Daniel P. Berrange
489da1c4b1
Fix missing check for memory allocation failure
2008-05-29 18:45:07 +00:00
Daniel P. Berrange
b0bcffda3b
Misc OOM / memory leak fixes
2008-05-29 15:28:28 +00:00
Daniel P. Berrange
18da6991e1
Generic OOM testing hooks
2008-05-29 15:13:07 +00:00
Daniel P. Berrange
a9d4944f8e
Don't add trailing blanks in dominfo output
2008-05-29 14:56:12 +00:00
Richard W.M. Jones
5c9454aa6e
Display autostart status in virsh dominfo command.
...
* src/virsh.c: Display autostart status in virsh dominfo
command (Shigeki Sakamoto).
2008-05-27 09:41:25 +00:00
Richard W.M. Jones
e083fc786c
Fix use of header files in disk storage backend.
...
* src/storage_backend_disk.c: Include internal.h to resolve use
of header files.
2008-05-27 08:56:56 +00:00
Richard W.M. Jones
f60dc0bc09
Deprecate the conn, dom and net fields in the _virError structure.
...
* include/libvirt/libvirt.h.in: Add VIR_DEPRECATED macro.
* src/internal.h: Internal code is allowed to use deprecated
features, so override VIR_DEPRECATED here.
* include/libvirt/virterror.h: Deprecate the conn, dom and net
fields in the _virError structure.
2008-05-23 08:32:08 +00:00
Richard W.M. Jones
1d8d4f86b6
Standardize use of header files, making internal.h primary.
...
* qemud/internal.h, qemud/qemud.h: Rename this file so it
doesn't conflict with src/internal.h.
* HACKING: Document how header files should be used.
* qemud/Makefile.am: Add src/ directory to includes.
* qemud/event.c, qemud/mdns.c, qemud/qemud.c, qemud/remote.c,
qemud/remote_protocol.c, qemud/remote_protocol.h,
qemud/remote_protocol.x, src/buf.c, src/libvirt.c,
src/nodeinfo.c, src/qemu_conf.c, src/qemu_driver.c,
src/stats_linux.c, src/storage_backend.c, src/storage_backend_fs.c,
src/storage_backend_iscsi.c, src/storage_backend_logical.c,
src/storage_conf.c, src/storage_driver.c, src/util.c,
src/util.h, src/virsh.c, src/virterror.c, src/xend_internal.c,
src/xml.c, tests/reconnect.c, tests/xmlrpctest.c,
tests/qparamtest.c: Standardize use of header files.
* docs/*, po/*: Rebuild docs.
2008-05-23 08:24:41 +00:00
Daniel P. Berrange
9dc31e159a
Fix misc leaks in qparams code, support ; as param separator. Add test suite
2008-05-22 23:49:36 +00:00
Daniel P. Berrange
7646d59568
Refactor QEMU command line building code for readability
2008-05-22 23:45:09 +00:00
Daniel P. Berrange
e193b5ddea
Apply CPU pinning at startup for QEMU guests
2008-05-22 16:27:20 +00:00
Daniel P. Berrange
6d372bd468
Add support for VCPU pinning in QEMU driver
2008-05-22 16:20:31 +00:00
Daniel P. Berrange
42aec3d000
Fix removal of iptable forwarding rules
2008-05-22 15:49:50 +00:00
Daniel P. Berrange
508c4226e1
Implement NUMA info/apis in QEMU driver
2008-05-22 15:29:50 +00:00
Daniel P. Berrange
ab5be538f3
Wire up free memory APIs to remote driver/daemon
2008-05-22 15:20:25 +00:00
Daniel P. Berrange
dd674689df
Fix misc memory leaks
2008-05-22 15:12:25 +00:00
Daniel P. Berrange
ecb117a4a8
Fix exit status check with qemu -help
2008-05-21 21:14:36 +00:00
Daniel P. Berrange
e866e302f8
Fixed couple of memory leaks wrt to virXXXDestroy APIs, and clarify docs to match reality
2008-05-21 20:53:30 +00:00
Daniel P. Berrange
3af422a82e
Run qemu with -help when probing for args
2008-05-21 19:43:39 +00:00
Jim Meyering
f011f263a1
plug two leaks
...
* src/qemu_conf.c (qemudParseXML): Free "obj" unconditionally.
2008-05-16 16:53:44 +00:00
Daniel P. Berrange
40a82f3066
Make QEMU test suite independant of host OS capabilities
2008-05-16 16:51:30 +00:00
Jim Meyering
a770c2ab1c
* src/xml.c: Include "c-ctype.h".
2008-05-16 14:18:38 +00:00
Jim Meyering
c1ee35af3b
start using c-ctype functions
...
Up to now, we've been avoiding ctype functions like isspace, isdigit,
etc. because they are locale-dependent. Now that we have the c-ctype
functions, we can start using *them*, to make the code more readable
with changes like these:
- /* This may not work on EBCDIC. */
- if ((*p >= 'a' && *p <= 'z') ||
- (*p >= 'A' && *p <= 'Z') ||
- (*p >= '0' && *p <= '9'))
+ if (c_isalnum(*p))
- while ((*cur >= '0') && (*cur <= '9')) {
+ while (c_isdigit(*cur)) {
Also, some macros in conf.c used names that conflicted with
standard meaning of "BLANK" and "SPACE", so I've adjusted them
to be in line with the definition of e.g., isblank.
In addition, I've wrapped those statement macros with do {...} while (0),
so that we can't forget the ";" after a use. There was one like that
already (fixed below). The missing semicolon would mess up automatic
indenting.
* src/buf.c (virBufferURIEncodeString):
* src/conf.c (IS_EOL, SKIP_BLANKS_AND_EOL, SKIP_BLANKS)
(virConfParseLong, virConfParseValue, virConfParseName)
(virConfParseSeparator, virConfParseStatement, IS_BLANK, IS_CHAR)
(IS_DIGIT, IS_SPACE, SKIP_SPACES):
* src/nodeinfo.c:
* src/qemu_conf.c (qemudParseInterfaceXML):
* src/qemu_driver.c (qemudDomainBlockStats):
* src/sexpr.c:
* src/stats_linux.c:
* src/util.c (virParseNumber, virDiskNameToIndex):
* src/uuid.c (hextobin, virUUIDParse):
* src/virsh.c:
* src/xml.c (parseCpuNumber, virParseCpuSet):
2008-05-16 09:37:44 +00:00
Jim Meyering
0dc23afb0c
avoid a double-free bug
...
* src/qemu_conf.c (qemudParseXML): Ensure that "obj" is either
NULL or a valid malloc'd pointer before we might "goto error"
where it is freed.
2008-05-16 09:30:10 +00:00
Daniel P. Berrange
65c2738ea1
Remove use of strcmp()
2008-05-15 20:07:34 +00:00
Daniel P. Berrange
25f860dc2f
Fixe default disk bus selection logic
2008-05-15 16:24:26 +00:00
Daniel P. Berrange
763a59d84d
Support Xenner bootloader
2008-05-15 16:21:11 +00:00
Daniel P. Berrange
0f1b6dd06a
Pass -name arg to QEMU when available
2008-05-15 16:15:17 +00:00
Daniel P. Berrange
3a7b528d4b
Add support for Xen input device in QEMU driver for xenner
2008-05-15 16:11:40 +00:00
Daniel P. Berrange
2c37f47985
Support paravirt disk configuration for xenner guests
2008-05-15 16:05:41 +00:00
Jim Meyering
6049594045
avoid using STREQLEN with a literal; use STRPREFIX instead
...
Likewise for STRNEQLEN -> !STRPREFIX.
* src/nodeinfo.c (linuxNodeInfoCPUPopulate):
* src/qemu_conf.c (qemudNetworkIfaceConnect):
(qemudParseInterfaceXML):
* src/qemu_driver.c (qemudDomainBlockStats):
* src/remote_internal.c (call):
* src/stats_linux.c (xenLinuxDomainDeviceID):
* src/xend_internal.c (xend_parse_sexp_desc):
(xend_get, sexpr_to_xend_topology):
* src/xm_internal.c (xenXMConfigCacheRefresh)
(xenXMDomainFormatXML):
2008-05-15 14:21:34 +00:00
Atsushi SAKAI
b87f3000aa
Change libvirtd description from qemu only to various VM(i.e. Xen, LXC)
...
Fix typos and comments
2008-05-15 06:12:32 +00:00
Daniel P. Berrange
f7fe78dc82
Added listen_addr config param for daemon (Stefan de Konink)
2008-05-14 20:57:20 +00:00
Daniel P. Berrange
1d73398e8f
Remove all use of strcmp, strncmp in favour of STREQ, STREQLEN, STRPREFIX
2008-05-14 19:51:24 +00:00
Jim Meyering
e830d52573
avoid "not a string literal..." warnings
...
* src/qemu_conf.c (qemudParseInterfaceXML): Add "%s".
(qemudBuildCommandLine, qemudGenerateXML): Likewise.
2008-05-13 09:15:11 +00:00
David L. Leskovec
94311de539
Enable libvirtd drivers to handle signals, in lxc, sigchld triggers vm cleanup
...
Mon May 12 23:32:21 PST 2008 David L. Leskovec <dlesko@linux.vnet.ibm.com>
* qemud/qemud.c: get siginfo with signals, distribute to drivers that
register a handler
* src/driver.h: add sighandler function to state driver table
* src/internal.h: define virStateSigDispatcher functions
* src/libvirt.c: add __virStateSigDispatcher function
* src/libvirt_sym.version: add __virStateSigDispatcher
* src/lxc_driver.c: add sig handler function, cleanup vm when sigchld
received from container process
* src/qemu_driver.c: NULL for sig handler (no handler) in state driver
* src/remote_internal.c: NULL for sig handler (no handler) in state driver
* src/storage_driver.c: NULL for sig handler (no handler) in state driver
2008-05-13 06:30:58 +00:00
Daniel P. Berrange
098ba1a433
Add support for -drive QEMU syntax, and virtio bus / disk type
2008-05-09 16:41:19 +00:00
Jim Meyering
25534052bc
Use gnulib's c-ctype.h, not <ctype.h>.
...
# Convert uses of isspace to c_isspace, isdigit to c_isdigit, etc.
re=$(man isspace|grep is.....,.is|sed 's/ -.*//' \
|tr -s ', \n' \||sed 's/^|//;s/|$//')
git grep -l -E "$re"|grep -Ev 'Chan|gnulib' \
|xargs perl -pi -e 's/\b('"$re"')\b/c_$1/g'
# Remove all uses of to_uchar
git grep -l to_uchar|xargs perl -pi -e 's/to_uchar\((.*?)\)/$1/g'
* src/util.h (to_uchar): Remove definition.
(TOLOWER): Remove definition.
(__virMacAddrCompare): Use c_tolower, not TOLOWER.
Globally:
Where needed, change <ctype.h> to <c-ctype.h>.
Remove unnecessary inclusion of <ctype.h>.
Ensure the global changes are never needed again:
* Makefile.maint (sc_avoid_ctype_macros): Prohibit use of ctype
macros. Recommend c-ctype.h instead.
(sc_prohibit_c_ctype_without_use): New rule.
(sc_prohibit_ctype_h): New rule. Disallow use of <ctype.h>.
2008-05-09 13:50:14 +00:00
Daniel Veillard
5e1bd04692
autostart for running Xen domains
...
* src/xen_unified.c src/xend_internal.c src/xend_internal.h: patch
from Cole Robinson implementing autostart for running Xen domains
Daniel
2008-05-09 08:17:18 +00:00
Jim Meyering
b8111adf35
avoid one more ctype vs. sign-extension problem
...
* src/util.c (TOLOWER): Also convert tolower argument.
2008-05-09 08:09:48 +00:00
Jim Meyering
6d132b546d
complete the previous change
2008-05-09 08:06:50 +00:00
Jim Meyering
712251009b
add "const" and "static" attributes to file-scoped globals
...
* src/storage_backend_fs.c (fileTypeInfo): Add "static" and two
"const" attributes.
(FileTypeInfo): Name the previously anonymous struct,
so the declaration of fileTypeInfo looks more conventional.
* src/xend_internal.c (sound_models): Mark as static, and
as an array of "const" entries.
These were relatively new additions to the list from here:
nm src/*.o|grep ' D '
2008-05-09 08:02:44 +00:00
David L. Leskovec
6ca76333f3
*** empty log message ***
2008-05-09 07:16:30 +00:00
Daniel P. Berrange
021bd31706
Added disk target bus type to Xen driver
2008-05-08 14:41:56 +00:00
Daniel P. Berrange
31b17e6d44
Disable sound functions when in proxy
2008-05-07 18:50:23 +00:00
Daniel Veillard
da6316f20e
SetVcpus and DomainGetMaxVcpus for QEmu
...
* src/qemu_conf.c src/qemu_conf.h src/qemu_driver.c: another patch
from Cole Robinson adding SetVcpus and DomainGetMaxVcpus for QEmu
Daniel
2008-05-07 16:16:44 +00:00
Daniel Veillard
70f446631f
Sound support for QEmu and Xen
...
* src/qemu_conf.c src/qemu_conf.h src/xend_internal.c
src/xend_internal.h src/xm_internal.c src/xml.c src/xml.h:
Patch from Cole Robinson adding sound support for QEmu and Xen
* tests/qemuxml2argvtest.c tests/sexpr2xmltest.c
tests/xmconfigtest.c tests/xml2sexprtest.c:
Associated regression tests
Daniel
2008-05-07 14:04:40 +00:00
Daniel P. Berrange
2afd1db4a2
Fix build on F9 with missing stddefs.h include
2008-05-06 21:44:12 +00:00
Daniel P. Berrange
b04e40d6a3
Remove bogus check for NULL in qparams breaking connections
2008-05-01 18:11:03 +00:00
Daniel P. Berrange
159cb2b97c
Added support for network interface model setting
2008-04-30 12:30:55 +00:00
Jim Meyering
0c37f59802
remove useless tests before xmlFree
...
* src/qemu_conf.c (qemudParseDiskXML, qemudParseInterfaceXML):
(qemudParseInputXML, qemudParseDhcpRangesXML):
* src/remote_internal.c (doRemoteOpen):
* src/storage_conf.c (virStoragePoolDefParseDoc):
* src/xm_internal.c (xenXMParseXMLDisk, xenXMParseXMLVif):
(xenXMParseXMLToConfig, xenXMAttachInterface):
* src/xml.c (virDomainParseXMLDiskDesc, virDomainParseXMLIfDesc):
(virDomainXMLDevID):
2008-04-29 19:43:57 +00:00
Daniel P. Berrange
624ab0be4c
Tell gcov to look in .libs to find coverage data
2008-04-29 15:38:13 +00:00
Daniel P. Berrange
b1f791adb0
Fix array out of bounds in capabilities code parsing
2008-04-29 14:13:54 +00:00
Daniel P. Berrange
7573ce3591
Remove bogus test code accidentally left in previous commit
2008-04-29 13:48:41 +00:00
Jim Meyering
724d0df7e5
Avoid "make syntax-check" failures.
...
* src/memory.c: Include "config.h".
Remove trailing blanks.
2008-04-29 13:37:20 +00:00
Jim Meyering
fe394e0baa
Avoid in-function #if directives.
...
* src/parthelper.c [!PED_PARTITION_PROTECTED]: Define to 0.
Remove in-function #ifdefs.
2008-04-29 13:20:46 +00:00
Richard W.M. Jones
1e43bebf69
* src/parthelper.c: Don't fail if PED_PARTITION_PROTECTED
...
is not defined because of ancient libparted
(Soren Hansen).
2008-04-29 08:17:36 +00:00
Daniel P. Berrange
4ffb0358de
Added safer lowlevel memory allocation APis. Converted hash.c and capabilities.c to use them
2008-04-28 21:44:54 +00:00
Daniel P. Berrange
642b26fab2
Change virBuffer API to prevent common usage errors. Update all users of APIs
2008-04-28 15:14:59 +00:00
Jim Meyering
212472b813
avoid format-related warnings
...
* qemud/qemud.c (main): Fix a bogus format string reported as umarked.
* src/virsh.c (cmdVcpupin): Non-literal with no args.
2008-04-28 09:09:52 +00:00
Daniel P. Berrange
e6f1123819
Added full support for serial and parallel devices to Xen drivers
2008-04-26 14:22:02 +00:00
Daniel P. Berrange
49956f0469
Implement serial & parallel device support for QEMU driver
2008-04-25 20:46:13 +00:00
Jim Meyering
225ba3f0af
avoid problems with sign-extended "char" operand to is* functions
...
* src/util.h (to_uchar): Define function.
* src/nodeinfo.c (linuxNodeInfoCPUPopulate): Apply to_uchar to is* operand.
* src/qemu_driver.c (qemudExtractMonitorPath): Likewise.
* src/sexpr.c (_string2sexpr): Likewise.
* src/stats_linux.c (xenLinuxDomainDeviceID): Likewise.
* src/util.c (TOLOWER, __virMacAddrCompare, virParseMacAddr): Likewise.
* src/virsh.c (cmdVcpupin, vshCommandGetToken): Likewise.
2008-04-25 14:53:05 +00:00
Jim Meyering
2d206f1d7a
avoid compile error when <pthread.h> is absent
...
* src/internal.h (HAVE_PTHREAD_H): Test with "#ifdef", not "#if".
2008-04-18 09:26:45 +00:00
Richard W.M. Jones
8df91acf70
Fixes for MinGW.
...
* configure.in: Fix pkg-config detection of libxml2,
add -lgcrypt to gnutls lib.
* src/Makefile.am: If compiling --without-libvirtd then
don't compile any part of the storage driver.
* configure.in, src/hash.c, src/internal.h: Detect availability
of pthread library and compile out mutex code if not available.
* src/storage_driver.c, src/util.c: Ignore some missing
headers on MinGW.
2008-04-18 08:33:23 +00:00
Richard W.M. Jones
ba5411995b
Remove unused uid field in virsh control structure.
...
* src/virsh.c: Remove unused uid field in virsh control structure.
2008-04-10 17:37:23 +00:00
Jim Meyering
5bf824ea10
convert TAB-based indentation in C sources to use only spaces
...
Done using this command (also includes .c.in and .h.in files):
for i in $(g ls-files|grep -E '\.[ch](\.in)?$'|grep -v gnulib); do
expand -i $i > j && mv j $i;done
2008-04-10 16:54:54 +00:00
Jim Meyering
dc42a9d2de
remove Vim and Emacs variable settings from C source files
...
Done with these commands:
git grep -l Local.variab|xargs \
perl -0x3b -pi -e 's,\n+/\*\n \* vim:(.|\n)*,\n,'
git grep -l Local.variab|xargs \
perl -0x3b -pi -e 's,\n+/\*\n \* Local variables:\n(.|\n)*,\n,'
2008-04-10 16:53:29 +00:00
Daniel Veillard
c863713742
Ask xend to remove device in the config file too
...
* src/xend_internal.c: applied a patch from Ryan Scott to ask
xend to save the device removal change in the config file
Daniel
2008-04-10 13:30:17 +00:00
Daniel Veillard
9ae41a71ac
* src/Makefile.am src/lxc_conf.c src/lxc_conf.h src/lxc_container.c
...
src/lxc_container.h src/lxc_driver.c: Applied second set of
linux container patches from Dave Leskovec adding start/stop
of domains
Daniel
2008-04-10 07:30:52 +00:00
Richard W.M. Jones
ed8a6d6a10
Core code contains Xen-ism UUID of dom0 = 0..0
...
* src/libvirt.c: Remove a Xen-ism from the core code, the
assumption that dom0's UUID is all zeroes.
2008-04-09 14:03:01 +00:00
Richard W.M. Jones
b5af30a9f3
Remove extraneous underscore
...
* src/openvz_conf.c: Remove extraneous underscore which stopped
file from compiling (Anton Protopopov).
2008-04-09 13:50:27 +00:00
Jim Meyering
3ce465f819
Don't fail to read a file because it's non-seekable (e.g., a pipe).
...
* src/util.c (fread_file_lim): New function.
(__virFileReadAll): Use fread_file_lim, rather than requiring
that stat.st_size provide a usable file size.
* tests/read-non-seekable: New test, for the above.
* tests/Makefile.am (test_scripts): Add read-non-seekable.
* tests/test-lib.sh (mkfifo_or_skip_): New helper function.
2008-04-08 15:33:16 +00:00
Richard W.M. Jones
407df0f164
src/qemu_driver.c: Handle errors from fork(2) and pipe(2)
...
system calls when creating qemu subprocess.
2008-04-08 12:27:53 +00:00
Daniel Veillard
801a8f2e7b
adds xen and hvm guest types to test driver capabilities
...
* src/test.c: patch from Cole Robinson adding xen and hvm guest types
to the test driver's capabilities.
Daniel
2008-04-08 09:26:24 +00:00
Daniel P. Berrange
d4a6fe9f99
Don't do polkit auth as root
2008-04-04 15:09:19 +00:00
Daniel Veillard
62ee5d5711
error message on vcpupin
...
* src/virsh.c: patch from Shigeki Sakamoto adding message on vcpupin
Daniel
2008-04-04 11:20:45 +00:00
Daniel Veillard
a528e97383
typos fixes
...
* docs//* src/conf.c src/hash.c src/libvirt.c src/proxy_internal.c
src/remote_internal.c src/virsh.c src/xen_internal.c
src/xend_internal.c src/xml.c: applied patch from Atsushi SAKAI
fixing a lot of typos
Daniel
2008-04-04 07:58:29 +00:00
Daniel Veillard
7b72ef296f
virNodeGetCellsFreeMemory for test driver
...
* src/test.c: patch from Cole Robinson to add
virNodeGetCellsFreeMemory to the test driver
Daniel
2008-04-04 07:31:24 +00:00
Richard W.M. Jones
dfc4b8a7d0
C99 initializer on __lastErr
...
* src/virterror.c: Use C99 initializers to make initialization
of __lastErr clearer (Guido Günther).
2008-04-02 16:22:34 +00:00
Daniel Veillard
c2b690f1bd
* src/lxc_conf.c: patch from Dave Leskovec fixing an freed memory
...
access I introduced yesterday
Daniel
2008-04-01 13:01:01 +00:00
Daniel Veillard
c7d7aa1cd1
remove dandling domain/net/conn pointers from error data
...
* src/hash.c src/internal.h src/virterror.c: remove dandling
domain/net/conn pointers from error data when released.
* src/lxc_driver.c: fix a NULL/0 return error mismatch
Daniel
2008-03-31 14:38:12 +00:00
Daniel Veillard
497f252015
linux countainers cleanup patches
...
* src/lxc_conf.c src/lxc_conf.h: cleanup patch for the conf driver
of linux countainers, reuse XPath helpers, make string fields dynamic
and remove a memory leak.
* src/lxc_driver.c: avoid some problems when the config directory is
not accessible and for regression tests
Daniel
2008-03-31 12:02:12 +00:00
Daniel P. Berrange
038b434f14
Added patches for routed networking from Mads Chr. Olesen
2008-03-28 20:38:21 +00:00
Daniel P. Berrange
924de9c3d1
Fix output of XML for FS storage pool
2008-03-28 17:56:44 +00:00
Daniel P. Berrange
b7909d3276
Tweak masquering rules to only capture traffic leaving the virtual network
2008-03-28 01:05:08 +00:00
Jim Meyering
c5adab5270
lxcError: mark a string and add to the list of nearly-checked functions
...
* Makefile.maint (msg_gen_function): Add, but commented-out.
* src/lxc_conf.c (lxcParseXML): Mark a diagnostic for translation.
2008-03-27 14:02:57 +00:00
Jim Meyering
76a7098407
testError: mark most string arguments for translation
...
* Makefile.maint (msg_gen_function): Add testError
* src/test.c (testDomainSave, testDomainRestore): Mark strings.
(testDomainCoreDump): Likewise.
2008-03-27 14:01:59 +00:00
Jim Meyering
7f8639261a
openvzLog: mark its string arguments for translation
...
* Makefile.maint (msg_gen_function): Add openvzLog.
* src/openvz_conf.c (openvzAssignVMDef, openvzParseXML): Mark strings.
* src/openvz_driver.c (openvzDomainShutdown, openvzDomainReboot):
(openvzDomainDefineXML, openvzDomainCreateLinux):
(openvzDomainCreate, openvzDomainUndefine): Likewise.
2008-03-27 14:00:28 +00:00
Jim Meyering
5bb81e1d87
error: mark most string arguments for translation
...
Also mark some arguments to __virRaiseError.
* Makefile.maint (msg_gen_function): Add error.
* po/POTFILES.in: Add src/openvz_conf.c and src/openvz_driver.c.
* src/openvz_conf.c (openvzParseXML, openvzGetVPSInfo): Mark strings.
* src/openvz_driver.c (openvzDomainLookupByID): Likewise.
(openvzDomainLookupByUUID, openvzDomainLookupByName): Likewise.
(openvzDomainGetInfo, openvzDomainShutdown, openvzDomainReboot)
(openvzDomainCreate, openvzDomainUndefine): Likewise.
* src/remote_internal.c (check_cert_file): Likewise.
(negotiate_gnutls_on_connection, verify_certificate): Likewise.
(remoteAuthenticate, addrToString, remoteAuthSASL): Likewise.
(remoteAuthPolkit, call, really_read_buf): Likewise.
2008-03-27 13:58:56 +00:00
Jim Meyering
f1eed04b2d
Convert diagnostics like "VAR > MAX_VAR" to translatable messages.
...
* src/remote_internal.c (errorf): New function.
(remoteListDomains, remoteDomainPinVcpu, remoteDomainGetVcpus):
(remoteListDefinedDomains, remoteListNetworks):
(remoteListDefinedNetworks): Convert strings to be translatable,
and also to include offending and maximum values. Use errorf.
2008-03-27 13:56:28 +00:00
Jim Meyering
b53c4e51f8
qemudReportError: mark for translation string args to this function
...
* Makefile.maint (msg_gen_function): Add qemudReportError.
* src/qemu_conf.c (qemudLoadDriverConfig)
(qemudExtractVersion, qemudParseDiskXML, qemudParseInterfaceXML)
(qemudParseInputXML, qemudParseXML, qemudNetworkIfaceConnect)
(qemudBuildCommandLine, qemudSaveConfig, qemudParseVMDeviceDef)
(qemudAssignVMDef, qemudSaveVMDef, qemudSaveNetworkConfig)
(qemudParseDhcpRangesXML, qemudParseNetworkXML)
(qemudAssignNetworkDef, qemudSaveNetworkDef, qemudGenerateXML)
(qemudGenerateNetworkXML, qemudDeleteConfig): Mark strings.
* src/qemu_driver.c (qemudBuildDnsmasqArgv, qemudAddIptablesRules)
(qemudGetCapabilities, qemudDomainGetOSType)
(qemudListDefinedDomains, qemudListNetworks)
(qemudListDefinedNetworks, qemudNetworkGetBridgeName): Mark strings.
2008-03-27 13:53:14 +00:00
Jim Meyering
3163224bb5
ReportError: mark for translation string args to this function
...
* Makefile.maint (msg_gen_function): Add ReportError.
* src/util.c (_virExec): Mark strings.
2008-03-27 13:47:00 +00:00
Jim Meyering
56a3cb8086
xenXMError: mark for translation string args to this function
...
* Makefile.maint (msg_gen_function): Add xenXMError.
* src/xm_internal.c (xenXMParseXMLToConfig, xenXMDomainDefineXML):
(xenXMDomainAttachDevice, xenXMDomainDetachDevice): Mark strings.
2008-03-27 13:45:26 +00:00
Jim Meyering
513bd04ce1
Mark many more strings for translation.
...
* Makefile.maint (err_func_re): Add to the list and make it readable.
* po/POTFILES.in: Add src/util.c and src/xm_internal.c, and sort.
* src/storage_backend.c: Fix comment.
* src/util.c (virFileLinkPointsTo): Mark a string.
* qemud/remote.c (remoteDispatchClientRequest): Mark strings.
(remoteDispatchOpen, CHECK_CONN, remoteDispatchGetType): Likewise.
(remoteDispatchDomainGetSchedulerType): Likewise.
(remoteDispatchDomainGetSchedulerParameters): Likewise.
(remoteDispatchDomainSetSchedulerParameters): Likewise.
(remoteDispatchDomainBlockStats): Likewise.
(remoteDispatchDomainInterfaceStats): Likewise.
(remoteDispatchDomainAttachDevice, remoteDispatchDomainCreate):
(remoteDispatchDomainDestroy, remoteDispatchDomainDetachDevice):
(remoteDispatchDomainDumpXml, remoteDispatchDomainGetAutostart):
(remoteDispatchDomainGetInfo, remoteDispatchDomainGetMaxMemory):
(remoteDispatchDomainGetMaxVcpus, remoteDispatchDomainGetOsType):
(remoteDispatchDomainGetVcpus): Likewise.
(remoteDispatchDomainMigratePerform): Likewise.
(remoteDispatchListDefinedDomains, remoteDispatchDomainPinVcpu):
(remoteDispatchDomainReboot, remoteDispatchDomainResume):
(remoteDispatchDomainSave, remoteDispatchDomainCoreDump):
(remoteDispatchDomainSetAutostart): Likewise.
(remoteDispatchDomainSetMaxMemory, remoteDispatchDomainSetMemory):
(remoteDispatchDomainSetVcpus, remoteDispatchDomainShutdown):
(remoteDispatchDomainSuspend, remoteDispatchDomainUndefine):
(remoteDispatchListDefinedNetworks, remoteDispatchListDomains):
(remoteDispatchListNetworks, remoteDispatchNetworkCreate):
(remoteDispatchNetworkDestroy, remoteDispatchNetworkDumpXml):
(remoteDispatchNetworkGetAutostart, remoteDispatchNetworkGetBridgeName):
(remoteDispatchNetworkSetAutostart, remoteDispatchNetworkUndefine):
(addrToString, remoteDispatchAuthSaslInit, remoteDispatchAuthSaslStart):
(remoteDispatchAuthSaslStep, remoteDispatchListDefinedStoragePools):
(remoteDispatchListStoragePools, remoteDispatchStoragePoolCreate):
(remoteDispatchStoragePoolBuild, remoteDispatchStoragePoolDestroy):
(remoteDispatchStoragePoolDelete, remoteDispatchStoragePoolRefresh):
(remoteDispatchStoragePoolGetInfo, remoteDispatchStoragePoolDumpXml):
(remoteDispatchStoragePoolGetAutostart): Likewise.
(remoteDispatchStoragePoolSetAutostart):
(remoteDispatchStoragePoolListVolumes):
(remoteDispatchStoragePoolNumOfVolumes):
(remoteDispatchStoragePoolUndefine, remoteDispatchStorageVolCreateXml):
(remoteDispatchStorageVolDelete, remoteDispatchStorageVolGetInfo):
(remoteDispatchStorageVolDumpXml, remoteDispatchStorageVolGetPath):
(remoteDispatchStorageVolLookupByName): Likewise.
* src/qemu_driver.c (qemudOpenMonitor, qemudStartVMDaemon):
(dhcpStartDhcpDaemon, qemudStartNetworkDaemon):
(qemudDomainSuspend, qemudDomainResume, qemudDomainShutdown):
(qemudDomainGetOSType, qemudDomainSetMaxMemory):
(qemudDomainSetMemory, qemudDomainGetInfo, qemudDomainSave):
(qemudDomainRestore, qemudDomainDumpXML, qemudDomainStart):
(qemudDomainUndefine, qemudDomainChangeCDROM):
(qemudDomainAttachDevice, qemudDomainGetAutostart):
(qemudDomainSetAutostart, qemudDomainInterfaceStats):
(qemudNetworkLookupByUUID, qemudNetworkLookupByName):
(qemudNetworkUndefine, qemudNetworkStart, qemudNetworkDestroy):
(qemudNetworkDumpXML, qemudNetworkGetAutostart):
(qemudNetworkSetAutostart): Likewise.
* src/virsh.c (cmdVcpupin, cmdAttachDevice, cmdDetachDevice): Likewise.
* src/xm_internal.c (xenXMConfigCacheRefresh, xenXMDomainPinVcpu): Likewise.
2008-03-27 13:43:01 +00:00
Daniel Veillard
425cf2e792
Linux container fixes, move driver in the daemon.
...
* src/lxc_conf.c src/lxc_conf.h src/lxc_driver.c src/remote_internal.c:
applied patch from Dan Berrange to change the way the lxc driver
works, migrating the support in the daemon, it also removes some
compilation issues and teh way the configuration files are named.
Daniel
2008-03-27 09:34:06 +00:00
Daniel Veillard
ae15bc7245
support of older versions of iscsiadm.
...
* src/storage_backend_iscsi.c: patch from Chris Lalancette to improve
support with older versions of iscsiadm.
Daniel
2008-03-27 08:11:27 +00:00
Daniel Veillard
94c2255d81
* src/xen_internal.c proxy/libvirt_proxy.c: fix Xen hypercall for
...
Xen-3.2, and merged its debugging with the general library facility
Daniel
2008-03-26 13:03:30 +00:00
Richard W.M. Jones
dc1824b780
Tue Mar 25 10:23:00 UTC 2008 Richard W.M. Jones <rjones@redhat.com>
...
* src/virsh.c: Additional error messages for missing
parameters (Shigeki Sakamoto).
2008-03-25 10:26:32 +00:00
Daniel Veillard
928a84e10d
* src/qemu_driver.c: remove trailing newlines from error messages
...
patch from Guido Günther
Daniel
2008-03-24 10:58:21 +00:00
Daniel Veillard
71c061d559
* src/qemu_driver.c: applied patch from Guido Günther to make error
...
strings as translatable
Daniel
2008-03-24 10:51:47 +00:00
Daniel Veillard
979bb2bb67
* src/xend_internal.c: applied patch from Saori Fukuta adding the
...
scheduler API for the Xen daemon driver
* po/POTFILES.in: add the two new linux container modules
Daniel
2008-03-24 09:23:32 +00:00
Daniel Veillard
f163895204
Initial Linux containers work
...
* configure.in include/libvirt/virterror.h src/Makefile.am
src/driver.h src/lxc_conf.[ch] src/lxc_driver.[ch] src/virterror.c:
Applied 3 patches from Dave Leskovec for intial support of
Linux containers, configured off by default, work in progress.
* src/libvirt.c: improve virDomainCreateLinux xmlDesc description
Daniel
2008-03-21 15:03:37 +00:00
Daniel Veillard
ccb19376f7
* src/util.c src/util.h src/xml.c: applied patch from Hiroyuki Kaguchi
...
fixing Ethernet MAC addresses parsingand separating as an util
function, with added comments from Jim Meyering
Daniel
2008-03-20 11:24:30 +00:00
Daniel Veillard
623ec4d2f2
* src/qemu_conf.c src/qemu_conf.h src/qemu_driver.c: applied patch
...
from Cole Robinson implementing memory operations for qemu driver
Daniel
2008-03-19 14:32:50 +00:00
Jim Meyering
2fe1c38796
Avoid "make syntax-check" failure.
...
* src/xen_unified.c: Remove trailing blank.
2008-03-18 22:33:01 +00:00
Daniel P. Berrange
ea1c08e78d
Use explicit logic rules for opening Xen sub-drivers
2008-03-17 17:30:48 +00:00
Jim Meyering
a34bcb7829
Treat ENOTSUP like ENODATA, after failed fgetfilecon.
...
* src/storage_backend.c (virStorageBackendUpdateVolInfoFD): Treat a
failed fgetfilecon with errno == ENOTSUP the same as for ENODATA.
2008-03-17 16:57:21 +00:00
Daniel Veillard
96c795328d
fixed DefinedDomains function comments c.f. 437216
...
* libvirt.c: fixed DefinedDomains function comments c.f. 437216
* docs/libvirt-*.xml docs/*/libvirt-libvirt.html: regenerated
Daniel
2008-03-17 16:43:54 +00:00
Daniel P. Berrange
cefa185c1f
Fix creation of unmanaged pools
2008-03-17 15:10:48 +00:00
Daniel P. Berrange
d8b363c35f
Cope with missing selinux attribute
2008-03-17 15:09:38 +00:00
Daniel Veillard
ca7047f122
* src/libvirt.c docs/libvirt-*.xml docs/html/libvirt-libvirt.html:
...
fixed a few missing argument descriptions and regenerated.
Daniel
2008-03-17 10:48:02 +00:00
Daniel Veillard
08ecf61b35
* NEWS virsh.1 docs//* include/libvirt/libvirt.h[.in] qemud/mdns.h
...
src/libvirt.c src/qemu.conf src/remote_internal.c src/xend_internal.c
tests/confdata/libvirtd.conf tests/confdata/libvirtd.out: patch from
Atsushi SAKAI fixing a ot more typo
Daniel
2008-03-17 10:27:31 +00:00
Daniel P. Berrange
7ae13660cf
Don't set MAC on TAP devs. Pass TAP device name to QEMU
2008-03-14 20:30:03 +00:00
Daniel Veillard
62b4c870aa
typo
...
* src/bridge.c: fix a typo in a comment
Daniel
2008-03-14 15:31:08 +00:00
Daniel Veillard
a7892ee000
String fixes #436620
...
* qemud/qemud.c src/virsh.c: fixing some user facing strings
problems pointed out by Francesco Tombolini should fix #436620
Daniel
2008-03-14 15:21:15 +00:00
Richard W.M. Jones
3e59e29859
Fix typo "informations" -> "information" (Atsushi SAKAI and
...
Saori FUKUTA).
2008-03-14 11:08:03 +00:00
Daniel Veillard
adbf991a1d
* src/libvirt.c: virDomainSetSchedulerParameters need to be
...
blocked on read-only connections, patch from Saori Fukuta
Daniel
2008-03-13 09:27:46 +00:00
Daniel Veillard
dc232cdf1b
* src/bridge.c src/virsh.c: typo fixes from Atsushi SAKAI
...
daniel
2008-03-13 09:21:41 +00:00
Daniel Veillard
af1c7f96a8
* src/qemu_conf.c src/qemu_driver.c: patch from Cole Robinson
...
fixing CD Rom change on live QEmu/KVM domains.
Daniel
2008-03-13 09:17:45 +00:00
Daniel P. Berrange
77ed8ded7b
Remove unused variable
2008-03-11 16:01:23 +00:00
Daniel P. Berrange
8d2d44ad05
Remove use of polkit-grant. Keep stdio open when running polkit-auth
2008-03-11 14:49:04 +00:00
Daniel P. Berrange
c3501d4792
Don't force Xen connections to readonly when non-root
2008-03-11 14:25:49 +00:00
Daniel Veillard
d4cbf4c624
* src/xend_internal.c: applied patch from Cole Robinson to not
...
loose the boot tag when defining a fully virtualized xen domain
Daniel
2008-03-07 09:23:30 +00:00
Richard W.M. Jones
2a4c20437d
Make iSCSI login actually work
...
* src/storage_backend_iscsi.c: Make iSCSI login actually work
(Chris Lalancette).
2008-03-04 20:02:34 +00:00
Richard W.M. Jones
4d6a8a1c0a
Report error when vcpupin is given bad vCPU number.
...
* src/virsh.c: Report error when vcpupin is given bad vCPU number
(Shigeki Sakamoto).
2008-03-04 19:59:56 +00:00
Jim Meyering
0075d7e74a
fix typo in comment
2008-03-03 23:06:02 +00:00
Jim Meyering
869f8d0e7d
Also ignore leading zeros when comparing MAC addresses.
...
* src/util.c: Include <ctype.h>.
(TOLOWER): Define.
(__virMacAddrCompare): Rewrite to also ignore leading zeros.
2008-03-03 20:39:52 +00:00
Daniel Veillard
65c4379c53
* src/capabilities.c: Cole Robinson pointed out a well formedness
...
problem when generating the capabilities in the test driver.
Daniel
2008-03-03 20:21:21 +00:00
Jim Meyering
4090a0870c
Don't use first byte of string as a pointer.
...
* src/qemu_conf.c (qemudReportError): Use the pointer, errorMessage,
not its first byte, errorMessage[0].
2008-03-03 18:11:16 +00:00
Jim Meyering
1de5bace80
Plug two leaks: host.migrateTrans and arch.name
...
* src/capabilities.c (virCapabilitiesFree): Free host.migrateTrans.
(virCapabilitiesFreeGuest): Free arch.name member.
2008-03-03 13:15:14 +00:00
Jim Meyering
47a4c0fa0b
Plug virCapabilities*GuestDomain leak.
...
* src/capabilities.c (virCapabilitiesFreeGuestDomain): Free dom->type.
(virCapabilitiesAddGuestDomain): Remove duplicate strdup stmt.
2008-03-03 13:14:26 +00:00
Jim Meyering
ba52fcbcdf
Rewrite test-coverage rules to accommodate multiple .o files per .c.
...
* src/Makefile.am (cov): Rewrite rule to merge gcov results corresponding
to two .o files: the libvirt_la- one, and the libvirt_test_la- one.
(tst): Remove unused rule.
* configure.in (LV_LIBTOOL_OBJDIR): Define and AC_SUBST.
2008-02-28 17:07:37 +00:00
Jim Meyering
9262d88e28
Avoid link errors with "configure --disable-shared".
...
* src/Makefile.am: Create a convenience library, libvirt_test.la,
and don't restrict access to *its* symbols.
* tests/Makefile.am (LDADDS): Add ../src/libvirt_test.la, so that
"configure --disable-shared" no longer provokes link errors.
(LIBVIRT): Remove definition.
(LDADDS): Remove use.
($(LIBVIRT)): Remove rule.
(LDADDS): Use the new convenience library instead.
(CLEANFILES): Define.
* docs/examples/index.py (dump_Makefile): Append $(COVERAGE_LDFLAGS),
to the LDADDS definition, to avoid link error with the combination of
--enable-test-coverage and --disable-shared.
* docs/examples/Makefile.am: Regenerate.
* docs/examples/index.html: Likewise.
* qemud/Makefile.am (libvirtd_LDFLAGS): Append $(COVERAGE_LDFLAGS).
* src/libvirt_sym.version: Remove some SP-before-TAB.
2008-02-28 17:06:32 +00:00
Daniel Veillard
004ff90483
Fix qemudReportError.
...
* src/qemu_conf.c: applied patch from Cole Robinson to use virErrorMsg
in qemudReportError.
Daniel
2008-02-28 11:17:49 +00:00
Daniel P. Berrange
9699e372c2
Set MAC address on TUN device for Xenner compatability
2008-02-28 01:23:14 +00:00
Richard W.M. Jones
92a1e14b0b
virMacAddrCompare for comparing MAC addresses
...
* src/util.c, src/util.h, src/libvirt_sym.version: Added
virMacAddrCompare utility function for comparing MAC
addresses.
* src/virsh.c, src/xm_internal.c: Use virMacAddrCompare
to compare addresses. (Shigeki Sakamoto and Richard Jones).
2008-02-27 16:14:44 +00:00
Jim Meyering
fa4ab3325b
Avoid "make distcheck" failure.
...
* src/Makefile.am (virsh_SOURCES): Add util-lib.h.
2008-02-27 15:17:45 +00:00
Jim Meyering
d7cdc28431
Fix a "make syntax-check" failure.
...
* src/capabilities.c: Include <config.h> from the .c file,
* src/capabilities.h: ... not from the .h file.
2008-02-27 14:40:19 +00:00
Richard W.M. Jones
b4882504ea
Fix typos (Atsushi SAKAI).
2008-02-27 10:37:19 +00:00
Daniel P. Berrange
63bc5dd3e1
Add formal internal capabilities API and update drivers to use it
2008-02-27 04:35:08 +00:00
Richard W.M. Jones
727c5601ec
Implement virDomainBlockStats for QEMU/KVM.
...
* src/qemu_driver.c: Implement virDomainBlockStats for QEMU/KVM
using QEMU/KVM 'info blockstats' command (Richard Jones).
* src/qemu_driver.c, src/qemu_conf.h: const-correctness
fixes (Jim Meyering).
2008-02-26 18:41:43 +00:00
Richard W.M. Jones
242fe3d401
No address attribute in Xen domain XML.
...
* src/xm_internal.c: handle the case where <mac/> clause
in Xen domain interface has no address attribute
(Shigeki Sakamoto).
2008-02-26 18:31:57 +00:00
Daniel Veillard
ea47a7d4e4
Oops trailing blank, Daniel
2008-02-26 07:06:48 +00:00
Daniel Veillard
36c6bfa63d
* src/driver.h src/libvirt.c src/openvz_driver.c src/qemu_driver.c
...
src/remote_internal.c src/test.c src/util.c src/util.h
src/xen_unified.c: added probe interface at the driver level,
use that to improve default hypervisor selection in the absence
of a given URI when connecting
Daniel
2008-02-26 07:05:18 +00:00
Daniel Veillard
9b1cd481b8
fix compilation against static libraries
...
* src/Makefile.am src/util-lib.h: fix done with Jim to allow
compilation of virsh with the static libraries.
Daniel
2008-02-25 13:55:56 +00:00
Jim Meyering
e497deb89e
Avoid new "make syntax-check" failures.
...
* .x-sc_avoid_write: Exempt src/util-lib.c, too.
* Makefile.maint (sc_unmarked_diagnostics): Filter out false positives.
* src/storage_backend_fs.c (virStorageBackendFileSystemVolCreate):
Use safewrite, not write.
* src/storage_backend_logical.c (virStorageBackendLogicalBuildPool): Likewise.
2008-02-25 10:00:16 +00:00
Jim Meyering
b1b23f76be
avoid format string warnings
...
Avoid warnings like this:
file:nnn:format not a string literal and no format arguments
* qemud/qemud.c: Insert a "%s" format argument.
* qemud/remote.c: Likewise.
* src/iptables.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/storage_backend.c: Likewise.
* src/storage_backend_fs.c: Likewise.
* src/storage_backend_iscsi.c Likewise.
* src/storage_backend_logical.c: Likewise.
* src/storage_conf.c: Likewise.
* src/storage_driver.c: Likewise.
2008-02-22 16:26:13 +00:00
Jim Meyering
b59d9c85f1
Use safewrite in place of write, in many cases.
...
Also add "make syntax-check" rules to ensure no new uses sneak in.
There are many uses of write like this:
if (write (fd, xml, towrite) != towrite)
return -1;
The problem is that the syscall can succeed, yet write less than
the requested number of bytes, so the caller should retry
rather than simply failing.
This patch changes most of them to use util.c's safewrite wrapper,
which encapsulates the process. Also, there were a few cases in
which the retry loop was open-coded, and I replaced those, too.
* Makefile.maint (sc_avoid_write): New rule, to avoid recurrence.
* .x-sc_avoid_write: New file. Record two legitimate exemptions.
* qemud/qemud.c (sig_handler, qemudClientWriteBuf): Use safewrite, not write.
* src/conf.c (__virConfWriteFile): Likewise.
* src/qemu_conf.c (qemudSaveConfig, qemudSaveNetworkConfig): Likewise.
* src/qemu_driver.c (qemudWaitForMonitor, qemudStartVMDaemon)
(qemudVMData, PROC_IP_FORWARD): Likewise.
* proxy/libvirt_proxy.c: Include "util.h".
(proxyWriteClientSocket): Use safewrite.
* src/test.c (testDomainSave, testDomainCoreDump): Likewise.
* src/proxy_internal.c (virProxyWriteClientSocket): Likewise.
* src/virsh.c: Include "util-lib.h".
(vshOutputLogFile): Use safewrite.
* src/console.c: Include "util-lib.h".
(vshRunConsole): Use safewrite.
2008-02-22 15:55:04 +00:00
Jim Meyering
a178a4e7bf
Move safewrite and saferead to a separate file.
...
We currently use safewrite from inside libvirt and don't want to publish
any such function name. However, we do want to use it in applications
like virsh, libvirtd and libvirt_proxy that link with libvirt. To that
end, this change moves that function definition (along with the nearly
identical saferead) into a new file, util-lib.c. To avoid maintaining
separate copies of even such small functions, we simply include that new
file from util.c. Then, the separate applications that need to use
safewrite simply compile and link with util-lib.c.
Of course, this does mean that each of those applications will
containing two copies of these functions. However, the functions
are so small that it's not worth worrying about that.
* src/util.c (saferead, safewrite): Move function definitions to
util-lib.c and include that .c file.
* src/util-lib.c (saferead, safewrite): New file. Functions from src/util.c
with slight change (s/int r =/ssize_t r =/) to reflect read/write return type.
* src/util-lib.h: Declare the two moved functions.
* src/util.h: Remove declarations. Include src/util-lib.h.
* proxy/Makefile.am (libvirt_proxy_SOURCES): Add src/util-lib.c.
* qemud/Makefile.am (libvirtd_SOURCES): Likewise.
* src/Makefile.am (virsh_SOURCES): Add util-lib.c. Remove some SP-before-TAB.
2008-02-22 15:53:13 +00:00
Jim Meyering
6187c6de9b
With --enable-iptables-lokkit=no, avoid warning about unused parameter.
...
* src/iptables.c (iptRulesSave) [!ENABLE_IPTABLES_LOKKIT]:
Mark parameter as used.
2008-02-22 12:34:27 +00:00
Jim Meyering
9bcade46df
Rewrite openvzSetUUID.
...
* src/openvz_conf.c (openvzSetUUID): Rewrite to avoid unchecked
lseek, write, and close as well as a potential file descriptor leak.
2008-02-21 18:48:06 +00:00
Jim Meyering
5fc07cd840
Handle failed openvzLocateConfDir.
...
* src/openvz_conf.c (openvzLocateConfDir, openvzGetVPSUUID):
(openvzSetUUID): Don't dereference NULL upon failure.
2008-02-21 18:22:45 +00:00
Richard W.M. Jones
be8653b183
Fix double-free in OpenVZ driver.
...
* src/openvz_conf.c: Double-free fix (Anton Protopopov).
2008-02-21 15:20:36 +00:00
Daniel P. Berrange
83d0aa0706
Added missing symbol export
2008-02-21 03:53:03 +00:00
Daniel P. Berrange
104cc98636
Update to work with new policy kit APIs
2008-02-20 16:54:35 +00:00
Daniel P. Berrange
4bea16df64
Ignore libvirt_parthelper binary
2008-02-20 15:58:38 +00:00
Daniel P. Berrange
291158945d
Added no-op stub of storage APIs to test driver
2008-02-20 15:53:34 +00:00
Daniel P. Berrange
b7db975135
Added disk partition storage pool backend
2008-02-20 15:52:17 +00:00
Daniel P. Berrange
8ec1fcd925
Added iSCSI storage pool backend
2008-02-20 15:49:25 +00:00
Daniel P. Berrange
e266ded2f6
Added directory/filesystem/netfs based storage pool backend
2008-02-20 15:45:59 +00:00
Daniel P. Berrange
ac736602fd
Added logical volume storage pool driver
2008-02-20 15:45:33 +00:00
Daniel P. Berrange
e39438e869
Added directory/filesystem/netfs based storage pool backend
2008-02-20 15:42:30 +00:00
Daniel P. Berrange
4a4e272f9d
Added storage backend helper APIs
2008-02-20 15:38:29 +00:00
Daniel P. Berrange
20878720c0
Added main internal storage driver impl
2008-02-20 15:34:52 +00:00
Daniel P. Berrange
f43e709842
Added convenience virsh command for creating pools/volumes without XML
2008-02-20 15:29:13 +00:00
Daniel P. Berrange
816fd02876
Added virsh commands for storage management
2008-02-20 15:27:08 +00:00
Daniel P. Berrange
661c5c4476
Add storage APIs to remote driver
2008-02-20 15:23:36 +00:00
Daniel P. Berrange
cb228a0e24
Internal driver API for storage management
2008-02-20 15:06:53 +00:00
Daniel P. Berrange
e1d2e325dd
Add public API for storage management
2008-02-20 14:57:39 +00:00
Mark McLoughlin
3da5504e68
Fix gcc-4.3.0 "inlining failed" warning.
...
* src/internal.h: move xstrol() variants from here ...
* src/util.[ch]: ... to here and rename to virStrToLong()
* src/libvirt_sym.version: export __virStrToLong_i() for
virsh and qemud.
* src/nodeinfo.c, src/stats_linux.c, src/virsh.c,
src/xend_internal.c, qemud/qemud.c: replace xstrtol()
calls with virStrToLong()
* src/nodeinfo.h: don't include internal.h, which was only
needed for xstrtol(), but instead include libvirt.h which
is suffificient for the declarations in the header.
2008-02-08 09:15:16 +00:00
Daniel Veillard
e9b3bc773d
virHashRemoveSet bugfixes
...
* src/hash.c: fix a couple of problems in virHashRemoveSet based
on Hiroyuki Kaguchi patch and explanations.
Daniel
2008-02-07 16:56:01 +00:00
Jim Meyering
247df6e448
Mark all qemudLog diagnostics for translation.
...
* po/POTFILES.in: Add names of many new files.
* Makefile.maint (err_func_re): Add qemudLog.
Mark diagnostics with _(...). Split some long lines.
* qemud/qemud.c (remoteCheckCertFile, remoteInitializeGnuTLS):
(qemudDispatchSignalEvent, qemudSetCloseExec, qemudSetNonBlock):
(qemudWritePidFile, qemudListenUnix, remoteMakeSockets):
(remoteListenTCP, qemudInitPaths, qemudInitialize):
(qemudNetworkInit, remoteInitializeTLSSession, remoteCheckDN):
(remoteCheckCertificate, remoteCheckAccess, qemudDispatchServer):
(qemudClientReadBuf, qemudDispatchClientRead):
(qemudClientWriteBuf, qemudDispatchClientWrite, qemudOneLoop):
(remoteConfigGetStringList, checkType, GET_CONF_STR):
(remoteConfigGetAuth, remoteReadConfigFile, main):
* qemud/remote.c (remoteDispatchAuthSaslInit, remoteSASLCheckSSF):
(remoteSASLCheckAccess, remoteDispatchAuthSaslStart):
(remoteDispatchAuthSaslStep, remoteDispatchAuthSaslInit):
(remoteDispatchAuthSaslStart, remoteDispatchAuthSaslStep):
(qemudGetSocketIdentity, remoteDispatchAuthPolkit):
* src/iptables.c (notifyRulesUpdated, MAX_FILE_LEN, iptRulesSave):
(iptRulesReload):
* src/qemu_conf.c (qemudExtractVersionInfo, qemudLoadConfig):
(qemudLoadNetworkConfig, qemudScanConfigDir):
* src/qemu_driver.c (qemudSetCloseExec, qemudSetNonBlock):
(qemudAutostartConfigs, qemudStartup, qemudReload):
(qemudWaitForMonitor, qemudStartVMDaemon, qemudVMData):
(qemudShutdownVMDaemon, qemudStartNetworkDaemon):
(qemudShutdownNetworkDaemon, qemudMonitorCommand):
(qemudDomainUndefine, qemudNetworkUndefine):
* src/uuid.c (virUUIDGenerate):
* src/xm_internal.c (xenXMAttachInterface):
2008-02-07 16:50:17 +00:00
Jim Meyering
e8ff93b4e6
Remove more useless if tests before "free"-like functions.
...
* build-aux/useless-if-before-free: Rename from ...
* build-aux/find-unnecessary-if-before-free: ... this. Remove file.
Also changed it so that new names are no longer hard-coded in the
script. Instead, they're supplied via options:
* Makefile.cfg (useless_free_options): Define.
Add xmlXPathFreeObject to the list of free-like functions it detects.
* Makefile.maint (sc_avoid_if_before_free): Reflect script renaming.
* .x-sc_avoid_if_before_free: Likewise.
* src/openvz_conf.c (openvzParseXML): Remove useless "if"-before-free.
* src/qemu_conf.c (qemudParseXML, qemudParseNetworkXML): Likewise.
* src/virsh.c (cmdVNCDisplay, cmdTTYConsole, cmdDetachInterface):
(cmdDetachDisk): Likewise.
* src/xm_internal.c (xenXMConfigSetIntFromXPath): Likewise.
(xenXMConfigSetStringFromXPath, xenXMParseXMLToConfig): Likewise.
(xenXMDomainAttachDevice, xenXMAttachDisk, xenXMAttachInterface):
(xenXMDomainDetachDevice): Likewise.
* src/xml.c (virXPathString): Likewise.
* tests/xmlrpctest.c (checkRequestValue): Likewise.
2008-02-07 16:49:29 +00:00
Jim Meyering
5a93214143
Remove trailing blanks
2008-02-07 12:34:19 +00:00
Mark McLoughlin
a0f83fd905
* src/xen_internal.c: Don't crash if there's no /sys/hypervisor/capabilities
2008-02-07 10:43:14 +00:00
Mark McLoughlin
3d3c8ac4c4
src/iptables.c: Create directory for saving iptables rules
2008-02-07 10:17:24 +00:00
Mark McLoughlin
f90cd4c3f4
src/xm_internal.[ch]: Move static function prototype from header
2008-02-07 10:14:43 +00:00
Daniel Veillard
b33f740e1f
* src/libvirt.c: fix bug in xenUnifiedDomainSuspend() patch provided
...
by Marcus Meissner
Daniel
2008-02-07 09:37:10 +00:00
Daniel Veillard
594af3eb22
add/change/delete a Disk/NIC of an inactive domains
...
* src/xm_internal.[ch]: applied patch from Shigeki Sakamoto to
add/change/delete a Disk/NIC of an inactive domains
Daniel
2008-02-06 17:57:10 +00:00
Daniel Veillard
eecd68364a
QEmu config error handling fixes
...
* src/qemu_conf.c: applied 2 patches from Guido Guenther to avoid
crashes when reading the config file
Daniel
2008-02-06 16:24:28 +00:00
Jim Meyering
5419d0b44d
Fix new "make distcheck" failures.
...
* src/xml.c (virDomainParseXMLOSDescHVM): Mark a diagnostic.
2008-02-05 22:07:31 +00:00
Jim Meyering
e04912a9f0
Remove all trailing blanks; turn on the rule to detect them.
...
* Makefile.cfg (local-checks-to-skip): Remove sc_trailing_blank.
* .x-sc_trailing_blank: New file, to exempt the few binary files.
2008-02-05 19:27:37 +00:00
Daniel P. Berrange
e87e3f86bf
Added support for booting off kenrel+initrd with HVM guests
2008-02-05 16:21:25 +00:00
Jim Meyering
fb66d5ab92
Eliminate all uses of virBufferAdd with string literals.
...
* Makefile.maint (sc_prohibit_virBufferAdd_with_string_literal):
New rule.
* src/buf.h (virBufferAddLit): Define.
* src/conf.c (virConfSaveValue): Use virBufferAddLit, in place
of virBufferAdd everywhere possible.
(virConfSaveEntry): Likewise.
* src/qemu_conf.c (qemudGenerateXML, qemudGenerateNetworkXML): Likewise.
* src/qemu_driver.c (qemudGetFeatures, qemudGetCapabilities): Likewise.
* src/test.c (testDomainDumpXML, testNetworkDumpXML): Likewise.
* src/xen_internal.c (xenHypervisorMakeCapabilitiesXML): Likewise.
* src/xend_internal.c (xend_parse_sexp_desc_os): Likewise.
(xend_parse_sexp_desc, sexpr_to_xend_topology_xml): Likewise.
* src/xm_internal.c (xenXMDomainFormatXML, xenXMDomainPinVcpu): Likewise.
* src/xml.c (virSaveCpuSet, virParseXenCpuTopology): Likewise.
(virDomainParseXMLGraphicsDescImage): Likewise.
(virDomainParseXMLGraphicsDescVFB, virDomainParseXMLOSDescHVM): Likewise.
(virDomainParseXMLOSDescPV, virDomainParseXMLDiskDesc): Likewise.
(virDomainParseXMLIfDesc, virDomainParseXMLDesc): Likewise.
2008-02-05 14:22:28 +00:00
Jim Meyering
ecaa696250
Enable more checks for unmarked messages; fix violators.
...
* Makefile.maint (sc_unmarked_diagnostics): Check for more functions.
* src/conf.c (virConfParseValue): Remove trailing space in diagnostic.
* src/libvirt.c (do_open, virDomainMigrate): Mark diagnostics.
* src/xend_internal.c (do_connect, xenDaemonDomainDumpXMLByID): Likewise.
(xenDaemonDomainDumpXMLByName, xenDaemonCreateLinux): Likewise.
(xenDaemonDomainMigratePerform, xenDaemonDomainDefineXML): Likewise.
* src/xml.c (virXPathString, virXPathNumber, virXPathLong): Likewise.
(virXPathBoolean, virXPathNode, virXPathNodeSet): Likewise.
(virDomainParseXMLOSDescHVM): Likewise.
* src/xmlrpc.c (xmlRpcValueNew): Likewise.
(xmlRpcValueUnmarshalDictElement): Likewise.
2008-02-04 19:31:30 +00:00
Jim Meyering
e99570fc77
Mark a string for translation.
...
* src/virsh.c: Add a "%s" and wrap with _(...).
2008-02-04 14:58:47 +00:00
Jim Meyering
70400346d2
Enable the sc_unmarked_diagnostics test and correct all violations
...
involving the "error" function.
* Makefile.cfg (local-checks-to-skip): Remove from skip list.
* src/remote_internal.c: Mark translatable strings.
2008-02-04 14:58:05 +00:00
Jim Meyering
f5f530f33f
Avoid virsh leaks due to missing virDomainFree(dom) calls
...
* src/virsh.c (cmdDomuuid): Add missing virDomainFree call.
(cmdAttachDevice): Likewise.
(cmdDetachDevice): Likewise.
2008-01-30 19:58:59 +00:00
Jim Meyering
a1d2d2b21c
src/virsh.c (cmdCapabilities): Plug a small leak.
2008-01-30 19:57:54 +00:00
Jim Meyering
34dff95bfd
src/test.c (testLoadDomain): Avoid leaks upon failure.
2008-01-30 19:57:13 +00:00
Jim Meyering
1217e5d516
Avoid used-uninitialized errors in test driver.
...
* src/test.c (testOpenFromFile): Initialize "privconn".
2008-01-30 19:54:29 +00:00
Jim Meyering
6997b1920f
src/libvirt.c (do_open): Avoid double-free upon failure.
2008-01-30 19:53:10 +00:00
Jim Meyering
218f866f86
Avoid segfault upon malloc failure, and plug a leak.
...
* src/test.c (testDomainSave): Detect testDomainDumpXML failure. Free "xml".
2008-01-30 19:52:16 +00:00
Jim Meyering
5561e9125f
Plug test-related leaks.
...
* src/test.c (testLoadNetwork): Free forwardDev.
(testLoadDomain): Free ctxt.
(testLoadNetwork): Likewise.
(testOpenFromFile): Likewise.
2008-01-30 19:50:14 +00:00
Daniel P. Berrange
17ef6faa7f
Remove double mutex lock()
2008-01-30 18:21:13 +00:00
Daniel P. Berrange
03003499e7
Fix XML generation for Xen USB devices
2008-01-30 16:38:18 +00:00
Daniel P. Berrange
21416a4746
Fix device name -> number conversion for block stats
2008-01-29 18:36:00 +00:00
Jim Meyering
2367caa327
Also detect and remove unnecessary if-before-xmlXPathFreeContext.
...
* build-aux/find-unnecessary-if-before-free: Update regexp.
* src/openvz_conf.c: Remove unnecessary "if (P)"-before xmlXPathFreeContext.
* src/qemu_conf.c: Likewise.
* src/virsh.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* tests/xmlrpctest.c: Likewise.
2008-01-29 18:23:43 +00:00
Jim Meyering
a378188194
Enable the <config.h>-requiring test; fix violations
...
Use <config.h>, not "config.h", per autoconf documentation.
* Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
* .x-sc_require_config_h: New file, to list exempted files.
* Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
2008-01-29 18:15:54 +00:00
Jim Meyering
acff2d11ac
Given code like if (foo) free (foo); remove the useless "if (foo) " part.
...
Likewise, given if (foo != NULL) free (foo); remove the useless "if" test.
* proxy/libvirt_proxy.c: Remove unnecessary "if" test before free.
* python/generator.py: Likewise.
* qemud/qemud.c: Likewise.
* src/buf.c: Likewise.
* src/conf.c: Likewise.
* src/hash.c: Likewise.
* src/iptables.c: Likewise.
* src/libvirt.c: Likewise.
* src/openvz_conf.c: Likewise.
* src/qemu_conf.c: Likewise.
* src/qemu_driver.c: Likewise.
* src/remote_internal.c: Likewise.
* src/test.c: Likewise.
* src/virsh.c: Likewise.
* src/virterror.c: Likewise.
* src/xen_internal.c: Likewise.
* src/xen_unified.c: Likewise.
* src/xend_internal.c: Likewise.
* src/xm_internal.c: Likewise.
* src/xml.c: Likewise.
* src/xmlrpc.c: Likewise.
* src/xs_internal.c: Likewise.
* tests/testutils.c: Likewise.
* tests/xencapstest.c: Likewise.
* tests/xmconfigtest.c: Likewise.
2008-01-29 17:41:07 +00:00
Daniel Veillard
aab826d4cc
Fix VIR_DOMAIN_NONE into VIR_DOMAIN_NOSTATE
...
* src/xen_internal.c: fix an erronous use of VIR_DOMAIN_NONE instead
of VIR_DOMAIN_NOSTATE (both defined as 0, no regression)
Daniel
2008-01-25 09:47:51 +00:00
Daniel Veillard
3f9a94bec3
* src/libvirt.c: Jay Gagnon pointed out that virDomainGetXMLDesc
...
was failing with a non-zero flag value
Daniel
2008-01-24 17:09:56 +00:00
Richard W.M. Jones
9cf2573c8a
Portability improvements for Mac OS X.
...
* configure.in: Use PortableXDR if available.
* qemud/internal.h: Use "socketcompat.h".
* qemud/qemud.c: Use <signal.h>.
* src/sexpr.c: Use <stdlib.h> instead of <malloc.h>.
* src/socketcompat.h: Include <sys/un.h> for Mac OS X.
2008-01-23 14:54:41 +00:00
Richard W.M. Jones
569200b6d4
Remove DOS line-endings.
...
* src/socketcompat.h: Remove DOS line-endings in this file.
2008-01-23 14:50:14 +00:00
Daniel P. Berrange
9d7661e415
Fix compat for old pkg-config and gnutls
2008-01-22 21:30:05 +00:00
Daniel P. Berrange
97bed42f7a
Fix & refactor ref counting cleanup code
2008-01-21 16:29:10 +00:00
Daniel P. Berrange
45738083a6
Use virFileReadAll in virsh.c
2008-01-21 15:27:14 +00:00
Daniel P. Berrange
53365f4c54
Remove no-op networking APIs from openvz driver
2008-01-21 15:19:46 +00:00
Jim Meyering
64b3019d69
Adjust sexpr-related interfaces to be const-correct.
...
* src/sexpr.c (sexpr_cons, append, sexpr_append, sexpr2string)
(sexpr_lookup_key, sexpr_lookup, sexpr_node, sexpr_fmt_node):
Add "const" attribute where appropriate.
* src/xend_internal.c (sexpr_int, sexpr_float, sexpr_u64)
(sexpr_uuid, sexpr_to_xend_domain_info, sexpr_to_xend_node_info)
(sexpr_to_xend_topology_xml, sexpr_to_domain): Likewise.
* src/sexpr.h: Adjust prototypes.
2008-01-21 14:22:15 +00:00
Jim Meyering
a430f22be4
Don't access line[-1] for a zero-length "line" from fgets.
...
A NUL byte at beginning of input, or just after a newline
would provoke an invalid buf[-1] access (possible segfault).
* src/libvirt.c (virConnectAuthCallbackDefault):
2008-01-21 14:09:51 +00:00
Daniel Veillard
5912e7c233
Preserve vif order
...
* src/xml-internal.c: apply patch from Hiroyuki Kaguchi to
preserve the vif list order.
Daniel
2008-01-21 08:27:12 +00:00
Daniel P. Berrange
d56aff5255
Added xstrtol_ll and xstrtol_ull convenience functions
2008-01-20 16:11:25 +00:00
Daniel P. Berrange
e05a879022
Fix nodeinfo compat for Xen 3.2.0
2008-01-20 15:56:49 +00:00
Daniel P. Berrange
e8d690aeb5
Enable debug by default, but only if LIBVIRT_DEBUG=1. Use generic macro for debug output
2008-01-19 18:36:01 +00:00
Jim Meyering
42e5d20ae9
Avoid format string warnings.
...
* src/virsh.c: Add "%s" where needed.
* src/proxy_internal.c: Likewise.
2008-01-16 17:13:23 +00:00
Daniel P. Berrange
f6ba6e9eb7
Support VNC keymap option with QEMU (Daniel Hokka Zakrisson)
2008-01-15 15:18:33 +00:00
Daniel P. Berrange
045d32a8e8
Fix off-by-one in SSH argv checking. Fix format string warning
2008-01-15 14:23:52 +00:00
Jim Meyering
2edab512a0
Clean up the global name space.
...
* src/qemu_conf.c: Add "static" and "const" attributes to some globals.
* src/qemu_conf.h: Update a declaration.
* src/qemu_driver.c (qemud_driver): Declare static.
Author: Jim Meyering <meyering@redhat.com>
2008-01-14 14:05:25 +00:00
Daniel P. Berrange
6aae9a9efb
Re-factor auth code to make clearer (Jim Meyering)
2008-01-14 04:05:23 +00:00
Daniel P. Berrange
b2083ea907
Fix crash when no auth callback
2008-01-14 04:00:34 +00:00
Mark McLoughlin
4c50142381
fix an unused variable warning
2008-01-10 14:41:39 +00:00
Mark McLoughlin
73ab4e0845
add iptablesSaveRules(), and don't save the rules to disk
...
and run lokkit each time a new rule is added.
2008-01-10 14:01:00 +00:00
Mark McLoughlin
2d2e410818
now that we only use built-in iptables chains, we don't
...
need to add or delete them
2008-01-10 13:58:59 +00:00
Mark McLoughlin
9b29b2a2a5
Like --with-iptables-prefix, --with-iptables-dir is no
...
longer useful, so let's remove it.
2008-01-10 13:57:48 +00:00
Mark McLoughlin
f8e0674ad5
--with-iptables-prefix was added to integrate with
...
a proposed system for letting iptables know how to
reload our rules. The proposed system wasn't accepted
so, although there might be some other theoretical
use for this, let's just remove it.
2008-01-10 13:56:22 +00:00
Mark McLoughlin
b9daf6d9dd
Add support for integrating our iptables support with Fedora's
...
iptables configuration using the lokkit --custom-rules command.
Basically, we write out our rules to /var/lib/libvirt/iptables
and run lokkit --custom-rules so that if e.g. iptables is
restarted or the user edits their firewall configuration, then
libvirt's rules get reloaded.
2008-01-10 13:54:02 +00:00
Mark McLoughlin
a43ddc075a
Include the iptables command and chain name in the saved rules files
2008-01-10 13:51:55 +00:00
Mark McLoughlin
9d04c25ab2
Re-name the "flipflop" variable to "command_idx"
2008-01-10 13:50:46 +00:00
Mark McLoughlin
cc83cda045
make use of virFileMakePath(), virFileBuildPath() and virRun().
2008-01-10 13:49:55 +00:00
Mark McLoughlin
fc11528f98
Fix compile error in --with-iptables-dir code
2008-01-10 13:48:44 +00:00