mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-11 20:35:46 +00:00
GCC 10 complains about variables may be used uninitialized. Even though it might be false positives, we can easily avoid them. Avoiding ../src/storage/storage_backend_iscsi_direct.c:634:11: error: ‘nb_block’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 634 | while (lba < nb_block) { | ^ ../src/storage/storage_backend_iscsi_direct.c:619:14: note: ‘nb_block’ was declared here 619 | uint64_t nb_block; | ^~~~~~~~ ../src/storage/storage_backend_iscsi_direct.c:637:16: error: ‘block_size’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 637 | task = iscsi_write16_sync(iscsi, lun, lba, data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 638 | block_size * to_write, | ~~~~~~~~~~~~~~~~~~~~~~ 639 | block_size, 0, 0, 0, 0, 0); | ~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/storage/storage_backend_iscsi_direct.c:618:14: note: ‘block_size’ was declared here 618 | uint32_t block_size; | ^~~~~~~~~~ ../src/storage/storage_backend_iscsi_direct.c: In function ‘virStorageBackendISCSIDirectRefreshPool’: ../src/storage/storage_backend_iscsi_direct.c:320:39: error: ‘nb_block’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 320 | vol->target.capacity = block_size * nb_block; | ~~~~~~~~~~~^~~~~~~~~~ ../src/storage/storage_backend_iscsi_direct.c:306:14: note: ‘nb_block’ was declared here 306 | uint64_t nb_block; | ^~~~~~~~ ../src/storage/storage_backend_iscsi_direct.c:320:39: error: ‘block_size’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 320 | vol->target.capacity = block_size * nb_block; | ~~~~~~~~~~~^~~~~~~~~~ ../src/storage/storage_backend_iscsi_direct.c:305:14: note: ‘block_size’ was declared here 305 | uint32_t block_size; | ^~~~~~~~~~ Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com> Reviewed-by: Marc Hartmayer <mhartmay@linux.ibm.com> Reviewed-by: Erik Skultety <eskultet@redhat.com> |
||
---|---|---|
.. | ||
access | ||
admin | ||
bhyve | ||
conf | ||
cpu | ||
cpu_map | ||
esx | ||
hyperv | ||
hypervisor | ||
interface | ||
keycodemapdb@27acf0ef82 | ||
libxl | ||
locking | ||
logging | ||
lxc | ||
network | ||
node_device | ||
nwfilter | ||
openvz | ||
qemu | ||
remote | ||
rpc | ||
secret | ||
security | ||
storage | ||
test | ||
util | ||
vbox | ||
vmware | ||
vmx | ||
vz | ||
admin_protocol-structs | ||
datatypes.c | ||
datatypes.h | ||
driver-hypervisor.h | ||
driver-interface.h | ||
driver-network.h | ||
driver-nodedev.h | ||
driver-nwfilter.h | ||
driver-secret.h | ||
driver-state.h | ||
driver-storage.h | ||
driver-stream.h | ||
driver.c | ||
driver.h | ||
internal.h | ||
libvirt_driver_modules.syms | ||
libvirt_esx.syms | ||
libvirt_internal.h | ||
libvirt_libssh2.syms | ||
libvirt_libssh.syms | ||
libvirt_linux.syms | ||
libvirt_lxc.syms | ||
libvirt_openvz.syms | ||
libvirt_private.syms | ||
libvirt_probes.d | ||
libvirt_public.syms | ||
libvirt_qemu.syms | ||
libvirt_remote.syms | ||
libvirt_sasl.syms | ||
libvirt_vmware.syms | ||
libvirt_vmx.syms | ||
libvirt-domain-checkpoint.c | ||
libvirt-domain-snapshot.c | ||
libvirt-domain.c | ||
libvirt-host.c | ||
libvirt-interface.c | ||
libvirt-lxc.c | ||
libvirt-lxc.pc.in | ||
libvirt-network.c | ||
libvirt-nodedev.c | ||
libvirt-nwfilter.c | ||
libvirt-qemu.c | ||
libvirt-qemu.pc.in | ||
libvirt-secret.c | ||
libvirt-storage.c | ||
libvirt-stream.c | ||
libvirt.c | ||
libvirt.conf | ||
libvirt.pc.in | ||
lock_protocol-structs | ||
lxc_monitor_protocol-structs | ||
lxc_protocol-structs | ||
meson.build | ||
qemu_protocol-structs | ||
README | ||
remote_protocol-structs | ||
virkeepaliveprotocol-structs | ||
virnetprotocol-structs |
libvirt library code README =========================== The directory provides the bulk of the libvirt codebase. Everything except for the libvirtd daemon and client tools. The build uses a large number of libtool convenience libraries - one for each child directory, and then links them together for the final libvirt.so, although some bits get linked directly to libvirtd daemon instead. The files directly in this directory are supporting the public API entry points & data structures. There are two core shared modules to be aware of: * util/ - a collection of shared APIs that can be used by any code. This directory is always in the include path for all things built * conf/ - APIs for parsing / manipulating all the official XML files used by the public API. This directory is only in the include path for driver implementation modules * vmx/ - VMware VMX config handling (used by esx/ and vmware/) Then there are the hypervisor implementations: * bhyve - bhyve - The BSD Hypervisor * esx/ - VMware ESX and GSX support using vSphere API over SOAP * hyperv/ - Microsoft Hyper-V support using WinRM * lxc/ - Linux Native Containers * openvz/ - OpenVZ containers using cli tools * qemu/ - QEMU / KVM using qemu CLI/monitor * remote/ - Generic libvirt native RPC client * test/ - A "mock" driver for testing * vbox/ - Virtual Box using native API * vmware/ - VMware Workstation and Player using the vmrun tool * xen/ - Xen using hypercalls, XenD SEXPR & XenStore Finally some secondary drivers that are shared for several HVs. Currently these are used by LXC, OpenVZ, QEMU and Xen drivers. The ESX, Hyper-V, Remote, Test & VirtualBox drivers all implement the secondary drivers directly * cpu/ - CPU feature management * interface/ - Host network interface management * network/ - Virtual NAT networking * nwfilter/ - Network traffic filtering rules * node_device/ - Host device enumeration * secret/ - Secret management * security/ - Mandatory access control drivers * storage/ - Storage management drivers Since both the hypervisor and secondary drivers can be built as dlopen()able modules, it is *FORBIDDEN* to have build dependencies between these directories. Drivers are only allowed to depend on the public API, and the internal APIs in the util/ and conf/ directories