libvirt/src
Michal Privoznik 5a4c2374a2 qemu: Avoid double free of VM
One of my previous patches (c7ac2519b7) did try to fix the issue when
domain dies too soon during migration. However, this clumsy approach was
missing removal of qemuProcessHandleMonitorDestroy resulting in double
unrefing of mon->vm and hence producing the daemon crash:

==11843== Invalid read of size 4
==11843==    at 0x50C28C5: virObjectUnref (virobject.c:255)
==11843==    by 0x1148F7DB: qemuMonitorDispose (qemu_monitor.c:258)
==11843==    by 0x50C2991: virObjectUnref (virobject.c:262)
==11843==    by 0x50C2D13: virObjectFreeCallback (virobject.c:388)
==11843==    by 0x509C37B: virEventPollCleanupHandles (vireventpoll.c:583)
==11843==    by 0x509C711: virEventPollRunOnce (vireventpoll.c:652)
==11843==    by 0x509A620: virEventRunDefaultImpl (virevent.c:274)
==11843==    by 0x520D21C: virNetServerRun (virnetserver.c:1112)
==11843==    by 0x11F368: main (libvirtd.c:1513)
==11843==  Address 0x13b88864 is 4 bytes inside a block of size 136 free'd
==11843==    at 0x4A07F5C: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==11843==    by 0x5079A2F: virFree (viralloc.c:580)
==11843==    by 0x50C29E3: virObjectUnref (virobject.c:270)
==11843==    by 0x114770E4: qemuProcessHandleMonitorDestroy (qemu_process.c:1103)
==11843==    by 0x1148F7CB: qemuMonitorDispose (qemu_monitor.c:257)
==11843==    by 0x50C2991: virObjectUnref (virobject.c:262)
==11843==    by 0x50C2D13: virObjectFreeCallback (virobject.c:388)
==11843==    by 0x509C37B: virEventPollCleanupHandles (vireventpoll.c:583)
==11843==    by 0x509C711: virEventPollRunOnce (vireventpoll.c:652)
==11843==    by 0x509A620: virEventRunDefaultImpl (virevent.c:274)
==11843==    by 0x520D21C: virNetServerRun (virnetserver.c:1112)
==11843==    by 0x11F368: main (libvirtd.c:1513)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2013-11-08 07:31:02 +01:00
..
access Avoid Coverity DEADCODE warning 2013-10-24 06:40:18 -04:00
conf conf: fix incorrect error log in virCPUDefIsEqual 2013-11-07 12:01:29 +01:00
cpu cpu: x86: Parse the CPU feature map only once 2013-11-04 11:51:09 +01:00
esx Fix a problem introduced by commit 99889012 2013-10-18 12:44:05 -06:00
hyperv Convert 'int i' to 'size_t i' in src/hyperv/ files 2013-07-10 17:55:16 +01:00
interface netcf: Don't complain when cleanup is called before init 2013-10-18 14:31:51 +02:00
libxl libxl: fix dubious cpumask handling in libxlDomainSetVcpuAffinities 2013-11-01 09:05:36 -06:00
locking Remove (nearly) all use of getuid()/getgid() 2013-10-21 14:03:52 +01:00
lxc Skip any files which are not mounted on the host 2013-11-05 15:51:48 +08:00
network network: fix connections count in case of allocate failure 2013-11-06 13:14:57 +02:00
node_device nodedev_hal: fix segfault when virDBusGetSystemBus fails 2013-10-31 11:21:10 -06:00
nwfilter maint: avoid 'const fooPtr' in nwfilter files 2013-10-14 13:13:18 -06:00
openvz maint: avoid 'const fooPtr' in domain_conf 2013-10-14 14:34:38 -06:00
parallels cleanup: Kill usage of access(PATH, F_OK) in favor of virFileExists() 2013-09-16 10:37:39 +02:00
phyp Convert 'int i' to 'size_t i' in src/phyp/ files 2013-07-10 17:55:15 +01:00
qemu qemu: Avoid double free of VM 2013-11-08 07:31:02 +01:00
remote Remove (nearly) all use of getuid()/getgid() 2013-10-21 14:03:52 +01:00
rpc virnetsocket: fix getsockopt on FreeBSD 2013-11-03 17:08:55 -06:00
secret Convert 'int i' to 'size_t i' in src/secret/ files 2013-07-10 17:40:14 +01:00
security maint: avoid further typedef accidents 2013-10-30 17:02:12 -06:00
storage storage: always probe type with buffer 2013-11-06 17:31:51 -07:00
test test driver: add support for .connectBaselineCPU 2013-11-06 15:01:17 -07:00
uml maint: avoid 'const fooPtr' in all remaining places 2013-10-14 14:34:38 -06:00
util storage: always probe type with buffer 2013-11-06 17:31:51 -07:00
vbox Remove (nearly) all use of getuid()/getgid() 2013-10-21 14:03:52 +01:00
vmware VMware: Do version detection earlier 2013-10-11 09:10:23 -05:00
vmx esx: Fix floppy.fileName handling in the vmx file parser 2013-10-15 11:39:02 +01:00
xen maint: avoid 'const fooPtr' in all remaining places 2013-10-14 14:34:38 -06:00
xenapi xenapi: fix coding style in xenapi_driver.c 2013-10-31 14:53:05 +01:00
xenxs Fix double free of hostdev on OOM in xenParseSxprPCI 2013-09-25 18:12:08 +01:00
check-aclperms.pl Fix naming of permission for detecting storage pools 2013-09-12 17:20:07 +01:00
check-aclrules.pl Extend the ACL test case to validate filter rule checks 2013-07-03 15:54:54 +01:00
check-driverimpls.pl Skip virNWFilterTechDriver when validating API naming 2013-05-09 17:09:59 +01:00
check-drivername.pl Extend previous check to validate driver struct field names 2013-04-24 10:59:53 +01:00
check-symfile.pl maint: use LGPL correctly 2013-05-20 14:03:48 -06:00
check-symsorting.pl maint: use LGPL correctly 2013-05-20 14:03:48 -06:00
datatypes.c Fix crash if OOM occurs when creating virConnectPtr 2013-09-24 10:51:28 +01:00
datatypes.h Rename 'DeviceMonitor' to 'NodeDeviceDriver' 2013-04-24 10:59:53 +01:00
driver.c Remove all direct use of getenv 2013-10-21 14:03:52 +01:00
driver.h libvirt: add new public API virConnectGetCPUModelNames 2013-09-23 15:41:50 -06:00
dtrace2systemtap.pl maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
fdstream.c Always open files in binary mode in virFDStreamOpenFileInternal 2013-09-24 14:27:41 +02:00
fdstream.h Allow the iohelper path to be customized by test programs 2013-05-10 19:57:18 +01:00
gnutls_1_0_compat.h maint: don't use config.h in .h files 2013-06-05 05:53:25 -06:00
internal.h maint: use LGPL correctly 2013-05-20 14:03:48 -06:00
libvirt_atomic.syms maint: check all symfiles for sorting 2013-02-22 16:48:12 -07:00
libvirt_daemon.syms maint: make it easier to sort syms files 2013-01-25 08:33:09 -07:00
libvirt_driver_modules.syms maint: one missed syms file 2013-01-26 09:59:12 -07:00
libvirt_esx.syms maint: enforce private symbol section sorting 2013-02-20 08:27:03 -07:00
libvirt_gnutls.syms Add APIs to get at more client security data 2013-03-19 13:11:46 +00:00
libvirt_internal.h New internal migration APIs with extensible parameters 2013-06-25 01:13:16 +02:00
libvirt_libssh2.syms maint: enforce private symbol section sorting 2013-02-20 08:27:03 -07:00
libvirt_linux.syms maint: enforce private symbol section sorting 2013-02-20 08:27:03 -07:00
libvirt_lxc.syms Apply security label when entering LXC namespaces 2013-03-13 15:16:37 +00:00
libvirt_openvz.syms maint: enforce private symbol section sorting 2013-02-20 08:27:03 -07:00
libvirt_private.syms storage: always probe type with buffer 2013-11-06 17:31:51 -07:00
libvirt_probes.d Re-add DTrace probes on 'dispose' functions 2013-03-14 12:42:21 +00:00
libvirt_public.syms libvirt: add new public API virConnectGetCPUModelNames 2013-09-23 15:41:50 -06:00
libvirt_qemu_probes.d build: fix binary location in stap files --with-driver-modules 2012-08-10 23:11:26 -04:00
libvirt_qemu.syms qemu-agent: available in 0.10.0 2012-08-23 13:05:52 -06:00
libvirt_remote.syms build: fix build --without-remote 2013-10-04 17:01:47 -06:00
libvirt_sasl.syms Add APIs to get at more client security data 2013-03-19 13:11:46 +00:00
libvirt_vmware.syms VMware: Make version parsing testable and add tests 2013-09-20 08:23:31 -05:00
libvirt_vmx.syms VMX: Create virVMXFormatDisk() from HD and CD-ROM 2013-09-01 23:11:50 -05:00
libvirt_xenxs.syms maint: enforce private symbol section sorting 2013-02-20 08:27:03 -07:00
libvirt-lxc.c Ensure LXC/QEMU APIs set the filename for errors 2013-08-02 15:32:26 +01:00
libvirt-qemu.c Ensure LXC/QEMU APIs set the filename for errors 2013-08-02 15:32:26 +01:00
libvirt.c libvirt.c: indent code of virDomainGetMemoryParameters's documentation 2013-10-30 17:30:12 +01:00
libvirt.conf Allow overriding default URI in config file 2012-03-15 11:20:17 +00:00
lock_protocol-structs tests: check remaining .x files 2013-09-09 12:04:03 -06:00
lxc_monitor_protocol-structs tests: check remaining .x files 2013-09-09 12:04:03 -06:00
lxc_protocol-structs build: add new file, for lxc_protocol checking 2013-01-15 12:01:22 -07:00
Makefile.am virt-login-shell: also build virAtomic.h 2013-11-05 19:44:27 +01:00
nodeinfo.c nodeinfo: fix build on non-Linux 2013-11-06 17:36:44 -07:00
nodeinfo.h Separate internal node device APIs from public API 2013-05-08 10:47:47 +01:00
qemu_protocol-structs Make naming of remote procedures match API names exactly 2013-04-24 10:33:10 +01:00
README hyperv: Add basic documentation 2011-08-26 17:52:55 +02:00
remote_protocol-structs virConnectGetCPUModelNames: implement the remote protocol 2013-09-23 15:50:35 -06:00
virkeepaliveprotocol-structs build: Properly generate and check virkeepaliveprotocol-structs 2011-11-24 14:44:04 +01:00
virnetprotocol-structs Extend RPC protocol to allow FD passing 2011-10-28 10:27:15 +01:00

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories