External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-20 13:09:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
70d75ffc79
libvirt/tests
History
Michal Privoznik 70d75ffc79 qemuBuildMemoryBackendStr: Honour passed @pagesize 
So far the argument has not much meaning and was practically ignored.
This is not good since when doing memory hotplug, the size of desired
hugepage backing is passed in that argument. Taking closer look at the
tests I'm fixing reveals the bug. For instance, while the following is
in the test:

    <memory model='dimm'>
      <source>
        <nodemask>1-3</nodemask>
        <pagesize unit='KiB'>4096</pagesize>
      </source>
      <target>
        <size unit='KiB'>524287</size>
        <node>0</node>
      </target>
      <address type='dimm' slot='0' base='0x100000000'/>
    </memory>

the generated commandline corresponding to this XML was:

    -object memory-backend-ram,id=memdimm0,size=536870912,\
    host-nodes=1-3,policy=bind

Have you noticed? Yes, memory-backend-ram! Nothing can be further away
from the right answer. The hugepage backing is requested in the XML
and we happily ignore it. This is just not right. It's
memory-backend-file which should have been used:

    -object memory-backend-file,id=memdimm0,prealloc=yes,\
    mem-path=/dev/hugepages4M/libvirt/qemu,size=536870912,\
    host-nodes=1-3,policy=bind

The problem is, that @pagesize passed to qemuBuildMemoryBackendStr
(where this part of commandline is built) was ignored. The hugepage to
back memory was searched only and only by NUMA nodes pinning. This
works only for regular guest NUMA nodes.

Then, I'm changing the hugepages size in the test XMLs too. This is
simply because in the test suite we create dummy mount points just for
2M and 1G hugepages. And in the test 4M was requested. I'm sticking to
2M, but 1G should just work too.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2015-06-26 09:23:06 +02:00
..
bhyvexml2argvdata
bhyvexml2xmloutdata
capabilityschemadata
commanddata
confdata Add configuration options for permissions on daemon's admin socket 2015-06-16 13:46:21 +02:00
cputestdata cpu: Add {Haswell,Broadwell}-noTSX CPU models 2015-03-26 09:19:59 +01:00
domaincapsschemadata
domainconfdata
domainschemadata conf: Add support for parsing and formatting max memory and slot count 2015-03-23 14:25:14 +01:00
domainsnapshotxml2xmlin conf: split <disk> schema into more pieces 2014-04-16 10:45:55 +02:00
domainsnapshotxml2xmlout
fchostdata/fc_host
interfaceschemadata interface: allow multiple IPv4 addresses + dhcp on a single interface 2015-05-22 10:14:01 -04:00
lxcconf2xmldata
lxcxml2xmldata
lxcxml2xmloutdata
networkxml2confdata network: escape quotes for dsmasq conf contents 2015-06-09 13:56:00 -04:00
networkxml2firewalldata
networkxml2xmlin
networkxml2xmlout
networkxml2xmlupdatein network: validate DHCP ranges are completely within defined network 2015-06-02 12:40:07 -04:00
networkxml2xmlupdateout network: validate DHCP ranges are completely within defined network 2015-06-02 12:40:07 -04:00
nodedevschemadata
nodeinfodata nodeinfodata: Remove broken symlinks and uneeded files 2015-04-02 11:12:01 +02:00
nwfilterxml2firewalldata nwfilter: Add support for icmpv6 filtering 2015-01-07 11:41:49 -05:00
nwfilterxml2xmlin nwfilter: Add support for icmpv6 filtering 2015-01-07 11:41:49 -05:00
nwfilterxml2xmlout
qemuagentdata
qemucapabilitiesdata qemu: Implement pci-serial 2015-05-21 17:49:02 +02:00
qemucaps2xmldata qemucaps2xmltest: fix the test to correspond to new domain formatting 2015-03-24 16:44:08 +01:00
qemuhelpdata qemu: Don't try to parse -help for new QEMU 2014-11-13 21:25:50 +01:00
qemuhotplugtestdata
qemumonitorjsondata
qemuxml2argvdata qemuBuildMemoryBackendStr: Honour passed @pagesize 2015-06-26 09:23:06 +02:00
qemuxml2xmloutdata conf: Ignore multiqueue with one queue. 2015-06-11 14:17:46 +02:00
qemuxmlnsdata
secretxml2xmlin
securityselinuxhelperdata
securityselinuxlabeldata caps: Use DomainDataLookup to replace GuestDefault* 2015-04-20 16:43:13 -04:00
sexpr2xmldata
storagepoolschemadata
storagepoolxml2xmlin storage: Fix the schema and add tests for cifs pool 2015-06-15 17:25:33 -04:00
storagepoolxml2xmlout storage: Fix the schema and add tests for cifs pool 2015-06-15 17:25:33 -04:00
storagevolschemadata
storagevolxml2argvdata
storagevolxml2xmlin
storagevolxml2xmlout conf: storage: Don't emit empty <permissions> block 2015-05-25 20:52:57 -04:00
sysinfodata sysinfo: Fix reports on ARM 2015-05-21 18:13:18 +02:00
vboxsnapshotxmldata
vircaps2xmldata
vircgroupdata tests: Add tests for virCgroupDetectMounts 2015-03-18 09:53:24 +01:00
virfiledata
virnetdaemondata tests: Adapt virnetservertest to daemon refactor 2015-06-16 13:46:20 +02:00
virnetdevtestdata/sys/class/net Introduce virnetdevtest 2015-04-14 19:33:02 +02:00
virnetserverdata tests: Adapt virnetservertest to daemon refactor 2015-06-16 13:46:20 +02:00
virpcitestdata
virscsidata
virusbtestdata/sys_bus_usb/devices
vmwareverdata
vmx2xmldata
xencapsdata
xlconfigdata xenconfig: fix spice mousemode and copypaste 2015-05-18 12:46:16 -06:00
xmconfigdata xenconfig: move <os> parsing/formating to config-specific files 2015-04-16 16:11:01 -06:00
xml2sexprdata
xml2vmxdata
.valgrind.supp
bhyvexml2argvmock.c
bhyvexml2argvtest.c bhyve: fix bhyvexml2argvtest build with gcc 2015-05-11 20:08:47 +03:00
bhyvexml2xmltest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
capabilityschematest
commandhelper.c
commandtest.c tests: fix some memleaks in tests 2015-04-27 10:04:38 +02:00
cpuset
cputest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
define-dev-segfault
domaincapsschematest
domaincapstest.c tests: fix some memleaks in tests 2015-04-27 10:04:38 +02:00
domainconftest.c tests: Use *DefParseFile more 2015-04-23 17:08:48 -04:00
domainschematest
domainsnapshotschematest
domainsnapshotxml2xmltest.c domain: conf: Drop expectedVirtTypes 2015-04-20 16:43:43 -04:00
esxutilstest.c
eventtest.c
fchosttest.c
fdstreamtest.c
int-overflow
interfaceschematest
interfacexml2xmltest.c interface: allow multiple IPv4 addresses + dhcp on a single interface 2015-05-22 10:14:01 -04:00
jsontest.c json: enhance parser test 2015-06-25 09:11:15 +02:00
libvirtd-fail Fix up "make check" 2009-10-07 12:18:13 +02:00
libvirtd-pool
libvirtdconftest.c
lxcconf2xmltest.c
lxcxml2xmltest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
Makefile.am util: multi-value virTypedParameter 2015-06-18 16:46:09 +02:00
metadatatest.c
networkschematest
networkxml2conftest.c network: escape quotes for dsmasq conf contents 2015-06-09 13:56:00 -04:00
networkxml2firewalltest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
networkxml2xmltest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
networkxml2xmlupdatetest.c network: validate DHCP ranges are completely within defined network 2015-06-02 12:40:07 -04:00
nodedevschematest
nodedevxml2xmltest.c
nodeinfotest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
nwfilterebiptablestest.c test: fix nwfilter tests following changes in virfirewall.c 2014-12-22 16:57:21 -05:00
nwfilterschematest
nwfilterxml2firewalltest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
nwfilterxml2xmltest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
objecteventtest.c objecteventtest: Check for virNetwork* return values 2015-03-23 09:56:15 +01:00
objectlocking.ml network_conf: Make virNetworkObj actually virObject 2015-03-11 16:58:48 +01:00
oomtrace.pl
openvzutilstest.c domain: Convert os.type to VIR_DOMAIN_OSTYPE enum 2015-04-20 16:40:09 -04:00
openvzutilstest.conf
pkix_asn1_tab.c
qemuagenttest.c tests: Use *DefParseFile more 2015-04-23 17:08:48 -04:00
qemuargv2xmltest.c libvirt: tests: test protected key mgmt ops support 2015-05-18 09:54:16 +02:00
qemucapabilitiestest.c
qemucaps2xmlmock.c tests: introduce qemucaps2xmlmock 2015-03-27 16:55:33 +01:00
qemucaps2xmltest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
qemucommandutiltest.c tests: fix some memleaks in tests 2015-04-27 10:04:38 +02:00
qemuhelptest.c tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE 2015-04-23 17:08:48 -04:00
qemuhotplugtest.c tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE 2015-04-23 17:08:48 -04:00
qemumonitorjsontest.c qemu: Do not poll for spice migration status 2015-06-19 15:15:11 +02:00
qemumonitortest.c tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE 2015-04-23 17:08:48 -04:00
qemumonitortestutils.c test: qemu: Fix qemu monitor test utils to allow testing HMP 2015-03-11 11:28:03 +01:00
qemumonitortestutils.h
qemuxml2argvmock.c
qemuxml2argvtest.c qemuBuildMemoryBackendStr: Honour passed @pagesize 2015-06-26 09:23:06 +02:00
qemuxml2xmltest.c conf: Format scheduler priority when it is zero 2015-06-25 23:25:30 +02:00
qemuxmlnstest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
read-bufsiz
read-non-seekable
reconnect.c
schematestutils.sh Cleanup srcdir usage 2015-04-27 16:03:31 +02:00
scsihosttest.c
seclabeltest.c
secretschematest
secretxml2xmltest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
securityselinuxhelper.c
securityselinuxlabeltest.c tests: Use *DefParseFile more 2015-04-23 17:08:48 -04:00
securityselinuxtest.c
sexpr2xmltest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
shunloadhelper.c
shunloadtest.c
sockettest.c network: validate DHCP ranges are completely within defined network 2015-06-02 12:40:07 -04:00
ssh.c
start maint: avoid regression on copyright listings 2012-07-27 07:42:34 -06:00
statstest.c tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE 2015-04-23 17:08:48 -04:00
storagebackendsheepdogtest.c tests: Use *DefParseFile more 2015-04-23 17:08:48 -04:00
storagepoolschematest
storagepoolxml2xmltest.c storage: Fix the schema and add tests for cifs pool 2015-06-15 17:25:33 -04:00
storagevolschematest schema: make source optional in volume XML 2013-05-17 08:35:08 +02:00
storagevolxml2argvtest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
storagevolxml2xmltest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
sysinfotest.c sysinfo: Fix reports on ARM 2015-05-21 18:13:18 +02:00
test_conf.c
test_conf.sh
test-lib.sh test-lib: Make case skipping possible 2013-09-13 10:25:56 +02:00
testutils.c tests: Fix grammar in comments. 2015-05-04 15:01:27 +02:00
testutils.h tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
testutilslxc.c tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE 2015-04-23 17:08:48 -04:00
testutilslxc.h
testutilsqemu.c Convert SCSI logical unit from unsigned int to unsigned long long 2015-06-22 16:03:33 -04:00
testutilsqemu.h cpu: Add {Haswell,Broadwell}-noTSX CPU models 2015-03-26 09:19:59 +01:00
testutilsxen.c caps: Convert to use VIR_DOMAIN_VIRT internally 2015-04-20 16:40:26 -04:00
testutilsxen.h
utiltest.c utiltest: Use int8_t instead of char. 2015-06-08 12:54:32 +02:00
vboxsnapshotxmltest.c
vcpupin virsh: Move error messages inside vshCommandOpt*() functions 2015-06-02 09:20:31 -04:00
viralloctest.c
viratomictest.c maint: fix comma style issues: tests, tools 2013-11-20 09:14:55 -07:00
virauthconfigtest.c
virbitmaptest.c tests: Resolve Coverity RESOURCE_LEAK 2015-04-15 10:29:41 -04:00
virbuftest.c tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE 2015-04-23 17:08:48 -04:00
vircaps2xmltest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
vircapstest.c vircapstest: Properly report error for failed tests 2015-06-24 13:47:05 +02:00
vircgroupmock.c
vircgrouptest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
vircryptotest.c
virdbustest.c
virdrivermoduletest.c
virendiantest.c
virfiletest.c util: file: Don't carelessly sanitize URIs 2015-04-09 09:43:36 +02:00
virfirewalltest.c
virhashdata.h
virhashtest.c tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE 2015-04-23 17:08:48 -04:00
virhostdevtest.c
viridentitytest.c
viriscsitest.c
virkeycodetest.c
virkeyfiletest.c
virkmodtest.c
virlockspacetest.c
virlogtest.c
virmock.h
virmockdbus.c
virnetdaemontest.c tests: Adapt virnetservertest to daemon refactor 2015-06-16 13:46:20 +02:00
virnetdevbandwidthmock.c
virnetdevbandwidthtest.c virNetDevBandwidthSet: Add priority to filter 2015-04-17 10:18:58 +02:00
virnetdevmock.c Introduce virnetdevtest 2015-04-14 19:33:02 +02:00
virnetdevtest.c Introduce virnetdevtest 2015-04-14 19:33:02 +02:00
virnetmessagetest.c
virnetserverclientmock.c
virnetserverclienttest.c
virnetsockettest.c rpc: add API for checking IPv4/6 availability 2015-06-11 12:11:18 +01:00
virnettlscontexttest.c
virnettlshelpers.c
virnettlshelpers.h
virnettlssessiontest.c tests: force FIPS testing mode with new enough GNU TLS versions 2014-09-04 11:56:39 +02:00
virpcimock.c
virpcitest.c tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE 2015-04-23 17:08:48 -04:00
virpolkittest.c
virportallocatortest.c tests: Add VIR_TEST_DEBUG and VIR_TEST_VERBOSE 2015-04-23 17:08:48 -04:00
virscsitest.c
virsh-all
virsh-optparse virsh: Move error messages inside vshCommandOpt*() functions 2015-06-02 09:20:31 -04:00
virsh-schedinfo
virsh-synopsis
virsh-undefine
virsh-uriprecedence
virshtest.c
virstoragetest.c util: storage: Fix parsing of nbd:// URI without path 2015-02-04 08:38:25 +01:00
virstringtest.c Add functions dealing with control characters in strings 2015-04-15 18:41:20 +02:00
virsystemdtest.c
virt-aa-helper-test
virtimetest.c
virtypedparamtest.c util: add virTypedParamsAddStringList 2015-06-18 16:46:09 +02:00
viruritest.c
virusbmock.c
virusbtest.c
vmwarevertest.c vmware: make version parsing more robust 2014-06-11 14:56:18 +02:00
vmx2xmltest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
xencapstest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
xlconfigtest.c xenconfig: fix spice mousemode and copypaste 2015-05-18 12:46:16 -06:00
xmconfigtest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
xml2sexprtest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00
xml2vmxtest.c tests: Add virtTestCompareToFile 2015-04-23 17:08:48 -04:00