2011-01-31 10:47:03 +00:00
|
|
|
/*
|
|
|
|
* qemu_migration.c: QEMU migration handling
|
|
|
|
*
|
2015-03-17 17:46:44 +00:00
|
|
|
* Copyright (C) 2006-2015 Red Hat, Inc.
|
2011-01-31 10:47:03 +00:00
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
2012-09-20 22:30:55 +00:00
|
|
|
* License along with this library. If not, see
|
2012-07-21 10:06:23 +00:00
|
|
|
* <http://www.gnu.org/licenses/>.
|
2011-01-31 10:47:03 +00:00
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
|
2013-03-22 13:52:25 +00:00
|
|
|
#include <netdb.h>
|
|
|
|
#include <sys/socket.h>
|
2011-01-31 10:47:03 +00:00
|
|
|
#include <sys/time.h>
|
2013-01-08 21:02:05 +00:00
|
|
|
#ifdef WITH_GNUTLS
|
2013-01-07 14:54:18 +00:00
|
|
|
# include <gnutls/gnutls.h>
|
|
|
|
# include <gnutls/x509.h>
|
|
|
|
#endif
|
2011-08-29 23:31:42 +00:00
|
|
|
#include <fcntl.h>
|
2012-04-23 14:17:55 +00:00
|
|
|
#include <poll.h>
|
2011-01-31 10:47:03 +00:00
|
|
|
|
|
|
|
#include "qemu_migration.h"
|
|
|
|
#include "qemu_monitor.h"
|
|
|
|
#include "qemu_domain.h"
|
|
|
|
#include "qemu_process.h"
|
|
|
|
#include "qemu_capabilities.h"
|
2013-01-31 13:48:06 +00:00
|
|
|
#include "qemu_command.h"
|
2011-03-10 00:35:13 +00:00
|
|
|
#include "qemu_cgroup.h"
|
2013-06-25 07:44:14 +00:00
|
|
|
#include "qemu_hotplug.h"
|
2015-04-16 09:24:23 +00:00
|
|
|
#include "qemu_blockjob.h"
|
2011-01-31 10:47:03 +00:00
|
|
|
|
Move qemu_audit.h helpers into shared code
The LXC and UML drivers can both make use of auditing. Move
the qemu_audit.{c,h} files to src/conf/domain_audit.{c,h}
* src/conf/domain_audit.c: Rename from src/qemu/qemu_audit.c
* src/conf/domain_audit.h: Rename from src/qemu/qemu_audit.h
* src/Makefile.am: Remove qemu_audit.{c,h}, add domain_audit.{c,h}
* src/qemu/qemu_audit.h, src/qemu/qemu_cgroup.c,
src/qemu/qemu_command.c, src/qemu/qemu_driver.c,
src/qemu/qemu_hotplug.c, src/qemu/qemu_migration.c,
src/qemu/qemu_process.c: Update for changed audit API names
2011-07-04 10:56:13 +00:00
|
|
|
#include "domain_audit.h"
|
2012-12-12 17:59:27 +00:00
|
|
|
#include "virlog.h"
|
2012-12-13 18:21:53 +00:00
|
|
|
#include "virerror.h"
|
2012-12-12 18:06:53 +00:00
|
|
|
#include "viralloc.h"
|
2011-07-19 18:32:58 +00:00
|
|
|
#include "virfile.h"
|
2015-03-17 17:46:44 +00:00
|
|
|
#include "virnetdevopenvswitch.h"
|
2011-01-31 10:47:03 +00:00
|
|
|
#include "datatypes.h"
|
|
|
|
#include "fdstream.h"
|
2012-12-13 18:01:25 +00:00
|
|
|
#include "viruuid.h"
|
2011-11-29 12:33:23 +00:00
|
|
|
#include "virtime.h"
|
2011-05-18 16:34:21 +00:00
|
|
|
#include "locking/domain_lock.h"
|
2011-08-12 08:54:05 +00:00
|
|
|
#include "rpc/virnetsocket.h"
|
2012-12-13 15:25:48 +00:00
|
|
|
#include "virstoragefile.h"
|
2012-02-24 18:48:55 +00:00
|
|
|
#include "viruri.h"
|
2012-12-12 17:00:34 +00:00
|
|
|
#include "virhook.h"
|
2013-04-03 10:36:23 +00:00
|
|
|
#include "virstring.h"
|
2013-06-25 13:49:21 +00:00
|
|
|
#include "virtypedparam.h"
|
2014-01-13 06:28:11 +00:00
|
|
|
#include "virprocess.h"
|
2014-11-05 13:28:57 +00:00
|
|
|
#include "nwfilter_conf.h"
|
2014-11-25 13:19:07 +00:00
|
|
|
#include "storage/storage_driver.h"
|
2011-01-31 10:47:03 +00:00
|
|
|
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_QEMU
|
|
|
|
|
2014-02-28 12:16:17 +00:00
|
|
|
VIR_LOG_INIT("qemu.qemu_migration");
|
|
|
|
|
2011-07-19 00:27:30 +00:00
|
|
|
VIR_ENUM_IMPL(qemuMigrationJobPhase, QEMU_MIGRATION_PHASE_LAST,
|
|
|
|
"none",
|
|
|
|
"perform2",
|
|
|
|
"begin3",
|
|
|
|
"perform3",
|
|
|
|
"perform3_done",
|
|
|
|
"confirm3_cancelled",
|
|
|
|
"confirm3",
|
|
|
|
"prepare",
|
|
|
|
"finish2",
|
|
|
|
"finish3",
|
|
|
|
);
|
|
|
|
|
2016-04-14 10:33:48 +00:00
|
|
|
VIR_ENUM_IMPL(qemuMigrationCompressMethod, QEMU_MIGRATION_COMPRESS_LAST,
|
|
|
|
"xbzrle",
|
|
|
|
"mt",
|
|
|
|
);
|
|
|
|
|
2011-02-17 13:17:59 +00:00
|
|
|
enum qemuMigrationCookieFlags {
|
2011-05-18 15:33:17 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_FLAG_GRAPHICS,
|
2011-05-18 16:34:21 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_FLAG_LOCKSTATE,
|
2011-09-15 13:13:11 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_FLAG_PERSISTENT,
|
2012-10-01 15:18:20 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_FLAG_NETWORK,
|
2013-01-29 12:38:50 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_FLAG_NBD,
|
2014-08-28 12:06:10 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_FLAG_STATS,
|
2015-07-30 13:27:07 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_FLAG_MEMORY_HOTPLUG,
|
2011-05-18 15:33:17 +00:00
|
|
|
|
|
|
|
QEMU_MIGRATION_COOKIE_FLAG_LAST
|
|
|
|
};
|
|
|
|
|
|
|
|
VIR_ENUM_DECL(qemuMigrationCookieFlag);
|
|
|
|
VIR_ENUM_IMPL(qemuMigrationCookieFlag,
|
|
|
|
QEMU_MIGRATION_COOKIE_FLAG_LAST,
|
2013-01-29 12:38:50 +00:00
|
|
|
"graphics",
|
|
|
|
"lockstate",
|
|
|
|
"persistent",
|
|
|
|
"network",
|
2014-08-28 12:06:10 +00:00
|
|
|
"nbd",
|
2015-07-30 13:27:07 +00:00
|
|
|
"statistics",
|
|
|
|
"memory-hotplug");
|
2011-05-18 15:33:17 +00:00
|
|
|
|
|
|
|
enum qemuMigrationCookieFeatures {
|
|
|
|
QEMU_MIGRATION_COOKIE_GRAPHICS = (1 << QEMU_MIGRATION_COOKIE_FLAG_GRAPHICS),
|
2011-05-18 16:34:21 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_LOCKSTATE = (1 << QEMU_MIGRATION_COOKIE_FLAG_LOCKSTATE),
|
2011-09-15 13:13:11 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_PERSISTENT = (1 << QEMU_MIGRATION_COOKIE_FLAG_PERSISTENT),
|
2012-10-01 15:18:20 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_NETWORK = (1 << QEMU_MIGRATION_COOKIE_FLAG_NETWORK),
|
2013-01-29 12:38:50 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_NBD = (1 << QEMU_MIGRATION_COOKIE_FLAG_NBD),
|
2014-08-28 12:06:10 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_STATS = (1 << QEMU_MIGRATION_COOKIE_FLAG_STATS),
|
2015-07-30 13:27:07 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_MEMORY_HOTPLUG = (1 << QEMU_MIGRATION_COOKIE_FLAG_MEMORY_HOTPLUG),
|
2011-02-17 13:17:59 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
typedef struct _qemuMigrationCookieGraphics qemuMigrationCookieGraphics;
|
|
|
|
typedef qemuMigrationCookieGraphics *qemuMigrationCookieGraphicsPtr;
|
|
|
|
struct _qemuMigrationCookieGraphics {
|
|
|
|
int type;
|
|
|
|
int port;
|
|
|
|
int tlsPort;
|
|
|
|
char *listen;
|
|
|
|
char *tlsSubject;
|
|
|
|
};
|
|
|
|
|
2012-10-01 15:18:20 +00:00
|
|
|
typedef struct _qemuMigrationCookieNetData qemuMigrationCookieNetData;
|
|
|
|
typedef qemuMigrationCookieNetData *qemuMigrationCookieNetDataPtr;
|
|
|
|
struct _qemuMigrationCookieNetData {
|
|
|
|
int vporttype; /* enum virNetDevVPortProfile */
|
|
|
|
|
|
|
|
/*
|
2015-06-03 10:10:36 +00:00
|
|
|
* Array of pointers to saved data. Each VIF will have its own
|
2012-10-01 15:18:20 +00:00
|
|
|
* data to transfer.
|
|
|
|
*/
|
|
|
|
char *portdata;
|
|
|
|
};
|
|
|
|
|
|
|
|
typedef struct _qemuMigrationCookieNetwork qemuMigrationCookieNetwork;
|
|
|
|
typedef qemuMigrationCookieNetwork *qemuMigrationCookieNetworkPtr;
|
|
|
|
struct _qemuMigrationCookieNetwork {
|
|
|
|
/* How many virtual NICs are we saving data for? */
|
|
|
|
int nnets;
|
|
|
|
|
|
|
|
qemuMigrationCookieNetDataPtr net;
|
|
|
|
};
|
|
|
|
|
2013-01-29 12:38:50 +00:00
|
|
|
typedef struct _qemuMigrationCookieNBD qemuMigrationCookieNBD;
|
|
|
|
typedef qemuMigrationCookieNBD *qemuMigrationCookieNBDPtr;
|
|
|
|
struct _qemuMigrationCookieNBD {
|
|
|
|
int port; /* on which port does NBD server listen for incoming data */
|
2014-11-24 14:55:36 +00:00
|
|
|
|
|
|
|
size_t ndisks; /* Number of items in @disk array */
|
|
|
|
struct {
|
|
|
|
char *target; /* Disk target */
|
|
|
|
unsigned long long capacity; /* And its capacity */
|
|
|
|
} *disks;
|
2013-01-29 12:38:50 +00:00
|
|
|
};
|
|
|
|
|
2011-01-24 18:06:16 +00:00
|
|
|
typedef struct _qemuMigrationCookie qemuMigrationCookie;
|
|
|
|
typedef qemuMigrationCookie *qemuMigrationCookiePtr;
|
|
|
|
struct _qemuMigrationCookie {
|
2011-07-06 22:42:06 +00:00
|
|
|
unsigned int flags;
|
|
|
|
unsigned int flagsMandatory;
|
2011-01-24 18:06:16 +00:00
|
|
|
|
|
|
|
/* Host properties */
|
2011-05-23 15:42:15 +00:00
|
|
|
unsigned char localHostuuid[VIR_UUID_BUFLEN];
|
|
|
|
unsigned char remoteHostuuid[VIR_UUID_BUFLEN];
|
|
|
|
char *localHostname;
|
|
|
|
char *remoteHostname;
|
2011-01-24 18:06:16 +00:00
|
|
|
|
|
|
|
/* Guest properties */
|
|
|
|
unsigned char uuid[VIR_UUID_BUFLEN];
|
|
|
|
char *name;
|
2011-02-17 13:17:59 +00:00
|
|
|
|
2011-05-18 16:34:21 +00:00
|
|
|
/* If (flags & QEMU_MIGRATION_COOKIE_LOCKSTATE) */
|
|
|
|
char *lockState;
|
|
|
|
char *lockDriver;
|
|
|
|
|
2011-02-17 13:17:59 +00:00
|
|
|
/* If (flags & QEMU_MIGRATION_COOKIE_GRAPHICS) */
|
|
|
|
qemuMigrationCookieGraphicsPtr graphics;
|
2011-09-15 13:13:11 +00:00
|
|
|
|
|
|
|
/* If (flags & QEMU_MIGRATION_COOKIE_PERSISTENT) */
|
|
|
|
virDomainDefPtr persistent;
|
2012-10-01 15:18:20 +00:00
|
|
|
|
|
|
|
/* If (flags & QEMU_MIGRATION_COOKIE_NETWORK) */
|
|
|
|
qemuMigrationCookieNetworkPtr network;
|
2013-01-29 12:38:50 +00:00
|
|
|
|
|
|
|
/* If (flags & QEMU_MIGRATION_COOKIE_NBD) */
|
|
|
|
qemuMigrationCookieNBDPtr nbd;
|
2014-08-28 12:06:10 +00:00
|
|
|
|
|
|
|
/* If (flags & QEMU_MIGRATION_COOKIE_STATS) */
|
|
|
|
qemuDomainJobInfoPtr jobInfo;
|
2011-01-24 18:06:16 +00:00
|
|
|
};
|
|
|
|
|
2011-02-17 13:17:59 +00:00
|
|
|
static void qemuMigrationCookieGraphicsFree(qemuMigrationCookieGraphicsPtr grap)
|
|
|
|
{
|
|
|
|
if (!grap)
|
|
|
|
return;
|
|
|
|
VIR_FREE(grap->listen);
|
|
|
|
VIR_FREE(grap->tlsSubject);
|
|
|
|
VIR_FREE(grap);
|
|
|
|
}
|
|
|
|
|
2011-01-24 18:06:16 +00:00
|
|
|
|
2012-10-01 15:18:20 +00:00
|
|
|
static void
|
|
|
|
qemuMigrationCookieNetworkFree(qemuMigrationCookieNetworkPtr network)
|
|
|
|
{
|
Convert 'int i' to 'size_t i' in src/qemu files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 14:09:33 +00:00
|
|
|
size_t i;
|
2012-10-01 15:18:20 +00:00
|
|
|
|
|
|
|
if (!network)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (network->net) {
|
|
|
|
for (i = 0; i < network->nnets; i++)
|
|
|
|
VIR_FREE(network->net[i].portdata);
|
|
|
|
}
|
|
|
|
VIR_FREE(network->net);
|
|
|
|
VIR_FREE(network);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-11-24 14:55:36 +00:00
|
|
|
static void qemuMigrationCookieNBDFree(qemuMigrationCookieNBDPtr nbd)
|
|
|
|
{
|
|
|
|
if (!nbd)
|
|
|
|
return;
|
|
|
|
|
|
|
|
while (nbd->ndisks)
|
|
|
|
VIR_FREE(nbd->disks[--nbd->ndisks].target);
|
|
|
|
VIR_FREE(nbd->disks);
|
|
|
|
VIR_FREE(nbd);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-01-24 18:06:16 +00:00
|
|
|
static void qemuMigrationCookieFree(qemuMigrationCookiePtr mig)
|
|
|
|
{
|
|
|
|
if (!mig)
|
|
|
|
return;
|
|
|
|
|
2013-09-16 11:26:46 +00:00
|
|
|
qemuMigrationCookieGraphicsFree(mig->graphics);
|
|
|
|
qemuMigrationCookieNetworkFree(mig->network);
|
2014-11-24 14:55:36 +00:00
|
|
|
qemuMigrationCookieNBDFree(mig->nbd);
|
2012-10-01 15:18:20 +00:00
|
|
|
|
2011-05-23 15:42:15 +00:00
|
|
|
VIR_FREE(mig->localHostname);
|
|
|
|
VIR_FREE(mig->remoteHostname);
|
2011-01-24 18:06:16 +00:00
|
|
|
VIR_FREE(mig->name);
|
2011-05-18 16:34:21 +00:00
|
|
|
VIR_FREE(mig->lockState);
|
|
|
|
VIR_FREE(mig->lockDriver);
|
2014-11-06 11:24:46 +00:00
|
|
|
VIR_FREE(mig->jobInfo);
|
2011-01-24 18:06:16 +00:00
|
|
|
VIR_FREE(mig);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2013-01-08 21:02:05 +00:00
|
|
|
#ifdef WITH_GNUTLS
|
2011-02-17 13:17:59 +00:00
|
|
|
static char *
|
|
|
|
qemuDomainExtractTLSSubject(const char *certdir)
|
|
|
|
{
|
|
|
|
char *certfile = NULL;
|
|
|
|
char *subject = NULL;
|
|
|
|
char *pemdata = NULL;
|
|
|
|
gnutls_datum_t pemdatum;
|
|
|
|
gnutls_x509_crt_t cert;
|
|
|
|
int ret;
|
|
|
|
size_t subjectlen;
|
|
|
|
|
|
|
|
if (virAsprintf(&certfile, "%s/server-cert.pem", certdir) < 0)
|
2013-07-04 10:14:12 +00:00
|
|
|
goto error;
|
2011-02-17 13:17:59 +00:00
|
|
|
|
|
|
|
if (virFileReadAll(certfile, 8192, &pemdata) < 0) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("unable to read server cert %s"), certfile);
|
2011-02-17 13:17:59 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = gnutls_x509_crt_init(&cert);
|
|
|
|
if (ret < 0) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("cannot initialize cert object: %s"),
|
|
|
|
gnutls_strerror(ret));
|
2011-02-17 13:17:59 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
pemdatum.data = (unsigned char *)pemdata;
|
|
|
|
pemdatum.size = strlen(pemdata);
|
|
|
|
|
|
|
|
ret = gnutls_x509_crt_import(cert, &pemdatum, GNUTLS_X509_FMT_PEM);
|
|
|
|
if (ret < 0) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("cannot load cert data from %s: %s"),
|
|
|
|
certfile, gnutls_strerror(ret));
|
2011-02-17 13:17:59 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
subjectlen = 1024;
|
|
|
|
if (VIR_ALLOC_N(subject, subjectlen+1) < 0)
|
2013-07-04 10:14:12 +00:00
|
|
|
goto error;
|
2011-02-17 13:17:59 +00:00
|
|
|
|
|
|
|
gnutls_x509_crt_get_dn(cert, subject, &subjectlen);
|
|
|
|
subject[subjectlen] = '\0';
|
|
|
|
|
|
|
|
VIR_FREE(certfile);
|
|
|
|
VIR_FREE(pemdata);
|
|
|
|
|
|
|
|
return subject;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
error:
|
2011-02-17 13:17:59 +00:00
|
|
|
VIR_FREE(certfile);
|
|
|
|
VIR_FREE(pemdata);
|
|
|
|
return NULL;
|
|
|
|
}
|
2013-01-07 14:54:18 +00:00
|
|
|
#endif
|
2011-02-17 13:17:59 +00:00
|
|
|
|
|
|
|
static qemuMigrationCookieGraphicsPtr
|
2016-04-13 15:06:42 +00:00
|
|
|
qemuMigrationCookieGraphicsSpiceAlloc(virQEMUDriverPtr driver,
|
|
|
|
virDomainGraphicsDefPtr def)
|
2011-02-17 13:17:59 +00:00
|
|
|
{
|
|
|
|
qemuMigrationCookieGraphicsPtr mig = NULL;
|
|
|
|
const char *listenAddr;
|
2016-04-13 15:26:17 +00:00
|
|
|
virDomainGraphicsListenDefPtr gListen = virDomainGraphicsGetListen(def, 0);
|
2013-01-10 21:03:14 +00:00
|
|
|
virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
|
2011-02-17 13:17:59 +00:00
|
|
|
|
|
|
|
if (VIR_ALLOC(mig) < 0)
|
2013-07-04 10:14:12 +00:00
|
|
|
goto error;
|
2011-02-17 13:17:59 +00:00
|
|
|
|
|
|
|
mig->type = def->type;
|
2016-04-13 15:06:42 +00:00
|
|
|
mig->port = def->data.spice.port;
|
|
|
|
if (cfg->spiceTLS)
|
|
|
|
mig->tlsPort = def->data.spice.tlsPort;
|
|
|
|
else
|
|
|
|
mig->tlsPort = -1;
|
2016-03-23 08:27:56 +00:00
|
|
|
|
2016-04-13 15:06:42 +00:00
|
|
|
if (!gListen || !(listenAddr = gListen->address))
|
|
|
|
listenAddr = cfg->spiceListen;
|
2011-02-17 13:17:59 +00:00
|
|
|
|
2013-01-08 21:02:05 +00:00
|
|
|
#ifdef WITH_GNUTLS
|
2016-04-13 15:06:42 +00:00
|
|
|
if (cfg->spiceTLS &&
|
|
|
|
!(mig->tlsSubject = qemuDomainExtractTLSSubject(cfg->spiceTLSx509certdir)))
|
|
|
|
goto error;
|
2013-01-07 14:54:18 +00:00
|
|
|
#endif
|
2013-05-20 09:23:13 +00:00
|
|
|
if (VIR_STRDUP(mig->listen, listenAddr) < 0)
|
|
|
|
goto error;
|
2011-02-17 13:17:59 +00:00
|
|
|
|
2013-01-10 21:03:14 +00:00
|
|
|
virObjectUnref(cfg);
|
2011-02-17 13:17:59 +00:00
|
|
|
return mig;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
error:
|
2011-02-17 13:17:59 +00:00
|
|
|
qemuMigrationCookieGraphicsFree(mig);
|
2013-01-10 21:03:14 +00:00
|
|
|
virObjectUnref(cfg);
|
2011-02-17 13:17:59 +00:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2012-10-01 15:18:20 +00:00
|
|
|
static qemuMigrationCookieNetworkPtr
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationCookieNetworkAlloc(virQEMUDriverPtr driver ATTRIBUTE_UNUSED,
|
2012-10-01 15:18:20 +00:00
|
|
|
virDomainDefPtr def)
|
|
|
|
{
|
|
|
|
qemuMigrationCookieNetworkPtr mig;
|
Convert 'int i' to 'size_t i' in src/qemu files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 14:09:33 +00:00
|
|
|
size_t i;
|
2012-10-01 15:18:20 +00:00
|
|
|
|
|
|
|
if (VIR_ALLOC(mig) < 0)
|
2013-07-04 10:14:12 +00:00
|
|
|
goto error;
|
2012-10-01 15:18:20 +00:00
|
|
|
|
|
|
|
mig->nnets = def->nnets;
|
|
|
|
|
|
|
|
if (VIR_ALLOC_N(mig->net, def->nnets) <0)
|
2013-07-04 10:14:12 +00:00
|
|
|
goto error;
|
2012-10-01 15:18:20 +00:00
|
|
|
|
|
|
|
for (i = 0; i < def->nnets; i++) {
|
|
|
|
virDomainNetDefPtr netptr;
|
|
|
|
virNetDevVPortProfilePtr vport;
|
|
|
|
|
|
|
|
netptr = def->nets[i];
|
|
|
|
vport = virDomainNetGetActualVirtPortProfile(netptr);
|
|
|
|
|
|
|
|
if (vport) {
|
|
|
|
mig->net[i].vporttype = vport->virtPortType;
|
|
|
|
|
|
|
|
switch (vport->virtPortType) {
|
|
|
|
case VIR_NETDEV_VPORT_PROFILE_NONE:
|
|
|
|
case VIR_NETDEV_VPORT_PROFILE_8021QBG:
|
|
|
|
case VIR_NETDEV_VPORT_PROFILE_8021QBH:
|
2012-10-01 15:18:22 +00:00
|
|
|
break;
|
2012-10-01 15:18:20 +00:00
|
|
|
case VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH:
|
2012-10-01 15:18:22 +00:00
|
|
|
if (virNetDevOpenvswitchGetMigrateData(&mig->net[i].portdata,
|
|
|
|
netptr->ifname) != 0) {
|
2014-11-28 08:37:42 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Unable to run command to get OVS port data for "
|
|
|
|
"interface %s"), netptr->ifname);
|
2012-10-01 15:18:22 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
break;
|
2012-10-01 15:18:20 +00:00
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return mig;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
error:
|
2012-10-01 15:18:20 +00:00
|
|
|
qemuMigrationCookieNetworkFree(mig);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2011-01-24 18:06:16 +00:00
|
|
|
static qemuMigrationCookiePtr
|
|
|
|
qemuMigrationCookieNew(virDomainObjPtr dom)
|
|
|
|
{
|
2011-10-04 07:11:35 +00:00
|
|
|
qemuDomainObjPrivatePtr priv = dom->privateData;
|
2011-01-24 18:06:16 +00:00
|
|
|
qemuMigrationCookiePtr mig = NULL;
|
2011-10-04 07:11:35 +00:00
|
|
|
const char *name;
|
2011-01-24 18:06:16 +00:00
|
|
|
|
|
|
|
if (VIR_ALLOC(mig) < 0)
|
2013-07-04 10:14:12 +00:00
|
|
|
goto error;
|
2011-01-24 18:06:16 +00:00
|
|
|
|
2011-10-04 07:11:35 +00:00
|
|
|
if (priv->origname)
|
|
|
|
name = priv->origname;
|
|
|
|
else
|
|
|
|
name = dom->def->name;
|
2013-05-20 09:23:13 +00:00
|
|
|
if (VIR_STRDUP(mig->name, name) < 0)
|
|
|
|
goto error;
|
2011-01-24 18:06:16 +00:00
|
|
|
memcpy(mig->uuid, dom->def->uuid, VIR_UUID_BUFLEN);
|
|
|
|
|
2013-04-26 16:39:11 +00:00
|
|
|
if (!(mig->localHostname = virGetHostname()))
|
2011-08-03 10:00:17 +00:00
|
|
|
goto error;
|
2011-05-23 15:42:15 +00:00
|
|
|
if (virGetHostUUID(mig->localHostuuid) < 0) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("Unable to obtain host UUID"));
|
2011-01-24 18:06:16 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
return mig;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
error:
|
2011-01-24 18:06:16 +00:00
|
|
|
qemuMigrationCookieFree(mig);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-02-17 13:17:59 +00:00
|
|
|
static int
|
|
|
|
qemuMigrationCookieAddGraphics(qemuMigrationCookiePtr mig,
|
2012-11-28 16:43:10 +00:00
|
|
|
virQEMUDriverPtr driver,
|
2011-02-17 13:17:59 +00:00
|
|
|
virDomainObjPtr dom)
|
|
|
|
{
|
2013-07-01 12:16:51 +00:00
|
|
|
size_t i = 0;
|
|
|
|
|
2011-02-17 13:17:59 +00:00
|
|
|
if (mig->flags & QEMU_MIGRATION_COOKIE_GRAPHICS) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("Migration graphics data already present"));
|
2011-02-17 13:17:59 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2013-07-01 12:16:51 +00:00
|
|
|
for (i = 0; i < dom->def->ngraphics; i++) {
|
|
|
|
if (dom->def->graphics[i]->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE) {
|
|
|
|
if (!(mig->graphics =
|
2016-04-13 15:06:42 +00:00
|
|
|
qemuMigrationCookieGraphicsSpiceAlloc(driver,
|
|
|
|
dom->def->graphics[i])))
|
2013-07-01 12:16:51 +00:00
|
|
|
return -1;
|
|
|
|
mig->flags |= QEMU_MIGRATION_COOKIE_GRAPHICS;
|
|
|
|
break;
|
|
|
|
}
|
2011-05-17 08:54:22 +00:00
|
|
|
}
|
2011-02-17 13:17:59 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-05-18 16:34:21 +00:00
|
|
|
static int
|
|
|
|
qemuMigrationCookieAddLockstate(qemuMigrationCookiePtr mig,
|
2012-11-28 16:43:10 +00:00
|
|
|
virQEMUDriverPtr driver,
|
2011-05-18 16:34:21 +00:00
|
|
|
virDomainObjPtr dom)
|
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = dom->privateData;
|
|
|
|
|
|
|
|
if (mig->flags & QEMU_MIGRATION_COOKIE_LOCKSTATE) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("Migration lockstate data already present"));
|
2011-05-18 16:34:21 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (virDomainObjGetState(dom, NULL) == VIR_DOMAIN_PAUSED) {
|
2013-05-20 09:23:13 +00:00
|
|
|
if (VIR_STRDUP(mig->lockState, priv->lockState) < 0)
|
2011-05-18 16:34:21 +00:00
|
|
|
return -1;
|
|
|
|
} else {
|
|
|
|
if (virDomainLockProcessInquire(driver->lockManager, dom, &mig->lockState) < 0)
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2013-05-20 09:23:13 +00:00
|
|
|
if (VIR_STRDUP(mig->lockDriver, virLockManagerPluginGetName(driver->lockManager)) < 0) {
|
2011-05-18 16:34:21 +00:00
|
|
|
VIR_FREE(mig->lockState);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
mig->flags |= QEMU_MIGRATION_COOKIE_LOCKSTATE;
|
|
|
|
mig->flagsMandatory |= QEMU_MIGRATION_COOKIE_LOCKSTATE;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-09-15 13:13:11 +00:00
|
|
|
static int
|
|
|
|
qemuMigrationCookieAddPersistent(qemuMigrationCookiePtr mig,
|
|
|
|
virDomainObjPtr dom)
|
|
|
|
{
|
|
|
|
if (mig->flags & QEMU_MIGRATION_COOKIE_PERSISTENT) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("Migration persistent data already present"));
|
2011-09-15 13:13:11 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!dom->newDef)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
mig->persistent = dom->newDef;
|
|
|
|
mig->flags |= QEMU_MIGRATION_COOKIE_PERSISTENT;
|
|
|
|
mig->flagsMandatory |= QEMU_MIGRATION_COOKIE_PERSISTENT;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-09-10 22:14:59 +00:00
|
|
|
static virDomainDefPtr
|
|
|
|
qemuMigrationCookieGetPersistent(qemuMigrationCookiePtr mig)
|
|
|
|
{
|
|
|
|
virDomainDefPtr def = mig->persistent;
|
|
|
|
|
|
|
|
mig->persistent = NULL;
|
|
|
|
mig->flags &= ~QEMU_MIGRATION_COOKIE_PERSISTENT;
|
|
|
|
mig->flagsMandatory &= ~QEMU_MIGRATION_COOKIE_PERSISTENT;
|
|
|
|
|
|
|
|
return def;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2012-10-01 15:18:20 +00:00
|
|
|
static int
|
|
|
|
qemuMigrationCookieAddNetwork(qemuMigrationCookiePtr mig,
|
2012-11-28 16:43:10 +00:00
|
|
|
virQEMUDriverPtr driver,
|
2012-10-01 15:18:20 +00:00
|
|
|
virDomainObjPtr dom)
|
|
|
|
{
|
|
|
|
if (mig->flags & QEMU_MIGRATION_COOKIE_NETWORK) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("Network migration data already present"));
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (dom->def->nnets > 0) {
|
|
|
|
mig->network = qemuMigrationCookieNetworkAlloc(driver, dom->def);
|
|
|
|
if (!mig->network)
|
|
|
|
return -1;
|
|
|
|
mig->flags |= QEMU_MIGRATION_COOKIE_NETWORK;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-05-18 16:34:21 +00:00
|
|
|
|
2013-01-29 12:38:50 +00:00
|
|
|
static int
|
|
|
|
qemuMigrationCookieAddNBD(qemuMigrationCookiePtr mig,
|
2014-11-24 14:55:36 +00:00
|
|
|
virQEMUDriverPtr driver,
|
2013-01-29 12:38:50 +00:00
|
|
|
virDomainObjPtr vm)
|
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
2014-11-24 14:55:36 +00:00
|
|
|
virHashTablePtr stats = NULL;
|
|
|
|
size_t i;
|
2014-12-16 09:40:58 +00:00
|
|
|
int ret = -1, rc;
|
2013-01-29 12:38:50 +00:00
|
|
|
|
|
|
|
/* It is not a bug if there already is a NBD data */
|
2015-12-31 06:04:39 +00:00
|
|
|
qemuMigrationCookieNBDFree(mig->nbd);
|
|
|
|
|
|
|
|
if (VIR_ALLOC(mig->nbd) < 0)
|
2013-01-29 12:38:50 +00:00
|
|
|
return -1;
|
|
|
|
|
2014-11-24 14:55:36 +00:00
|
|
|
if (vm->def->ndisks &&
|
|
|
|
VIR_ALLOC_N(mig->nbd->disks, vm->def->ndisks) < 0)
|
|
|
|
return -1;
|
|
|
|
mig->nbd->ndisks = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < vm->def->ndisks; i++) {
|
|
|
|
virDomainDiskDefPtr disk = vm->def->disks[i];
|
|
|
|
qemuBlockStats *entry;
|
|
|
|
|
|
|
|
if (!stats) {
|
|
|
|
if (!(stats = virHashCreate(10, virHashValueFree)))
|
|
|
|
goto cleanup;
|
|
|
|
|
qemu_migrate: use nested job when adding NBD to cookie
qemuMigrationCookieAddNBD is usually called from within an async
MIGRATION_OUT or MIGRATION_IN job, so it needs to start a nested job.
(The one exception is during the Begin phase when change protection
isn't enabled, but qemuDomainObjEnterMonitorAsync will behave the same
as qemuDomainObjEnterMonitor in this case.)
This bug was encountered with a libvirt client that repeatedly queries
the disk mirroring block job info during a migration. If one of these
queries occurs just as the Perform migration cookie is baked, libvirt
crashes.
Relevant logs are as follows:
6701: warning : qemuDomainObjEnterMonitorInternal:1544 : This thread seems to be the async job owner; entering monitor without asking for a nested job is dangerous
[1] 6701: info : qemuMonitorSend:972 : QEMU_MONITOR_SEND_MSG: mon=0x7fefdc004700 msg={"execute":"query-block","id":"libvirt-629"}
[2] 6699: info : qemuMonitorIOWrite:503 : QEMU_MONITOR_IO_WRITE: mon=0x7fefdc004700 buf={"execute":"query-block","id":"libvirt-629"}
[3] 6704: info : qemuMonitorSend:972 : QEMU_MONITOR_SEND_MSG: mon=0x7fefdc004700 msg={"execute":"query-block-jobs","id":"libvirt-630"}
[4] 6699: info : qemuMonitorJSONIOProcessLine:203 : QEMU_MONITOR_RECV_REPLY: mon=0x7fefdc004700 reply={"return": [...], "id": "libvirt-629"}
6699: error : qemuMonitorJSONIOProcessLine:211 : internal error: Unexpected JSON reply '{"return": [...], "id": "libvirt-629"}'
At [1] qemuMonitorBlockStatsUpdateCapacity sends its request, then waits
on mon->notify. At [2] the request is written out to the monitor socket.
At [3] qemuMonitorBlockJobInfo sends its request, and also waits on
mon->notify. The reply from the first request is received at [4].
However, qemuMonitorJSONIOProcessLine is not expecting this reply since
the second request hadn't completed sending. The reply is dropped and an
error is returned.
qemuMonitorIO signals mon->notify twice during its error handling,
waking up both of the threads waiting on it. One of them clears mon->msg
as it exits qemuMonitorSend; the other crashes:
qemuMonitorSend (mon=0x7fefdc004700, msg=<value optimized out>) at qemu/qemu_monitor.c:975
975 while (!mon->msg->finished) {
(gdb) print mon->msg
$1 = (qemuMonitorMessagePtr) 0x0
Signed-off-by: Michael Chapman <mike@very.puzzling.org>
2015-04-08 06:51:42 +00:00
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm,
|
|
|
|
priv->job.asyncJob) < 0)
|
|
|
|
goto cleanup;
|
2014-12-16 09:40:58 +00:00
|
|
|
rc = qemuMonitorBlockStatsUpdateCapacity(priv->mon, stats, false);
|
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0)
|
2014-11-24 14:55:36 +00:00
|
|
|
goto cleanup;
|
2014-12-16 09:40:58 +00:00
|
|
|
if (rc < 0)
|
2014-11-24 14:55:36 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!disk->info.alias ||
|
|
|
|
!(entry = virHashLookup(stats, disk->info.alias)))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (VIR_STRDUP(mig->nbd->disks[mig->nbd->ndisks].target,
|
|
|
|
disk->dst) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
mig->nbd->disks[mig->nbd->ndisks].capacity = entry->capacity;
|
|
|
|
mig->nbd->ndisks++;
|
|
|
|
}
|
|
|
|
|
2013-01-29 12:38:50 +00:00
|
|
|
mig->nbd->port = priv->nbdPort;
|
|
|
|
mig->flags |= QEMU_MIGRATION_COOKIE_NBD;
|
|
|
|
|
2014-11-24 14:55:36 +00:00
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
|
|
virHashFree(stats);
|
|
|
|
return ret;
|
2013-01-29 12:38:50 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
static int
|
|
|
|
qemuMigrationCookieAddStatistics(qemuMigrationCookiePtr mig,
|
|
|
|
virDomainObjPtr vm)
|
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
|
|
|
|
if (!priv->job.completed)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (!mig->jobInfo && VIR_ALLOC(mig->jobInfo) < 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
*mig->jobInfo = *priv->job.completed;
|
|
|
|
mig->flags |= QEMU_MIGRATION_COOKIE_STATS;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-02-17 13:17:59 +00:00
|
|
|
static void qemuMigrationCookieGraphicsXMLFormat(virBufferPtr buf,
|
|
|
|
qemuMigrationCookieGraphicsPtr grap)
|
|
|
|
{
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAsprintf(buf, "<graphics type='%s' port='%d' listen='%s'",
|
2011-02-17 13:17:59 +00:00
|
|
|
virDomainGraphicsTypeToString(grap->type),
|
|
|
|
grap->port, grap->listen);
|
|
|
|
if (grap->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE)
|
|
|
|
virBufferAsprintf(buf, " tlsPort='%d'", grap->tlsPort);
|
|
|
|
if (grap->tlsSubject) {
|
|
|
|
virBufferAddLit(buf, ">\n");
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAdjustIndent(buf, 2);
|
|
|
|
virBufferEscapeString(buf, "<cert info='subject' value='%s'/>\n", grap->tlsSubject);
|
|
|
|
virBufferAdjustIndent(buf, -2);
|
|
|
|
virBufferAddLit(buf, "</graphics>\n");
|
2011-02-17 13:17:59 +00:00
|
|
|
} else {
|
|
|
|
virBufferAddLit(buf, "/>\n");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2012-10-01 15:18:20 +00:00
|
|
|
static void
|
|
|
|
qemuMigrationCookieNetworkXMLFormat(virBufferPtr buf,
|
|
|
|
qemuMigrationCookieNetworkPtr optr)
|
|
|
|
{
|
Convert 'int i' to 'size_t i' in src/qemu files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 14:09:33 +00:00
|
|
|
size_t i;
|
2012-10-01 15:18:20 +00:00
|
|
|
bool empty = true;
|
|
|
|
|
|
|
|
for (i = 0; i < optr->nnets; i++) {
|
|
|
|
/* If optr->net[i].vporttype is not set, there is nothing to transfer */
|
|
|
|
if (optr->net[i].vporttype != VIR_NETDEV_VPORT_PROFILE_NONE) {
|
|
|
|
if (empty) {
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAddLit(buf, "<network>\n");
|
|
|
|
virBufferAdjustIndent(buf, 2);
|
2012-10-01 15:18:20 +00:00
|
|
|
empty = false;
|
|
|
|
}
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAsprintf(buf, "<interface index='%zu' vporttype='%s'",
|
2012-10-01 15:18:20 +00:00
|
|
|
i, virNetDevVPortTypeToString(optr->net[i].vporttype));
|
|
|
|
if (optr->net[i].portdata) {
|
|
|
|
virBufferAddLit(buf, ">\n");
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAdjustIndent(buf, 2);
|
|
|
|
virBufferEscapeString(buf, "<portdata>%s</portdata>\n",
|
2012-10-01 15:18:20 +00:00
|
|
|
optr->net[i].portdata);
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAdjustIndent(buf, -2);
|
|
|
|
virBufferAddLit(buf, "</interface>\n");
|
2012-10-01 15:18:20 +00:00
|
|
|
} else {
|
|
|
|
virBufferAddLit(buf, "/>\n");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2014-03-13 00:00:10 +00:00
|
|
|
if (!empty) {
|
|
|
|
virBufferAdjustIndent(buf, -2);
|
|
|
|
virBufferAddLit(buf, "</network>\n");
|
|
|
|
}
|
2012-10-01 15:18:20 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
static void
|
|
|
|
qemuMigrationCookieStatisticsXMLFormat(virBufferPtr buf,
|
|
|
|
qemuDomainJobInfoPtr jobInfo)
|
|
|
|
{
|
2015-11-26 12:23:08 +00:00
|
|
|
qemuMonitorMigrationStats *stats = &jobInfo->stats;
|
2014-08-28 12:06:10 +00:00
|
|
|
|
|
|
|
virBufferAddLit(buf, "<statistics>\n");
|
|
|
|
virBufferAdjustIndent(buf, 2);
|
|
|
|
|
2014-08-28 14:37:38 +00:00
|
|
|
virBufferAsprintf(buf, "<started>%llu</started>\n", jobInfo->started);
|
|
|
|
virBufferAsprintf(buf, "<stopped>%llu</stopped>\n", jobInfo->stopped);
|
2015-04-23 07:19:12 +00:00
|
|
|
virBufferAsprintf(buf, "<sent>%llu</sent>\n", jobInfo->sent);
|
|
|
|
if (jobInfo->timeDeltaSet)
|
|
|
|
virBufferAsprintf(buf, "<delta>%lld</delta>\n", jobInfo->timeDelta);
|
2014-08-28 14:37:38 +00:00
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_TIME_ELAPSED,
|
|
|
|
jobInfo->timeElapsed);
|
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_TIME_REMAINING,
|
|
|
|
jobInfo->timeRemaining);
|
2015-11-26 12:23:08 +00:00
|
|
|
if (stats->downtime_set)
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_DOWNTIME,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->downtime);
|
|
|
|
if (stats->setup_time_set)
|
2014-01-13 06:28:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_SETUP_TIME,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->setup_time);
|
2014-08-28 12:06:10 +00:00
|
|
|
|
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_MEMORY_TOTAL,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->ram_total);
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_MEMORY_PROCESSED,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->ram_transferred);
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_MEMORY_REMAINING,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->ram_remaining);
|
2014-01-13 06:28:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_MEMORY_BPS,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->ram_bps);
|
2014-08-28 12:06:10 +00:00
|
|
|
|
2015-11-26 12:23:08 +00:00
|
|
|
if (stats->ram_duplicate_set) {
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_MEMORY_CONSTANT,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->ram_duplicate);
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_MEMORY_NORMAL,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->ram_normal);
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_MEMORY_NORMAL_BYTES,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->ram_normal_bytes);
|
2014-08-28 12:06:10 +00:00
|
|
|
}
|
|
|
|
|
2015-11-27 11:30:09 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_MEMORY_DIRTY_RATE,
|
|
|
|
stats->ram_dirty_rate);
|
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_MEMORY_ITERATION,
|
|
|
|
stats->ram_iteration);
|
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_DISK_TOTAL,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->disk_total);
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_DISK_PROCESSED,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->disk_transferred);
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_DISK_REMAINING,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->disk_remaining);
|
2014-01-13 06:28:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_DISK_BPS,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->disk_bps);
|
2014-08-28 12:06:10 +00:00
|
|
|
|
2015-11-26 12:23:08 +00:00
|
|
|
if (stats->xbzrle_set) {
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_COMPRESSION_CACHE,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->xbzrle_cache_size);
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_COMPRESSION_BYTES,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->xbzrle_bytes);
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_COMPRESSION_PAGES,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->xbzrle_pages);
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_COMPRESSION_CACHE_MISSES,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->xbzrle_cache_miss);
|
2014-08-28 12:06:10 +00:00
|
|
|
virBufferAsprintf(buf, "<%1$s>%2$llu</%1$s>\n",
|
|
|
|
VIR_DOMAIN_JOB_COMPRESSION_OVERFLOW,
|
2015-11-26 12:23:08 +00:00
|
|
|
stats->xbzrle_overflow);
|
2014-08-28 12:06:10 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
virBufferAdjustIndent(buf, -2);
|
|
|
|
virBufferAddLit(buf, "</statistics>\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-09-17 12:57:30 +00:00
|
|
|
static int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationCookieXMLFormat(virQEMUDriverPtr driver,
|
2012-05-04 19:00:13 +00:00
|
|
|
virBufferPtr buf,
|
2011-09-17 12:57:30 +00:00
|
|
|
qemuMigrationCookiePtr mig)
|
2011-01-24 18:06:16 +00:00
|
|
|
{
|
|
|
|
char uuidstr[VIR_UUID_STRING_BUFLEN];
|
|
|
|
char hostuuidstr[VIR_UUID_STRING_BUFLEN];
|
Convert 'int i' to 'size_t i' in src/qemu files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 14:09:33 +00:00
|
|
|
size_t i;
|
2011-01-24 18:06:16 +00:00
|
|
|
|
|
|
|
virUUIDFormat(mig->uuid, uuidstr);
|
2011-05-23 15:42:15 +00:00
|
|
|
virUUIDFormat(mig->localHostuuid, hostuuidstr);
|
2011-01-24 18:06:16 +00:00
|
|
|
|
2013-05-07 10:28:50 +00:00
|
|
|
virBufferAddLit(buf, "<qemu-migration>\n");
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAdjustIndent(buf, 2);
|
|
|
|
virBufferEscapeString(buf, "<name>%s</name>\n", mig->name);
|
|
|
|
virBufferAsprintf(buf, "<uuid>%s</uuid>\n", uuidstr);
|
|
|
|
virBufferEscapeString(buf, "<hostname>%s</hostname>\n", mig->localHostname);
|
|
|
|
virBufferAsprintf(buf, "<hostuuid>%s</hostuuid>\n", hostuuidstr);
|
2011-02-17 13:17:59 +00:00
|
|
|
|
2013-05-21 07:21:20 +00:00
|
|
|
for (i = 0; i < QEMU_MIGRATION_COOKIE_FLAG_LAST; i++) {
|
2011-05-18 15:33:17 +00:00
|
|
|
if (mig->flagsMandatory & (1 << i))
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAsprintf(buf, "<feature name='%s'/>\n",
|
2011-05-18 15:33:17 +00:00
|
|
|
qemuMigrationCookieFlagTypeToString(i));
|
|
|
|
}
|
|
|
|
|
2011-05-17 08:54:22 +00:00
|
|
|
if ((mig->flags & QEMU_MIGRATION_COOKIE_GRAPHICS) &&
|
|
|
|
mig->graphics)
|
2011-02-17 13:17:59 +00:00
|
|
|
qemuMigrationCookieGraphicsXMLFormat(buf, mig->graphics);
|
|
|
|
|
2011-05-18 16:34:21 +00:00
|
|
|
if ((mig->flags & QEMU_MIGRATION_COOKIE_LOCKSTATE) &&
|
|
|
|
mig->lockState) {
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAsprintf(buf, "<lockstate driver='%s'>\n",
|
2011-05-18 16:34:21 +00:00
|
|
|
mig->lockDriver);
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAdjustIndent(buf, 2);
|
|
|
|
virBufferAsprintf(buf, "<leases>%s</leases>\n",
|
2011-05-18 16:34:21 +00:00
|
|
|
mig->lockState);
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAdjustIndent(buf, -2);
|
|
|
|
virBufferAddLit(buf, "</lockstate>\n");
|
2011-05-18 16:34:21 +00:00
|
|
|
}
|
|
|
|
|
2011-09-15 13:13:11 +00:00
|
|
|
if ((mig->flags & QEMU_MIGRATION_COOKIE_PERSISTENT) &&
|
|
|
|
mig->persistent) {
|
2012-05-04 19:00:13 +00:00
|
|
|
if (qemuDomainDefFormatBuf(driver,
|
|
|
|
mig->persistent,
|
|
|
|
VIR_DOMAIN_XML_INACTIVE |
|
2012-10-08 09:58:05 +00:00
|
|
|
VIR_DOMAIN_XML_SECURE |
|
|
|
|
VIR_DOMAIN_XML_MIGRATABLE,
|
2012-05-04 19:00:13 +00:00
|
|
|
buf) < 0)
|
2011-09-17 12:57:30 +00:00
|
|
|
return -1;
|
2011-09-15 13:13:11 +00:00
|
|
|
}
|
|
|
|
|
2012-10-01 15:18:20 +00:00
|
|
|
if ((mig->flags & QEMU_MIGRATION_COOKIE_NETWORK) && mig->network)
|
|
|
|
qemuMigrationCookieNetworkXMLFormat(buf, mig->network);
|
|
|
|
|
2013-01-29 12:38:50 +00:00
|
|
|
if ((mig->flags & QEMU_MIGRATION_COOKIE_NBD) && mig->nbd) {
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAddLit(buf, "<nbd");
|
2013-01-29 12:38:50 +00:00
|
|
|
if (mig->nbd->port)
|
|
|
|
virBufferAsprintf(buf, " port='%d'", mig->nbd->port);
|
2014-11-24 14:55:36 +00:00
|
|
|
if (mig->nbd->ndisks) {
|
|
|
|
virBufferAddLit(buf, ">\n");
|
|
|
|
virBufferAdjustIndent(buf, 2);
|
|
|
|
for (i = 0; i < mig->nbd->ndisks; i++) {
|
|
|
|
virBufferEscapeString(buf, "<disk target='%s'",
|
|
|
|
mig->nbd->disks[i].target);
|
|
|
|
virBufferAsprintf(buf, " capacity='%llu'/>\n",
|
|
|
|
mig->nbd->disks[i].capacity);
|
|
|
|
}
|
|
|
|
virBufferAdjustIndent(buf, -2);
|
|
|
|
virBufferAddLit(buf, "</nbd>\n");
|
|
|
|
} else {
|
|
|
|
virBufferAddLit(buf, "/>\n");
|
|
|
|
}
|
2013-01-29 12:38:50 +00:00
|
|
|
}
|
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
if (mig->flags & QEMU_MIGRATION_COOKIE_STATS && mig->jobInfo)
|
|
|
|
qemuMigrationCookieStatisticsXMLFormat(buf, mig->jobInfo);
|
|
|
|
|
2014-03-13 00:00:10 +00:00
|
|
|
virBufferAdjustIndent(buf, -2);
|
2011-01-24 18:06:16 +00:00
|
|
|
virBufferAddLit(buf, "</qemu-migration>\n");
|
2011-09-17 12:57:30 +00:00
|
|
|
return 0;
|
2011-01-24 18:06:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2012-11-28 16:43:10 +00:00
|
|
|
static char *qemuMigrationCookieXMLFormatStr(virQEMUDriverPtr driver,
|
2012-05-04 19:00:13 +00:00
|
|
|
qemuMigrationCookiePtr mig)
|
2011-01-24 18:06:16 +00:00
|
|
|
{
|
|
|
|
virBuffer buf = VIR_BUFFER_INITIALIZER;
|
|
|
|
|
2012-05-04 19:00:13 +00:00
|
|
|
if (qemuMigrationCookieXMLFormat(driver, &buf, mig) < 0) {
|
2011-09-17 12:57:30 +00:00
|
|
|
virBufferFreeAndReset(&buf);
|
|
|
|
return NULL;
|
|
|
|
}
|
2011-01-24 18:06:16 +00:00
|
|
|
|
2014-06-27 08:40:15 +00:00
|
|
|
if (virBufferCheckError(&buf) < 0)
|
2011-01-24 18:06:16 +00:00
|
|
|
return NULL;
|
|
|
|
|
|
|
|
return virBufferContentAndReset(&buf);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-02-17 13:17:59 +00:00
|
|
|
static qemuMigrationCookieGraphicsPtr
|
|
|
|
qemuMigrationCookieGraphicsXMLParse(xmlXPathContextPtr ctxt)
|
|
|
|
{
|
|
|
|
qemuMigrationCookieGraphicsPtr grap;
|
|
|
|
char *tmp;
|
|
|
|
|
|
|
|
if (VIR_ALLOC(grap) < 0)
|
2013-07-04 10:14:12 +00:00
|
|
|
goto error;
|
2011-02-17 13:17:59 +00:00
|
|
|
|
|
|
|
if (!(tmp = virXPathString("string(./graphics/@type)", ctxt))) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("missing type attribute in migration data"));
|
2011-02-17 13:17:59 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
if ((grap->type = virDomainGraphicsTypeFromString(tmp)) < 0) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("unknown graphics type %s"), tmp);
|
2011-02-17 13:17:59 +00:00
|
|
|
VIR_FREE(tmp);
|
|
|
|
goto error;
|
|
|
|
}
|
2011-10-13 22:19:44 +00:00
|
|
|
VIR_FREE(tmp);
|
2011-02-17 13:17:59 +00:00
|
|
|
if (virXPathInt("string(./graphics/@port)", ctxt, &grap->port) < 0) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("missing port attribute in migration data"));
|
2011-02-17 13:17:59 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
if (grap->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE) {
|
|
|
|
if (virXPathInt("string(./graphics/@tlsPort)", ctxt, &grap->tlsPort) < 0) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("missing tlsPort attribute in migration data"));
|
2011-02-17 13:17:59 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!(grap->listen = virXPathString("string(./graphics/@listen)", ctxt))) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("missing listen attribute in migration data"));
|
2011-02-17 13:17:59 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
/* Optional */
|
2011-05-18 09:57:07 +00:00
|
|
|
grap->tlsSubject = virXPathString("string(./graphics/cert[@info='subject']/@value)", ctxt);
|
2011-02-17 13:17:59 +00:00
|
|
|
|
|
|
|
return grap;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
error:
|
2011-02-17 13:17:59 +00:00
|
|
|
qemuMigrationCookieGraphicsFree(grap);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2012-10-01 15:18:20 +00:00
|
|
|
static qemuMigrationCookieNetworkPtr
|
|
|
|
qemuMigrationCookieNetworkXMLParse(xmlXPathContextPtr ctxt)
|
|
|
|
{
|
|
|
|
qemuMigrationCookieNetworkPtr optr;
|
Convert 'int i' to 'size_t i' in src/qemu files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 14:09:33 +00:00
|
|
|
size_t i;
|
2012-10-01 15:18:20 +00:00
|
|
|
int n;
|
|
|
|
xmlNodePtr *interfaces = NULL;
|
|
|
|
char *vporttype;
|
|
|
|
xmlNodePtr save_ctxt = ctxt->node;
|
|
|
|
|
|
|
|
if (VIR_ALLOC(optr) < 0)
|
2013-07-04 10:14:12 +00:00
|
|
|
goto error;
|
2012-10-01 15:18:20 +00:00
|
|
|
|
|
|
|
if ((n = virXPathNodeSet("./network/interface", ctxt, &interfaces)) < 0) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("missing interface information"));
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
optr->nnets = n;
|
2012-11-16 08:03:42 +00:00
|
|
|
if (VIR_ALLOC_N(optr->net, optr->nnets) < 0)
|
2013-07-04 10:14:12 +00:00
|
|
|
goto error;
|
2012-10-01 15:18:20 +00:00
|
|
|
|
|
|
|
for (i = 0; i < n; i++) {
|
|
|
|
/* portdata is optional, and may not exist */
|
|
|
|
ctxt->node = interfaces[i];
|
|
|
|
optr->net[i].portdata = virXPathString("string(./portdata[1])", ctxt);
|
|
|
|
|
|
|
|
if (!(vporttype = virXMLPropString(interfaces[i], "vporttype"))) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("missing vporttype attribute in migration data"));
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
optr->net[i].vporttype = virNetDevVPortTypeFromString(vporttype);
|
|
|
|
}
|
|
|
|
|
|
|
|
VIR_FREE(interfaces);
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2012-10-01 15:18:20 +00:00
|
|
|
ctxt->node = save_ctxt;
|
|
|
|
return optr;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
error:
|
2012-10-01 15:18:20 +00:00
|
|
|
VIR_FREE(interfaces);
|
|
|
|
qemuMigrationCookieNetworkFree(optr);
|
|
|
|
optr = NULL;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-11-24 14:55:36 +00:00
|
|
|
static qemuMigrationCookieNBDPtr
|
|
|
|
qemuMigrationCookieNBDXMLParse(xmlXPathContextPtr ctxt)
|
|
|
|
{
|
|
|
|
qemuMigrationCookieNBDPtr ret = NULL;
|
|
|
|
char *port = NULL, *capacity = NULL;
|
|
|
|
size_t i;
|
|
|
|
int n;
|
|
|
|
xmlNodePtr *disks = NULL;
|
|
|
|
xmlNodePtr save_ctxt = ctxt->node;
|
|
|
|
|
|
|
|
if (VIR_ALLOC(ret) < 0)
|
|
|
|
goto error;
|
|
|
|
|
|
|
|
port = virXPathString("string(./nbd/@port)", ctxt);
|
|
|
|
if (port && virStrToLong_i(port, NULL, 10, &ret->port) < 0) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Malformed nbd port '%s'"),
|
|
|
|
port);
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Now check if source sent a list of disks to prealloc. We might be
|
|
|
|
* talking to an older server, so it's not an error if the list is
|
|
|
|
* missing. */
|
|
|
|
if ((n = virXPathNodeSet("./nbd/disk", ctxt, &disks)) > 0) {
|
|
|
|
if (VIR_ALLOC_N(ret->disks, n) < 0)
|
|
|
|
goto error;
|
|
|
|
ret->ndisks = n;
|
|
|
|
|
|
|
|
for (i = 0; i < n; i++) {
|
|
|
|
ctxt->node = disks[i];
|
|
|
|
VIR_FREE(capacity);
|
|
|
|
|
|
|
|
if (!(ret->disks[i].target = virXPathString("string(./@target)", ctxt))) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("Malformed disk target"));
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
capacity = virXPathString("string(./@capacity)", ctxt);
|
|
|
|
if (!capacity ||
|
|
|
|
virStrToLong_ull(capacity, NULL, 10,
|
|
|
|
&ret->disks[i].capacity) < 0) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Malformed disk capacity: '%s'"),
|
|
|
|
NULLSTR(capacity));
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
VIR_FREE(port);
|
|
|
|
VIR_FREE(capacity);
|
|
|
|
VIR_FREE(disks);
|
|
|
|
ctxt->node = save_ctxt;
|
|
|
|
return ret;
|
|
|
|
error:
|
|
|
|
qemuMigrationCookieNBDFree(ret);
|
|
|
|
ret = NULL;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
static qemuDomainJobInfoPtr
|
|
|
|
qemuMigrationCookieStatisticsXMLParse(xmlXPathContextPtr ctxt)
|
|
|
|
{
|
|
|
|
qemuDomainJobInfoPtr jobInfo = NULL;
|
2015-11-26 12:23:08 +00:00
|
|
|
qemuMonitorMigrationStats *stats;
|
2014-08-28 12:06:10 +00:00
|
|
|
xmlNodePtr save_ctxt = ctxt->node;
|
|
|
|
|
|
|
|
if (!(ctxt->node = virXPathNode("./statistics", ctxt)))
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (VIR_ALLOC(jobInfo) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
2015-11-26 12:23:08 +00:00
|
|
|
stats = &jobInfo->stats;
|
2014-08-28 12:06:10 +00:00
|
|
|
jobInfo->type = VIR_DOMAIN_JOB_COMPLETED;
|
|
|
|
|
2014-08-28 14:37:38 +00:00
|
|
|
virXPathULongLong("string(./started[1])", ctxt, &jobInfo->started);
|
|
|
|
virXPathULongLong("string(./stopped[1])", ctxt, &jobInfo->stopped);
|
2015-04-23 07:19:12 +00:00
|
|
|
virXPathULongLong("string(./sent[1])", ctxt, &jobInfo->sent);
|
|
|
|
if (virXPathLongLong("string(./delta[1])", ctxt, &jobInfo->timeDelta) == 0)
|
|
|
|
jobInfo->timeDeltaSet = true;
|
2014-08-28 14:37:38 +00:00
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_TIME_ELAPSED "[1])",
|
|
|
|
ctxt, &jobInfo->timeElapsed);
|
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_TIME_REMAINING "[1])",
|
|
|
|
ctxt, &jobInfo->timeRemaining);
|
2015-04-23 07:19:12 +00:00
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
if (virXPathULongLong("string(./" VIR_DOMAIN_JOB_DOWNTIME "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->downtime) == 0)
|
|
|
|
stats->downtime_set = true;
|
2014-01-13 06:28:10 +00:00
|
|
|
if (virXPathULongLong("string(./" VIR_DOMAIN_JOB_SETUP_TIME "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->setup_time) == 0)
|
|
|
|
stats->setup_time_set = true;
|
2014-08-28 12:06:10 +00:00
|
|
|
|
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_MEMORY_TOTAL "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->ram_total);
|
2014-08-28 12:06:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_MEMORY_PROCESSED "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->ram_transferred);
|
2014-08-28 12:06:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_MEMORY_REMAINING "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->ram_remaining);
|
2014-01-13 06:28:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_MEMORY_BPS "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->ram_bps);
|
2014-08-28 12:06:10 +00:00
|
|
|
|
|
|
|
if (virXPathULongLong("string(./" VIR_DOMAIN_JOB_MEMORY_CONSTANT "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->ram_duplicate) == 0)
|
|
|
|
stats->ram_duplicate_set = true;
|
2014-08-28 12:06:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_MEMORY_NORMAL "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->ram_normal);
|
2014-08-28 12:06:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_MEMORY_NORMAL_BYTES "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->ram_normal_bytes);
|
2014-08-28 12:06:10 +00:00
|
|
|
|
2015-11-27 11:30:09 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_MEMORY_DIRTY_RATE "[1])",
|
|
|
|
ctxt, &stats->ram_dirty_rate);
|
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_MEMORY_ITERATION "[1])",
|
|
|
|
ctxt, &stats->ram_iteration);
|
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_DISK_TOTAL "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->disk_total);
|
2014-08-28 12:06:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_DISK_PROCESSED "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->disk_transferred);
|
2014-08-28 12:06:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_DISK_REMAINING "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->disk_remaining);
|
2014-01-13 06:28:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_DISK_BPS "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->disk_bps);
|
2014-08-28 12:06:10 +00:00
|
|
|
|
|
|
|
if (virXPathULongLong("string(./" VIR_DOMAIN_JOB_COMPRESSION_CACHE "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->xbzrle_cache_size) == 0)
|
|
|
|
stats->xbzrle_set = true;
|
2014-08-28 12:06:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_COMPRESSION_BYTES "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->xbzrle_bytes);
|
2014-08-28 12:06:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_COMPRESSION_PAGES "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->xbzrle_pages);
|
2014-08-28 12:06:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_COMPRESSION_CACHE_MISSES "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->xbzrle_cache_miss);
|
2014-08-28 12:06:10 +00:00
|
|
|
virXPathULongLong("string(./" VIR_DOMAIN_JOB_COMPRESSION_OVERFLOW "[1])",
|
2015-11-26 12:23:08 +00:00
|
|
|
ctxt, &stats->xbzrle_overflow);
|
2014-08-28 12:06:10 +00:00
|
|
|
|
|
|
|
cleanup:
|
|
|
|
ctxt->node = save_ctxt;
|
|
|
|
return jobInfo;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-01-24 18:06:16 +00:00
|
|
|
static int
|
|
|
|
qemuMigrationCookieXMLParse(qemuMigrationCookiePtr mig,
|
2012-11-28 16:43:10 +00:00
|
|
|
virQEMUDriverPtr driver,
|
2011-09-15 13:13:11 +00:00
|
|
|
xmlDocPtr doc,
|
2011-01-24 18:06:16 +00:00
|
|
|
xmlXPathContextPtr ctxt,
|
2011-07-06 22:42:06 +00:00
|
|
|
unsigned int flags)
|
2011-01-24 18:06:16 +00:00
|
|
|
{
|
|
|
|
char uuidstr[VIR_UUID_STRING_BUFLEN];
|
2013-02-01 17:04:15 +00:00
|
|
|
char *tmp = NULL;
|
2011-05-18 15:33:17 +00:00
|
|
|
xmlNodePtr *nodes = NULL;
|
Convert 'int i' to 'size_t i' in src/qemu files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 14:09:33 +00:00
|
|
|
size_t i;
|
|
|
|
int n;
|
2013-02-01 17:04:15 +00:00
|
|
|
virCapsPtr caps = NULL;
|
|
|
|
|
|
|
|
if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
|
|
|
|
goto error;
|
2011-01-24 18:06:16 +00:00
|
|
|
|
|
|
|
/* We don't store the uuid, name, hostname, or hostuuid
|
|
|
|
* values. We just compare them to local data to do some
|
|
|
|
* sanity checking on migration operation
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* Extract domain name */
|
|
|
|
if (!(tmp = virXPathString("string(./name[1])", ctxt))) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("missing name element in migration data"));
|
2011-01-24 18:06:16 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
if (STRNEQ(tmp, mig->name)) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Incoming cookie data had unexpected name %s vs %s"),
|
|
|
|
tmp, mig->name);
|
2011-01-24 18:06:16 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
VIR_FREE(tmp);
|
|
|
|
|
|
|
|
/* Extract domain uuid */
|
|
|
|
tmp = virXPathString("string(./uuid[1])", ctxt);
|
|
|
|
if (!tmp) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("missing uuid element in migration data"));
|
2011-01-24 18:06:16 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
virUUIDFormat(mig->uuid, uuidstr);
|
|
|
|
if (STRNEQ(tmp, uuidstr)) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Incoming cookie data had unexpected UUID %s vs %s"),
|
|
|
|
tmp, uuidstr);
|
2015-02-05 03:42:26 +00:00
|
|
|
goto error;
|
2011-01-24 18:06:16 +00:00
|
|
|
}
|
|
|
|
VIR_FREE(tmp);
|
|
|
|
|
|
|
|
/* Check & forbid "localhost" migration */
|
2011-05-23 15:42:15 +00:00
|
|
|
if (!(mig->remoteHostname = virXPathString("string(./hostname[1])", ctxt))) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("missing hostname element in migration data"));
|
2011-01-24 18:06:16 +00:00
|
|
|
goto error;
|
|
|
|
}
|
2011-05-23 15:42:15 +00:00
|
|
|
if (STREQ(mig->remoteHostname, mig->localHostname)) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Attempt to migrate guest to the same host %s"),
|
|
|
|
mig->remoteHostname);
|
2011-01-24 18:06:16 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!(tmp = virXPathString("string(./hostuuid[1])", ctxt))) {
|
2012-10-26 13:06:17 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("missing hostuuid element in migration data"));
|
|
|
|
goto error;
|
2011-01-24 18:06:16 +00:00
|
|
|
}
|
2012-10-26 13:06:17 +00:00
|
|
|
if (virUUIDParse(tmp, mig->remoteHostuuid) < 0) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("malformed hostuuid element in migration data"));
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
if (memcmp(mig->remoteHostuuid, mig->localHostuuid, VIR_UUID_BUFLEN) == 0) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Attempt to migrate guest to the same host %s"),
|
|
|
|
tmp);
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
VIR_FREE(tmp);
|
2011-01-24 18:06:16 +00:00
|
|
|
|
2011-05-18 15:33:17 +00:00
|
|
|
/* Check to ensure all mandatory features from XML are also
|
|
|
|
* present in 'flags' */
|
2013-02-20 09:30:38 +00:00
|
|
|
if ((n = virXPathNodeSet("./feature", ctxt, &nodes)) < 0)
|
2011-05-18 15:33:17 +00:00
|
|
|
goto error;
|
|
|
|
|
2013-05-21 07:21:20 +00:00
|
|
|
for (i = 0; i < n; i++) {
|
2011-05-18 15:33:17 +00:00
|
|
|
int val;
|
|
|
|
char *str = virXMLPropString(nodes[i], "name");
|
|
|
|
if (!str) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("missing feature name"));
|
2011-05-18 15:33:17 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
if ((val = qemuMigrationCookieFlagTypeFromString(str)) < 0) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Unknown migration cookie feature %s"),
|
|
|
|
str);
|
2011-05-18 15:33:17 +00:00
|
|
|
VIR_FREE(str);
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
if ((flags & (1 << val)) == 0) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Unsupported migration cookie feature %s"),
|
|
|
|
str);
|
2011-05-18 15:33:17 +00:00
|
|
|
VIR_FREE(str);
|
2015-11-05 14:23:37 +00:00
|
|
|
goto error;
|
2011-05-18 15:33:17 +00:00
|
|
|
}
|
|
|
|
VIR_FREE(str);
|
|
|
|
}
|
|
|
|
VIR_FREE(nodes);
|
|
|
|
|
2011-02-17 13:17:59 +00:00
|
|
|
if ((flags & QEMU_MIGRATION_COOKIE_GRAPHICS) &&
|
|
|
|
virXPathBoolean("count(./graphics) > 0", ctxt) &&
|
|
|
|
(!(mig->graphics = qemuMigrationCookieGraphicsXMLParse(ctxt))))
|
|
|
|
goto error;
|
|
|
|
|
2011-05-18 16:34:21 +00:00
|
|
|
if ((flags & QEMU_MIGRATION_COOKIE_LOCKSTATE) &&
|
|
|
|
virXPathBoolean("count(./lockstate) > 0", ctxt)) {
|
|
|
|
mig->lockDriver = virXPathString("string(./lockstate[1]/@driver)", ctxt);
|
|
|
|
if (!mig->lockDriver) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("Missing lock driver name in migration cookie"));
|
2011-05-18 16:34:21 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
mig->lockState = virXPathString("string(./lockstate[1]/leases[1])", ctxt);
|
|
|
|
if (mig->lockState && STREQ(mig->lockState, ""))
|
|
|
|
VIR_FREE(mig->lockState);
|
|
|
|
}
|
|
|
|
|
2011-09-15 13:13:11 +00:00
|
|
|
if ((flags & QEMU_MIGRATION_COOKIE_PERSISTENT) &&
|
|
|
|
virXPathBoolean("count(./domain) > 0", ctxt)) {
|
|
|
|
if ((n = virXPathNodeSet("./domain", ctxt, &nodes)) > 1) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Too many domain elements in "
|
|
|
|
"migration cookie: %d"),
|
|
|
|
n);
|
2011-09-15 13:13:11 +00:00
|
|
|
goto error;
|
|
|
|
}
|
2013-03-28 13:55:55 +00:00
|
|
|
mig->persistent = virDomainDefParseNode(doc, nodes[0],
|
|
|
|
caps, driver->xmlopt,
|
2015-09-15 15:04:55 +00:00
|
|
|
VIR_DOMAIN_DEF_PARSE_INACTIVE |
|
|
|
|
VIR_DOMAIN_DEF_PARSE_ABI_UPDATE);
|
2011-09-15 13:13:11 +00:00
|
|
|
if (!mig->persistent) {
|
|
|
|
/* virDomainDefParseNode already reported
|
|
|
|
* an error for us */
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
VIR_FREE(nodes);
|
|
|
|
}
|
|
|
|
|
2012-10-01 15:18:20 +00:00
|
|
|
if ((flags & QEMU_MIGRATION_COOKIE_NETWORK) &&
|
|
|
|
virXPathBoolean("count(./network) > 0", ctxt) &&
|
|
|
|
(!(mig->network = qemuMigrationCookieNetworkXMLParse(ctxt))))
|
|
|
|
goto error;
|
|
|
|
|
2013-01-29 12:38:50 +00:00
|
|
|
if (flags & QEMU_MIGRATION_COOKIE_NBD &&
|
2014-11-24 14:55:36 +00:00
|
|
|
virXPathBoolean("boolean(./nbd)", ctxt) &&
|
|
|
|
(!(mig->nbd = qemuMigrationCookieNBDXMLParse(ctxt))))
|
|
|
|
goto error;
|
2013-01-29 12:38:50 +00:00
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
if (flags & QEMU_MIGRATION_COOKIE_STATS &&
|
|
|
|
virXPathBoolean("boolean(./statistics)", ctxt) &&
|
|
|
|
(!(mig->jobInfo = qemuMigrationCookieStatisticsXMLParse(ctxt))))
|
|
|
|
goto error;
|
|
|
|
|
2013-02-01 17:04:15 +00:00
|
|
|
virObjectUnref(caps);
|
2011-01-24 18:06:16 +00:00
|
|
|
return 0;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
error:
|
2011-01-24 18:06:16 +00:00
|
|
|
VIR_FREE(tmp);
|
2011-05-18 15:33:17 +00:00
|
|
|
VIR_FREE(nodes);
|
2013-02-01 17:04:15 +00:00
|
|
|
virObjectUnref(caps);
|
2011-01-24 18:06:16 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
qemuMigrationCookieXMLParseStr(qemuMigrationCookiePtr mig,
|
2012-11-28 16:43:10 +00:00
|
|
|
virQEMUDriverPtr driver,
|
2011-01-24 18:06:16 +00:00
|
|
|
const char *xml,
|
2011-07-06 22:42:06 +00:00
|
|
|
unsigned int flags)
|
2011-01-24 18:06:16 +00:00
|
|
|
{
|
|
|
|
xmlDocPtr doc = NULL;
|
|
|
|
xmlXPathContextPtr ctxt = NULL;
|
2011-05-16 15:10:35 +00:00
|
|
|
int ret = -1;
|
2011-01-24 18:06:16 +00:00
|
|
|
|
|
|
|
VIR_DEBUG("xml=%s", NULLSTR(xml));
|
|
|
|
|
2011-09-14 14:17:57 +00:00
|
|
|
if (!(doc = virXMLParseStringCtxt(xml, _("(qemu_migration_cookie)"), &ctxt)))
|
2011-01-24 18:06:16 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2011-09-15 13:13:11 +00:00
|
|
|
ret = qemuMigrationCookieXMLParse(mig, driver, doc, ctxt, flags);
|
2011-01-24 18:06:16 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2011-01-24 18:06:16 +00:00
|
|
|
xmlXPathFreeContext(ctxt);
|
|
|
|
xmlFreeDoc(doc);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
qemuMigrationBakeCookie(qemuMigrationCookiePtr mig,
|
2012-11-28 16:43:10 +00:00
|
|
|
virQEMUDriverPtr driver,
|
2011-02-17 13:17:59 +00:00
|
|
|
virDomainObjPtr dom,
|
2011-01-24 18:06:16 +00:00
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
2011-07-06 22:42:06 +00:00
|
|
|
unsigned int flags)
|
2011-01-24 18:06:16 +00:00
|
|
|
{
|
2011-06-04 10:14:05 +00:00
|
|
|
if (!cookieout || !cookieoutlen)
|
|
|
|
return 0;
|
2011-01-24 18:06:16 +00:00
|
|
|
|
|
|
|
*cookieoutlen = 0;
|
|
|
|
|
2011-02-17 13:17:59 +00:00
|
|
|
if (flags & QEMU_MIGRATION_COOKIE_GRAPHICS &&
|
|
|
|
qemuMigrationCookieAddGraphics(mig, driver, dom) < 0)
|
|
|
|
return -1;
|
|
|
|
|
2011-05-18 16:34:21 +00:00
|
|
|
if (flags & QEMU_MIGRATION_COOKIE_LOCKSTATE &&
|
|
|
|
qemuMigrationCookieAddLockstate(mig, driver, dom) < 0)
|
|
|
|
return -1;
|
|
|
|
|
2011-09-15 13:13:11 +00:00
|
|
|
if (flags & QEMU_MIGRATION_COOKIE_PERSISTENT &&
|
|
|
|
qemuMigrationCookieAddPersistent(mig, dom) < 0)
|
|
|
|
return -1;
|
|
|
|
|
2012-10-01 15:18:20 +00:00
|
|
|
if (flags & QEMU_MIGRATION_COOKIE_NETWORK &&
|
|
|
|
qemuMigrationCookieAddNetwork(mig, driver, dom) < 0) {
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2013-01-29 12:38:50 +00:00
|
|
|
if ((flags & QEMU_MIGRATION_COOKIE_NBD) &&
|
|
|
|
qemuMigrationCookieAddNBD(mig, driver, dom) < 0)
|
|
|
|
return -1;
|
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
if (flags & QEMU_MIGRATION_COOKIE_STATS &&
|
|
|
|
qemuMigrationCookieAddStatistics(mig, dom) < 0)
|
|
|
|
return -1;
|
|
|
|
|
2015-07-30 13:27:07 +00:00
|
|
|
if (flags & QEMU_MIGRATION_COOKIE_MEMORY_HOTPLUG)
|
|
|
|
mig->flagsMandatory |= QEMU_MIGRATION_COOKIE_MEMORY_HOTPLUG;
|
|
|
|
|
2012-05-04 19:00:13 +00:00
|
|
|
if (!(*cookieout = qemuMigrationCookieXMLFormatStr(driver, mig)))
|
2011-01-24 18:06:16 +00:00
|
|
|
return -1;
|
|
|
|
|
|
|
|
*cookieoutlen = strlen(*cookieout) + 1;
|
|
|
|
|
|
|
|
VIR_DEBUG("cookielen=%d cookie=%s", *cookieoutlen, *cookieout);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static qemuMigrationCookiePtr
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationEatCookie(virQEMUDriverPtr driver,
|
2011-05-18 16:34:21 +00:00
|
|
|
virDomainObjPtr dom,
|
2011-01-24 18:06:16 +00:00
|
|
|
const char *cookiein,
|
|
|
|
int cookieinlen,
|
2011-07-06 22:42:06 +00:00
|
|
|
unsigned int flags)
|
2011-01-24 18:06:16 +00:00
|
|
|
{
|
|
|
|
qemuMigrationCookiePtr mig = NULL;
|
|
|
|
|
|
|
|
/* Parse & validate incoming cookie (if any) */
|
|
|
|
if (cookiein && cookieinlen &&
|
|
|
|
cookiein[cookieinlen-1] != '\0') {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("Migration cookie was not NULL terminated"));
|
2011-01-24 18:06:16 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIR_DEBUG("cookielen=%d cookie='%s'", cookieinlen, NULLSTR(cookiein));
|
|
|
|
|
|
|
|
if (!(mig = qemuMigrationCookieNew(dom)))
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
if (cookiein && cookieinlen &&
|
|
|
|
qemuMigrationCookieXMLParseStr(mig,
|
2011-09-15 13:13:11 +00:00
|
|
|
driver,
|
2011-01-24 18:06:16 +00:00
|
|
|
cookiein,
|
|
|
|
flags) < 0)
|
|
|
|
goto error;
|
|
|
|
|
2015-05-04 20:21:23 +00:00
|
|
|
if (flags & QEMU_MIGRATION_COOKIE_PERSISTENT &&
|
|
|
|
mig->persistent &&
|
|
|
|
STRNEQ(dom->def->name, mig->persistent->name)) {
|
|
|
|
VIR_FREE(mig->persistent->name);
|
|
|
|
if (VIR_STRDUP(mig->persistent->name, dom->def->name) < 0)
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
2011-05-18 16:34:21 +00:00
|
|
|
if (mig->flags & QEMU_MIGRATION_COOKIE_LOCKSTATE) {
|
|
|
|
if (!mig->lockDriver) {
|
|
|
|
if (virLockManagerPluginUsesState(driver->lockManager)) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Missing %s lock state for migration cookie"),
|
|
|
|
virLockManagerPluginGetName(driver->lockManager));
|
2011-05-18 16:34:21 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
} else if (STRNEQ(mig->lockDriver,
|
|
|
|
virLockManagerPluginGetName(driver->lockManager))) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Source host lock driver %s different from target %s"),
|
|
|
|
mig->lockDriver,
|
|
|
|
virLockManagerPluginGetName(driver->lockManager));
|
2011-05-18 16:34:21 +00:00
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-01-24 18:06:16 +00:00
|
|
|
return mig;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
error:
|
2011-01-24 18:06:16 +00:00
|
|
|
qemuMigrationCookieFree(mig);
|
|
|
|
return NULL;
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-02-06 13:30:59 +00:00
|
|
|
static void
|
|
|
|
qemuMigrationStoreDomainState(virDomainObjPtr vm)
|
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
priv->preMigrationState = virDomainObjGetState(vm, NULL);
|
|
|
|
|
|
|
|
VIR_DEBUG("Storing pre-migration state=%d domain=%p",
|
|
|
|
priv->preMigrationState, vm);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Returns true if the domain was resumed, false otherwise */
|
|
|
|
static bool
|
|
|
|
qemuMigrationRestoreDomainState(virConnectPtr conn, virDomainObjPtr vm)
|
|
|
|
{
|
|
|
|
virQEMUDriverPtr driver = conn->privateData;
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
2016-01-13 15:29:58 +00:00
|
|
|
int reason;
|
|
|
|
virDomainState state = virDomainObjGetState(vm, &reason);
|
2014-02-06 13:30:59 +00:00
|
|
|
bool ret = false;
|
|
|
|
|
2016-01-13 15:29:58 +00:00
|
|
|
VIR_DEBUG("driver=%p, vm=%p, pre-mig-state=%s, state=%s, reason=%s",
|
|
|
|
driver, vm,
|
|
|
|
virDomainStateTypeToString(priv->preMigrationState),
|
|
|
|
virDomainStateTypeToString(state),
|
|
|
|
virDomainStateReasonToString(state, reason));
|
2014-02-06 13:30:59 +00:00
|
|
|
|
2016-01-13 15:29:58 +00:00
|
|
|
if (state != VIR_DOMAIN_PAUSED ||
|
|
|
|
reason == VIR_DOMAIN_PAUSED_POSTCOPY_FAILED)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (priv->preMigrationState == VIR_DOMAIN_RUNNING) {
|
2014-02-06 13:30:59 +00:00
|
|
|
/* This is basically the only restore possibility that's safe
|
|
|
|
* and we should attempt to do */
|
|
|
|
|
|
|
|
VIR_DEBUG("Restoring pre-migration state due to migration error");
|
|
|
|
|
|
|
|
/* we got here through some sort of failure; start the domain again */
|
|
|
|
if (qemuProcessStartCPUs(driver, vm, conn,
|
|
|
|
VIR_DOMAIN_RUNNING_MIGRATION_CANCELED,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT) < 0) {
|
|
|
|
/* Hm, we already know we are in error here. We don't want to
|
|
|
|
* overwrite the previous error, though, so we just throw something
|
|
|
|
* to the logs and hope for the best */
|
|
|
|
VIR_ERROR(_("Failed to resume guest %s after failure"), vm->def->name);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
ret = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
priv->preMigrationState = VIR_DOMAIN_NOSTATE;
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-11-25 13:19:07 +00:00
|
|
|
|
|
|
|
static int
|
|
|
|
qemuMigrationPrecreateDisk(virConnectPtr conn,
|
|
|
|
virDomainDiskDefPtr disk,
|
|
|
|
unsigned long long capacity)
|
|
|
|
{
|
|
|
|
int ret = -1;
|
|
|
|
virStoragePoolPtr pool = NULL;
|
|
|
|
virStorageVolPtr vol = NULL;
|
|
|
|
char *volName = NULL, *basePath = NULL;
|
|
|
|
char *volStr = NULL;
|
|
|
|
virBuffer buf = VIR_BUFFER_INITIALIZER;
|
|
|
|
const char *format = NULL;
|
|
|
|
unsigned int flags = 0;
|
|
|
|
|
|
|
|
VIR_DEBUG("Precreate disk type=%s", virStorageTypeToString(disk->src->type));
|
|
|
|
|
|
|
|
switch ((virStorageType) disk->src->type) {
|
|
|
|
case VIR_STORAGE_TYPE_FILE:
|
|
|
|
if (!virDomainDiskGetSource(disk)) {
|
|
|
|
VIR_DEBUG("Dropping sourceless disk '%s'",
|
|
|
|
disk->dst);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (VIR_STRDUP(basePath, disk->src->path) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (!(volName = strrchr(basePath, '/'))) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG,
|
|
|
|
_("malformed disk path: %s"),
|
|
|
|
disk->src->path);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
*volName = '\0';
|
|
|
|
volName++;
|
|
|
|
|
|
|
|
if (!(pool = storagePoolLookupByTargetPath(conn, basePath)))
|
|
|
|
goto cleanup;
|
|
|
|
format = virStorageFileFormatTypeToString(disk->src->format);
|
|
|
|
if (disk->src->format == VIR_STORAGE_FILE_QCOW2)
|
|
|
|
flags |= VIR_STORAGE_VOL_CREATE_PREALLOC_METADATA;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case VIR_STORAGE_TYPE_VOLUME:
|
|
|
|
if (!(pool = virStoragePoolLookupByName(conn, disk->src->srcpool->pool)))
|
|
|
|
goto cleanup;
|
|
|
|
format = virStorageFileFormatTypeToString(disk->src->format);
|
|
|
|
volName = disk->src->srcpool->volume;
|
|
|
|
if (disk->src->format == VIR_STORAGE_FILE_QCOW2)
|
|
|
|
flags |= VIR_STORAGE_VOL_CREATE_PREALLOC_METADATA;
|
|
|
|
break;
|
|
|
|
|
2015-03-13 00:34:58 +00:00
|
|
|
case VIR_STORAGE_TYPE_NETWORK:
|
|
|
|
VIR_DEBUG("Skipping creation of network disk '%s'",
|
|
|
|
disk->dst);
|
|
|
|
return 0;
|
|
|
|
|
2014-11-25 13:19:07 +00:00
|
|
|
case VIR_STORAGE_TYPE_BLOCK:
|
|
|
|
case VIR_STORAGE_TYPE_DIR:
|
|
|
|
case VIR_STORAGE_TYPE_NONE:
|
|
|
|
case VIR_STORAGE_TYPE_LAST:
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("cannot precreate storage for disk type '%s'"),
|
|
|
|
virStorageTypeToString(disk->src->type));
|
|
|
|
goto cleanup;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if ((vol = virStorageVolLookupByName(pool, volName))) {
|
|
|
|
VIR_DEBUG("Skipping creation of already existing volume of name '%s'",
|
|
|
|
volName);
|
|
|
|
ret = 0;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
virBufferAddLit(&buf, "<volume>\n");
|
|
|
|
virBufferAdjustIndent(&buf, 2);
|
|
|
|
virBufferEscapeString(&buf, "<name>%s</name>\n", volName);
|
|
|
|
virBufferAsprintf(&buf, "<capacity>%llu</capacity>\n", capacity);
|
|
|
|
virBufferAddLit(&buf, "<target>\n");
|
|
|
|
virBufferAdjustIndent(&buf, 2);
|
|
|
|
virBufferAsprintf(&buf, "<format type='%s'/>\n", format);
|
|
|
|
virBufferAdjustIndent(&buf, -2);
|
|
|
|
virBufferAddLit(&buf, "</target>\n");
|
|
|
|
virBufferAdjustIndent(&buf, -2);
|
|
|
|
virBufferAddLit(&buf, "</volume>\n");
|
|
|
|
|
|
|
|
if (!(volStr = virBufferContentAndReset(&buf))) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("unable to create volume XML"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!(vol = virStorageVolCreateXML(pool, volStr, flags)))
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
|
|
VIR_FREE(basePath);
|
|
|
|
VIR_FREE(volStr);
|
|
|
|
virObjectUnref(vol);
|
|
|
|
virObjectUnref(pool);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2015-06-15 22:42:10 +00:00
|
|
|
static bool
|
|
|
|
qemuMigrateDisk(virDomainDiskDef const *disk,
|
|
|
|
size_t nmigrate_disks, const char **migrate_disks)
|
|
|
|
{
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
/* Check if the disk alias is in the list */
|
|
|
|
if (nmigrate_disks) {
|
|
|
|
for (i = 0; i < nmigrate_disks; i++) {
|
|
|
|
if (STREQ(disk->dst, migrate_disks[i]))
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Default is to migrate only non-shared non-readonly disks
|
|
|
|
* with source */
|
|
|
|
return !disk->src->shared && !disk->src->readonly &&
|
|
|
|
virDomainDiskGetSource(disk);
|
|
|
|
}
|
|
|
|
|
2014-11-25 13:19:07 +00:00
|
|
|
|
|
|
|
static int
|
|
|
|
qemuMigrationPrecreateStorage(virConnectPtr conn,
|
|
|
|
virQEMUDriverPtr driver ATTRIBUTE_UNUSED,
|
|
|
|
virDomainObjPtr vm,
|
2015-06-15 22:42:10 +00:00
|
|
|
qemuMigrationCookieNBDPtr nbd,
|
|
|
|
size_t nmigrate_disks,
|
2015-08-04 08:12:30 +00:00
|
|
|
const char **migrate_disks,
|
|
|
|
bool incremental)
|
2014-11-25 13:19:07 +00:00
|
|
|
{
|
|
|
|
int ret = -1;
|
|
|
|
size_t i = 0;
|
|
|
|
|
|
|
|
if (!nbd || !nbd->ndisks)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
for (i = 0; i < nbd->ndisks; i++) {
|
|
|
|
virDomainDiskDefPtr disk;
|
|
|
|
const char *diskSrcPath;
|
|
|
|
|
2015-04-02 14:34:01 +00:00
|
|
|
VIR_DEBUG("Looking up disk target '%s' (capacity=%llu)",
|
2014-11-25 13:19:07 +00:00
|
|
|
nbd->disks[i].target, nbd->disks[i].capacity);
|
|
|
|
|
2015-05-21 09:21:51 +00:00
|
|
|
if (!(disk = virDomainDiskByName(vm->def, nbd->disks[i].target,
|
|
|
|
false))) {
|
2014-11-25 13:19:07 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("unable to find disk by target: %s"),
|
|
|
|
nbd->disks[i].target);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
diskSrcPath = virDomainDiskGetSource(disk);
|
|
|
|
|
2015-06-15 22:42:10 +00:00
|
|
|
/* Skip disks we don't want to migrate and already existing disks. */
|
|
|
|
if (!qemuMigrateDisk(disk, nmigrate_disks, migrate_disks) ||
|
2014-11-25 13:19:07 +00:00
|
|
|
(diskSrcPath && virFileExists(diskSrcPath))) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2015-08-04 08:12:30 +00:00
|
|
|
if (incremental) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
|
|
|
|
_("pre-creation of storage targets for incremental "
|
|
|
|
"storage migration is not supported"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2014-11-25 13:19:07 +00:00
|
|
|
VIR_DEBUG("Proceeding with disk source %s", NULLSTR(diskSrcPath));
|
|
|
|
|
|
|
|
if (qemuMigrationPrecreateDisk(conn, disk, nbd->disks[i].capacity) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2013-01-31 13:48:06 +00:00
|
|
|
/**
|
|
|
|
* qemuMigrationStartNBDServer:
|
|
|
|
* @driver: qemu driver
|
|
|
|
* @vm: domain
|
|
|
|
*
|
|
|
|
* Starts NBD server. This is a newer method to copy
|
|
|
|
* storage during migration than using 'blk' and 'inc'
|
|
|
|
* arguments in 'migrate' monitor command.
|
|
|
|
* Error is reported here.
|
|
|
|
*
|
|
|
|
* Returns 0 on success, -1 otherwise.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
qemuMigrationStartNBDServer(virQEMUDriverPtr driver,
|
2013-03-22 13:52:25 +00:00
|
|
|
virDomainObjPtr vm,
|
2015-06-15 22:42:10 +00:00
|
|
|
const char *listenAddr,
|
|
|
|
size_t nmigrate_disks,
|
2016-03-17 14:58:48 +00:00
|
|
|
const char **migrate_disks,
|
|
|
|
int nbdPort)
|
2013-01-31 13:48:06 +00:00
|
|
|
{
|
|
|
|
int ret = -1;
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
unsigned short port = 0;
|
|
|
|
char *diskAlias = NULL;
|
|
|
|
size_t i;
|
|
|
|
|
2016-03-17 14:58:48 +00:00
|
|
|
if (nbdPort < 0 || nbdPort > USHRT_MAX) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG, "%s",
|
|
|
|
_("nbd port must be in range 0-65535"));
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2013-01-31 13:48:06 +00:00
|
|
|
for (i = 0; i < vm->def->ndisks; i++) {
|
|
|
|
virDomainDiskDefPtr disk = vm->def->disks[i];
|
|
|
|
|
2015-06-15 22:42:10 +00:00
|
|
|
/* check whether disk should be migrated */
|
|
|
|
if (!qemuMigrateDisk(disk, nmigrate_disks, migrate_disks))
|
2013-01-31 13:48:06 +00:00
|
|
|
continue;
|
|
|
|
|
|
|
|
VIR_FREE(diskAlias);
|
|
|
|
if (virAsprintf(&diskAlias, "%s%s",
|
2013-07-04 10:14:12 +00:00
|
|
|
QEMU_DRIVE_HOST_PREFIX, disk->info.alias) < 0)
|
2013-01-31 13:48:06 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_IN) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
2016-03-17 14:58:48 +00:00
|
|
|
if (port == 0) {
|
|
|
|
if (nbdPort)
|
|
|
|
port = nbdPort;
|
|
|
|
else if (virPortAllocatorAcquire(driver->migrationPorts, &port) < 0)
|
|
|
|
goto exit_monitor;
|
|
|
|
|
|
|
|
if (qemuMonitorNBDServerStart(priv->mon, listenAddr, port) < 0)
|
|
|
|
goto exit_monitor;
|
2013-01-31 13:48:06 +00:00
|
|
|
}
|
|
|
|
|
2014-12-16 09:40:58 +00:00
|
|
|
if (qemuMonitorNBDServerAdd(priv->mon, diskAlias, true) < 0)
|
|
|
|
goto exit_monitor;
|
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0)
|
2013-01-31 13:48:06 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
priv->nbdPort = port;
|
|
|
|
ret = 0;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2013-01-31 13:48:06 +00:00
|
|
|
VIR_FREE(diskAlias);
|
2016-03-17 14:58:48 +00:00
|
|
|
if (ret < 0 && nbdPort == 0)
|
2014-10-31 08:16:22 +00:00
|
|
|
virPortAllocatorRelease(driver->migrationPorts, port);
|
2013-01-31 13:48:06 +00:00
|
|
|
return ret;
|
2014-12-16 09:40:58 +00:00
|
|
|
|
|
|
|
exit_monitor:
|
|
|
|
ignore_value(qemuDomainObjExitMonitor(driver, vm));
|
|
|
|
goto cleanup;
|
2013-01-31 13:48:06 +00:00
|
|
|
}
|
|
|
|
|
2015-04-16 09:24:23 +00:00
|
|
|
|
|
|
|
static int
|
|
|
|
qemuMigrationStopNBDServer(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
qemuMigrationCookiePtr mig)
|
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
|
|
|
|
if (!mig->nbd)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_IN) < 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
if (qemuMonitorNBDServerStop(priv->mon) < 0)
|
|
|
|
VIR_WARN("Unable to stop NBD server");
|
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
virPortAllocatorRelease(driver->migrationPorts, priv->nbdPort);
|
|
|
|
priv->nbdPort = 0;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
2015-05-14 12:28:12 +00:00
|
|
|
* qemuMigrationDriveMirrorReady:
|
2015-04-16 09:24:23 +00:00
|
|
|
* @driver: qemu driver
|
|
|
|
* @vm: domain
|
|
|
|
*
|
|
|
|
* Check the status of all drive-mirrors started by
|
|
|
|
* qemuMigrationDriveMirror. Any pending block job events
|
|
|
|
* for the mirrored disks will be processed.
|
|
|
|
*
|
|
|
|
* Returns 1 if all mirrors are "ready",
|
|
|
|
* 0 if some mirrors are still performing initial sync,
|
|
|
|
* -1 on error.
|
|
|
|
*/
|
|
|
|
static int
|
2015-05-14 12:28:12 +00:00
|
|
|
qemuMigrationDriveMirrorReady(virQEMUDriverPtr driver,
|
2015-04-16 09:24:23 +00:00
|
|
|
virDomainObjPtr vm)
|
|
|
|
{
|
|
|
|
size_t i;
|
2015-05-14 12:28:12 +00:00
|
|
|
size_t notReady = 0;
|
|
|
|
int status;
|
2015-04-16 09:24:23 +00:00
|
|
|
|
|
|
|
for (i = 0; i < vm->def->ndisks; i++) {
|
|
|
|
virDomainDiskDefPtr disk = vm->def->disks[i];
|
2015-05-13 09:20:36 +00:00
|
|
|
qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk);
|
2015-04-16 09:24:23 +00:00
|
|
|
|
2015-05-14 12:28:12 +00:00
|
|
|
if (!diskPriv->migrating)
|
2015-04-16 09:24:23 +00:00
|
|
|
continue;
|
|
|
|
|
2015-05-14 12:28:12 +00:00
|
|
|
status = qemuBlockJobUpdate(driver, vm, disk);
|
|
|
|
if (status == VIR_DOMAIN_BLOCK_JOB_FAILED) {
|
2015-04-16 09:24:23 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED,
|
|
|
|
_("migration of disk %s failed"),
|
|
|
|
disk->dst);
|
|
|
|
return -1;
|
|
|
|
}
|
2015-05-14 12:28:12 +00:00
|
|
|
|
|
|
|
if (disk->mirrorState != VIR_DOMAIN_DISK_MIRROR_STATE_READY)
|
|
|
|
notReady++;
|
2015-04-16 09:24:23 +00:00
|
|
|
}
|
|
|
|
|
2015-05-14 12:28:12 +00:00
|
|
|
if (notReady) {
|
|
|
|
VIR_DEBUG("Waiting for %zu disk mirrors to get ready", notReady);
|
|
|
|
return 0;
|
|
|
|
} else {
|
|
|
|
VIR_DEBUG("All disk mirrors are ready");
|
|
|
|
return 1;
|
|
|
|
}
|
2015-04-16 09:24:23 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-06-09 21:50:36 +00:00
|
|
|
/*
|
|
|
|
* If @check is true, the function will report an error and return a different
|
|
|
|
* code in case a block job fails. This way we can properly abort migration in
|
|
|
|
* case some block jobs failed once all memory has already been transferred.
|
2015-04-16 09:24:23 +00:00
|
|
|
*
|
2015-06-09 21:50:36 +00:00
|
|
|
* Returns 1 if all mirrors are gone,
|
|
|
|
* 0 if some mirrors are still active,
|
|
|
|
* -1 some mirrors failed but some are still active,
|
|
|
|
* -2 all mirrors are gone but some of them failed.
|
2015-04-16 09:24:23 +00:00
|
|
|
*/
|
|
|
|
static int
|
2015-06-09 21:50:36 +00:00
|
|
|
qemuMigrationDriveMirrorCancelled(virQEMUDriverPtr driver,
|
2015-04-16 09:24:23 +00:00
|
|
|
virDomainObjPtr vm,
|
2015-06-09 21:50:36 +00:00
|
|
|
bool check)
|
2015-04-16 09:24:23 +00:00
|
|
|
{
|
2015-06-09 21:50:36 +00:00
|
|
|
size_t i;
|
|
|
|
size_t active = 0;
|
|
|
|
int status;
|
|
|
|
bool failed = false;
|
2015-04-16 09:24:23 +00:00
|
|
|
|
2015-06-09 21:50:36 +00:00
|
|
|
for (i = 0; i < vm->def->ndisks; i++) {
|
|
|
|
virDomainDiskDefPtr disk = vm->def->disks[i];
|
|
|
|
qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk);
|
2015-04-16 09:24:23 +00:00
|
|
|
|
2015-06-09 21:50:36 +00:00
|
|
|
if (!diskPriv->migrating)
|
|
|
|
continue;
|
2015-04-16 09:24:23 +00:00
|
|
|
|
2015-06-09 21:50:36 +00:00
|
|
|
status = qemuBlockJobUpdate(driver, vm, disk);
|
|
|
|
switch (status) {
|
|
|
|
case VIR_DOMAIN_BLOCK_JOB_FAILED:
|
|
|
|
if (check) {
|
2015-04-16 09:24:23 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED,
|
2015-06-09 21:50:36 +00:00
|
|
|
_("migration of disk %s failed"),
|
2015-04-16 09:24:23 +00:00
|
|
|
disk->dst);
|
2015-06-09 21:50:36 +00:00
|
|
|
failed = true;
|
2015-04-16 09:24:23 +00:00
|
|
|
}
|
2015-06-09 21:50:36 +00:00
|
|
|
/* fallthrough */
|
|
|
|
case VIR_DOMAIN_BLOCK_JOB_CANCELED:
|
|
|
|
case VIR_DOMAIN_BLOCK_JOB_COMPLETED:
|
|
|
|
qemuBlockJobSyncEnd(driver, vm, disk);
|
|
|
|
diskPriv->migrating = false;
|
|
|
|
break;
|
2015-04-16 09:24:23 +00:00
|
|
|
|
2015-06-09 21:50:36 +00:00
|
|
|
default:
|
|
|
|
active++;
|
2015-04-16 09:24:23 +00:00
|
|
|
}
|
2015-06-09 21:50:36 +00:00
|
|
|
}
|
2015-04-16 09:24:23 +00:00
|
|
|
|
2015-06-09 21:50:36 +00:00
|
|
|
if (failed) {
|
|
|
|
if (active) {
|
|
|
|
VIR_DEBUG("Some disk mirrors failed; still waiting for %zu "
|
|
|
|
"disk mirrors to finish", active);
|
|
|
|
return -1;
|
|
|
|
} else {
|
|
|
|
VIR_DEBUG("All disk mirrors are gone; some of them failed");
|
|
|
|
return -2;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if (active) {
|
|
|
|
VIR_DEBUG("Waiting for %zu disk mirrors to finish", active);
|
|
|
|
return 0;
|
|
|
|
} else {
|
|
|
|
VIR_DEBUG("All disk mirrors are gone");
|
|
|
|
return 1;
|
2015-05-14 12:28:12 +00:00
|
|
|
}
|
2015-04-16 09:24:23 +00:00
|
|
|
}
|
2015-06-09 21:50:36 +00:00
|
|
|
}
|
2015-04-16 09:24:23 +00:00
|
|
|
|
|
|
|
|
2015-06-09 21:50:36 +00:00
|
|
|
/*
|
|
|
|
* Returns 0 on success,
|
|
|
|
* 1 when job is already completed or it failed and failNoJob is false,
|
|
|
|
* -1 on error or when job failed and failNoJob is true.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
qemuMigrationCancelOneDriveMirror(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
virDomainDiskDefPtr disk,
|
2015-05-20 08:28:37 +00:00
|
|
|
bool failNoJob,
|
|
|
|
qemuDomainAsyncJob asyncJob)
|
2015-06-09 21:50:36 +00:00
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
char *diskAlias = NULL;
|
|
|
|
int ret = -1;
|
|
|
|
int status;
|
|
|
|
int rv;
|
|
|
|
|
|
|
|
status = qemuBlockJobUpdate(driver, vm, disk);
|
|
|
|
switch (status) {
|
|
|
|
case VIR_DOMAIN_BLOCK_JOB_FAILED:
|
|
|
|
case VIR_DOMAIN_BLOCK_JOB_CANCELED:
|
|
|
|
if (failNoJob) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED,
|
|
|
|
_("migration of disk %s failed"),
|
|
|
|
disk->dst);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
case VIR_DOMAIN_BLOCK_JOB_COMPLETED:
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (virAsprintf(&diskAlias, "%s%s",
|
|
|
|
QEMU_DRIVE_HOST_PREFIX, disk->info.alias) < 0)
|
|
|
|
return -1;
|
|
|
|
|
2015-05-20 08:28:37 +00:00
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
|
2015-06-09 21:50:36 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
rv = qemuMonitorBlockJobCancel(priv->mon, diskAlias, true);
|
|
|
|
|
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0 || rv < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
ret = 0;
|
2015-04-16 09:24:23 +00:00
|
|
|
|
|
|
|
cleanup:
|
|
|
|
VIR_FREE(diskAlias);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* qemuMigrationCancelDriveMirror:
|
|
|
|
* @driver: qemu driver
|
|
|
|
* @vm: domain
|
2015-06-09 21:50:36 +00:00
|
|
|
* @check: if true report an error when some of the mirrors fails
|
2015-04-16 09:24:23 +00:00
|
|
|
*
|
|
|
|
* Cancel all drive-mirrors started by qemuMigrationDriveMirror.
|
|
|
|
* Any pending block job events for the affected disks will be
|
|
|
|
* processed.
|
|
|
|
*
|
|
|
|
* Returns 0 on success, -1 otherwise.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
qemuMigrationCancelDriveMirror(virQEMUDriverPtr driver,
|
2015-06-09 21:50:36 +00:00
|
|
|
virDomainObjPtr vm,
|
2015-05-20 08:28:37 +00:00
|
|
|
bool check,
|
2015-06-01 12:41:50 +00:00
|
|
|
qemuDomainAsyncJob asyncJob,
|
|
|
|
virConnectPtr dconn)
|
2015-04-16 09:24:23 +00:00
|
|
|
{
|
2015-05-11 18:15:43 +00:00
|
|
|
virErrorPtr err = NULL;
|
2015-06-09 21:50:36 +00:00
|
|
|
int ret = -1;
|
2015-04-16 09:24:23 +00:00
|
|
|
size_t i;
|
2015-06-09 21:50:36 +00:00
|
|
|
int rv;
|
|
|
|
bool failed = false;
|
|
|
|
|
|
|
|
VIR_DEBUG("Cancelling drive mirrors for domain %s", vm->def->name);
|
2015-04-16 09:24:23 +00:00
|
|
|
|
|
|
|
for (i = 0; i < vm->def->ndisks; i++) {
|
|
|
|
virDomainDiskDefPtr disk = vm->def->disks[i];
|
2015-05-13 09:20:36 +00:00
|
|
|
qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk);
|
2015-04-16 09:24:23 +00:00
|
|
|
|
2015-06-09 21:50:36 +00:00
|
|
|
if (!diskPriv->migrating)
|
2015-04-16 09:24:23 +00:00
|
|
|
continue;
|
|
|
|
|
2015-05-20 08:28:37 +00:00
|
|
|
rv = qemuMigrationCancelOneDriveMirror(driver, vm, disk,
|
|
|
|
check, asyncJob);
|
2015-06-09 21:50:36 +00:00
|
|
|
if (rv != 0) {
|
|
|
|
if (rv < 0) {
|
|
|
|
if (!err)
|
|
|
|
err = virSaveLastError();
|
|
|
|
failed = true;
|
|
|
|
}
|
|
|
|
qemuBlockJobSyncEnd(driver, vm, disk);
|
|
|
|
diskPriv->migrating = false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
while ((rv = qemuMigrationDriveMirrorCancelled(driver, vm, check)) != 1) {
|
2015-06-01 12:41:50 +00:00
|
|
|
if (check && !failed &&
|
|
|
|
dconn && virConnectIsAlive(dconn) <= 0) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
|
|
|
|
_("Lost connection to destination host"));
|
|
|
|
failed = true;
|
|
|
|
}
|
|
|
|
|
2015-06-09 21:50:36 +00:00
|
|
|
if (rv < 0) {
|
|
|
|
failed = true;
|
|
|
|
if (rv == -2)
|
|
|
|
break;
|
2015-05-11 18:15:43 +00:00
|
|
|
}
|
2015-05-11 18:10:06 +00:00
|
|
|
|
2015-06-09 21:50:36 +00:00
|
|
|
if (failed && !err)
|
|
|
|
err = virSaveLastError();
|
|
|
|
|
|
|
|
if (virDomainObjWait(vm) < 0)
|
|
|
|
goto cleanup;
|
2015-04-16 09:24:23 +00:00
|
|
|
}
|
|
|
|
|
2015-06-09 21:50:36 +00:00
|
|
|
ret = failed ? -1 : 0;
|
|
|
|
|
|
|
|
cleanup:
|
2015-05-11 18:15:43 +00:00
|
|
|
if (err) {
|
|
|
|
virSetError(err);
|
|
|
|
virFreeError(err);
|
|
|
|
}
|
|
|
|
return ret;
|
2015-04-16 09:24:23 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2012-11-23 14:42:51 +00:00
|
|
|
/**
|
|
|
|
* qemuMigrationDriveMirror:
|
|
|
|
* @driver: qemu driver
|
|
|
|
* @vm: domain
|
|
|
|
* @mig: migration cookie
|
|
|
|
* @host: where are we migrating to
|
2016-04-01 02:16:53 +00:00
|
|
|
* @speed: bandwidth limit in MiB/s
|
2012-11-23 14:42:51 +00:00
|
|
|
* @migrate_flags: migrate monitor command flags
|
|
|
|
*
|
|
|
|
* Run drive-mirror to feed NBD server running on dst and wait
|
|
|
|
* till the process switches into another phase where writes go
|
2015-04-16 09:24:23 +00:00
|
|
|
* simultaneously to both source and destination. On success,
|
|
|
|
* update @migrate_flags so we don't tell 'migrate' command
|
|
|
|
* to do the very same operation. On failure, the caller is
|
|
|
|
* expected to call qemuMigrationCancelDriveMirror to stop all
|
|
|
|
* running mirrors.
|
2012-11-23 14:42:51 +00:00
|
|
|
*
|
|
|
|
* Returns 0 on success (@migrate_flags updated),
|
|
|
|
* -1 otherwise.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
qemuMigrationDriveMirror(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
qemuMigrationCookiePtr mig,
|
|
|
|
const char *host,
|
|
|
|
unsigned long speed,
|
2015-06-15 22:42:10 +00:00
|
|
|
unsigned int *migrate_flags,
|
|
|
|
size_t nmigrate_disks,
|
2015-06-01 12:41:50 +00:00
|
|
|
const char **migrate_disks,
|
|
|
|
virConnectPtr dconn)
|
2012-11-23 14:42:51 +00:00
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
int ret = -1;
|
|
|
|
int port;
|
2015-04-16 09:24:23 +00:00
|
|
|
size_t i;
|
2012-11-23 14:42:51 +00:00
|
|
|
char *diskAlias = NULL;
|
|
|
|
char *nbd_dest = NULL;
|
2013-05-31 11:24:06 +00:00
|
|
|
char *hoststr = NULL;
|
2016-04-01 02:16:53 +00:00
|
|
|
unsigned long long mirror_speed = speed;
|
2012-11-23 14:42:51 +00:00
|
|
|
unsigned int mirror_flags = VIR_DOMAIN_BLOCK_REBASE_REUSE_EXT;
|
2015-05-14 12:28:12 +00:00
|
|
|
int rv;
|
2015-05-19 15:28:25 +00:00
|
|
|
virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
|
2015-05-14 12:28:12 +00:00
|
|
|
|
|
|
|
VIR_DEBUG("Starting drive mirrors for domain %s", vm->def->name);
|
2012-11-23 14:42:51 +00:00
|
|
|
|
2016-04-01 02:16:53 +00:00
|
|
|
if (mirror_speed > LLONG_MAX >> 20) {
|
|
|
|
virReportError(VIR_ERR_OVERFLOW,
|
|
|
|
_("bandwidth must be less than %llu"),
|
|
|
|
LLONG_MAX >> 20);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
mirror_speed <<= 20;
|
|
|
|
|
2012-11-23 14:42:51 +00:00
|
|
|
/* steal NBD port and thus prevent its propagation back to destination */
|
|
|
|
port = mig->nbd->port;
|
|
|
|
mig->nbd->port = 0;
|
|
|
|
|
2013-05-31 11:24:06 +00:00
|
|
|
/* escape literal IPv6 address */
|
|
|
|
if (strchr(host, ':')) {
|
2013-07-04 10:14:12 +00:00
|
|
|
if (virAsprintf(&hoststr, "[%s]", host) < 0)
|
2015-04-16 09:24:23 +00:00
|
|
|
goto cleanup;
|
2013-05-31 11:24:06 +00:00
|
|
|
} else if (VIR_STRDUP(hoststr, host) < 0) {
|
2015-04-16 09:24:23 +00:00
|
|
|
goto cleanup;
|
2013-05-31 11:24:06 +00:00
|
|
|
}
|
|
|
|
|
2012-11-23 14:42:51 +00:00
|
|
|
if (*migrate_flags & QEMU_MONITOR_MIGRATE_NON_SHARED_INC)
|
|
|
|
mirror_flags |= VIR_DOMAIN_BLOCK_REBASE_SHALLOW;
|
|
|
|
|
|
|
|
for (i = 0; i < vm->def->ndisks; i++) {
|
|
|
|
virDomainDiskDefPtr disk = vm->def->disks[i];
|
2015-05-11 18:10:06 +00:00
|
|
|
qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk);
|
2015-04-16 09:24:23 +00:00
|
|
|
int mon_ret;
|
2012-11-23 14:42:51 +00:00
|
|
|
|
2015-06-15 22:42:10 +00:00
|
|
|
/* check whether disk should be migrated */
|
|
|
|
if (!qemuMigrateDisk(disk, nmigrate_disks, migrate_disks))
|
2012-11-23 14:42:51 +00:00
|
|
|
continue;
|
|
|
|
|
|
|
|
if ((virAsprintf(&diskAlias, "%s%s",
|
|
|
|
QEMU_DRIVE_HOST_PREFIX, disk->info.alias) < 0) ||
|
|
|
|
(virAsprintf(&nbd_dest, "nbd:%s:%d:exportname=%s",
|
2013-07-04 10:14:12 +00:00
|
|
|
hoststr, port, diskAlias) < 0))
|
2015-04-16 09:24:23 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2012-11-23 14:42:51 +00:00
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm,
|
2015-05-14 12:28:12 +00:00
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT) < 0)
|
2015-04-16 09:24:23 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2015-05-14 12:28:12 +00:00
|
|
|
qemuBlockJobSyncBegin(disk);
|
2015-06-15 22:42:05 +00:00
|
|
|
/* Force "raw" format for NBD export */
|
2012-11-23 14:42:51 +00:00
|
|
|
mon_ret = qemuMonitorDriveMirror(priv->mon, diskAlias, nbd_dest,
|
2016-04-01 02:16:53 +00:00
|
|
|
"raw", mirror_speed, 0, 0, mirror_flags);
|
2015-05-14 12:28:12 +00:00
|
|
|
VIR_FREE(diskAlias);
|
|
|
|
VIR_FREE(nbd_dest);
|
2012-11-23 14:42:51 +00:00
|
|
|
|
2015-04-16 09:24:23 +00:00
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0 || mon_ret < 0) {
|
2015-05-14 12:28:12 +00:00
|
|
|
qemuBlockJobSyncEnd(driver, vm, disk);
|
2015-04-16 09:24:23 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
2015-05-11 18:10:06 +00:00
|
|
|
diskPriv->migrating = true;
|
2015-05-19 15:28:25 +00:00
|
|
|
|
2016-02-04 12:32:45 +00:00
|
|
|
if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) {
|
2015-05-19 15:28:25 +00:00
|
|
|
VIR_WARN("Failed to save status on vm %s", vm->def->name);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2015-04-16 09:24:23 +00:00
|
|
|
}
|
2012-11-23 14:42:51 +00:00
|
|
|
|
2015-05-14 12:28:12 +00:00
|
|
|
while ((rv = qemuMigrationDriveMirrorReady(driver, vm)) != 1) {
|
|
|
|
if (rv < 0)
|
|
|
|
goto cleanup;
|
2012-11-23 14:42:51 +00:00
|
|
|
|
2015-05-15 13:59:49 +00:00
|
|
|
if (priv->job.abortJob) {
|
2015-05-14 12:28:12 +00:00
|
|
|
priv->job.current->type = VIR_DOMAIN_JOB_CANCELLED;
|
|
|
|
virReportError(VIR_ERR_OPERATION_ABORTED, _("%s: %s"),
|
|
|
|
qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
|
|
|
|
_("canceled by client"));
|
|
|
|
goto cleanup;
|
2012-11-23 14:42:51 +00:00
|
|
|
}
|
2015-05-14 12:28:12 +00:00
|
|
|
|
2015-06-01 12:41:50 +00:00
|
|
|
if (dconn && virConnectIsAlive(dconn) <= 0) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
|
|
|
|
_("Lost connection to destination host"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2015-05-15 13:59:49 +00:00
|
|
|
if (virDomainObjWait(vm) < 0)
|
2015-05-14 12:28:12 +00:00
|
|
|
goto cleanup;
|
2012-11-23 14:42:51 +00:00
|
|
|
}
|
|
|
|
|
2015-04-16 09:24:23 +00:00
|
|
|
/* Okay, all disks are ready. Modify migrate_flags */
|
2012-11-23 14:42:51 +00:00
|
|
|
*migrate_flags &= ~(QEMU_MONITOR_MIGRATE_NON_SHARED_DISK |
|
|
|
|
QEMU_MONITOR_MIGRATE_NON_SHARED_INC);
|
|
|
|
ret = 0;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2015-05-19 15:28:25 +00:00
|
|
|
virObjectUnref(cfg);
|
2012-11-23 14:42:51 +00:00
|
|
|
VIR_FREE(diskAlias);
|
|
|
|
VIR_FREE(nbd_dest);
|
2013-05-31 11:24:06 +00:00
|
|
|
VIR_FREE(hoststr);
|
2012-11-23 14:42:51 +00:00
|
|
|
return ret;
|
|
|
|
}
|
2013-01-31 13:48:06 +00:00
|
|
|
|
2012-11-27 15:34:24 +00:00
|
|
|
|
2015-10-06 13:39:48 +00:00
|
|
|
/**
|
|
|
|
* qemuMigrationIsAllowedHostdev:
|
|
|
|
* @def: domain definition
|
|
|
|
*
|
|
|
|
* Checks that @def does not contain any host devices unsupported accross
|
|
|
|
* migrations. Returns true if the vm is allowed to migrate.
|
|
|
|
*/
|
|
|
|
static bool
|
|
|
|
qemuMigrationIsAllowedHostdev(const virDomainDef *def)
|
|
|
|
{
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
/* Migration with USB host devices is allowed, all other devices are
|
|
|
|
* forbidden. */
|
|
|
|
for (i = 0; i < def->nhostdevs; i++) {
|
|
|
|
virDomainHostdevDefPtr hostdev = def->hostdevs[i];
|
|
|
|
if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS ||
|
|
|
|
hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
|
|
|
_("domain has assigned non-USB host devices"));
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-10-06 14:24:48 +00:00
|
|
|
/**
|
|
|
|
* qemuMigrationIsAllowed:
|
|
|
|
* @driver: qemu driver struct
|
|
|
|
* @vm: domain object
|
|
|
|
* @remote: migration is remote
|
|
|
|
* @flags: migration flags (see struct virDomainMigrateFlags)
|
|
|
|
*
|
|
|
|
* Validates that the configuration of @vm can be migrated in various
|
|
|
|
* situations. If @remote is true, the migration happens to remote host. @flags
|
|
|
|
* is used to check various special migration types according to the request.
|
|
|
|
*
|
|
|
|
* Returns true if migration is supported. Reports libvirt error and returns
|
|
|
|
* false otherwise.
|
|
|
|
*/
|
2012-12-07 10:59:24 +00:00
|
|
|
bool
|
2015-10-06 13:53:02 +00:00
|
|
|
qemuMigrationIsAllowed(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
bool remote,
|
2015-10-06 14:24:48 +00:00
|
|
|
unsigned int flags)
|
2011-01-31 10:47:03 +00:00
|
|
|
{
|
snapshot: prevent migration from stranding snapshot data
Migration is another case of stranding metadata. And since
snapshot metadata is arbitrarily large, there's no way to
shoehorn it into the migration cookie of migration v3.
This patch consolidates two existing locations for migration
validation into one helper function, then enhances that function
to also do the new checks. If we could always trust the source
to validate migration, then the destination would not have to
do anything; but since older servers that did not do checking
can migrate to newer destinations, we have to repeat some of
the same checks on the destination; meanwhile, we want to
detect failures as soon as possible. With migration v2, this
means that validation will reject things at Prepare on the
destination if the XML exposes the problem, otherwise at Perform
on the source; with migration v3, this means that validation
will reject things at Begin on the source, or if the source
is old and the XML exposes the problem, then at Prepare on the
destination.
This patch is necessarily over-strict. Once a later patch
properly handles auto-cleanup of snapshot metadata on the
death of a transient domain, then the only time we actually
need snapshots to prevent migration is when using the
--undefinesource flag on a persistent source domain.
It is possible to recreate snapshot metadata on the destination
with VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE and
VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT. But for now, that is limited,
since if we delete the snapshot metadata prior to migration,
then we won't know the name of the current snapshot to pass
along; and if we delete the snapshot metadata after migration
and use the v3 migration cookie to pass along the name of the
current snapshot, then we need a way to bypass the fact that
this patch refuses migration with snapshot metadata present.
So eventually, we may have to introduce migration protocol v4
that allows feature negotiation and an arbitrary number of
handshake exchanges, so as to pass as many rpc calls as needed
to transfer all the snapshot xml hierarchy.
But all of that is thoughts for the future; for now, the best
course of action is to quit early, rather than get into a
funky state of stale metadata; then relax restrictions later.
* src/qemu/qemu_migration.h (qemuMigrationIsAllowed): Make static.
* src/qemu/qemu_migration.c (qemuMigrationIsAllowed): Alter
signature, and allow checks for both outgoing and incoming.
(qemuMigrationBegin, qemuMigrationPrepareAny)
(qemuMigrationPerformJob): Update callers.
2011-08-12 19:23:09 +00:00
|
|
|
int nsnapshots;
|
2013-06-10 14:30:48 +00:00
|
|
|
int pauseReason;
|
Convert 'int i' to 'size_t i' in src/qemu files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 14:09:33 +00:00
|
|
|
size_t i;
|
snapshot: prevent migration from stranding snapshot data
Migration is another case of stranding metadata. And since
snapshot metadata is arbitrarily large, there's no way to
shoehorn it into the migration cookie of migration v3.
This patch consolidates two existing locations for migration
validation into one helper function, then enhances that function
to also do the new checks. If we could always trust the source
to validate migration, then the destination would not have to
do anything; but since older servers that did not do checking
can migrate to newer destinations, we have to repeat some of
the same checks on the destination; meanwhile, we want to
detect failures as soon as possible. With migration v2, this
means that validation will reject things at Prepare on the
destination if the XML exposes the problem, otherwise at Perform
on the source; with migration v3, this means that validation
will reject things at Begin on the source, or if the source
is old and the XML exposes the problem, then at Prepare on the
destination.
This patch is necessarily over-strict. Once a later patch
properly handles auto-cleanup of snapshot metadata on the
death of a transient domain, then the only time we actually
need snapshots to prevent migration is when using the
--undefinesource flag on a persistent source domain.
It is possible to recreate snapshot metadata on the destination
with VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE and
VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT. But for now, that is limited,
since if we delete the snapshot metadata prior to migration,
then we won't know the name of the current snapshot to pass
along; and if we delete the snapshot metadata after migration
and use the v3 migration cookie to pass along the name of the
current snapshot, then we need a way to bypass the fact that
this patch refuses migration with snapshot metadata present.
So eventually, we may have to introduce migration protocol v4
that allows feature negotiation and an arbitrary number of
handshake exchanges, so as to pass as many rpc calls as needed
to transfer all the snapshot xml hierarchy.
But all of that is thoughts for the future; for now, the best
course of action is to quit early, rather than get into a
funky state of stale metadata; then relax restrictions later.
* src/qemu/qemu_migration.h (qemuMigrationIsAllowed): Make static.
* src/qemu/qemu_migration.c (qemuMigrationIsAllowed): Alter
signature, and allow checks for both outgoing and incoming.
(qemuMigrationBegin, qemuMigrationPrepareAny)
(qemuMigrationPerformJob): Update callers.
2011-08-12 19:23:09 +00:00
|
|
|
|
2015-10-06 13:53:02 +00:00
|
|
|
/* perform these checks only when migrating to remote hosts */
|
|
|
|
if (remote) {
|
|
|
|
nsnapshots = virDomainSnapshotObjListNum(vm->snapshots, NULL, 0);
|
|
|
|
if (nsnapshots < 0)
|
|
|
|
return false;
|
2013-06-10 14:30:48 +00:00
|
|
|
|
2015-10-06 13:53:02 +00:00
|
|
|
if (nsnapshots > 0) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID,
|
|
|
|
_("cannot migrate domain with %d snapshots"),
|
|
|
|
nsnapshots);
|
|
|
|
return false;
|
snapshot: prevent migration from stranding snapshot data
Migration is another case of stranding metadata. And since
snapshot metadata is arbitrarily large, there's no way to
shoehorn it into the migration cookie of migration v3.
This patch consolidates two existing locations for migration
validation into one helper function, then enhances that function
to also do the new checks. If we could always trust the source
to validate migration, then the destination would not have to
do anything; but since older servers that did not do checking
can migrate to newer destinations, we have to repeat some of
the same checks on the destination; meanwhile, we want to
detect failures as soon as possible. With migration v2, this
means that validation will reject things at Prepare on the
destination if the XML exposes the problem, otherwise at Perform
on the source; with migration v3, this means that validation
will reject things at Begin on the source, or if the source
is old and the XML exposes the problem, then at Prepare on the
destination.
This patch is necessarily over-strict. Once a later patch
properly handles auto-cleanup of snapshot metadata on the
death of a transient domain, then the only time we actually
need snapshots to prevent migration is when using the
--undefinesource flag on a persistent source domain.
It is possible to recreate snapshot metadata on the destination
with VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE and
VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT. But for now, that is limited,
since if we delete the snapshot metadata prior to migration,
then we won't know the name of the current snapshot to pass
along; and if we delete the snapshot metadata after migration
and use the v3 migration cookie to pass along the name of the
current snapshot, then we need a way to bypass the fact that
this patch refuses migration with snapshot metadata present.
So eventually, we may have to introduce migration protocol v4
that allows feature negotiation and an arbitrary number of
handshake exchanges, so as to pass as many rpc calls as needed
to transfer all the snapshot xml hierarchy.
But all of that is thoughts for the future; for now, the best
course of action is to quit early, rather than get into a
funky state of stale metadata; then relax restrictions later.
* src/qemu/qemu_migration.h (qemuMigrationIsAllowed): Make static.
* src/qemu/qemu_migration.c (qemuMigrationIsAllowed): Alter
signature, and allow checks for both outgoing and incoming.
(qemuMigrationBegin, qemuMigrationPrepareAny)
(qemuMigrationPerformJob): Update callers.
2011-08-12 19:23:09 +00:00
|
|
|
}
|
2012-12-07 10:59:24 +00:00
|
|
|
|
2015-10-06 13:53:02 +00:00
|
|
|
/* cancel migration if disk I/O error is emitted while migrating */
|
2015-10-06 14:24:48 +00:00
|
|
|
if (flags & VIR_MIGRATE_ABORT_ON_ERROR &&
|
2015-10-06 15:02:09 +00:00
|
|
|
!(flags & VIR_MIGRATE_OFFLINE) &&
|
2015-10-06 13:53:02 +00:00
|
|
|
virDomainObjGetState(vm, &pauseReason) == VIR_DOMAIN_PAUSED &&
|
|
|
|
pauseReason == VIR_DOMAIN_PAUSED_IOERROR) {
|
blockjob: react to active block copy
For now, disk migration via block copy job is not implemented in
libvirt. But when we do implement it, we have to deal with the
fact that qemu does not yet provide an easy way to re-start a qemu
process with mirroring still intact. Paolo has proposed an idea
for a persistent dirty bitmap that might make this possible, but
until that design is complete, it's hard to say what changes
libvirt would need. Even something like 'virDomainSave' becomes
hairy, if you realize the implications that 'virDomainRestore'
would be stuck with recreating the same mirror layout.
But if we step back and look at the bigger picture, we realize that
the initial client of live storage migration via disk mirroring is
oVirt, which always uses transient domains, and that if a transient
domain is destroyed while a mirror exists, oVirt can easily restart
the storage migration by creating a new domain that visits just the
source storage, with no loss in data.
We can make life a lot easier by being cowards for now, forbidding
certain operations on a domain. This patch guarantees that we
never get in a state where we would have to restart a domain with
a mirroring block copy, by preventing saves, snapshots, migration,
hot unplug of a disk in use, and conversion to a persistent domain
(thankfully, it is still relatively easy to 'virsh undefine' a
running domain to temporarily make it transient, run tests on
'virsh blockcopy', then 'virsh define' to restore the persistence).
Later, if the qemu design is enhanced, we can relax our code.
The change to qemudDomainDefine looks a bit odd for undoing an
assignment, rather than probing up front to avoid the assignment,
but this is because of how virDomainAssignDef combines both a
lookup and assignment into a single function call.
* src/conf/domain_conf.h (virDomainHasDiskMirror): New prototype.
* src/conf/domain_conf.c (virDomainHasDiskMirror): New function.
* src/libvirt_private.syms (domain_conf.h): Export it.
* src/qemu/qemu_driver.c (qemuDomainSaveInternal)
(qemuDomainSnapshotCreateXML, qemuDomainRevertToSnapshot)
(qemuDomainBlockJobImpl, qemudDomainDefine): Prevent dangerous
actions while block copy is already in action.
* src/qemu/qemu_hotplug.c (qemuDomainDetachDiskDevice): Likewise.
* src/qemu/qemu_migration.c (qemuMigrationIsAllowed): Likewise.
2012-04-10 02:39:47 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
2015-10-06 13:53:02 +00:00
|
|
|
_("cannot migrate domain with I/O error"));
|
blockjob: react to active block copy
For now, disk migration via block copy job is not implemented in
libvirt. But when we do implement it, we have to deal with the
fact that qemu does not yet provide an easy way to re-start a qemu
process with mirroring still intact. Paolo has proposed an idea
for a persistent dirty bitmap that might make this possible, but
until that design is complete, it's hard to say what changes
libvirt would need. Even something like 'virDomainSave' becomes
hairy, if you realize the implications that 'virDomainRestore'
would be stuck with recreating the same mirror layout.
But if we step back and look at the bigger picture, we realize that
the initial client of live storage migration via disk mirroring is
oVirt, which always uses transient domains, and that if a transient
domain is destroyed while a mirror exists, oVirt can easily restart
the storage migration by creating a new domain that visits just the
source storage, with no loss in data.
We can make life a lot easier by being cowards for now, forbidding
certain operations on a domain. This patch guarantees that we
never get in a state where we would have to restart a domain with
a mirroring block copy, by preventing saves, snapshots, migration,
hot unplug of a disk in use, and conversion to a persistent domain
(thankfully, it is still relatively easy to 'virsh undefine' a
running domain to temporarily make it transient, run tests on
'virsh blockcopy', then 'virsh define' to restore the persistence).
Later, if the qemu design is enhanced, we can relax our code.
The change to qemudDomainDefine looks a bit odd for undoing an
assignment, rather than probing up front to avoid the assignment,
but this is because of how virDomainAssignDef combines both a
lookup and assignment into a single function call.
* src/conf/domain_conf.h (virDomainHasDiskMirror): New prototype.
* src/conf/domain_conf.c (virDomainHasDiskMirror): New function.
* src/libvirt_private.syms (domain_conf.h): Export it.
* src/qemu/qemu_driver.c (qemuDomainSaveInternal)
(qemuDomainSnapshotCreateXML, qemuDomainRevertToSnapshot)
(qemuDomainBlockJobImpl, qemudDomainDefine): Prevent dangerous
actions while block copy is already in action.
* src/qemu/qemu_hotplug.c (qemuDomainDetachDiskDevice): Likewise.
* src/qemu/qemu_migration.c (qemuMigrationIsAllowed): Likewise.
2012-04-10 02:39:47 +00:00
|
|
|
return false;
|
|
|
|
}
|
snapshot: prevent migration from stranding snapshot data
Migration is another case of stranding metadata. And since
snapshot metadata is arbitrarily large, there's no way to
shoehorn it into the migration cookie of migration v3.
This patch consolidates two existing locations for migration
validation into one helper function, then enhances that function
to also do the new checks. If we could always trust the source
to validate migration, then the destination would not have to
do anything; but since older servers that did not do checking
can migrate to newer destinations, we have to repeat some of
the same checks on the destination; meanwhile, we want to
detect failures as soon as possible. With migration v2, this
means that validation will reject things at Prepare on the
destination if the XML exposes the problem, otherwise at Perform
on the source; with migration v3, this means that validation
will reject things at Begin on the source, or if the source
is old and the XML exposes the problem, then at Prepare on the
destination.
This patch is necessarily over-strict. Once a later patch
properly handles auto-cleanup of snapshot metadata on the
death of a transient domain, then the only time we actually
need snapshots to prevent migration is when using the
--undefinesource flag on a persistent source domain.
It is possible to recreate snapshot metadata on the destination
with VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE and
VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT. But for now, that is limited,
since if we delete the snapshot metadata prior to migration,
then we won't know the name of the current snapshot to pass
along; and if we delete the snapshot metadata after migration
and use the v3 migration cookie to pass along the name of the
current snapshot, then we need a way to bypass the fact that
this patch refuses migration with snapshot metadata present.
So eventually, we may have to introduce migration protocol v4
that allows feature negotiation and an arbitrary number of
handshake exchanges, so as to pass as many rpc calls as needed
to transfer all the snapshot xml hierarchy.
But all of that is thoughts for the future; for now, the best
course of action is to quit early, rather than get into a
funky state of stale metadata; then relax restrictions later.
* src/qemu/qemu_migration.h (qemuMigrationIsAllowed): Make static.
* src/qemu/qemu_migration.c (qemuMigrationIsAllowed): Alter
signature, and allow checks for both outgoing and incoming.
(qemuMigrationBegin, qemuMigrationPrepareAny)
(qemuMigrationPerformJob): Update callers.
2011-08-12 19:23:09 +00:00
|
|
|
|
|
|
|
}
|
2012-10-19 11:36:33 +00:00
|
|
|
|
2015-10-06 15:02:09 +00:00
|
|
|
/* following checks don't make sense for offline migration */
|
|
|
|
if (!(flags & VIR_MIGRATE_OFFLINE)) {
|
|
|
|
if (qemuProcessAutoDestroyActive(driver, vm)) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID,
|
|
|
|
"%s", _("domain is marked for auto destroy"));
|
|
|
|
return false;
|
|
|
|
}
|
2015-10-06 13:53:02 +00:00
|
|
|
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2015-10-06 15:02:09 +00:00
|
|
|
if (qemuDomainHasBlockjob(vm, false)) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
|
|
|
_("domain has an active block job"));
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!qemuMigrationIsAllowedHostdev(vm->def))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (vm->def->cpu && vm->def->cpu->mode != VIR_CPU_MODE_HOST_PASSTHROUGH) {
|
|
|
|
for (i = 0; i < vm->def->cpu->nfeatures; i++) {
|
|
|
|
virCPUFeatureDefPtr feature = &vm->def->cpu->features[i];
|
2014-05-06 11:55:44 +00:00
|
|
|
|
2015-10-06 15:02:09 +00:00
|
|
|
if (feature->policy != VIR_CPU_FEATURE_REQUIRE)
|
|
|
|
continue;
|
2014-05-06 11:55:44 +00:00
|
|
|
|
2015-10-06 15:02:09 +00:00
|
|
|
/* QEMU blocks migration and save with invariant TSC enabled */
|
|
|
|
if (STREQ(feature->name, "invtsc")) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID,
|
|
|
|
_("domain has CPU feature: %s"),
|
|
|
|
feature->name);
|
|
|
|
return false;
|
|
|
|
}
|
2014-09-29 13:58:38 +00:00
|
|
|
}
|
2014-05-06 11:55:44 +00:00
|
|
|
}
|
|
|
|
|
2015-10-06 15:02:09 +00:00
|
|
|
/* Verify that memory device config can be transferred reliably */
|
|
|
|
for (i = 0; i < vm->def->nmems; i++) {
|
|
|
|
virDomainMemoryDefPtr mem = vm->def->mems[i];
|
2015-01-19 13:28:14 +00:00
|
|
|
|
2015-10-06 15:02:09 +00:00
|
|
|
if (mem->model == VIR_DOMAIN_MEMORY_MODEL_DIMM &&
|
|
|
|
mem->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_DIMM) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
|
|
|
_("domain's dimm info lacks slot ID "
|
|
|
|
"or base address"));
|
2015-01-19 13:28:14 +00:00
|
|
|
|
2015-10-06 15:02:09 +00:00
|
|
|
return false;
|
|
|
|
}
|
2015-01-19 13:28:14 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-01-31 10:47:03 +00:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2012-02-21 12:20:06 +00:00
|
|
|
static bool
|
2015-06-15 22:42:10 +00:00
|
|
|
qemuMigrationIsSafe(virDomainDefPtr def,
|
|
|
|
size_t nmigrate_disks,
|
|
|
|
const char **migrate_disks)
|
2012-02-21 12:20:06 +00:00
|
|
|
{
|
Convert 'int i' to 'size_t i' in src/qemu files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 14:09:33 +00:00
|
|
|
size_t i;
|
2012-02-21 12:20:06 +00:00
|
|
|
|
2013-05-21 07:21:20 +00:00
|
|
|
for (i = 0; i < def->ndisks; i++) {
|
2012-02-21 12:20:06 +00:00
|
|
|
virDomainDiskDefPtr disk = def->disks[i];
|
conf: use disk source accessors in qemu/
Part of a series of cleanups to use new accessor methods.
* src/qemu/qemu_conf.c (qemuCheckSharedDevice)
(qemuAddSharedDevice, qemuRemoveSharedDevice, qemuSetUnprivSGIO):
Use accessors.
* src/qemu/qemu_domain.c (qemuDomainDeviceDefPostParse)
(qemuDomainObjCheckDiskTaint, qemuDomainSnapshotForEachQcow2Raw)
(qemuDomainCheckRemoveOptionalDisk, qemuDomainCheckDiskPresence)
(qemuDiskChainCheckBroken, qemuDomainDetermineDiskChain):
Likewise.
* src/qemu/qemu_hotplug.c (qemuDomainChangeEjectableMedia)
(qemuDomainCheckEjectableMedia)
(qemuDomainAttachVirtioDiskDevice, qemuDomainAttachSCSIDisk)
(qemuDomainAttachUSBMassstorageDevice)
(qemuDomainAttachDeviceDiskLive, qemuDomainRemoveDiskDevice)
(qemuDomainDetachVirtioDiskDevice, qemuDomainDetachDiskDevice):
Likewise.
* src/qemu/qemu_migration.c (qemuMigrationStartNBDServer)
(qemuMigrationDriveMirror, qemuMigrationCancelDriveMirror)
(qemuMigrationIsSafe): Likewise.
* src/qemu/qemu_process.c (qemuProcessGetVolumeQcowPassphrase)
(qemuProcessHandleIOError, qemuProcessHandleBlockJob)
(qemuProcessInitPasswords): Likewise.
* src/qemu/qemu_driver.c (qemuDomainChangeDiskMediaLive)
(qemuDomainGetBlockInfo, qemuDiskPathToAlias): Likewise.
Signed-off-by: Eric Blake <eblake@redhat.com>
2014-03-18 19:16:47 +00:00
|
|
|
const char *src = virDomainDiskGetSource(disk);
|
2012-02-21 12:20:06 +00:00
|
|
|
|
2012-03-05 11:10:21 +00:00
|
|
|
/* Our code elsewhere guarantees shared disks are either readonly (in
|
|
|
|
* which case cache mode doesn't matter) or used with cache=none */
|
2015-06-15 22:42:10 +00:00
|
|
|
if (qemuMigrateDisk(disk, nmigrate_disks, migrate_disks) &&
|
2012-03-05 11:10:21 +00:00
|
|
|
disk->cachemode != VIR_DOMAIN_DISK_CACHE_DISABLE) {
|
2013-04-11 16:28:35 +00:00
|
|
|
int rc;
|
2012-06-06 18:36:31 +00:00
|
|
|
|
conf: move host disk type to util/
A continuation of the migration of disk details to virstoragefile.
This patch moves a single enum, but converting the name has quite
a bit of fallout.
* src/conf/domain_conf.h (virDomainDiskType): Move...
* src/util/virstoragefile.h (virStorageType): ...and rename.
* src/bhyve/bhyve_command.c (bhyveBuildDiskArgStr)
(virBhyveProcessBuildLoadCmd): Update clients.
* src/conf/domain_conf.c (virDomainDiskSourceDefParse)
(virDomainDiskDefParseXML, virDomainDiskSourceDefFormatInternal)
(virDomainDiskDefFormat, virDomainDiskGetActualType)
(virDomainDiskDefForeachPath, virDomainDiskSourceIsBlockType):
Likewise.
* src/conf/snapshot_conf.h (_virDomainSnapshotDiskDef): Likewise.
* src/conf/snapshot_conf.c (virDomainSnapshotDiskDefParseXML)
(virDomainSnapshotAlignDisks, virDomainSnapshotDiskDefFormat):
Likewise.
* src/esx/esx_driver.c (esxAutodetectSCSIControllerModel)
(esxDomainDefineXML): Likewise.
* src/locking/domain_lock.c (virDomainLockManagerAddDisk):
Likewise.
* src/lxc/lxc_controller.c
(virLXCControllerSetupLoopDeviceDisk)
(virLXCControllerSetupNBDDeviceDisk)
(virLXCControllerSetupLoopDevices, virLXCControllerSetupDisk):
Likewise.
* src/parallels/parallels_driver.c (parallelsGetHddInfo):
Likewise.
* src/phyp/phyp_driver.c (phypDiskType): Likewise.
* src/qemu/qemu_command.c (qemuGetDriveSourceString)
(qemuDomainDiskGetSourceString, qemuBuildDriveStr)
(qemuBuildCommandLine, qemuParseCommandLineDisk)
(qemuParseCommandLine): Likewise.
* src/qemu/qemu_conf.c (qemuCheckSharedDevice)
(qemuTranslateDiskSourcePool)
(qemuTranslateSnapshotDiskSourcePool): Likewise.
* src/qemu/qemu_domain.c (qemuDomainDeviceDefPostParse)
(qemuDomainDetermineDiskChain): Likewise.
* src/qemu/qemu_driver.c (qemuDomainGetBlockInfo)
(qemuDomainSnapshotPrepareDiskExternalBackingInactive)
(qemuDomainSnapshotPrepareDiskExternalBackingActive)
(qemuDomainSnapshotPrepareDiskExternalOverlayActive)
(qemuDomainSnapshotPrepareDiskExternalOverlayInactive)
(qemuDomainSnapshotPrepareDiskInternal)
(qemuDomainSnapshotPrepare)
(qemuDomainSnapshotCreateSingleDiskActive): Likewise.
* src/qemu/qemu_hotplug.c (qemuDomainChangeEjectableMedia):
Likewise.
* src/qemu/qemu_migration.c (qemuMigrationIsSafe): Likewise.
* src/security/security_apparmor.c
(AppArmorRestoreSecurityImageLabel)
(AppArmorSetSecurityImageLabel): Likewise.
* src/security/security_dac.c (virSecurityDACSetSecurityImageLabel)
(virSecurityDACRestoreSecurityImageLabelInt)
(virSecurityDACSetSecurityAllLabel): Likewise.
* src/security/security_selinux.c
(virSecuritySELinuxRestoreSecurityImageLabelInt)
(virSecuritySELinuxSetSecurityImageLabel)
(virSecuritySELinuxSetSecurityAllLabel): Likewise.
* src/storage/storage_backend.c (virStorageFileBackendForType):
Likewise.
* src/storage/storage_backend_fs.c (virStorageFileBackendFile)
(virStorageFileBackendBlock): Likewise.
* src/storage/storage_backend_gluster.c
(virStorageFileBackendGluster): Likewise.
* src/vbox/vbox_tmpl.c (vboxDomainGetXMLDesc, vboxAttachDrives)
(vboxDomainAttachDeviceImpl, vboxDomainDetachDevice): Likewise.
* src/vmware/vmware_conf.c (vmwareVmxPath): Likewise.
* src/vmx/vmx.c (virVMXParseDisk, virVMXFormatDisk)
(virVMXFormatFloppy): Likewise.
* src/xenxs/xen_sxpr.c (xenParseSxprDisks, xenParseSxpr)
(xenFormatSxprDisk): Likewise.
* src/xenxs/xen_xm.c (xenParseXM, xenFormatXMDisk): Likewise.
* tests/securityselinuxlabeltest.c (testSELinuxLoadDef):
Likewise.
* src/libvirt_private.syms (domain_conf.h): Move symbols...
(virstoragefile.h): ...as appropriate.
Signed-off-by: Eric Blake <eblake@redhat.com>
2014-03-27 21:57:49 +00:00
|
|
|
if (virDomainDiskGetType(disk) == VIR_STORAGE_TYPE_FILE) {
|
2014-03-29 20:15:33 +00:00
|
|
|
if ((rc = virFileIsSharedFS(src)) < 0)
|
2013-04-11 16:28:35 +00:00
|
|
|
return false;
|
|
|
|
else if (rc == 0)
|
2012-06-06 18:36:31 +00:00
|
|
|
continue;
|
conf: use disk source accessors in qemu/
Part of a series of cleanups to use new accessor methods.
* src/qemu/qemu_conf.c (qemuCheckSharedDevice)
(qemuAddSharedDevice, qemuRemoveSharedDevice, qemuSetUnprivSGIO):
Use accessors.
* src/qemu/qemu_domain.c (qemuDomainDeviceDefPostParse)
(qemuDomainObjCheckDiskTaint, qemuDomainSnapshotForEachQcow2Raw)
(qemuDomainCheckRemoveOptionalDisk, qemuDomainCheckDiskPresence)
(qemuDiskChainCheckBroken, qemuDomainDetermineDiskChain):
Likewise.
* src/qemu/qemu_hotplug.c (qemuDomainChangeEjectableMedia)
(qemuDomainCheckEjectableMedia)
(qemuDomainAttachVirtioDiskDevice, qemuDomainAttachSCSIDisk)
(qemuDomainAttachUSBMassstorageDevice)
(qemuDomainAttachDeviceDiskLive, qemuDomainRemoveDiskDevice)
(qemuDomainDetachVirtioDiskDevice, qemuDomainDetachDiskDevice):
Likewise.
* src/qemu/qemu_migration.c (qemuMigrationStartNBDServer)
(qemuMigrationDriveMirror, qemuMigrationCancelDriveMirror)
(qemuMigrationIsSafe): Likewise.
* src/qemu/qemu_process.c (qemuProcessGetVolumeQcowPassphrase)
(qemuProcessHandleIOError, qemuProcessHandleBlockJob)
(qemuProcessInitPasswords): Likewise.
* src/qemu/qemu_driver.c (qemuDomainChangeDiskMediaLive)
(qemuDomainGetBlockInfo, qemuDiskPathToAlias): Likewise.
Signed-off-by: Eric Blake <eblake@redhat.com>
2014-03-18 19:16:47 +00:00
|
|
|
if ((rc = virStorageFileIsClusterFS(src)) < 0)
|
2012-06-06 18:36:31 +00:00
|
|
|
return false;
|
2013-04-11 16:28:35 +00:00
|
|
|
else if (rc == 1)
|
|
|
|
continue;
|
2014-05-21 23:13:12 +00:00
|
|
|
} else if (disk->src->type == VIR_STORAGE_TYPE_NETWORK &&
|
|
|
|
disk->src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD) {
|
2012-07-02 18:55:26 +00:00
|
|
|
continue;
|
2012-06-06 18:36:31 +00:00
|
|
|
}
|
2012-02-21 12:20:06 +00:00
|
|
|
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_MIGRATE_UNSAFE, "%s",
|
|
|
|
_("Migration may lead to data corruption if disks"
|
|
|
|
" use cache != none"));
|
2012-02-21 12:20:06 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2011-01-31 10:47:03 +00:00
|
|
|
/** qemuMigrationSetOffline
|
|
|
|
* Pause domain for non-live migration.
|
|
|
|
*/
|
|
|
|
int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationSetOffline(virQEMUDriverPtr driver,
|
2011-01-31 10:47:03 +00:00
|
|
|
virDomainObjPtr vm)
|
|
|
|
{
|
|
|
|
int ret;
|
2011-06-02 15:40:33 +00:00
|
|
|
VIR_DEBUG("driver=%p vm=%p", driver, vm);
|
qemu: fix crash when mixing sync and async monitor jobs
Currently, we attempt to run sync job and async job at the same time. It
means that the monitor commands for two jobs can be run in any order.
In the function qemuDomainObjEnterMonitorInternal():
if (priv->job.active == QEMU_JOB_NONE && priv->job.asyncJob) {
if (qemuDomainObjBeginNestedJob(driver, obj) < 0)
We check whether the caller is an async job by priv->job.active and
priv->job.asynJob. But when an async job is running, and a sync job is
also running at the time of the check, then priv->job.active is not
QEMU_JOB_NONE. So we cannot check whether the caller is an async job
in the function qemuDomainObjEnterMonitorInternal(), and must instead
put the burden on the caller to tell us when an async command wants
to do a nested job.
Once the burden is on the caller, then only async monitor enters need
to worry about whether the VM is still running; for sync monitor enter,
the internal return is always 0, so lots of ignore_value can be dropped.
* src/qemu/THREADS.txt: Reflect new rules.
* src/qemu/qemu_domain.h (qemuDomainObjEnterMonitorAsync): New
prototype.
* src/qemu/qemu_process.h (qemuProcessStartCPUs)
(qemuProcessStopCPUs): Add parameter.
* src/qemu/qemu_migration.h (qemuMigrationToFile): Likewise.
(qemuMigrationWaitForCompletion): Make static.
* src/qemu/qemu_domain.c (qemuDomainObjEnterMonitorInternal): Add
parameter.
(qemuDomainObjEnterMonitorAsync): New function.
(qemuDomainObjEnterMonitor, qemuDomainObjEnterMonitorWithDriver):
Update callers.
* src/qemu/qemu_driver.c (qemuDomainSaveInternal)
(qemudDomainCoreDump, doCoreDump, processWatchdogEvent)
(qemudDomainSuspend, qemudDomainResume, qemuDomainSaveImageStartVM)
(qemuDomainSnapshotCreateActive, qemuDomainRevertToSnapshot):
Likewise.
* src/qemu/qemu_process.c (qemuProcessStopCPUs)
(qemuProcessFakeReboot, qemuProcessRecoverMigration)
(qemuProcessRecoverJob, qemuProcessStart): Likewise.
* src/qemu/qemu_migration.c (qemuMigrationToFile)
(qemuMigrationWaitForCompletion, qemuMigrationUpdateJobStatus)
(qemuMigrationJobStart, qemuDomainMigrateGraphicsRelocate)
(doNativeMigrate, doTunnelMigrate, qemuMigrationPerformJob)
(qemuMigrationPerformPhase, qemuMigrationFinish)
(qemuMigrationConfirm): Likewise.
* src/qemu/qemu_hotplug.c: Drop unneeded ignore_value.
2011-07-28 23:18:24 +00:00
|
|
|
ret = qemuProcessStopCPUs(driver, vm, VIR_DOMAIN_PAUSED_MIGRATION,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT);
|
2011-01-31 10:47:03 +00:00
|
|
|
if (ret == 0) {
|
2013-11-22 14:38:05 +00:00
|
|
|
virObjectEventPtr event;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2013-11-21 17:03:26 +00:00
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
2011-01-31 10:47:03 +00:00
|
|
|
VIR_DOMAIN_EVENT_SUSPENDED,
|
|
|
|
VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED);
|
2015-07-07 13:33:53 +00:00
|
|
|
qemuDomainEventQueue(driver, event);
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2016-01-13 15:29:58 +00:00
|
|
|
|
|
|
|
void
|
|
|
|
qemuMigrationPostcopyFailed(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm)
|
|
|
|
{
|
|
|
|
virDomainState state;
|
|
|
|
int reason;
|
|
|
|
|
|
|
|
state = virDomainObjGetState(vm, &reason);
|
|
|
|
|
|
|
|
if (state != VIR_DOMAIN_PAUSED &&
|
|
|
|
state != VIR_DOMAIN_RUNNING)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (state == VIR_DOMAIN_PAUSED &&
|
|
|
|
reason == VIR_DOMAIN_PAUSED_POSTCOPY_FAILED)
|
|
|
|
return;
|
|
|
|
|
|
|
|
VIR_WARN("Migration of domain %s failed during post-copy; "
|
|
|
|
"leaving the domain paused", vm->def->name);
|
|
|
|
|
|
|
|
if (state == VIR_DOMAIN_RUNNING) {
|
|
|
|
virObjectEventPtr event;
|
|
|
|
|
|
|
|
if (qemuProcessStopCPUs(driver, vm,
|
|
|
|
VIR_DOMAIN_PAUSED_POSTCOPY_FAILED,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_IN) < 0) {
|
|
|
|
VIR_WARN("Unable to pause guest CPUs for %s", vm->def->name);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
|
|
|
VIR_DOMAIN_EVENT_SUSPENDED,
|
|
|
|
VIR_DOMAIN_EVENT_SUSPENDED_POSTCOPY_FAILED);
|
|
|
|
qemuDomainEventQueue(driver, event);
|
|
|
|
} else {
|
|
|
|
virDomainObjSetState(vm, VIR_DOMAIN_PAUSED,
|
|
|
|
VIR_DOMAIN_PAUSED_POSTCOPY_FAILED);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-01-13 06:28:12 +00:00
|
|
|
static int
|
2016-01-28 07:04:27 +00:00
|
|
|
qemuMigrationSetOption(virQEMUDriverPtr driver,
|
2014-01-13 06:28:12 +00:00
|
|
|
virDomainObjPtr vm,
|
2016-01-28 07:04:27 +00:00
|
|
|
qemuMonitorMigrationCaps capability,
|
2014-11-10 13:46:26 +00:00
|
|
|
bool state,
|
2014-01-13 06:28:12 +00:00
|
|
|
qemuDomainAsyncJob job)
|
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm, job) < 0)
|
|
|
|
return -1;
|
|
|
|
|
2016-01-28 07:04:27 +00:00
|
|
|
ret = qemuMonitorGetMigrationCapability(priv->mon, capability);
|
2014-01-13 06:28:12 +00:00
|
|
|
|
|
|
|
if (ret < 0) {
|
|
|
|
goto cleanup;
|
2014-11-10 13:46:26 +00:00
|
|
|
} else if (ret == 0 && !state) {
|
|
|
|
/* Unsupported but we want it off anyway */
|
|
|
|
goto cleanup;
|
2014-01-13 06:28:12 +00:00
|
|
|
} else if (ret == 0) {
|
|
|
|
if (job == QEMU_ASYNC_JOB_MIGRATION_IN) {
|
2016-01-28 07:04:27 +00:00
|
|
|
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED,
|
|
|
|
_("Migration option '%s' is not supported by "
|
|
|
|
"target QEMU binary"),
|
|
|
|
qemuMonitorMigrationCapsTypeToString(capability));
|
2014-01-13 06:28:12 +00:00
|
|
|
} else {
|
2016-01-28 07:04:27 +00:00
|
|
|
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED,
|
|
|
|
_("Migration option '%s' is not supported by "
|
|
|
|
"source QEMU binary"),
|
|
|
|
qemuMonitorMigrationCapsTypeToString(capability));
|
2014-01-13 06:28:12 +00:00
|
|
|
}
|
|
|
|
ret = -1;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2016-01-28 07:04:27 +00:00
|
|
|
ret = qemuMonitorSetMigrationCapability(priv->mon, capability, state);
|
2014-01-13 06:28:12 +00:00
|
|
|
|
|
|
|
cleanup:
|
2014-12-16 09:40:58 +00:00
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0)
|
|
|
|
ret = -1;
|
2014-01-13 06:28:12 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-12-01 15:59:55 +00:00
|
|
|
|
|
|
|
static int
|
|
|
|
qemuMigrationSetPostCopy(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
bool state,
|
|
|
|
qemuDomainAsyncJob job)
|
|
|
|
{
|
2014-12-01 15:59:57 +00:00
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
|
2014-12-01 15:59:55 +00:00
|
|
|
if (qemuMigrationSetOption(driver, vm,
|
|
|
|
QEMU_MONITOR_MIGRATION_CAPS_POSTCOPY,
|
|
|
|
state, job) < 0)
|
|
|
|
return -1;
|
|
|
|
|
2014-12-01 15:59:57 +00:00
|
|
|
priv->job.postcopyEnabled = state;
|
2014-12-01 15:59:55 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2013-06-10 13:35:03 +00:00
|
|
|
static int
|
2015-05-25 14:57:49 +00:00
|
|
|
qemuMigrationWaitForSpice(virDomainObjPtr vm)
|
2013-06-10 13:35:03 +00:00
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
bool wait_for_spice = false;
|
2013-07-01 12:16:51 +00:00
|
|
|
size_t i = 0;
|
2013-06-10 13:35:03 +00:00
|
|
|
|
2016-02-29 12:18:13 +00:00
|
|
|
if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_SEAMLESS_MIGRATION) ||
|
|
|
|
!priv->job.spiceMigration)
|
2015-05-25 14:57:49 +00:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
for (i = 0; i < vm->def->ngraphics; i++) {
|
|
|
|
if (vm->def->graphics[i]->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE) {
|
|
|
|
wait_for_spice = true;
|
|
|
|
break;
|
2013-07-01 12:16:51 +00:00
|
|
|
}
|
|
|
|
}
|
2013-06-10 13:35:03 +00:00
|
|
|
|
|
|
|
if (!wait_for_spice)
|
|
|
|
return 0;
|
|
|
|
|
2015-12-16 12:14:42 +00:00
|
|
|
VIR_DEBUG("Waiting for SPICE to finish migration");
|
2015-05-25 14:57:49 +00:00
|
|
|
while (!priv->job.spiceMigrated && !priv->job.abortJob) {
|
|
|
|
if (virDomainObjWait(vm) < 0)
|
2013-06-10 13:35:03 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
2013-01-14 11:45:20 +00:00
|
|
|
|
2015-05-26 12:37:30 +00:00
|
|
|
|
|
|
|
static void
|
|
|
|
qemuMigrationUpdateJobType(qemuDomainJobInfoPtr jobInfo)
|
|
|
|
{
|
2015-11-26 12:24:31 +00:00
|
|
|
switch ((qemuMonitorMigrationStatus) jobInfo->stats.status) {
|
2015-05-26 12:37:30 +00:00
|
|
|
case QEMU_MONITOR_MIGRATION_STATUS_COMPLETED:
|
|
|
|
jobInfo->type = VIR_DOMAIN_JOB_COMPLETED;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case QEMU_MONITOR_MIGRATION_STATUS_INACTIVE:
|
|
|
|
jobInfo->type = VIR_DOMAIN_JOB_NONE;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case QEMU_MONITOR_MIGRATION_STATUS_ERROR:
|
|
|
|
jobInfo->type = VIR_DOMAIN_JOB_FAILED;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case QEMU_MONITOR_MIGRATION_STATUS_CANCELLED:
|
|
|
|
jobInfo->type = VIR_DOMAIN_JOB_CANCELLED;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case QEMU_MONITOR_MIGRATION_STATUS_SETUP:
|
|
|
|
case QEMU_MONITOR_MIGRATION_STATUS_ACTIVE:
|
2015-11-26 14:37:23 +00:00
|
|
|
case QEMU_MONITOR_MIGRATION_STATUS_POSTCOPY:
|
2015-05-26 12:37:30 +00:00
|
|
|
case QEMU_MONITOR_MIGRATION_STATUS_CANCELLING:
|
2015-11-26 12:24:31 +00:00
|
|
|
case QEMU_MONITOR_MIGRATION_STATUS_LAST:
|
2015-05-26 12:37:30 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
int
|
|
|
|
qemuMigrationFetchJobStatus(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
qemuDomainAsyncJob asyncJob,
|
|
|
|
qemuDomainJobInfoPtr jobInfo)
|
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
int rv;
|
|
|
|
|
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
|
|
|
|
return -1;
|
|
|
|
|
2015-11-26 12:23:08 +00:00
|
|
|
memset(&jobInfo->stats, 0, sizeof(jobInfo->stats));
|
|
|
|
rv = qemuMonitorGetMigrationStats(priv->mon, &jobInfo->stats);
|
2015-05-26 12:37:30 +00:00
|
|
|
|
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0 || rv < 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
qemuMigrationUpdateJobType(jobInfo);
|
|
|
|
return qemuDomainJobInfoUpdateTime(jobInfo);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-05-28 09:17:17 +00:00
|
|
|
static const char *
|
|
|
|
qemuMigrationJobName(virDomainObjPtr vm)
|
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
|
|
|
|
switch (priv->job.asyncJob) {
|
|
|
|
case QEMU_ASYNC_JOB_MIGRATION_OUT:
|
|
|
|
return _("migration job");
|
|
|
|
case QEMU_ASYNC_JOB_SAVE:
|
|
|
|
return _("domain save job");
|
|
|
|
case QEMU_ASYNC_JOB_DUMP:
|
|
|
|
return _("domain core dump job");
|
|
|
|
default:
|
|
|
|
return _("job");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-04-20 16:33:27 +00:00
|
|
|
static int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationUpdateJobStatus(virQEMUDriverPtr driver,
|
2011-04-20 16:33:27 +00:00
|
|
|
virDomainObjPtr vm,
|
2014-06-15 16:32:56 +00:00
|
|
|
qemuDomainAsyncJob asyncJob)
|
2011-01-31 10:47:03 +00:00
|
|
|
{
|
2011-04-20 16:33:27 +00:00
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
2015-05-26 12:37:30 +00:00
|
|
|
qemuDomainJobInfoPtr jobInfo = priv->job.current;
|
|
|
|
qemuDomainJobInfo newInfo = *jobInfo;
|
2013-02-08 08:58:03 +00:00
|
|
|
|
2015-05-26 12:37:30 +00:00
|
|
|
if (qemuMigrationFetchJobStatus(driver, vm, asyncJob, &newInfo) < 0)
|
|
|
|
return -1;
|
2011-04-20 16:33:27 +00:00
|
|
|
|
2015-05-26 12:37:30 +00:00
|
|
|
*jobInfo = newInfo;
|
|
|
|
return 0;
|
|
|
|
}
|
2012-09-20 09:15:31 +00:00
|
|
|
|
2011-04-20 16:33:27 +00:00
|
|
|
|
2015-05-26 12:37:30 +00:00
|
|
|
static int
|
|
|
|
qemuMigrationCheckJobStatus(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
2015-10-05 12:32:58 +00:00
|
|
|
qemuDomainAsyncJob asyncJob,
|
|
|
|
bool updateJobStats)
|
2015-05-26 12:37:30 +00:00
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
qemuDomainJobInfoPtr jobInfo = priv->job.current;
|
2014-05-22 10:29:20 +00:00
|
|
|
|
2015-05-29 06:37:59 +00:00
|
|
|
bool events = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MIGRATION_EVENT);
|
|
|
|
|
|
|
|
if (events)
|
|
|
|
qemuMigrationUpdateJobType(jobInfo);
|
|
|
|
else if (qemuMigrationUpdateJobStatus(driver, vm, asyncJob) < 0)
|
2015-05-26 12:37:30 +00:00
|
|
|
return -1;
|
2011-04-20 16:33:27 +00:00
|
|
|
|
2015-05-26 12:37:30 +00:00
|
|
|
switch (jobInfo->type) {
|
|
|
|
case VIR_DOMAIN_JOB_NONE:
|
2015-05-28 09:17:17 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"),
|
|
|
|
qemuMigrationJobName(vm), _("is not active"));
|
2015-05-26 12:37:30 +00:00
|
|
|
return -1;
|
2011-04-20 16:33:27 +00:00
|
|
|
|
2015-05-26 12:37:30 +00:00
|
|
|
case VIR_DOMAIN_JOB_FAILED:
|
2015-05-28 09:17:17 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"),
|
|
|
|
qemuMigrationJobName(vm), _("unexpectedly failed"));
|
2015-05-26 12:37:30 +00:00
|
|
|
return -1;
|
2011-04-20 16:33:27 +00:00
|
|
|
|
2015-05-26 12:37:30 +00:00
|
|
|
case VIR_DOMAIN_JOB_CANCELLED:
|
2015-05-28 09:17:17 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_ABORTED, _("%s: %s"),
|
|
|
|
qemuMigrationJobName(vm), _("canceled by client"));
|
2015-05-26 12:37:30 +00:00
|
|
|
return -1;
|
|
|
|
|
2015-05-29 06:37:59 +00:00
|
|
|
case VIR_DOMAIN_JOB_COMPLETED:
|
|
|
|
/* Fetch statistics of a completed migration */
|
2015-10-05 12:32:58 +00:00
|
|
|
if (events && updateJobStats &&
|
2015-05-29 06:37:59 +00:00
|
|
|
qemuMigrationUpdateJobStatus(driver, vm, asyncJob) < 0)
|
|
|
|
return -1;
|
|
|
|
break;
|
|
|
|
|
2015-05-26 12:37:30 +00:00
|
|
|
case VIR_DOMAIN_JOB_BOUNDED:
|
|
|
|
case VIR_DOMAIN_JOB_UNBOUNDED:
|
|
|
|
case VIR_DOMAIN_JOB_LAST:
|
2011-04-20 16:33:27 +00:00
|
|
|
break;
|
|
|
|
}
|
2015-05-26 12:37:30 +00:00
|
|
|
return 0;
|
2011-04-20 16:33:27 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-10-05 12:36:15 +00:00
|
|
|
enum qemuMigrationCompletedFlags {
|
|
|
|
QEMU_MIGRATION_COMPLETED_ABORT_ON_ERROR = (1 << 0),
|
|
|
|
QEMU_MIGRATION_COMPLETED_CHECK_STORAGE = (1 << 1),
|
2015-10-05 12:32:58 +00:00
|
|
|
QEMU_MIGRATION_COMPLETED_UPDATE_STATS = (1 << 2),
|
2015-11-26 14:37:23 +00:00
|
|
|
QEMU_MIGRATION_COMPLETED_POSTCOPY = (1 << 3),
|
2015-10-05 12:36:15 +00:00
|
|
|
};
|
|
|
|
|
2015-05-28 09:58:11 +00:00
|
|
|
/**
|
|
|
|
* Returns 1 if migration completed successfully,
|
|
|
|
* 0 if the domain is still being migrated,
|
|
|
|
* -1 migration failed,
|
|
|
|
* -2 something else failed, we need to cancel migration.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
qemuMigrationCompleted(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
qemuDomainAsyncJob asyncJob,
|
|
|
|
virConnectPtr dconn,
|
2015-10-05 12:36:15 +00:00
|
|
|
unsigned int flags)
|
2015-05-28 09:58:11 +00:00
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
qemuDomainJobInfoPtr jobInfo = priv->job.current;
|
|
|
|
int pauseReason;
|
2015-10-05 12:32:58 +00:00
|
|
|
bool updateStats = !!(flags & QEMU_MIGRATION_COMPLETED_UPDATE_STATS);
|
2015-05-28 09:58:11 +00:00
|
|
|
|
2015-10-05 12:32:58 +00:00
|
|
|
if (qemuMigrationCheckJobStatus(driver, vm, asyncJob, updateStats) < 0)
|
2015-05-28 09:58:11 +00:00
|
|
|
goto error;
|
|
|
|
|
2015-10-05 12:36:15 +00:00
|
|
|
if (flags & QEMU_MIGRATION_COMPLETED_CHECK_STORAGE &&
|
|
|
|
qemuMigrationDriveMirrorReady(driver, vm) < 0)
|
2015-05-28 09:58:11 +00:00
|
|
|
goto error;
|
|
|
|
|
2015-10-05 12:36:15 +00:00
|
|
|
if (flags & QEMU_MIGRATION_COMPLETED_ABORT_ON_ERROR &&
|
2015-05-28 09:58:11 +00:00
|
|
|
virDomainObjGetState(vm, &pauseReason) == VIR_DOMAIN_PAUSED &&
|
|
|
|
pauseReason == VIR_DOMAIN_PAUSED_IOERROR) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"),
|
|
|
|
qemuMigrationJobName(vm), _("failed due to I/O error"));
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (dconn && virConnectIsAlive(dconn) <= 0) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
|
|
|
|
_("Lost connection to destination host"));
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
2015-11-26 14:37:23 +00:00
|
|
|
/* In case of postcopy the source considers migration completed at the
|
|
|
|
* moment it switched from active to postcopy-active state. The destination
|
|
|
|
* will continue waiting until the migrate state changes to completed.
|
|
|
|
*/
|
|
|
|
if (flags & QEMU_MIGRATION_COMPLETED_POSTCOPY &&
|
|
|
|
jobInfo->type == VIR_DOMAIN_JOB_UNBOUNDED &&
|
|
|
|
jobInfo->stats.status == QEMU_MONITOR_MIGRATION_STATUS_POSTCOPY) {
|
|
|
|
VIR_DEBUG("Migration switched to post-copy");
|
|
|
|
if (updateStats &&
|
|
|
|
qemuMigrationUpdateJobStatus(driver, vm, asyncJob) < 0)
|
|
|
|
goto error;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2015-05-28 09:58:11 +00:00
|
|
|
if (jobInfo->type == VIR_DOMAIN_JOB_COMPLETED)
|
|
|
|
return 1;
|
|
|
|
else
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
error:
|
|
|
|
if (jobInfo->type == VIR_DOMAIN_JOB_UNBOUNDED) {
|
|
|
|
/* The migration was aborted by us rather than QEMU itself. */
|
|
|
|
jobInfo->type = VIR_DOMAIN_JOB_FAILED;
|
|
|
|
return -2;
|
|
|
|
} else if (jobInfo->type == VIR_DOMAIN_JOB_COMPLETED) {
|
|
|
|
jobInfo->type = VIR_DOMAIN_JOB_FAILED;
|
|
|
|
return -1;
|
|
|
|
} else {
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-05-22 10:29:20 +00:00
|
|
|
/* Returns 0 on success, -2 when migration needs to be cancelled, or -1 when
|
|
|
|
* QEMU reports failed migration.
|
|
|
|
*/
|
qemu: fix crash when mixing sync and async monitor jobs
Currently, we attempt to run sync job and async job at the same time. It
means that the monitor commands for two jobs can be run in any order.
In the function qemuDomainObjEnterMonitorInternal():
if (priv->job.active == QEMU_JOB_NONE && priv->job.asyncJob) {
if (qemuDomainObjBeginNestedJob(driver, obj) < 0)
We check whether the caller is an async job by priv->job.active and
priv->job.asynJob. But when an async job is running, and a sync job is
also running at the time of the check, then priv->job.active is not
QEMU_JOB_NONE. So we cannot check whether the caller is an async job
in the function qemuDomainObjEnterMonitorInternal(), and must instead
put the burden on the caller to tell us when an async command wants
to do a nested job.
Once the burden is on the caller, then only async monitor enters need
to worry about whether the VM is still running; for sync monitor enter,
the internal return is always 0, so lots of ignore_value can be dropped.
* src/qemu/THREADS.txt: Reflect new rules.
* src/qemu/qemu_domain.h (qemuDomainObjEnterMonitorAsync): New
prototype.
* src/qemu/qemu_process.h (qemuProcessStartCPUs)
(qemuProcessStopCPUs): Add parameter.
* src/qemu/qemu_migration.h (qemuMigrationToFile): Likewise.
(qemuMigrationWaitForCompletion): Make static.
* src/qemu/qemu_domain.c (qemuDomainObjEnterMonitorInternal): Add
parameter.
(qemuDomainObjEnterMonitorAsync): New function.
(qemuDomainObjEnterMonitor, qemuDomainObjEnterMonitorWithDriver):
Update callers.
* src/qemu/qemu_driver.c (qemuDomainSaveInternal)
(qemudDomainCoreDump, doCoreDump, processWatchdogEvent)
(qemudDomainSuspend, qemudDomainResume, qemuDomainSaveImageStartVM)
(qemuDomainSnapshotCreateActive, qemuDomainRevertToSnapshot):
Likewise.
* src/qemu/qemu_process.c (qemuProcessStopCPUs)
(qemuProcessFakeReboot, qemuProcessRecoverMigration)
(qemuProcessRecoverJob, qemuProcessStart): Likewise.
* src/qemu/qemu_migration.c (qemuMigrationToFile)
(qemuMigrationWaitForCompletion, qemuMigrationUpdateJobStatus)
(qemuMigrationJobStart, qemuDomainMigrateGraphicsRelocate)
(doNativeMigrate, doTunnelMigrate, qemuMigrationPerformJob)
(qemuMigrationPerformPhase, qemuMigrationFinish)
(qemuMigrationConfirm): Likewise.
* src/qemu/qemu_hotplug.c: Drop unneeded ignore_value.
2011-07-28 23:18:24 +00:00
|
|
|
static int
|
2014-08-21 13:08:39 +00:00
|
|
|
qemuMigrationWaitForCompletion(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
2014-06-15 16:32:56 +00:00
|
|
|
qemuDomainAsyncJob asyncJob,
|
2014-08-21 13:08:39 +00:00
|
|
|
virConnectPtr dconn,
|
2015-12-17 12:46:18 +00:00
|
|
|
unsigned int flags)
|
2011-04-20 16:33:27 +00:00
|
|
|
{
|
2011-01-31 10:47:03 +00:00
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
2014-08-21 13:08:39 +00:00
|
|
|
qemuDomainJobInfoPtr jobInfo = priv->job.current;
|
2015-05-29 06:38:44 +00:00
|
|
|
bool events = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MIGRATION_EVENT);
|
2015-05-28 09:58:11 +00:00
|
|
|
int rv;
|
2011-05-13 10:11:47 +00:00
|
|
|
|
2015-12-17 12:46:18 +00:00
|
|
|
flags |= QEMU_MIGRATION_COMPLETED_UPDATE_STATS;
|
2015-10-05 12:36:15 +00:00
|
|
|
|
2014-08-21 13:08:39 +00:00
|
|
|
jobInfo->type = VIR_DOMAIN_JOB_UNBOUNDED;
|
2015-10-05 12:36:15 +00:00
|
|
|
while ((rv = qemuMigrationCompleted(driver, vm, asyncJob,
|
|
|
|
dconn, flags)) != 1) {
|
2015-05-28 09:58:11 +00:00
|
|
|
if (rv < 0)
|
|
|
|
return rv;
|
2011-09-23 06:56:56 +00:00
|
|
|
|
2015-05-29 06:38:44 +00:00
|
|
|
if (events) {
|
|
|
|
if (virDomainObjWait(vm) < 0) {
|
|
|
|
jobInfo->type = VIR_DOMAIN_JOB_FAILED;
|
|
|
|
return -2;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
/* Poll every 50ms for progress & to allow cancellation */
|
|
|
|
struct timespec ts = { .tv_sec = 0, .tv_nsec = 50 * 1000 * 1000ull };
|
|
|
|
|
|
|
|
virObjectUnlock(vm);
|
|
|
|
nanosleep(&ts, NULL);
|
|
|
|
virObjectLock(vm);
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
2015-05-13 16:08:50 +00:00
|
|
|
qemuDomainJobInfoUpdateDowntime(jobInfo);
|
|
|
|
VIR_FREE(priv->job.completed);
|
|
|
|
if (VIR_ALLOC(priv->job.completed) == 0)
|
|
|
|
*priv->job.completed = *jobInfo;
|
|
|
|
|
2015-05-28 09:58:11 +00:00
|
|
|
return 0;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-10-15 17:49:22 +00:00
|
|
|
static int
|
|
|
|
qemuMigrationWaitForDestCompletion(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
2015-11-26 14:37:23 +00:00
|
|
|
qemuDomainAsyncJob asyncJob,
|
|
|
|
bool postcopy)
|
2015-10-15 17:49:22 +00:00
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
2015-11-26 14:37:23 +00:00
|
|
|
unsigned int flags = 0;
|
2015-10-15 17:49:22 +00:00
|
|
|
int rv;
|
|
|
|
|
|
|
|
if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MIGRATION_EVENT))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
VIR_DEBUG("Waiting for incoming migration to complete");
|
|
|
|
|
2015-11-26 14:37:23 +00:00
|
|
|
if (postcopy)
|
|
|
|
flags = QEMU_MIGRATION_COMPLETED_POSTCOPY;
|
|
|
|
|
|
|
|
while ((rv = qemuMigrationCompleted(driver, vm, asyncJob,
|
|
|
|
NULL, flags)) != 1) {
|
2015-10-15 17:49:22 +00:00
|
|
|
if (rv < 0 || virDomainObjWait(vm) < 0)
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-02-17 13:39:36 +00:00
|
|
|
static int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuDomainMigrateGraphicsRelocate(virQEMUDriverPtr driver,
|
2011-02-17 13:39:36 +00:00
|
|
|
virDomainObjPtr vm,
|
2013-06-18 10:17:18 +00:00
|
|
|
qemuMigrationCookiePtr cookie,
|
|
|
|
const char *graphicsuri)
|
2011-02-17 13:39:36 +00:00
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
2013-06-18 10:17:18 +00:00
|
|
|
int ret = -1;
|
|
|
|
const char *listenAddress = NULL;
|
qemu: Reformat listen address prior to checking
Currently, a listen address for a SPICE server can be specified. Later,
when the domain is migrated, we need to relocate the graphics which
involves telling new destination to the SPICE server. However, we can't
just assume the listen address is the new location, because the listen
address can be ANYCAST (0.0.0.0 for IPv4, :: for IPv6). In which case,
we want to pass the remote hostname. But there are some troubles with
ANYCAST. In both IPv4 and IPv6 it has many ways for specifying such
address. For instance, in IPv4: 0, 0.0, 0.0.0, 0.0.0.0. The number of
variations gets bigger in IPv6 world. Hence, in order to check for
ANYCAST address sanely, we should take the provided listen address,
parse it and format back in it's full form. Which is exactly what this
patch does.
2013-06-05 15:05:50 +00:00
|
|
|
virSocketAddr addr;
|
2013-06-18 10:17:18 +00:00
|
|
|
virURIPtr uri = NULL;
|
|
|
|
int type = -1;
|
|
|
|
int port = -1;
|
|
|
|
int tlsPort = -1;
|
|
|
|
const char *tlsSubject = NULL;
|
2011-02-17 13:39:36 +00:00
|
|
|
|
2013-06-18 10:17:18 +00:00
|
|
|
if (!cookie || (!cookie->graphics && !graphicsuri))
|
2011-02-17 13:39:36 +00:00
|
|
|
return 0;
|
|
|
|
|
2013-06-18 10:17:18 +00:00
|
|
|
if (graphicsuri && !(uri = virURIParse(graphicsuri)))
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (cookie->graphics) {
|
|
|
|
type = cookie->graphics->type;
|
|
|
|
|
|
|
|
listenAddress = cookie->graphics->listen;
|
|
|
|
|
|
|
|
if (!listenAddress ||
|
|
|
|
(virSocketAddrParse(&addr, listenAddress, AF_UNSPEC) > 0 &&
|
|
|
|
virSocketAddrIsWildcard(&addr)))
|
|
|
|
listenAddress = cookie->remoteHostname;
|
|
|
|
|
|
|
|
port = cookie->graphics->port;
|
|
|
|
tlsPort = cookie->graphics->tlsPort;
|
|
|
|
tlsSubject = cookie->graphics->tlsSubject;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (uri) {
|
Convert 'int i' to 'size_t i' in src/qemu files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 14:09:33 +00:00
|
|
|
size_t i;
|
2013-06-18 10:17:18 +00:00
|
|
|
|
|
|
|
if ((type = virDomainGraphicsTypeFromString(uri->scheme)) < 0) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG,
|
|
|
|
_("unknown graphics type %s"), uri->scheme);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (uri->server)
|
|
|
|
listenAddress = uri->server;
|
|
|
|
if (uri->port > 0)
|
|
|
|
port = uri->port;
|
|
|
|
|
|
|
|
for (i = 0; i < uri->paramsCount; i++) {
|
|
|
|
virURIParamPtr param = uri->params + i;
|
|
|
|
|
|
|
|
if (STRCASEEQ(param->name, "tlsPort")) {
|
|
|
|
if (virStrToLong_i(param->value, NULL, 10, &tlsPort) < 0) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG,
|
|
|
|
_("invalid tlsPort number: %s"),
|
|
|
|
param->value);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
} else if (STRCASEEQ(param->name, "tlsSubject")) {
|
|
|
|
tlsSubject = param->value;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2011-02-17 13:39:36 +00:00
|
|
|
|
|
|
|
/* QEMU doesn't support VNC relocation yet, so
|
|
|
|
* skip it to avoid generating an error
|
|
|
|
*/
|
2013-06-18 10:17:18 +00:00
|
|
|
if (type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE) {
|
|
|
|
ret = 0;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2013-04-10 15:16:06 +00:00
|
|
|
|
2013-06-18 10:17:18 +00:00
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT) == 0) {
|
|
|
|
ret = qemuMonitorGraphicsRelocate(priv->mon, type, listenAddress,
|
|
|
|
port, tlsPort, tlsSubject);
|
2016-02-29 12:18:13 +00:00
|
|
|
priv->job.spiceMigration = !ret;
|
2014-12-16 09:40:58 +00:00
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0)
|
|
|
|
ret = -1;
|
2011-06-30 09:23:50 +00:00
|
|
|
}
|
2011-02-17 13:39:36 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2013-06-18 10:17:18 +00:00
|
|
|
virURIFree(uri);
|
2011-02-17 13:39:36 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2012-10-01 15:18:20 +00:00
|
|
|
static int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuDomainMigrateOPDRelocate(virQEMUDriverPtr driver ATTRIBUTE_UNUSED,
|
2012-10-01 15:18:20 +00:00
|
|
|
virDomainObjPtr vm,
|
|
|
|
qemuMigrationCookiePtr cookie)
|
|
|
|
{
|
2012-10-01 15:18:22 +00:00
|
|
|
virDomainNetDefPtr netptr;
|
|
|
|
int ret = -1;
|
Convert 'int i' to 'size_t i' in src/qemu files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 14:09:33 +00:00
|
|
|
size_t i;
|
2012-10-01 15:18:20 +00:00
|
|
|
|
|
|
|
for (i = 0; i < cookie->network->nnets; i++) {
|
|
|
|
netptr = vm->def->nets[i];
|
|
|
|
|
|
|
|
switch (cookie->network->net[i].vporttype) {
|
|
|
|
case VIR_NETDEV_VPORT_PROFILE_NONE:
|
|
|
|
case VIR_NETDEV_VPORT_PROFILE_8021QBG:
|
|
|
|
case VIR_NETDEV_VPORT_PROFILE_8021QBH:
|
2012-10-01 15:18:22 +00:00
|
|
|
break;
|
2012-10-01 15:18:20 +00:00
|
|
|
case VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH:
|
2012-10-01 15:18:22 +00:00
|
|
|
if (virNetDevOpenvswitchSetMigrateData(cookie->network->net[i].portdata,
|
|
|
|
netptr->ifname) != 0) {
|
2014-11-28 08:37:42 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Unable to run command to set OVS port data for "
|
|
|
|
"interface %s"), netptr->ifname);
|
2012-10-01 15:18:22 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
break;
|
2012-10-01 15:18:20 +00:00
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-10-01 15:18:22 +00:00
|
|
|
ret = 0;
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2012-10-01 15:18:20 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-10-20 13:48:33 +00:00
|
|
|
int
|
|
|
|
qemuMigrationCheckIncoming(virQEMUCapsPtr qemuCaps,
|
|
|
|
const char *migrateFrom)
|
|
|
|
{
|
|
|
|
if (STRPREFIX(migrateFrom, "rdma")) {
|
|
|
|
if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_MIGRATE_RDMA)) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
|
|
|
|
_("incoming RDMA migration is not supported "
|
|
|
|
"with this QEMU binary"));
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
} else if (!STRPREFIX(migrateFrom, "tcp") &&
|
|
|
|
!STRPREFIX(migrateFrom, "exec") &&
|
|
|
|
!STRPREFIX(migrateFrom, "fd") &&
|
|
|
|
!STRPREFIX(migrateFrom, "unix") &&
|
|
|
|
STRNEQ(migrateFrom, "stdio")) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
|
|
|
|
_("unknown migration protocol"));
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
char *
|
|
|
|
qemuMigrationIncomingURI(const char *migrateFrom,
|
|
|
|
int migrateFd)
|
|
|
|
{
|
|
|
|
char *uri = NULL;
|
|
|
|
|
|
|
|
if (STREQ(migrateFrom, "stdio"))
|
|
|
|
ignore_value(virAsprintf(&uri, "fd:%d", migrateFd));
|
|
|
|
else
|
|
|
|
ignore_value(VIR_STRDUP(uri, migrateFrom));
|
|
|
|
|
|
|
|
return uri;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-11-11 17:02:23 +00:00
|
|
|
int
|
|
|
|
qemuMigrationRunIncoming(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *uri,
|
|
|
|
qemuDomainAsyncJob asyncJob)
|
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
int ret = -1;
|
|
|
|
int rv;
|
|
|
|
|
|
|
|
VIR_DEBUG("Setting up incoming migration with URI %s", uri);
|
|
|
|
|
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
rv = qemuMonitorMigrateIncoming(priv->mon, uri);
|
|
|
|
|
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0 || rv < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (asyncJob == QEMU_ASYNC_JOB_MIGRATION_IN) {
|
|
|
|
/* qemuMigrationWaitForDestCompletion is called from the Finish phase */
|
|
|
|
ret = 0;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2015-11-26 14:37:23 +00:00
|
|
|
if (qemuMigrationWaitForDestCompletion(driver, vm, asyncJob, false) < 0)
|
2015-11-11 17:02:23 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2012-03-19 15:48:43 +00:00
|
|
|
/* This is called for outgoing non-p2p migrations when a connection to the
|
|
|
|
* client which initiated the migration was closed but we were waiting for it
|
|
|
|
* to follow up with the next phase, that is, in between
|
|
|
|
* qemuDomainMigrateBegin3 and qemuDomainMigratePerform3 or
|
|
|
|
* qemuDomainMigratePerform3 and qemuDomainMigrateConfirm3.
|
|
|
|
*/
|
2013-07-15 14:53:13 +00:00
|
|
|
static virDomainObjPtr
|
|
|
|
qemuMigrationCleanup(virDomainObjPtr vm,
|
|
|
|
virConnectPtr conn,
|
|
|
|
void *opaque)
|
2012-03-19 15:48:43 +00:00
|
|
|
{
|
2013-07-15 14:53:13 +00:00
|
|
|
virQEMUDriverPtr driver = opaque;
|
2012-03-19 15:48:43 +00:00
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
|
|
|
|
VIR_DEBUG("vm=%s, conn=%p, asyncJob=%s, phase=%s",
|
|
|
|
vm->def->name, conn,
|
|
|
|
qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
|
|
|
|
qemuDomainAsyncJobPhaseToString(priv->job.asyncJob,
|
|
|
|
priv->job.phase));
|
|
|
|
|
|
|
|
if (!qemuMigrationJobIsActive(vm, QEMU_ASYNC_JOB_MIGRATION_OUT))
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
VIR_DEBUG("The connection which started outgoing migration of domain %s"
|
|
|
|
" was closed; canceling the migration",
|
|
|
|
vm->def->name);
|
|
|
|
|
2014-06-15 16:32:56 +00:00
|
|
|
switch ((qemuMigrationJobPhase) priv->job.phase) {
|
2012-03-19 15:48:43 +00:00
|
|
|
case QEMU_MIGRATION_PHASE_BEGIN3:
|
|
|
|
/* just forget we were about to migrate */
|
|
|
|
qemuDomainObjDiscardAsyncJob(driver, vm);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case QEMU_MIGRATION_PHASE_PERFORM3_DONE:
|
|
|
|
VIR_WARN("Migration of domain %s finished but we don't know if the"
|
|
|
|
" domain was successfully started on destination or not",
|
|
|
|
vm->def->name);
|
|
|
|
/* clear the job and let higher levels decide what to do */
|
|
|
|
qemuDomainObjDiscardAsyncJob(driver, vm);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case QEMU_MIGRATION_PHASE_PERFORM3:
|
|
|
|
/* cannot be seen without an active migration API; unreachable */
|
|
|
|
case QEMU_MIGRATION_PHASE_CONFIRM3:
|
|
|
|
case QEMU_MIGRATION_PHASE_CONFIRM3_CANCELLED:
|
|
|
|
/* all done; unreachable */
|
|
|
|
case QEMU_MIGRATION_PHASE_PREPARE:
|
|
|
|
case QEMU_MIGRATION_PHASE_FINISH2:
|
|
|
|
case QEMU_MIGRATION_PHASE_FINISH3:
|
|
|
|
/* incoming migration; unreachable */
|
|
|
|
case QEMU_MIGRATION_PHASE_PERFORM2:
|
|
|
|
/* single phase outgoing migration; unreachable */
|
|
|
|
case QEMU_MIGRATION_PHASE_NONE:
|
|
|
|
case QEMU_MIGRATION_PHASE_LAST:
|
|
|
|
/* unreachable */
|
|
|
|
;
|
|
|
|
}
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2012-03-19 15:48:43 +00:00
|
|
|
return vm;
|
|
|
|
}
|
|
|
|
|
2013-06-25 07:44:14 +00:00
|
|
|
|
2011-07-19 00:27:32 +00:00
|
|
|
/* The caller is supposed to lock the vm and start a migration job. */
|
2015-06-15 22:42:04 +00:00
|
|
|
static char *
|
|
|
|
qemuMigrationBeginPhase(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *xmlin,
|
|
|
|
const char *dname,
|
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
2015-06-15 22:42:10 +00:00
|
|
|
size_t nmigrate_disks,
|
|
|
|
const char **migrate_disks,
|
2015-06-15 22:42:04 +00:00
|
|
|
unsigned long flags)
|
2011-02-03 11:09:28 +00:00
|
|
|
{
|
|
|
|
char *rv = NULL;
|
|
|
|
qemuMigrationCookiePtr mig = NULL;
|
2011-05-27 10:30:26 +00:00
|
|
|
virDomainDefPtr def = NULL;
|
2011-07-19 00:27:32 +00:00
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
2013-02-01 17:04:15 +00:00
|
|
|
virCapsPtr caps = NULL;
|
2013-01-29 12:38:50 +00:00
|
|
|
unsigned int cookieFlags = QEMU_MIGRATION_COOKIE_LOCKSTATE;
|
2011-07-19 00:27:32 +00:00
|
|
|
|
2011-10-14 19:24:18 +00:00
|
|
|
VIR_DEBUG("driver=%p, vm=%p, xmlin=%s, dname=%s,"
|
2015-06-15 22:42:10 +00:00
|
|
|
" cookieout=%p, cookieoutlen=%p,"
|
|
|
|
" nmigrate_disks=%zu, migrate_disks=%p, flags=%lx",
|
2011-10-14 19:24:18 +00:00
|
|
|
driver, vm, NULLSTR(xmlin), NULLSTR(dname),
|
2015-06-15 22:42:10 +00:00
|
|
|
cookieout, cookieoutlen, nmigrate_disks,
|
|
|
|
migrate_disks, flags);
|
2011-02-03 11:09:28 +00:00
|
|
|
|
2013-02-01 17:04:15 +00:00
|
|
|
if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
|
|
|
|
goto cleanup;
|
|
|
|
|
2011-07-19 00:27:32 +00:00
|
|
|
/* Only set the phase if we are inside QEMU_ASYNC_JOB_MIGRATION_OUT.
|
|
|
|
* Otherwise we will start the async job later in the perform phase losing
|
|
|
|
* change protection.
|
|
|
|
*/
|
|
|
|
if (priv->job.asyncJob == QEMU_ASYNC_JOB_MIGRATION_OUT)
|
|
|
|
qemuMigrationJobSetPhase(driver, vm, QEMU_MIGRATION_PHASE_BEGIN3);
|
2011-02-03 11:09:28 +00:00
|
|
|
|
2015-10-06 14:24:48 +00:00
|
|
|
if (!qemuMigrationIsAllowed(driver, vm, true, flags))
|
2011-02-03 11:09:28 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2015-06-15 22:42:10 +00:00
|
|
|
if (!(flags & VIR_MIGRATE_UNSAFE) &&
|
|
|
|
!qemuMigrationIsSafe(vm->def, nmigrate_disks, migrate_disks))
|
2012-02-21 12:20:06 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2014-12-01 15:59:55 +00:00
|
|
|
if (flags & VIR_MIGRATE_POSTCOPY &&
|
|
|
|
(!(flags & VIR_MIGRATE_LIVE) ||
|
|
|
|
flags & VIR_MIGRATE_PAUSED)) {
|
|
|
|
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
|
|
|
|
_("post-copy migration is not supported with non-live "
|
|
|
|
"or paused migration"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2015-06-15 22:42:10 +00:00
|
|
|
if (flags & (VIR_MIGRATE_NON_SHARED_DISK | VIR_MIGRATE_NON_SHARED_INC)) {
|
|
|
|
bool has_drive_mirror = virQEMUCapsGet(priv->qemuCaps,
|
|
|
|
QEMU_CAPS_DRIVE_MIRROR);
|
|
|
|
|
|
|
|
if (nmigrate_disks) {
|
|
|
|
if (has_drive_mirror) {
|
|
|
|
size_t i, j;
|
|
|
|
|
|
|
|
/* Check user requested only known disk targets. */
|
|
|
|
for (i = 0; i < nmigrate_disks; i++) {
|
|
|
|
for (j = 0; j < vm->def->ndisks; j++) {
|
|
|
|
if (STREQ(vm->def->disks[j]->dst, migrate_disks[i]))
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (j == vm->def->ndisks) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG,
|
|
|
|
_("disk target %s not found"),
|
|
|
|
migrate_disks[i]);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (flags & VIR_MIGRATE_TUNNELLED) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
|
|
|
|
_("Selecting disks to migrate is not "
|
|
|
|
"implemented for tunnelled migration"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
|
|
|
|
_("qemu does not support drive-mirror command"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (has_drive_mirror) {
|
|
|
|
/* TODO support NBD for TUNNELLED migration */
|
|
|
|
if (flags & VIR_MIGRATE_TUNNELLED) {
|
|
|
|
VIR_WARN("NBD in tunnelled migration is currently not supported");
|
|
|
|
} else {
|
|
|
|
cookieFlags |= QEMU_MIGRATION_COOKIE_NBD;
|
|
|
|
priv->nbdPort = 0;
|
|
|
|
}
|
2013-01-29 12:38:50 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-09-14 14:42:46 +00:00
|
|
|
if (virDomainDefHasMemoryHotplug(vm->def) ||
|
2015-09-08 13:06:26 +00:00
|
|
|
((flags & VIR_MIGRATE_PERSIST_DEST) &&
|
2015-09-14 14:42:46 +00:00
|
|
|
vm->newDef && virDomainDefHasMemoryHotplug(vm->newDef)))
|
2015-07-30 13:27:07 +00:00
|
|
|
cookieFlags |= QEMU_MIGRATION_COOKIE_MEMORY_HOTPLUG;
|
|
|
|
|
2011-05-18 16:34:21 +00:00
|
|
|
if (!(mig = qemuMigrationEatCookie(driver, vm, NULL, 0, 0)))
|
2011-02-03 11:09:28 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (qemuMigrationBakeCookie(mig, driver, vm,
|
|
|
|
cookieout, cookieoutlen,
|
2013-01-29 12:38:50 +00:00
|
|
|
cookieFlags) < 0)
|
2011-02-03 11:09:28 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2012-11-21 08:28:49 +00:00
|
|
|
if (flags & VIR_MIGRATE_OFFLINE) {
|
|
|
|
if (flags & (VIR_MIGRATE_NON_SHARED_DISK |
|
|
|
|
VIR_MIGRATE_NON_SHARED_INC)) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
|
|
|
_("offline migration cannot handle "
|
|
|
|
"non-shared storage"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
if (!(flags & VIR_MIGRATE_PERSIST_DEST)) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
|
|
|
_("offline migration must be specified with "
|
|
|
|
"the persistent flag set"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
if (flags & VIR_MIGRATE_TUNNELLED) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
|
|
|
_("tunnelled offline migration does not "
|
|
|
|
"make sense"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-05-27 10:30:26 +00:00
|
|
|
if (xmlin) {
|
2013-03-28 13:55:55 +00:00
|
|
|
if (!(def = virDomainDefParseString(xmlin, caps, driver->xmlopt,
|
2014-11-18 16:44:00 +00:00
|
|
|
VIR_DOMAIN_DEF_PARSE_INACTIVE)))
|
2011-05-27 10:30:26 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
qemu: Introduce qemuDomainDefCheckABIStability
https://bugzilla.redhat.com/show_bug.cgi?id=994364
Whenever we check for ABI stability, we have new xml (e.g. provided by
user, or obtained from snapshot, whatever) which we compare to old xml
and see if ABI won't break. However, if the new xml was produced via
virDomainGetXMLDesc(..., VIR_DOMAIN_XML_MIGRATABLE) it lacks some
devices, e.g. 'pci-root' controller. Hence, the ABI stability check
fails even though it is stable. Moreover, we can't simply fix
virDomainDefCheckABIStability because removing the correct devices is
task for the driver. For instance, qemu driver wants to remove the usb
controller too, while LXC driver doesn't. That's why we need special
qemu wrapper over virDomainDefCheckABIStability which removes the
correct devices from domain XML, produces MIGRATABLE xml and calls the
check ABI stability function.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2013-10-10 08:53:56 +00:00
|
|
|
if (!qemuDomainDefCheckABIStability(driver, vm->def, def))
|
2011-05-27 10:30:26 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2012-05-04 19:23:17 +00:00
|
|
|
rv = qemuDomainDefFormatLive(driver, def, false, true);
|
2011-05-27 10:30:26 +00:00
|
|
|
} else {
|
2012-05-04 19:23:17 +00:00
|
|
|
rv = qemuDomainDefFormatLive(driver, vm->def, false, true);
|
2011-05-27 10:30:26 +00:00
|
|
|
}
|
2011-02-03 11:09:28 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2011-02-03 11:09:28 +00:00
|
|
|
qemuMigrationCookieFree(mig);
|
2013-02-01 17:04:15 +00:00
|
|
|
virObjectUnref(caps);
|
2011-05-27 10:30:26 +00:00
|
|
|
virDomainDefFree(def);
|
2011-02-03 11:09:28 +00:00
|
|
|
return rv;
|
|
|
|
}
|
|
|
|
|
2013-06-25 07:44:14 +00:00
|
|
|
char *
|
|
|
|
qemuMigrationBegin(virConnectPtr conn,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *xmlin,
|
|
|
|
const char *dname,
|
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
2015-06-15 22:42:10 +00:00
|
|
|
size_t nmigrate_disks,
|
|
|
|
const char **migrate_disks,
|
2013-06-25 07:44:14 +00:00
|
|
|
unsigned long flags)
|
|
|
|
{
|
|
|
|
virQEMUDriverPtr driver = conn->privateData;
|
|
|
|
char *xml = NULL;
|
2014-06-15 16:32:56 +00:00
|
|
|
qemuDomainAsyncJob asyncJob;
|
2013-06-25 07:44:14 +00:00
|
|
|
|
|
|
|
if ((flags & VIR_MIGRATE_CHANGE_PROTECTION)) {
|
|
|
|
if (qemuMigrationJobStart(driver, vm, QEMU_ASYNC_JOB_MIGRATION_OUT) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
asyncJob = QEMU_ASYNC_JOB_MIGRATION_OUT;
|
|
|
|
} else {
|
|
|
|
if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
asyncJob = QEMU_ASYNC_JOB_NONE;
|
|
|
|
}
|
|
|
|
|
2014-02-06 13:30:59 +00:00
|
|
|
qemuMigrationStoreDomainState(vm);
|
|
|
|
|
2013-06-25 07:44:14 +00:00
|
|
|
if (!virDomainObjIsActive(vm) && !(flags & VIR_MIGRATE_OFFLINE)) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID,
|
|
|
|
"%s", _("domain is not running"));
|
|
|
|
goto endjob;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Check if there is any ejected media.
|
|
|
|
* We don't want to require them on the destination.
|
|
|
|
*/
|
|
|
|
if (!(flags & VIR_MIGRATE_OFFLINE) &&
|
|
|
|
qemuDomainCheckEjectableMedia(driver, vm, asyncJob) < 0)
|
|
|
|
goto endjob;
|
|
|
|
|
|
|
|
if (!(xml = qemuMigrationBeginPhase(driver, vm, xmlin, dname,
|
|
|
|
cookieout, cookieoutlen,
|
2015-06-15 22:42:10 +00:00
|
|
|
nmigrate_disks, migrate_disks, flags)))
|
2013-06-25 07:44:14 +00:00
|
|
|
goto endjob;
|
|
|
|
|
|
|
|
if ((flags & VIR_MIGRATE_CHANGE_PROTECTION)) {
|
|
|
|
/* We keep the job active across API calls until the confirm() call.
|
|
|
|
* This prevents any other APIs being invoked while migration is taking
|
|
|
|
* place.
|
|
|
|
*/
|
2013-07-15 14:53:13 +00:00
|
|
|
if (virCloseCallbacksSet(driver->closeCallbacks, vm, conn,
|
2015-03-30 02:40:59 +00:00
|
|
|
qemuMigrationCleanup) < 0) {
|
|
|
|
VIR_FREE(xml);
|
2013-06-25 07:44:14 +00:00
|
|
|
goto endjob;
|
2015-03-30 02:40:59 +00:00
|
|
|
}
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
qemuMigrationJobContinue(vm);
|
2013-06-25 07:44:14 +00:00
|
|
|
} else {
|
|
|
|
goto endjob;
|
|
|
|
}
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2015-04-23 15:27:58 +00:00
|
|
|
virDomainObjEndAPI(&vm);
|
2013-06-25 07:44:14 +00:00
|
|
|
return xml;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
endjob:
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
if (flags & VIR_MIGRATE_CHANGE_PROTECTION)
|
|
|
|
qemuMigrationJobFinish(driver, vm);
|
|
|
|
else
|
|
|
|
qemuDomainObjEndJob(driver, vm);
|
2013-06-25 07:44:14 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2011-02-03 11:09:28 +00:00
|
|
|
|
2011-01-31 10:47:03 +00:00
|
|
|
/* Prepare is the first step, and it runs on the destination host.
|
|
|
|
*/
|
2011-06-13 08:48:34 +00:00
|
|
|
|
2012-03-16 06:56:19 +00:00
|
|
|
static void
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationPrepareCleanup(virQEMUDriverPtr driver,
|
2012-03-16 06:56:19 +00:00
|
|
|
virDomainObjPtr vm)
|
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
|
|
|
|
VIR_DEBUG("driver=%p, vm=%s, job=%s, asyncJob=%s",
|
|
|
|
driver,
|
|
|
|
vm->def->name,
|
|
|
|
qemuDomainJobTypeToString(priv->job.active),
|
|
|
|
qemuDomainAsyncJobTypeToString(priv->job.asyncJob));
|
|
|
|
|
2013-10-11 03:27:13 +00:00
|
|
|
virPortAllocatorRelease(driver->migrationPorts, priv->migrationPort);
|
|
|
|
priv->migrationPort = 0;
|
|
|
|
|
2012-03-16 06:56:19 +00:00
|
|
|
if (!qemuMigrationJobIsActive(vm, QEMU_ASYNC_JOB_MIGRATION_IN))
|
|
|
|
return;
|
|
|
|
qemuDomainObjDiscardAsyncJob(driver, vm);
|
|
|
|
}
|
|
|
|
|
2015-11-10 12:43:04 +00:00
|
|
|
static qemuProcessIncomingDefPtr
|
2015-11-05 14:21:02 +00:00
|
|
|
qemuMigrationPrepareIncoming(virDomainObjPtr vm,
|
|
|
|
bool tunnel,
|
|
|
|
const char *protocol,
|
|
|
|
const char *listenAddress,
|
2015-11-10 12:43:04 +00:00
|
|
|
unsigned short port,
|
|
|
|
int fd)
|
2015-11-05 14:21:02 +00:00
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
2015-11-10 12:43:04 +00:00
|
|
|
qemuProcessIncomingDefPtr inc = NULL;
|
2015-11-05 14:21:02 +00:00
|
|
|
char *migrateFrom = NULL;
|
|
|
|
|
|
|
|
if (tunnel) {
|
|
|
|
if (VIR_STRDUP(migrateFrom, "stdio") < 0)
|
|
|
|
goto cleanup;
|
|
|
|
} else {
|
|
|
|
bool encloseAddress = false;
|
|
|
|
bool hostIPv6Capable = false;
|
|
|
|
bool qemuIPv6Capable = false;
|
|
|
|
struct addrinfo *info = NULL;
|
|
|
|
struct addrinfo hints = { .ai_flags = AI_ADDRCONFIG,
|
|
|
|
.ai_socktype = SOCK_STREAM };
|
|
|
|
const char *incFormat;
|
|
|
|
|
|
|
|
if (getaddrinfo("::", NULL, &hints, &info) == 0) {
|
|
|
|
freeaddrinfo(info);
|
|
|
|
hostIPv6Capable = true;
|
|
|
|
}
|
|
|
|
qemuIPv6Capable = virQEMUCapsGet(priv->qemuCaps,
|
|
|
|
QEMU_CAPS_IPV6_MIGRATION);
|
|
|
|
|
|
|
|
if (listenAddress) {
|
|
|
|
if (virSocketAddrNumericFamily(listenAddress) == AF_INET6) {
|
|
|
|
if (!qemuIPv6Capable) {
|
|
|
|
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
|
|
|
|
_("qemu isn't capable of IPv6"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
if (!hostIPv6Capable) {
|
|
|
|
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
|
|
|
|
_("host isn't capable of IPv6"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
/* IPv6 address must be escaped in brackets on the cmd line */
|
|
|
|
encloseAddress = true;
|
|
|
|
} else {
|
|
|
|
/* listenAddress is a hostname or IPv4 */
|
|
|
|
}
|
|
|
|
} else if (qemuIPv6Capable && hostIPv6Capable) {
|
|
|
|
/* Listen on :: instead of 0.0.0.0 if QEMU understands it
|
|
|
|
* and there is at least one IPv6 address configured
|
|
|
|
*/
|
|
|
|
listenAddress = "::";
|
|
|
|
encloseAddress = true;
|
|
|
|
} else {
|
|
|
|
listenAddress = "0.0.0.0";
|
|
|
|
}
|
|
|
|
|
|
|
|
/* QEMU will be started with
|
|
|
|
* -incoming protocol:[<IPv6 addr>]:port,
|
|
|
|
* -incoming protocol:<IPv4 addr>:port, or
|
|
|
|
* -incoming protocol:<hostname>:port
|
|
|
|
*/
|
|
|
|
if (encloseAddress)
|
|
|
|
incFormat = "%s:[%s]:%d";
|
|
|
|
else
|
|
|
|
incFormat = "%s:%s:%d";
|
|
|
|
if (virAsprintf(&migrateFrom, incFormat,
|
|
|
|
protocol, listenAddress, port) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2016-01-07 23:07:37 +00:00
|
|
|
inc = qemuProcessIncomingDefNew(priv->qemuCaps, listenAddress,
|
|
|
|
migrateFrom, fd, NULL);
|
2015-11-10 12:43:04 +00:00
|
|
|
|
2015-11-05 14:21:02 +00:00
|
|
|
cleanup:
|
2015-11-10 12:43:04 +00:00
|
|
|
VIR_FREE(migrateFrom);
|
|
|
|
return inc;
|
2015-11-05 14:21:02 +00:00
|
|
|
}
|
|
|
|
|
2016-04-14 10:33:48 +00:00
|
|
|
static int
|
|
|
|
qemuMigrationSetCompression(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
qemuDomainAsyncJob job,
|
|
|
|
qemuMigrationCompressionPtr compression)
|
|
|
|
{
|
2016-04-14 10:33:51 +00:00
|
|
|
int ret = -1;
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
qemuMonitorMigrationCompressionPtr params = &compression->params;
|
|
|
|
|
2016-04-14 10:33:48 +00:00
|
|
|
if (qemuMigrationSetOption(driver, vm,
|
|
|
|
QEMU_MONITOR_MIGRATION_CAPS_XBZRLE,
|
|
|
|
compression->methods &
|
|
|
|
(1ULL << QEMU_MIGRATION_COMPRESS_XBZRLE),
|
|
|
|
job) < 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
if (qemuMigrationSetOption(driver, vm,
|
|
|
|
QEMU_MONITOR_MIGRATION_CAPS_COMPRESS,
|
|
|
|
compression->methods &
|
|
|
|
(1ULL << QEMU_MIGRATION_COMPRESS_MT),
|
|
|
|
job) < 0)
|
|
|
|
return -1;
|
|
|
|
|
2016-04-14 10:33:51 +00:00
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm, job) < 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
if ((params->level_set || params->threads_set || params->dthreads_set) &&
|
|
|
|
qemuMonitorSetMigrationCompression(priv->mon, params) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (compression->xbzrle_cache_set &&
|
|
|
|
qemuMonitorSetMigrationCacheSize(priv->mon,
|
|
|
|
compression->xbzrle_cache) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0)
|
|
|
|
ret = -1;
|
|
|
|
|
|
|
|
return ret;
|
2016-04-14 10:33:48 +00:00
|
|
|
}
|
|
|
|
|
2011-06-13 08:48:34 +00:00
|
|
|
static int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationPrepareAny(virQEMUDriverPtr driver,
|
2011-06-13 08:48:34 +00:00
|
|
|
virConnectPtr dconn,
|
|
|
|
const char *cookiein,
|
|
|
|
int cookieinlen,
|
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
2013-06-07 12:12:28 +00:00
|
|
|
virDomainDefPtr *def,
|
2013-09-03 13:17:03 +00:00
|
|
|
const char *origname,
|
2012-11-21 08:28:49 +00:00
|
|
|
virStreamPtr st,
|
2014-09-15 16:15:42 +00:00
|
|
|
const char *protocol,
|
2013-10-11 03:27:13 +00:00
|
|
|
unsigned short port,
|
|
|
|
bool autoPort,
|
2013-10-08 12:41:44 +00:00
|
|
|
const char *listenAddress,
|
2015-06-15 22:42:10 +00:00
|
|
|
size_t nmigrate_disks,
|
|
|
|
const char **migrate_disks,
|
2016-03-17 14:58:48 +00:00
|
|
|
int nbdPort,
|
2016-04-14 10:33:48 +00:00
|
|
|
qemuMigrationCompressionPtr compression,
|
2012-11-21 08:28:49 +00:00
|
|
|
unsigned long flags)
|
2011-01-31 10:47:03 +00:00
|
|
|
{
|
|
|
|
virDomainObjPtr vm = NULL;
|
2013-11-22 14:38:05 +00:00
|
|
|
virObjectEventPtr event = NULL;
|
2011-01-31 10:47:03 +00:00
|
|
|
int ret = -1;
|
2010-12-23 18:24:42 +00:00
|
|
|
int dataFD[2] = { -1, -1 };
|
2011-01-31 10:47:03 +00:00
|
|
|
qemuDomainObjPrivatePtr priv = NULL;
|
2011-01-24 18:06:16 +00:00
|
|
|
qemuMigrationCookiePtr mig = NULL;
|
2011-06-13 08:48:34 +00:00
|
|
|
bool tunnel = !!st;
|
2012-02-28 12:42:42 +00:00
|
|
|
char *xmlout = NULL;
|
2012-11-21 08:28:49 +00:00
|
|
|
unsigned int cookieFlags;
|
2013-02-01 17:04:15 +00:00
|
|
|
virCapsPtr caps = NULL;
|
2015-11-10 12:43:04 +00:00
|
|
|
qemuProcessIncomingDefPtr incoming = NULL;
|
2014-02-04 15:42:13 +00:00
|
|
|
bool taint_hook = false;
|
2015-11-10 12:43:04 +00:00
|
|
|
bool stopProcess = false;
|
|
|
|
bool relabel = false;
|
|
|
|
int rv;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-11-05 13:28:57 +00:00
|
|
|
virNWFilterReadLockFilterUpdates();
|
|
|
|
|
2012-11-21 08:28:49 +00:00
|
|
|
if (flags & VIR_MIGRATE_OFFLINE) {
|
|
|
|
if (flags & (VIR_MIGRATE_NON_SHARED_DISK |
|
|
|
|
VIR_MIGRATE_NON_SHARED_INC)) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
|
|
|
_("offline migration cannot handle "
|
|
|
|
"non-shared storage"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
if (!(flags & VIR_MIGRATE_PERSIST_DEST)) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
|
|
|
_("offline migration must be specified with "
|
|
|
|
"the persistent flag set"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
if (tunnel) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
|
|
|
_("tunnelled offline migration does not "
|
|
|
|
"make sense"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2015-11-10 11:56:29 +00:00
|
|
|
cookieFlags = 0;
|
|
|
|
} else {
|
|
|
|
cookieFlags = QEMU_MIGRATION_COOKIE_GRAPHICS;
|
2012-11-21 08:28:49 +00:00
|
|
|
}
|
|
|
|
|
2014-12-01 15:59:55 +00:00
|
|
|
if (flags & VIR_MIGRATE_POSTCOPY &&
|
|
|
|
(!(flags & VIR_MIGRATE_LIVE) ||
|
|
|
|
flags & VIR_MIGRATE_PAUSED)) {
|
|
|
|
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
|
|
|
|
_("post-copy migration is not supported with non-live "
|
|
|
|
"or paused migration"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2013-02-01 17:04:15 +00:00
|
|
|
if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
|
|
|
|
goto cleanup;
|
|
|
|
|
2015-10-06 13:39:48 +00:00
|
|
|
if (!qemuMigrationIsAllowedHostdev(*def))
|
2011-01-31 10:47:03 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2012-02-28 12:42:42 +00:00
|
|
|
/* Let migration hook filter domain XML */
|
|
|
|
if (virHookPresent(VIR_HOOK_DRIVER_QEMU)) {
|
|
|
|
char *xml;
|
|
|
|
int hookret;
|
|
|
|
|
2013-06-07 12:12:28 +00:00
|
|
|
if (!(xml = qemuDomainDefFormatXML(driver, *def,
|
2012-10-09 11:15:46 +00:00
|
|
|
VIR_DOMAIN_XML_SECURE |
|
|
|
|
VIR_DOMAIN_XML_MIGRATABLE)))
|
2012-02-28 12:42:42 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2013-06-07 12:12:28 +00:00
|
|
|
hookret = virHookCall(VIR_HOOK_DRIVER_QEMU, (*def)->name,
|
2012-02-28 12:42:42 +00:00
|
|
|
VIR_HOOK_QEMU_OP_MIGRATE, VIR_HOOK_SUBOP_BEGIN,
|
|
|
|
NULL, xml, &xmlout);
|
|
|
|
VIR_FREE(xml);
|
|
|
|
|
|
|
|
if (hookret < 0) {
|
|
|
|
goto cleanup;
|
|
|
|
} else if (hookret == 0) {
|
2014-10-22 09:27:36 +00:00
|
|
|
if (virStringIsEmpty(xmlout)) {
|
2012-02-28 12:42:42 +00:00
|
|
|
VIR_DEBUG("Migrate hook filter returned nothing; using the"
|
|
|
|
" original XML");
|
|
|
|
} else {
|
|
|
|
virDomainDefPtr newdef;
|
|
|
|
|
|
|
|
VIR_DEBUG("Using hook-filtered domain XML: %s", xmlout);
|
2013-03-28 13:55:55 +00:00
|
|
|
newdef = virDomainDefParseString(xmlout, caps, driver->xmlopt,
|
2014-11-18 16:44:00 +00:00
|
|
|
VIR_DOMAIN_DEF_PARSE_INACTIVE);
|
2012-02-28 12:42:42 +00:00
|
|
|
if (!newdef)
|
|
|
|
goto cleanup;
|
|
|
|
|
qemu: Introduce qemuDomainDefCheckABIStability
https://bugzilla.redhat.com/show_bug.cgi?id=994364
Whenever we check for ABI stability, we have new xml (e.g. provided by
user, or obtained from snapshot, whatever) which we compare to old xml
and see if ABI won't break. However, if the new xml was produced via
virDomainGetXMLDesc(..., VIR_DOMAIN_XML_MIGRATABLE) it lacks some
devices, e.g. 'pci-root' controller. Hence, the ABI stability check
fails even though it is stable. Moreover, we can't simply fix
virDomainDefCheckABIStability because removing the correct devices is
task for the driver. For instance, qemu driver wants to remove the usb
controller too, while LXC driver doesn't. That's why we need special
qemu wrapper over virDomainDefCheckABIStability which removes the
correct devices from domain XML, produces MIGRATABLE xml and calls the
check ABI stability function.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2013-10-10 08:53:56 +00:00
|
|
|
if (!qemuDomainDefCheckABIStability(driver, *def, newdef)) {
|
2012-02-28 12:42:42 +00:00
|
|
|
virDomainDefFree(newdef);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2013-06-07 12:12:28 +00:00
|
|
|
virDomainDefFree(*def);
|
|
|
|
*def = newdef;
|
2014-02-04 15:42:13 +00:00
|
|
|
/* We should taint the domain here. However, @vm and therefore
|
|
|
|
* privateData too are still NULL, so just notice the fact and
|
|
|
|
* taint it later. */
|
|
|
|
taint_hook = true;
|
2012-02-28 12:42:42 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-06-07 12:12:28 +00:00
|
|
|
if (!(vm = virDomainObjListAdd(driver->domains, *def,
|
2013-03-31 18:03:42 +00:00
|
|
|
driver->xmlopt,
|
Merge virDomainObjListIsDuplicate into virDomainObjListAdd
The duplicate VM checking should be done atomically with
virDomainObjListAdd, so shoud not be a separate function.
Instead just use flags to indicate what kind of checks are
required.
This pair, used in virDomainCreateXML:
if (virDomainObjListIsDuplicate(privconn->domains, def, 1) < 0)
goto cleanup;
if (!(dom = virDomainObjListAdd(privconn->domains,
privconn->caps,
def, false)))
goto cleanup;
Changes to
if (!(dom = virDomainObjListAdd(privconn->domains,
privconn->caps,
def,
VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE,
NULL)))
goto cleanup;
This pair, used in virDomainRestoreFlags:
if (virDomainObjListIsDuplicate(privconn->domains, def, 1) < 0)
goto cleanup;
if (!(dom = virDomainObjListAdd(privconn->domains,
privconn->caps,
def, true)))
goto cleanup;
Changes to
if (!(dom = virDomainObjListAdd(privconn->domains,
privconn->caps,
def,
VIR_DOMAIN_OBJ_LIST_ADD_LIVE |
VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE,
NULL)))
goto cleanup;
This pair, used in virDomainDefineXML:
if (virDomainObjListIsDuplicate(privconn->domains, def, 0) < 0)
goto cleanup;
if (!(dom = virDomainObjListAdd(privconn->domains,
privconn->caps,
def, false)))
goto cleanup;
Changes to
if (!(dom = virDomainObjListAdd(privconn->domains,
privconn->caps,
def,
0, NULL)))
goto cleanup;
2013-01-14 14:46:58 +00:00
|
|
|
VIR_DOMAIN_OBJ_LIST_ADD_LIVE |
|
|
|
|
VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE,
|
|
|
|
NULL)))
|
2011-01-31 10:47:03 +00:00
|
|
|
goto cleanup;
|
Merge virDomainObjListIsDuplicate into virDomainObjListAdd
The duplicate VM checking should be done atomically with
virDomainObjListAdd, so shoud not be a separate function.
Instead just use flags to indicate what kind of checks are
required.
This pair, used in virDomainCreateXML:
if (virDomainObjListIsDuplicate(privconn->domains, def, 1) < 0)
goto cleanup;
if (!(dom = virDomainObjListAdd(privconn->domains,
privconn->caps,
def, false)))
goto cleanup;
Changes to
if (!(dom = virDomainObjListAdd(privconn->domains,
privconn->caps,
def,
VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE,
NULL)))
goto cleanup;
This pair, used in virDomainRestoreFlags:
if (virDomainObjListIsDuplicate(privconn->domains, def, 1) < 0)
goto cleanup;
if (!(dom = virDomainObjListAdd(privconn->domains,
privconn->caps,
def, true)))
goto cleanup;
Changes to
if (!(dom = virDomainObjListAdd(privconn->domains,
privconn->caps,
def,
VIR_DOMAIN_OBJ_LIST_ADD_LIVE |
VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE,
NULL)))
goto cleanup;
This pair, used in virDomainDefineXML:
if (virDomainObjListIsDuplicate(privconn->domains, def, 0) < 0)
goto cleanup;
if (!(dom = virDomainObjListAdd(privconn->domains,
privconn->caps,
def, false)))
goto cleanup;
Changes to
if (!(dom = virDomainObjListAdd(privconn->domains,
privconn->caps,
def,
0, NULL)))
goto cleanup;
2013-01-14 14:46:58 +00:00
|
|
|
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
virObjectRef(vm);
|
2013-06-07 12:12:28 +00:00
|
|
|
*def = NULL;
|
2011-01-31 10:47:03 +00:00
|
|
|
priv = vm->privateData;
|
2013-09-03 13:17:03 +00:00
|
|
|
if (VIR_STRDUP(priv->origname, origname) < 0)
|
|
|
|
goto cleanup;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-02-04 15:42:13 +00:00
|
|
|
if (taint_hook) {
|
|
|
|
/* Domain XML has been altered by a hook script. */
|
|
|
|
priv->hookRun = true;
|
|
|
|
}
|
|
|
|
|
2011-05-18 16:34:21 +00:00
|
|
|
if (!(mig = qemuMigrationEatCookie(driver, vm, cookiein, cookieinlen,
|
2013-01-29 12:38:50 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_LOCKSTATE |
|
2015-11-05 14:20:21 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_NBD |
|
|
|
|
QEMU_MIGRATION_COOKIE_MEMORY_HOTPLUG)))
|
2011-01-24 18:06:16 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2015-03-02 19:04:12 +00:00
|
|
|
if (STREQ_NULLABLE(protocol, "rdma") &&
|
|
|
|
!virMemoryLimitIsSet(vm->def->mem.hard_limit)) {
|
2014-01-13 06:28:11 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
|
|
|
_("cannot start RDMA migration with no memory hard "
|
|
|
|
"limit set"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2015-06-15 22:42:10 +00:00
|
|
|
if (qemuMigrationPrecreateStorage(dconn, driver, vm, mig->nbd,
|
2015-08-04 08:12:30 +00:00
|
|
|
nmigrate_disks, migrate_disks,
|
|
|
|
!!(flags & VIR_MIGRATE_NON_SHARED_INC)) < 0)
|
2014-11-25 13:19:07 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2011-07-19 00:27:31 +00:00
|
|
|
if (qemuMigrationJobStart(driver, vm, QEMU_ASYNC_JOB_MIGRATION_IN) < 0)
|
2011-01-31 10:47:03 +00:00
|
|
|
goto cleanup;
|
2011-07-19 00:27:31 +00:00
|
|
|
qemuMigrationJobSetPhase(driver, vm, QEMU_MIGRATION_PHASE_PREPARE);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
|
|
|
/* Domain starts inactive, even if the domain XML had an id field. */
|
|
|
|
vm->def->id = -1;
|
|
|
|
|
2012-11-21 08:28:49 +00:00
|
|
|
if (flags & VIR_MIGRATE_OFFLINE)
|
|
|
|
goto done;
|
|
|
|
|
2011-06-13 08:48:34 +00:00
|
|
|
if (tunnel &&
|
|
|
|
(pipe(dataFD) < 0 || virSetCloseExec(dataFD[1]) < 0)) {
|
2010-12-23 18:24:42 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
|
|
|
_("cannot create pipe for tunnelled migration"));
|
2015-11-10 11:41:01 +00:00
|
|
|
goto stopjob;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
2016-01-28 14:56:07 +00:00
|
|
|
if (qemuProcessInit(driver, vm, QEMU_ASYNC_JOB_MIGRATION_IN,
|
2016-03-17 12:51:20 +00:00
|
|
|
true, false, VIR_QEMU_PROCESS_START_AUTODESTROY) < 0)
|
2015-11-10 11:41:01 +00:00
|
|
|
goto stopjob;
|
2015-11-10 12:43:04 +00:00
|
|
|
stopProcess = true;
|
2015-11-05 14:21:02 +00:00
|
|
|
|
2015-11-10 12:43:04 +00:00
|
|
|
if (!(incoming = qemuMigrationPrepareIncoming(vm, tunnel, protocol,
|
|
|
|
listenAddress, port,
|
|
|
|
dataFD[0])))
|
2015-11-10 11:41:01 +00:00
|
|
|
goto stopjob;
|
2015-11-10 12:43:04 +00:00
|
|
|
dataFD[0] = -1; /* the FD is now owned by incoming */
|
|
|
|
|
2016-03-15 12:00:59 +00:00
|
|
|
if (qemuProcessPrepareDomain(dconn, driver, vm,
|
|
|
|
VIR_QEMU_PROCESS_START_AUTODESTROY) < 0)
|
|
|
|
goto stopjob;
|
|
|
|
|
2016-03-22 12:16:05 +00:00
|
|
|
if (qemuProcessPrepareHost(driver, vm, !!incoming) < 0)
|
|
|
|
goto stopjob;
|
|
|
|
|
2015-11-10 12:43:04 +00:00
|
|
|
rv = qemuProcessLaunch(dconn, driver, vm, QEMU_ASYNC_JOB_MIGRATION_IN,
|
|
|
|
incoming, NULL,
|
|
|
|
VIR_NETDEV_VPORT_PROFILE_OP_MIGRATE_IN_START,
|
|
|
|
VIR_QEMU_PROCESS_START_AUTODESTROY);
|
|
|
|
if (rv < 0) {
|
|
|
|
if (rv == -2)
|
|
|
|
relabel = true;
|
2015-11-10 11:41:01 +00:00
|
|
|
goto stopjob;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
2015-11-10 12:43:04 +00:00
|
|
|
relabel = true;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2011-06-13 08:48:34 +00:00
|
|
|
if (tunnel) {
|
|
|
|
if (virFDStreamOpen(st, dataFD[1]) < 0) {
|
|
|
|
virReportSystemError(errno, "%s",
|
|
|
|
_("cannot pass pipe for tunnelled migration"));
|
2015-11-10 11:41:01 +00:00
|
|
|
goto stopjob;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
2011-06-13 08:48:34 +00:00
|
|
|
dataFD[1] = -1; /* 'st' owns the FD now & will close it */
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
2016-04-14 10:33:48 +00:00
|
|
|
if (qemuMigrationSetCompression(driver, vm, QEMU_ASYNC_JOB_MIGRATION_IN,
|
|
|
|
compression) < 0)
|
2015-11-10 11:41:01 +00:00
|
|
|
goto stopjob;
|
2013-01-14 11:45:20 +00:00
|
|
|
|
2014-11-20 12:44:18 +00:00
|
|
|
if (STREQ_NULLABLE(protocol, "rdma") &&
|
2014-01-13 06:28:11 +00:00
|
|
|
virProcessSetMaxMemLock(vm->pid, vm->def->mem.hard_limit << 10) < 0) {
|
2015-11-10 11:41:01 +00:00
|
|
|
goto stopjob;
|
2014-01-13 06:28:11 +00:00
|
|
|
}
|
|
|
|
|
2016-01-28 07:04:27 +00:00
|
|
|
if (qemuMigrationSetOption(driver, vm,
|
|
|
|
QEMU_MONITOR_MIGRATION_CAPS_RDMA_PIN_ALL,
|
2014-11-10 13:46:26 +00:00
|
|
|
flags & VIR_MIGRATE_RDMA_PIN_ALL,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_IN) < 0)
|
2015-11-10 11:41:01 +00:00
|
|
|
goto stopjob;
|
2014-01-13 06:28:12 +00:00
|
|
|
|
2014-12-01 15:59:55 +00:00
|
|
|
if (qemuMigrationSetPostCopy(driver, vm,
|
|
|
|
flags & VIR_MIGRATE_POSTCOPY,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_IN) < 0)
|
|
|
|
goto stopjob;
|
|
|
|
|
2013-01-29 12:38:50 +00:00
|
|
|
if (mig->nbd &&
|
|
|
|
flags & (VIR_MIGRATE_NON_SHARED_DISK | VIR_MIGRATE_NON_SHARED_INC) &&
|
|
|
|
virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_NBD_SERVER)) {
|
2016-01-07 23:07:37 +00:00
|
|
|
if (qemuMigrationStartNBDServer(driver, vm, incoming->address,
|
2016-03-17 14:58:48 +00:00
|
|
|
nmigrate_disks, migrate_disks,
|
|
|
|
nbdPort) < 0) {
|
2015-11-10 11:41:01 +00:00
|
|
|
goto stopjob;
|
2013-01-29 12:38:50 +00:00
|
|
|
}
|
2013-05-28 19:27:45 +00:00
|
|
|
cookieFlags |= QEMU_MIGRATION_COOKIE_NBD;
|
2013-01-29 12:38:50 +00:00
|
|
|
}
|
|
|
|
|
2015-11-10 11:56:29 +00:00
|
|
|
if (mig->lockState) {
|
|
|
|
VIR_DEBUG("Received lockstate %s", mig->lockState);
|
|
|
|
VIR_FREE(priv->lockState);
|
|
|
|
priv->lockState = mig->lockState;
|
|
|
|
mig->lockState = NULL;
|
|
|
|
} else {
|
|
|
|
VIR_DEBUG("Received no lockstate");
|
|
|
|
}
|
|
|
|
|
2015-11-10 12:43:04 +00:00
|
|
|
if (incoming->deferredURI &&
|
|
|
|
qemuMigrationRunIncoming(driver, vm, incoming->deferredURI,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_IN) < 0)
|
|
|
|
goto stopjob;
|
|
|
|
|
|
|
|
if (qemuProcessFinishStartup(dconn, driver, vm, QEMU_ASYNC_JOB_MIGRATION_IN,
|
|
|
|
false, VIR_DOMAIN_PAUSED_MIGRATION) < 0)
|
|
|
|
goto stopjob;
|
|
|
|
|
2015-11-10 11:56:29 +00:00
|
|
|
done:
|
2013-01-29 12:38:50 +00:00
|
|
|
if (qemuMigrationBakeCookie(mig, driver, vm, cookieout,
|
|
|
|
cookieoutlen, cookieFlags) < 0) {
|
2011-01-24 18:06:16 +00:00
|
|
|
/* We could tear down the whole guest here, but
|
|
|
|
* cookie data is (so far) non-critical, so that
|
|
|
|
* seems a little harsh. We'll just warn for now.
|
|
|
|
*/
|
|
|
|
VIR_WARN("Unable to encode migration cookie");
|
|
|
|
}
|
|
|
|
|
2012-03-16 06:56:19 +00:00
|
|
|
if (qemuDomainCleanupAdd(vm, qemuMigrationPrepareCleanup) < 0)
|
2015-11-10 11:41:01 +00:00
|
|
|
goto stopjob;
|
2012-03-16 06:56:19 +00:00
|
|
|
|
2012-11-21 08:28:49 +00:00
|
|
|
if (!(flags & VIR_MIGRATE_OFFLINE)) {
|
|
|
|
virDomainAuditStart(vm, "migrated", true);
|
2013-11-21 17:03:26 +00:00
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
2012-11-21 08:28:49 +00:00
|
|
|
VIR_DOMAIN_EVENT_STARTED,
|
|
|
|
VIR_DOMAIN_EVENT_STARTED_MIGRATED);
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2011-07-19 00:27:31 +00:00
|
|
|
/* We keep the job active across API calls until the finish() call.
|
|
|
|
* This prevents any other APIs being invoked while incoming
|
|
|
|
* migration is taking place.
|
|
|
|
*/
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
qemuMigrationJobContinue(vm);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2013-10-11 03:27:13 +00:00
|
|
|
if (autoPort)
|
|
|
|
priv->migrationPort = port;
|
2016-03-17 14:58:48 +00:00
|
|
|
/* in this case port is not auto selected and we don't need to manage it
|
|
|
|
* anymore after cookie is baked
|
|
|
|
*/
|
|
|
|
if (nbdPort != 0)
|
|
|
|
priv->nbdPort = 0;
|
2011-07-19 00:27:31 +00:00
|
|
|
ret = 0;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2015-11-10 12:43:04 +00:00
|
|
|
qemuProcessIncomingDefFree(incoming);
|
2012-02-28 12:42:42 +00:00
|
|
|
VIR_FREE(xmlout);
|
2010-12-23 18:24:42 +00:00
|
|
|
VIR_FORCE_CLOSE(dataFD[0]);
|
|
|
|
VIR_FORCE_CLOSE(dataFD[1]);
|
2014-12-23 04:32:45 +00:00
|
|
|
if (ret < 0 && priv) {
|
|
|
|
/* priv is set right after vm is added to the list of domains
|
|
|
|
* and there is no 'goto cleanup;' in the middle of those */
|
2015-01-13 02:15:52 +00:00
|
|
|
VIR_FREE(priv->origname);
|
2016-03-17 14:58:48 +00:00
|
|
|
/* release if port is auto selected which is not the case if
|
|
|
|
* it is given in parameters
|
|
|
|
*/
|
|
|
|
if (nbdPort == 0)
|
|
|
|
virPortAllocatorRelease(driver->migrationPorts, priv->nbdPort);
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
priv->nbdPort = 0;
|
2015-09-22 13:25:00 +00:00
|
|
|
qemuDomainRemoveInactive(driver, vm);
|
2011-09-26 11:36:37 +00:00
|
|
|
}
|
2015-04-23 15:27:58 +00:00
|
|
|
virDomainObjEndAPI(&vm);
|
2015-07-07 13:33:53 +00:00
|
|
|
qemuDomainEventQueue(driver, event);
|
2011-01-24 18:06:16 +00:00
|
|
|
qemuMigrationCookieFree(mig);
|
2013-02-01 17:04:15 +00:00
|
|
|
virObjectUnref(caps);
|
2014-11-05 13:28:57 +00:00
|
|
|
virNWFilterUnlockFilterUpdates();
|
2011-01-31 10:47:03 +00:00
|
|
|
return ret;
|
2011-07-19 00:27:31 +00:00
|
|
|
|
2015-11-10 11:41:01 +00:00
|
|
|
stopjob:
|
2015-11-10 12:43:04 +00:00
|
|
|
if (stopProcess) {
|
|
|
|
unsigned int stopFlags = VIR_QEMU_PROCESS_STOP_MIGRATED;
|
|
|
|
if (!relabel)
|
|
|
|
stopFlags |= VIR_QEMU_PROCESS_STOP_NO_RELABEL;
|
2015-11-10 11:41:01 +00:00
|
|
|
virDomainAuditStart(vm, "migrated", false);
|
2016-02-11 10:20:28 +00:00
|
|
|
qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_IN, stopFlags);
|
2015-11-10 11:41:01 +00:00
|
|
|
}
|
2013-01-14 11:45:20 +00:00
|
|
|
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
qemuMigrationJobFinish(driver, vm);
|
2011-07-19 00:27:31 +00:00
|
|
|
goto cleanup;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-06-13 08:48:34 +00:00
|
|
|
/*
|
|
|
|
* This version starts an empty VM listening on a localhost TCP port, and
|
|
|
|
* sets up the corresponding virStream to handle the incoming data.
|
|
|
|
*/
|
|
|
|
int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationPrepareTunnel(virQEMUDriverPtr driver,
|
2011-06-13 08:48:34 +00:00
|
|
|
virConnectPtr dconn,
|
|
|
|
const char *cookiein,
|
|
|
|
int cookieinlen,
|
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
|
|
|
virStreamPtr st,
|
2013-06-07 12:12:28 +00:00
|
|
|
virDomainDefPtr *def,
|
2013-09-03 13:17:03 +00:00
|
|
|
const char *origname,
|
2012-11-21 08:28:49 +00:00
|
|
|
unsigned long flags)
|
2011-06-13 08:48:34 +00:00
|
|
|
{
|
2016-04-14 10:33:48 +00:00
|
|
|
qemuMigrationCompressionPtr compression = NULL;
|
2011-06-13 08:48:34 +00:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
VIR_DEBUG("driver=%p, dconn=%p, cookiein=%s, cookieinlen=%d, "
|
2013-04-29 10:29:02 +00:00
|
|
|
"cookieout=%p, cookieoutlen=%p, st=%p, def=%p, "
|
2013-09-03 13:17:03 +00:00
|
|
|
"origname=%s, flags=%lx",
|
2011-06-13 08:48:34 +00:00
|
|
|
driver, dconn, NULLSTR(cookiein), cookieinlen,
|
2013-09-03 13:17:03 +00:00
|
|
|
cookieout, cookieoutlen, st, *def, origname, flags);
|
2011-06-13 08:48:34 +00:00
|
|
|
|
2013-06-25 12:38:05 +00:00
|
|
|
if (st == NULL) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("tunnelled migration requested but NULL stream passed"));
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2016-04-14 10:33:48 +00:00
|
|
|
if (!(compression = qemuMigrationCompressionParse(NULL, 0, flags)))
|
|
|
|
return -1;
|
|
|
|
|
2011-06-13 08:48:34 +00:00
|
|
|
ret = qemuMigrationPrepareAny(driver, dconn, cookiein, cookieinlen,
|
2013-09-03 13:17:03 +00:00
|
|
|
cookieout, cookieoutlen, def, origname,
|
2016-04-14 10:33:48 +00:00
|
|
|
st, NULL, 0, false, NULL, 0, NULL, 0,
|
|
|
|
compression, flags);
|
|
|
|
VIR_FREE(compression);
|
2011-06-13 08:48:34 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-09-15 16:13:38 +00:00
|
|
|
static virURIPtr
|
|
|
|
qemuMigrationParseURI(const char *uri, bool *wellFormed)
|
|
|
|
{
|
|
|
|
char *tmp = NULL;
|
|
|
|
virURIPtr parsed;
|
|
|
|
|
|
|
|
/* For compatibility reasons tcp://... URIs are sent as tcp:...
|
|
|
|
* We need to transform them to a well-formed URI before parsing. */
|
|
|
|
if (STRPREFIX(uri, "tcp:") && !STRPREFIX(uri + 4, "//")) {
|
|
|
|
if (virAsprintf(&tmp, "tcp://%s", uri + 4) < 0)
|
|
|
|
return NULL;
|
|
|
|
uri = tmp;
|
|
|
|
}
|
|
|
|
|
|
|
|
parsed = virURIParse(uri);
|
|
|
|
if (parsed && wellFormed)
|
|
|
|
*wellFormed = !tmp;
|
|
|
|
VIR_FREE(tmp);
|
|
|
|
|
|
|
|
return parsed;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-01-31 10:47:03 +00:00
|
|
|
int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationPrepareDirect(virQEMUDriverPtr driver,
|
2011-01-31 10:47:03 +00:00
|
|
|
virConnectPtr dconn,
|
2011-01-24 18:06:16 +00:00
|
|
|
const char *cookiein,
|
|
|
|
int cookieinlen,
|
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
2011-01-31 10:47:03 +00:00
|
|
|
const char *uri_in,
|
|
|
|
char **uri_out,
|
2013-06-07 12:12:28 +00:00
|
|
|
virDomainDefPtr *def,
|
2013-09-03 13:17:03 +00:00
|
|
|
const char *origname,
|
2013-10-08 12:41:44 +00:00
|
|
|
const char *listenAddress,
|
2015-06-15 22:42:10 +00:00
|
|
|
size_t nmigrate_disks,
|
|
|
|
const char **migrate_disks,
|
2016-03-17 14:58:48 +00:00
|
|
|
int nbdPort,
|
2016-04-14 10:33:48 +00:00
|
|
|
qemuMigrationCompressionPtr compression,
|
2012-11-21 08:28:49 +00:00
|
|
|
unsigned long flags)
|
2011-01-31 10:47:03 +00:00
|
|
|
{
|
2013-10-11 03:27:13 +00:00
|
|
|
unsigned short port = 0;
|
|
|
|
bool autoPort = true;
|
2011-01-31 10:47:03 +00:00
|
|
|
char *hostname = NULL;
|
|
|
|
int ret = -1;
|
2013-06-18 11:38:55 +00:00
|
|
|
virURIPtr uri = NULL;
|
2014-05-20 06:08:05 +00:00
|
|
|
virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
|
|
|
|
const char *migrateHost = cfg->migrateHost;
|
2011-06-01 10:35:18 +00:00
|
|
|
|
2011-05-20 10:03:04 +00:00
|
|
|
VIR_DEBUG("driver=%p, dconn=%p, cookiein=%s, cookieinlen=%d, "
|
|
|
|
"cookieout=%p, cookieoutlen=%p, uri_in=%s, uri_out=%p, "
|
2015-06-15 22:42:10 +00:00
|
|
|
"def=%p, origname=%s, listenAddress=%s, "
|
2016-03-17 14:58:48 +00:00
|
|
|
"nmigrate_disks=%zu, migrate_disks=%p, nbdPort=%d, flags=%lx",
|
2011-05-20 10:03:04 +00:00
|
|
|
driver, dconn, NULLSTR(cookiein), cookieinlen,
|
|
|
|
cookieout, cookieoutlen, NULLSTR(uri_in), uri_out,
|
2015-06-15 22:42:10 +00:00
|
|
|
*def, origname, NULLSTR(listenAddress),
|
2016-03-17 14:58:48 +00:00
|
|
|
nmigrate_disks, migrate_disks, nbdPort, flags);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2013-06-25 12:38:05 +00:00
|
|
|
*uri_out = NULL;
|
|
|
|
|
2011-01-31 10:47:03 +00:00
|
|
|
/* The URI passed in may be NULL or a string "tcp://somehostname:port".
|
|
|
|
*
|
|
|
|
* If the URI passed in is NULL then we allocate a port number
|
2014-05-20 06:08:05 +00:00
|
|
|
* from our pool of port numbers, and if the migrateHost is configured,
|
|
|
|
* we return a URI of "tcp://migrateHost:port", otherwise return a URI
|
|
|
|
* of "tcp://ourhostname:port".
|
2011-01-31 10:47:03 +00:00
|
|
|
*
|
|
|
|
* If the URI passed in is not NULL then we try to parse out the
|
|
|
|
* port number and use that (note that the hostname is assumed
|
|
|
|
* to be a correct hostname which refers to the target machine).
|
|
|
|
*/
|
|
|
|
if (uri_in == NULL) {
|
2014-10-07 04:07:30 +00:00
|
|
|
bool encloseAddress = false;
|
|
|
|
const char *incFormat;
|
|
|
|
|
2013-10-31 11:49:04 +00:00
|
|
|
if (virPortAllocatorAcquire(driver->migrationPorts, &port) < 0)
|
2013-10-11 03:27:13 +00:00
|
|
|
goto cleanup;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-05-20 06:08:05 +00:00
|
|
|
if (migrateHost != NULL) {
|
2014-10-07 04:07:30 +00:00
|
|
|
if (virSocketAddrNumericFamily(migrateHost) == AF_INET6)
|
|
|
|
encloseAddress = true;
|
2014-05-20 06:08:05 +00:00
|
|
|
|
2014-10-07 04:07:30 +00:00
|
|
|
if (VIR_STRDUP(hostname, migrateHost) < 0)
|
2014-05-20 06:08:05 +00:00
|
|
|
goto cleanup;
|
|
|
|
} else {
|
|
|
|
if ((hostname = virGetHostname()) == NULL)
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
|
|
|
|
if (STRPREFIX(hostname, "localhost")) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("hostname on destination resolved to localhost,"
|
|
|
|
" but migration requires an FQDN"));
|
2011-01-31 10:47:03 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* XXX this really should have been a properly well-formed
|
|
|
|
* URI, but we can't add in tcp:// now without breaking
|
2012-02-03 18:20:22 +00:00
|
|
|
* compatibility with old targets. We at least make the
|
2011-01-31 10:47:03 +00:00
|
|
|
* new targets accept both syntaxes though.
|
|
|
|
*/
|
2014-10-07 04:07:30 +00:00
|
|
|
if (encloseAddress)
|
|
|
|
incFormat = "%s:[%s]:%d";
|
|
|
|
else
|
|
|
|
incFormat = "%s:%s:%d";
|
|
|
|
|
|
|
|
if (virAsprintf(uri_out, incFormat, "tcp", hostname, port) < 0)
|
2011-01-31 10:47:03 +00:00
|
|
|
goto cleanup;
|
|
|
|
} else {
|
2014-09-15 16:13:38 +00:00
|
|
|
bool well_formed_uri;
|
2013-03-22 13:52:25 +00:00
|
|
|
|
2014-09-15 16:13:38 +00:00
|
|
|
if (!(uri = qemuMigrationParseURI(uri_in, &well_formed_uri)))
|
|
|
|
goto cleanup;
|
2013-03-22 13:52:25 +00:00
|
|
|
|
2015-02-11 08:30:32 +00:00
|
|
|
if (uri->scheme == NULL) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG,
|
|
|
|
_("missing scheme in migration URI: %s"),
|
|
|
|
uri_in);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2014-01-13 06:28:11 +00:00
|
|
|
if (STRNEQ(uri->scheme, "tcp") &&
|
|
|
|
STRNEQ(uri->scheme, "rdma")) {
|
2014-09-15 16:13:38 +00:00
|
|
|
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED,
|
|
|
|
_("unsupported scheme %s in migration URI %s"),
|
|
|
|
uri->scheme, uri_in);
|
2013-03-22 13:52:25 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (uri->server == NULL) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG, _("missing host in migration"
|
|
|
|
" URI: %s"), uri_in);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (uri->port == 0) {
|
2013-10-31 11:49:04 +00:00
|
|
|
if (virPortAllocatorAcquire(driver->migrationPorts, &port) < 0)
|
2013-10-11 03:27:13 +00:00
|
|
|
goto cleanup;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-09-15 16:13:38 +00:00
|
|
|
/* Send well-formed URI only if uri_in was well-formed */
|
2013-10-23 04:15:12 +00:00
|
|
|
if (well_formed_uri) {
|
|
|
|
uri->port = port;
|
|
|
|
if (!(*uri_out = virURIFormat(uri)))
|
|
|
|
goto cleanup;
|
|
|
|
} else {
|
|
|
|
if (virAsprintf(uri_out, "%s:%d", uri_in, port) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
} else {
|
2013-10-11 03:27:13 +00:00
|
|
|
port = uri->port;
|
|
|
|
autoPort = false;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (*uri_out)
|
|
|
|
VIR_DEBUG("Generated uri_out=%s", *uri_out);
|
|
|
|
|
2011-06-13 08:48:34 +00:00
|
|
|
ret = qemuMigrationPrepareAny(driver, dconn, cookiein, cookieinlen,
|
2013-09-03 13:17:03 +00:00
|
|
|
cookieout, cookieoutlen, def, origname,
|
2014-09-15 16:15:42 +00:00
|
|
|
NULL, uri ? uri->scheme : "tcp",
|
2015-06-15 22:42:10 +00:00
|
|
|
port, autoPort, listenAddress,
|
2016-04-14 10:33:48 +00:00
|
|
|
nmigrate_disks, migrate_disks, nbdPort,
|
|
|
|
compression, flags);
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2013-06-18 11:38:55 +00:00
|
|
|
virURIFree(uri);
|
2011-01-31 10:47:03 +00:00
|
|
|
VIR_FREE(hostname);
|
2014-05-20 06:08:05 +00:00
|
|
|
virObjectUnref(cfg);
|
2013-10-11 03:27:13 +00:00
|
|
|
if (ret != 0) {
|
2011-01-31 10:47:03 +00:00
|
|
|
VIR_FREE(*uri_out);
|
2013-10-11 03:27:13 +00:00
|
|
|
if (autoPort)
|
|
|
|
virPortAllocatorRelease(driver->migrationPorts, port);
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2013-06-25 12:38:05 +00:00
|
|
|
virDomainDefPtr
|
|
|
|
qemuMigrationPrepareDef(virQEMUDriverPtr driver,
|
|
|
|
const char *dom_xml,
|
2013-09-03 13:17:03 +00:00
|
|
|
const char *dname,
|
|
|
|
char **origname)
|
2013-06-25 12:38:05 +00:00
|
|
|
{
|
|
|
|
virCapsPtr caps = NULL;
|
|
|
|
virDomainDefPtr def;
|
2013-09-03 13:17:03 +00:00
|
|
|
char *name = NULL;
|
2013-06-25 12:38:05 +00:00
|
|
|
|
|
|
|
if (!dom_xml) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("no domain XML passed"));
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
if (!(def = virDomainDefParseString(dom_xml, caps, driver->xmlopt,
|
2014-11-18 16:44:00 +00:00
|
|
|
VIR_DOMAIN_DEF_PARSE_INACTIVE)))
|
2013-06-25 12:38:05 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (dname) {
|
2013-09-03 13:17:03 +00:00
|
|
|
name = def->name;
|
2013-06-25 12:38:05 +00:00
|
|
|
if (VIR_STRDUP(def->name, dname) < 0) {
|
|
|
|
virDomainDefFree(def);
|
|
|
|
def = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2013-06-25 12:38:05 +00:00
|
|
|
virObjectUnref(caps);
|
2013-09-03 13:17:03 +00:00
|
|
|
if (def && origname)
|
|
|
|
*origname = name;
|
|
|
|
else
|
|
|
|
VIR_FREE(name);
|
2013-06-25 12:38:05 +00:00
|
|
|
return def;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2013-06-25 12:55:10 +00:00
|
|
|
static int
|
|
|
|
qemuMigrationConfirmPhase(virQEMUDriverPtr driver,
|
|
|
|
virConnectPtr conn,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *cookiein,
|
|
|
|
int cookieinlen,
|
|
|
|
unsigned int flags,
|
|
|
|
int retcode)
|
|
|
|
{
|
|
|
|
qemuMigrationCookiePtr mig;
|
2016-02-17 23:12:33 +00:00
|
|
|
virObjectEventPtr event;
|
2013-06-25 12:55:10 +00:00
|
|
|
int rv = -1;
|
|
|
|
virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
|
2016-02-18 13:44:48 +00:00
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
qemuDomainJobInfoPtr jobInfo = NULL;
|
2013-06-25 12:55:10 +00:00
|
|
|
|
|
|
|
VIR_DEBUG("driver=%p, conn=%p, vm=%p, cookiein=%s, cookieinlen=%d, "
|
|
|
|
"flags=%x, retcode=%d",
|
|
|
|
driver, conn, vm, NULLSTR(cookiein), cookieinlen,
|
|
|
|
flags, retcode);
|
|
|
|
|
|
|
|
virCheckFlags(QEMU_MIGRATION_FLAGS, -1);
|
|
|
|
|
|
|
|
qemuMigrationJobSetPhase(driver, vm,
|
|
|
|
retcode == 0
|
|
|
|
? QEMU_MIGRATION_PHASE_CONFIRM3
|
|
|
|
: QEMU_MIGRATION_PHASE_CONFIRM3_CANCELLED);
|
|
|
|
|
2014-08-28 14:39:58 +00:00
|
|
|
if (!(mig = qemuMigrationEatCookie(driver, vm, cookiein, cookieinlen,
|
|
|
|
QEMU_MIGRATION_COOKIE_STATS)))
|
2013-06-25 12:55:10 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2016-02-18 13:44:48 +00:00
|
|
|
if (retcode == 0)
|
|
|
|
jobInfo = priv->job.completed;
|
|
|
|
else
|
2015-04-23 07:19:12 +00:00
|
|
|
VIR_FREE(priv->job.completed);
|
2016-02-18 13:44:48 +00:00
|
|
|
|
|
|
|
/* Update times with the values sent by the destination daemon */
|
|
|
|
if (mig->jobInfo && jobInfo) {
|
2015-11-26 14:37:23 +00:00
|
|
|
int reason;
|
|
|
|
|
|
|
|
/* We need to refresh migration statistics after a completed post-copy
|
|
|
|
* migration since priv->job.completed contains obsolete data from the
|
|
|
|
* time we switched to post-copy mode.
|
|
|
|
*/
|
|
|
|
if (virDomainObjGetState(vm, &reason) == VIR_DOMAIN_PAUSED &&
|
|
|
|
reason == VIR_DOMAIN_PAUSED_POSTCOPY &&
|
|
|
|
qemuMigrationFetchJobStatus(driver, vm,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT,
|
|
|
|
jobInfo) < 0)
|
|
|
|
VIR_WARN("Could not refresh migration statistics");
|
|
|
|
|
2016-02-18 13:44:48 +00:00
|
|
|
qemuDomainJobInfoUpdateTime(jobInfo);
|
|
|
|
jobInfo->timeDeltaSet = mig->jobInfo->timeDeltaSet;
|
|
|
|
jobInfo->timeDelta = mig->jobInfo->timeDelta;
|
|
|
|
jobInfo->stats.downtime_set = mig->jobInfo->stats.downtime_set;
|
|
|
|
jobInfo->stats.downtime = mig->jobInfo->stats.downtime;
|
2014-08-28 14:39:58 +00:00
|
|
|
}
|
|
|
|
|
2013-06-25 12:55:10 +00:00
|
|
|
if (flags & VIR_MIGRATE_OFFLINE)
|
|
|
|
goto done;
|
|
|
|
|
2016-01-13 15:29:58 +00:00
|
|
|
/* Did the migration go as planned? If yes, kill off the domain object.
|
|
|
|
* If something failed, resume CPUs, but only if we didn't use post-copy.
|
2013-06-25 12:55:10 +00:00
|
|
|
*/
|
|
|
|
if (retcode == 0) {
|
|
|
|
/* If guest uses SPICE and supports seamless migration we have to hold
|
|
|
|
* up domain shutdown until SPICE server transfers its data */
|
2015-05-25 14:57:49 +00:00
|
|
|
qemuMigrationWaitForSpice(vm);
|
2013-06-25 12:55:10 +00:00
|
|
|
|
|
|
|
qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_MIGRATED,
|
2016-02-11 10:20:28 +00:00
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT,
|
2013-06-25 12:55:10 +00:00
|
|
|
VIR_QEMU_PROCESS_STOP_MIGRATED);
|
|
|
|
virDomainAuditStop(vm, "migrated");
|
|
|
|
|
2013-11-21 17:03:26 +00:00
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
2013-06-25 12:55:10 +00:00
|
|
|
VIR_DOMAIN_EVENT_STOPPED,
|
|
|
|
VIR_DOMAIN_EVENT_STOPPED_MIGRATED);
|
2016-02-17 23:12:33 +00:00
|
|
|
qemuDomainEventQueue(driver, event);
|
|
|
|
qemuDomainEventEmitJobCompleted(driver, vm);
|
2013-06-25 12:55:10 +00:00
|
|
|
} else {
|
2015-04-16 09:24:23 +00:00
|
|
|
virErrorPtr orig_err = virSaveLastError();
|
2016-01-13 15:29:58 +00:00
|
|
|
int reason;
|
2013-06-25 12:55:10 +00:00
|
|
|
|
|
|
|
/* cancel any outstanding NBD jobs */
|
2015-05-20 08:28:37 +00:00
|
|
|
qemuMigrationCancelDriveMirror(driver, vm, false,
|
2015-06-01 12:41:50 +00:00
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT, NULL);
|
2015-04-16 09:24:23 +00:00
|
|
|
|
|
|
|
virSetError(orig_err);
|
|
|
|
virFreeError(orig_err);
|
2013-06-25 12:55:10 +00:00
|
|
|
|
2016-01-13 15:29:58 +00:00
|
|
|
if (virDomainObjGetState(vm, &reason) == VIR_DOMAIN_PAUSED &&
|
|
|
|
reason == VIR_DOMAIN_PAUSED_POSTCOPY) {
|
|
|
|
qemuMigrationPostcopyFailed(driver, vm);
|
|
|
|
} else if (qemuMigrationRestoreDomainState(conn, vm)) {
|
2014-02-06 13:30:59 +00:00
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
|
|
|
VIR_DOMAIN_EVENT_RESUMED,
|
|
|
|
VIR_DOMAIN_EVENT_RESUMED_MIGRATED);
|
2016-02-17 23:12:33 +00:00
|
|
|
qemuDomainEventQueue(driver, event);
|
2013-06-25 12:55:10 +00:00
|
|
|
}
|
|
|
|
|
2016-02-04 12:32:45 +00:00
|
|
|
if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0)
|
2013-06-25 12:55:10 +00:00
|
|
|
VIR_WARN("Failed to save status on vm %s", vm->def->name);
|
|
|
|
}
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
done:
|
2013-06-25 12:55:10 +00:00
|
|
|
qemuMigrationCookieFree(mig);
|
|
|
|
rv = 0;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2013-06-25 12:55:10 +00:00
|
|
|
virObjectUnref(cfg);
|
|
|
|
return rv;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
qemuMigrationConfirm(virConnectPtr conn,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *cookiein,
|
|
|
|
int cookieinlen,
|
|
|
|
unsigned int flags,
|
|
|
|
int cancelled)
|
|
|
|
{
|
|
|
|
virQEMUDriverPtr driver = conn->privateData;
|
2014-06-15 16:32:56 +00:00
|
|
|
qemuMigrationJobPhase phase;
|
2013-06-25 12:55:10 +00:00
|
|
|
virQEMUDriverConfigPtr cfg = NULL;
|
|
|
|
int ret = -1;
|
|
|
|
|
|
|
|
cfg = virQEMUDriverGetConfig(driver);
|
|
|
|
|
|
|
|
if (!qemuMigrationJobIsActive(vm, QEMU_ASYNC_JOB_MIGRATION_OUT))
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (cancelled)
|
|
|
|
phase = QEMU_MIGRATION_PHASE_CONFIRM3_CANCELLED;
|
|
|
|
else
|
|
|
|
phase = QEMU_MIGRATION_PHASE_CONFIRM3;
|
|
|
|
|
|
|
|
qemuMigrationJobStartPhase(driver, vm, phase);
|
2013-07-15 14:53:13 +00:00
|
|
|
virCloseCallbacksUnset(driver->closeCallbacks, vm,
|
|
|
|
qemuMigrationCleanup);
|
2013-06-25 12:55:10 +00:00
|
|
|
|
|
|
|
ret = qemuMigrationConfirmPhase(driver, conn, vm,
|
|
|
|
cookiein, cookieinlen,
|
|
|
|
flags, cancelled);
|
|
|
|
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
qemuMigrationJobFinish(driver, vm);
|
2015-09-22 13:25:00 +00:00
|
|
|
if (!virDomainObjIsActive(vm)) {
|
2015-10-27 08:53:59 +00:00
|
|
|
if (flags & VIR_MIGRATE_UNDEFINE_SOURCE) {
|
2013-06-25 12:55:10 +00:00
|
|
|
virDomainDeleteConfig(cfg->configDir, cfg->autostartDir, vm);
|
2015-10-27 08:53:59 +00:00
|
|
|
vm->persistent = 0;
|
|
|
|
}
|
2013-06-25 12:55:10 +00:00
|
|
|
qemuDomainRemoveInactive(driver, vm);
|
|
|
|
}
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2015-04-23 15:27:58 +00:00
|
|
|
virDomainObjEndAPI(&vm);
|
2013-06-25 12:55:10 +00:00
|
|
|
virObjectUnref(cfg);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
enum qemuMigrationDestinationType {
|
|
|
|
MIGRATION_DEST_HOST,
|
2012-02-02 15:34:08 +00:00
|
|
|
MIGRATION_DEST_CONNECT_HOST,
|
2011-08-11 12:36:04 +00:00
|
|
|
MIGRATION_DEST_UNIX,
|
2011-08-11 13:47:02 +00:00
|
|
|
MIGRATION_DEST_FD,
|
2011-08-11 12:36:04 +00:00
|
|
|
};
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
enum qemuMigrationForwardType {
|
|
|
|
MIGRATION_FWD_DIRECT,
|
|
|
|
MIGRATION_FWD_STREAM,
|
|
|
|
};
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
typedef struct _qemuMigrationSpec qemuMigrationSpec;
|
|
|
|
typedef qemuMigrationSpec *qemuMigrationSpecPtr;
|
|
|
|
struct _qemuMigrationSpec {
|
|
|
|
enum qemuMigrationDestinationType destType;
|
|
|
|
union {
|
|
|
|
struct {
|
2014-09-15 16:15:42 +00:00
|
|
|
const char *protocol;
|
2011-08-11 12:36:04 +00:00
|
|
|
const char *name;
|
|
|
|
int port;
|
|
|
|
} host;
|
|
|
|
|
|
|
|
struct {
|
2011-08-11 13:47:02 +00:00
|
|
|
char *file;
|
2011-08-11 12:36:04 +00:00
|
|
|
int sock;
|
|
|
|
} unix_socket;
|
2011-08-11 13:47:02 +00:00
|
|
|
|
|
|
|
struct {
|
|
|
|
int qemu;
|
|
|
|
int local;
|
|
|
|
} fd;
|
2011-08-11 12:36:04 +00:00
|
|
|
} dest;
|
|
|
|
|
|
|
|
enum qemuMigrationForwardType fwdType;
|
|
|
|
union {
|
|
|
|
virStreamPtr stream;
|
|
|
|
} fwd;
|
|
|
|
};
|
2011-01-31 10:47:03 +00:00
|
|
|
|
|
|
|
#define TUNNEL_SEND_BUF_SIZE 65536
|
|
|
|
|
2011-05-09 15:52:42 +00:00
|
|
|
typedef struct _qemuMigrationIOThread qemuMigrationIOThread;
|
|
|
|
typedef qemuMigrationIOThread *qemuMigrationIOThreadPtr;
|
|
|
|
struct _qemuMigrationIOThread {
|
|
|
|
virThread thread;
|
|
|
|
virStreamPtr st;
|
|
|
|
int sock;
|
|
|
|
virError err;
|
2012-04-23 14:17:55 +00:00
|
|
|
int wakeupRecvFD;
|
|
|
|
int wakeupSendFD;
|
2011-05-09 15:52:42 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static void qemuMigrationIOFunc(void *arg)
|
2011-01-31 10:47:03 +00:00
|
|
|
{
|
2011-05-09 15:52:42 +00:00
|
|
|
qemuMigrationIOThreadPtr data = arg;
|
2012-04-23 14:17:55 +00:00
|
|
|
char *buffer = NULL;
|
|
|
|
struct pollfd fds[2];
|
|
|
|
int timeout = -1;
|
|
|
|
virErrorPtr err = NULL;
|
|
|
|
|
|
|
|
VIR_DEBUG("Running migration tunnel; stream=%p, sock=%d",
|
|
|
|
data->st, data->sock);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2013-07-04 10:14:12 +00:00
|
|
|
if (VIR_ALLOC_N(buffer, TUNNEL_SEND_BUF_SIZE) < 0)
|
2012-04-23 14:17:55 +00:00
|
|
|
goto abrt;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2012-04-23 14:17:55 +00:00
|
|
|
fds[0].fd = data->sock;
|
|
|
|
fds[1].fd = data->wakeupRecvFD;
|
|
|
|
|
2011-01-31 10:47:03 +00:00
|
|
|
for (;;) {
|
2012-04-23 14:17:55 +00:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
fds[0].events = fds[1].events = POLLIN;
|
|
|
|
fds[0].revents = fds[1].revents = 0;
|
|
|
|
|
|
|
|
ret = poll(fds, ARRAY_CARDINALITY(fds), timeout);
|
|
|
|
|
|
|
|
if (ret < 0) {
|
|
|
|
if (errno == EAGAIN || errno == EINTR)
|
|
|
|
continue;
|
2011-01-31 10:47:03 +00:00
|
|
|
virReportSystemError(errno, "%s",
|
2012-04-23 14:17:55 +00:00
|
|
|
_("poll failed in migration tunnel"));
|
|
|
|
goto abrt;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
2012-04-23 14:17:55 +00:00
|
|
|
|
|
|
|
if (ret == 0) {
|
|
|
|
/* We were asked to gracefully stop but reading would block. This
|
|
|
|
* can only happen if qemu told us migration finished but didn't
|
|
|
|
* close the migration fd. We handle this in the same way as EOF.
|
|
|
|
*/
|
|
|
|
VIR_DEBUG("QEMU forgot to close migration fd");
|
2011-01-31 10:47:03 +00:00
|
|
|
break;
|
2012-04-23 14:17:55 +00:00
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2012-04-23 14:17:55 +00:00
|
|
|
if (fds[1].revents & (POLLIN | POLLERR | POLLHUP)) {
|
|
|
|
char stop = 0;
|
|
|
|
|
|
|
|
if (saferead(data->wakeupRecvFD, &stop, 1) != 1) {
|
|
|
|
virReportSystemError(errno, "%s",
|
|
|
|
_("failed to read from wakeup fd"));
|
|
|
|
goto abrt;
|
|
|
|
}
|
|
|
|
|
|
|
|
VIR_DEBUG("Migration tunnel was asked to %s",
|
|
|
|
stop ? "abort" : "finish");
|
|
|
|
if (stop) {
|
|
|
|
goto abrt;
|
|
|
|
} else {
|
|
|
|
timeout = 0;
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
2012-04-23 14:17:55 +00:00
|
|
|
if (fds[0].revents & (POLLIN | POLLERR | POLLHUP)) {
|
|
|
|
int nbytes;
|
|
|
|
|
|
|
|
nbytes = saferead(data->sock, buffer, TUNNEL_SEND_BUF_SIZE);
|
|
|
|
if (nbytes > 0) {
|
|
|
|
if (virStreamSend(data->st, buffer, nbytes) < 0)
|
|
|
|
goto error;
|
|
|
|
} else if (nbytes < 0) {
|
|
|
|
virReportSystemError(errno, "%s",
|
|
|
|
_("tunnelled migration failed to read from qemu"));
|
|
|
|
goto abrt;
|
|
|
|
} else {
|
|
|
|
/* EOF; get out of here */
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2011-05-09 15:52:42 +00:00
|
|
|
if (virStreamFinish(data->st) < 0)
|
|
|
|
goto error;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2015-10-08 12:29:07 +00:00
|
|
|
VIR_FORCE_CLOSE(data->sock);
|
2012-04-23 14:17:55 +00:00
|
|
|
VIR_FREE(buffer);
|
|
|
|
|
2011-05-09 15:52:42 +00:00
|
|
|
return;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
abrt:
|
2012-04-23 14:17:55 +00:00
|
|
|
err = virSaveLastError();
|
|
|
|
if (err && err->code == VIR_ERR_OK) {
|
|
|
|
virFreeError(err);
|
|
|
|
err = NULL;
|
|
|
|
}
|
|
|
|
virStreamAbort(data->st);
|
|
|
|
if (err) {
|
|
|
|
virSetError(err);
|
|
|
|
virFreeError(err);
|
|
|
|
}
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
error:
|
2015-10-08 12:29:07 +00:00
|
|
|
/* Let the source qemu know that the transfer cant continue anymore.
|
|
|
|
* Don't copy the error for EPIPE as destination has the actual error. */
|
|
|
|
VIR_FORCE_CLOSE(data->sock);
|
|
|
|
if (!virLastErrorIsSystemErrno(EPIPE))
|
|
|
|
virCopyLastError(&data->err);
|
2011-05-09 15:52:42 +00:00
|
|
|
virResetLastError();
|
2012-04-23 14:17:55 +00:00
|
|
|
VIR_FREE(buffer);
|
2011-05-09 15:52:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static qemuMigrationIOThreadPtr
|
|
|
|
qemuMigrationStartTunnel(virStreamPtr st,
|
|
|
|
int sock)
|
|
|
|
{
|
2012-04-23 14:17:55 +00:00
|
|
|
qemuMigrationIOThreadPtr io = NULL;
|
|
|
|
int wakeupFD[2] = { -1, -1 };
|
2011-05-09 15:52:42 +00:00
|
|
|
|
2012-04-23 14:17:55 +00:00
|
|
|
if (pipe2(wakeupFD, O_CLOEXEC) < 0) {
|
|
|
|
virReportSystemError(errno, "%s",
|
|
|
|
_("Unable to make pipe"));
|
|
|
|
goto error;
|
2011-05-09 15:52:42 +00:00
|
|
|
}
|
|
|
|
|
2012-04-23 14:17:55 +00:00
|
|
|
if (VIR_ALLOC(io) < 0)
|
2013-07-04 10:14:12 +00:00
|
|
|
goto error;
|
2012-04-23 14:17:55 +00:00
|
|
|
|
2011-05-09 15:52:42 +00:00
|
|
|
io->st = st;
|
|
|
|
io->sock = sock;
|
2012-04-23 14:17:55 +00:00
|
|
|
io->wakeupRecvFD = wakeupFD[0];
|
|
|
|
io->wakeupSendFD = wakeupFD[1];
|
2011-05-09 15:52:42 +00:00
|
|
|
|
|
|
|
if (virThreadCreate(&io->thread, true,
|
|
|
|
qemuMigrationIOFunc,
|
|
|
|
io) < 0) {
|
|
|
|
virReportSystemError(errno, "%s",
|
|
|
|
_("Unable to create migration thread"));
|
2012-04-23 14:17:55 +00:00
|
|
|
goto error;
|
2011-05-09 15:52:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return io;
|
2012-04-23 14:17:55 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
error:
|
2012-04-23 14:17:55 +00:00
|
|
|
VIR_FORCE_CLOSE(wakeupFD[0]);
|
|
|
|
VIR_FORCE_CLOSE(wakeupFD[1]);
|
|
|
|
VIR_FREE(io);
|
|
|
|
return NULL;
|
2011-05-09 15:52:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2012-04-23 14:17:55 +00:00
|
|
|
qemuMigrationStopTunnel(qemuMigrationIOThreadPtr io, bool error)
|
2011-05-09 15:52:42 +00:00
|
|
|
{
|
|
|
|
int rv = -1;
|
2012-04-23 14:17:55 +00:00
|
|
|
char stop = error ? 1 : 0;
|
|
|
|
|
|
|
|
/* make sure the thread finishes its job and is joinable */
|
|
|
|
if (safewrite(io->wakeupSendFD, &stop, 1) != 1) {
|
|
|
|
virReportSystemError(errno, "%s",
|
|
|
|
_("failed to wakeup migration tunnel"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2011-05-09 15:52:42 +00:00
|
|
|
virThreadJoin(&io->thread);
|
|
|
|
|
|
|
|
/* Forward error from the IO thread, to this thread */
|
|
|
|
if (io->err.code != VIR_ERR_OK) {
|
2012-04-23 14:17:55 +00:00
|
|
|
if (error)
|
|
|
|
rv = 0;
|
|
|
|
else
|
|
|
|
virSetError(&io->err);
|
2011-05-09 15:52:42 +00:00
|
|
|
virResetError(&io->err);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
rv = 0;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2012-04-23 14:17:55 +00:00
|
|
|
VIR_FORCE_CLOSE(io->wakeupSendFD);
|
|
|
|
VIR_FORCE_CLOSE(io->wakeupRecvFD);
|
2011-05-09 15:52:42 +00:00
|
|
|
VIR_FREE(io);
|
|
|
|
return rv;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
2012-02-02 15:34:08 +00:00
|
|
|
static int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationConnect(virQEMUDriverPtr driver,
|
2012-02-02 15:34:08 +00:00
|
|
|
virDomainObjPtr vm,
|
|
|
|
qemuMigrationSpecPtr spec)
|
|
|
|
{
|
|
|
|
virNetSocketPtr sock;
|
|
|
|
const char *host;
|
|
|
|
char *port = NULL;
|
|
|
|
int ret = -1;
|
|
|
|
|
|
|
|
host = spec->dest.host.name;
|
2013-07-04 10:14:12 +00:00
|
|
|
if (virAsprintf(&port, "%d", spec->dest.host.port) < 0)
|
2012-02-02 15:34:08 +00:00
|
|
|
return -1;
|
|
|
|
|
|
|
|
spec->destType = MIGRATION_DEST_FD;
|
|
|
|
spec->dest.fd.qemu = -1;
|
|
|
|
|
|
|
|
if (virSecurityManagerSetSocketLabel(driver->securityManager, vm->def) < 0)
|
|
|
|
goto cleanup;
|
2015-05-21 14:51:28 +00:00
|
|
|
if (virNetSocketNewConnectTCP(host, port,
|
|
|
|
AF_UNSPEC,
|
|
|
|
&sock) == 0) {
|
2012-02-02 15:34:08 +00:00
|
|
|
spec->dest.fd.qemu = virNetSocketDupFD(sock, true);
|
2012-07-11 13:35:51 +00:00
|
|
|
virObjectUnref(sock);
|
2012-02-02 15:34:08 +00:00
|
|
|
}
|
|
|
|
if (virSecurityManagerClearSocketLabel(driver->securityManager, vm->def) < 0 ||
|
|
|
|
spec->dest.fd.qemu == -1)
|
|
|
|
goto cleanup;
|
|
|
|
|
2013-03-26 14:45:16 +00:00
|
|
|
/* Migration expects a blocking FD */
|
|
|
|
if (virSetBlocking(spec->dest.fd.qemu, true) < 0) {
|
|
|
|
virReportSystemError(errno, _("Unable to set FD %d blocking"),
|
|
|
|
spec->dest.fd.qemu);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2012-02-02 15:34:08 +00:00
|
|
|
ret = 0;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2012-02-02 15:34:08 +00:00
|
|
|
VIR_FREE(port);
|
|
|
|
if (ret < 0)
|
|
|
|
VIR_FORCE_CLOSE(spec->dest.fd.qemu);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
static int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationRun(virQEMUDriverPtr driver,
|
2011-08-11 12:36:04 +00:00
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *cookiein,
|
|
|
|
int cookieinlen,
|
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
|
|
|
unsigned long flags,
|
|
|
|
unsigned long resource,
|
2011-09-23 06:56:56 +00:00
|
|
|
qemuMigrationSpecPtr spec,
|
2013-06-18 10:17:18 +00:00
|
|
|
virConnectPtr dconn,
|
2015-06-15 22:42:10 +00:00
|
|
|
const char *graphicsuri,
|
|
|
|
size_t nmigrate_disks,
|
2016-04-14 10:33:48 +00:00
|
|
|
const char **migrate_disks,
|
|
|
|
qemuMigrationCompressionPtr compression)
|
2011-01-31 10:47:03 +00:00
|
|
|
{
|
2011-04-20 12:12:43 +00:00
|
|
|
int ret = -1;
|
2011-08-11 12:36:04 +00:00
|
|
|
unsigned int migrate_flags = QEMU_MONITOR_MIGRATE_BACKGROUND;
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
2011-02-03 11:09:28 +00:00
|
|
|
qemuMigrationCookiePtr mig = NULL;
|
2011-05-09 15:52:42 +00:00
|
|
|
qemuMigrationIOThreadPtr iothread = NULL;
|
2011-08-11 12:36:04 +00:00
|
|
|
int fd = -1;
|
2011-08-26 18:10:27 +00:00
|
|
|
unsigned long migrate_speed = resource ? resource : priv->migMaxBandwidth;
|
2012-04-20 12:07:49 +00:00
|
|
|
virErrorPtr orig_err = NULL;
|
2013-01-29 12:38:50 +00:00
|
|
|
unsigned int cookieFlags = 0;
|
2013-06-12 14:11:21 +00:00
|
|
|
bool abort_on_error = !!(flags & VIR_MIGRATE_ABORT_ON_ERROR);
|
2015-05-29 06:38:44 +00:00
|
|
|
bool events = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MIGRATION_EVENT);
|
2015-11-26 14:37:23 +00:00
|
|
|
bool inPostCopy = false;
|
2015-12-17 12:46:18 +00:00
|
|
|
unsigned int waitFlags;
|
2014-05-22 10:29:20 +00:00
|
|
|
int rc;
|
2011-08-11 12:36:04 +00:00
|
|
|
|
|
|
|
VIR_DEBUG("driver=%p, vm=%p, cookiein=%s, cookieinlen=%d, "
|
|
|
|
"cookieout=%p, cookieoutlen=%p, flags=%lx, resource=%lu, "
|
2015-06-15 22:42:10 +00:00
|
|
|
"spec=%p (dest=%d, fwd=%d), dconn=%p, graphicsuri=%s, "
|
|
|
|
"nmigrate_disks=%zu, migrate_disks=%p",
|
2011-08-11 12:36:04 +00:00
|
|
|
driver, vm, NULLSTR(cookiein), cookieinlen,
|
|
|
|
cookieout, cookieoutlen, flags, resource,
|
2013-06-18 10:17:18 +00:00
|
|
|
spec, spec->destType, spec->fwdType, dconn,
|
2015-06-15 22:42:10 +00:00
|
|
|
NULLSTR(graphicsuri), nmigrate_disks, migrate_disks);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2013-01-29 12:38:50 +00:00
|
|
|
if (flags & VIR_MIGRATE_NON_SHARED_DISK) {
|
|
|
|
migrate_flags |= QEMU_MONITOR_MIGRATE_NON_SHARED_DISK;
|
|
|
|
cookieFlags |= QEMU_MIGRATION_COOKIE_NBD;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (flags & VIR_MIGRATE_NON_SHARED_INC) {
|
|
|
|
migrate_flags |= QEMU_MONITOR_MIGRATE_NON_SHARED_INC;
|
|
|
|
cookieFlags |= QEMU_MIGRATION_COOKIE_NBD;
|
|
|
|
}
|
|
|
|
|
2011-05-18 16:34:21 +00:00
|
|
|
if (virLockManagerPluginUsesState(driver->lockManager) &&
|
|
|
|
!cookieout) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("Migration with lock driver %s requires"
|
|
|
|
" cookie support"),
|
|
|
|
virLockManagerPluginGetName(driver->lockManager));
|
2011-05-18 16:34:21 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2015-05-29 06:38:44 +00:00
|
|
|
if (events)
|
|
|
|
priv->signalIOError = abort_on_error;
|
|
|
|
|
2013-01-29 12:38:50 +00:00
|
|
|
mig = qemuMigrationEatCookie(driver, vm, cookiein, cookieinlen,
|
|
|
|
cookieFlags | QEMU_MIGRATION_COOKIE_GRAPHICS);
|
|
|
|
if (!mig)
|
2011-02-03 11:09:28 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2013-06-18 10:17:18 +00:00
|
|
|
if (qemuDomainMigrateGraphicsRelocate(driver, vm, mig, graphicsuri) < 0)
|
2011-02-03 11:09:28 +00:00
|
|
|
VIR_WARN("unable to provide data for graphics client relocation");
|
|
|
|
|
2015-04-16 09:24:23 +00:00
|
|
|
if (migrate_flags & (QEMU_MONITOR_MIGRATE_NON_SHARED_DISK |
|
|
|
|
QEMU_MONITOR_MIGRATE_NON_SHARED_INC)) {
|
|
|
|
if (mig->nbd) {
|
|
|
|
/* This will update migrate_flags on success */
|
|
|
|
if (qemuMigrationDriveMirror(driver, vm, mig,
|
|
|
|
spec->dest.host.name,
|
|
|
|
migrate_speed,
|
2015-06-15 22:42:10 +00:00
|
|
|
&migrate_flags,
|
|
|
|
nmigrate_disks,
|
2015-06-01 12:41:50 +00:00
|
|
|
migrate_disks,
|
|
|
|
dconn) < 0) {
|
2015-04-16 09:24:23 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
/* Destination doesn't support NBD server.
|
|
|
|
* Fall back to previous implementation. */
|
|
|
|
VIR_DEBUG("Destination doesn't support NBD server "
|
|
|
|
"Falling back to previous implementation.");
|
|
|
|
}
|
2012-11-23 14:42:51 +00:00
|
|
|
}
|
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
/* Before EnterMonitor, since qemuMigrationSetOffline already does that */
|
2011-05-20 12:29:42 +00:00
|
|
|
if (!(flags & VIR_MIGRATE_LIVE) &&
|
|
|
|
virDomainObjGetState(vm, NULL) == VIR_DOMAIN_RUNNING) {
|
|
|
|
if (qemuMigrationSetOffline(driver, vm) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2016-04-14 10:33:48 +00:00
|
|
|
if (qemuMigrationSetCompression(driver, vm, QEMU_ASYNC_JOB_MIGRATION_OUT,
|
|
|
|
compression) < 0)
|
2013-01-14 11:45:20 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2016-01-28 07:04:27 +00:00
|
|
|
if (qemuMigrationSetOption(driver, vm,
|
|
|
|
QEMU_MONITOR_MIGRATION_CAPS_AUTO_CONVERGE,
|
|
|
|
flags & VIR_MIGRATE_AUTO_CONVERGE,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT) < 0)
|
2014-02-06 23:44:36 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2016-01-28 07:04:27 +00:00
|
|
|
if (qemuMigrationSetOption(driver, vm,
|
|
|
|
QEMU_MONITOR_MIGRATION_CAPS_RDMA_PIN_ALL,
|
2014-11-10 13:46:26 +00:00
|
|
|
flags & VIR_MIGRATE_RDMA_PIN_ALL,
|
2014-01-13 06:28:12 +00:00
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
2014-12-01 15:59:55 +00:00
|
|
|
if (qemuMigrationSetPostCopy(driver, vm,
|
|
|
|
flags & VIR_MIGRATE_POSTCOPY,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
qemu: fix crash when mixing sync and async monitor jobs
Currently, we attempt to run sync job and async job at the same time. It
means that the monitor commands for two jobs can be run in any order.
In the function qemuDomainObjEnterMonitorInternal():
if (priv->job.active == QEMU_JOB_NONE && priv->job.asyncJob) {
if (qemuDomainObjBeginNestedJob(driver, obj) < 0)
We check whether the caller is an async job by priv->job.active and
priv->job.asynJob. But when an async job is running, and a sync job is
also running at the time of the check, then priv->job.active is not
QEMU_JOB_NONE. So we cannot check whether the caller is an async job
in the function qemuDomainObjEnterMonitorInternal(), and must instead
put the burden on the caller to tell us when an async command wants
to do a nested job.
Once the burden is on the caller, then only async monitor enters need
to worry about whether the VM is still running; for sync monitor enter,
the internal return is always 0, so lots of ignore_value can be dropped.
* src/qemu/THREADS.txt: Reflect new rules.
* src/qemu/qemu_domain.h (qemuDomainObjEnterMonitorAsync): New
prototype.
* src/qemu/qemu_process.h (qemuProcessStartCPUs)
(qemuProcessStopCPUs): Add parameter.
* src/qemu/qemu_migration.h (qemuMigrationToFile): Likewise.
(qemuMigrationWaitForCompletion): Make static.
* src/qemu/qemu_domain.c (qemuDomainObjEnterMonitorInternal): Add
parameter.
(qemuDomainObjEnterMonitorAsync): New function.
(qemuDomainObjEnterMonitor, qemuDomainObjEnterMonitorWithDriver):
Update callers.
* src/qemu/qemu_driver.c (qemuDomainSaveInternal)
(qemudDomainCoreDump, doCoreDump, processWatchdogEvent)
(qemudDomainSuspend, qemudDomainResume, qemuDomainSaveImageStartVM)
(qemuDomainSnapshotCreateActive, qemuDomainRevertToSnapshot):
Likewise.
* src/qemu/qemu_process.c (qemuProcessStopCPUs)
(qemuProcessFakeReboot, qemuProcessRecoverMigration)
(qemuProcessRecoverJob, qemuProcessStart): Likewise.
* src/qemu/qemu_migration.c (qemuMigrationToFile)
(qemuMigrationWaitForCompletion, qemuMigrationUpdateJobStatus)
(qemuMigrationJobStart, qemuDomainMigrateGraphicsRelocate)
(doNativeMigrate, doTunnelMigrate, qemuMigrationPerformJob)
(qemuMigrationPerformPhase, qemuMigrationFinish)
(qemuMigrationConfirm): Likewise.
* src/qemu/qemu_hotplug.c: Drop unneeded ignore_value.
2011-07-28 23:18:24 +00:00
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT) < 0)
|
2011-06-30 09:23:50 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2015-05-15 13:59:49 +00:00
|
|
|
if (priv->job.abortJob) {
|
2012-11-08 13:49:55 +00:00
|
|
|
/* explicitly do this *after* we entered the monitor,
|
|
|
|
* as this is a critical section so we are guaranteed
|
2015-05-15 13:59:49 +00:00
|
|
|
* priv->job.abortJob will not change */
|
2014-12-16 09:40:58 +00:00
|
|
|
ignore_value(qemuDomainObjExitMonitor(driver, vm));
|
2014-12-01 07:05:32 +00:00
|
|
|
priv->job.current->type = VIR_DOMAIN_JOB_CANCELLED;
|
2012-11-08 13:49:55 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_ABORTED, _("%s: %s"),
|
|
|
|
qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
|
|
|
|
_("canceled by client"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2014-12-16 09:40:58 +00:00
|
|
|
if (qemuMonitorSetMigrationSpeed(priv->mon, migrate_speed) < 0)
|
|
|
|
goto exit_monitor;
|
2011-04-20 12:12:43 +00:00
|
|
|
|
2012-02-02 15:34:08 +00:00
|
|
|
/* connect to the destination qemu if needed */
|
|
|
|
if (spec->destType == MIGRATION_DEST_CONNECT_HOST &&
|
2012-02-15 15:48:54 +00:00
|
|
|
qemuMigrationConnect(driver, vm, spec) < 0) {
|
2014-12-16 09:40:58 +00:00
|
|
|
goto exit_monitor;
|
2012-02-15 15:48:54 +00:00
|
|
|
}
|
2012-02-02 15:34:08 +00:00
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
switch (spec->destType) {
|
|
|
|
case MIGRATION_DEST_HOST:
|
2014-01-13 06:28:11 +00:00
|
|
|
if (STREQ(spec->dest.host.protocol, "rdma") &&
|
|
|
|
virProcessSetMaxMemLock(vm->pid, vm->def->mem.hard_limit << 10) < 0) {
|
2014-12-16 09:40:58 +00:00
|
|
|
goto exit_monitor;
|
2014-01-13 06:28:11 +00:00
|
|
|
}
|
2011-08-11 12:36:04 +00:00
|
|
|
ret = qemuMonitorMigrateToHost(priv->mon, migrate_flags,
|
2014-09-15 16:15:42 +00:00
|
|
|
spec->dest.host.protocol,
|
2011-08-11 12:36:04 +00:00
|
|
|
spec->dest.host.name,
|
|
|
|
spec->dest.host.port);
|
|
|
|
break;
|
|
|
|
|
2012-02-02 15:34:08 +00:00
|
|
|
case MIGRATION_DEST_CONNECT_HOST:
|
|
|
|
/* handled above and transformed into MIGRATION_DEST_FD */
|
|
|
|
break;
|
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
case MIGRATION_DEST_UNIX:
|
2015-11-06 16:50:26 +00:00
|
|
|
ret = qemuMonitorMigrateToUnix(priv->mon, migrate_flags,
|
|
|
|
spec->dest.unix_socket.file);
|
2011-08-11 12:36:04 +00:00
|
|
|
break;
|
2011-08-11 13:47:02 +00:00
|
|
|
|
|
|
|
case MIGRATION_DEST_FD:
|
2012-05-30 09:20:44 +00:00
|
|
|
if (spec->fwdType != MIGRATION_FWD_DIRECT) {
|
2011-08-11 13:47:02 +00:00
|
|
|
fd = spec->dest.fd.local;
|
2012-05-30 09:20:44 +00:00
|
|
|
spec->dest.fd.local = -1;
|
|
|
|
}
|
2011-08-11 13:47:02 +00:00
|
|
|
ret = qemuMonitorMigrateToFd(priv->mon, migrate_flags,
|
|
|
|
spec->dest.fd.qemu);
|
|
|
|
VIR_FORCE_CLOSE(spec->dest.fd.qemu);
|
|
|
|
break;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
2014-12-16 09:40:58 +00:00
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0)
|
|
|
|
ret = -1;
|
2011-08-11 12:36:04 +00:00
|
|
|
if (ret < 0)
|
2011-04-20 12:12:43 +00:00
|
|
|
goto cleanup;
|
|
|
|
ret = -1;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
|
|
|
/* From this point onwards we *must* call cancel to abort the
|
|
|
|
* migration on source if anything goes wrong */
|
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
if (spec->destType == MIGRATION_DEST_UNIX) {
|
|
|
|
/* It is also possible that the migrate didn't fail initially, but
|
|
|
|
* rather failed later on. Check its status before waiting for a
|
|
|
|
* connection from qemu which may never be initiated.
|
|
|
|
*/
|
2015-05-28 09:17:17 +00:00
|
|
|
if (qemuMigrationCheckJobStatus(driver, vm,
|
2015-10-05 12:32:58 +00:00
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT,
|
|
|
|
false) < 0)
|
2011-08-11 12:36:04 +00:00
|
|
|
goto cancel;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
while ((fd = accept(spec->dest.unix_socket.sock, NULL, NULL)) < 0) {
|
|
|
|
if (errno == EAGAIN || errno == EINTR)
|
|
|
|
continue;
|
|
|
|
virReportSystemError(errno, "%s",
|
|
|
|
_("failed to accept connection from qemu"));
|
|
|
|
goto cancel;
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
2015-10-08 12:29:07 +00:00
|
|
|
if (spec->fwdType != MIGRATION_FWD_DIRECT) {
|
|
|
|
if (!(iothread = qemuMigrationStartTunnel(spec->fwd.stream, fd)))
|
|
|
|
goto cancel;
|
|
|
|
/* If we've created a tunnel, then the 'fd' will be closed in the
|
|
|
|
* qemuMigrationIOFunc as data->sock.
|
|
|
|
*/
|
|
|
|
fd = -1;
|
|
|
|
}
|
2011-05-09 15:52:42 +00:00
|
|
|
|
2015-12-17 12:46:18 +00:00
|
|
|
waitFlags = 0;
|
|
|
|
if (abort_on_error)
|
|
|
|
waitFlags |= QEMU_MIGRATION_COMPLETED_ABORT_ON_ERROR;
|
|
|
|
if (mig->nbd)
|
|
|
|
waitFlags |= QEMU_MIGRATION_COMPLETED_CHECK_STORAGE;
|
|
|
|
if (flags & VIR_MIGRATE_POSTCOPY)
|
|
|
|
waitFlags |= QEMU_MIGRATION_COMPLETED_POSTCOPY;
|
|
|
|
|
2014-05-22 10:29:20 +00:00
|
|
|
rc = qemuMigrationWaitForCompletion(driver, vm,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT,
|
2015-12-17 12:46:18 +00:00
|
|
|
dconn, waitFlags);
|
2014-05-22 10:29:20 +00:00
|
|
|
if (rc == -2)
|
|
|
|
goto cancel;
|
|
|
|
else if (rc == -1)
|
2011-08-11 12:36:04 +00:00
|
|
|
goto cleanup;
|
2011-05-09 15:52:42 +00:00
|
|
|
|
2015-11-26 14:37:23 +00:00
|
|
|
if (priv->job.current->stats.status == QEMU_MONITOR_MIGRATION_STATUS_POSTCOPY)
|
|
|
|
inPostCopy = true;
|
|
|
|
|
2016-01-05 21:19:28 +00:00
|
|
|
/* When migration completed, QEMU will have paused the CPUs for us.
|
|
|
|
* Wait for the STOP event to be processed or explicitly stop CPUs
|
|
|
|
* (for old QEMU which does not send events) to release the lock state.
|
2011-06-02 15:40:33 +00:00
|
|
|
*/
|
2016-01-05 21:19:28 +00:00
|
|
|
if (priv->monJSON) {
|
|
|
|
while (virDomainObjGetState(vm, NULL) == VIR_DOMAIN_RUNNING) {
|
|
|
|
priv->signalStop = true;
|
|
|
|
rc = virDomainObjWait(vm);
|
|
|
|
priv->signalStop = false;
|
2015-11-26 14:37:23 +00:00
|
|
|
if (rc < 0)
|
|
|
|
goto cancelPostCopy;
|
2014-12-01 07:05:33 +00:00
|
|
|
}
|
2016-01-05 21:19:28 +00:00
|
|
|
} else if (virDomainObjGetState(vm, NULL) == VIR_DOMAIN_RUNNING &&
|
|
|
|
qemuMigrationSetOffline(driver, vm) < 0) {
|
2015-11-26 14:37:23 +00:00
|
|
|
goto cancelPostCopy;
|
2011-06-02 15:40:33 +00:00
|
|
|
}
|
2016-02-23 09:47:01 +00:00
|
|
|
if (priv->job.completed)
|
|
|
|
priv->job.completed->stopped = priv->job.current->stopped;
|
2011-06-02 15:40:33 +00:00
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
ret = 0;
|
2011-05-09 15:52:42 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2012-04-20 12:07:49 +00:00
|
|
|
if (ret < 0 && !orig_err)
|
|
|
|
orig_err = virSaveLastError();
|
|
|
|
|
2013-01-30 16:53:37 +00:00
|
|
|
/* cancel any outstanding NBD jobs */
|
2015-04-16 09:24:23 +00:00
|
|
|
if (mig && mig->nbd) {
|
2015-05-20 08:28:37 +00:00
|
|
|
if (qemuMigrationCancelDriveMirror(driver, vm, ret == 0,
|
2015-06-01 12:41:50 +00:00
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT,
|
|
|
|
dconn) < 0)
|
2015-04-16 09:24:23 +00:00
|
|
|
ret = -1;
|
|
|
|
}
|
2013-01-30 16:53:37 +00:00
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
if (spec->fwdType != MIGRATION_FWD_DIRECT) {
|
2012-04-23 14:17:55 +00:00
|
|
|
if (iothread && qemuMigrationStopTunnel(iothread, ret < 0) < 0)
|
2011-08-11 12:36:04 +00:00
|
|
|
ret = -1;
|
|
|
|
}
|
2015-07-14 13:42:50 +00:00
|
|
|
VIR_FORCE_CLOSE(fd);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-08-28 14:37:38 +00:00
|
|
|
if (priv->job.completed) {
|
2014-08-28 11:52:58 +00:00
|
|
|
qemuDomainJobInfoUpdateTime(priv->job.completed);
|
2014-08-28 14:37:38 +00:00
|
|
|
qemuDomainJobInfoUpdateDowntime(priv->job.completed);
|
2015-04-23 07:19:12 +00:00
|
|
|
ignore_value(virTimeMillisNow(&priv->job.completed->sent));
|
2014-08-28 14:37:38 +00:00
|
|
|
}
|
2014-08-28 11:52:58 +00:00
|
|
|
|
2015-11-26 14:37:23 +00:00
|
|
|
if (priv->job.current->type == VIR_DOMAIN_JOB_UNBOUNDED && !inPostCopy)
|
2014-12-01 07:05:33 +00:00
|
|
|
priv->job.current->type = VIR_DOMAIN_JOB_FAILED;
|
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
cookieFlags |= QEMU_MIGRATION_COOKIE_NETWORK |
|
|
|
|
QEMU_MIGRATION_COOKIE_STATS;
|
2013-05-03 09:55:49 +00:00
|
|
|
if (flags & VIR_MIGRATE_PERSIST_DEST)
|
|
|
|
cookieFlags |= QEMU_MIGRATION_COOKIE_PERSISTENT;
|
2011-02-03 11:09:28 +00:00
|
|
|
if (ret == 0 &&
|
2013-01-29 12:38:50 +00:00
|
|
|
qemuMigrationBakeCookie(mig, driver, vm, cookieout,
|
|
|
|
cookieoutlen, cookieFlags) < 0) {
|
2011-02-03 11:09:28 +00:00
|
|
|
VIR_WARN("Unable to encode migration cookie");
|
2012-10-01 15:18:20 +00:00
|
|
|
}
|
2011-02-03 11:09:28 +00:00
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
qemuMigrationCookieFree(mig);
|
|
|
|
|
2015-05-29 06:38:44 +00:00
|
|
|
if (events)
|
|
|
|
priv->signalIOError = false;
|
|
|
|
|
2012-04-20 12:07:49 +00:00
|
|
|
if (orig_err) {
|
|
|
|
virSetError(orig_err);
|
|
|
|
virFreeError(orig_err);
|
|
|
|
}
|
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
return ret;
|
|
|
|
|
2014-12-16 09:40:58 +00:00
|
|
|
exit_monitor:
|
|
|
|
ignore_value(qemuDomainObjExitMonitor(driver, vm));
|
|
|
|
goto cleanup;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cancel:
|
2012-04-20 12:07:49 +00:00
|
|
|
orig_err = virSaveLastError();
|
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
if (virDomainObjIsActive(vm)) {
|
qemu: fix crash when mixing sync and async monitor jobs
Currently, we attempt to run sync job and async job at the same time. It
means that the monitor commands for two jobs can be run in any order.
In the function qemuDomainObjEnterMonitorInternal():
if (priv->job.active == QEMU_JOB_NONE && priv->job.asyncJob) {
if (qemuDomainObjBeginNestedJob(driver, obj) < 0)
We check whether the caller is an async job by priv->job.active and
priv->job.asynJob. But when an async job is running, and a sync job is
also running at the time of the check, then priv->job.active is not
QEMU_JOB_NONE. So we cannot check whether the caller is an async job
in the function qemuDomainObjEnterMonitorInternal(), and must instead
put the burden on the caller to tell us when an async command wants
to do a nested job.
Once the burden is on the caller, then only async monitor enters need
to worry about whether the VM is still running; for sync monitor enter,
the internal return is always 0, so lots of ignore_value can be dropped.
* src/qemu/THREADS.txt: Reflect new rules.
* src/qemu/qemu_domain.h (qemuDomainObjEnterMonitorAsync): New
prototype.
* src/qemu/qemu_process.h (qemuProcessStartCPUs)
(qemuProcessStopCPUs): Add parameter.
* src/qemu/qemu_migration.h (qemuMigrationToFile): Likewise.
(qemuMigrationWaitForCompletion): Make static.
* src/qemu/qemu_domain.c (qemuDomainObjEnterMonitorInternal): Add
parameter.
(qemuDomainObjEnterMonitorAsync): New function.
(qemuDomainObjEnterMonitor, qemuDomainObjEnterMonitorWithDriver):
Update callers.
* src/qemu/qemu_driver.c (qemuDomainSaveInternal)
(qemudDomainCoreDump, doCoreDump, processWatchdogEvent)
(qemudDomainSuspend, qemudDomainResume, qemuDomainSaveImageStartVM)
(qemuDomainSnapshotCreateActive, qemuDomainRevertToSnapshot):
Likewise.
* src/qemu/qemu_process.c (qemuProcessStopCPUs)
(qemuProcessFakeReboot, qemuProcessRecoverMigration)
(qemuProcessRecoverJob, qemuProcessStart): Likewise.
* src/qemu/qemu_migration.c (qemuMigrationToFile)
(qemuMigrationWaitForCompletion, qemuMigrationUpdateJobStatus)
(qemuMigrationJobStart, qemuDomainMigrateGraphicsRelocate)
(doNativeMigrate, doTunnelMigrate, qemuMigrationPerformJob)
(qemuMigrationPerformPhase, qemuMigrationFinish)
(qemuMigrationConfirm): Likewise.
* src/qemu/qemu_hotplug.c: Drop unneeded ignore_value.
2011-07-28 23:18:24 +00:00
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT) == 0) {
|
2011-06-30 09:23:50 +00:00
|
|
|
qemuMonitorMigrateCancel(priv->mon);
|
2014-12-16 09:40:58 +00:00
|
|
|
ignore_value(qemuDomainObjExitMonitor(driver, vm));
|
2011-06-30 09:23:50 +00:00
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
2011-08-11 12:36:04 +00:00
|
|
|
goto cleanup;
|
2015-11-26 14:37:23 +00:00
|
|
|
|
|
|
|
cancelPostCopy:
|
|
|
|
priv->job.current->type = VIR_DOMAIN_JOB_FAILED;
|
|
|
|
if (inPostCopy)
|
|
|
|
goto cancel;
|
|
|
|
else
|
|
|
|
goto cleanup;
|
2011-08-11 12:36:04 +00:00
|
|
|
}
|
|
|
|
|
2014-09-15 16:15:42 +00:00
|
|
|
/* Perform migration using QEMU's native migrate support,
|
2011-08-11 12:36:04 +00:00
|
|
|
* not encrypted obviously
|
|
|
|
*/
|
2012-11-28 16:43:10 +00:00
|
|
|
static int doNativeMigrate(virQEMUDriverPtr driver,
|
2011-08-11 12:36:04 +00:00
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *uri,
|
|
|
|
const char *cookiein,
|
|
|
|
int cookieinlen,
|
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
|
|
|
unsigned long flags,
|
2011-09-23 06:56:56 +00:00
|
|
|
unsigned long resource,
|
2013-06-18 10:17:18 +00:00
|
|
|
virConnectPtr dconn,
|
2015-06-15 22:42:10 +00:00
|
|
|
const char *graphicsuri,
|
|
|
|
size_t nmigrate_disks,
|
2016-04-14 10:33:48 +00:00
|
|
|
const char **migrate_disks,
|
|
|
|
qemuMigrationCompressionPtr compression)
|
2011-08-11 12:36:04 +00:00
|
|
|
{
|
2011-08-11 13:47:02 +00:00
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
2012-02-24 18:48:55 +00:00
|
|
|
virURIPtr uribits = NULL;
|
2011-08-11 13:47:02 +00:00
|
|
|
int ret = -1;
|
2011-08-11 12:36:04 +00:00
|
|
|
qemuMigrationSpec spec;
|
|
|
|
|
|
|
|
VIR_DEBUG("driver=%p, vm=%p, uri=%s, cookiein=%s, cookieinlen=%d, "
|
2013-06-18 10:17:18 +00:00
|
|
|
"cookieout=%p, cookieoutlen=%p, flags=%lx, resource=%lu, "
|
2015-06-15 22:42:10 +00:00
|
|
|
"graphicsuri=%s, nmigrate_disks=%zu migrate_disks=%p",
|
2011-08-11 12:36:04 +00:00
|
|
|
driver, vm, uri, NULLSTR(cookiein), cookieinlen,
|
2013-06-18 10:17:18 +00:00
|
|
|
cookieout, cookieoutlen, flags, resource,
|
2015-06-15 22:42:10 +00:00
|
|
|
NULLSTR(graphicsuri), nmigrate_disks, migrate_disks);
|
2011-08-11 12:36:04 +00:00
|
|
|
|
2014-09-15 16:13:38 +00:00
|
|
|
if (!(uribits = qemuMigrationParseURI(uri, NULL)))
|
2011-08-11 12:36:04 +00:00
|
|
|
return -1;
|
|
|
|
|
2015-02-11 08:30:32 +00:00
|
|
|
if (uribits->scheme == NULL) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
_("missing scheme in migration URI: %s"),
|
|
|
|
uri);
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2014-01-13 06:28:11 +00:00
|
|
|
if (STREQ(uribits->scheme, "rdma")) {
|
|
|
|
if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MIGRATE_RDMA)) {
|
|
|
|
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
|
|
|
|
_("outgoing RDMA migration is not supported "
|
|
|
|
"with this QEMU binary"));
|
2014-09-23 13:22:24 +00:00
|
|
|
goto cleanup;
|
2014-01-13 06:28:11 +00:00
|
|
|
}
|
2015-03-02 19:04:12 +00:00
|
|
|
if (!virMemoryLimitIsSet(vm->def->mem.hard_limit)) {
|
2014-01-13 06:28:11 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
|
|
|
_("cannot start RDMA migration with no memory hard "
|
|
|
|
"limit set"));
|
2014-09-23 13:22:24 +00:00
|
|
|
goto cleanup;
|
2014-01-13 06:28:11 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-11-06 16:50:26 +00:00
|
|
|
if (STRNEQ(uribits->scheme, "rdma"))
|
2012-02-02 15:34:08 +00:00
|
|
|
spec.destType = MIGRATION_DEST_CONNECT_HOST;
|
|
|
|
else
|
2011-08-11 13:47:02 +00:00
|
|
|
spec.destType = MIGRATION_DEST_HOST;
|
2014-09-15 16:15:42 +00:00
|
|
|
spec.dest.host.protocol = uribits->scheme;
|
2012-02-02 15:34:08 +00:00
|
|
|
spec.dest.host.name = uribits->server;
|
|
|
|
spec.dest.host.port = uribits->port;
|
|
|
|
spec.fwdType = MIGRATION_FWD_DIRECT;
|
2011-08-11 13:47:02 +00:00
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
ret = qemuMigrationRun(driver, vm, cookiein, cookieinlen, cookieout,
|
2013-06-18 10:17:18 +00:00
|
|
|
cookieoutlen, flags, resource, &spec, dconn,
|
2016-04-14 10:33:48 +00:00
|
|
|
graphicsuri, nmigrate_disks, migrate_disks,
|
|
|
|
compression);
|
2011-08-11 13:47:02 +00:00
|
|
|
|
|
|
|
if (spec.destType == MIGRATION_DEST_FD)
|
|
|
|
VIR_FORCE_CLOSE(spec.dest.fd.qemu);
|
|
|
|
|
2014-09-23 13:22:24 +00:00
|
|
|
cleanup:
|
2012-03-20 11:59:42 +00:00
|
|
|
virURIFree(uribits);
|
2011-08-11 12:36:04 +00:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2012-11-28 16:43:10 +00:00
|
|
|
static int doTunnelMigrate(virQEMUDriverPtr driver,
|
2011-08-11 12:36:04 +00:00
|
|
|
virDomainObjPtr vm,
|
|
|
|
virStreamPtr st,
|
|
|
|
const char *cookiein,
|
|
|
|
int cookieinlen,
|
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
|
|
|
unsigned long flags,
|
2011-09-23 06:56:56 +00:00
|
|
|
unsigned long resource,
|
2013-06-18 10:17:18 +00:00
|
|
|
virConnectPtr dconn,
|
2015-06-15 22:42:10 +00:00
|
|
|
const char *graphicsuri,
|
|
|
|
size_t nmigrate_disks,
|
2016-04-14 10:33:48 +00:00
|
|
|
const char **migrate_disks,
|
|
|
|
qemuMigrationCompressionPtr compression)
|
2011-08-11 12:36:04 +00:00
|
|
|
{
|
2011-08-12 08:54:05 +00:00
|
|
|
virNetSocketPtr sock = NULL;
|
2011-08-11 12:36:04 +00:00
|
|
|
int ret = -1;
|
|
|
|
qemuMigrationSpec spec;
|
2013-01-10 21:03:14 +00:00
|
|
|
virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
|
2015-11-06 16:50:26 +00:00
|
|
|
int fds[2] = { -1, -1 };
|
2011-08-11 12:36:04 +00:00
|
|
|
|
|
|
|
VIR_DEBUG("driver=%p, vm=%p, st=%p, cookiein=%s, cookieinlen=%d, "
|
2013-06-18 10:17:18 +00:00
|
|
|
"cookieout=%p, cookieoutlen=%p, flags=%lx, resource=%lu, "
|
2015-06-15 22:42:10 +00:00
|
|
|
"graphicsuri=%s, nmigrate_disks=%zu, migrate_disks=%p",
|
2011-08-11 12:36:04 +00:00
|
|
|
driver, vm, st, NULLSTR(cookiein), cookieinlen,
|
2013-06-18 10:17:18 +00:00
|
|
|
cookieout, cookieoutlen, flags, resource,
|
2015-06-15 22:42:10 +00:00
|
|
|
NULLSTR(graphicsuri), nmigrate_disks, migrate_disks);
|
2011-08-11 12:36:04 +00:00
|
|
|
|
|
|
|
spec.fwdType = MIGRATION_FWD_STREAM;
|
|
|
|
spec.fwd.stream = st;
|
|
|
|
|
2011-08-11 13:47:02 +00:00
|
|
|
|
2015-11-06 16:50:26 +00:00
|
|
|
spec.destType = MIGRATION_DEST_FD;
|
|
|
|
spec.dest.fd.qemu = -1;
|
|
|
|
spec.dest.fd.local = -1;
|
2011-08-11 13:47:02 +00:00
|
|
|
|
2015-11-06 16:50:26 +00:00
|
|
|
if (pipe2(fds, O_CLOEXEC) == 0) {
|
|
|
|
spec.dest.fd.qemu = fds[1];
|
|
|
|
spec.dest.fd.local = fds[0];
|
|
|
|
}
|
|
|
|
if (spec.dest.fd.qemu == -1 ||
|
|
|
|
virSecurityManagerSetImageFDLabel(driver->securityManager, vm->def,
|
|
|
|
spec.dest.fd.qemu) < 0) {
|
|
|
|
virReportSystemError(errno, "%s",
|
|
|
|
_("cannot create pipe for tunnelled migration"));
|
|
|
|
goto cleanup;
|
2011-08-11 13:47:02 +00:00
|
|
|
}
|
|
|
|
|
2011-08-11 12:36:04 +00:00
|
|
|
ret = qemuMigrationRun(driver, vm, cookiein, cookieinlen, cookieout,
|
2013-06-18 10:17:18 +00:00
|
|
|
cookieoutlen, flags, resource, &spec, dconn,
|
2016-04-14 10:33:48 +00:00
|
|
|
graphicsuri, nmigrate_disks, migrate_disks,
|
|
|
|
compression);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2011-08-11 13:47:02 +00:00
|
|
|
if (spec.destType == MIGRATION_DEST_FD) {
|
|
|
|
VIR_FORCE_CLOSE(spec.dest.fd.qemu);
|
|
|
|
VIR_FORCE_CLOSE(spec.dest.fd.local);
|
|
|
|
} else {
|
2012-07-11 13:35:51 +00:00
|
|
|
virObjectUnref(sock);
|
2011-08-11 13:47:02 +00:00
|
|
|
VIR_FREE(spec.dest.unix_socket.file);
|
|
|
|
}
|
2011-04-20 12:12:43 +00:00
|
|
|
|
2013-01-10 21:03:14 +00:00
|
|
|
virObjectUnref(cfg);
|
2011-04-20 12:12:43 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-04-20 12:48:58 +00:00
|
|
|
/* This is essentially a re-impl of virDomainMigrateVersion2
|
|
|
|
* from libvirt.c, but running in source libvirtd context,
|
|
|
|
* instead of client app context & also adding in tunnel
|
|
|
|
* handling */
|
2012-11-28 16:43:10 +00:00
|
|
|
static int doPeer2PeerMigrate2(virQEMUDriverPtr driver,
|
2011-09-26 16:51:47 +00:00
|
|
|
virConnectPtr sconn ATTRIBUTE_UNUSED,
|
2011-04-20 12:12:43 +00:00
|
|
|
virConnectPtr dconn,
|
|
|
|
virDomainObjPtr vm,
|
Add a second URI parameter to virDomainMigratePerform3 method
The virDomainMigratePerform3 currently has a single URI parameter
whose meaning varies. It is either
- A QEMU migration URI (normal migration)
- A libvirtd connection URI (peer2peer migration)
Unfortunately when using peer2peer migration, without also
using tunnelled migration, it is possible that both URIs are
required.
This adds a second URI parameter to the virDomainMigratePerform3
method, to cope with this scenario. Each parameter how has a fixed
meaning.
NB, there is no way to actually take advantage of this yet,
since virDomainMigrate/virDomainMigrateToURI do not have any
way to provide the 2 separate URIs
* daemon/remote.c, src/remote/remote_driver.c,
src/remote/remote_protocol.x, src/remote_protocol-structs: Add
the second URI parameter to perform3 message
* src/driver.h, src/libvirt.c, src/libvirt_internal.h: Add
the second URI parameter to Perform3 method
* src/libvirt_internal.h, src/qemu/qemu_migration.c,
src/qemu/qemu_migration.h: Update to handle URIs correctly
2011-05-18 13:18:53 +00:00
|
|
|
const char *dconnuri,
|
2011-04-20 12:12:43 +00:00
|
|
|
unsigned long flags,
|
|
|
|
const char *dname,
|
|
|
|
unsigned long resource)
|
2011-01-31 10:47:03 +00:00
|
|
|
{
|
|
|
|
virDomainPtr ddomain = NULL;
|
|
|
|
char *uri_out = NULL;
|
2011-01-24 18:06:16 +00:00
|
|
|
char *cookie = NULL;
|
2011-04-20 12:48:58 +00:00
|
|
|
char *dom_xml = NULL;
|
|
|
|
int cookielen = 0, ret;
|
|
|
|
virErrorPtr orig_err = NULL;
|
2013-05-24 10:14:02 +00:00
|
|
|
bool cancelled;
|
2011-04-20 12:48:58 +00:00
|
|
|
virStreamPtr st = NULL;
|
2013-07-04 17:58:51 +00:00
|
|
|
unsigned long destflags;
|
2016-04-14 10:33:48 +00:00
|
|
|
qemuMigrationCompressionPtr compression = NULL;
|
2013-06-12 14:11:22 +00:00
|
|
|
|
2011-05-20 10:03:04 +00:00
|
|
|
VIR_DEBUG("driver=%p, sconn=%p, dconn=%p, vm=%p, dconnuri=%s, "
|
2011-07-08 15:18:48 +00:00
|
|
|
"flags=%lx, dname=%s, resource=%lu",
|
2011-05-20 10:03:04 +00:00
|
|
|
driver, sconn, dconn, vm, NULLSTR(dconnuri),
|
|
|
|
flags, NULLSTR(dname), resource);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2011-04-20 12:48:58 +00:00
|
|
|
/* In version 2 of the protocol, the prepare step is slightly
|
|
|
|
* different. We fetch the domain XML of the source domain
|
|
|
|
* and pass it to Prepare2.
|
|
|
|
*/
|
|
|
|
if (!(dom_xml = qemuDomainFormatXML(driver, vm,
|
2012-10-08 09:58:05 +00:00
|
|
|
QEMU_DOMAIN_FORMAT_LIVE_FLAGS |
|
|
|
|
VIR_DOMAIN_XML_MIGRATABLE)))
|
2011-04-20 12:48:58 +00:00
|
|
|
return -1;
|
|
|
|
|
|
|
|
if (virDomainObjGetState(vm, NULL) == VIR_DOMAIN_PAUSED)
|
|
|
|
flags |= VIR_MIGRATE_PAUSED;
|
|
|
|
|
2014-02-06 23:44:36 +00:00
|
|
|
destflags = flags & ~(VIR_MIGRATE_ABORT_ON_ERROR |
|
|
|
|
VIR_MIGRATE_AUTO_CONVERGE);
|
2013-07-04 17:58:51 +00:00
|
|
|
|
2016-04-14 10:33:48 +00:00
|
|
|
if (!(compression = qemuMigrationCompressionParse(NULL, 0, flags)))
|
|
|
|
goto cleanup;
|
|
|
|
|
2011-04-20 12:48:58 +00:00
|
|
|
VIR_DEBUG("Prepare2 %p", dconn);
|
|
|
|
if (flags & VIR_MIGRATE_TUNNELLED) {
|
|
|
|
/*
|
|
|
|
* Tunnelled Migrate Version 2 does not support cookies
|
|
|
|
* due to missing parameters in the prepareTunnel() API.
|
|
|
|
*/
|
|
|
|
|
|
|
|
if (!(st = virStreamNew(dconn, 0)))
|
|
|
|
goto cleanup;
|
|
|
|
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjEnterRemote(vm);
|
2011-04-20 12:48:58 +00:00
|
|
|
ret = dconn->driver->domainMigratePrepareTunnel
|
2013-06-12 14:11:22 +00:00
|
|
|
(dconn, st, destflags, dname, resource, dom_xml);
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjExitRemote(vm);
|
2011-04-20 12:48:58 +00:00
|
|
|
} else {
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjEnterRemote(vm);
|
2011-04-20 12:48:58 +00:00
|
|
|
ret = dconn->driver->domainMigratePrepare2
|
|
|
|
(dconn, &cookie, &cookielen, NULL, &uri_out,
|
2013-06-12 14:11:22 +00:00
|
|
|
destflags, dname, resource, dom_xml);
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjExitRemote(vm);
|
2011-04-20 12:48:58 +00:00
|
|
|
}
|
|
|
|
VIR_FREE(dom_xml);
|
|
|
|
if (ret == -1)
|
2011-01-31 10:47:03 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
/* the domain may have shutdown or crashed while we had the locks dropped
|
2013-02-06 18:17:20 +00:00
|
|
|
* in qemuDomainObjEnterRemote, so check again
|
2011-01-31 10:47:03 +00:00
|
|
|
*/
|
|
|
|
if (!virDomainObjIsActive(vm)) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("guest unexpectedly quit"));
|
2011-01-31 10:47:03 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2011-04-20 12:48:58 +00:00
|
|
|
if (!(flags & VIR_MIGRATE_TUNNELLED) &&
|
|
|
|
(uri_out == NULL)) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("domainMigratePrepare2 did not set uri"));
|
2013-05-24 10:14:02 +00:00
|
|
|
cancelled = true;
|
2013-12-28 13:40:10 +00:00
|
|
|
orig_err = virSaveLastError();
|
2011-04-20 12:48:58 +00:00
|
|
|
goto finish;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
2011-04-20 12:48:58 +00:00
|
|
|
/* Perform the migration. The driver isn't supposed to return
|
|
|
|
* until the migration is complete.
|
|
|
|
*/
|
|
|
|
VIR_DEBUG("Perform %p", sconn);
|
2011-07-19 00:27:32 +00:00
|
|
|
qemuMigrationJobSetPhase(driver, vm, QEMU_MIGRATION_PHASE_PERFORM2);
|
2011-04-20 12:48:58 +00:00
|
|
|
if (flags & VIR_MIGRATE_TUNNELLED)
|
2011-02-03 11:09:28 +00:00
|
|
|
ret = doTunnelMigrate(driver, vm, st,
|
|
|
|
NULL, 0, NULL, NULL,
|
2015-06-15 22:42:10 +00:00
|
|
|
flags, resource, dconn,
|
2016-04-14 10:33:48 +00:00
|
|
|
NULL, 0, NULL, compression);
|
2011-04-20 12:48:58 +00:00
|
|
|
else
|
|
|
|
ret = doNativeMigrate(driver, vm, uri_out,
|
|
|
|
cookie, cookielen,
|
|
|
|
NULL, NULL, /* No out cookie with v2 migration */
|
2016-04-14 10:33:48 +00:00
|
|
|
flags, resource, dconn, NULL, 0, NULL, compression);
|
2011-04-20 12:48:58 +00:00
|
|
|
|
|
|
|
/* Perform failed. Make sure Finish doesn't overwrite the error */
|
|
|
|
if (ret < 0)
|
|
|
|
orig_err = virSaveLastError();
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2011-04-20 12:48:58 +00:00
|
|
|
/* If Perform returns < 0, then we need to cancel the VM
|
|
|
|
* startup on the destination
|
|
|
|
*/
|
2013-05-24 10:14:02 +00:00
|
|
|
cancelled = ret < 0;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
finish:
|
2011-04-20 12:48:58 +00:00
|
|
|
/* In version 2 of the migration protocol, we pass the
|
|
|
|
* status code from the sender to the destination host,
|
|
|
|
* so it can do any cleanup if the migration failed.
|
|
|
|
*/
|
2011-01-31 10:47:03 +00:00
|
|
|
dname = dname ? dname : vm->def->name;
|
2011-04-20 12:48:58 +00:00
|
|
|
VIR_DEBUG("Finish2 %p ret=%d", dconn, ret);
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjEnterRemote(vm);
|
2011-01-31 10:47:03 +00:00
|
|
|
ddomain = dconn->driver->domainMigrateFinish2
|
2011-04-20 12:48:58 +00:00
|
|
|
(dconn, dname, cookie, cookielen,
|
2013-06-12 14:11:22 +00:00
|
|
|
uri_out ? uri_out : dconnuri, destflags, cancelled);
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjExitRemote(vm);
|
2013-12-28 13:40:10 +00:00
|
|
|
if (cancelled && ddomain)
|
|
|
|
VIR_ERROR(_("finish step ignored that migration was cancelled"));
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2011-04-20 12:48:58 +00:00
|
|
|
if (ddomain) {
|
Convert public datatypes to inherit from virObject
This converts the following public API datatypes to use the
virObject infrastructure:
virConnectPtr
virDomainPtr
virDomainSnapshotPtr
virInterfacePtr
virNetworkPtr
virNodeDevicePtr
virNWFilterPtr
virSecretPtr
virStreamPtr
virStorageVolPtr
virStoragePoolPtr
The code is significantly simplified, since the mutex in the
virConnectPtr object now only needs to be held when accessing
the per-connection virError object instance. All other operations
are completely lock free.
* src/datatypes.c, src/datatypes.h, src/libvirt.c: Convert
public datatypes to use virObject
* src/conf/domain_event.c, src/phyp/phyp_driver.c,
src/qemu/qemu_command.c, src/qemu/qemu_migration.c,
src/qemu/qemu_process.c, src/storage/storage_driver.c,
src/vbox/vbox_tmpl.c, src/xen/xend_internal.c,
tests/qemuxml2argvtest.c, tests/qemuxmlnstest.c,
tests/sexpr2xmltest.c, tests/xmconfigtest.c: Convert
to use virObjectUnref/virObjectRef
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-07-31 16:55:36 +00:00
|
|
|
virObjectUnref(ddomain);
|
2011-04-20 12:48:58 +00:00
|
|
|
ret = 0;
|
|
|
|
} else {
|
|
|
|
ret = -1;
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
|
Convert public datatypes to inherit from virObject
This converts the following public API datatypes to use the
virObject infrastructure:
virConnectPtr
virDomainPtr
virDomainSnapshotPtr
virInterfacePtr
virNetworkPtr
virNodeDevicePtr
virNWFilterPtr
virSecretPtr
virStreamPtr
virStorageVolPtr
virStoragePoolPtr
The code is significantly simplified, since the mutex in the
virConnectPtr object now only needs to be held when accessing
the per-connection virError object instance. All other operations
are completely lock free.
* src/datatypes.c, src/datatypes.h, src/libvirt.c: Convert
public datatypes to use virObject
* src/conf/domain_event.c, src/phyp/phyp_driver.c,
src/qemu/qemu_command.c, src/qemu/qemu_migration.c,
src/qemu/qemu_process.c, src/storage/storage_driver.c,
src/vbox/vbox_tmpl.c, src/xen/xend_internal.c,
tests/qemuxml2argvtest.c, tests/qemuxmlnstest.c,
tests/sexpr2xmltest.c, tests/xmconfigtest.c: Convert
to use virObjectUnref/virObjectRef
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-07-31 16:55:36 +00:00
|
|
|
virObjectUnref(st);
|
2011-04-20 12:48:58 +00:00
|
|
|
|
|
|
|
if (orig_err) {
|
|
|
|
virSetError(orig_err);
|
|
|
|
virFreeError(orig_err);
|
|
|
|
}
|
|
|
|
VIR_FREE(uri_out);
|
2011-01-24 18:06:16 +00:00
|
|
|
VIR_FREE(cookie);
|
2016-04-14 10:33:48 +00:00
|
|
|
VIR_FREE(compression);
|
2011-04-20 12:48:58 +00:00
|
|
|
|
|
|
|
return ret;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-02-03 11:09:28 +00:00
|
|
|
/* This is essentially a re-impl of virDomainMigrateVersion3
|
|
|
|
* from libvirt.c, but running in source libvirtd context,
|
|
|
|
* instead of client app context & also adding in tunnel
|
|
|
|
* handling */
|
2013-06-25 13:49:21 +00:00
|
|
|
static int
|
|
|
|
doPeer2PeerMigrate3(virQEMUDriverPtr driver,
|
|
|
|
virConnectPtr sconn,
|
|
|
|
virConnectPtr dconn,
|
|
|
|
const char *dconnuri,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *xmlin,
|
|
|
|
const char *dname,
|
|
|
|
const char *uri,
|
2013-06-18 10:17:18 +00:00
|
|
|
const char *graphicsuri,
|
2013-10-08 12:41:44 +00:00
|
|
|
const char *listenAddress,
|
2015-06-15 22:42:10 +00:00
|
|
|
size_t nmigrate_disks,
|
|
|
|
const char **migrate_disks,
|
2016-03-17 14:58:48 +00:00
|
|
|
int nbdPort,
|
2016-04-14 10:33:48 +00:00
|
|
|
qemuMigrationCompressionPtr compression,
|
2013-06-25 13:49:21 +00:00
|
|
|
unsigned long long bandwidth,
|
|
|
|
bool useParams,
|
|
|
|
unsigned long flags)
|
2011-02-03 11:09:28 +00:00
|
|
|
{
|
|
|
|
virDomainPtr ddomain = NULL;
|
|
|
|
char *uri_out = NULL;
|
|
|
|
char *cookiein = NULL;
|
|
|
|
char *cookieout = NULL;
|
|
|
|
char *dom_xml = NULL;
|
|
|
|
int cookieinlen = 0;
|
|
|
|
int cookieoutlen = 0;
|
|
|
|
int ret = -1;
|
|
|
|
virErrorPtr orig_err = NULL;
|
2013-06-25 13:49:21 +00:00
|
|
|
bool cancelled = true;
|
2011-02-03 11:09:28 +00:00
|
|
|
virStreamPtr st = NULL;
|
2013-07-04 17:58:51 +00:00
|
|
|
unsigned long destflags;
|
2013-06-25 13:49:21 +00:00
|
|
|
virTypedParameterPtr params = NULL;
|
|
|
|
int nparams = 0;
|
|
|
|
int maxparams = 0;
|
2015-06-15 22:42:10 +00:00
|
|
|
size_t i;
|
2013-06-25 13:49:21 +00:00
|
|
|
|
|
|
|
VIR_DEBUG("driver=%p, sconn=%p, dconn=%p, dconnuri=%s, vm=%p, xmlin=%s, "
|
2013-10-08 12:41:44 +00:00
|
|
|
"dname=%s, uri=%s, graphicsuri=%s, listenAddress=%s, "
|
2016-03-17 14:58:48 +00:00
|
|
|
"nmigrate_disks=%zu, migrate_disks=%p, nbdPort=%d, "
|
|
|
|
"bandwidth=%llu, useParams=%d, flags=%lx",
|
2013-06-25 13:49:21 +00:00
|
|
|
driver, sconn, dconn, NULLSTR(dconnuri), vm, NULLSTR(xmlin),
|
2013-10-08 12:41:44 +00:00
|
|
|
NULLSTR(dname), NULLSTR(uri), NULLSTR(graphicsuri),
|
2016-03-17 14:58:48 +00:00
|
|
|
NULLSTR(listenAddress), nmigrate_disks, migrate_disks, nbdPort,
|
2015-06-15 22:42:10 +00:00
|
|
|
bandwidth, useParams, flags);
|
2011-02-03 11:09:28 +00:00
|
|
|
|
2011-07-19 00:27:32 +00:00
|
|
|
/* Unlike the virDomainMigrateVersion3 counterpart, we don't need
|
|
|
|
* to worry about auto-setting the VIR_MIGRATE_CHANGE_PROTECTION
|
|
|
|
* bit here, because we are already running inside the context of
|
|
|
|
* a single job. */
|
|
|
|
|
2013-06-25 07:44:14 +00:00
|
|
|
dom_xml = qemuMigrationBeginPhase(driver, vm, xmlin, dname,
|
2015-06-15 22:42:10 +00:00
|
|
|
&cookieout, &cookieoutlen,
|
|
|
|
nmigrate_disks, migrate_disks, flags);
|
2011-02-03 11:09:28 +00:00
|
|
|
if (!dom_xml)
|
|
|
|
goto cleanup;
|
|
|
|
|
2013-06-25 13:49:21 +00:00
|
|
|
if (useParams) {
|
|
|
|
if (virTypedParamsAddString(¶ms, &nparams, &maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_DEST_XML, dom_xml) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (dname &&
|
|
|
|
virTypedParamsAddString(¶ms, &nparams, &maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_DEST_NAME, dname) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (uri &&
|
|
|
|
virTypedParamsAddString(¶ms, &nparams, &maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_URI, uri) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
if (bandwidth &&
|
|
|
|
virTypedParamsAddULLong(¶ms, &nparams, &maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_BANDWIDTH,
|
|
|
|
bandwidth) < 0)
|
|
|
|
goto cleanup;
|
2013-06-18 10:17:18 +00:00
|
|
|
|
|
|
|
if (graphicsuri &&
|
|
|
|
virTypedParamsAddString(¶ms, &nparams, &maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_GRAPHICS_URI,
|
|
|
|
graphicsuri) < 0)
|
|
|
|
goto cleanup;
|
2013-10-08 12:41:44 +00:00
|
|
|
if (listenAddress &&
|
|
|
|
virTypedParamsAddString(¶ms, &nparams, &maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_LISTEN_ADDRESS,
|
|
|
|
listenAddress) < 0)
|
|
|
|
goto cleanup;
|
2015-06-15 22:42:10 +00:00
|
|
|
for (i = 0; i < nmigrate_disks; i++)
|
|
|
|
if (virTypedParamsAddString(¶ms, &nparams, &maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_MIGRATE_DISKS,
|
|
|
|
migrate_disks[i]) < 0)
|
|
|
|
goto cleanup;
|
2016-03-17 14:58:48 +00:00
|
|
|
if (nbdPort &&
|
|
|
|
virTypedParamsAddInt(¶ms, &nparams, &maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_DISKS_PORT,
|
|
|
|
nbdPort) < 0)
|
|
|
|
goto cleanup;
|
2016-04-14 10:33:48 +00:00
|
|
|
|
|
|
|
if (qemuMigrationCompressionDump(compression, ¶ms, &nparams,
|
|
|
|
&maxparams, &flags) < 0)
|
|
|
|
goto cleanup;
|
2013-06-25 13:49:21 +00:00
|
|
|
}
|
|
|
|
|
2011-02-03 11:09:28 +00:00
|
|
|
if (virDomainObjGetState(vm, NULL) == VIR_DOMAIN_PAUSED)
|
|
|
|
flags |= VIR_MIGRATE_PAUSED;
|
|
|
|
|
2014-02-06 23:44:36 +00:00
|
|
|
destflags = flags & ~(VIR_MIGRATE_ABORT_ON_ERROR |
|
|
|
|
VIR_MIGRATE_AUTO_CONVERGE);
|
2013-07-04 17:58:51 +00:00
|
|
|
|
2011-02-03 11:09:28 +00:00
|
|
|
VIR_DEBUG("Prepare3 %p", dconn);
|
|
|
|
cookiein = cookieout;
|
|
|
|
cookieinlen = cookieoutlen;
|
|
|
|
cookieout = NULL;
|
|
|
|
cookieoutlen = 0;
|
|
|
|
if (flags & VIR_MIGRATE_TUNNELLED) {
|
|
|
|
if (!(st = virStreamNew(dconn, 0)))
|
|
|
|
goto cleanup;
|
|
|
|
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjEnterRemote(vm);
|
2013-06-25 13:49:21 +00:00
|
|
|
if (useParams) {
|
|
|
|
ret = dconn->driver->domainMigratePrepareTunnel3Params
|
|
|
|
(dconn, st, params, nparams, cookiein, cookieinlen,
|
|
|
|
&cookieout, &cookieoutlen, destflags);
|
|
|
|
} else {
|
|
|
|
ret = dconn->driver->domainMigratePrepareTunnel3
|
|
|
|
(dconn, st, cookiein, cookieinlen, &cookieout, &cookieoutlen,
|
|
|
|
destflags, dname, bandwidth, dom_xml);
|
|
|
|
}
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjExitRemote(vm);
|
2011-02-03 11:09:28 +00:00
|
|
|
} else {
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjEnterRemote(vm);
|
2013-06-25 13:49:21 +00:00
|
|
|
if (useParams) {
|
|
|
|
ret = dconn->driver->domainMigratePrepare3Params
|
|
|
|
(dconn, params, nparams, cookiein, cookieinlen,
|
|
|
|
&cookieout, &cookieoutlen, &uri_out, destflags);
|
|
|
|
} else {
|
|
|
|
ret = dconn->driver->domainMigratePrepare3
|
|
|
|
(dconn, cookiein, cookieinlen, &cookieout, &cookieoutlen,
|
|
|
|
uri, &uri_out, destflags, dname, bandwidth, dom_xml);
|
|
|
|
}
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjExitRemote(vm);
|
2011-02-03 11:09:28 +00:00
|
|
|
}
|
|
|
|
VIR_FREE(dom_xml);
|
|
|
|
if (ret == -1)
|
|
|
|
goto cleanup;
|
|
|
|
|
2012-11-21 08:28:49 +00:00
|
|
|
if (flags & VIR_MIGRATE_OFFLINE) {
|
|
|
|
VIR_DEBUG("Offline migration, skipping Perform phase");
|
|
|
|
VIR_FREE(cookieout);
|
|
|
|
cookieoutlen = 0;
|
2013-05-24 10:14:02 +00:00
|
|
|
cancelled = false;
|
2012-11-21 08:28:49 +00:00
|
|
|
goto finish;
|
|
|
|
}
|
|
|
|
|
2013-06-25 13:49:21 +00:00
|
|
|
if (uri_out) {
|
|
|
|
uri = uri_out;
|
|
|
|
if (useParams &&
|
|
|
|
virTypedParamsReplaceString(¶ms, &nparams,
|
2013-12-28 13:40:10 +00:00
|
|
|
VIR_MIGRATE_PARAM_URI, uri_out) < 0) {
|
|
|
|
orig_err = virSaveLastError();
|
2013-06-25 13:49:21 +00:00
|
|
|
goto finish;
|
2013-12-28 13:40:10 +00:00
|
|
|
}
|
2013-06-25 13:49:21 +00:00
|
|
|
} else if (!uri && !(flags & VIR_MIGRATE_TUNNELLED)) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("domainMigratePrepare3 did not set uri"));
|
2013-12-28 13:40:10 +00:00
|
|
|
orig_err = virSaveLastError();
|
2011-02-03 11:09:28 +00:00
|
|
|
goto finish;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Perform the migration. The driver isn't supposed to return
|
|
|
|
* until the migration is complete. The src VM should remain
|
|
|
|
* running, but in paused state until the destination can
|
|
|
|
* confirm migration completion.
|
|
|
|
*/
|
2013-06-25 13:49:21 +00:00
|
|
|
VIR_DEBUG("Perform3 %p uri=%s", sconn, NULLSTR(uri));
|
2011-07-19 00:27:32 +00:00
|
|
|
qemuMigrationJobSetPhase(driver, vm, QEMU_MIGRATION_PHASE_PERFORM3);
|
2011-02-03 11:09:28 +00:00
|
|
|
VIR_FREE(cookiein);
|
|
|
|
cookiein = cookieout;
|
|
|
|
cookieinlen = cookieoutlen;
|
|
|
|
cookieout = NULL;
|
|
|
|
cookieoutlen = 0;
|
2013-06-25 13:49:21 +00:00
|
|
|
if (flags & VIR_MIGRATE_TUNNELLED) {
|
2011-02-03 11:09:28 +00:00
|
|
|
ret = doTunnelMigrate(driver, vm, st,
|
|
|
|
cookiein, cookieinlen,
|
|
|
|
&cookieout, &cookieoutlen,
|
2015-06-15 22:42:10 +00:00
|
|
|
flags, bandwidth, dconn, graphicsuri,
|
2016-04-14 10:33:48 +00:00
|
|
|
nmigrate_disks, migrate_disks, compression);
|
2013-06-25 13:49:21 +00:00
|
|
|
} else {
|
|
|
|
ret = doNativeMigrate(driver, vm, uri,
|
2011-02-03 11:09:28 +00:00
|
|
|
cookiein, cookieinlen,
|
|
|
|
&cookieout, &cookieoutlen,
|
2015-06-15 22:42:10 +00:00
|
|
|
flags, bandwidth, dconn, graphicsuri,
|
2016-04-14 10:33:48 +00:00
|
|
|
nmigrate_disks, migrate_disks, compression);
|
2013-06-25 13:49:21 +00:00
|
|
|
}
|
2011-02-03 11:09:28 +00:00
|
|
|
|
|
|
|
/* Perform failed. Make sure Finish doesn't overwrite the error */
|
2011-07-19 00:27:32 +00:00
|
|
|
if (ret < 0) {
|
2011-02-03 11:09:28 +00:00
|
|
|
orig_err = virSaveLastError();
|
2011-07-19 00:27:32 +00:00
|
|
|
} else {
|
|
|
|
qemuMigrationJobSetPhase(driver, vm,
|
|
|
|
QEMU_MIGRATION_PHASE_PERFORM3_DONE);
|
|
|
|
}
|
2011-02-03 11:09:28 +00:00
|
|
|
|
|
|
|
/* If Perform returns < 0, then we need to cancel the VM
|
|
|
|
* startup on the destination
|
|
|
|
*/
|
2013-05-24 10:14:02 +00:00
|
|
|
cancelled = ret < 0;
|
2011-02-03 11:09:28 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
finish:
|
2011-02-03 11:09:28 +00:00
|
|
|
/*
|
|
|
|
* The status code from the source is passed to the destination.
|
|
|
|
* The dest can cleanup in the source indicated it failed to
|
|
|
|
* send all migration data. Returns NULL for ddomain if
|
|
|
|
* the dest was unable to complete migration.
|
|
|
|
*/
|
|
|
|
VIR_DEBUG("Finish3 %p ret=%d", dconn, ret);
|
|
|
|
VIR_FREE(cookiein);
|
|
|
|
cookiein = cookieout;
|
|
|
|
cookieinlen = cookieoutlen;
|
|
|
|
cookieout = NULL;
|
|
|
|
cookieoutlen = 0;
|
2013-06-25 13:49:21 +00:00
|
|
|
|
|
|
|
if (useParams) {
|
|
|
|
if (virTypedParamsGetString(params, nparams,
|
|
|
|
VIR_MIGRATE_PARAM_DEST_NAME, NULL) <= 0 &&
|
|
|
|
virTypedParamsReplaceString(¶ms, &nparams,
|
|
|
|
VIR_MIGRATE_PARAM_DEST_NAME,
|
|
|
|
vm->def->name) < 0) {
|
|
|
|
ddomain = NULL;
|
|
|
|
} else {
|
|
|
|
qemuDomainObjEnterRemote(vm);
|
|
|
|
ddomain = dconn->driver->domainMigrateFinish3Params
|
|
|
|
(dconn, params, nparams, cookiein, cookieinlen,
|
|
|
|
&cookieout, &cookieoutlen, destflags, cancelled);
|
|
|
|
qemuDomainObjExitRemote(vm);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
dname = dname ? dname : vm->def->name;
|
|
|
|
qemuDomainObjEnterRemote(vm);
|
|
|
|
ddomain = dconn->driver->domainMigrateFinish3
|
|
|
|
(dconn, dname, cookiein, cookieinlen, &cookieout, &cookieoutlen,
|
|
|
|
dconnuri, uri, destflags, cancelled);
|
|
|
|
qemuDomainObjExitRemote(vm);
|
|
|
|
}
|
2015-07-02 19:46:56 +00:00
|
|
|
|
|
|
|
if (cancelled) {
|
|
|
|
if (ddomain) {
|
|
|
|
VIR_ERROR(_("finish step ignored that migration was cancelled"));
|
|
|
|
} else {
|
|
|
|
/* If Finish reported a useful error, use it instead of the
|
|
|
|
* original "migration unexpectedly failed" error.
|
|
|
|
*
|
|
|
|
* This is ugly but we can't do better with the APIs we have. We
|
|
|
|
* only replace the error if Finish was called with cancelled == 1
|
|
|
|
* and reported a real error (old libvirt would report an error
|
|
|
|
* from RPC instead of MIGRATE_FINISH_OK), which only happens when
|
|
|
|
* the domain died on destination. To further reduce a possibility
|
|
|
|
* of false positives we also check that Perform returned
|
|
|
|
* VIR_ERR_OPERATION_FAILED.
|
|
|
|
*/
|
|
|
|
if (orig_err &&
|
|
|
|
orig_err->domain == VIR_FROM_QEMU &&
|
|
|
|
orig_err->code == VIR_ERR_OPERATION_FAILED) {
|
|
|
|
virErrorPtr err = virGetLastError();
|
2015-09-01 10:47:55 +00:00
|
|
|
if (err &&
|
|
|
|
err->domain == VIR_FROM_QEMU &&
|
2015-07-02 19:46:56 +00:00
|
|
|
err->code != VIR_ERR_MIGRATE_FINISH_OK) {
|
|
|
|
virFreeError(orig_err);
|
|
|
|
orig_err = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2011-02-03 11:09:28 +00:00
|
|
|
|
Fix the signature of virDomainMigrateFinish3 for error reporting
The current virDomainMigrateFinish3 method signature attempts to
distinguish two types of errors, by allowing return with ret== 0,
but ddomain == NULL, to indicate a failure to start the guest.
This is flawed, because when ret == 0, there is no way for the
virErrorPtr details to be sent back to the client.
Change the signature of virDomainMigrateFinish3 so it simply
returns a virDomainPtr, in the same way as virDomainMigrateFinish2
The disk locking code will protect against the only possible
failure mode this doesn't account for (loosing conenctivity to
libvirtd after Finish3 starts the CPUs, but before the client
sees the reply for Finish3).
* src/driver.h, src/libvirt.c, src/libvirt_internal.h: Change
virDomainMigrateFinish3 to return a virDomainPtr instead of int
* src/remote/remote_driver.c, src/remote/remote_protocol.x,
daemon/remote.c, src/qemu/qemu_driver.c, src/qemu/qemu_migration.c:
Update for API change
2011-05-24 12:05:33 +00:00
|
|
|
/* If ddomain is NULL, then we were unable to start
|
|
|
|
* the guest on the target, and must restart on the
|
|
|
|
* source. There is a small chance that the ddomain
|
|
|
|
* is NULL due to an RPC failure, in which case
|
|
|
|
* ddomain could in fact be running on the dest.
|
|
|
|
* The lock manager plugins should take care of
|
|
|
|
* safety in this scenario.
|
2011-02-03 11:09:28 +00:00
|
|
|
*/
|
2013-05-24 10:14:02 +00:00
|
|
|
cancelled = ddomain == NULL;
|
2011-02-03 11:09:28 +00:00
|
|
|
|
2011-05-23 16:48:36 +00:00
|
|
|
/* If finish3 set an error, and we don't have an earlier
|
|
|
|
* one we need to preserve it in case confirm3 overwrites
|
|
|
|
*/
|
|
|
|
if (!orig_err)
|
|
|
|
orig_err = virSaveLastError();
|
|
|
|
|
2011-02-03 11:09:28 +00:00
|
|
|
/*
|
|
|
|
* If cancelled, then src VM will be restarted, else
|
|
|
|
* it will be killed
|
|
|
|
*/
|
2012-08-02 10:11:20 +00:00
|
|
|
VIR_DEBUG("Confirm3 %p cancelled=%d vm=%p", sconn, cancelled, vm);
|
2011-02-03 11:09:28 +00:00
|
|
|
VIR_FREE(cookiein);
|
|
|
|
cookiein = cookieout;
|
|
|
|
cookieinlen = cookieoutlen;
|
|
|
|
cookieout = NULL;
|
|
|
|
cookieoutlen = 0;
|
2013-06-25 12:55:10 +00:00
|
|
|
ret = qemuMigrationConfirmPhase(driver, sconn, vm,
|
|
|
|
cookiein, cookieinlen,
|
|
|
|
flags, cancelled);
|
2011-02-03 11:09:28 +00:00
|
|
|
/* If Confirm3 returns -1, there's nothing more we can
|
|
|
|
* do, but fortunately worst case is that there is a
|
|
|
|
* domain left in 'paused' state on source.
|
|
|
|
*/
|
2011-08-16 09:24:25 +00:00
|
|
|
if (ret < 0)
|
|
|
|
VIR_WARN("Guest %s probably left in 'paused' state on source",
|
|
|
|
vm->def->name);
|
2011-02-03 11:09:28 +00:00
|
|
|
|
|
|
|
cleanup:
|
|
|
|
if (ddomain) {
|
Convert public datatypes to inherit from virObject
This converts the following public API datatypes to use the
virObject infrastructure:
virConnectPtr
virDomainPtr
virDomainSnapshotPtr
virInterfacePtr
virNetworkPtr
virNodeDevicePtr
virNWFilterPtr
virSecretPtr
virStreamPtr
virStorageVolPtr
virStoragePoolPtr
The code is significantly simplified, since the mutex in the
virConnectPtr object now only needs to be held when accessing
the per-connection virError object instance. All other operations
are completely lock free.
* src/datatypes.c, src/datatypes.h, src/libvirt.c: Convert
public datatypes to use virObject
* src/conf/domain_event.c, src/phyp/phyp_driver.c,
src/qemu/qemu_command.c, src/qemu/qemu_migration.c,
src/qemu/qemu_process.c, src/storage/storage_driver.c,
src/vbox/vbox_tmpl.c, src/xen/xend_internal.c,
tests/qemuxml2argvtest.c, tests/qemuxmlnstest.c,
tests/sexpr2xmltest.c, tests/xmconfigtest.c: Convert
to use virObjectUnref/virObjectRef
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-07-31 16:55:36 +00:00
|
|
|
virObjectUnref(ddomain);
|
2011-02-03 11:09:28 +00:00
|
|
|
ret = 0;
|
|
|
|
} else {
|
|
|
|
ret = -1;
|
|
|
|
}
|
|
|
|
|
Convert public datatypes to inherit from virObject
This converts the following public API datatypes to use the
virObject infrastructure:
virConnectPtr
virDomainPtr
virDomainSnapshotPtr
virInterfacePtr
virNetworkPtr
virNodeDevicePtr
virNWFilterPtr
virSecretPtr
virStreamPtr
virStorageVolPtr
virStoragePoolPtr
The code is significantly simplified, since the mutex in the
virConnectPtr object now only needs to be held when accessing
the per-connection virError object instance. All other operations
are completely lock free.
* src/datatypes.c, src/datatypes.h, src/libvirt.c: Convert
public datatypes to use virObject
* src/conf/domain_event.c, src/phyp/phyp_driver.c,
src/qemu/qemu_command.c, src/qemu/qemu_migration.c,
src/qemu/qemu_process.c, src/storage/storage_driver.c,
src/vbox/vbox_tmpl.c, src/xen/xend_internal.c,
tests/qemuxml2argvtest.c, tests/qemuxmlnstest.c,
tests/sexpr2xmltest.c, tests/xmconfigtest.c: Convert
to use virObjectUnref/virObjectRef
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-07-31 16:55:36 +00:00
|
|
|
virObjectUnref(st);
|
2011-02-03 11:09:28 +00:00
|
|
|
|
|
|
|
if (orig_err) {
|
|
|
|
virSetError(orig_err);
|
|
|
|
virFreeError(orig_err);
|
|
|
|
}
|
|
|
|
VIR_FREE(uri_out);
|
|
|
|
VIR_FREE(cookiein);
|
|
|
|
VIR_FREE(cookieout);
|
2013-06-25 13:49:21 +00:00
|
|
|
virTypedParamsFree(params, nparams);
|
2011-02-03 11:09:28 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-05-29 06:38:44 +00:00
|
|
|
static void
|
|
|
|
qemuMigrationConnectionClosed(virConnectPtr conn,
|
|
|
|
int reason,
|
|
|
|
void *opaque)
|
|
|
|
{
|
|
|
|
virDomainObjPtr vm = opaque;
|
|
|
|
|
|
|
|
VIR_DEBUG("conn=%p, reason=%d, vm=%s", conn, reason, vm->def->name);
|
|
|
|
virDomainObjBroadcast(vm);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2014-04-11 19:17:47 +00:00
|
|
|
static int virConnectCredType[] = {
|
|
|
|
VIR_CRED_AUTHNAME,
|
|
|
|
VIR_CRED_PASSPHRASE,
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
static virConnectAuth virConnectAuthConfig = {
|
|
|
|
.credtype = virConnectCredType,
|
|
|
|
.ncredtype = ARRAY_CARDINALITY(virConnectCredType),
|
|
|
|
};
|
|
|
|
|
|
|
|
|
2012-11-28 16:43:10 +00:00
|
|
|
static int doPeer2PeerMigrate(virQEMUDriverPtr driver,
|
2011-04-20 12:48:58 +00:00
|
|
|
virConnectPtr sconn,
|
2011-01-31 10:47:03 +00:00
|
|
|
virDomainObjPtr vm,
|
2011-05-18 09:26:30 +00:00
|
|
|
const char *xmlin,
|
Add a second URI parameter to virDomainMigratePerform3 method
The virDomainMigratePerform3 currently has a single URI parameter
whose meaning varies. It is either
- A QEMU migration URI (normal migration)
- A libvirtd connection URI (peer2peer migration)
Unfortunately when using peer2peer migration, without also
using tunnelled migration, it is possible that both URIs are
required.
This adds a second URI parameter to the virDomainMigratePerform3
method, to cope with this scenario. Each parameter how has a fixed
meaning.
NB, there is no way to actually take advantage of this yet,
since virDomainMigrate/virDomainMigrateToURI do not have any
way to provide the 2 separate URIs
* daemon/remote.c, src/remote/remote_driver.c,
src/remote/remote_protocol.x, src/remote_protocol-structs: Add
the second URI parameter to perform3 message
* src/driver.h, src/libvirt.c, src/libvirt_internal.h: Add
the second URI parameter to Perform3 method
* src/libvirt_internal.h, src/qemu/qemu_migration.c,
src/qemu/qemu_migration.h: Update to handle URIs correctly
2011-05-18 13:18:53 +00:00
|
|
|
const char *dconnuri,
|
2011-01-31 10:47:03 +00:00
|
|
|
const char *uri,
|
2013-06-18 10:17:18 +00:00
|
|
|
const char *graphicsuri,
|
2013-10-08 12:41:44 +00:00
|
|
|
const char *listenAddress,
|
2015-06-15 22:42:10 +00:00
|
|
|
size_t nmigrate_disks,
|
|
|
|
const char **migrate_disks,
|
2016-03-17 14:58:48 +00:00
|
|
|
int nbdPort,
|
2016-04-14 10:33:48 +00:00
|
|
|
qemuMigrationCompressionPtr compression,
|
2011-01-31 10:47:03 +00:00
|
|
|
unsigned long flags,
|
|
|
|
const char *dname,
|
2011-06-06 03:05:34 +00:00
|
|
|
unsigned long resource,
|
|
|
|
bool *v3proto)
|
2011-01-31 10:47:03 +00:00
|
|
|
{
|
|
|
|
int ret = -1;
|
|
|
|
virConnectPtr dconn = NULL;
|
|
|
|
bool p2p;
|
2011-07-19 14:51:08 +00:00
|
|
|
virErrorPtr orig_err = NULL;
|
2012-12-11 11:50:53 +00:00
|
|
|
bool offline = false;
|
2013-01-10 21:03:14 +00:00
|
|
|
virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
|
2013-06-25 13:49:21 +00:00
|
|
|
bool useParams;
|
2011-07-19 14:51:08 +00:00
|
|
|
|
2015-06-15 22:42:10 +00:00
|
|
|
VIR_DEBUG("driver=%p, sconn=%p, vm=%p, xmlin=%s, dconnuri=%s, uri=%s, "
|
|
|
|
"graphicsuri=%s, listenAddress=%s, nmigrate_disks=%zu, "
|
2016-03-17 14:58:48 +00:00
|
|
|
"migrate_disks=%p, nbdPort=%d, flags=%lx, dname=%s, "
|
|
|
|
"resource=%lu",
|
2011-05-20 10:03:04 +00:00
|
|
|
driver, sconn, vm, NULLSTR(xmlin), NULLSTR(dconnuri),
|
2013-10-08 12:41:44 +00:00
|
|
|
NULLSTR(uri), NULLSTR(graphicsuri), NULLSTR(listenAddress),
|
2016-03-17 14:58:48 +00:00
|
|
|
nmigrate_disks, migrate_disks, nbdPort, flags, NULLSTR(dname),
|
|
|
|
resource);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2015-04-30 13:56:07 +00:00
|
|
|
if (flags & VIR_MIGRATE_TUNNELLED && uri) {
|
|
|
|
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
|
|
|
|
_("migration URI is not supported by tunnelled "
|
|
|
|
"migration"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (flags & VIR_MIGRATE_TUNNELLED && listenAddress) {
|
|
|
|
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
|
|
|
|
_("listen address is not supported by tunnelled "
|
|
|
|
"migration"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2016-03-17 14:58:48 +00:00
|
|
|
if (flags & VIR_MIGRATE_TUNNELLED && nbdPort) {
|
|
|
|
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
|
|
|
|
_("disk port address is not supported by tunnelled "
|
|
|
|
"migration"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2011-01-31 10:47:03 +00:00
|
|
|
/* the order of operations is important here; we make sure the
|
|
|
|
* destination side is completely setup before we touch the source
|
|
|
|
*/
|
|
|
|
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjEnterRemote(vm);
|
2014-04-11 19:17:47 +00:00
|
|
|
dconn = virConnectOpenAuth(dconnuri, &virConnectAuthConfig, 0);
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjExitRemote(vm);
|
2011-01-31 10:47:03 +00:00
|
|
|
if (dconn == NULL) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED,
|
2013-05-28 19:12:01 +00:00
|
|
|
_("Failed to connect to remote libvirt URI %s: %s"),
|
|
|
|
dconnuri, virGetLastErrorMessage());
|
2013-01-10 21:03:14 +00:00
|
|
|
virObjectUnref(cfg);
|
2011-01-31 10:47:03 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2013-01-10 21:03:14 +00:00
|
|
|
if (virConnectSetKeepAlive(dconn, cfg->keepAliveInterval,
|
|
|
|
cfg->keepAliveCount) < 0)
|
2011-09-16 11:50:56 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2015-05-29 06:38:44 +00:00
|
|
|
if (virConnectRegisterCloseCallback(dconn, qemuMigrationConnectionClosed,
|
|
|
|
vm, NULL) < 0) {
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjEnterRemote(vm);
|
2011-01-31 10:47:03 +00:00
|
|
|
p2p = VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn,
|
|
|
|
VIR_DRV_FEATURE_MIGRATION_P2P);
|
2011-06-06 03:05:34 +00:00
|
|
|
/* v3proto reflects whether the caller used Perform3, but with
|
2011-07-19 00:27:32 +00:00
|
|
|
* p2p migrate, regardless of whether Perform2 or Perform3
|
2011-06-06 03:05:34 +00:00
|
|
|
* were used, we decide protocol based on what target supports
|
|
|
|
*/
|
|
|
|
*v3proto = VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn,
|
|
|
|
VIR_DRV_FEATURE_MIGRATION_V3);
|
2013-06-25 13:49:21 +00:00
|
|
|
useParams = VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn,
|
|
|
|
VIR_DRV_FEATURE_MIGRATION_PARAMS);
|
2012-11-21 08:28:49 +00:00
|
|
|
if (flags & VIR_MIGRATE_OFFLINE)
|
|
|
|
offline = VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn,
|
|
|
|
VIR_DRV_FEATURE_MIGRATION_OFFLINE);
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjExitRemote(vm);
|
2011-02-03 11:09:28 +00:00
|
|
|
|
2011-01-31 10:47:03 +00:00
|
|
|
if (!p2p) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED, "%s",
|
|
|
|
_("Destination libvirt does not support peer-to-peer migration protocol"));
|
2011-01-31 10:47:03 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2013-06-25 13:49:21 +00:00
|
|
|
/* Only xmlin, dname, uri, and bandwidth parameters can be used with
|
|
|
|
* old-style APIs. */
|
2015-06-15 22:42:10 +00:00
|
|
|
if (!useParams && (graphicsuri || listenAddress || nmigrate_disks)) {
|
2013-06-25 13:49:21 +00:00
|
|
|
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
|
|
|
|
_("Migration APIs with extensible parameters are not "
|
|
|
|
"supported but extended parameters were passed"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2012-11-21 08:28:49 +00:00
|
|
|
if (flags & VIR_MIGRATE_OFFLINE && !offline) {
|
|
|
|
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s",
|
|
|
|
_("offline migration is not supported by "
|
|
|
|
"the destination host"));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2011-01-31 10:47:03 +00:00
|
|
|
/* domain may have been stopped while we were talking to remote daemon */
|
2012-11-21 08:28:49 +00:00
|
|
|
if (!virDomainObjIsActive(vm) && !(flags & VIR_MIGRATE_OFFLINE)) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("guest unexpectedly quit"));
|
2011-01-31 10:47:03 +00:00
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
2011-07-19 00:27:32 +00:00
|
|
|
/* Change protection is only required on the source side (us), and
|
|
|
|
* only for v3 migration when begin and perform are separate jobs.
|
|
|
|
* But peer-2-peer is already a single job, and we still want to
|
|
|
|
* talk to older destinations that would reject the flag.
|
|
|
|
* Therefore it is safe to clear the bit here. */
|
|
|
|
flags &= ~VIR_MIGRATE_CHANGE_PROTECTION;
|
|
|
|
|
2013-06-25 13:49:21 +00:00
|
|
|
if (*v3proto) {
|
|
|
|
ret = doPeer2PeerMigrate3(driver, sconn, dconn, dconnuri, vm, xmlin,
|
2013-10-08 12:41:44 +00:00
|
|
|
dname, uri, graphicsuri, listenAddress,
|
2016-03-17 14:58:48 +00:00
|
|
|
nmigrate_disks, migrate_disks, nbdPort,
|
2016-04-14 10:33:48 +00:00
|
|
|
compression, resource, useParams, flags);
|
2013-06-25 13:49:21 +00:00
|
|
|
} else {
|
2011-02-03 11:09:28 +00:00
|
|
|
ret = doPeer2PeerMigrate2(driver, sconn, dconn, vm,
|
Add a second URI parameter to virDomainMigratePerform3 method
The virDomainMigratePerform3 currently has a single URI parameter
whose meaning varies. It is either
- A QEMU migration URI (normal migration)
- A libvirtd connection URI (peer2peer migration)
Unfortunately when using peer2peer migration, without also
using tunnelled migration, it is possible that both URIs are
required.
This adds a second URI parameter to the virDomainMigratePerform3
method, to cope with this scenario. Each parameter how has a fixed
meaning.
NB, there is no way to actually take advantage of this yet,
since virDomainMigrate/virDomainMigrateToURI do not have any
way to provide the 2 separate URIs
* daemon/remote.c, src/remote/remote_driver.c,
src/remote/remote_protocol.x, src/remote_protocol-structs: Add
the second URI parameter to perform3 message
* src/driver.h, src/libvirt.c, src/libvirt_internal.h: Add
the second URI parameter to Perform3 method
* src/libvirt_internal.h, src/qemu/qemu_migration.c,
src/qemu/qemu_migration.h: Update to handle URIs correctly
2011-05-18 13:18:53 +00:00
|
|
|
dconnuri, flags, dname, resource);
|
2013-06-25 13:49:21 +00:00
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2011-07-19 14:51:08 +00:00
|
|
|
orig_err = virSaveLastError();
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjEnterRemote(vm);
|
2015-05-29 06:38:44 +00:00
|
|
|
virConnectUnregisterCloseCallback(dconn, qemuMigrationConnectionClosed);
|
2014-01-03 15:08:52 +00:00
|
|
|
virObjectUnref(dconn);
|
2013-02-06 18:17:20 +00:00
|
|
|
qemuDomainObjExitRemote(vm);
|
2011-07-19 14:51:08 +00:00
|
|
|
if (orig_err) {
|
|
|
|
virSetError(orig_err);
|
|
|
|
virFreeError(orig_err);
|
|
|
|
}
|
2013-01-10 21:03:14 +00:00
|
|
|
virObjectUnref(cfg);
|
2011-01-31 10:47:03 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-07-19 00:27:32 +00:00
|
|
|
/*
|
|
|
|
* This implements perform part of the migration protocol when migration job
|
|
|
|
* does not need to be active across several APIs, i.e., peer2peer migration or
|
|
|
|
* perform phase of v2 non-peer2peer migration.
|
|
|
|
*/
|
|
|
|
static int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationPerformJob(virQEMUDriverPtr driver,
|
2011-07-19 00:27:32 +00:00
|
|
|
virConnectPtr conn,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *xmlin,
|
|
|
|
const char *dconnuri,
|
|
|
|
const char *uri,
|
2013-06-18 10:17:18 +00:00
|
|
|
const char *graphicsuri,
|
2013-10-08 12:41:44 +00:00
|
|
|
const char *listenAddress,
|
2015-06-15 22:42:10 +00:00
|
|
|
size_t nmigrate_disks,
|
|
|
|
const char **migrate_disks,
|
2016-03-17 14:58:48 +00:00
|
|
|
int nbdPort,
|
2016-04-14 10:33:48 +00:00
|
|
|
qemuMigrationCompressionPtr compression,
|
2014-01-07 01:03:17 +00:00
|
|
|
const char *cookiein,
|
2011-07-19 00:27:32 +00:00
|
|
|
int cookieinlen,
|
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
|
|
|
unsigned long flags,
|
|
|
|
const char *dname,
|
|
|
|
unsigned long resource,
|
|
|
|
bool v3proto)
|
2011-01-31 10:47:03 +00:00
|
|
|
{
|
2013-11-22 14:38:05 +00:00
|
|
|
virObjectEventPtr event = NULL;
|
2011-01-31 10:47:03 +00:00
|
|
|
int ret = -1;
|
2012-04-20 12:07:49 +00:00
|
|
|
virErrorPtr orig_err = NULL;
|
2013-01-10 21:03:14 +00:00
|
|
|
virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2011-07-19 00:27:32 +00:00
|
|
|
if (qemuMigrationJobStart(driver, vm, QEMU_ASYNC_JOB_MIGRATION_OUT) < 0)
|
2011-01-31 10:47:03 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2012-11-21 08:28:49 +00:00
|
|
|
if (!virDomainObjIsActive(vm) && !(flags & VIR_MIGRATE_OFFLINE)) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID,
|
|
|
|
"%s", _("domain is not running"));
|
2011-01-31 10:47:03 +00:00
|
|
|
goto endjob;
|
|
|
|
}
|
|
|
|
|
2015-10-06 14:24:48 +00:00
|
|
|
if (!qemuMigrationIsAllowed(driver, vm, true, flags))
|
2012-10-17 12:08:17 +00:00
|
|
|
goto endjob;
|
2011-06-23 10:41:57 +00:00
|
|
|
|
2015-06-15 22:42:10 +00:00
|
|
|
if (!(flags & VIR_MIGRATE_UNSAFE) &&
|
|
|
|
!qemuMigrationIsSafe(vm->def, nmigrate_disks, migrate_disks))
|
2012-10-17 12:08:17 +00:00
|
|
|
goto endjob;
|
2012-02-21 12:20:06 +00:00
|
|
|
|
2014-02-06 13:30:59 +00:00
|
|
|
qemuMigrationStoreDomainState(vm);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
|
|
|
if ((flags & (VIR_MIGRATE_TUNNELLED | VIR_MIGRATE_PEER2PEER))) {
|
2011-07-19 00:27:32 +00:00
|
|
|
ret = doPeer2PeerMigrate(driver, conn, vm, xmlin,
|
2013-10-08 12:41:44 +00:00
|
|
|
dconnuri, uri, graphicsuri, listenAddress,
|
2016-03-17 14:58:48 +00:00
|
|
|
nmigrate_disks, migrate_disks, nbdPort,
|
2016-04-14 10:33:48 +00:00
|
|
|
compression, flags, dname, resource, &v3proto);
|
2011-01-31 10:47:03 +00:00
|
|
|
} else {
|
2011-07-19 00:27:32 +00:00
|
|
|
qemuMigrationJobSetPhase(driver, vm, QEMU_MIGRATION_PHASE_PERFORM2);
|
|
|
|
ret = doNativeMigrate(driver, vm, uri, cookiein, cookieinlen,
|
|
|
|
cookieout, cookieoutlen,
|
2016-04-14 10:33:48 +00:00
|
|
|
flags, resource, NULL, NULL, 0, NULL,
|
|
|
|
compression);
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
2011-07-19 00:27:32 +00:00
|
|
|
if (ret < 0)
|
|
|
|
goto endjob;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2011-05-23 12:50:11 +00:00
|
|
|
/*
|
|
|
|
* In v3 protocol, the source VM is not killed off until the
|
|
|
|
* confirm step.
|
|
|
|
*/
|
2011-07-19 00:27:32 +00:00
|
|
|
if (!v3proto) {
|
2012-06-11 13:20:44 +00:00
|
|
|
qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_MIGRATED,
|
2016-02-11 10:20:28 +00:00
|
|
|
QEMU_ASYNC_JOB_MIGRATION_OUT,
|
2012-06-11 13:20:44 +00:00
|
|
|
VIR_QEMU_PROCESS_STOP_MIGRATED);
|
Move qemu_audit.h helpers into shared code
The LXC and UML drivers can both make use of auditing. Move
the qemu_audit.{c,h} files to src/conf/domain_audit.{c,h}
* src/conf/domain_audit.c: Rename from src/qemu/qemu_audit.c
* src/conf/domain_audit.h: Rename from src/qemu/qemu_audit.h
* src/Makefile.am: Remove qemu_audit.{c,h}, add domain_audit.{c,h}
* src/qemu/qemu_audit.h, src/qemu/qemu_cgroup.c,
src/qemu/qemu_command.c, src/qemu/qemu_driver.c,
src/qemu/qemu_hotplug.c, src/qemu/qemu_migration.c,
src/qemu/qemu_process.c: Update for changed audit API names
2011-07-04 10:56:13 +00:00
|
|
|
virDomainAuditStop(vm, "migrated");
|
2013-11-21 17:03:26 +00:00
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
2011-02-03 11:09:28 +00:00
|
|
|
VIR_DOMAIN_EVENT_STOPPED,
|
|
|
|
VIR_DOMAIN_EVENT_STOPPED_MIGRATED);
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
endjob:
|
2012-04-20 12:07:49 +00:00
|
|
|
if (ret < 0)
|
|
|
|
orig_err = virSaveLastError();
|
|
|
|
|
2014-02-06 13:30:59 +00:00
|
|
|
if (qemuMigrationRestoreDomainState(conn, vm)) {
|
2013-11-21 17:03:26 +00:00
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
2011-01-31 10:47:03 +00:00
|
|
|
VIR_DOMAIN_EVENT_RESUMED,
|
|
|
|
VIR_DOMAIN_EVENT_RESUMED_MIGRATED);
|
|
|
|
}
|
2011-07-19 00:27:32 +00:00
|
|
|
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
qemuMigrationJobFinish(driver, vm);
|
2015-09-22 13:25:00 +00:00
|
|
|
if (!virDomainObjIsActive(vm) && ret == 0) {
|
2015-10-27 08:53:59 +00:00
|
|
|
if (flags & VIR_MIGRATE_UNDEFINE_SOURCE) {
|
2013-01-10 21:03:14 +00:00
|
|
|
virDomainDeleteConfig(cfg->configDir, cfg->autostartDir, vm);
|
2015-10-27 08:53:59 +00:00
|
|
|
vm->persistent = 0;
|
|
|
|
}
|
2011-09-22 06:02:03 +00:00
|
|
|
qemuDomainRemoveInactive(driver, vm);
|
2011-07-19 00:27:32 +00:00
|
|
|
}
|
|
|
|
|
2012-04-20 12:07:49 +00:00
|
|
|
if (orig_err) {
|
|
|
|
virSetError(orig_err);
|
|
|
|
virFreeError(orig_err);
|
|
|
|
}
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2015-04-23 15:27:58 +00:00
|
|
|
virDomainObjEndAPI(&vm);
|
2015-07-07 13:33:53 +00:00
|
|
|
qemuDomainEventQueue(driver, event);
|
2013-01-10 21:03:14 +00:00
|
|
|
virObjectUnref(cfg);
|
2011-07-19 00:27:32 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This implements perform phase of v3 migration protocol.
|
|
|
|
*/
|
|
|
|
static int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationPerformPhase(virQEMUDriverPtr driver,
|
2011-07-19 00:27:32 +00:00
|
|
|
virConnectPtr conn,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *uri,
|
2013-06-18 10:17:18 +00:00
|
|
|
const char *graphicsuri,
|
2015-06-15 22:42:10 +00:00
|
|
|
size_t nmigrate_disks,
|
|
|
|
const char **migrate_disks,
|
2016-04-14 10:33:48 +00:00
|
|
|
qemuMigrationCompressionPtr compression,
|
2011-07-19 00:27:32 +00:00
|
|
|
const char *cookiein,
|
|
|
|
int cookieinlen,
|
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
|
|
|
unsigned long flags,
|
|
|
|
unsigned long resource)
|
|
|
|
{
|
2013-11-22 14:38:05 +00:00
|
|
|
virObjectEventPtr event = NULL;
|
2011-07-19 00:27:32 +00:00
|
|
|
int ret = -1;
|
|
|
|
|
|
|
|
/* If we didn't start the job in the begin phase, start it now. */
|
|
|
|
if (!(flags & VIR_MIGRATE_CHANGE_PROTECTION)) {
|
|
|
|
if (qemuMigrationJobStart(driver, vm, QEMU_ASYNC_JOB_MIGRATION_OUT) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
} else if (!qemuMigrationJobIsActive(vm, QEMU_ASYNC_JOB_MIGRATION_OUT)) {
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
qemuMigrationJobStartPhase(driver, vm, QEMU_MIGRATION_PHASE_PERFORM3);
|
2013-07-15 14:53:13 +00:00
|
|
|
virCloseCallbacksUnset(driver->closeCallbacks, vm,
|
|
|
|
qemuMigrationCleanup);
|
2011-07-19 00:27:32 +00:00
|
|
|
|
|
|
|
ret = doNativeMigrate(driver, vm, uri, cookiein, cookieinlen,
|
|
|
|
cookieout, cookieoutlen,
|
2015-06-15 22:42:10 +00:00
|
|
|
flags, resource, NULL, graphicsuri,
|
2016-04-14 10:33:48 +00:00
|
|
|
nmigrate_disks, migrate_disks, compression);
|
2011-07-19 00:27:32 +00:00
|
|
|
|
2014-02-06 13:30:59 +00:00
|
|
|
if (ret < 0) {
|
|
|
|
if (qemuMigrationRestoreDomainState(conn, vm)) {
|
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
|
|
|
VIR_DOMAIN_EVENT_RESUMED,
|
|
|
|
VIR_DOMAIN_EVENT_RESUMED_MIGRATED);
|
2011-05-19 11:48:15 +00:00
|
|
|
}
|
2011-07-19 00:27:32 +00:00
|
|
|
goto endjob;
|
2014-02-06 13:30:59 +00:00
|
|
|
}
|
2011-07-19 00:27:32 +00:00
|
|
|
|
|
|
|
qemuMigrationJobSetPhase(driver, vm, QEMU_MIGRATION_PHASE_PERFORM3_DONE);
|
|
|
|
|
2013-07-15 14:53:13 +00:00
|
|
|
if (virCloseCallbacksSet(driver->closeCallbacks, vm, conn,
|
|
|
|
qemuMigrationCleanup) < 0)
|
2012-03-19 15:48:43 +00:00
|
|
|
goto endjob;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
endjob:
|
2011-07-19 00:27:32 +00:00
|
|
|
if (ret < 0)
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
qemuMigrationJobFinish(driver, vm);
|
2011-07-19 00:27:32 +00:00
|
|
|
else
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
qemuMigrationJobContinue(vm);
|
2015-09-22 13:25:00 +00:00
|
|
|
if (!virDomainObjIsActive(vm))
|
2011-09-22 06:02:03 +00:00
|
|
|
qemuDomainRemoveInactive(driver, vm);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2015-04-23 15:27:58 +00:00
|
|
|
virDomainObjEndAPI(&vm);
|
2015-07-07 13:33:53 +00:00
|
|
|
qemuDomainEventQueue(driver, event);
|
2011-01-31 10:47:03 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2011-07-19 00:27:32 +00:00
|
|
|
int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationPerform(virQEMUDriverPtr driver,
|
2011-07-19 00:27:32 +00:00
|
|
|
virConnectPtr conn,
|
|
|
|
virDomainObjPtr vm,
|
|
|
|
const char *xmlin,
|
|
|
|
const char *dconnuri,
|
|
|
|
const char *uri,
|
2013-06-18 10:17:18 +00:00
|
|
|
const char *graphicsuri,
|
2013-10-08 12:41:44 +00:00
|
|
|
const char *listenAddress,
|
2015-06-15 22:42:10 +00:00
|
|
|
size_t nmigrate_disks,
|
|
|
|
const char **migrate_disks,
|
2016-03-17 14:58:48 +00:00
|
|
|
int nbdPort,
|
2016-04-14 10:33:48 +00:00
|
|
|
qemuMigrationCompressionPtr compression,
|
2011-07-19 00:27:32 +00:00
|
|
|
const char *cookiein,
|
|
|
|
int cookieinlen,
|
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
|
|
|
unsigned long flags,
|
|
|
|
const char *dname,
|
|
|
|
unsigned long resource,
|
|
|
|
bool v3proto)
|
|
|
|
{
|
|
|
|
VIR_DEBUG("driver=%p, conn=%p, vm=%p, xmlin=%s, dconnuri=%s, "
|
2015-06-15 22:42:10 +00:00
|
|
|
"uri=%s, graphicsuri=%s, listenAddress=%s, "
|
2016-03-17 14:58:48 +00:00
|
|
|
"nmigrate_disks=%zu, migrate_disks=%p, nbdPort=%d, "
|
2013-06-18 10:17:18 +00:00
|
|
|
"cookiein=%s, cookieinlen=%d, cookieout=%p, cookieoutlen=%p, "
|
|
|
|
"flags=%lx, dname=%s, resource=%lu, v3proto=%d",
|
2011-07-19 00:27:32 +00:00
|
|
|
driver, conn, vm, NULLSTR(xmlin), NULLSTR(dconnuri),
|
2013-10-11 12:15:32 +00:00
|
|
|
NULLSTR(uri), NULLSTR(graphicsuri), NULLSTR(listenAddress),
|
2016-03-17 14:58:48 +00:00
|
|
|
nmigrate_disks, migrate_disks, nbdPort,
|
|
|
|
NULLSTR(cookiein), cookieinlen, cookieout, cookieoutlen,
|
|
|
|
flags, NULLSTR(dname), resource, v3proto);
|
2011-07-19 00:27:32 +00:00
|
|
|
|
|
|
|
if ((flags & (VIR_MIGRATE_TUNNELLED | VIR_MIGRATE_PEER2PEER))) {
|
|
|
|
if (cookieinlen) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID,
|
|
|
|
"%s", _("received unexpected cookie with P2P migration"));
|
2011-07-19 00:27:32 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
return qemuMigrationPerformJob(driver, conn, vm, xmlin, dconnuri, uri,
|
2013-10-08 12:41:44 +00:00
|
|
|
graphicsuri, listenAddress,
|
2016-03-17 14:58:48 +00:00
|
|
|
nmigrate_disks, migrate_disks, nbdPort,
|
2016-04-14 10:33:48 +00:00
|
|
|
compression, cookiein, cookieinlen,
|
2013-06-18 10:17:18 +00:00
|
|
|
cookieout, cookieoutlen,
|
|
|
|
flags, dname, resource, v3proto);
|
2011-07-19 00:27:32 +00:00
|
|
|
} else {
|
|
|
|
if (dconnuri) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("Unexpected dconnuri parameter with non-peer2peer migration"));
|
2011-07-19 00:27:32 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (v3proto) {
|
|
|
|
return qemuMigrationPerformPhase(driver, conn, vm, uri,
|
2013-06-18 10:17:18 +00:00
|
|
|
graphicsuri,
|
2015-06-15 22:42:10 +00:00
|
|
|
nmigrate_disks, migrate_disks,
|
2016-04-14 10:33:48 +00:00
|
|
|
compression, cookiein, cookieinlen,
|
2011-07-19 00:27:32 +00:00
|
|
|
cookieout, cookieoutlen,
|
2011-08-11 12:36:04 +00:00
|
|
|
flags, resource);
|
2011-07-19 00:27:32 +00:00
|
|
|
} else {
|
2016-01-07 10:39:45 +00:00
|
|
|
return qemuMigrationPerformJob(driver, conn, vm, xmlin, NULL,
|
2013-10-08 12:41:44 +00:00
|
|
|
uri, graphicsuri, listenAddress,
|
2016-03-17 14:58:48 +00:00
|
|
|
nmigrate_disks, migrate_disks, nbdPort,
|
2016-04-14 10:33:48 +00:00
|
|
|
compression, cookiein, cookieinlen,
|
2011-07-19 00:27:32 +00:00
|
|
|
cookieout, cookieoutlen, flags,
|
|
|
|
dname, resource, v3proto);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2012-03-27 20:00:01 +00:00
|
|
|
static int
|
2014-03-18 08:15:21 +00:00
|
|
|
qemuMigrationVPAssociatePortProfiles(virDomainDefPtr def)
|
|
|
|
{
|
Convert 'int i' to 'size_t i' in src/qemu files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 14:09:33 +00:00
|
|
|
size_t i;
|
2011-01-31 10:47:03 +00:00
|
|
|
int last_good_net = -1;
|
|
|
|
virDomainNetDefPtr net;
|
|
|
|
|
|
|
|
for (i = 0; i < def->nnets; i++) {
|
|
|
|
net = def->nets[i];
|
2011-07-04 01:57:45 +00:00
|
|
|
if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_DIRECT) {
|
Rename Macvtap management APIs
In preparation for code re-organization, rename the Macvtap
management APIs to have the following patterns
virNetDevMacVLanXXXXX - macvlan/macvtap interface management
virNetDevVPortProfileXXXX - virtual port profile management
* src/util/macvtap.c, src/util/macvtap.h: Rename APIs
* src/conf/domain_conf.c, src/network/bridge_driver.c,
src/qemu/qemu_command.c, src/qemu/qemu_command.h,
src/qemu/qemu_driver.c, src/qemu/qemu_hotplug.c,
src/qemu/qemu_migration.c, src/qemu/qemu_process.c,
src/qemu/qemu_process.h: Update for renamed APIs
2011-11-02 16:51:01 +00:00
|
|
|
if (virNetDevVPortProfileAssociate(net->ifname,
|
2012-02-15 19:19:32 +00:00
|
|
|
virDomainNetGetActualVirtPortProfile(net),
|
2012-07-17 12:07:59 +00:00
|
|
|
&net->mac,
|
Rename Macvtap management APIs
In preparation for code re-organization, rename the Macvtap
management APIs to have the following patterns
virNetDevMacVLanXXXXX - macvlan/macvtap interface management
virNetDevVPortProfileXXXX - virtual port profile management
* src/util/macvtap.c, src/util/macvtap.h: Rename APIs
* src/conf/domain_conf.c, src/network/bridge_driver.c,
src/qemu/qemu_command.c, src/qemu/qemu_command.h,
src/qemu/qemu_driver.c, src/qemu/qemu_hotplug.c,
src/qemu/qemu_migration.c, src/qemu/qemu_process.c,
src/qemu/qemu_process.h: Update for renamed APIs
2011-11-02 16:51:01 +00:00
|
|
|
virDomainNetGetActualDirectDev(net),
|
2012-03-06 01:12:39 +00:00
|
|
|
-1,
|
Rename Macvtap management APIs
In preparation for code re-organization, rename the Macvtap
management APIs to have the following patterns
virNetDevMacVLanXXXXX - macvlan/macvtap interface management
virNetDevVPortProfileXXXX - virtual port profile management
* src/util/macvtap.c, src/util/macvtap.h: Rename APIs
* src/conf/domain_conf.c, src/network/bridge_driver.c,
src/qemu/qemu_command.c, src/qemu/qemu_command.h,
src/qemu/qemu_driver.c, src/qemu/qemu_hotplug.c,
src/qemu/qemu_migration.c, src/qemu/qemu_process.c,
src/qemu/qemu_process.h: Update for renamed APIs
2011-11-02 16:51:01 +00:00
|
|
|
def->uuid,
|
2012-03-27 20:00:01 +00:00
|
|
|
VIR_NETDEV_VPORT_PROFILE_OP_MIGRATE_IN_FINISH,
|
|
|
|
false) < 0) {
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_FAILED,
|
|
|
|
_("Port profile Associate failed for %s"),
|
|
|
|
net->ifname);
|
2011-01-31 10:47:03 +00:00
|
|
|
goto err_exit;
|
2012-03-27 20:00:01 +00:00
|
|
|
}
|
2015-04-07 18:40:15 +00:00
|
|
|
last_good_net = i;
|
2012-03-27 20:00:01 +00:00
|
|
|
VIR_DEBUG("Port profile Associate succeeded for %s", net->ifname);
|
2012-03-29 11:15:00 +00:00
|
|
|
|
2012-07-17 12:07:59 +00:00
|
|
|
if (virNetDevMacVLanVPortProfileRegisterCallback(net->ifname, &net->mac,
|
2012-03-29 11:15:00 +00:00
|
|
|
virDomainNetGetActualDirectDev(net), def->uuid,
|
|
|
|
virDomainNetGetActualVirtPortProfile(net),
|
|
|
|
VIR_NETDEV_VPORT_PROFILE_OP_CREATE))
|
|
|
|
goto err_exit;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-03-27 20:00:01 +00:00
|
|
|
return 0;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
err_exit:
|
2015-04-07 18:40:15 +00:00
|
|
|
for (i = 0; last_good_net != -1 && i <= last_good_net; i++) {
|
2011-01-31 10:47:03 +00:00
|
|
|
net = def->nets[i];
|
2011-07-04 01:57:45 +00:00
|
|
|
if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_DIRECT) {
|
Rename Macvtap management APIs
In preparation for code re-organization, rename the Macvtap
management APIs to have the following patterns
virNetDevMacVLanXXXXX - macvlan/macvtap interface management
virNetDevVPortProfileXXXX - virtual port profile management
* src/util/macvtap.c, src/util/macvtap.h: Rename APIs
* src/conf/domain_conf.c, src/network/bridge_driver.c,
src/qemu/qemu_command.c, src/qemu/qemu_command.h,
src/qemu/qemu_driver.c, src/qemu/qemu_hotplug.c,
src/qemu/qemu_migration.c, src/qemu/qemu_process.c,
src/qemu/qemu_process.h: Update for renamed APIs
2011-11-02 16:51:01 +00:00
|
|
|
ignore_value(virNetDevVPortProfileDisassociate(net->ifname,
|
2012-02-15 19:19:32 +00:00
|
|
|
virDomainNetGetActualVirtPortProfile(net),
|
2012-07-17 12:07:59 +00:00
|
|
|
&net->mac,
|
Rename Macvtap management APIs
In preparation for code re-organization, rename the Macvtap
management APIs to have the following patterns
virNetDevMacVLanXXXXX - macvlan/macvtap interface management
virNetDevVPortProfileXXXX - virtual port profile management
* src/util/macvtap.c, src/util/macvtap.h: Rename APIs
* src/conf/domain_conf.c, src/network/bridge_driver.c,
src/qemu/qemu_command.c, src/qemu/qemu_command.h,
src/qemu/qemu_driver.c, src/qemu/qemu_hotplug.c,
src/qemu/qemu_migration.c, src/qemu/qemu_process.c,
src/qemu/qemu_process.h: Update for renamed APIs
2011-11-02 16:51:01 +00:00
|
|
|
virDomainNetGetActualDirectDev(net),
|
2012-03-06 01:12:39 +00:00
|
|
|
-1,
|
Rename Macvtap management APIs
In preparation for code re-organization, rename the Macvtap
management APIs to have the following patterns
virNetDevMacVLanXXXXX - macvlan/macvtap interface management
virNetDevVPortProfileXXXX - virtual port profile management
* src/util/macvtap.c, src/util/macvtap.h: Rename APIs
* src/conf/domain_conf.c, src/network/bridge_driver.c,
src/qemu/qemu_command.c, src/qemu/qemu_command.h,
src/qemu/qemu_driver.c, src/qemu/qemu_hotplug.c,
src/qemu/qemu_migration.c, src/qemu/qemu_process.c,
src/qemu/qemu_process.h: Update for renamed APIs
2011-11-02 16:51:01 +00:00
|
|
|
VIR_NETDEV_VPORT_PROFILE_OP_MIGRATE_IN_FINISH));
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
}
|
2012-03-27 20:00:01 +00:00
|
|
|
return -1;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-07-07 10:11:37 +00:00
|
|
|
static int
|
|
|
|
qemuMigrationPersist(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm,
|
2015-09-10 22:14:59 +00:00
|
|
|
qemuMigrationCookiePtr mig,
|
|
|
|
bool ignoreSaveError)
|
2015-07-07 10:11:37 +00:00
|
|
|
{
|
|
|
|
virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
|
|
|
|
virCapsPtr caps = NULL;
|
|
|
|
virDomainDefPtr vmdef;
|
2015-09-10 22:14:59 +00:00
|
|
|
virDomainDefPtr oldDef = NULL;
|
|
|
|
unsigned int oldPersist = vm->persistent;
|
2015-07-07 10:11:37 +00:00
|
|
|
virObjectEventPtr event;
|
|
|
|
int ret = -1;
|
|
|
|
|
|
|
|
if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
|
|
|
|
goto cleanup;
|
|
|
|
|
|
|
|
vm->persistent = 1;
|
2015-09-10 22:14:59 +00:00
|
|
|
oldDef = vm->newDef;
|
|
|
|
vm->newDef = qemuMigrationCookieGetPersistent(mig);
|
2015-07-07 10:11:37 +00:00
|
|
|
|
2015-09-10 22:14:59 +00:00
|
|
|
if (!(vmdef = virDomainObjGetPersistentDef(caps, driver->xmlopt, vm)))
|
|
|
|
goto error;
|
2015-07-07 10:11:37 +00:00
|
|
|
|
2016-02-03 21:40:36 +00:00
|
|
|
if (virDomainSaveConfig(cfg->configDir, driver->caps, vmdef) < 0 &&
|
|
|
|
!ignoreSaveError)
|
2015-09-10 22:14:59 +00:00
|
|
|
goto error;
|
2015-07-07 10:11:37 +00:00
|
|
|
|
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
|
|
|
VIR_DOMAIN_EVENT_DEFINED,
|
2015-09-10 22:14:59 +00:00
|
|
|
oldPersist ?
|
|
|
|
VIR_DOMAIN_EVENT_DEFINED_UPDATED :
|
|
|
|
VIR_DOMAIN_EVENT_DEFINED_ADDED);
|
2015-07-07 13:33:53 +00:00
|
|
|
qemuDomainEventQueue(driver, event);
|
2015-07-07 10:11:37 +00:00
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
cleanup:
|
2015-09-10 22:14:59 +00:00
|
|
|
virDomainDefFree(oldDef);
|
2015-07-07 10:11:37 +00:00
|
|
|
virObjectUnref(caps);
|
|
|
|
virObjectUnref(cfg);
|
|
|
|
return ret;
|
2015-09-10 22:14:59 +00:00
|
|
|
|
|
|
|
error:
|
|
|
|
virDomainDefFree(vm->newDef);
|
|
|
|
vm->persistent = oldPersist;
|
|
|
|
vm->newDef = oldDef;
|
|
|
|
oldDef = NULL;
|
|
|
|
goto cleanup;
|
2015-07-07 10:11:37 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-01-31 10:47:03 +00:00
|
|
|
virDomainPtr
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationFinish(virQEMUDriverPtr driver,
|
2011-01-31 10:47:03 +00:00
|
|
|
virConnectPtr dconn,
|
|
|
|
virDomainObjPtr vm,
|
2011-01-24 18:06:16 +00:00
|
|
|
const char *cookiein,
|
|
|
|
int cookieinlen,
|
|
|
|
char **cookieout,
|
|
|
|
int *cookieoutlen,
|
2011-01-31 10:47:03 +00:00
|
|
|
unsigned long flags,
|
2011-05-23 12:50:11 +00:00
|
|
|
int retcode,
|
|
|
|
bool v3proto)
|
2011-01-31 10:47:03 +00:00
|
|
|
{
|
|
|
|
virDomainPtr dom = NULL;
|
2011-01-24 18:06:16 +00:00
|
|
|
qemuMigrationCookiePtr mig = NULL;
|
2011-07-19 00:27:31 +00:00
|
|
|
virErrorPtr orig_err = NULL;
|
2011-09-15 13:13:11 +00:00
|
|
|
int cookie_flags = 0;
|
2011-10-04 07:11:35 +00:00
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
2013-01-10 21:03:14 +00:00
|
|
|
virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
|
2013-11-06 03:36:57 +00:00
|
|
|
unsigned short port;
|
2015-12-15 12:19:08 +00:00
|
|
|
unsigned long long timeReceived = 0;
|
|
|
|
virObjectEventPtr event;
|
2016-01-08 16:03:48 +00:00
|
|
|
int rc;
|
2016-02-18 13:02:15 +00:00
|
|
|
qemuDomainJobInfoPtr jobInfo = NULL;
|
2015-11-26 14:37:23 +00:00
|
|
|
bool inPostCopy = false;
|
2016-04-12 13:41:28 +00:00
|
|
|
bool doKill = true;
|
2011-07-19 00:27:31 +00:00
|
|
|
|
2011-05-20 10:03:04 +00:00
|
|
|
VIR_DEBUG("driver=%p, dconn=%p, vm=%p, cookiein=%s, cookieinlen=%d, "
|
2011-07-08 15:18:48 +00:00
|
|
|
"cookieout=%p, cookieoutlen=%p, flags=%lx, retcode=%d",
|
2011-05-20 10:03:04 +00:00
|
|
|
driver, dconn, vm, NULLSTR(cookiein), cookieinlen,
|
|
|
|
cookieout, cookieoutlen, flags, retcode);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2013-11-06 03:36:57 +00:00
|
|
|
port = priv->migrationPort;
|
|
|
|
priv->migrationPort = 0;
|
|
|
|
|
2015-07-02 06:26:48 +00:00
|
|
|
if (!qemuMigrationJobIsActive(vm, QEMU_ASYNC_JOB_MIGRATION_IN)) {
|
|
|
|
qemuMigrationErrorReport(driver, vm->def->name);
|
2011-01-31 10:47:03 +00:00
|
|
|
goto cleanup;
|
2015-07-02 06:26:48 +00:00
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
ignore_value(virTimeMillisNow(&timeReceived));
|
|
|
|
|
2011-07-19 00:27:31 +00:00
|
|
|
qemuMigrationJobStartPhase(driver, vm,
|
|
|
|
v3proto ? QEMU_MIGRATION_PHASE_FINISH3
|
|
|
|
: QEMU_MIGRATION_PHASE_FINISH2);
|
2011-01-24 18:06:16 +00:00
|
|
|
|
2012-03-16 06:56:19 +00:00
|
|
|
qemuDomainCleanupRemove(vm, qemuMigrationPrepareCleanup);
|
2014-08-28 12:06:10 +00:00
|
|
|
VIR_FREE(priv->job.completed);
|
2012-03-16 06:56:19 +00:00
|
|
|
|
2014-08-28 12:06:10 +00:00
|
|
|
cookie_flags = QEMU_MIGRATION_COOKIE_NETWORK |
|
2014-11-04 09:52:10 +00:00
|
|
|
QEMU_MIGRATION_COOKIE_STATS |
|
|
|
|
QEMU_MIGRATION_COOKIE_NBD;
|
2011-09-15 13:13:11 +00:00
|
|
|
if (flags & VIR_MIGRATE_PERSIST_DEST)
|
|
|
|
cookie_flags |= QEMU_MIGRATION_COOKIE_PERSISTENT;
|
|
|
|
|
|
|
|
if (!(mig = qemuMigrationEatCookie(driver, vm, cookiein,
|
|
|
|
cookieinlen, cookie_flags)))
|
2011-07-19 00:27:31 +00:00
|
|
|
goto endjob;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2015-07-07 12:11:58 +00:00
|
|
|
if (flags & VIR_MIGRATE_OFFLINE) {
|
2015-12-15 12:19:08 +00:00
|
|
|
if (retcode == 0 &&
|
|
|
|
qemuMigrationPersist(driver, vm, mig, false) == 0)
|
|
|
|
dom = virGetDomain(dconn, vm->def->name, vm->def->uuid);
|
|
|
|
goto endjob;
|
|
|
|
}
|
2015-10-01 19:54:38 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
if (retcode != 0) {
|
|
|
|
qemuDomainJobInfo info;
|
2015-10-01 19:54:38 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
/* Check for a possible error on the monitor in case Finish was called
|
|
|
|
* earlier than monitor EOF handler got a chance to process the error
|
|
|
|
*/
|
|
|
|
qemuMigrationFetchJobStatus(driver, vm,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_IN,
|
|
|
|
&info);
|
|
|
|
goto endjob;
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
if (!virDomainObjIsActive(vm)) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("guest unexpectedly quit"));
|
|
|
|
qemuMigrationErrorReport(driver, vm->def->name);
|
|
|
|
goto endjob;
|
|
|
|
}
|
2015-07-07 12:42:42 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
if (qemuMigrationVPAssociatePortProfiles(vm->def) < 0)
|
|
|
|
goto endjob;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
if (mig->network && qemuDomainMigrateOPDRelocate(driver, vm, mig) < 0)
|
|
|
|
VIR_WARN("unable to provide network data for relocation");
|
2012-11-27 15:34:24 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
if (qemuMigrationStopNBDServer(driver, vm, mig) < 0)
|
|
|
|
goto endjob;
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2016-01-08 16:03:48 +00:00
|
|
|
if (qemuRefreshVirtioChannelState(driver, vm) < 0)
|
|
|
|
goto endjob;
|
|
|
|
|
|
|
|
if ((rc = qemuConnectAgent(driver, vm)) < 0) {
|
|
|
|
if (rc == -2)
|
|
|
|
goto endjob;
|
|
|
|
|
|
|
|
VIR_WARN("Cannot connect to QEMU guest agent for %s",
|
|
|
|
vm->def->name);
|
|
|
|
virResetLastError();
|
|
|
|
priv->agentError = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
if (flags & VIR_MIGRATE_PERSIST_DEST) {
|
|
|
|
if (qemuMigrationPersist(driver, vm, mig, !v3proto) < 0) {
|
|
|
|
/* Hmpf. Migration was successful, but making it persistent
|
|
|
|
* was not. If we report successful, then when this domain
|
|
|
|
* shuts down, management tools are in for a surprise. On the
|
|
|
|
* other hand, if we report failure, then the management tools
|
|
|
|
* might try to restart the domain on the source side, even
|
|
|
|
* though the domain is actually running on the destination.
|
|
|
|
* Pretend success and hope that this is a rare situation and
|
|
|
|
* management tools are smart.
|
|
|
|
*
|
|
|
|
* However, in v3 protocol, the source VM is still available
|
|
|
|
* to restart during confirm() step, so we kill it off now.
|
2015-10-15 17:49:22 +00:00
|
|
|
*/
|
|
|
|
if (v3proto)
|
|
|
|
goto endjob;
|
2015-10-02 10:08:26 +00:00
|
|
|
}
|
2015-12-15 12:19:08 +00:00
|
|
|
}
|
2015-10-02 10:08:26 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
/* We need to wait for QEMU to process all data sent by the source
|
|
|
|
* before starting guest CPUs.
|
|
|
|
*/
|
|
|
|
if (qemuMigrationWaitForDestCompletion(driver, vm,
|
2015-11-26 14:37:23 +00:00
|
|
|
QEMU_ASYNC_JOB_MIGRATION_IN,
|
|
|
|
!!(flags & VIR_MIGRATE_POSTCOPY)) < 0) {
|
2015-12-15 12:19:08 +00:00
|
|
|
/* There's not much we can do for v2 protocol since the
|
|
|
|
* original domain on the source host is already gone.
|
|
|
|
*/
|
|
|
|
if (v3proto)
|
|
|
|
goto endjob;
|
|
|
|
}
|
2015-10-01 19:39:35 +00:00
|
|
|
|
2015-11-26 14:37:23 +00:00
|
|
|
if (priv->job.current->stats.status == QEMU_MONITOR_MIGRATION_STATUS_POSTCOPY)
|
|
|
|
inPostCopy = true;
|
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
if (!(flags & VIR_MIGRATE_PAUSED)) {
|
|
|
|
/* run 'cont' on the destination, which allows migration on qemu
|
|
|
|
* >= 0.10.6 to work properly. This isn't strictly necessary on
|
|
|
|
* older qemu's, but it also doesn't hurt anything there
|
|
|
|
*/
|
|
|
|
if (qemuProcessStartCPUs(driver, vm, dconn,
|
2015-11-26 14:37:23 +00:00
|
|
|
inPostCopy ? VIR_DOMAIN_RUNNING_POSTCOPY
|
|
|
|
: VIR_DOMAIN_RUNNING_MIGRATED,
|
2015-12-15 12:19:08 +00:00
|
|
|
QEMU_ASYNC_JOB_MIGRATION_IN) < 0) {
|
|
|
|
if (virGetLastError() == NULL)
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
|
|
"%s", _("resume operation failed"));
|
|
|
|
/* Need to save the current error, in case shutting
|
|
|
|
* down the process overwrites it
|
|
|
|
*/
|
|
|
|
orig_err = virSaveLastError();
|
2015-10-01 19:54:38 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
/*
|
|
|
|
* In v3 protocol, the source VM is still available to
|
|
|
|
* restart during confirm() step, so we kill it off
|
|
|
|
* now.
|
|
|
|
* In v2 protocol, the source is dead, so we leave
|
|
|
|
* target in paused state, in case admin can fix
|
|
|
|
* things up.
|
|
|
|
*/
|
|
|
|
if (v3proto)
|
|
|
|
goto endjob;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
2015-11-26 14:37:23 +00:00
|
|
|
|
|
|
|
if (inPostCopy) {
|
2016-04-12 13:41:28 +00:00
|
|
|
doKill = false;
|
2015-11-26 14:37:23 +00:00
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
|
|
|
VIR_DOMAIN_EVENT_RESUMED,
|
|
|
|
VIR_DOMAIN_EVENT_RESUMED_POSTCOPY);
|
|
|
|
qemuDomainEventQueue(driver, event);
|
|
|
|
}
|
2015-12-15 12:19:08 +00:00
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
if (mig->jobInfo) {
|
2016-02-18 13:02:15 +00:00
|
|
|
jobInfo = mig->jobInfo;
|
2015-12-15 12:19:08 +00:00
|
|
|
mig->jobInfo = NULL;
|
|
|
|
|
|
|
|
if (jobInfo->sent && timeReceived) {
|
|
|
|
jobInfo->timeDelta = timeReceived - jobInfo->sent;
|
|
|
|
jobInfo->received = timeReceived;
|
|
|
|
jobInfo->timeDeltaSet = true;
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
2016-02-18 13:02:15 +00:00
|
|
|
qemuDomainJobInfoUpdateTime(jobInfo);
|
|
|
|
qemuDomainJobInfoUpdateDowntime(jobInfo);
|
2015-12-15 12:19:08 +00:00
|
|
|
}
|
2012-11-21 08:28:49 +00:00
|
|
|
|
2015-11-26 14:37:23 +00:00
|
|
|
if (inPostCopy) {
|
|
|
|
if (qemuMigrationWaitForDestCompletion(driver, vm,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_IN,
|
|
|
|
false) < 0) {
|
|
|
|
goto endjob;
|
|
|
|
}
|
|
|
|
if (virDomainObjGetState(vm, NULL) == VIR_DOMAIN_RUNNING) {
|
|
|
|
virDomainObjSetState(vm,
|
|
|
|
VIR_DOMAIN_RUNNING,
|
|
|
|
VIR_DOMAIN_RUNNING_MIGRATED);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
dom = virGetDomain(dconn, vm->def->name, vm->def->uuid);
|
2011-06-23 10:03:57 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
|
|
|
VIR_DOMAIN_EVENT_RESUMED,
|
|
|
|
VIR_DOMAIN_EVENT_RESUMED_MIGRATED);
|
|
|
|
qemuDomainEventQueue(driver, event);
|
2015-07-02 19:46:56 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
if (virDomainObjGetState(vm, NULL) == VIR_DOMAIN_PAUSED) {
|
|
|
|
virDomainObjSetState(vm, VIR_DOMAIN_PAUSED, VIR_DOMAIN_PAUSED_USER);
|
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
|
|
|
VIR_DOMAIN_EVENT_SUSPENDED,
|
|
|
|
VIR_DOMAIN_EVENT_SUSPENDED_PAUSED);
|
|
|
|
qemuDomainEventQueue(driver, event);
|
2015-07-07 12:42:42 +00:00
|
|
|
}
|
2015-07-02 19:46:56 +00:00
|
|
|
|
2015-12-15 12:19:08 +00:00
|
|
|
if (virDomainObjIsActive(vm) &&
|
2016-02-04 12:32:45 +00:00
|
|
|
virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0)
|
2015-12-15 12:19:08 +00:00
|
|
|
VIR_WARN("Failed to save status on vm %s", vm->def->name);
|
|
|
|
|
|
|
|
/* Guest is successfully running, so cancel previous auto destroy */
|
|
|
|
qemuProcessAutoDestroyRemove(driver, vm);
|
|
|
|
|
2015-07-07 12:42:42 +00:00
|
|
|
endjob:
|
2015-07-07 13:29:10 +00:00
|
|
|
if (!dom &&
|
2015-07-07 12:42:42 +00:00
|
|
|
!(flags & VIR_MIGRATE_OFFLINE) &&
|
|
|
|
virDomainObjIsActive(vm)) {
|
2016-04-12 13:41:28 +00:00
|
|
|
if (doKill) {
|
2016-01-13 15:29:58 +00:00
|
|
|
qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED,
|
|
|
|
QEMU_ASYNC_JOB_MIGRATION_IN,
|
|
|
|
VIR_QEMU_PROCESS_STOP_MIGRATED);
|
|
|
|
virDomainAuditStop(vm, "failed");
|
|
|
|
event = virDomainEventLifecycleNewFromObj(vm,
|
|
|
|
VIR_DOMAIN_EVENT_STOPPED,
|
|
|
|
VIR_DOMAIN_EVENT_STOPPED_FAILED);
|
|
|
|
qemuDomainEventQueue(driver, event);
|
|
|
|
} else {
|
|
|
|
qemuMigrationPostcopyFailed(driver, vm);
|
|
|
|
}
|
2011-01-31 10:47:03 +00:00
|
|
|
}
|
|
|
|
|
2016-02-18 13:02:15 +00:00
|
|
|
if (dom) {
|
|
|
|
priv->job.completed = jobInfo;
|
|
|
|
jobInfo = NULL;
|
|
|
|
if (qemuMigrationBakeCookie(mig, driver, vm, cookieout, cookieoutlen,
|
|
|
|
QEMU_MIGRATION_COOKIE_STATS) < 0)
|
|
|
|
VIR_WARN("Unable to encode migration cookie");
|
2015-11-26 14:37:23 +00:00
|
|
|
|
|
|
|
/* Remove completed stats for post-copy, everything but timing fields
|
|
|
|
* is obsolete anyway.
|
|
|
|
*/
|
|
|
|
if (inPostCopy)
|
|
|
|
VIR_FREE(priv->job.completed);
|
2016-02-18 13:02:15 +00:00
|
|
|
}
|
2011-01-24 18:06:16 +00:00
|
|
|
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
qemuMigrationJobFinish(driver, vm);
|
2015-09-22 13:25:00 +00:00
|
|
|
if (!virDomainObjIsActive(vm))
|
2011-09-22 06:02:03 +00:00
|
|
|
qemuDomainRemoveInactive(driver, vm);
|
2011-01-31 10:47:03 +00:00
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2016-02-18 13:02:15 +00:00
|
|
|
VIR_FREE(jobInfo);
|
2013-11-06 03:36:57 +00:00
|
|
|
virPortAllocatorRelease(driver->migrationPorts, port);
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
if (priv->mon)
|
2015-11-12 13:54:04 +00:00
|
|
|
qemuMonitorSetDomainLog(priv->mon, NULL, NULL, NULL);
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
VIR_FREE(priv->origname);
|
2015-04-23 15:27:58 +00:00
|
|
|
virDomainObjEndAPI(&vm);
|
2015-09-10 22:14:59 +00:00
|
|
|
if (mig) {
|
|
|
|
virDomainDefFree(qemuMigrationCookieGetPersistent(mig));
|
|
|
|
qemuMigrationCookieFree(mig);
|
|
|
|
}
|
2011-05-23 16:48:36 +00:00
|
|
|
if (orig_err) {
|
|
|
|
virSetError(orig_err);
|
|
|
|
virFreeError(orig_err);
|
|
|
|
}
|
2013-01-10 21:03:14 +00:00
|
|
|
virObjectUnref(cfg);
|
2015-07-02 20:32:54 +00:00
|
|
|
|
|
|
|
/* Set a special error if Finish is expected to return NULL as a result of
|
|
|
|
* successful call with retcode != 0
|
|
|
|
*/
|
|
|
|
if (retcode != 0 && !dom && !virGetLastError())
|
|
|
|
virReportError(VIR_ERR_MIGRATE_FINISH_OK, NULL);
|
2011-01-31 10:47:03 +00:00
|
|
|
return dom;
|
|
|
|
}
|
2011-03-10 00:35:13 +00:00
|
|
|
|
2011-02-03 11:09:28 +00:00
|
|
|
|
2013-02-06 18:17:20 +00:00
|
|
|
/* Helper function called while vm is active. */
|
2011-03-10 00:35:13 +00:00
|
|
|
int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationToFile(virQEMUDriverPtr driver, virDomainObjPtr vm,
|
2016-02-15 16:17:02 +00:00
|
|
|
int fd,
|
2011-03-10 00:35:13 +00:00
|
|
|
const char *compressor,
|
2014-06-15 16:32:56 +00:00
|
|
|
qemuDomainAsyncJob asyncJob)
|
2011-03-10 00:35:13 +00:00
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
int rc;
|
2013-07-08 10:08:46 +00:00
|
|
|
int ret = -1;
|
2011-03-25 17:02:27 +00:00
|
|
|
virCommandPtr cmd = NULL;
|
|
|
|
int pipeFD[2] = { -1, -1 };
|
2012-03-20 15:56:29 +00:00
|
|
|
unsigned long saveMigBandwidth = priv->migMaxBandwidth;
|
2013-01-17 10:59:23 +00:00
|
|
|
char *errbuf = NULL;
|
2014-05-22 10:38:47 +00:00
|
|
|
virErrorPtr orig_err = NULL;
|
2012-03-20 15:56:29 +00:00
|
|
|
|
|
|
|
/* Increase migration bandwidth to unlimited since target is a file.
|
|
|
|
* Failure to change migration speed is not fatal. */
|
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) == 0) {
|
|
|
|
qemuMonitorSetMigrationSpeed(priv->mon,
|
2012-08-03 16:34:06 +00:00
|
|
|
QEMU_DOMAIN_MIG_BANDWIDTH_MAX);
|
|
|
|
priv->migMaxBandwidth = QEMU_DOMAIN_MIG_BANDWIDTH_MAX;
|
2014-12-16 09:40:58 +00:00
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0)
|
|
|
|
return -1;
|
2012-03-20 15:56:29 +00:00
|
|
|
}
|
2011-03-10 00:35:13 +00:00
|
|
|
|
2014-08-12 13:21:56 +00:00
|
|
|
if (!virDomainObjIsActive(vm)) {
|
|
|
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
|
_("guest unexpectedly quit"));
|
|
|
|
/* nothing to tear down */
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2016-02-15 16:17:02 +00:00
|
|
|
if (compressor && pipe(pipeFD) < 0) {
|
|
|
|
virReportSystemError(errno, "%s",
|
|
|
|
_("Failed to create pipe for migration"));
|
|
|
|
return -1;
|
2011-03-10 00:35:13 +00:00
|
|
|
}
|
|
|
|
|
2016-02-15 16:17:02 +00:00
|
|
|
/* All right! We can use fd migration, which means that qemu
|
|
|
|
* doesn't have to open() the file, so while we still have to
|
|
|
|
* grant SELinux access, we can do it on fd and avoid cleanup
|
|
|
|
* later, as well as skip futzing with cgroup. */
|
|
|
|
if (virSecurityManagerSetImageFDLabel(driver->securityManager, vm->def,
|
|
|
|
compressor ? pipeFD[1] : fd) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
qemu: fix crash when mixing sync and async monitor jobs
Currently, we attempt to run sync job and async job at the same time. It
means that the monitor commands for two jobs can be run in any order.
In the function qemuDomainObjEnterMonitorInternal():
if (priv->job.active == QEMU_JOB_NONE && priv->job.asyncJob) {
if (qemuDomainObjBeginNestedJob(driver, obj) < 0)
We check whether the caller is an async job by priv->job.active and
priv->job.asynJob. But when an async job is running, and a sync job is
also running at the time of the check, then priv->job.active is not
QEMU_JOB_NONE. So we cannot check whether the caller is an async job
in the function qemuDomainObjEnterMonitorInternal(), and must instead
put the burden on the caller to tell us when an async command wants
to do a nested job.
Once the burden is on the caller, then only async monitor enters need
to worry about whether the VM is still running; for sync monitor enter,
the internal return is always 0, so lots of ignore_value can be dropped.
* src/qemu/THREADS.txt: Reflect new rules.
* src/qemu/qemu_domain.h (qemuDomainObjEnterMonitorAsync): New
prototype.
* src/qemu/qemu_process.h (qemuProcessStartCPUs)
(qemuProcessStopCPUs): Add parameter.
* src/qemu/qemu_migration.h (qemuMigrationToFile): Likewise.
(qemuMigrationWaitForCompletion): Make static.
* src/qemu/qemu_domain.c (qemuDomainObjEnterMonitorInternal): Add
parameter.
(qemuDomainObjEnterMonitorAsync): New function.
(qemuDomainObjEnterMonitor, qemuDomainObjEnterMonitorWithDriver):
Update callers.
* src/qemu/qemu_driver.c (qemuDomainSaveInternal)
(qemudDomainCoreDump, doCoreDump, processWatchdogEvent)
(qemudDomainSuspend, qemudDomainResume, qemuDomainSaveImageStartVM)
(qemuDomainSnapshotCreateActive, qemuDomainRevertToSnapshot):
Likewise.
* src/qemu/qemu_process.c (qemuProcessStopCPUs)
(qemuProcessFakeReboot, qemuProcessRecoverMigration)
(qemuProcessRecoverJob, qemuProcessStart): Likewise.
* src/qemu/qemu_migration.c (qemuMigrationToFile)
(qemuMigrationWaitForCompletion, qemuMigrationUpdateJobStatus)
(qemuMigrationJobStart, qemuDomainMigrateGraphicsRelocate)
(doNativeMigrate, doTunnelMigrate, qemuMigrationPerformJob)
(qemuMigrationPerformPhase, qemuMigrationFinish)
(qemuMigrationConfirm): Likewise.
* src/qemu/qemu_hotplug.c: Drop unneeded ignore_value.
2011-07-28 23:18:24 +00:00
|
|
|
if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
|
2011-06-30 09:23:50 +00:00
|
|
|
goto cleanup;
|
|
|
|
|
2011-03-10 00:35:13 +00:00
|
|
|
if (!compressor) {
|
2016-02-15 16:17:02 +00:00
|
|
|
rc = qemuMonitorMigrateToFd(priv->mon,
|
|
|
|
QEMU_MONITOR_MIGRATE_BACKGROUND,
|
|
|
|
fd);
|
2011-03-10 00:35:13 +00:00
|
|
|
} else {
|
|
|
|
const char *prog = compressor;
|
|
|
|
const char *args[] = {
|
|
|
|
prog,
|
|
|
|
"-c",
|
|
|
|
NULL
|
|
|
|
};
|
2016-02-15 16:17:02 +00:00
|
|
|
|
|
|
|
cmd = virCommandNewArgs(args);
|
|
|
|
virCommandSetInputFD(cmd, pipeFD[0]);
|
|
|
|
virCommandSetOutputFD(cmd, &fd);
|
|
|
|
virCommandSetErrorBuffer(cmd, &errbuf);
|
|
|
|
virCommandDoAsyncIO(cmd);
|
|
|
|
if (virSetCloseExec(pipeFD[1]) < 0) {
|
|
|
|
virReportSystemError(errno, "%s",
|
|
|
|
_("Unable to set cloexec flag"));
|
|
|
|
ignore_value(qemuDomainObjExitMonitor(driver, vm));
|
|
|
|
goto cleanup;
|
2011-03-25 17:02:27 +00:00
|
|
|
}
|
2016-02-15 16:17:02 +00:00
|
|
|
if (virCommandRunAsync(cmd, NULL) < 0) {
|
|
|
|
ignore_value(qemuDomainObjExitMonitor(driver, vm));
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
rc = qemuMonitorMigrateToFd(priv->mon,
|
|
|
|
QEMU_MONITOR_MIGRATE_BACKGROUND,
|
|
|
|
pipeFD[1]);
|
|
|
|
if (VIR_CLOSE(pipeFD[0]) < 0 ||
|
|
|
|
VIR_CLOSE(pipeFD[1]) < 0)
|
|
|
|
VIR_WARN("failed to close intermediate pipe");
|
2011-03-10 00:35:13 +00:00
|
|
|
}
|
2014-12-16 09:40:58 +00:00
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0)
|
2014-08-12 13:21:56 +00:00
|
|
|
goto cleanup;
|
2011-03-10 00:35:13 +00:00
|
|
|
if (rc < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
2015-12-17 12:46:18 +00:00
|
|
|
rc = qemuMigrationWaitForCompletion(driver, vm, asyncJob, NULL, 0);
|
2011-03-10 00:35:13 +00:00
|
|
|
|
2014-05-22 10:38:47 +00:00
|
|
|
if (rc < 0) {
|
|
|
|
if (rc == -2) {
|
|
|
|
orig_err = virSaveLastError();
|
|
|
|
virCommandAbort(cmd);
|
2014-08-12 13:21:56 +00:00
|
|
|
if (virDomainObjIsActive(vm) &&
|
|
|
|
qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) == 0) {
|
2014-05-22 10:38:47 +00:00
|
|
|
qemuMonitorMigrateCancel(priv->mon);
|
2014-12-16 09:40:58 +00:00
|
|
|
ignore_value(qemuDomainObjExitMonitor(driver, vm));
|
2014-05-22 10:38:47 +00:00
|
|
|
}
|
|
|
|
}
|
2011-03-10 00:35:13 +00:00
|
|
|
goto cleanup;
|
2014-05-22 10:38:47 +00:00
|
|
|
}
|
2011-03-10 00:35:13 +00:00
|
|
|
|
2011-03-25 17:02:27 +00:00
|
|
|
if (cmd && virCommandWait(cmd, NULL) < 0)
|
|
|
|
goto cleanup;
|
|
|
|
|
2016-02-17 23:12:33 +00:00
|
|
|
qemuDomainEventEmitJobCompleted(driver, vm);
|
2011-03-10 00:35:13 +00:00
|
|
|
ret = 0;
|
|
|
|
|
2014-03-25 06:49:44 +00:00
|
|
|
cleanup:
|
2014-05-22 10:38:47 +00:00
|
|
|
if (ret < 0 && !orig_err)
|
|
|
|
orig_err = virSaveLastError();
|
|
|
|
|
2012-03-20 15:56:29 +00:00
|
|
|
/* Restore max migration bandwidth */
|
2014-08-12 13:21:56 +00:00
|
|
|
if (virDomainObjIsActive(vm) &&
|
|
|
|
qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) == 0) {
|
2012-03-20 15:56:29 +00:00
|
|
|
qemuMonitorSetMigrationSpeed(priv->mon, saveMigBandwidth);
|
|
|
|
priv->migMaxBandwidth = saveMigBandwidth;
|
2014-12-16 09:40:58 +00:00
|
|
|
ignore_value(qemuDomainObjExitMonitor(driver, vm));
|
2012-03-20 15:56:29 +00:00
|
|
|
}
|
|
|
|
|
2011-03-25 17:02:27 +00:00
|
|
|
VIR_FORCE_CLOSE(pipeFD[0]);
|
|
|
|
VIR_FORCE_CLOSE(pipeFD[1]);
|
2013-01-17 10:59:23 +00:00
|
|
|
if (cmd) {
|
|
|
|
VIR_DEBUG("Compression binary stderr: %s", NULLSTR(errbuf));
|
|
|
|
VIR_FREE(errbuf);
|
|
|
|
virCommandFree(cmd);
|
|
|
|
}
|
2014-05-22 10:38:47 +00:00
|
|
|
|
|
|
|
if (orig_err) {
|
|
|
|
virSetError(orig_err);
|
|
|
|
virFreeError(orig_err);
|
|
|
|
}
|
|
|
|
|
2011-03-10 00:35:13 +00:00
|
|
|
return ret;
|
|
|
|
}
|
2011-07-19 00:27:30 +00:00
|
|
|
|
2015-05-19 15:28:25 +00:00
|
|
|
|
|
|
|
int
|
|
|
|
qemuMigrationCancel(virQEMUDriverPtr driver,
|
|
|
|
virDomainObjPtr vm)
|
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
virHashTablePtr blockJobs = NULL;
|
|
|
|
bool storage = false;
|
|
|
|
size_t i;
|
|
|
|
int ret = -1;
|
|
|
|
|
|
|
|
VIR_DEBUG("Canceling unfinished outgoing migration of domain %s",
|
|
|
|
vm->def->name);
|
|
|
|
|
|
|
|
for (i = 0; i < vm->def->ndisks; i++) {
|
|
|
|
virDomainDiskDefPtr disk = vm->def->disks[i];
|
|
|
|
if (QEMU_DOMAIN_DISK_PRIVATE(disk)->migrating) {
|
|
|
|
qemuBlockJobSyncBegin(disk);
|
|
|
|
storage = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
qemuDomainObjEnterMonitor(driver, vm);
|
|
|
|
|
|
|
|
ignore_value(qemuMonitorMigrateCancel(priv->mon));
|
|
|
|
if (storage)
|
|
|
|
blockJobs = qemuMonitorGetAllBlockJobInfo(priv->mon);
|
|
|
|
|
|
|
|
if (qemuDomainObjExitMonitor(driver, vm) < 0 || (storage && !blockJobs))
|
|
|
|
goto endsyncjob;
|
|
|
|
|
|
|
|
if (!storage) {
|
|
|
|
ret = 0;
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < vm->def->ndisks; i++) {
|
|
|
|
virDomainDiskDefPtr disk = vm->def->disks[i];
|
|
|
|
qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk);
|
|
|
|
|
|
|
|
if (!diskPriv->migrating)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (virHashLookup(blockJobs, disk->info.alias)) {
|
|
|
|
VIR_DEBUG("Drive mirror on disk %s is still running", disk->dst);
|
|
|
|
} else {
|
|
|
|
VIR_DEBUG("Drive mirror on disk %s is gone", disk->dst);
|
|
|
|
qemuBlockJobSyncEnd(driver, vm, disk);
|
|
|
|
diskPriv->migrating = false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (qemuMigrationCancelDriveMirror(driver, vm, false,
|
2015-06-01 12:41:50 +00:00
|
|
|
QEMU_ASYNC_JOB_NONE, NULL) < 0)
|
2015-05-19 15:28:25 +00:00
|
|
|
goto endsyncjob;
|
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
cleanup:
|
|
|
|
virHashFree(blockJobs);
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
endsyncjob:
|
|
|
|
if (storage) {
|
|
|
|
for (i = 0; i < vm->def->ndisks; i++) {
|
|
|
|
virDomainDiskDefPtr disk = vm->def->disks[i];
|
|
|
|
qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk);
|
|
|
|
|
|
|
|
if (diskPriv->migrating) {
|
|
|
|
qemuBlockJobSyncEnd(driver, vm, disk);
|
|
|
|
diskPriv->migrating = false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
goto cleanup;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2011-07-19 00:27:30 +00:00
|
|
|
int
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationJobStart(virQEMUDriverPtr driver,
|
2011-07-19 00:27:30 +00:00
|
|
|
virDomainObjPtr vm,
|
2014-06-15 16:32:56 +00:00
|
|
|
qemuDomainAsyncJob job)
|
2011-07-19 00:27:30 +00:00
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
|
2013-02-06 18:17:20 +00:00
|
|
|
if (qemuDomainObjBeginAsyncJob(driver, vm, job) < 0)
|
2011-07-19 00:27:30 +00:00
|
|
|
return -1;
|
|
|
|
|
2011-07-19 00:27:36 +00:00
|
|
|
if (job == QEMU_ASYNC_JOB_MIGRATION_IN) {
|
2011-07-19 00:27:30 +00:00
|
|
|
qemuDomainObjSetAsyncJobMask(vm, QEMU_JOB_NONE);
|
2011-07-19 00:27:36 +00:00
|
|
|
} else {
|
2014-09-03 11:16:41 +00:00
|
|
|
qemuDomainObjSetAsyncJobMask(vm, (QEMU_JOB_DEFAULT_MASK |
|
|
|
|
JOB_MASK(QEMU_JOB_SUSPEND) |
|
|
|
|
JOB_MASK(QEMU_JOB_MIGRATION_OP)));
|
2011-07-19 00:27:36 +00:00
|
|
|
}
|
2011-07-19 00:27:30 +00:00
|
|
|
|
2014-08-21 13:08:39 +00:00
|
|
|
priv->job.current->type = VIR_DOMAIN_JOB_UNBOUNDED;
|
2011-07-19 00:27:30 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationJobSetPhase(virQEMUDriverPtr driver,
|
2011-07-19 00:27:30 +00:00
|
|
|
virDomainObjPtr vm,
|
2014-06-15 16:32:56 +00:00
|
|
|
qemuMigrationJobPhase phase)
|
2011-07-19 00:27:30 +00:00
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
|
|
|
|
if (phase < priv->job.phase) {
|
|
|
|
VIR_ERROR(_("migration protocol going backwards %s => %s"),
|
|
|
|
qemuMigrationJobPhaseTypeToString(priv->job.phase),
|
|
|
|
qemuMigrationJobPhaseTypeToString(phase));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
qemuDomainObjSetJobPhase(driver, vm, phase);
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationJobStartPhase(virQEMUDriverPtr driver,
|
2011-07-19 00:27:30 +00:00
|
|
|
virDomainObjPtr vm,
|
2014-06-15 16:32:56 +00:00
|
|
|
qemuMigrationJobPhase phase)
|
2011-07-19 00:27:30 +00:00
|
|
|
{
|
|
|
|
qemuMigrationJobSetPhase(driver, vm, phase);
|
|
|
|
}
|
|
|
|
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
void
|
2011-07-19 00:27:30 +00:00
|
|
|
qemuMigrationJobContinue(virDomainObjPtr vm)
|
|
|
|
{
|
2012-04-06 16:55:46 +00:00
|
|
|
qemuDomainObjReleaseAsyncJob(vm);
|
2011-07-19 00:27:30 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
bool
|
|
|
|
qemuMigrationJobIsActive(virDomainObjPtr vm,
|
2014-06-15 16:32:56 +00:00
|
|
|
qemuDomainAsyncJob job)
|
2011-07-19 00:27:30 +00:00
|
|
|
{
|
|
|
|
qemuDomainObjPrivatePtr priv = vm->privateData;
|
|
|
|
|
|
|
|
if (priv->job.asyncJob != job) {
|
|
|
|
const char *msg;
|
|
|
|
|
|
|
|
if (job == QEMU_ASYNC_JOB_MIGRATION_IN)
|
|
|
|
msg = _("domain '%s' is not processing incoming migration");
|
|
|
|
else
|
|
|
|
msg = _("domain '%s' is not being migrated");
|
|
|
|
|
2012-07-18 15:22:03 +00:00
|
|
|
virReportError(VIR_ERR_OPERATION_INVALID, msg, vm->def->name);
|
2011-07-19 00:27:30 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
void
|
2012-11-28 16:43:10 +00:00
|
|
|
qemuMigrationJobFinish(virQEMUDriverPtr driver, virDomainObjPtr vm)
|
2011-07-19 00:27:30 +00:00
|
|
|
{
|
qemu: completely rework reference counting
There is one problem that causes various errors in the daemon. When
domain is waiting for a job, it is unlocked while waiting on the
condition. However, if that domain is for example transient and being
removed in another API (e.g. cancelling incoming migration), it get's
unref'd. If the first call, that was waiting, fails to get the job, it
unref's the domain object, and because it was the last reference, it
causes clearing of the whole domain object. However, when finishing the
call, the domain must be unlocked, but there is no way for the API to
know whether it was cleaned or not (unless there is some ugly temporary
variable, but let's scratch that).
The root cause is that our APIs don't ref the objects they are using and
all use the implicit reference that the object has when it is in the
domain list. That reference can be removed when the API is waiting for
a job. And because each domain doesn't do its ref'ing, it results in
the ugly checking of the return value of virObjectUnref() that we have
everywhere.
This patch changes qemuDomObjFromDomain() to ref the domain (using
virDomainObjListFindByUUIDRef()) and adds qemuDomObjEndAPI() which
should be the only function in which the return value of
virObjectUnref() is checked. This makes all reference counting
deterministic and makes the code a bit clearer.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-12-04 13:41:36 +00:00
|
|
|
qemuDomainObjEndAsyncJob(driver, vm);
|
2011-07-19 00:27:30 +00:00
|
|
|
}
|
2015-07-02 06:26:48 +00:00
|
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
qemuMigrationErrorFree(void *data,
|
|
|
|
const void *name ATTRIBUTE_UNUSED)
|
|
|
|
{
|
|
|
|
virErrorPtr err = data;
|
|
|
|
virFreeError(err);
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
qemuMigrationErrorInit(virQEMUDriverPtr driver)
|
|
|
|
{
|
|
|
|
driver->migrationErrors = virHashAtomicNew(64, qemuMigrationErrorFree);
|
|
|
|
if (driver->migrationErrors)
|
|
|
|
return 0;
|
|
|
|
else
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* This function consumes @err; the caller should consider the @err pointer
|
|
|
|
* invalid after calling this function.
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
qemuMigrationErrorSave(virQEMUDriverPtr driver,
|
|
|
|
const char *name,
|
|
|
|
virErrorPtr err)
|
|
|
|
{
|
|
|
|
if (!err)
|
|
|
|
return;
|
|
|
|
|
|
|
|
VIR_DEBUG("Saving incoming migration error for domain %s: %s",
|
|
|
|
name, err->message);
|
|
|
|
if (virHashAtomicUpdate(driver->migrationErrors, name, err) < 0) {
|
|
|
|
VIR_WARN("Failed to save migration error for domain '%s'", name);
|
|
|
|
virFreeError(err);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
qemuMigrationErrorReport(virQEMUDriverPtr driver,
|
|
|
|
const char *name)
|
|
|
|
{
|
|
|
|
virErrorPtr err;
|
|
|
|
|
|
|
|
if (!(err = virHashAtomicSteal(driver->migrationErrors, name)))
|
|
|
|
return;
|
|
|
|
|
|
|
|
VIR_DEBUG("Restoring saved incoming migration error for domain %s: %s",
|
|
|
|
name, err->message);
|
|
|
|
virSetError(err);
|
|
|
|
virFreeError(err);
|
|
|
|
}
|
2016-04-14 10:33:48 +00:00
|
|
|
|
|
|
|
|
|
|
|
/* don't ever pass NULL params with non zero nparams */
|
|
|
|
qemuMigrationCompressionPtr
|
|
|
|
qemuMigrationCompressionParse(virTypedParameterPtr params,
|
|
|
|
int nparams,
|
|
|
|
unsigned long flags)
|
|
|
|
{
|
|
|
|
size_t i;
|
|
|
|
qemuMigrationCompressionPtr compression = NULL;
|
2016-04-14 10:33:51 +00:00
|
|
|
qemuMonitorMigrationCompressionPtr cparams;
|
2016-04-14 10:33:48 +00:00
|
|
|
|
|
|
|
if (VIR_ALLOC(compression) < 0)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
for (i = 0; i < nparams; i++) {
|
|
|
|
int method;
|
|
|
|
|
|
|
|
if (STRNEQ(params[i].field, VIR_MIGRATE_PARAM_COMPRESSION))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
method = qemuMigrationCompressMethodTypeFromString(params[i].value.s);
|
|
|
|
if (method < 0) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG,
|
|
|
|
_("Unsupported compression method '%s'"),
|
|
|
|
params[i].value.s);
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (compression->methods & (1ULL << method)) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG,
|
|
|
|
_("Compression method '%s' is specified twice"),
|
|
|
|
params[i].value.s);
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
compression->methods |= 1ULL << method;
|
|
|
|
}
|
|
|
|
|
2016-04-14 10:33:51 +00:00
|
|
|
#define GET_PARAM(PARAM, TYPE, PARENT, VALUE) \
|
|
|
|
do { \
|
|
|
|
int rc; \
|
|
|
|
\
|
|
|
|
if ((rc = virTypedParamsGet ## TYPE(params, nparams, \
|
|
|
|
PARAM, &PARENT->VALUE)) < 0) \
|
|
|
|
goto error; \
|
|
|
|
\
|
|
|
|
if (rc == 1) \
|
|
|
|
PARENT->VALUE ## _set = true; \
|
|
|
|
} while (0)
|
|
|
|
|
|
|
|
cparams = &compression->params;
|
|
|
|
|
|
|
|
if (params) {
|
|
|
|
GET_PARAM(VIR_MIGRATE_PARAM_COMPRESSION_MT_LEVEL, Int,
|
|
|
|
cparams, level);
|
|
|
|
GET_PARAM(VIR_MIGRATE_PARAM_COMPRESSION_MT_THREADS, Int,
|
|
|
|
cparams, threads);
|
|
|
|
GET_PARAM(VIR_MIGRATE_PARAM_COMPRESSION_MT_DTHREADS, Int,
|
|
|
|
cparams, dthreads);
|
|
|
|
GET_PARAM(VIR_MIGRATE_PARAM_COMPRESSION_XBZRLE_CACHE, ULLong,
|
|
|
|
compression, xbzrle_cache);
|
|
|
|
}
|
|
|
|
|
|
|
|
#undef GET_PARAM
|
|
|
|
|
|
|
|
if ((cparams->level_set || cparams->threads_set || cparams->dthreads_set) &&
|
|
|
|
!(compression->methods & (1ULL << QEMU_MIGRATION_COMPRESS_MT))) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG, "%s",
|
|
|
|
_("Turn multithread compression on to tune it"));
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (compression->xbzrle_cache_set &&
|
|
|
|
!(compression->methods & (1ULL << QEMU_MIGRATION_COMPRESS_XBZRLE))) {
|
|
|
|
virReportError(VIR_ERR_INVALID_ARG, "%s",
|
|
|
|
_("Turn xbzrle compression on to tune it"));
|
|
|
|
goto error;
|
|
|
|
}
|
|
|
|
|
2016-04-14 10:33:48 +00:00
|
|
|
if (!compression->methods && (flags & VIR_MIGRATE_COMPRESSED))
|
|
|
|
compression->methods = 1ULL << QEMU_MIGRATION_COMPRESS_XBZRLE;
|
|
|
|
|
|
|
|
return compression;
|
|
|
|
|
|
|
|
error:
|
|
|
|
VIR_FREE(compression);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
qemuMigrationCompressionDump(qemuMigrationCompressionPtr compression,
|
|
|
|
virTypedParameterPtr *params,
|
|
|
|
int *nparams,
|
|
|
|
int *maxparams,
|
|
|
|
unsigned long *flags)
|
|
|
|
{
|
|
|
|
size_t i;
|
2016-04-14 10:33:51 +00:00
|
|
|
qemuMonitorMigrationCompressionPtr cparams = &compression->params;
|
2016-04-14 10:33:48 +00:00
|
|
|
|
2016-04-14 10:33:51 +00:00
|
|
|
if (compression->methods == 1ULL << QEMU_MIGRATION_COMPRESS_XBZRLE &&
|
|
|
|
!compression->xbzrle_cache_set) {
|
2016-04-14 10:33:48 +00:00
|
|
|
*flags |= VIR_MIGRATE_COMPRESSED;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < QEMU_MIGRATION_COMPRESS_LAST; ++i) {
|
|
|
|
if ((compression->methods & (1ULL << i)) &&
|
|
|
|
virTypedParamsAddString(params, nparams, maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_COMPRESSION,
|
|
|
|
qemuMigrationCompressMethodTypeToString(i)) < 0)
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2016-04-14 10:33:51 +00:00
|
|
|
if (cparams->level_set &&
|
|
|
|
virTypedParamsAddInt(params, nparams, maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_COMPRESSION_MT_LEVEL,
|
|
|
|
cparams->level) < 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
if (cparams->threads_set &&
|
|
|
|
virTypedParamsAddInt(params, nparams, maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_COMPRESSION_MT_THREADS,
|
|
|
|
cparams->threads) < 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
if (cparams->dthreads_set &&
|
|
|
|
virTypedParamsAddInt(params, nparams, maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_COMPRESSION_MT_DTHREADS,
|
|
|
|
cparams->dthreads) < 0)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
if (compression->xbzrle_cache_set &&
|
|
|
|
virTypedParamsAddULLong(params, nparams, maxparams,
|
|
|
|
VIR_MIGRATE_PARAM_COMPRESSION_XBZRLE_CACHE,
|
|
|
|
compression->xbzrle_cache) < 0)
|
|
|
|
return -1;
|
|
|
|
|
2016-04-14 10:33:48 +00:00
|
|
|
return 0;
|
|
|
|
}
|